Kazu Hirata [Tue, 26 Jul 2022 03:52:22 +0000 (20:52 -0700)]
[flang] Remove unused variable lastPrivBlock (NFC)
This fixes the warning:
llvm-project/flang/lib/Lower/OpenMP.cpp:94:10: error: unused
variable 'lastPrivBlock' [-Werror,-Wunused-variable]
Sunho Kim [Tue, 26 Jul 2022 03:51:33 +0000 (12:51 +0900)]
[JITLink][COFF] Implement IMAGE_COMDAT_SELECT_LARGEST partially.
Implement IMAGE_COMDAT_SELECT_LARGEST partially. It's going to fail if larger symbol appears but this hasn't happened at least in vcruntime library.
We probably would not implement this properly as it requires complicated runtime patching which is not of nature of JIT. However, we'd like to validate if larger section appears and report to the user in the near future.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129941
Sunho Kim [Tue, 26 Jul 2022 03:46:34 +0000 (12:46 +0900)]
[JITLink][COFF] Implement IMAGE_WEAK_EXTERN_SEARCH_NOLIBRARY/LIBRARY.
Implement IMAGE_WEAK_EXTERN_SEARCH_NOLIBRARY/LIBRARY characteristics flag.
Since COFFObjectFile class will set undefined flag for symbols with no alias flag, ORC ObjectFileInterface will not pull in this symbol. So, we only need to make sure the scope is local. NOLIBRARY and LIBRARY are handled in the same way for now. (which is what lld does right now)
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129939
Sunho Kim [Tue, 26 Jul 2022 03:44:04 +0000 (12:44 +0900)]
[JITLink][COFF] Handle duplicate external symbols.
Handles duplicate external symbols. This happens in few static libraries generaed from msvc toolchain.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129937
Weverything [Tue, 26 Jul 2022 03:26:19 +0000 (20:26 -0700)]
John Ericson [Mon, 25 Jul 2022 21:17:34 +0000 (21:17 +0000)]
[llvm][cmake] Make `install_symlink` workflow work with absolute install dirs
If `CMAKE_INSTALL_BINDIR` is a different absolute path per project, as
it is with NixOS when we install every package to its own prefix, the
old way fails when the absolute path gets prepended with `CMAKE_INSTALL_PREFIX`.
The `extend_path` function does what we want, but it is currently internal-only. So easier to just inline the one small case of it we need.
Also fix one stray `bin` -> `CMAKE_INSTALL_BINDIR`
Reviewed By: sebastian-ne
Differential Revision: https://reviews.llvm.org/D101070
jacquesguan [Thu, 14 Jul 2022 02:41:42 +0000 (10:41 +0800)]
[DAGCombiner] Teach scalarizeExtractedBinop to support scalable splat.
This patch supports the scalable splat part for scalarizeExtractedBinop.
Differential Revision: https://reviews.llvm.org/D129725
Slava Gurevich [Tue, 26 Jul 2022 01:23:19 +0000 (18:23 -0700)]
Revert "[LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2"
This reverts commit
b9aedd94e6796e4b4866ab4c091b736b3db58cb7.
jacquesguan [Mon, 25 Jul 2022 10:11:53 +0000 (18:11 +0800)]
[mlir][Math] Add constant folder for Exp2Op.
This patch adds constant folder for Exp2Op which only supports single and double precision floating-point.
Differential Revision: https://reviews.llvm.org/D130472
Jacques Pienaar [Tue, 26 Jul 2022 00:41:17 +0000 (17:41 -0700)]
[mlir] SCCP add missing pessimistic setting
When this was updated in D127139 the update in-place case was no longer
marked as pessimistic. Add back in.
Differential Revision: https://reviews.llvm.org/D130453
River Riddle [Tue, 19 Jul 2022 23:12:02 +0000 (16:12 -0700)]
[mlir][Parser] Fix memory leak when failing to parse a forward declared block
This commit fixes a failure edge case where we accidentally drop forward
declared blocks in the error case. This allows for running the
invalid.mlir test in asan mode now.
Fixes #51387
Differential Revision: https://reviews.llvm.org/D130132
Arnamoy Bhattacharyya [Tue, 26 Jul 2022 00:31:23 +0000 (20:31 -0400)]
[Flang][OpenMP] Add support for lastprivate clause for worksharing loop.
This patch adds an initial support to the lastprivate clause for worksharing loop. The patch creates necessary control flow to guarantee the store of the value from the logical last iteration of the workshare loop.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D130027
Daniel Bertalan [Mon, 25 Jul 2022 22:51:28 +0000 (00:51 +0200)]
[lld-macho] Implement -hidden-l
Similarly to -load_hidden, this flag instructs the linker to not export
symbols from the specified archive. While that flag takes a path,
-hidden-l looks for the specified library name in the search path.
The test changes are needed because -hidden-lfoo resolves to libfoo.a,
not foo.a.
Differential Revision: https://reviews.llvm.org/D130529
Slava Gurevich [Mon, 25 Jul 2022 22:52:21 +0000 (15:52 -0700)]
[LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2
Improve LLDB reliability by fixing the following "uninitialized variables" static code inspection warnings from
scan.coverity.com:
1476275, 1274012, 1455035, 1364789, 1454282
1467483, 1406152, 1406255, 1454837, 1454416
1467446, 1462022, 1461909, 1420566, 1327228
1367767, 1431254, 1467299, 1312678, 1431780
1454731, 1490403
Differential Revision: https://reviews.llvm.org/D130528
River Riddle [Sun, 10 Jul 2022 08:00:21 +0000 (01:00 -0700)]
[mlir] Refactor the Parser library in preparation for an MLIR binary format
The current Parser library is solely focused on providing API for
the textual MLIR format, but MLIR will soon also provide a binary
format. This commit renames the current Parser library to AsmParser to
better correspond to what the library is actually intended for. A new
Parser library is added which will act as a unified parser interface
between both text and binary formats. Most parser clients are
unaffected, given that the unified interface is essentially the same as
the current interface. Only clients that rely on utilizing the
AsmParserState, or those that want to parse Attributes/Types need to be
updated to point to the AsmParser library.
Differential Revision: https://reviews.llvm.org/D129605
Amara Emerson [Mon, 25 Jul 2022 22:13:49 +0000 (15:13 -0700)]
[GlobalISel] Fix miscompile of G_UREM + G_UDIV due to not checking for equality
of the first operands of each.
Fixes issue #55287
Differential Revision: https://reviews.llvm.org/D130525
Shafik Yaghmour [Mon, 25 Jul 2022 22:56:44 +0000 (15:56 -0700)]
[Clang] Fix how we set the NumPositiveBits on an EnumDecl to cover the case of single enumerator with value zero or an empty enum
Currently in Sema::ActOnEnumBody(...) when calculating NumPositiveBits we miss
the case where there is only a single enumerator with value zero and the case of
an empty enum. In both cases we end up with zero positive bits when in fact we
need one bit to store the value zero.
This PR updates the calculation to account for these cases.
Differential Revision: https://reviews.llvm.org/D130301
Craig Topper [Mon, 25 Jul 2022 22:42:42 +0000 (15:42 -0700)]
[RISCV] Refactor translateSetCCForBranch to prepare for D130508. NFC.
D130508 handles more constants than just 1 or -1. We need to extract
the constant instead of relying isOneConstant or isAllOnesConstant.
Alexander Shaposhnikov [Mon, 25 Jul 2022 22:51:25 +0000 (22:51 +0000)]
[IRBuilder] Add assert for AtomicRMW ordering
Add assert for AtomicRMW: Ordering != AtomicOrdering::Unordered
(https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L3944)
and adjust expandAtomicStore accordingly.
Test plan:
1/ ninja check-llvm check-clang check-lld
2/ Bootstrapped LLVM/Clang pass tests
Differential revision: https://reviews.llvm.org/D130457
Fabian Parzefall [Mon, 25 Jul 2022 21:48:48 +0000 (14:48 -0700)]
[BOLT] Process each block only once in fixCFGForPIC
Rather than iterating over the whole function from the start until no
internal calls are found, process each block only once and continue
processing after splitting. This version of the function also does not
seemingly invalidate iterators from within the loop.
Reviewed By: maksfb
Differential Revision: https://reviews.llvm.org/D130436
Fangrui Song [Mon, 25 Jul 2022 22:05:38 +0000 (15:05 -0700)]
[Driver] Ignore unimplemented -mtune= for ARM/PowerPC
This compensates for
8f0c901c1a172313a32bc06a1fcface76cd1220f which enabled
-Wunused-command-line-argument for unimplemented -mtune= in the generic code.
Ignoring -mtune= appears to be longstanding and the error-free behavior in the
presence of -Werror is unfortunately relied on by the Linux kernel's arm and
powerpc ports. Ignore the warnings for the upcoming 15.0.0 branch and will
implement functionality to fill the test gap soon.
Link: https://github.com/ClangBuiltLinux/linux/issues/1674
lipracer [Mon, 25 Jul 2022 21:33:51 +0000 (15:33 -0600)]
[mlir][NFC] Remove TypeRange's constructors that cause ambiguity
ArrayRef<Value> can implicit convert to ValueRange,when we call TypeRange(SmallVector<Value>) is ambiguity.
TypeRange(ValueRange values)
TypeRange(ArrayRef<Value> values)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D129475
lipracer [Mon, 25 Jul 2022 20:42:18 +0000 (14:42 -0600)]
Split class ValueRange to a new file
When we apply parent patch : https://reviews.llvm.org/D129475
The prompt I get with the clang compiler is: ValueRange is imcomplete type,ValueRange is a forward declaration in the file TypeRange.h, and the file OperationSupport.h already includes the file TypeRange.h.The class TypeRange and the class ValueRange depend on each other.
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D130332
Augie Fackler [Wed, 30 Mar 2022 18:14:53 +0000 (14:14 -0400)]
MemoryBuiltins: remove malloc-family funcs from list
We no longer need specialized knowledge of these allocator functions in
this file since we have the correct attributes available now.
As far as I can tell the changes in the attributor tests are due to
things getting more consistent on alloc-family once we remove the static
list entries.
The two test changes in NewGVN merit extra scrutiny: NewGVN appears to
be _extremely_ sensitive to the inaccessiblememonly for reasons that
are beyond me. As a result, I had-enumerated all the attributes on
allocation functions in those two tests instead of using -inferattrs.
I assumed that the two -disable-simplify-libcalls tests there no
longer are sensible since the function declaration now includes all the
relevant attributes.
Differential Revision: https://reviews.llvm.org/D130107
Augie Fackler [Fri, 18 Mar 2022 20:26:24 +0000 (16:26 -0400)]
tests: add attributes that would normally come from inferattrs
As my goal is to remove at least _some_ functions from the static list
in MemoryBuiltins.cpp, these tests either need to run inferattrs or
statically declare these attributes to keep passing. A couple of tests
had alternate cases which are no longer meaningful, e.g.
`malloc-load-removal.ll`.
Differential Revision: https://reviews.llvm.org/D123087
John Ericson [Mon, 25 Jul 2022 21:15:14 +0000 (21:15 +0000)]
Revert "[llvm][cmake] Make `install_symlink` workflow work with absolute install dirs"
`ExtendPath` needs to be moved from internal to external CMake if it is
to be used to `AddLLVM`. See, for example, the failure in
https://lab.llvm.org/buildbot#builders/61/builds/29940
This reverts commit
5acd376438a53747c84e38c8b69fc74a270da680.
John Ericson [Fri, 21 Jan 2022 02:54:54 +0000 (02:54 +0000)]
[llvm][cmake] Make `install_symlink` workflow work with absolute install dirs
If `CMAKE_INSTALL_BINDIR` is a different absolute path per project, as
it is with NixOS when we install every package to its own prefix, the
old way fails when the absolute path gets prepended with `CMAKE_INSTALL_PREFIX`.
Using `extend_path` from the install-time script isn't really possible, so we just make the caller responsible for making the path absolute instead.
Also fix one stray `bin` -> `CMAKE_INSTALL_BINDIR`
Reviewed By: sebastian-ne
Differential Revision: https://reviews.llvm.org/D101070
John Ericson [Sat, 1 Jan 2022 20:18:27 +0000 (20:18 +0000)]
[cmake] Support custom package install paths
Firstly, we we make an additional GNUInstallDirs-style variable. With
NixOS, for example, this is crucial as we want those to go in
`${dev}/lib/cmake` not `${out}/lib/cmake` as that would a cmake subdir
of the "regular" libdir, which is installed even when no one needs to do
any development.
Secondly, we make *Config.cmake robust to absolute package install
paths. We for NixOS will in fact be passing them absolute paths to make
the `${dev}` vs `${out}` distinction mentioned above, and the
GNUInstallDirs-style variables are suposed to support absolute paths in
general so it's good practice besides the NixOS use-case.
Thirdly, we make `${project}_INSTALL_PACKAGE_DIR` CACHE PATHs like other
install dirs are.
Reviewed By: sebastian-ne
Differential Revision: https://reviews.llvm.org/D117973
Joseph Huber [Mon, 25 Jul 2022 19:16:06 +0000 (15:16 -0400)]
[Libomptarget] Reintroduce host architecture checks for device RTL
A previous patch removed the need to set the auxiliary architecture as
it was no longer needed for the clang invocation after moving to using
the clang frontend. However, this had a second use of preventing
unsupported host architectures from building the device runtime. This
caused failures when trying to build on 32-bit hosts for example.
Fixes #56699
Reviewed By: tianshilei1992
Differential Revision: https://reviews.llvm.org/D130509
Roy Sundahl [Mon, 25 Jul 2022 16:31:02 +0000 (09:31 -0700)]
[asan][test] Additional test requiring weak symbol for dyld64.
Extension of D127929
rdar://
80997227
Differential Revision: https://reviews.llvm.org/D130499
Daniel Bertalan [Mon, 25 Jul 2022 09:45:55 +0000 (11:45 +0200)]
Reland "[lld-macho] Implement -load_hidden"
This flag was introduced in ld64-609. It instructs the linker to link to
a static library while treating its symbols as if they had hidden
visibility. This is useful when building a dylib that links to static
libraries but we don't want the symbols from those to be exported.
Closes #51505
This reland adds bitcode file handling, so we won't get any compile
errors due to BitcodeFile::forceHidden being unused.
Differential Revision: https://reviews.llvm.org/D130473
Siva Chandra Reddy [Mon, 25 Jul 2022 20:45:46 +0000 (20:45 +0000)]
[libc][Obvious] Use the correct StringView constructor in dirent_test.
Andrew Brown [Mon, 25 Jul 2022 20:16:07 +0000 (13:16 -0700)]
[WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets
Only Emscripten supports dynamic linking with threads. To use
thread-local storage for other targets, this change defaults to the
`localexec` model.
Differential Revision: https://reviews.llvm.org/D130053
Siva Chandra Reddy [Sat, 23 Jul 2022 07:35:46 +0000 (07:35 +0000)]
[libc] Add dirent.h functions opendir, readdir, closedir and dirfd.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D130459
Matt Arsenault [Sat, 23 Jul 2022 13:33:21 +0000 (09:33 -0400)]
RegAllocGreedy: Add a command line flag for reverseLocalAssignment
Introduce a flag like for some of the other target heuristic controls
to help with experimentation.
Matt Arsenault [Sat, 23 Jul 2022 14:22:41 +0000 (10:22 -0400)]
AMDGPU: Adjust register allocation priority values down
Set the priorities consistently to number of registers in the tuple -
1. Previously we started at 1, and also tried to give SGPR higher
values than VGPRs. There's no point in assigning SGPRs higher values
now that those are allocated in a separate regalloc run.
This avoids overflowing the 5 bits used for the class priority in the
allocation heuristic for 32 element tuples. This avoids some cases
where smaller registers unexpectedly get prioritized over larger.
Joseph Huber [Mon, 25 Jul 2022 19:27:41 +0000 (15:27 -0400)]
[OpenMP] Remove noinline attributes in the device runtime
We previously used the `noinline` attributes to specify some defintions
which should be kept alive in the runtime. These were then stripped
immediately in the OpenMPOpt module pass. However, Since the changes in
D130298, we not explicitly state which functions will have external
visiblity in the bitcode library. Additionally the OpenMPOpt module pass
should run before the inliner pass, so this shouldn't make a difference
in whether or not the functions will be alive for the initial pass of
OpenMPOpt. This should simplify the interface, and additionally save
time spend on scanning funciton names for noinline.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D130368
Sanjay Patel [Mon, 25 Jul 2022 14:09:09 +0000 (10:09 -0400)]
[Passes] add a tail-call-elim pass near the end of the opt pipeline
We call tail-call-elim near the beginning of the pipeline,
but that is too early to annotate calls that get added later.
In the motivating case from issue #47852, the missing 'tail'
on memset leads to sub-optimal codegen.
I experimented with removing the early instance of
tail-call-elim instead of just adding another pass, but that
appears to be slightly worse for compile-time:
+0.15% vs. +0.08% time.
"tailcall" shows adding the pass; "tailcall2" shows moving
the pass to later, then adding the original early pass back
(so
1596886802 is functionally equivalent to
180b0439dc ):
https://llvm-compile-time-tracker.com/index.php?config=NewPM-O3&stat=instructions&remote=rotateright
Note that there was an effort to split the tail call functionality
into 2 passes - that could help reduce compile-time if we find
that this change costs more in compile-time than expected based
on the preliminary testing:
D60031
Differential Revision: https://reviews.llvm.org/D130374
Peter Klausler [Fri, 22 Jul 2022 18:48:07 +0000 (11:48 -0700)]
[flang] Allow restricted specific intrinsic functions as implicitly-interfaced procedure pointer targets
The predicate "CanBeCalledViaImplicitInterface()" was returning false for
restricted specific intrinsic functions (e.g., SIN) because their procedure
characteristics have the elemental attribute; this leads to a bogus semantic
error when one attempts to use them as proc-targets in procedure pointer
assignment statements when the left-hand side of the assignment is a procedure
pointer with an implicit interface. However, these restricted specific intrinsic
functions have always been allowed as special cases for such usage -- it is
as if they are elemental when it is necessary for them to be so, but not
when it's a problem.
Differential Revision: https://reviews.llvm.org/D130386
Peter Klausler [Fri, 22 Jul 2022 21:32:03 +0000 (14:32 -0700)]
[flang][runtime] Reset unit frame buffer when re-opening
An OPEN statement that implies closing a connection must invalidate
the unit's frame buffer so as to prevent stale data from the old
connection from being read into the newly-connected unit.
Differential Revision: https://reviews.llvm.org/D130430
Daniel Bertalan [Mon, 25 Jul 2022 19:11:19 +0000 (21:11 +0200)]
Revert "[lld-macho] Implement -load_hidden"
This reverts commit
4c79e1a3f4eb790f40239833ae237e828ce07386.
Broke this bot: https://lab.llvm.org/buildbot/#builders/57/builds/20319
Daniel Bertalan [Mon, 25 Jul 2022 09:45:55 +0000 (11:45 +0200)]
[lld-macho] Implement -load_hidden
This flag was introduced in ld64-609. It instructs the linker to link to
a static library while treating its symbols as if they had hidden
visibility. This is useful when building a dylib that links to static
libraries but we don't want the symbols from those to be exported.
Closes #51505
Differential Revision: https://reviews.llvm.org/D130473
Craig Topper [Mon, 25 Jul 2022 18:48:52 +0000 (11:48 -0700)]
[RISCV] Add more test cases for select with (setge X, C) condition.
InstCombine and SelectionDAG will tend to canonicalize these conditions
to (setgt X, C-1). C-1 might be more costly to materialize than C would
have been.
Kiran Chandramohan [Mon, 25 Jul 2022 18:21:17 +0000 (18:21 +0000)]
[Flang][OpenMP] Initial support for integer reduction in worksharing-loop
Lower the Flang parse-tree containing OpenMP reductions to the OpenMP
dialect. The OpenMP dialect models reductions with,
1) A reduction declaration operation that specifies how to initialize, combine,
and atomically combine private reduction variables.
2) The OpenMP operation (like wsloop) that supports reductions has an array of
reduction accumulator variables (operands) and an array attribute of the same
size that points to the reduction declaration to be used for the reduction
accumulation.
3) The OpenMP reduction operation that takes a value and an accumulator.
This operation replaces the original reduction operation in the source.
(1) is implemented by the `createReductionDecl` in OpenMP.cpp,
(2) is implemented while creating the OpenMP operation,
(3) is implemented by the `genOpenMPReduction` function in OpenMP.cpp, and
called from Bridge.cpp. The implementation of (3) is not very robust.
NOTE 1: The patch currently supports only reductions for integer type addition.
NOTE 2: Only supports reduction in the worksharing loop.
NOTE 3: Does not generate atomic combination region.
NOTE 4: Other options for creating the reduction operation include
a) having the reduction operation as a construct containing an assignment
and then handling it appropriately in the Bridge.
b) we can modify `genAssignment` or `genFIR(AssignmentStmt)` in the Bridge to
handle OpenMP reduction but so far we have tried not to mix OpenMP
and non-OpenMP code and this will break that.
I will try (b) in a separate patch.
NOTE 5: OpenMP dialect gained support for reduction with the patches:
D105358, D107343. See https://discourse.llvm.org/t/rfc-openmp-reduction-support/3367
for more details.
Reviewed By: awarzynski
Differential Revision: https://reviews.llvm.org/D130077
Co-authored-by: Peixin-Qiao <qiaopeixin@huawei.com>
Dmitri Gribenko [Mon, 25 Jul 2022 18:23:23 +0000 (20:23 +0200)]
[clang][dataflow] Rename iterators from IT to It
The latter way to abbreviate is a lot more common in the LLVM codebase.
Reviewed By: sgatev, xazax.hun
Differential Revision: https://reviews.llvm.org/D130423
Siva Chandra Reddy [Fri, 22 Jul 2022 06:54:54 +0000 (06:54 +0000)]
[libc] Add a simple StringStream class.
This class will be used in future changes to construct simple strings.
Reviewed By: michaelrj
Differential Revision: https://reviews.llvm.org/D130334
Eric Li [Mon, 25 Jul 2022 16:18:53 +0000 (12:18 -0400)]
[clang][dataflow] Fix MapLattice::insert() to not drop return value
Fix `MapLattice` API to return `std::pair<iterator, bool>`,
allowing users to detect when an element has been inserted without
performing a redundant map lookup.
Differential Revision: https://reviews.llvm.org/D130497
Justin Brooks [Mon, 25 Jul 2022 18:18:53 +0000 (18:18 +0000)]
[Kaleidoscope] Fix DWARF function creation example
The full code listing was fixed in
fdaeb0c647eb66763721a7fe74e0a36b007dcd75
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D130217
Peter Klausler [Mon, 18 Jul 2022 20:31:17 +0000 (13:31 -0700)]
[flang] Dial some errors down to warnings for ASSOCIATED()
When a procedure pointer is associated with a procedure target, f18
will emit hard error messages if the pointer is incompatible with the
target in a way that would cause the program to not work if the
procedure pointer were actually called. However, in the context of
the ASSOCIATED() intrinsic, the compiler should not consider a query
to be a compilation-time error if the pointer and the target are
incompatible. The standard gives us sufficient wiggle room here
to treat these cases as warnings.
Attempts to use ASSOCIATED to test whether a procedure pointer is
associated with a data object, or vice versa, remain errors.
Differential Revision: https://reviews.llvm.org/D130384
Christopher Bate [Mon, 25 Jul 2022 16:28:23 +0000 (10:28 -0600)]
Revert "[mlir][Arithmetic] Add `arith.delinearize_index` operation"
This reverts commit
535b507ba58e8b5f604d53ffc961be1456d229a7.
Corentin Jabot [Sat, 23 Jul 2022 07:53:40 +0000 (09:53 +0200)]
[Clang] Status of the C++23 papers approved by WG21 at the July plenary
Jean Perier [Mon, 25 Jul 2022 17:38:08 +0000 (19:38 +0200)]
[flang] Runs FIR SimplifyRegionLitePass pass after calling the inliner
In flang pipeline, the inliner calls createCanonicalizerPass with the region
simplification disabled. The inliner pass does canonicalization even if
no inlining happens. After canonicalization, FIR lite region simplification
must be called to get rid of unreachable regions.
This code exposes the need to run SimplifyRegionLitePass after the inliner is
called with FIR pipeline.
Differential Revision: https://reviews.llvm.org/D130484
Mike Urbach [Wed, 20 Jul 2022 14:21:36 +0000 (08:21 -0600)]
[mlir] Update Python CMake version requirement.
The minimum required version is now 3.19 due to the usage of some
more recent features. Update the version check and error message
accordingly. Also remove some logic that behaved differently before
3.18, since we can assume we are now on version 3.19+.
Reviewed By: stella.stamenova
Differential Revision: https://reviews.llvm.org/D130171
Warren Ristow [Mon, 25 Jul 2022 17:24:43 +0000 (10:24 -0700)]
[Reassociate][NFC] Use an appropriate dyn_cast for BinaryOperator
In D129523, it was noted that there is are some questionable naked casts
from Instruction to BinaryOperator, which could be addressed by doing a
dyn_cast directly to BinaryOperator, avoiding the need for the later cast.
This cleans up that casting.
Reviewed By: nikic, spatel, RKSimon
Differential Revision: https://reviews.llvm.org/D130448
Vladislav Dzhidzhoev [Mon, 25 Jul 2022 17:10:48 +0000 (17:10 +0000)]
[GlobalISel][DebugInfo] Remove debug info with zero line from constants inserted at entry block
Emission of constants having DebugLoc with line 0 causes significant increase of debug_line section size for some source files.
To illustrate, we can compare section sizes of several files from llvm test-suite, built with SelectionDAG vs GlobalISel, on Aarch64 (macOS), using -O0 optimization level:
| Source path | SDAG text sz | GISel text sz | SDAG debug_line sz | GISel debug_line sz
| -------------------------------------------------------------- | ------------ | ------------- | ------------------ | --------------------
| `SingleSource/Regression/C/gcc-c-torture/execute/strlen-2.c` | 15320 | 660 | 14872 | 6340
| `SingleSource/Regression/C/gcc-c-torture/execute/
20040629-1.c` | 33640 | 26300 | 2812 | 6693
| `SingleSource/Benchmarks/Misc/flops-4.c` | 1428 | 1196 | 594 | 1008
| `MultiSource/Benchmarks/MiBench/consumer-typeset/z31.c` | 2716 | 964 | 809 | 903
| `MultiSource/Benchmarks/Prolangs-C/gnugo/showinst.c` | 2534 | 2502 | 189 | 573
For instance, here is a fragment of `flops-4.c.o` debug line section dump
```
Address Line Column File ISA Discriminator Flags
------------------ ------ ------ ------ --- ------------- -------------
0x0000000000000000 174 0 1 0 0 is_stmt
0x0000000000000010 0 0 1 0 0
0x0000000000000018 185 4 1 0 0 is_stmt prologue_end
0x000000000000001c 0 0 1 0 0
0x0000000000000024 186 4 1 0 0 is_stmt
0x000000000000002c 189 10 1 0 0 is_stmt
0x0000000000000030 0 0 1 0 0
0x0000000000000038 207 11 1 0 0 is_stmt
0x0000000000000044 208 11 1 0 0 is_stmt
0x0000000000000048 0 0 1 0 0
0x0000000000000058 210 10 1 0 0 is_stmt
0x000000000000005c 0 0 1 0 0
0x0000000000000060 211 10 1 0 0 is_stmt
0x0000000000000064 0 0 1 0 0
0x000000000000006c 212 10 1 0 0 is_stmt
0x0000000000000070 0 0 1 0 0
0x000000000000007c 213 10 1 0 0 is_stmt
0x0000000000000080 0 0 1 0 0
0x0000000000000088 214 10 1 0 0 is_stmt
0x000000000000008c 0 0 1 0 0
0x0000000000000094 215 10 1 0 0 is_stmt
```
Lot of zero lines are produced by constants (global values) having DebugLoc with line 0.
It seems that they're not significant for debugging experience.
With the commit applied, total size of debug_line sections of llvm shared libraries has reduced by 2.5%.
Change of debug line section size of files listed above:
| Source path | GISel debug_line sz | Patch debug_line sz
| -------------------------------------------------------------- | ------------------- | --------------------
| `SingleSource/Regression/C/gcc-c-torture/execute/strlen-2.c` | 6340 | 1465
| `SingleSource/Regression/C/gcc-c-torture/execute/
20040629-1.c` | 6693 | 3782
| `SingleSource/Benchmarks/Misc/flops-4.c` | 1008 | 609
| `MultiSource/Benchmarks/MiBench/consumer-typeset/z31.c` | 903 | 841
| `MultiSource/Benchmarks/Prolangs-C/gnugo/showinst.c` | 573 | 190
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D127488
Peter Klausler [Mon, 18 Jul 2022 17:27:05 +0000 (10:27 -0700)]
[flang] Better error message for NULL() actual argument for dummy allocatable
f18 intentionally does not support the spottily-implemented language extension
in which one can pass NULL() for an allocatable dummy argument. This is perhaps
a sanctioned side effect in other compilers of the fact that they pass distinct
"base address" and "descriptor address" physical arguments.
Make the error message in this case more specific to the circumstances, and
add a note to Extensions.md to clarify that this behavior is intended.
(We could, with some effort in lowering, support passing NULL for an INTENT(IN)
allocatable dummy, but let's see whether such nonconforming usage appears
in a real application before spending any more time on it.)
Differential Revision: https://reviews.llvm.org/D130380
Vladislav Dzhidzhoev [Mon, 25 Jul 2022 16:39:46 +0000 (16:39 +0000)]
Fix assertion in SmallDenseMap constructor with reserve from non-power-of-2 buckets count
`SmallDenseMap` constructor with reserve gets an arbitrary `NumInitBuckets` value and passes it below to `init` method.
If `NumInitBuckets` is greater then `InlineBuckets`, then `SmallDenseMap` initializes to large representation passing `NumInitBuckets` below to `DenseMap` initialization. `DenseMap::initEmpty` method asserts that initial buckets count must be a power of 2.
Proposed solution is to update `NumInitBuckets` value in `SmallDenseMap` constructor till the next power of 2. It should satisfy both `DenseMap` preconditions and required minimum buckets count for reservation.
Reviewed By: atrick
Differential Revision: https://reviews.llvm.org/D129825
Igor Zhukov [Mon, 25 Jul 2022 16:54:32 +0000 (18:54 +0200)]
Use `<stdatomic.h>` with MSVC and C++
and use fallback only for C.
It fixes the isssue with clang-cl:
```
#include <stdatomic.h>
#include <stdbool.h>
#ifdef __cplusplus
#include <atomic>
using namespace std;
#endif
int main() {
atomic_bool b = true;
}
```
```
$ clang-cl /TC main.cpp
# works
```
```
$ clang-cl /TP /std:c++20 main.cpp
stdatomic.h(70,6): error: conflicting types for 'atomic_thread_fence'
void atomic_thread_fence(memory_order);
^
atomic(166,24): note: previous definition is here
extern "C" inline void atomic_thread_fence(const memory_order _Order) noexcept {
...
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
```
Many errors but
`<stdatomic.h>` has many macros to built-in functions.
```
#define atomic_thread_fence(order) __c11_atomic_thread_fence(order)
```
and MSVC `<atomic>` has real functions.
and the built-in functions are redefined.
Reviewed By: #libc, aaron.ballman, Mordante
Differential Revision: https://reviews.llvm.org/D130419
Michał Górny [Wed, 20 Jul 2022 14:27:21 +0000 (16:27 +0200)]
[lldb] [gdb-remote] Refactor killing process and move it to client
Refactor the code responsible for sending the "k" packet and move it
into GDBRemoteCommunicationClient::KillProcess() method. This is part
of refactoring to enable multiprocess support in the client,
and to support using the vKill packet instead.
As part of the refactoring, the following functional changes apply:
- Some redundant logging has been removed, as any failures are returned
via exit_string anyway.
- SetLastStopPacket() is no longer called. It is used only to populate
the thread list, and since the process has just exited and we're
terminating the process instance, there's really no reason to set it.
- On successful kill, exit_string is set to "killed", to clearly
indicate that the process has terminated on our request rather than
on its own.
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.llvm.org/D130340
Daniel Bertalan [Mon, 25 Jul 2022 15:18:47 +0000 (17:18 +0200)]
[lld-macho] Demangle location name in undefined symbol diagnostics
If the `-demangle` flag is passed to lld, symbol names will now be
demangled in the "referenced by:" message in addition to the referenced
symbol's name, which was already demangled before this change.
Differential Revision: https://reviews.llvm.org/D130490
Craig Topper [Mon, 25 Jul 2022 16:13:21 +0000 (09:13 -0700)]
[RISCV] Teach RISCVCodeGenPrepare to optimize (zext (abs(i32 X, i1 1))).
(abs(i32 X, i1 1) always produces a positive result. The 'i1 1'
means INT_MIN input produces poison. If the result is sign extended,
InstCombine will convert it to zext. This does not produce ideal
code for RISCV.
This patch reverses the zext back to sext which can be folded
into a subw or negw. Ideally we'd do this in SelectionDAG, but
we lose the INT_MIN poison flag when llvm.abs becomes ISD::ABS.
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D130412
Saiyedul Islam [Mon, 25 Jul 2022 16:35:09 +0000 (11:35 -0500)]
Revert "Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info"""
This reverts commit
281eb9223cf2e9366b5356fafab275abf0ea1d2b.
Nikolas Klauser [Sun, 24 Jul 2022 13:28:15 +0000 (15:28 +0200)]
[libc++] Fix algorithms which use reverse_iterator
This adds a C++20-version of `reverse_iterator` which doesn't SFINAE away the operators for use inside the classic STL algorithms. Pre-C++20 `_AlgRevIter` is just an alias for `reverse_iterator`.
Reviewed By: var-const, #libc
Spies: huixie90, libcxx-commits
Differential Revision: https://reviews.llvm.org/D128864
Peixin Qiao [Mon, 25 Jul 2022 16:33:27 +0000 (00:33 +0800)]
[flang] Support intrinsic `selected_int_kind` for variables
As Fortran 2018 16.9.169, the argument of selected_int_kind is integer
scalar, and result is default integer scalar. The constant expression in
this intrinsic has been supported by folding the constant expression.
This supports lowering and runtime for variables in this intrinsic.
Reviewed By: Jean Perier
Differential Revision: https://reviews.llvm.org/D129959
Andrzej Warzynski [Mon, 25 Jul 2022 16:21:25 +0000 (16:21 +0000)]
[flang][nfc] Add missing `REQUIRES: asserts` in a test
This change is required for release builds - see
https://reviews.llvm.org/D130185 for more context.
I'm sending this without a review as this is rather straightforward and
identical to the changes from https://reviews.llvm.org/D130185 (the test
updated in this patch wasn't yet in-tree when D130185 landed).
Jonas Devlieghere [Mon, 25 Jul 2022 16:26:09 +0000 (09:26 -0700)]
[lldb] Make compiler-rt an optional LLDB test dependency
Make compiler-rt an LLDB test dependency if the corresponding target
exists. Similarly we already have `asan` and `tsan` as optional test
dependencies, but we need the `compiler-rt` target when enabling
compiler-rt trough LLVM_ENABLE_RUNTIMES.
Craig Topper [Mon, 25 Jul 2022 15:55:37 +0000 (08:55 -0700)]
[X86] Custom type legalize v2i32 smulo/umulo to use a single pmuldq/pmuludq.
With SSE4.1 and above we were using 3 multiply instructions. This
was due to type legalization widening to v4i32 and the low half
being done with pmulld while the high half used two pmuldq/pmuludq.
Instead of that, we can use a single pmuludq/pmuldq to calculate
the full product at once, extract the high and low bits and compare
to check for overflow.
I've restricted SMULO to sse4.1 to get pmuldq. We can probably
do a fixup to pmuludq on earlier targets, but that's for another day.
I was going through my git stash and found an early version of this patch
from a year or two ago so I went ahead and finished it.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D130432
John Ericson [Sat, 29 Jan 2022 18:42:12 +0000 (18:42 +0000)]
[llvm][cmake] Shore up `llvm_check_linker_flags`.
Ensure `CMAKE_EXE_LINKER_FLAGS` effects the underlying `try_compile` by setting
this policy to use the new, non-deprecated behavior, without effecting the
caller.
Normally this shouldn't be necessary, as CMake uses
`cmake_minimum_required(VERSION 3.13.4)` consistently, but I suppose
this could rear its head in a downstream project?
Reviewed By: sebastian-ne
Differential Revision: https://reviews.llvm.org/D118546
Benoit Jacob [Mon, 25 Jul 2022 15:21:33 +0000 (15:21 +0000)]
Generalize the vector transfer flattening patterns (dyn shapes).
Differential Revision: https://reviews.llvm.org/D130284
Bradley Smith [Thu, 16 Jun 2022 10:33:37 +0000 (10:33 +0000)]
[AArch64][SVE] Fold target specific ext/trunc nodes into loads/stores
Due to the way fixed length SVE lowering works, we sometimes introduce
ext/trunc nodes very late, these nodes then immediately get converted
into target specific nodes (UUNPKLO/UZP1) before they get a chance to be
folded into a load/store.
This patch introduces target specific dag combines for these nodes so that
we can still create extending loads/truncating stores out of them.
Differential Revision: https://reviews.llvm.org/D128065
David Spickett [Mon, 25 Jul 2022 15:14:03 +0000 (15:14 +0000)]
[lldb][AArch64] Use macro for unused var without asserts enabled
82d4f39f342165a92eaa1fe74488158942cf27b4 marked an unused
var of mine (thanks Dmitri Gribenko!). Which reminded me lldb has
a macro just for that purpose.
Dmitri Gribenko [Mon, 25 Jul 2022 14:58:03 +0000 (16:58 +0200)]
[lldb][AArch64] Fix an unused variable warning in release builds. NFC
David Spickett [Mon, 11 Jul 2022 12:26:36 +0000 (13:26 +0100)]
[lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager
This is the first part of support for reading MTE tags from Linux
core files. The format is documented here:
https://www.kernel.org/doc/html/latest/arm64/memory-tagging-extension.html#core-dump-support
This patch adds a method to unpack from the format the core
file uses, which is different to the one chosen for GDB packets.
MemoryTagManagerAArch64MTE is not tied one OS so another OS
might choose a different format in future. However, infrastructure
to handle that would go untested until then so I've chosen not to
attempt to handle that.
Reviewed By: omjavaid
Differential Revision: https://reviews.llvm.org/D129487
Sunho Kim [Mon, 25 Jul 2022 14:41:53 +0000 (23:41 +0900)]
[JITLink][COFF][x86_64] Reimplement ADDR32NB/REL32.
Reimplements ADDR32NB/REL32 relocations properly, out-of-reach targets will be dealt in the separate patch that will generate the stub for dllimport symbols.
Reviewed By: sgraenitz
Differential Revision: https://reviews.llvm.org/D129936
Sunho Kim [Mon, 25 Jul 2022 14:24:25 +0000 (23:24 +0900)]
[ORC][COFF] Properly set weak flag to COMDAT symbols.
Properly set weak flag to COMDAT symbols so that no duplicate definition error will be generated. There is an inaccuracy in setting plain weak for largest selection type, which will be dealt with soon when largest type is properly implemented.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129764
Sunho Kim [Mon, 25 Jul 2022 14:21:17 +0000 (23:21 +0900)]
[JITLink][COFF] Implement IMAGE_SYM_CLASS_LABEL.
AcceptedPublic
Implements IMAGE_SYM_CLASS_LABEL. It's simply a section + offset. This is not used a lot by llvm mc but very commonly used by MSVC compiler.
Reviewed By: sgraenitz
Differential Revision: https://reviews.llvm.org/D129754
Tue Ly [Mon, 25 Jul 2022 14:20:32 +0000 (10:20 -0400)]
[libc] Raise FE_INVALID for sinf with +- inf inputs.
Matthias Springer [Mon, 25 Jul 2022 14:13:01 +0000 (16:13 +0200)]
[mlir][linalg] Expand test case for tile-and-fuse with transform dialect
Reverse the order of the payload ops. fuse_into_containing_op should still work.
Differential Revision: https://reviews.llvm.org/D130355
Sunho Kim [Mon, 25 Jul 2022 14:02:31 +0000 (23:02 +0900)]
[JITLink][COFF] Handle out-of-order COMDAT second symbol.
Handle out-of-order COMDAT second symbols. In llvm codegen, the second symbol of COMDAT sequence always follows the first symbol in the global symbol list. But, when the object file came from MSVC compiler, these can come in out of order.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129721
Sunho Kim [Mon, 25 Jul 2022 13:59:19 +0000 (22:59 +0900)]
[JITLink][COFF] Don't dead strip COMDAT associative symbol.
This prevents the dead strip of associative comdat section when parent section is alive.
Reviewed By: sgraenitz
Differential Revision: https://reviews.llvm.org/D129720
Erich Keane [Mon, 25 Jul 2022 13:21:54 +0000 (06:21 -0700)]
Reapply "[NFC] Add some additional features to MultiLevelTemplateArgumentList""
This reverts commit
6a1ccf61cdf80c793f9c699ada33af5d85263b30.
A typo in an assert escaped my local testing thanks to being a release
build :/
Simon Tatham [Mon, 25 Jul 2022 13:55:31 +0000 (14:55 +0100)]
[llvm-objdump,ARM] Fix .byte directives dumping the wrong byte.
The clause in `dumpARMELFData` that dumps a single byte as a `.byte`
directive was printing the operand of that directive as `Bytes[0]`,
not `Bytes[Index]`. In particular, this led to the `dumpBytes` output
to its left not matching it!
Reviewed By: DavidSpickett
Differential Revision: https://reviews.llvm.org/D130360
Alex Zinenko [Mon, 18 Jul 2022 16:28:04 +0000 (18:28 +0200)]
[mlir] move _mlir_alloc and friends to CRunnerUtils
These functions don't depend on the C++ runtime and therefore belong to
CRunnerUtils. Clean up the macros on the way as `_MSC_VER` indicates the
compiler, not the platform, which is indicated by `_WIN32` and will be
present when, e.g., compiling with minGW.
Reviewed By: rdzhabarov
Differential Revision: https://reviews.llvm.org/D130025
Michele Scuttari [Mon, 25 Jul 2022 13:42:36 +0000 (15:42 +0200)]
[MLIR] Generic 'malloc', 'aligned_alloc' and 'free' functions
When converted to the LLVM dialect, the memref.alloc and memref.free operations were generating calls to hardcoded 'malloc' and 'free' functions. This didn't leave any freedom to users to provide their custom implementation. Those operations now convert into calls to '_mlir_alloc' and '_mlir_free' functions, which have also been implemented into the runtime support library as wrappers to 'malloc' and 'free'. The same has been done for the 'aligned_alloc' function.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D128791
Saiyedul Islam [Mon, 25 Jul 2022 13:32:26 +0000 (08:32 -0500)]
Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info""
This reverts commit
8cbf4a386b6740180fe48aaebbd1ca9f8ee14367.
Iain Sandoe [Wed, 6 Jul 2022 06:40:01 +0000 (07:40 +0100)]
[C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]
This includes the revised provisions of [basic.lookup.argdep] p4
1. ADL is amended to handle p 4.3 where functions in trasitively imported modules may
become visible when they are exported in the same namespace as a visible type.
2. If a function is in a different modular TU, and has internal-linkage, we invalidate
its entry in an overload set.
[basic.lookup.argdep] p5 ex 2 now passes.
Differential Revision: https://reviews.llvm.org/D129174
Ilya Biryukov [Mon, 25 Jul 2022 10:42:42 +0000 (12:42 +0200)]
[Sema] Merge C++20 concept definitions from different modules in same TU
Currently the C++20 concepts are only merged in `ASTReader`, i.e. when
coming from different TU. This can causes ambiguious reference errors when
trying to access the same concept that should otherwise be merged.
Please see the added test for an example.
Note that we currently use `ASTContext::isSameEntity` to check for ODR
violations. However, it will not check that concept requirements match.
The same issue holds for mering concepts from different TUs, I added a
FIXME and filed a GH issue to track this:
https://github.com/llvm/llvm-project/issues/56310
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D128921
Weining Lu [Mon, 25 Jul 2022 09:24:25 +0000 (17:24 +0800)]
[LoongArch] Parse LoongArch base ABI in ObjectYAML and llvm-readobj
LoongArch e_flags definition:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_e_flags_identifies_abi_type_and_version
Differential Revision: https://reviews.llvm.org/D130238
David Spickett [Mon, 25 Jul 2022 10:55:45 +0000 (10:55 +0000)]
[lldb][ARM/AArch64] Use sys/uio.h instead of socket.h in native register context
We only want iovec and uio.h is just that without a lot
of other stuff. Saves me wondering why this code might
want to open sockets.
https://pubs.opengroup.org/onlinepubs/
007904975/basedefs/sys/uio.h.html
Cullen Rhodes [Mon, 25 Jul 2022 11:57:27 +0000 (11:57 +0000)]
[AArch64] Combine setcc (iN (bitcast (vNi1 X))) with vecreduce_or
Reviewed By: paulwalker-arm
Differential Revision: https://reviews.llvm.org/D130163
Cullen Rhodes [Mon, 25 Jul 2022 11:54:15 +0000 (11:54 +0000)]
[AArch64][NFC] Add test case for setcc (iN bitcast (vNi1 X)), (iN 0), (eq|ne)
To be combined to 'setcc (iN (zext (i1 (vecreduce_or (vNi1 X))))), 0, (eq|ne)'
in follow on patch.
Reviewed By: peterwaller-arm
Differential Revision: https://reviews.llvm.org/D130162
Abhina Sreeskantharajan [Mon, 25 Jul 2022 12:06:16 +0000 (08:06 -0400)]
[SystemZ][z/OS] Open YAML text files as text
This patch sets the YAML file as text instead of binary.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D130354
Peixin Qiao [Mon, 25 Jul 2022 11:36:14 +0000 (19:36 +0800)]
[flang] Support lowering intrinsic `selected_real_kind` for variables
As Fortran 2018 16.9.170, the argument of `selected_real_kind` is integer
scalar, and result is default integer scalar. The constant expression in
this intrinsic has been supported by folding the constant expression.
This supports lowering this intrinsic for variables using runtime.
Reviewed By: Jean Perier
Differential Revision: https://reviews.llvm.org/D130183
Benjamin Kramer [Mon, 25 Jul 2022 11:28:32 +0000 (13:28 +0200)]
[ValueTracking] Fix unused variable warning in release builds. NFC
Muhammad Usman Shahid [Mon, 25 Jul 2022 11:22:54 +0000 (07:22 -0400)]
Rewording "static_assert" diagnostics
This patch rewords the static assert diagnostic output. Failing a
_Static_assert in C should not report that static_assert failed. This
changes the wording to be more like GCC and uses "static assertion"
when possible instead of hard coding the name. This also changes some
instances of 'static_assert' to instead be based on the token in the
source code.
Differential Revision: https://reviews.llvm.org/D129048
Aaron Ballman [Mon, 25 Jul 2022 11:18:48 +0000 (07:18 -0400)]
Switch from XFAIL to UNSUPPORTED; NFC
This test is currently marked as XFAIL for Windows, but running the
test with a debug build of clang-repl.exe crashes with a modal system
dialog. This switches the test to UNSUPPORTED instead. This makes the
test behavior less onerous for those of us doing Debug builds, at the
expense of a minor bit of coverage if the test were ever to start
passing unexpectedly on Windows (which seems like an unlikely event).
Iain Sandoe [Mon, 25 Jul 2022 09:50:16 +0000 (10:50 +0100)]
[C++20][Modules] Add a testcase for [basic.link] p10 [NFC].
This adds a testcase based on example 2 from the basic.link section of the
standard.
Sam McCall [Fri, 22 Jul 2022 09:28:51 +0000 (11:28 +0200)]
[pseudo] Eliminate multiple-specified-types ambiguities using guards
Motivating case: `foo bar;` is not a declaration of nothing with `foo` and `bar`
both types.
This is a common and critical ambiguity, clangd/AST.cpp has 20% fewer
ambiguous nodes (1674->1332) after this change.
Differential Revision: https://reviews.llvm.org/D130337
Matthias Springer [Mon, 25 Jul 2022 10:29:01 +0000 (12:29 +0200)]
[mlir][tensor][bufferize][NFC] Remove duplicate code
InsertSliceOp and ParallelInsertSliceOp are very similar and can share some of the bufferization analysis code.
Differential Revision: https://reviews.llvm.org/D130465
Saiyedul Islam [Mon, 25 Jul 2022 10:32:59 +0000 (05:32 -0500)]
Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info"
This reverts commit
471f2abc62d96b3ef97e13f4f7be2d386fc9f75f.