commit-bot@chromium.org [Mon, 19 May 2014 13:53:10 +0000 (13:53 +0000)]
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate.
Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug.
R=robertphillips@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
282283002
git-svn-id: http://skia.googlecode.com/svn/trunk@14774
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 19 May 2014 12:36:15 +0000 (12:36 +0000)]
Add choke point for performing a fake endRecording
My goal here was to add a single location where we could patch up the created PicturePlayback. Unfortunately, the complexity of the recording process (e.g., the BBH) makes this quite complex.
I will investigate altering the behavior of SkPicturePlayback to account for a potentially unbalanced set of saves/saveLayers.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
283333007
git-svn-id: http://skia.googlecode.com/svn/trunk@14773
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 19 May 2014 12:26:58 +0000 (12:26 +0000)]
Ensure playing back a picture always balances saves and restores
This "fixes" the legacy interface's possible creation of pictures with unbalanced save/restores.
The Android dox will need to be updated once/if this lands.
R=reed@google.com, scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
286033005
git-svn-id: http://skia.googlecode.com/svn/trunk@14772
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 19:48:57 +0000 (19:48 +0000)]
Fix generation tests.
R=epoger@google.com
TBR=epoger
NOTRY=true
BUG=skia:2565
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
284313007
git-svn-id: http://skia.googlecode.com/svn/trunk@14771
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 19:19:31 +0000 (19:19 +0000)]
make buildbot_globals.py read global_variables.json file from googlesource
BUG=skia:2564
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
291563008
git-svn-id: http://skia.googlecode.com/svn/trunk@14770
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 18:27:11 +0000 (18:27 +0000)]
Fix windows build.
Windows won't let me insert #ifdefs inside macro expansion.
R=borenet@google.com
TBR=borenet
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
289853003
git-svn-id: http://skia.googlecode.com/svn/trunk@14769
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 18:11:51 +0000 (18:11 +0000)]
Generate Android.mk for DM.
ifdef out code that won't build where we don't have jsoncpp.
Include ctype instead of string.h for tolower.
Depends on https://codereview.chromium.org/
282053002/
BUG=skia:2447
R=mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
290603002
git-svn-id: http://skia.googlecode.com/svn/trunk@14768
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 17:56:43 +0000 (17:56 +0000)]
Generate gm/Android.mk, minus JSON.
When running gyp_to_android.py, generate the makefile for gm.
For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.
gm/gm_expectations.cpp:
gm/gm_expectations.h:
gm/gmmain.cpp:
Remove all json functionality when SK_BUILD_JSON_WRITER is not defined.
This flag is not defined when SK_BUILD_FOR_ANDROID is defined.
gyp/gm.gyp:
Depend on skia and cutils.
platform_tools/android/bin/gyp_to_android.py:
Generate gm/Android.mk.
platform_tools/android/gyp_gen/makefile_writer.py:
Build gm/Android.mk when building external/skia.
Depends on https://codereview.chromium.org/
282053002/
BUG=skia:2447
BUG=skia:2448
R=epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
281303003
git-svn-id: http://skia.googlecode.com/svn/trunk@14767
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 17:46:09 +0000 (17:46 +0000)]
Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2272
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
290183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14766
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 17:22:51 +0000 (17:22 +0000)]
Fix Gpu texture creation bug
When creating a resizedTexture on a device that doesn't support non power of 2 tile (Tegras),
we were creating the new stretched texture but were not actually saving the result
BUG=skia:2561
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
284303005
git-svn-id: http://skia.googlecode.com/svn/trunk@14765
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 16:35:48 +0000 (16:35 +0000)]
Disable poppler on Windows since it no longer compiles in VS2013
R=borenet@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
285293008
git-svn-id: http://skia.googlecode.com/svn/trunk@14764
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 13:49:08 +0000 (13:49 +0000)]
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/
283273002/)
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 13:47:56 +0000 (13:47 +0000)]
Rebase for https://codereview.chromium.org/
283803003/
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
291483008
git-svn-id: http://skia.googlecode.com/svn/trunk@14762
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 13:35:01 +0000 (13:35 +0000)]
remove unused (by clients) SkUnitMapper
BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
283273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14761
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 13:15:41 +0000 (13:15 +0000)]
Generate bench/Android.mk from gyp.
For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.
bench/DeferredSurfaceCopyBench.cpp:
Include GrRenderTarget last, so SK_SUPPORT_GPU will be set properly.
bench/ResultsWriter.h:
bench/benchmain.cpp:
Remove JSONResultsWriter when SK_BUILD_JSON_WRITER is not defined,
which is the case for the Android framework build.
gyp/bench.gyp:
Depend on skia and cutils (for android_atomic_inc etc).
gyp/common_conditions.gypi:
Define SK_BUILD_JSON_WRITER when skia_build_json_writer is set.
gyp/common_variables.gypi:
Add a flag for skia_build_json_writer, and set it only when
skia_android_framework is not set.
gyp/jsoncpp.gyp:
Do not build jsoncpp when skia_build_json_writer is not defined.
include/utils/SkJSONCPP.h:
Do not include json headers when SK_BUILD_JSON_WRITER is not defined.
platform_tools/android/bin/gyp_to_android.py:
Generate bench/Android.mk.
platform_tools/android/gyp_gen/gypd_parser.py:
Skip dest_dir when checking for include_dirs.
platform_tools/android/gyp_gen/makefile_writer.py:
Build bench/Android.mk when building external/skia.
platform_tools/android/gyp_gen/tool_makefile_writer.py:
Add a parameter for putting the binary into /data/local/tmp.
BUG=skia:2447
BUG=skia:2448
R=halcanary@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
282053002
git-svn-id: http://skia.googlecode.com/svn/trunk@14760
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 13:03:46 +0000 (13:03 +0000)]
DM: find max component difference
So far unused except to back BitmapsEqual, but I want to play with it in CLs I'm working on.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
290043005
git-svn-id: http://skia.googlecode.com/svn/trunk@14759
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 May 2014 12:46:25 +0000 (12:46 +0000)]
bench rebase after 1663d40
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
292503002
git-svn-id: http://skia.googlecode.com/svn/trunk@14758
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 16 May 2014 03:03:31 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14757
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 21:14:34 +0000 (21:14 +0000)]
Add polyfill for pointer events, change code to handle both mouse and pointer events equalls.
Mobile first!
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
286913005
git-svn-id: http://skia.googlecode.com/svn/trunk@14756
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 20:48:52 +0000 (20:48 +0000)]
hack to expand 'pad' to account for very wide glyphs
BUG=crbug.com/373785
R=mtklein@google.com, robertphillips@google.com, bungeman@google.com, eae@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
288923006
git-svn-id: http://skia.googlecode.com/svn/trunk@14755
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 20:35:50 +0000 (20:35 +0000)]
Add lua scripts to scrape dashing info
BUG=skia:
R=reed@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
288883003
git-svn-id: http://skia.googlecode.com/svn/trunk@14754
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 20:32:48 +0000 (20:32 +0000)]
Move skPaint2GrPaint to SkGr.h/cpp
BUG=skia:
R=bsalomon@google.com, brian@thesalomons.net, robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
283803003
git-svn-id: http://skia.googlecode.com/svn/trunk@14753
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 17:33:31 +0000 (17:33 +0000)]
refactor DM::SetupBitmap
Seemed sort of repetitive.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
286993005
git-svn-id: http://skia.googlecode.com/svn/trunk@14752
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 16:10:37 +0000 (16:10 +0000)]
Factor out DumpRecord method from dump_record tool for later use
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
282233003
git-svn-id: http://skia.googlecode.com/svn/trunk@14751
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 15:59:39 +0000 (15:59 +0000)]
Add SSE4 check to BlurImage optimization.
Adds a build-time SSE4 check to SkBlurImage_opts_SSE2.cpp
in the SkBoxBlur_SSE2 function.
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, senorblanco@chromium.org
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
281963002
git-svn-id: http://skia.googlecode.com/svn/trunk@14750
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 15:40:41 +0000 (15:40 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.
Neither Chrome nor Android uses this flag anymore.
Make sure all constructors touched that only have one parameter are marked as 'explicit'.
BUG=2187
R=scroggo@google.com, reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
282203004
git-svn-id: http://skia.googlecode.com/svn/trunk@14749
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 15:10:48 +0000 (15:10 +0000)]
render_pictures: add --mismatchPath flag
When set, it will only write out images that don't match expectations.
BUG=skia:1942
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
283123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14748
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 14:41:00 +0000 (14:41 +0000)]
delete no-longer-used update-doxygen.sh
BUG=skia:2470
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
290033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14747
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 13:25:53 +0000 (13:25 +0000)]
bench rebase after a1633da
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
286073005
git-svn-id: http://skia.googlecode.com/svn/trunk@14746
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 May 2014 09:46:20 +0000 (09:46 +0000)]
Always inline SkFloatToFixed_arm.
We have "inline" assembly for speed on ARM, but the compiler when
told to optimize for space wasn't inlining it, destroying any
possible performance improvement.
BUG=skbug:2550
R=mtklein@google.com, reed@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
281143002
git-svn-id: http://skia.googlecode.com/svn/trunk@14745
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 15 May 2014 03:03:58 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14744
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 20:27:56 +0000 (20:27 +0000)]
Effects on the paint also prevent layer merge optimization.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
287953002
git-svn-id: http://skia.googlecode.com/svn/trunk@14743
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 20:26:00 +0000 (20:26 +0000)]
DM: tweaks
- translate filenames to task names instead of using a verbatim mode in WriteTask
- add an option to write out only PNG data to the .png if you don't need -r to work
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
288823002
git-svn-id: http://skia.googlecode.com/svn/trunk@14742
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 14 May 2014 18:58:16 +0000 (18:58 +0000)]
comment out info4 test until Rob can fix it
git-svn-id: http://skia.googlecode.com/svn/trunk@14741
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 18:04:46 +0000 (18:04 +0000)]
rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots
(SkipBuildbotRuns)
BUG=skia:2514
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
287623006
git-svn-id: http://skia.googlecode.com/svn/trunk@14740
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 17:55:32 +0000 (17:55 +0000)]
DM: Add --skps.
This does render_pictures, plus checks SkRecord optimizations.
Disable an SkRecord optimization that draws several bot SKPs wrong. (To be investigated.)
BUG=skia:2378
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270543004
git-svn-id: http://skia.googlecode.com/svn/trunk@14739
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 17:42:42 +0000 (17:42 +0000)]
remove reference to (deleted) SkKernel33MaskFilter
BUG=skia:
R=caryclark@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
281163002
git-svn-id: http://skia.googlecode.com/svn/trunk@14738
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 16:57:49 +0000 (16:57 +0000)]
Fix goauth path
BUG=skia:2551
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
288763002
git-svn-id: http://skia.googlecode.com/svn/trunk@14737
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 16:32:31 +0000 (16:32 +0000)]
update NeedsDeepCopy
BUG=skia:
R=mtklein@google.com, scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
289723002
git-svn-id: http://skia.googlecode.com/svn/trunk@14736
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 16:30:41 +0000 (16:30 +0000)]
bench rebase after 9f3b925
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
286823004
git-svn-id: http://skia.googlecode.com/svn/trunk@14735
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 16:06:15 +0000 (16:06 +0000)]
Reland the 4x -> 1x allocation from "4x allocation in PipeController is probably overkill."
BUG=372671
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
283933002
git-svn-id: http://skia.googlecode.com/svn/trunk@14734
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 16:03:14 +0000 (16:03 +0000)]
Add asADash to Lua for scraping
BUG=skia:
R=robertphillips@google.com, reed@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
267423006
git-svn-id: http://skia.googlecode.com/svn/trunk@14733
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:42:14 +0000 (15:42 +0000)]
Add warning about GOPATH to bug_chomper/run_server.sh
BUG=skia:2551
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
285763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14732
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:38:25 +0000 (15:38 +0000)]
Reland one more bug fix from "4x allocation in PipeController is probably overkill.".
BUG=372671
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
285693007
git-svn-id: http://skia.googlecode.com/svn/trunk@14731
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:36:54 +0000 (15:36 +0000)]
arm64make script - fix error preventing Release testing.
R=scroggo@google.com, djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
258323002
git-svn-id: http://skia.googlecode.com/svn/trunk@14730
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:14:51 +0000 (15:14 +0000)]
Add CPU backing store for GrAtlas to reduce texture uploads.
This change creates a temporary copy of each GrPlot on the CPU
side. As we add glyphs to a plot, a dirty rectangle is tracked,
and just before we render text we upload all of the dirty areas
to the atlas texture. Once a plot is nearly full, we assume that
we may only be adding one or two glyphs before rendering, so we
delete the CPU backing memory to save space, and upload directly.
BUG=366225
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
269423007
git-svn-id: http://skia.googlecode.com/svn/trunk@14729
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:12:51 +0000 (15:12 +0000)]
Allow GrFontCache::dump() in all builds.
In testing Chrome last week, I discovered that dump() works fine in Release builds, so there's no reason to restrict it to Developer.
R=robertphillips@google.com, egdaniel@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
286803002
git-svn-id: http://skia.googlecode.com/svn/trunk@14728
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 15:12:08 +0000 (15:12 +0000)]
Reland bug fixes from "4x allocation in PipeController is probably overkill."
BUG=372671
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
283093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14727
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 14:54:51 +0000 (14:54 +0000)]
Stage fixes for underline position.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
271333002
git-svn-id: http://skia.googlecode.com/svn/trunk@14726
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 14:50:57 +0000 (14:50 +0000)]
Manually revert "4x allocation in PipeController is probably overkill."
This reverts commit
2d91efffdb57646a495de5bf859ff281ef86dd12.
Conflicts:
src/pipe/SkGPipeWrite.cpp
BUG=372671
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
277653004
git-svn-id: http://skia.googlecode.com/svn/trunk@14725
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 14:28:34 +0000 (14:28 +0000)]
Add ownership dox for SkShader::asACompose.
Supplement the comment added in
http://code.google.com/p/skia/source/detail?r=14716
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
288713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14724
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 13:34:42 +0000 (13:34 +0000)]
By default, Chromium optimizes for size when compiling on Android.
Forcing the SkAlphaMulQ() function inline can yield as much as a 5-10%
improvement in rasterization time for some of Chromium's telemetry
tests on the Nexus 10, since it's in the inner loop of complex blends.
R=mtklein@google.com, reed@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
283753003
git-svn-id: http://skia.googlecode.com/svn/trunk@14723
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 13:13:44 +0000 (13:13 +0000)]
Inline noop willFoo/didFoo into SkCanvas.h.
We've got our canvas subclasses all calling back up to these via
INHERITED, all noops. That's fine but currently a little sad as they
can't be optimized away without link-time optimization, which we and
Chrome only do on Windows. We actually make a call for each of these
today on non-Windows.
So, move the empty implementations into the header so those chaining
calls really can be optimized away.
BUG=skia:
R=reed@google.com, fmalita@google.com, mtklein@google.com, fmalita@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
287593005
git-svn-id: http://skia.googlecode.com/svn/trunk@14722
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 13:11:48 +0000 (13:11 +0000)]
Update layer-pre-rendering for Chrome flag
As currently plumbed into Chromium, EXPERIMENTAL_optimize can be called multiple times per picture. Additionally, Chromium generates a lot of pictures with no layers at all.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
283703007
git-svn-id: http://skia.googlecode.com/svn/trunk@14721
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 May 2014 12:55:34 +0000 (12:55 +0000)]
Ping MySQL every minute in an attempt to keep the connection alive.
I've tried various MySQL server settings, and some TCP settings on the webtry server, none seem to keep the connection from hanging, so this is a brute-force solution.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
286543003
git-svn-id: http://skia.googlecode.com/svn/trunk@14720
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 20:32:32 +0000 (20:32 +0000)]
Comment out call broken call to pushMatrix in LuaCanvas
BUG=skia:
R=robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
271533013
git-svn-id: http://skia.googlecode.com/svn/trunk@14719
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 19:18:55 +0000 (19:18 +0000)]
BugChomper: Get the oauth_client_secret from GS
BUG=skia:
NOTRY=true
(SkipBuildbotRuns)
R=jcgregorio@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
288593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14718
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 19:13:36 +0000 (19:13 +0000)]
bench rebase after f71be96
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
276573012
git-svn-id: http://skia.googlecode.com/svn/trunk@14717
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 18:14:45 +0000 (18:14 +0000)]
Add functions for inspecting SkShader.
Add a function to inspect an SkShader to determine if it is an
SkComposeShader.
Add a virtual function for determining if an SkShader is a custom
shader, which returns a custom set of information. The
implementation is in Android, and this function is only defined
if SK_BUILD_FOR_ANDROID_FRAMEWORK.
BUG=b/
10650594
R=reed@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
282733005
git-svn-id: http://skia.googlecode.com/svn/trunk@14716
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 18:03:45 +0000 (18:03 +0000)]
BugChomper utility - rewrite in Go
BUG=skia:
R=jcgregorio@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
274693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14715
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 17:47:08 +0000 (17:47 +0000)]
Fixed flaky test
BUG=skia:
R=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
283713005
git-svn-id: http://skia.googlecode.com/svn/trunk@14714
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 17:38:17 +0000 (17:38 +0000)]
Adds dashboard link for one-line plot on each alert item.
BUG=skia:2523
NOTRY=true
R=kelvinly@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
280663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14713
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 17:33:56 +0000 (17:33 +0000)]
Adds kelvinly@google.com to CQ_COMMITTERS
BUG=skia:
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
270383005
git-svn-id: http://skia.googlecode.com/svn/trunk@14712
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 14:47:21 +0000 (14:47 +0000)]
Update TSAN suppressions.
BUG=skia:2459, skia:1792
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
288533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14711
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 14:47:17 +0000 (14:47 +0000)]
Remove legacy SkLayerRasterizer flag for Android.
Android's uses of SkLayerRasterizer have been cleaned up and no longer require
the legacy API. Remove the flag for Android.
We still have to keep the legacy API around until Mozilla have cleaned up their
uses.
BUG=skia:2187
R=reed@google.com, djsollen@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
279383006
git-svn-id: http://skia.googlecode.com/svn/trunk@14710
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 14:47:11 +0000 (14:47 +0000)]
Always inline Filter_32_*_neon functions
The functions are rather performance critical and already marked
'inline'. However, Chrome for Android will not have these functions
inlined due to it being compiled with -Os and a small -finline-limit.
This avoids one call in the filtering functions.
Does not increase the library size.
BUG=chromium:363073
R=mtklein@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
280403005
git-svn-id: http://skia.googlecode.com/svn/trunk@14709
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 14:45:29 +0000 (14:45 +0000)]
Add check for bad dash interval in dash effect picture read
BUG=skia:2542
R=caryclark@google.com, reed@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
275053004
git-svn-id: http://skia.googlecode.com/svn/trunk@14708
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 14:16:42 +0000 (14:16 +0000)]
bench rebase after e92c68f
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
286583005
git-svn-id: http://skia.googlecode.com/svn/trunk@14707
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 13 May 2014 13:35:04 +0000 (13:35 +0000)]
Fix the android framework build as it still uses mutable local matrices.
R=reed@google.com
Review URL: https://codereview.chromium.org/
284663004
git-svn-id: http://skia.googlecode.com/svn/trunk@14706
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 13 May 2014 03:06:05 +0000 (03:06 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14705
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 13 May 2014 00:43:44 +0000 (00:43 +0000)]
add SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX for chrome
TBR=borenet@google.com
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
286563004
git-svn-id: http://skia.googlecode.com/svn/trunk@14704
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:47:02 +0000 (20:47 +0000)]
comment-only fix to tools/update-doxygen.sh
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
280703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14703
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:42:21 +0000 (20:42 +0000)]
re-land hide get/setLocalMatrix
This reverts commit
b1d702a43b07934f5b001b1b09db2c57ede909a1.
TBR=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
279903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14702
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:40:29 +0000 (20:40 +0000)]
rename rebaseline_server JSON constants to be more consistent
(no behavioral change, no change to JSON file format)
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
287473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14701
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:23:34 +0000 (20:23 +0000)]
bench rebase after 261d015
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
280683002
git-svn-id: http://skia.googlecode.com/svn/trunk@14700
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 12 May 2014 18:12:24 +0000 (18:12 +0000)]
apply localmatrix in pre-order, to match other shaders
BUG=skia:
Review URL: https://codereview.chromium.org/
280293002
git-svn-id: http://skia.googlecode.com/svn/trunk@14699
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 12 May 2014 17:18:45 +0000 (17:18 +0000)]
add new perlin noise gm to test localmatrix
BUG=skia:
Review URL: https://codereview.chromium.org/
283533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14698
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:48:38 +0000 (15:48 +0000)]
Clean up global gSkSuppressFontCachePurgeSpew.
No one is using it except to flick it to true to shut up the spew,
but the spew is already guarded by #ifdef SPEW_PURGE_STATUS. Let's
leave it to SPEW_PURGE_STATUS.
Noticed this specificially when TSAN complained about FontScalerBench
modifying it in a thread-unsafe way.
BUG=skia:1792
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
264333008
git-svn-id: http://skia.googlecode.com/svn/trunk@14697
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:38:00 +0000 (15:38 +0000)]
Make gMask_00FF00FF a constant
This is to optimize SkAlphaMulQ() in PIC mode. With the visibility=default
symbol the constant is not known at compile time (and is not a constant), but
instead is fetched through a double indirection through GOT. The function is
quite hot on one of the chromium benchmarks:
rasterize_and_record_micro.key_silk_cases.
This change replaces the symbol with a compile-time constant. As a bonus the
variable is not exported from the dynamic library, i. e. a cleaner library
interface.
See specific performance improvements on Android here:
http://goo.gl/iMuTDt
R=skyostil@chromium.org, tomhudson@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com
Author: pasko@chromium.org
Review URL: https://codereview.chromium.org/
270473003
git-svn-id: http://skia.googlecode.com/svn/trunk@14696
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:37:20 +0000 (15:37 +0000)]
add --readJsonSummaryPath to render_pictures
BUG=skia:1942
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
273783004
git-svn-id: http://skia.googlecode.com/svn/trunk@14695
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:36:43 +0000 (14:36 +0000)]
Adds the ability to filter bench expectations in builder/config level.
BUG=skia:2539
NOTRY=true
R=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
277163002
git-svn-id: http://skia.googlecode.com/svn/trunk@14694
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:16:19 +0000 (14:16 +0000)]
Improved x86 SSE build and run-time checks.
Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14644
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
272503006
git-svn-id: http://skia.googlecode.com/svn/trunk@14693
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:12:38 +0000 (14:12 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=14651
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14692
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 13:35:55 +0000 (13:35 +0000)]
remove unused Kernel33MaskFilter
R=robertphillips@google.com
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
280233002
git-svn-id: http://skia.googlecode.com/svn/trunk@14691
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 10 May 2014 12:57:48 +0000 (12:57 +0000)]
bench rebase after 108eddb
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
275353002
git-svn-id: http://skia.googlecode.com/svn/trunk@14690
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 10 May 2014 03:04:40 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14689
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 9 May 2014 20:52:23 +0000 (20:52 +0000)]
add localmatrix param to asNewEffect
BUG=skia:
Review URL: https://codereview.chromium.org/
278983002
git-svn-id: http://skia.googlecode.com/svn/trunk@14688
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 20:46:48 +0000 (20:46 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.
Committed: http://code.google.com/p/skia/source/detail?r=14680
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14687
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 20:28:11 +0000 (20:28 +0000)]
add localmatrix parameter to shader's asNewEffect
BUG=skia:
R=bsalomon@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
278963002
git-svn-id: http://skia.googlecode.com/svn/trunk@14686
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 9 May 2014 20:06:57 +0000 (20:06 +0000)]
Revert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"
This reverts commit
9acd04797101990af23f5c374b7dfcbaac12fd2b.
git-svn-id: http://skia.googlecode.com/svn/trunk@14685
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 19:54:42 +0000 (19:54 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
TBR=djsollen@google.com
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
271253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14684
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 19:25:43 +0000 (19:25 +0000)]
Un-swap underline position and thickness calcualtions in DirectWrite.
The change at r13635 got these backwards.
git-svn-id: http://skia.googlecode.com/svn/trunk@14683
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Fri, 9 May 2014 18:08:24 +0000 (18:08 +0000)]
Flatten resources directory
On android trybots, the files in a subdirectory weren't being
loaded onto the device. Consequently, the ImageDecoderOptions
test was not testing anything. I had to relax that unit test
to reflect the existing behavior of our libjpeg decoder on
Android.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
264583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14682
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 18:02:51 +0000 (18:02 +0000)]
Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. (https://codereview.chromium.org/
275903002/)
Reason for revert:
Breaks chrome build.
Original issue's description:
> Factor GrTexture into public GrTexture and private GrTextureImpl.
>
> Committed: http://code.google.com/p/skia/source/detail?r=14680
R=jvanverth@google.com, robertphillips@google.com
TBR=jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
278073002
git-svn-id: http://skia.googlecode.com/svn/trunk@14681
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 17:37:55 +0000 (17:37 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14680
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 9 May 2014 17:24:31 +0000 (17:24 +0000)]
Revert "Flatten resources directory"
Review URL: https://codereview.chromium.org/
278033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14679
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 16:24:06 +0000 (16:24 +0000)]
Flatten resources directory
On android trybots, the files in a subdirectory weren't being
loaded onto the device. Consequently, the ImageDecoderOptions
test was not testing anything. I had to relax that unit test
to reflect the existing behavior of our libjpeg decoder on
Android.
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
264583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14678
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 15:42:07 +0000 (15:42 +0000)]
Revert of hide get/setLocalMatrix (https://codereview.chromium.org/
279563002/)
Reason for revert:
broke gms
Original issue's description:
> hide get/setLocalMatrix
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14675
R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org
TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
278903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14677
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 15:22:41 +0000 (15:22 +0000)]
Allow for no pdf rasterizers in gm.
Our poppler does not build properly with VS2013, but using
gyp_skia -Dskia_enable_poppler_enabled=0
also does not build due to kPDFRasterizers being statically empty.
This adds a do nothing, not run by default 'pdf rasterizer'.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
270263009
git-svn-id: http://skia.googlecode.com/svn/trunk@14676
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 15:19:48 +0000 (15:19 +0000)]
hide get/setLocalMatrix
BUG=skia:
R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
279563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14675
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log