Ed Bartosh [Tue, 25 Feb 2014 11:25:30 +0000 (13:25 +0200)]
Fixed naming of accepted branches
Name of accepted branches were made by replacing ':' to '/' in OBS
project name. That caused conflict between branches for subprojects and
main project, e.g. Tizen:IVI and Tizen:IVI:Genivi. For this pair of
projects accepted branches were named as accepted/tizen/ivi and
accepted/tizen/ivi/genivi. This naming approach creates a conflict as
.git/refs/accepted/tizen/ivi can't be directory (for
accepted/tizen/ivi/genivi) and file (for accepted/tizen/ivi) branches at
the same time.
This issue caused failures on backend to update accepted branches.
Fixed by using '_' instead of '/' in branch names, so above 2 example
branches are named as accepted/tizen_ivi and accepted/tizen_ivi_genivi
now and do not conflict with each other.
Fixes: #1435
Change-Id: I3f253f0d438bf9b455a4fc24de151eefa1903ae5
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lin Yang [Mon, 24 Feb 2014 03:48:04 +0000 (11:48 +0800)]
Remove duplicate function call for SR revoke event
Change-Id: Ie4898a1f0abc62830e344c57851c0b998954b309
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Thu, 13 Feb 2014 11:57:10 +0000 (13:57 +0200)]
Fixed bug in cleanup job
Cleanup job now takes project name either from 'project' or 'sourceproject'
field of the event structure, passed from OBS.
Previously it was taking project name only from 'project' field, which is set
for OBS_REPO_PUBLISHED event and is not set for SR_ACCEPTED event.
This was the reason for not removing prerelease projects when SR is accepted.
Fixes: #1649
Change-Id: Ie9d37f0dbba7e9d92a436e755ec0a32d636f7d3c
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Alexander Kanevskiy [Sat, 14 Dec 2013 21:34:04 +0000 (23:34 +0200)]
Removing unused imports from common/prerelease.py
Change-Id: I1a5bfe5b390d0ee01bebb3e155565d2064b3d39a
Ed Bartosh [Sat, 15 Feb 2014 16:09:58 +0000 (18:09 +0200)]
Remove prerelease project when SR is accepted
Prerelease projects should be removed from OBS when their SRs are
accepted as they're not needed anymore.
Fixes: #1649
Change-Id: I7563e19ac2c4be21b1530d110ff771fd996ba7cc
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 15 Feb 2014 15:34:53 +0000 (17:34 +0200)]
Fixed crash in job_requests
job_requests code assumes that GIT_AUTHOR_EMAIL is set and crashes when
SR is created by repa:
info sending mail for OBS_SRCSRV_REQUEST_ACCEPTED obs_request_accept
Traceback (most recent call last):
File "/var/lib/jenkins/jenkins-scripts/job_request.py", line 342,
sys.exit(main())
File "/var/lib/jenkins/jenkins-scripts/job_request.py", line 307, in
notify_submiter(event_fields, data)
File "/var/lib/jenkins/jenkins-scripts/job_request.py", line 281, in
os.getenv('EMAIL_TEMPLATES_DIR'))
File "/var/lib/jenkins/jenkins-scripts/requests/mailer.py", line 267,
if isinstance(request_data[_to], list):
KeyError: 'GIT_AUTHOR_EMAIL'
The reason for this is that repa's SRs don't have 'Submitter' field,
which is used to set GIT_AUTHOR_EMAIL. However, it's not mandatory as
even current code gets submitter name and email from git.
This change sets GIT_AUTHOR_EMAIL using information from git.
Fixes: #1653
Change-Id: I4349687d04717e11f0cbe42819a75356fd029a61
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 15 Feb 2014 15:10:42 +0000 (17:10 +0200)]
Skipped notification about SR creation for prerelease projects
As repa creates SRs and immediately accepts/rejects them there is no
need to notify submitter about SR creation as he/she will be anyway
notified about SR acceptance or rejection.
Fixes: #1655
Change-Id: Ice23ca4338c1b5de0e64117abec10b4ed5d167b0
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 15 Feb 2014 13:02:21 +0000 (15:02 +0200)]
Do not notify submitter when SR is revoked
This is done to stop confusing developers by sending them notifications
about revoked SRs. SRs are revoked because submissions are accepted by
repa tool.
Fixes: #1652
Change-Id: I2663899ef9a90538c89fc4f485ef34e6cacd2203
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 15 Feb 2014 12:53:54 +0000 (14:53 +0200)]
Delete package when SR is revoked
OBS event OBS_SRCSRV_REQUEST_REVOKED was not processed correctly in
job_requests and projects were not deleted.
Fixes: #1654
Change-Id: I92e47978e20c7e111af332e7a082037f3d8eb140
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Hasan Wan [Tue, 18 Feb 2014 03:00:50 +0000 (05:00 +0200)]
Fix the prerelease repo inconsistent with new repo structure issues
Fixes: #1658
Change-Id: If66d81ec1ceeebd4438c20c9251be5fc73d56892
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Tue, 18 Feb 2014 02:53:11 +0000 (04:53 +0200)]
use modifyrepo_c to modify repo
keep the groups.xml and patterns.xml in repo to avoid the patterns
not found issues
Fixes: #1657
Change-Id: Ia5701206386ae056ba2a735048336b22dae24aab
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lingchaox Xin [Tue, 11 Feb 2014 09:10:46 +0000 (17:10 +0800)]
Limit python-requests version 2.0.1+ to have a good no_proxy support
Since python-requests in our Service Repo is 1.1.0 version, we need
upgrade it to a higher version(now the latest is 2.2.1).
Change-Id: I1bfcf1c5de2b0c7998d3615bb5b7fc658b88bd97
Lingchaox Xin [Mon, 10 Feb 2014 09:23:23 +0000 (17:23 +0800)]
Fix `IOError: [Errno 2] No such file or directory` when sync diff
Change-Id: I1c128842679e7c6f220103dc929055fb8210a8bc
Alexander Kanevskiy [Sat, 14 Dec 2013 21:32:05 +0000 (23:32 +0200)]
Fix pylint warning: redefining build-in function 'map'
W: 44, 8: Redefining built-in 'map' (redefined-builtin)
Change-Id: Ia657e719a565c3924c8505c3e9be910ea1e039c9
JF Ding [Sat, 8 Feb 2014 09:04:16 +0000 (17:04 +0800)]
Added GPLv2 COPYING file and correct the License in spec
Because we have passed the company's open-sourcing approval long before,
we need to align the license description in spec file accordingly.
And added the license file for GPLv2 by the way, the source of copy:
http://www.gnu.org/licenses/gpl-2.0.txt
Change-Id: Ibb49999d8fca9f5eeb234fc5372f016d387e0fbc
Signed-off-by: JF Ding <jian-feng.ding@intel.com>
Ed Bartosh [Fri, 24 Jan 2014 15:30:55 +0000 (17:30 +0200)]
job_policycheck: Check if packaging directory exists
Check if packaging/ directory exists before running gbs export.
Otherwize it will crash this way:
running command: "git clone
ssh://tizenrobot@review.tizen.org:29418/sdk/ide/webapp-eplugin
--reference /var/lib/jenkins/git/sdk/ide/webapp-eplugin.git
/var/lib/jenkins/jobs/policy-check/workspace/_wBiPn/sdk/ide/webapp-eplugin
", with output::
+-------------- | Cloning into
/var/lib/jenkins/jobs/policy-check/workspace/_wBiPn/sdk/ide/webapp-eplugin...
+--------------
gbp:debug: git fetch --quiet --tags origin refs/changes/29/13329/2
gbp:debug: git checkout --quiet FETCH_HEAD
packaging dir is
/var/lib/jenkins/jobs/policy-check/workspace/_wBiPn/sdk/ide/webapp-eplugin/packaging
gbp:debug: git checkout --quiet FETCH_HEAD
Traceback (most recent call last):
File "jenkins-scripts/job_policycheck.py", line 196, in <module>
sys.exit(main())
File "jenkins-scripts/job_policycheck.py", line 172, in main
if not export(prjdir, packagingdir, mygit, events, mygerrit):
File "jenkins-scripts/job_policycheck.py", line 62, in export
tempd = tempfile.mkdtemp(dir=os.path.join(prjdir, packagingdir))
File "/usr/lib64/python2.7/tempfile.py", line 318, in mkdtemp
_os.mkdir(file, 0700)
OSError: [Errno 2] No such file or directory:
'/var/lib/jenkins/jobs/policy-check/workspace/_wBiPn/sdk/ide/webapp-eplugin/packaging/tmpG92RZU'
Fixes: #1506
Change-Id: Ib73b64724ad60358328243f346a04331429327ef
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Fri, 24 Jan 2014 12:34:00 +0000 (14:34 +0200)]
common/mapping.py: Improve xml parsing error handling
Added local exception MappingError and properly process it in
policycheck job.
Fixes: #1541
Change-Id: I3e4ab8a7ec150933876ecb4f02461406833b8e6d
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lingchaox Xin [Fri, 24 Jan 2014 07:43:52 +0000 (15:43 +0800)]
Add index.html in templates in spec
This will fix `jinja2.exceptions.TemplateNotFound: index.html` error.
Change-Id: Ic73be70bedb67372c7cd414f123375894b4c90b5
Lingchaox Xin [Thu, 23 Jan 2014 09:56:41 +0000 (17:56 +0800)]
Fix IndexError when repo info has no element
Change-Id: Id2764928ab6ca99c88f5ad330e1bcf1c023159c8
Lingchaox Xin [Thu, 23 Jan 2014 09:43:10 +0000 (17:43 +0800)]
Adapt for new interface in python-snapdiff
Change-Id: I46725b4ee8caeb1de0488c32091ed11a0af1e36a
Lingchaox Xin [Thu, 9 Jan 2014 07:55:38 +0000 (15:55 +0800)]
Split trigger_image_creation function into two parts
From now on, triggering jobs and preparing trigger data are
independent, and it is more readable.
Change-Id: Ie2ab0a9cec388751b6805f2ec6cdbaf63ae2b5f7
Hasan Wan [Fri, 13 Dec 2013 07:30:19 +0000 (07:30 +0000)]
use the new repo structure
Change-Id: Ideebe8d0bcf0deeaa6988fd5e921f4c031bf5183
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Mon, 6 Jan 2014 03:11:53 +0000 (03:11 +0000)]
create the latest repo link
Change-Id: I6ab84a1c80a1881e243b096c964bad0c6cd80929
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Mon, 6 Jan 2014 02:57:00 +0000 (02:57 +0000)]
remove unused function
Change-Id: I99a3c65d00163b78df2885d1850c6f4e94b99c2d
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lingchaox Xin [Tue, 24 Dec 2013 10:02:40 +0000 (18:02 +0800)]
Integrate snapdiff into jenkins-scripts
Change-Id: Idaf2791be10ab1d0e72536200c11c065692024f2
Hasan Wan [Fri, 13 Dec 2013 07:34:46 +0000 (07:34 +0000)]
fix a potenntial bug about find package-groups package
Change-Id: Id9857210eb1561fbf8a4ce77ddd27dcd1b1f274f
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Alexander Kanevskiy [Sat, 14 Dec 2013 21:15:11 +0000 (23:15 +0200)]
Fix format string operation
Change-Id: I9e4ee98e51e22d3e82e6147af344d03b4529caf1
ZhuoX Li [Fri, 13 Dec 2013 09:34:31 +0000 (17:34 +0800)]
Add unitest testcase for gbs interface
Change-Id: Ia8eb7d35ac9c7478433acb5a8052c2a5f840faa6
ZhuoX Li [Fri, 13 Dec 2013 09:33:45 +0000 (17:33 +0800)]
Add unitest testcase for gbp interface
Change-Id: I362d3e0563d56b5dfc7df4fd8a2285b9bb243772
Lin Yang [Tue, 10 Dec 2013 08:55:40 +0000 (16:55 +0800)]
Combine all repos build result into one comments
Change-Id: I565f3856072776f20505411e83ec21eafc848104
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Tue, 10 Dec 2013 12:00:33 +0000 (20:00 +0800)]
Add profile info into accept tag name
Change accept tag name format to accept/{OBS_PRJ_NAME}/{DATE.TIME} to insert
profile info.
Fixes: #1511
Change-Id: I1d1e5087e3966e4ec52b804c631037c7cfef8093
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Sun, 8 Dec 2013 11:37:35 +0000 (13:37 +0200)]
policycheck: Check if specs found in packaging/ directory
If there is no spec files in packaging/ directory job should fail and
send message back to gerrit informing submitter about the issue.
Change-Id: Ib6a129fe94fc9e011fd9b33be31f4083b6d73bc2
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 8 Dec 2013 11:41:46 +0000 (13:41 +0200)]
policycheck: fail the job if gbs export fails
If gbs export fails job should fail as this is definitely policy issue.
Ignoring this doesn't make sense.
Change-Id: Ibf377af948e229d6c01f5cb3bda7bdeba83ea07e
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 8 Dec 2013 11:30:23 +0000 (13:30 +0200)]
policycheck: Check if packaging/ directory exist
if there is no packaging/ directory in the project policycheck should
fail and send message back to Gerrit.
Currently if project doesn't have packaging directory job produces
non-informative traceback:
Traceback (most recent call last):
File "jenkins-scripts/job_policycheck.py", line 196, in <module>
sys.exit(main())
File "jenkins-scripts/job_policycheck.py", line 172, in main
if not export(prjdir, packagingdir, mygit, events, mygerrit):
File "jenkins-scripts/job_policycheck.py", line 62, in export
tempd = tempfile.mkdtemp(dir=os.path.join(prjdir, packagingdir))
File "/usr/lib64/python2.7/tempfile.py", line 318, in mkdtemp
_os.mkdir(file, 0700)
and doesn't report anything back to submitter.
Fixes: #1526
Change-Id: Ic98c26e04c45ff22eeb9136acfe006159d9eff5c
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 8 Dec 2013 13:06:11 +0000 (15:06 +0200)]
Catch backenddb EntityError exception
When there is no map for some OBS project backenddb API raises
EntityError exception. It should be catched.
Fixes: #1528
Change-Id: I4c7fa8c5562c4d01a5d9b67e9a4a5d1d38e4b082
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 8 Dec 2013 10:15:03 +0000 (12:15 +0200)]
Check if key is in mapping to avoid KeyError
This change should fix KeyError traceback in parsing description. In
current code everything with ':' is considered as key:value, which is
incorrect assumption as ':' is a very common symbol.
Fixes: #1524
Change-Id: I29deb4e410ba820535e09d8c4808894296c40cda
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 9 Dec 2013 18:17:08 +0000 (20:17 +0200)]
job_pre_release_gerrit: Check if prerelease enabled for OBS project
To avoid triggering workflow for all projects prerelease_enabled
function is implemented and used in job_pre_release_gerrit to filter out
unrelated projects.
Fixes: #1531
Change-Id: I65f3cd98bedacf61e7dae769b94f4c7091c52d4a
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 9 Dec 2013 09:32:41 +0000 (11:32 +0200)]
Fixed linking and unlinking repositories
Linking and unlinking was changing only first repository in the project.
The rest repos were left unchanged.
Fixes: #1530
Change-Id: Ia40fc6249f244644375a1b71f2c9a8ddfccc2067
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Wed, 4 Dec 2013 12:26:29 +0000 (14:26 +0200)]
Check return code of sync function
When sync filed job_imager should also fail.
Fixes: #1513
Change-Id: I261b6c1844f1c2aa2e19e8b968f08a39d4b93e96
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Hasan Wan [Wed, 4 Dec 2013 06:44:22 +0000 (08:44 +0200)]
fix the releaesid key name mistake when update value
Change-Id: I08168e89393b7d49e4b20bd49fe4931257d61119
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Wed, 4 Dec 2013 06:42:22 +0000 (08:42 +0200)]
Fix a typo when get exception
Change-Id: I9761ec87c71684b0c060f75d4e906bff8388bdca
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Wed, 4 Dec 2013 06:15:40 +0000 (08:15 +0200)]
enable createrepo_c for repomaker
Change-Id: I53166ed7cace598b7b7e569f9c9fa425d148560f
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Ed Bartosh [Mon, 2 Dec 2013 16:39:22 +0000 (18:39 +0200)]
Code cleanup of job_pre_release_obs
Pylinted + code cleanup.
Change-Id: Ifaa2adb1cd57d5dcaeee5f0abf7e4871266960d2
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 1 Dec 2013 21:17:07 +0000 (23:17 +0200)]
Cleanup prerelese repos from all snapshots
When cleaning up prerelease repos we should consider all snapshots, not
just the latest one.
Change-Id: I85b2d1dfedeb979eaf135ca5f4416ef54c3fbb93
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sun, 1 Dec 2013 20:16:56 +0000 (22:16 +0200)]
Reimplemented logic of finding published repos
Current logic assumes that all repos of one OBS projects have the same
snapshot id, which is not always true. First of all due to the bug in
boss-repomaker they're always different. Second, for one OBS project
some repos can be published, but some can't because of package build
failures, so snapshot ids can be different for different repos in the
same project and they has to be found and cleaned up.
As it's impossible to find repo only by OBS project name more
sophisticated logic should be used:
- Find all keys, starting from OBS prject name
- Part after colon may be repo name
- Repo name should not contain colon as some projects may have the same
prefix, e.g. Tizen:IVI and Tizen:IVI:Release
Change-Id: I018105dc52244d8530b26daa5a4b47bf6cc6ea1a
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 2 Dec 2013 16:11:11 +0000 (18:11 +0200)]
Used repo name as a part of release key
PartOf and Release keys in repos.yaml are not uniq. Using them as a
uniq identifier leads to breakage of workflow as they're continuously
rewritten by repomaker for every snapshot for the repos with the
same PartOf and Release keys in repos.yaml
This change uses repo name instead of PartOf and Release. Name is
uniq in repos.yaml, so this should hopefully fix the issue.
Note, that this change requires repomaker to store release ids using
repo name. This is done in this change:
https://otctools.jf.intel.com/review/#/c/8189/
Change-Id: I63e033bff640ec2ae93e1d522dce55758aff2acd
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 2 Dec 2013 16:06:38 +0000 (18:06 +0200)]
Pylinted job_pre_release_obs.py
Change-Id: I65f7ff443ecfbb941f91cd8bf2e92ada2d6f82fc
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 30 Nov 2013 15:34:37 +0000 (17:34 +0200)]
Refined warning message
This is quite important message. Let's make it a bit more clear.
Change-Id: I3653a702511d06e1e93e7697cab5ea3e7cfd85f4
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 2 Dec 2013 15:57:39 +0000 (17:57 +0200)]
Used OBS repo to find repo name from repos.yaml
This is an adaptation of job_pre_release_obs and job_create_snapshot to
the change in the key format for obs -> repo mappings. Now OBS repository
is also used to find repo name. This change passes OBS repository to
Snapshot class to find repo name properly.
Change-Id: I30adf0c8f3efceaabeec77a468613cacf2ec1e23
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Sat, 30 Nov 2013 14:59:25 +0000 (16:59 +0200)]
Added obs repository as a part of obs->repo mapping
OBS project can be mapped to multiple repo names in repos.yaml depending
on obs repository, for example:
Tizen:Mobile OBS project currently maps to 3 repos:
Tizen-mobile for OBS repo atom,
Tizen-mobile-rd-pq for OBS repo arm,
Tizen-emulator for OBS repo emulator.
so, it's not possible to find repo name by using OBS project.
OBS repository should be taken into consideration as well.
This is a serious design fault in the current code.
This change is trying to fix this by using <OBS project>:<OBS repository>
key in obs->repo mapping API.
Change-Id: Ibfb7b77b3efbbbde65d8deeff1b90e08e0695977
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lin Yang [Thu, 28 Nov 2013 03:39:53 +0000 (11:39 +0800)]
Clean up use obsolete function end()
Because end() function has been already removed, should not use it any more.
Change-Id: Id02d2e7aaec145236557b8fa228098e818e2aeb1
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Thu, 28 Nov 2013 03:24:11 +0000 (11:24 +0800)]
Change return code when init TempPackage exception
One buildcheck project will send out multiply OBS_REPO_PUBLISH_STATE events, the
first build will delete this project, the following builds will rasie this
exception. In this case, it should return 0.
Change-Id: I6816b9fe61cb9b4e9a6baaae9b415587795fccfc
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lingchaox Xin [Wed, 27 Nov 2013 02:58:18 +0000 (10:58 +0800)]
Fix is_new_package method not found
It is not fixed completely in 9340906 commit
Change-Id: I862e941d0b78f4cb8b68818da59d924335f3cb71
Lin Yang [Wed, 27 Nov 2013 06:34:39 +0000 (14:34 +0800)]
Return directly if post comment to gerrit failed
Change-Id: I3f4c7c5da7089645caaecfb49970ce60d5da656b
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Hasan Wan [Fri, 22 Nov 2013 03:25:24 +0000 (03:25 +0000)]
Trigger the next job with project name info
Change-Id: I5b8e1534a445fb340f9ffdad38bc02cb32f4e109
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lin Yang [Thu, 21 Nov 2013 07:06:50 +0000 (15:06 +0800)]
Catch GerritError when post comment back to gerrit
Change-Id: Ie00925f18f10cca8560e65e45f934758f2395cb7
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Tue, 26 Nov 2013 07:03:28 +0000 (15:03 +0800)]
Enable more flexible pattern to sync code
When sync code from outside to inside gerrit, need more flexible pattern to
control which refname need to be synced, like only sync one branch.
Change-Id: I65bafca9574c7d7a0a89d728fefc4b08e4132a0a
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Wed, 20 Nov 2013 06:15:51 +0000 (14:15 +0800)]
Split the output of _git_inout to lines
Change-Id: I93f4ff3bd892137806e151015d841e29ae21cb81
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Hasan Wan [Fri, 15 Nov 2013 07:24:26 +0000 (09:24 +0200)]
Fix the image creation job not trigger issues
Fixes: #1462
Change-Id: Ia07fdf3132a7a61b65df622ef9b289931d5691a0
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Change-Id: I3b35bf56963106674e46c49c5c485a9d9b76d4fb
Hasan Wan [Fri, 15 Nov 2013 04:21:02 +0000 (06:21 +0200)]
job_submit.py are required in jenkins-scripts package
Change-Id: I7e40d106cd74fb3199d4e49c7f423401eef0aea3
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lin Yang [Wed, 13 Nov 2013 07:15:43 +0000 (15:15 +0800)]
Do not need to specify specfile when gbs rb
Because gbs can automatically handle multiply specfile issue, don't need to
specify specfile in gbs command any more.
Change-Id: I09707dc3f66302a4362dea5057743314d59aa1b9
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Tue, 12 Nov 2013 15:30:45 +0000 (17:30 +0200)]
Used atexit to remove temporary directories
Change-Id: I171819fa87dea5933bbbe1592a6ffd759683b410
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Tue, 12 Nov 2013 12:39:24 +0000 (14:39 +0200)]
job_submitobs: Pylinted
Change-Id: Ic250816f3d8a091f37d8d30bc448180fb518a927
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Tue, 12 Nov 2013 11:53:44 +0000 (13:53 +0200)]
Moved ref sync from job_sync_git to job_submitobs
This is done to avoid submitting to obs on sync instance if sync fails.
It's impossible to do when jobs are running asynchronously.
This change also reduces amount of code as it removes duplication
code used in both jobs.
Fixes: #1437
Change-Id: Iba10ec0126963b65296ba516cc7215a86212db36
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 11 Nov 2013 19:24:08 +0000 (21:24 +0200)]
Catch git errors, print error message.
Fixes: #1407
Change-Id: Ifaa3dc82da2d094582c075b49905138ec6813997
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lin Yang [Wed, 13 Nov 2013 06:51:36 +0000 (14:51 +0800)]
No need to checkout upstream pristine-tar branch
Because gbs new version can automatically checkout upstream and pristine-tar
branch before gbs export, don't need to checkout these branches manually.
Change-Id: I477070020fa38e1651a46a6727b9d366045b1ad0
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Mon, 11 Nov 2013 19:06:24 +0000 (21:06 +0200)]
Catched git errors
Used _git_inout instead of deprecated _git_getoutput.
Catched errors and raised local exception.
Change-Id: Ib7e844a0740e1215c18e8862dabedd0a5add5307
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Tue, 12 Nov 2013 16:16:56 +0000 (18:16 +0200)]
Pylinted common/buildservice.py
Fixed one typo. Got rid of unused variables.
Change-Id: Icf597b912100dd0f6e60b88dca990d87b55cc678
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Tue, 12 Nov 2013 16:02:56 +0000 (18:02 +0200)]
Catch urllib2.URLError
Caught urllib2.URLError exception. Included more info into error
message.
Fixes: #1408
Change-Id: Ib86635c50e305e8228cf62840c9cee527bc42bc8
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lingchaox Xin [Thu, 14 Nov 2013 05:42:45 +0000 (13:42 +0800)]
Fix rpm packaging bug
Remove `/var/lib/jenkins/userContent/jenkins-scripts' link only when
uninstall the package.
Change-Id: I8fffb85cb60b6b5bd0f12796281404b4d50fdb6b
Lingchaox Xin [Wed, 13 Nov 2013 07:00:02 +0000 (15:00 +0800)]
Fix creating temp workspace since packaging dir is a relative path
Change-Id: I362547d80ea7537fd5cd0c2b8a2dbf7fb3c86de0
Lingchaox Xin [Tue, 29 Oct 2013 08:54:04 +0000 (16:54 +0800)]
Check whether `gbs export` succeeds before remote building
Feature #1396
Change-Id: Iedfadd42d40e759dafdcb16d9d221890270b24f1
Lin Yang [Mon, 11 Nov 2013 14:08:24 +0000 (22:08 +0800)]
Check whether need to sync project to inside obs
For sync instance, need to check whether this project match the regular
expression in jobs/configuration to sync this submission to inside obs.
Fixes: #1426
Change-Id: Ide8addde38a40dab1487d7d97f1a477dc6dbdbff
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Hasan Wan [Mon, 11 Nov 2013 06:26:17 +0000 (06:26 +0000)]
Generate repo manifest file
Fixes: #1392
Change-Id: I1f6b055ec59ad8bc5caaef681ff09bc08bd5c9d3
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Wed, 6 Nov 2013 03:17:34 +0000 (03:17 +0000)]
Keep another copy of buildconf in repodata
Change-Id: I530a4287b8bd692bbf065244cb4367211b729ed1
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Wed, 6 Nov 2013 03:16:59 +0000 (03:16 +0000)]
Fix a mistake of previous patch
Change-Id: I861a910652999013830d2eba20d3eebc66fa42fd
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lin Yang [Fri, 8 Nov 2013 06:33:02 +0000 (14:33 +0800)]
Fix delete obs package failure in linked project
Before delete obs package, we should make sure this package still exist in obs.
Origin function bs.exists() will return true if this package don't exist in this
project, but in another linked project. So move to get_package_real_project_name
to check it.
Fixes: #1428
Change-Id: I969aac13df6df532694ef7ed3a30adfc8e7ec5c1
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Fri, 8 Nov 2013 04:40:25 +0000 (12:40 +0800)]
Fix create symlinks under userContent failure
Safer way to rewrite the symlink when install and upgrade package.
Fixes: #1433
Change-Id: I4f62f47255faae35010316082e665b52466200d6
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Mon, 4 Nov 2013 15:39:57 +0000 (17:39 +0200)]
Catch GerritError exception
Wrapped gerrit.Gerrit.* calls into try/except to catch GerritError
exception and produce human-readable error messages.
Fixes: #1436
Change-Id: Id7aec6ced7a8803987eb765e51bc667f0b4de557
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 4 Nov 2013 14:48:05 +0000 (16:48 +0200)]
Refactored common/gerrit
Now Gerrit class raises GerritException when it gets non-zero return
code from ssh gerrit interface. Previously errors were silently ignored.
Change-Id: I68d48a010c3427e00daa1306127de5e3b9e17bbd
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Hasan Wan [Mon, 4 Nov 2013 07:48:18 +0000 (09:48 +0200)]
retry the obs operation when get ObsError
Fixes: #1103
Change-Id: I68d5935133b94167456a2d81bc747bdaa5e14342
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Mon, 4 Nov 2013 07:17:53 +0000 (09:17 +0200)]
make retry function as decorator
Change-Id: Ibbe7114af871b3cafc2dde6e4085b52e6737f20e
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Thu, 31 Oct 2013 04:14:57 +0000 (04:14 +0000)]
move xml2obj to common/utils
Change-Id: Ie4dac18217667e0095cad8c2ca958055c949d656
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Thu, 31 Oct 2013 03:53:19 +0000 (03:53 +0000)]
Trigger post snapshot creation jobs after snapshot created
Change-Id: I702320a5eff7af494c1725a0358bbd78a6b574f8
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Hasan Wan [Thu, 31 Oct 2013 03:03:41 +0000 (03:03 +0000)]
Fix an error with the project init
Change-Id: Ic979ab0574df02b23b65f3f9374a2b7bf30fdfc0
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Lin Yang [Thu, 31 Oct 2013 07:55:47 +0000 (15:55 +0800)]
Fix no logfile exception in buildcheck job
If obs package is in some states, like unresolvable, it will throw exception
when try to fetch build log for this package. And we need to send out build log
only for build failed package.
Fixes: #1429
Change-Id: I3f3754bc7200b15d720d8f23de86015110cd426f
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lingchaox Xin [Tue, 29 Oct 2013 08:51:57 +0000 (16:51 +0800)]
Handle gbs commands errors
Before this, gbs errors will be ignored
Fix #1406
Change-Id: I4f0db8902e23567c5ef0615f50279b952a4e654a
Lingchaox Xin [Tue, 29 Oct 2013 02:00:25 +0000 (10:00 +0800)]
Use oscapi directly rather than invoke core.meta_exists
Change-Id: I9b7945c56d385b032cb8b965d2b47c3e7c25e080
Lin Yang [Fri, 25 Oct 2013 04:12:55 +0000 (12:12 +0800)]
Fix import gbp.rpm.parse_spec failure
In gbp new version, it change parse_spec() function name to SpecFile().
Fixes: #1419
Change-Id: I74bb5971080038e89a573dd5b86cc2567600de9f
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Mon, 28 Oct 2013 06:18:30 +0000 (14:18 +0800)]
Fix submitobs job cannot send out email
Use ${BUILD_TAG}.env file as file parameter, instead of ${random}.mail.env, to
trigger downstream job mail-sender to match jenkins job conf change.
Fixes: #1422
Change-Id: Ie791588eaadd26036b0e909427023cb07ff5fb91
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Tue, 29 Oct 2013 02:43:38 +0000 (10:43 +0800)]
Handle manually created requests in obs
The description section format of requests manually created by admin is
different as default format, so catch this kind of exception when trying parse
the request description and ignore this request.
Fixes: #1397
Change-Id: Ibba0406fa1161cf2f0fc519d545e610e339fecf5
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lin Yang [Mon, 28 Oct 2013 11:53:07 +0000 (19:53 +0800)]
Change tools repo to otctools obs repo
To get the latest released tools, change tools dependency repo from tizen.org
repo to otctools obs repo.
Change-Id: I1c5320a89535636e6492d1b45f7128f309dde829
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Wed, 23 Oct 2013 11:31:44 +0000 (14:31 +0300)]
Fixed KeyError exception in job_load_repos
This happened in production:
Traceback (most recent call last):
File "jenkins-scripts/job_load_repos.yaml.py", line 75, in <module>
sys.exit(main())
File "jenkins-scripts/job_load_repos.yaml.py", line 70, in main
update_repos_conf_on_filesystem(os.path.join(prjdir, 'repos.yaml'))
File "jenkins-scripts/job_load_repos.yaml.py", line 47, in
update_repos_conf_on_filesystem
repo['SnapshotDir'])
KeyError: 'SnapshotDir'
Change-Id: I8fe89fa7f509f001824215791cee4f24be6e1a9d
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lin Yang [Tue, 22 Oct 2013 13:09:35 +0000 (21:09 +0800)]
Fix push to heads/accepted/* hierarchy failure
When parse one tag info, it should return the commit id the tag attached, not
the hash number the tag itself.
Fixes: #1395
Change-Id: I7f82c84c35924a42d67dc7b8e17e7c9c48e13b3a
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Lingchaox Xin [Tue, 24 Sep 2013 02:59:55 +0000 (10:59 +0800)]
Catch git push tag exception
Fixes: #1344
Change-Id: I2b174f5ce142a54353361b6e03c8febfc01472e4
Signed-off-by: Lingchaox Xin <lingchaox.xin@intel.com>
Hasan Wan [Thu, 17 Oct 2013 07:23:00 +0000 (07:23 +0000)]
Add a new scripts to generate the buildlogs dir for snapshots
Change-Id: I91934f21fd9c15f7a834312d2ccf4a1dc075bbc6
Signed-off-by: Hasan Wan <hasan.wan@intel.com>
Ed Bartosh [Thu, 17 Oct 2013 14:21:30 +0000 (17:21 +0300)]
Moved userContent/jenkins-scripts symlink to -common
userContent/jenkins-scripts symlink should be in -common for two
reasons:
- it's used by also by -sync instances.
- jenkins-scripts directory exists in -common package
Change-Id: Ia82d4e44c511bd3765da0dc0dee5222624a4d3b0
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Lin Yang [Tue, 15 Oct 2013 12:58:35 +0000 (20:58 +0800)]
Auto create symlinks to jenkins-scripts
In %post section, automatically create symlinks /var/lib/jenkins/userContent/
jenkins-scripts to /var/lib/jenkins/jenkins-scripts.
Fixes: #1356
Change-Id: Ib8972db7bb1db616db377a0c3a4fca5f33e33ee5
Signed-off-by: Lin Yang <lin.a.yang@intel.com>
Ed Bartosh [Tue, 15 Oct 2013 10:28:18 +0000 (13:28 +0300)]
Deleted job_deletetag
The reason is that we don't need to delete any tags. We may need another
job to delete old tags, but we don't need to delete them just because
the change was rejected like job_deletetag does.
Moreover job_deletetag has bugs. It may end up in infinite loop if it
can't force push to git repo. Removing the job automatically fixes this
issue.
Fixes: #1379
Change-Id: I182f8abdaa6f656edc8bb686698fffebbfa41092
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Ed Bartosh [Mon, 14 Oct 2013 11:57:57 +0000 (14:57 +0300)]
Improved error handling in job_mail_sender
Now jobs performs sanity check for configuration parameters and returns
1 if it fails.
Fixes: #1225
Change-Id: I4c7223589ec601f22b1675f75dacaa1388e05c33
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>