Chip Salzenberg [Thu, 6 Mar 1997 15:46:34 +0000 (03:46 +1200)]
Make conversion of @_ to real array work right after C<shift>
Norbert Pueschel [Sat, 8 Mar 1997 11:50:15 +0000 (12:50 +0100)]
AmigaOS hint patch
92 compiles and tests 100% under AmigaOS and NetBSD 1.2.
The following patch is needed to prevent Configure from
blowing up pdksh. Don't ask me why, I haven't the foggiest idea. :-(
p5p-msgid:
77724767@Armageddon.meb.uni-bonn.de
Chip Salzenberg [Thu, 6 Mar 1997 15:46:37 +0000 (03:46 +1200)]
Warn on %{+undef} and @{+undef}
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[differences between cumulative patch application and perl-5.003_92]
Perl 5 Porters [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[inseparable changes from match from perl-5.003_91 to perl-5.003_92]
CORE LANGUAGE CHANGES
Subject: Strictly follow lexical context of C<eval ''> and nested subs
From: Chip Salzenberg <chip@perl.com>
Files: op.c
Subject: Make ::SUPER and UNIVERSAL work together
From: Chip Salzenberg <chip@perl.com>
Files: gv.c pod/perlguts.pod
CORE PORTABILITY
Subject: OS/2 patches
Date: Wed, 5 Mar 1997 22:08:43 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: hints/os2.sh lib/ExtUtils/MakeMaker.pm t/op/taint.t
Msg-ID:
199703060308.WAA22211@monk.mps.ohio-state.edu
(applied based on p5p patch as commit
eda4d5189d403b15f244b4696a710fb91d15053e)
Subject: VMS patches
Date: Wed, 05 Mar 1997 23:10:24 -0500 (EST)
From: Charles Bailey <bailey@HMIVAX.HUMGEN.UPENN.EDU>
Files: lib/ExtUtils/MM_VMS.pm lib/ExtUtils/Manifest.pm perlsdio.h t/op/runlevel.t t/op/taint.t vms/descrip.mms vms/perly_c.vms vms/sockadapt.c vms/sockadapt.h vms/vms_yfix.pl
private-msgid: 01IG5SQE4A6U00661G@hmivax.humgen.upenn.edu
DOCUMENTATION
Subject: Add taint checks and srand to perldelta
Date: Sun, 2 Mar 1997 11:56:08 -0800 (PST)
From: Tom Phoenix <rootbeer@teleport.com>
Files: pod/perldelta.pod
Msg-ID: Pine.GSO.3.95q.
970302115355.23058D-100000@kelly.teleport.com
(applied based on p5p patch as commit
b28e0bc0aa3232e18d1bacb3efcbfb755ad100e0)
Subject: Don't call FileHandle 'deprecated'
From: Chip Salzenberg <chip@perl.com>
Files: pod/perldelta.pod
Subject: Improve sample module header
Date: Sat, 01 Mar 1997 10:32:31 -0700
From: Tom Christiansen <tchrist@jhereg.perl.com>
Files: pod/perlmod.pod
Msg-ID:
199703011732.KAA14693@jhereg.perl.com
(applied based on p5p patch as commit
3e1e15658152387f41e00ded4796cede4e1e10d3)
Subject: Update list of CPAN sites
Date: Sun, 2 Mar 1997 16:54:22 +0200 (EET)
From: Jarkko Hietaniemi <jhi@iki.fi>
Files: pod/perlmod.pod
Msg-ID:
199703021454.QAA07446@alpha.hut.fi
(applied based on p5p patch as commit
9423903e60e6c92c1893f5f4cab2476f403f8a4b)
Subject: Enhance description of 'server error'
Date: Tue, 4 Feb 1997 21:03:23 +0200 (EET)
From: Jarkko Hietaniemi <jhi@cc.hut.fi>
Files: pod/perldiag.pod
private-msgid:
199702041903.VAA16070@alpha.hut.fi
Subject: Regularize format of E-Mail addresses in *.pod
From: Chip Salzenberg <chip@perl.com>
Files: pod/*.pod
LIBRARY AND EXTENSIONS
Subject: Use IV instead of double for tms structure members
From: Chip Salzenberg <chip@perl.com>
Files: ext/POSIX/POSIX.xs
OTHER CORE CHANGES
Subject: Make sure $^X is tainted when ARG_ZERO_IS_SCRIPT
From: Chip Salzenberg <chip@perl.com>
Files: toke.c
Subject: Clarify '-T too late' error
From: Chip Salzenberg <chip@perl.com>
Files: perl.c pod/perldiag.pod
Subject: Warn when redefining or undefining a constant sub
From: Chip Salzenberg <chip@perl.com>
Files: pod/perldiag.pod pp.c sv.c
Subject: Don't generate spurious 'not imported' warning
From: Chip Salzenberg <chip@perl.com>
Files: gv.c t/pragma/strict-vars pod/perldiag.pod
Subject: Clarify message re: @host in string
From: Chip Salzenberg <chip@perl.com>
Files: pod/perldiag.pod pod/perltrap.pod toke.c
Subject: Disconnect refs that are targets of pp_readline
From: Chip Salzenberg <chip@perl.com>
Files: pp_hot.c
Subject: Fix typo in test of HvFILL()
From: Chip Salzenberg <chip@perl.com>
Files: op.c
Subject: Allow for pad name array to be shorter than pad array
From: Chip Salzenberg <chip@perl.com>
Files: op.c
Subject: Eliminate format-string type warnings
Date: Mon, 3 Mar 1997 10:15:11 +0100 (MET)
From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
Files: doio.c ext/POSIX/POSIX.xs gv.c hints/dec_osf.sh pp.c pp_ctl.c pp_hot.c run.c sv.c x2p/a2py.c
private-msgid:
199703030915.KAA11634@bombur2.uio.no
Subject: Update copyright dates
From: Chip Salzenberg <chip@perl.com>
Files: *.[hc] x2p/*.[hc] win32/EXTERN.h vms/vmsish.h vms/vms.c
TESTS
Subject: Smarter t/op/taint.t
Date: Mon, 3 Mar 1997 10:31:54 -0800 (PST)
From: Tom Phoenix <rootbeer@teleport.com>
Files: t/op/taint.t
private-msgid: Pine.GSO.3.95q.
970303103047.24000A-100000@kelly.teleport.com
Subject: Fix taint test for systems without csh
From: Chip Salzenberg <chip@perl.com>
Files: t/op/taint.t
Jarkko Hietaniemi [Sun, 2 Mar 1997 14:54:22 +0000 (16:54 +0200)]
Update list of CPAN sites
p5p-msgid:
199703021454.QAA07446@alpha.hut.fi
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Tom Christiansen [Sat, 1 Mar 1997 17:32:31 +0000 (10:32 -0700)]
Improve sample module header
Subject: Re: addition to perlmod and perlfaq?
Here's the "final" version. Larry and I have to
head off to a book signing now. Chip, please have
this replace the old stuff I have in L<perlmod/"Perl Modules">
that begins with ``package Fred;''.
p5p-msgid:
199703011732.KAA14693@jhereg.perl.com
Signed-off-by: Graham Barr <gbarr@ti.com>
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Clarify C<crypt> documentation
(this is the same change as commit
f827b0a6c8a4efd53c50a16b098f59ac04fd670d, but as applied)
Tom Phoenix [Fri, 28 Feb 1997 21:18:25 +0000 (13:18 -0800)]
Clarify C<crypt> documentation
From a suggestion I got in private e-mail. Most readers of this list will
quickly recognize this as the part of perlfunc which explains crypt. This
should apply over my previous patch, but if you've already fixed my typo,
you'll have to fix something by hand.
p5p-msgid: Pine.GSO.3.95q.
970228131112.12357D-100000@kelly.teleport.com
Tom Phoenix [Sun, 2 Mar 1997 19:56:08 +0000 (11:56 -0800)]
Add taint checks and srand to perldelta
p5p-msgid: Pine.GSO.3.95q.
970302115355.23058D-100000@kelly.teleport.com
(name lost) [Sat, 25 Jan 1997 02:01:05 +0000 (14:01 +1200)]
Support 'long long' in h2ph
Ilya Zakharevich [Thu, 6 Mar 1997 03:08:43 +0000 (22:08 -0500)]
OS/2 patches
Chip Salzenberg writes:
>
> Below is a raw list of the changes I've incorporated into my working
> source tree. I've not broken them down by category yet, or edited
> their titles; they're in chronological order of application.
Here is what I have:
a) Minor fix for hints/os2;
b) 1 taint test minorly broken (does not unset IFS), and should be
switched off on DOSISH systems anyway :-(;
c) One additional word made legal in MakeMaker (It was supported
before, but a warning was issued).
Enjoy,
p5p-msgid:
199703060308.WAA22211@monk.mps.ohio-state.edu
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Update pod2html
(this is the same change as commit
ffcd4c5fd14c54dc48f279f8fb1699214b296ed6, but as applied)
William Middleton [Mon, 3 Mar 1997 00:25:03 +0000 (16:25 -0800)]
Update pod2html
> [...]
> # Lost interest? It's so bad I've lost apathy.
You too, eh?
However, here's a patch which brings the _91 version up to date.
YES, it still slurps chunks. ( No comment )
YES, it still uses XMP. (Nothing else works right)
YES, it still is hard to follow. (But oh, the joy of figuring it out!)
YES, it works on all platforms with configuration, including Macs...
I had pretty much given up on this, just telling people to grab
the latest from my CPAN dir, but I get alot of mail with fixes
against 1.15, and this is version is vastly better... Please
try it, and apply to 5.004, if it's not too late.
I will (respectfully) ignore any whining about the inappropriateness
of some of the things I had to do in here. Also any comments
about other renditions, I've tried them all, and this one still
excels; besides working on all platforms. I'm in the middle of a
rather difficult project, and I took the day off today to get this
together.
p5p-msgid:
199703030025.QAA08106@ducks
Chip Salzenberg [Tue, 18 Feb 1997 16:22:49 +0000 (04:22 +1200)]
Don't test locales if there is no setlocale()
Daniel S. Lewart [Sat, 1 Mar 1997 18:04:09 +0000 (12:04 -0600)]
Make op/TEST silent under -w
Below is a unidiff to make t/TEST "-w" clean.
p5p-msgid:
199703011821.NAA13037@sinistar.idle.com
Chip Salzenberg [Mon, 20 Jan 1997 16:11:30 +0000 (04:11 +1200)]
Document IO::File::new_tmpfile
Hugo van der Sanden [Thu, 6 Mar 1997 07:55:25 +0000 (07:55 +0000)]
Fix quotewords
Subject: Re: Fix for ::SUPER with UNIVERSAL
In <
199703052319.SAA32568@rio.atlantic.net>, Chip Salzenberg writes:
:Cute. It turns out that FileHandle and IO::Handle were okay, but the
:handling of ::SUPER (which is used by IO::Handle::new) was broken in
:the face of UNIVERSAL.
:
:Here's a patch.
That fixes it.
Here's one back - I think Text::ParseWords->quotewords is more broken than
this, but it's a start.
p5p-msgid:
199703060755.HAA15060@crypt.compulink.co.uk
Hugo van der Sanden [Tue, 4 Mar 1997 11:32:11 +0000 (11:32 +0000)]
Benchmark: using code refs
It often irritates me that I can't supply a coderef to the Benchmark::
routines: here's a small patch to allow them.
p5p-msgid:
199703041132.LAA07613@tyree.iii.co.uk
Johan Vromans [Fri, 28 Feb 1997 18:11:34 +0000 (06:11 +1200)]
Refresh Getopt::Long to 2.9
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Newer ReadLine
(this is the same change as commit
bcbbe6e503cc1899ede8fc1ac0c1c14e432c4f60, but as applied)
Ilya Zakharevich [Tue, 4 Mar 1997 06:34:28 +0000 (01:34 -0500)]
Newer ReadLine
Finally I could compile GNU ReadLine2.1, so I got some experience with
T::R::Gnu. Unfortunately, debugger could not use any advanced features
of T::R::Gnu since it was accessing the features of T::R::Perl via
backdoors.
I reworked the interface to use object-oriented methods so that it
should not know anything about the particular ReadLine package it uses
(as far as it conforms to some simple interface).
Below is that part of the patch which should go into standard
distribution
Consider it as mildly emergent bug fix, it is -w-safe,
Enjoy,
p5p-msgid:
199703040634.
BAA19919@monk.mps.ohio-state.edu
Chip Salzenberg [Fri, 28 Feb 1997 17:28:12 +0000 (05:28 +1200)]
Change 'continuing anyway' to 'probably harmless'
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
near-harmless bug in _91's Configure
(this is the same change as commit
79893acbe8efa42713540e8af91f667f182baa34, but as applied)
Roderick Schertler [Sun, 2 Mar 1997 02:26:49 +0000 (21:26 -0500)]
near-harmless bug in _91's Configure
At line 8118 of _91's Configure is this:
echo"(I can't seem to compile the test program...)"
note missing space after echo.
p5p-msgid: pzg1yfuiza.fsf@eeyore.ibcinc.com
Tom Phoenix [Wed, 5 Mar 1997 17:47:22 +0000 (09:47 -0800)]
Re: The continuing MachTen saga
private-msgid: Pine.GSO.3.95q.
970305091611.3572E-100000@kelly.teleport.com
Raphael Manfredi [Thu, 6 Mar 1997 13:10:38 +0000 (14:10 +0100)]
HP-UX hint update
Quoting Chip Salzenberg:
:If you have a second, please look them over and see if anything
:important is out or anything broken is in.
I don't see my hint/hpux.sh patch. Here it is again (in unified format
this time):
p5p-msgid: 1479.
857653838@lyon.grenoble.hp.com
Ilya Zakharevich [Thu, 6 Mar 1997 03:08:43 +0000 (22:08 -0500)]
OS/2 patches
Chip Salzenberg writes:
>
> Below is a raw list of the changes I've incorporated into my working
> source tree. I've not broken them down by category yet, or edited
> their titles; they're in chronological order of application.
Here is what I have:
a) Minor fix for hints/os2;
b) 1 taint test minorly broken (does not unset IFS), and should be
switched off on DOSISH systems anyway :-(;
c) One additional word made legal in MakeMaker (It was supported
before, but a warning was issued).
Enjoy,
p5p-msgid:
199703060308.WAA22211@monk.mps.ohio-state.edu
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Clarify C<crypt> documentation
(this is the same change as commit
033135fa782fb902eccfa5fabb72b7be2050ba12, but as applied)
Tom Phoenix [Fri, 28 Feb 1997 21:18:25 +0000 (13:18 -0800)]
Clarify C<crypt> documentation
p5p-msgid: <Pine.GSO.3.95q.
970228131112.12357D-100000@kelly.teleport.com>
(name lost) [Sat, 25 Jan 1997 02:01:05 +0000 (14:01 +1200)]
Support 'long long' in h2ph
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Update pod2html
(this is the same change as commit
90841c69f02b801a9d408ee4b2ed3da4664a144d, but as applied)
William Middleton [Mon, 3 Mar 1997 00:25:03 +0000 (16:25 -0800)]
Update pod2html
> [...]
> # Lost interest? It's so bad I've lost apathy.
You too, eh?
However, here's a patch which brings the _91 version up to date.
YES, it still slurps chunks. ( No comment )
YES, it still uses XMP. (Nothing else works right)
YES, it still is hard to follow. (But oh, the joy of figuring it out!)
YES, it works on all platforms with configuration, including Macs...
I had pretty much given up on this, just telling people to grab
the latest from my CPAN dir, but I get alot of mail with fixes
against 1.15, and this is version is vastly better... Please
try it, and apply to 5.004, if it's not too late.
I will (respectfully) ignore any whining about the inappropriateness
of some of the things I had to do in here. Also any comments
about other renditions, I've tried them all, and this one still
excels; besides working on all platforms. I'm in the middle of a
rather difficult project, and I took the day off today to get this
together.
p5p-msgid:
199703030025.QAA08106@ducks
Chip Salzenberg [Tue, 18 Feb 1997 16:22:49 +0000 (04:22 +1200)]
Don't test locales if there is no setlocale()
Daniel S. Lewart [Sat, 1 Mar 1997 18:04:09 +0000 (12:04 -0600)]
Make op/TEST silent under -w
Below is a unidiff to make t/TEST "-w" clean.
p5p-msgid:
199703011821.NAA13037@sinistar.idle.com
Chip Salzenberg [Mon, 20 Jan 1997 16:11:30 +0000 (04:11 +1200)]
Document IO::File::new_tmpfile
Hugo van der Sanden [Thu, 6 Mar 1997 07:55:25 +0000 (07:55 +0000)]
Fix quotewords
Subject: Re: Fix for ::SUPER with UNIVERSAL
In <
199703052319.SAA32568@rio.atlantic.net>, Chip Salzenberg writes:
:Cute. It turns out that FileHandle and IO::Handle were okay, but the
:handling of ::SUPER (which is used by IO::Handle::new) was broken in
:the face of UNIVERSAL.
:
:Here's a patch.
That fixes it.
Here's one back - I think Text::ParseWords->quotewords is more broken than
this, but it's a start.
p5p-msgid:
199703060755.HAA15060@crypt.compulink.co.uk
Hugo van der Sanden [Tue, 4 Mar 1997 11:32:11 +0000 (11:32 +0000)]
Benchmark: using code refs
It often irritates me that I can't supply a coderef to the Benchmark::
routines: here's a small patch to allow them.
p5p-msgid:
199703041132.LAA07613@tyree.iii.co.uk
Johan Vromans [Fri, 28 Feb 1997 18:11:34 +0000 (06:11 +1200)]
Refresh Getopt::Long to 2.9
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Sat, 1 Mar 1997 06:40:49 +0000 (18:40 +1200)]
Newer ReadLine
(this is the same change as commit
d064f897c983478165072b3747bdb05ee656e1e6, but as applied)
Ilya Zakharevich [Tue, 4 Mar 1997 06:34:28 +0000 (01:34 -0500)]
Newer ReadLine
Finally I could compile GNU ReadLine2.1, so I got some experience with
T::R::Gnu. Unfortunately, debugger could not use any advanced features
of T::R::Gnu since it was accessing the features of T::R::Perl via
backdoors.
I reworked the interface to use object-oriented methods so that it
should not know anything about the particular ReadLine package it uses
(as far as it conforms to some simple interface).
Below is that part of the patch which should go into standard
distribution
Consider it as mildly emergent bug fix, it is -w-safe,
Enjoy,
p5p-msgid:
199703040634.
BAA19919@monk.mps.ohio-state.edu
Chip Salzenberg [Fri, 28 Feb 1997 17:28:12 +0000 (05:28 +1200)]
Change 'continuing anyway' to 'probably harmless'
Roderick Schertler [Sun, 2 Mar 1997 02:26:49 +0000 (21:26 -0500)]
near-harmless bug in _91's Configure
At line 8118 of _91's Configure is this:
echo"(I can't seem to compile the test program...)"
note missing space after echo.
p5p-msgid: pzg1yfuiza.fsf@eeyore.ibcinc.com
Tom Phoenix [Wed, 5 Mar 1997 17:47:22 +0000 (09:47 -0800)]
Re: The continuing MachTen saga
private-msgid: Pine.GSO.3.95q.
970305091611.3572E-100000@kelly.teleport.com
Raphael Manfredi [Thu, 6 Mar 1997 13:10:38 +0000 (14:10 +0100)]
HP-UX hint update
Quoting Chip Salzenberg:
:If you have a second, please look them over and see if anything
:important is out or anything broken is in.
I don't see my hint/hpux.sh patch. Here it is again (in unified format
this time):
p5p-msgid: 1479.
857653838@lyon.grenoble.hp.com
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
[differences between cumulative patch application and perl-5.003_91]
Perl 5 Porters [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
[inseparable changes from match from perl-5.003_90 to perl-5.003_91]
BUILD PROCESS
Subject: Sanity check linking with $libs
Date: Tue, 25 Feb 1997 14:13:45 -0500 (EST)
From: Andy Dougherty <doughera@fractal.phys.lafayette.edu>
Files: Configure
Msg-ID: <Pine.SOL.3.95q.
970225221634.2486A-100000@fractal.lafayette.edu>
(applied based on p5p patch as commit
5c37e92e59bb92e49d5a21017cd6dc066a28ddea)
Subject: Flush stdout when printing $randbits guess
From: Chip Salzenberg <chip@perl.com>
Files: Configure
Subject: Configure changes for Irix nm
From: Helmut Jarausch <helmutjarausch@unknown>
Files: Configure
CORE LANGUAGE CHANGES
Subject: Fix perl_call_*() when !G_EVAL
Date: Tue, 25 Feb 1997 02:25:56 -0500
From: Gurusamy Sarathy <gsar@engin.umich.edu>
Files: MANIFEST gv.c interp.sym perl.c perl.h pp_ctl.c pp_sys.c t/op/runlevel.t
Msg-ID: <
199702250725.
CAA09192@aatma.engin.umich.edu>, <
199702251925.OAA15498@aatma.engin.umich.edu>, <
199702252200.RAA16853@aatma.engin.umich.edu>
(applied based on p5p patch as commits
40f788c454d994616342c409de5b5d181ad9b8af, and
907a881cde89c56bc61d3f314c0efb8754ca472a,
20efc0829f6564c44574762adb07e8865bc14026)
Subject: Fix taint tests for writeable dirs in $ENV{PATH}
From: Chip Salzenberg <chip@perl.com>
Files: mg.c mg.h pod/perlsec.pod taint.c
Subject: Forbid tainted parameters for truncate()
From: Chip Salzenberg <chip@perl.com>
Files: pp_sys.c
Subject: Don't taint magic hash keys unnecessarily
Date: Fri, 28 Feb 1997 02:11:26 -0500 (EST)
From: Charles Bailey <bailey@HMIVAX.HUMGEN.UPENN.EDU>
Files: hv.c
private-msgid: <01IFXL9TY74Y00661G@hmivax.humgen.upenn.edu>
CORE PORTABILITY
Subject: VMS patches post _90
Date: Fri, 28 Feb 1997 15:26:33 -0500 (EST)
From: Charles Bailey <bailey@HMIVAX.HUMGEN.UPENN.EDU>
Files: doio.c mg.c perl.h pp_hot.c t/op/rand.t t/op/taint.t taint.c vms/descrip.mms vms/vms.c
private-msgid: <01IFYDE5ZT7O005A53@hmivax.humgen.upenn.edu>
Subject: Fix taint check in system() and exec() under VMS and OS/2
From: Chip Salzenberg <chip@perl.com>
Files: pp_sys.c
Subject: If _XOPEN_VERSION >= 4, socket length parameters are size_t
From: Michael H. Moran <mhm@austin.ibm.com>
Files: perl.h pp_sys.c
Subject: Make dooneliner() compile again
From: Chip Salzenberg <chip@perl.com>
Files: pp_sys.c
DOCUMENTATION
Subject: Move ENVIRONMENT from perl.pod to perlrun.pod
From: Chip Salzenberg <chip@perl.com>
Files: pod/perl.pod pod/perlrun.pod
Subject: Describe PERL_DEBUG_MSTATS in perlrun.pod
From: Nat <gnat@frii.com>
Files: pod/perlrun.pod
Subject: Fix references to perlbug
From: Chip Salzenberg <chip@perl.com>
Files: pod/perl.pod pod/perldelta.pod pod/perllocale.pod pod/perltoc.pod
OTHER CORE CHANGES
Subject: Short-circuit duplicate study() calls
From: Chip Salzenberg <chip@perl.com>
Files: pp.c
Subject: Call sv_set[iu]v() with [IU]V parameter, not [IU]32
From: Chip Salzenberg <chip@perl.com>
Files: perl.c pp.c pp_sys.c toke.c util.c
Subject: Clean up and document API for hashes
Date: Tue, 25 Feb 1997 13:24:02 -0500
From: Gurusamy Sarathy <gsar@engin.umich.edu>
Files: hv.c hv.h pod/perldelta.pod pod/perlguts.pod
Msg-ID: <
199702251824.NAA14859@aatma.engin.umich.edu>
(applied based on p5p patch as commit
a61fe43df197fcc70e6f310c06ee17d52b606c45)
Subject: pp_undef was not always freeing memory
Date: Thu, 27 Feb 1997 01:53:51 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: pp.c
Msg-ID: <
199702270653.
BAA13949@monk.mps.ohio-state.edu>
(applied based on p5p patch as commit
1da885048b65b5be1bd3077c6fc45f92c567e1b5)
Subject: Don't examine rx->exec_tainted if pregexec() fails
From: Chip Salzenberg <chip@perl.com>
Files: pp_hot.c
TESTS
Subject: New test op/taint.t
Date: Tue, 25 Feb 1997 11:36:53 -0800 (PST)
From: Tom Phoenix <rootbeer@teleport.com>
Files: MANIFEST t/op/taint.t
private-msgid: <Pine.GSO.3.95q.
970225101328.18288M-100000@kelly.teleport.com
Subject: Patch to t/op/rand.t
Date: Tue, 25 Feb 1997 18:19:34 -0800 (PST)
From: Tom Phoenix <rootbeer@teleport.com>
Files: t/op/rand.t
private-msgid: <Pine.GSO.3.95q.
970225181321.13796Q-100000@kelly.teleport.com
UTILITIES
Subject: Add --lax option to pod2man; use it in perldoc
From: Nat <gnat@frii.com>
Files: pod/pod2man.PL utils/perldoc.PL
Subject: Eliminate dead code in pod2man
From: Chip Salzenberg <chip@perl.com>
Files: pod/pod2man.PL
Andy Dougherty [Tue, 25 Feb 1997 19:13:45 +0000 (14:13 -0500)]
Sanity check linking with $libs
On Tue, 25 Feb 1997, Chip Salzenberg wrote:
> According to Andy Dougherty:
> > Chip, do you want to put something like this in, or shall I? (I'd
> > need to borrow the current sfio unit)
>
> I'm leery of changing a working Configure, especially because _90's
> Configure has patches that haven't been propagated back to the units.
Staying leery is probably healthy.
Looking at _90's Configure, I see we'd have to change some
dependencies to move the sfio sanity checking earlier in the script.
I'd probably be inclined to do this by merging stuff into a single unit
(right after checking whether sfio is available, check whether it's
useful) and giving the whole thing a ?Y:TOP directive.
p5p-msgid: <Pine.SOL.3.95q.
970225133824.28903K-100000@fractal.lafayette.edu>
private-msgid: <Pine.SOL.3.95q.
970225221634.2486A-100000@fractal.lafayette.edu>
Tom Phoenix (with help from M.J.T. Guy [Mon, 24 Feb 1997 16:36:06 +0000 (04:36 +1200)]
Updates to perlfunc.pod
Signed-off-by: Tom Phoenix (with help from M.J.T. Guy <tomphoenix@unknown>
Ilya Zakharevich [Thu, 27 Feb 1997 06:53:51 +0000 (01:53 -0500)]
pp_undef was not always freeing memory
As I found, pp_undef in
$a = 'aaa';
$a = 0;
undef $a;
was not reclaiming the storage, as it does in
$a = 'aaa';
undef $a;
The patch is below fixes this shortcoming (tests ok, perl rebuilds
itself OK),
Enjoy,
p5p-msgid: <
199702270707.
CAA13978@monk.mps.ohio-state.edu>
private-msgid: <
199702270653.
BAA13949@monk.mps.ohio-state.edu>
Andy Dougherty [Fri, 28 Feb 1997 16:35:49 +0000 (11:35 -0500)]
Warn about intrusive sfio behavior
private-msgid: <Pine.SOL.3.95q.
970228112136.24038G-100000@fractal.lafayette.
Gurusamy Sarathy [Tue, 25 Feb 1997 18:24:02 +0000 (13:24 -0500)]
Clean up and document API for hashes
On Tue, 25 Feb 1997 09:01:57 EST, Chip Salzenberg wrote:
>I've had 99.44% good reports about _90. I'd love to go public
>immediately, but Sarathy's perl_call fix is just too valuable to pass
>up, and there's a taint test in the works. So please don't tell
>anyone that _90 is the first public beta; that will likely be _91.
FWIW, the Beta Zvoid is alive and kicking on Linux 2.0.28.
You might want to put this in too. (The patches to hv.h are mostly
to an unused macro that will be useful for extension writers).
p5p-msgid: <
199702251824.NAA14859@aatma.engin.umich.edu>
Doug MacEachern [Thu, 27 Feb 1997 16:25:04 +0000 (11:25 -0500)]
Allow explicit '-lperl' in link arguments
private-msgid: <
199702271625.LAA25402@postman.osf.org>
Gurusamy Sarathy [Tue, 25 Feb 1997 22:00:49 +0000 (17:00 -0500)]
_90 op/tie.t gets "Segmentation fault" with Sarathy's perl_call patch
On Tue, 25 Feb 1997 14:41:30 EST, Chip Salzenberg wrote:
>According to Gurusamy Sarathy:
>> On Tue, 25 Feb 1997 10:07:02 PST, David Dyck wrote:
>> >summary:
>> > op/tie.t gets "Segmentation fault" with Sarathy's perl_call patch
>>
>> Try this patch.
>
>That's got it. Now pureperl doesn't complain about op/tie.t.
>
Good. This here patch sets up the flag in a few more places (to avoid
redundant sigjmp()s which was why t/op/tie.t triggered execution
of docatch()). This patch fixes that flag leak.
p5p-msgid: <
199702252200.RAA16853@aatma.engin.umich.edu>
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Gurusamy Sarathy [Tue, 25 Feb 1997 19:25:39 +0000 (14:25 -0500)]
_90 op/tie.t gets "Segmentation fault" with Sarathy's perl_call patch
On Tue, 25 Feb 1997 10:07:02 PST, David Dyck wrote:
>
>summary:
> op/tie.t gets "Segmentation fault" with Sarathy's perl_call patch
>
Oops. Thanks for that report (Evil how the segfault doesn't show
up under `make test`. Evil.)
Try this patch. (I was being risque with the runlevel pretense...)
p5p-msgid: <
199702251925.OAA15498@aatma.engin.umich.edu>
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
Don't warn on use of CCFLAGS
(this is the same change as commit
69d91587b2e24056be123e153ca28f4e82fa8dff, but as applied)
Andreas Koenig [Tue, 25 Feb 1997 10:38:43 +0000 (11:38 +0100)]
Don't warn on use of CCFLAGS
Subject: CCFLAGS (Was: This message did not make it ...)
>>>>> Raphael Manfredi writes:
> Making ODBM_File (dynamic)
> Processing hints file hints/hpux.pl
> 'CCFLAGS' is not a known MakeMaker parameter name.
> error. Upon closer inspection, it looks like the hint file is
> doing:
> $self->{CCFLAGS} = $Config{ccflags} . ' -DDBM_BUG_DUPLICATE_FREE' ;
> Why the 'CCFLAGS' key is unknown is beyond me. It would be nice
> to find the roots of this problem before we go to beta.
Finally, here it is. Unfortunately, I cannot remember how it was lost
from the list.
p5p-msgid: <
199702251038.LAA13123@anna.in-berlin.de>
Gurusamy Sarathy [Tue, 25 Feb 1997 07:25:56 +0000 (02:25 -0500)]
Fix perl_call_*() when !G_EVAL
On Mon, 24 Feb 1997 15:19:17 EST, Gurusamy Sarathy wrote:
>On Mon, 24 Feb 1997 12:53:57 GMT, Tim Bunce wrote:
>>> From: Tom Christiansen <tchrist@jhereg.perl.com>
>>> >Dprof "works".
>>> Then how come it's not in the core? :-(
>>I'd certainly like it to be there for 5.004.
>
>I'd agree, except there's this bug in perl_call_*() that makes
>it fail to run this fully:
>
> % perl -d:DProf -e 'sub T { eval { die "burp" } } T(); print "zip\n"'
> %
Ok, here's a patch for the perl_call_*() problems with error traps,
meant for 5.004 (hope I didn't miss the boat!).
This is a subset of the functionality contained in Michael Schroeder's
stack-of-stacks patch. The patch itself if simple: code that calls
runops() without explicitly setting up a jmp_buf sets a flag that
indicates doeval() is responsible for catching any longjmp()s
locally. The three places that call doeval() then call setjmp()
based on this flag.
This patch is binary compatible and minimal (as opposed to the
stack-of-stacks patch which has other issues involved, making it
more complicated). There's a testsuite with 9 tests (3_28 fails all
but one).
p5p-msgid: <
199702250725.
CAA09192@aatma.engin.umich.edu>
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
Follow up on elimination of $` $& $' in libraries
(this is the same change as commit
efa45da9e2f446e4e79f819d2fa3a099e54425fa, but as applied)
M.J.T. Guy [Fri, 28 Feb 1997 13:59:42 +0000 (13:59 +0000)]
Follow up on elimination of $` $& $' in libraries
Ilya Zakharevich <ilya@math.ohio-state.edu> wrote
> $' $` $& eliminated from all the known *.pm.
Close, but you overlooked the 'use English' in diagnostics.pm.
See additional patch below.
p5p-msgid: <E0w0Sqc-00046E-00@ursa.cus.cam.ac.uk>
Ilya Zakharevich [Tue, 25 Feb 1997 19:37:07 +0000 (14:37 -0500)]
Make IPC::Open3 work without fork()
private-msgid: <
199702251937.OAA10718@monk.mps.ohio-state.edu>
Chip Salzenberg [Tue, 25 Feb 1997 01:58:14 +0000 (13:58 +1200)]
Don't require() in a signal handler
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Tue, 25 Feb 1997 01:12:02 +0000 (13:12 +1200)]
Update OS/2 Configure diff
(this is the same change as commit
ef05b0d7eb79c109aa2e843e7ab5d5abad251c55, but as applied)
Ilya Zakharevich [Tue, 25 Feb 1997 19:06:23 +0000 (14:06 -0500)]
Update OS/2 Configure diff
Chip Salzenberg writes:
>
> (I missed the $randbits case in _90; it is fixed in _91.)
The broken $randbits test (no $ldflags) is just ignored under OS/2
anyway, so this should help.
p5p-msgid: <
199702251906.OAA10608@monk.mps.ohio-state.edu>
Gurusamy Sarathy [Thu, 27 Feb 1997 18:02:30 +0000 (13:02 -0500)]
Silence bogus typo warning on $DB::postponed
private-msgid: <
199702271802.NAA12505@aatma.engin.umich.edu>
Ilya Zakharevich [Thu, 27 Feb 1997 19:24:36 +0000 (14:24 -0500)]
Fix SEGV when debugging with foreach() lvalue patch
p5p-msgid: <
199702271924.OAA14557@monk.mps.ohio-state.edu>
Chip Salzenberg [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
[differences between cumulative patch application and perl-5.003_90]
Perl 5 Porters [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
[inseparable changes from match from perl5.003_28 to perl-5.003_90]
BUILD PROCESS
Subject: Re: ccdlflags don't quite work
Date: Mon, 24 Feb 1997 16:07:07 -0500 (EST)
From: Andy Dougherty <doughera@fractal.phys.lafayette.edu>
Files: Configure
Msg-ID: <Pine.SOL.3.95q.
970224160630.5700E-100000@fractal.lafayette.e
(applied based on p5p patch as commit
bc75e68b7b49a5ac07dc839aec7ca05eba51175f)
Subject: Use $ccflags, $ldflags, $libs when determining $randbits
From: Chip Salzenberg <chip@perl.com>
Files: Configure
Subject: 'installperl -v' doesn't do enough
Date: Mon, 24 Feb 1997 08:42:59 -0500
From: Spider Boardman <spider@Orb.Nashua.NH.US>
Files: installperl
Msg-ID: <
199702241342.IAA25945@Orb.Nashua.NH.US>
(applied based on p5p patch as commit
7287d43f85a3731984c0e0ef1f20e1515b4140f2)
Subject: installperl breaks running system (for a while)
Date: Mon, 24 Feb 1997 09:12:11 -0500
From: Spider Boardman <spider@Orb.Nashua.NH.US>
Files: installperl
Msg-ID: <
199702241412.JAA11829@Orb.Nashua.NH.US>
(applied based on p5p patch as commit
ec2a3d87ba26a9586ad981051a949403027c147a)
CORE PORTABILITY
Subject: Digital UNIX and 3_28
Date: Sun, 23 Feb 1997 16:27:19 +0200 (EET)
From: Jarkko Hietaniemi <jhi@iki.fi>
Files: Configure MANIFEST ext/NDBM_File/hints/dec_osf.pl ext/ODBM_File/hints/dec_osf.pl hints/dec_osf.sh
Msg-ID: <
199702231427.QAA13807@alpha.hut.fi>
(applied based on p5p patch as commit
58c0852f6968d0b4520a03e22a56226185ab78c6)
Subject: AmigaOS patches to 5.003_28
Date: Sat, 22 Feb 1997 18:08:02 +0100
From: "Norbert Pueschel" <pueschel@imsdd.meb.uni-bonn.de>
Files: README.amiga hints/amigaos.sh t/io/fs.t t/lib/anydbm.t t/lib/db-btree.t t/lib/db-hash.t t/lib/db-recno.t t/lib/gdbm.t t/lib/ndbm.t t/lib/odbm.t t/lib/sdbm.t t/op/magic.t t/op/stat.t
Msg-ID: <
77724759@Armageddon.meb.uni-bonn.de>
(applied based on p5p patch as commit
b8e6d11c134e93a7795379ceb62b7f950607c667)
TESTS
Subject: Don't use <*> where readdir() will do
From: Chip Salzenberg <chip@perl.com>
Files: t/op/stat.t
Subject: Allow for $^X to be 'miniperl'
Date: Sun, 23 Feb 1997 16:22:45 +0100
From: Dominic Dunlop <domo@slipper.ip.lu>
Files: t/op/magic.t
private-msgid: <v03020903af360f31aced@[194.51.248.65]>
Spider Boardman [Mon, 24 Feb 1997 14:12:11 +0000 (09:12 -0500)]
installperl breaks running system (for a while)
"installperl" causes scripts with "/usr/bin/perl" or equivalent to
fail during the process of installation, which can take a while with
slow disks and/or slow CPUs. It should install the libraries and such
*before* linking "$installbin/perl" to the version-dependent executable.
p5p-msgid: <
199702241412.JAA11829@Orb.Nashua.NH.US>
Chip Salzenberg [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Spider Boardman [Mon, 24 Feb 1997 13:42:59 +0000 (08:42 -0500)]
'installperl -v' doesn't do enough
"installperl -v" doesn't install enough for even "perl5.00328 -V" to
work. It should install the version-dependent portions of the "lib"
directory as well as the perl executable.
p5p-msgid: <
199702241342.IAA25945@Orb.Nashua.NH.US>
Chip Salzenberg [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
Document one-argument limitation with #! line
(this is the same change as commit
3c5180aa4845c30d7891bc90e491cc6f9b6ecd85, but as applied)
Tom Phoenix [Mon, 24 Feb 1997 02:41:02 +0000 (18:41 -0800)]
Document one-argument limitation with #! line
On Sun, 23 Feb 1997, Tom Christiansen wrote:
> If it is important to you that your bug be fixed, do monitor the
> Changes file in any development releases since the time you submitted
> the bug, and encourage the maintainers with kind words (but never any
> flames!). Feel free to resend your bug report if the next released
> version of perl comes out and your bug is still present.
That's good. And how about adding something like this?
p5p-msgid: <Pine.GSO.3.95q.
970223151026.18178P-100000@kelly.teleport.com>
private-msgid: <Pine.GSO.3.95q.
970223182745.15989A-100000@kelly.teleport.com
Andy Dougherty [Mon, 24 Feb 1997 21:07:07 +0000 (16:07 -0500)]
Re: ccdlflags don't quite work
On Mon, 24 Feb 1997, Matthias Urlichs wrote:
> Two problems:
>
> # How will the perl executable find the installed shared $libperl?
> # Add $xxx to ccdlflags.
> ... and it does this every time I reconfigure Perl without first saying
> "rm config.sh", so the list grows longer and longer and... Ugh. Probably
> the best solution is to add a Configure variable which does nothing but
> remember if we have added $xxx yet.
I think this will fix the problem.
p5p-msgid: <Pine.SOL.3.95q.
970224160630.5700E-100000@fractal.lafayette.edu>
private-msgid: <Pine.SOL.3.95q.
970224160630.5700E-100000@fractal.lafayette.e
Jarkko Hietaniemi [Fri, 21 Feb 1997 15:38:06 +0000 (03:38 +1200)]
Fix typo in 'Tolkien quotation typo' fix
Norbert Pueschel [Sat, 22 Feb 1997 17:08:02 +0000 (18:08 +0100)]
AmigaOS patches to 5.003_28
Here are some patches for AmigaOS, mainly to switch of unwanted tests.
With these patches, perl 5.003_28 passes all tests under AmigaOS.
You should check if there are other hint files that need the new
dont_use_nlink variable added.
p5p-msgid: <
77724759@Armageddon.meb.uni-bonn.de>
Andy Dougherty [Mon, 24 Feb 1997 21:06:02 +0000 (16:06 -0500)]
pumpkin-1.9.pod
private-msgid: <Pine.SOL.3.95q.
970224155702.5700D-100000@fractal.lafayette.e
Jarkko Hietaniemi [Sun, 23 Feb 1997 14:27:19 +0000 (16:27 +0200)]
Digital UNIX and 3_28
Please try this on 3_28 in as many Digital UNIX / DEC OSF/1 boxes you
can and report the results back to me. I have already 100% positive
make test results from
Digital UNIX 4.0 cc static/shared, gcc static/shared
Digital UNIX 4.0B cc static/shared, gcc static/shared
DEC OSF/1 3.2C cc static/shared, gcc static/shared
so you can test some other os / compiler combinations first.
p5p-msgid: <
199702231427.QAA13807@alpha.hut.fi>
Chip Salzenberg [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
[dummy merge]
This merge exists so that the p5p version of the patch and the applied
version are both in the history
Chip Salzenberg [Fri, 21 Feb 1997 14:41:53 +0000 (02:41 +1200)]
Add documentation and '-h' option to perlbug
This was the summary description that Chip wrote for the two changes:
4fc194b2052979cb8d28873cf62c0ce84cd214f5
3f4fc4634a226330cf98eab6871f26f45d52e425
Gurusamy Sarathy [Mon, 24 Feb 1997 20:09:51 +0000 (15:09 -0500)]
perlbug.pod for 5.004
On Mon, 24 Feb 1997 16:10:10 GMT, "M.J.T. Guy" wrote:
>You wrote to perl5-porters:
>> I hope I got Kenneth right as the AUTHOR of perlbug.
>
>Doesn't he deserve the E<lt> treatment, like the rest of you?
>
>>+ Kenneth Albanowski <kjahds@kjahds.com>, subsequently I<doc>tored by
Sure. That, and a few pod2man noises fixed below. Goes on top
of the previous patch.
p5p-msgid: <
199702242009.PAA02849@aatma.engin.umich.edu>
Gurusamy Sarathy [Mon, 24 Feb 1997 22:29:30 +0000 (17:29 -0500)]
Re: Hash key created by subroutine call? (fwd)
On Mon, 24 Feb 1997 06:20:14 MST, Tom Christiansen wrote:
>Considering how frequently this gets asked, how about
>putting it in perlsub?
>
>------- start of forwarded message -------
>From: Rick Smith <ricks@sd.znet.com>
>Newsgroups: comp.lang.perl.misc
>Subject: Hash key created by subroutine call?
>Date: Sat, 22 Feb 1997 21:47:52 -0800
I seem to be in a documental state today.
p5p-msgid: <
199702242229.RAA04395@aatma.engin.umich.edu>
Gurusamy Sarathy [Sun, 23 Feb 1997 11:00:00 +0000 (00:00 +1300)]
perlbug.pod for 5.004
On Sun, 23 Feb 1997 15:06:24 MST, Tom Christiansen wrote:
>Maybe this should talk more about the perlbug program, or be podfully
>included in that script?
>
>--tom
I've made some additions, along with a merge into utils/perlbug.PL.
(I didn't see Tom(rootbeer)'s suggestion before making the patch,
so that's not in.)
I hope I got Kenneth right as the AUTHOR of perlbug.
Do we need a `ln -s utils/perlbug pod/perlbug.pod` too?
p5p-msgid: <
199702240854.
DAA27128@aatma.engin.umich.edu>
Andy Dougherty [Mon, 24 Feb 1997 22:09:09 +0000 (17:09 -0500)]
Post-28 INSTALL updates
Here are some more updates to the INSTALL file. Specifically, I revised
the malloc section a bit to give more of an overall perspective (and,
admittedly, less detail).
p5p-msgid: <Pine.SOL.3.95q.
970224170713.5700H-100000@fractal.lafayette.edu>
private-msgid: <Pine.SOL.3.95q.
970224170713.5700H-100000@fractal.lafayette.e
Tom Phoenix [Tue, 31 Dec 1996 17:59:20 +0000 (05:59 +1200)]
More thoroughly test rand() and srand()
Chip Salzenberg [Tue, 19 Nov 1996 00:07:00 +0000 (12:07 +1200)]
C<use vars> didn't work until 5.002
Tim Bunce [Mon, 24 Feb 1997 16:05:17 +0000 (16:05 +0000)]
Trivial patch to make ExtUtils::Install more -w clean
p5p-msgid: <
9702241605.AA17436@toad.ig.co.uk>
Roderick Schertler [Sat, 22 Feb 1997 18:03:08 +0000 (13:03 -0500)]
Pod::Text fixes
Here are some bug fixes for Pod::Text.
Is it a bug that text given to =for and =begin doesn't get indented? It
seems like a bug to me, but I imagine one could argue the other way so I
wanted to test opinion before fixing it.
p5p-msgid: <350.
856634588@eeyore.ibcinc.com>
Roderick Schertler [Sun, 23 Feb 1997 19:29:57 +0000 (14:29 -0500)]
Fix fd leak in IO::Pipe
Subject: Re: Another goof with IO::Pipe?
On Fri, 21 Feb 1997 18:51:10 -0500 (EST), Ilya Zakharevich <ilya@math.ohio-state.edu> said:
>
> IO::Pipe basically does:
> $fh = $rw ? $me->reader() : $me->writer(); # close the other end
> bless $io, "IO::Handle";
> $io->fdopen($fh, $mode);
>
> In the corresponding place IPC::Open3 adds:
>
> $fh->close;
>
> Which one is correct?
The ->close is necessary, the IO::Pipe code is leaving two copies of the
pipe in the child. It dup()s the pipe onto STDIN/STDOUT, but doesn't
then close the pipe.
Here's an fd scan of a child whose parent did ->reader:
FD Type Mode UID Inode File System FS Type rdev
0 char special 0620 roderick 686 13054,42068 dg/ux 23, 8
1 FIFO special 0000 roderick 23 900, 0 dg/ux --
2 char special 0620 roderick 686 13054,42068 dg/ux 23, 8
4 FIFO special 0000 roderick 23 900, 0 dg/ux --
fd 4 is original write side of the pipe (the read side was fd 3) which
should have been closed by this point.
p5p-msgid: <pzn2sv722y.fsf@eeyore.ibcinc.com>
Ilya Zakharevich [Fri, 21 Feb 1997 14:53:46 +0000 (02:53 +1200)]
Don't clobber $1 et al in debugger's DB::sub()