Zbigniew Jędrzejewski-Szmek [Fri, 21 Oct 2016 03:41:21 +0000 (23:41 -0400)]
detect-virt: add --private-users switch to check if a userns is active
Various things don't work when we're running in a user namespace, but it's
pretty hard to reliably detect if that is true.
A function is added which looks at /proc/self/uid_map and returns false
if the default "0 0 UINT32_MAX" is found, and true if it finds anything else.
This misses the case where an 1:1 mapping with the full range was used, but
I don't know how to distinguish this case.
'systemd-detect-virt --private-users' is very similar to
'systemd-detect-virt --chroot', but we check for a user namespace instead.
Zbigniew Jędrzejewski-Szmek [Fri, 21 Oct 2016 03:03:26 +0000 (23:03 -0400)]
nspawn, NEWS: add missing "s" in --private-users-chown (#4438)
Evgeny Vereshchagin [Thu, 20 Oct 2016 18:23:32 +0000 (21:23 +0300)]
sysusers: fix memleak (#4430)
Fixes:
```
==28075== 64 bytes in 1 blocks are definitely lost in loss record 2 of 3
==28075== at 0x4C2BAEE: malloc (vg_replace_malloc.c:298)
==28075== by 0x4C2DCA1: realloc (vg_replace_malloc.c:785)
==28075== by 0x4ED40A2: greedy_realloc (alloc-util.c:57)
==28075== by 0x4E90F87: extract_first_word (extract-word.c:78)
==28075== by 0x4E91813: extract_many_words (extract-word.c:270)
==28075== by 0x10FE93: parse_line (sysusers.c:1325)
==28075== by 0x11198B: read_config_file (sysusers.c:1640)
==28075== by 0x111EB8: main (sysusers.c:1773)
==28075==
```
Lennart Poettering [Thu, 20 Oct 2016 17:20:22 +0000 (19:20 +0200)]
update-utmp: let's use STR_IN_SET() where it is pretty
Lennart Poettering [Thu, 20 Oct 2016 17:19:46 +0000 (19:19 +0200)]
logind: don't hit assert when we try to free NULL manager object
Fixes: #4431
Lennart Poettering [Thu, 20 Oct 2016 17:19:34 +0000 (19:19 +0200)]
update TODO
Lennart Poettering [Thu, 20 Oct 2016 17:36:28 +0000 (19:36 +0200)]
sysctl: run sysctl service if /proc/sys/net is writable (#4425)
This simply changes this line:
ConditionPathIsReadWrite=/proc/sys/
to this:
ConditionPathIsReadWrite=/proc/sys/net/
The background for this is that the latter is namespaced through network
namespacing usually and hence frequently set as writable in containers, even
though the former is kept read-only. If /proc/sys is read-only but
/proc/sys/net is writable we should run the sysctl service, as useful settings
may be made in this case.
Fixes: #4370
Lennart Poettering [Thu, 20 Oct 2016 15:45:27 +0000 (17:45 +0200)]
units: extend stop timeout for user@.service to 120s (#4426)
By default all user and all system services get stop timeouts for 90s. This is
problematic as the user manager of course is run as system service. Thus, if
the default time-out is hit for any user service, then it will also be hit for
user@.service as a whole, thus making the whole concept useless for user
services.
This patch extends the stop timeout to 120s for user@.service hence, so that
that the user service manager has ample time to process user services timing
out.
(The other option would have been to shorten the default user service timeout,
but I think a user service should get the same timeout by default as a system
service)
Fixes: #4206
Evgeny Vereshchagin [Thu, 20 Oct 2016 15:44:30 +0000 (18:44 +0300)]
tests: fix memleak in test-calendarspec (#4424)
Fixes:
```
==10750==
==10750== HEAP SUMMARY:
==10750== in use at exit: 96 bytes in 3 blocks
==10750== total heap usage: 1,711 allocs, 1,708 frees, 854,545 bytes
allocated
==10750==
==10750== 96 (64 direct, 32 indirect) bytes in 1 blocks are definitely
lost in loss record 3 of 3
==10750== at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==10750== by 0x4EB3BDA: calendar_spec_from_string
(calendarspec.c:771)
==10750== by 0x109675: test_hourly_bug_4031 (test-calendarspec.c:118)
==10750== by 0x10A00E: main (test-calendarspec.c:202)
==10750==
==10750== LEAK SUMMARY:
==10750== definitely lost: 64 bytes in 1 blocks
==10750== indirectly lost: 32 bytes in 2 blocks
==10750== possibly lost: 0 bytes in 0 blocks
==10750== still reachable: 0 bytes in 0 blocks
==10750== suppressed: 0 bytes in 0 blocks
==10750==
==10750== For counts of detected and suppressed errors, rerun with: -v
==10750== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
```
Martin Pitt [Thu, 20 Oct 2016 15:43:42 +0000 (17:43 +0200)]
Merge pull request #4418 from keszybz/autogen-params
Allow ./autogen.sh to take parameters for configure
Zbigniew Jędrzejewski-Szmek [Thu, 20 Oct 2016 13:35:40 +0000 (09:35 -0400)]
Merge pull request #4414 from poettering/consolesakcomment
three minor fixes: document /dev/console/SAK handling + another cgroups wording fix + document User= default
Lennart Poettering [Wed, 19 Oct 2016 21:40:31 +0000 (23:40 +0200)]
man: document default for User=
Replaces: #4375
Lennart Poettering [Wed, 19 Oct 2016 21:30:50 +0000 (23:30 +0200)]
journald,core: add short comments we we keep reopening /dev/console all the time
Just to make sure the next one reading this isn't surprised that the fd isn't
kept open. SAK and stuff...
Fix suggested:
https://github.com/systemd/systemd/pull/4366#issuecomment-
253659162
Lennart Poettering [Tue, 18 Oct 2016 14:18:08 +0000 (16:18 +0200)]
man: one more cgroup wording fix
Lennart Poettering [Thu, 20 Oct 2016 11:10:37 +0000 (13:10 +0200)]
Merge pull request #4417 from keszybz/man-and-rlimit
Two unrelated patches: man page tweaks and rlimit log levels
Marcel Holtmann [Thu, 20 Oct 2016 08:24:18 +0000 (10:24 +0200)]
hwdb: Update database of Bluetooth company identifiers
Zbigniew Jędrzejewski-Szmek [Thu, 20 Oct 2016 02:57:02 +0000 (22:57 -0400)]
build-sys: show configure and make commands
And also hide make clean output which is very verbose and not particularly
interesting.
Zbigniew Jędrzejewski-Szmek [Thu, 20 Oct 2016 02:49:22 +0000 (22:49 -0400)]
build-sys: allow autogen.sh to take configure params
It is sometimes nice to run autogen with some configure parameters.
For example:
./autogen.sh c --disable-manpages
So pass any extra args after the [cgals] verb to the configure command.
Also, check that the verb is correct (empty or one of the known letters)
before doing any non-trivial work.
Zbigniew Jędrzejewski-Szmek [Tue, 18 Oct 2016 17:38:41 +0000 (13:38 -0400)]
pid1: downgrade some rlimit warnings
Since we ignore the result anyway, downgrade errors to warning.
log_oom() will still emit an error, but that's mostly theoretical, so it
is not worth complicating the code to avoid the small inconsistency
Lennart Poettering [Wed, 19 Oct 2016 23:48:35 +0000 (01:48 +0200)]
core: let's upgrade the log level for service processes dying of signal (#4415)
As suggested in
https://github.com/systemd/systemd/pull/4367#issuecomment-
253670328
Lennart Poettering [Wed, 19 Oct 2016 22:10:08 +0000 (00:10 +0200)]
Merge pull request #4360 from fbuihuu/journald-fix-flush-when-restarting
Journald fix flush when restarting (#4190)
Lucas Werkmeister [Wed, 19 Oct 2016 21:21:26 +0000 (23:21 +0200)]
man: document dependencies implied by Sockets= (#4412)
Fixes #4410. Also includes two minor improvements to the previous
sentence.
Lennart Poettering [Wed, 19 Oct 2016 19:35:39 +0000 (21:35 +0200)]
Merge pull request #4378 from evverx/nspawn-smoke-test
tests: add smoke test for systemd-nspawn
Lennart Poettering [Wed, 19 Oct 2016 19:33:32 +0000 (21:33 +0200)]
Merge pull request #4390 from keszybz/install-specifiers
Various install-related tweaks
Evgeny Vereshchagin [Wed, 19 Oct 2016 19:15:20 +0000 (22:15 +0300)]
bootctl: don't try to remove esp_path (#4407)
This is a follow-up for
9ee051b9c7623
Yu Watanabe [Wed, 19 Oct 2016 11:50:47 +0000 (20:50 +0900)]
boot: fix `bootctl install` segfault (#4404)
Franck Bui [Wed, 12 Oct 2016 08:09:45 +0000 (10:09 +0200)]
journal: rename determine_space_for() into cache_space_refresh()
Now that determine_space_for() only deals with storage space (cached) values,
rename it so it reflects the fact that only the cached storage space values are
updated.
Franck Bui [Wed, 12 Oct 2016 07:58:10 +0000 (09:58 +0200)]
journal: introduce patch_min_use() helper
Updating min_use is rather an unusual operation that is limited when we first
open the journal files, therefore extracts it from determine_space_for() and
create a function of its own and call this new function when needed.
determine_space_for() is now dealing with storage space (cached) values only.
There should be no functional changes.
Franck Bui [Wed, 12 Oct 2016 07:05:55 +0000 (09:05 +0200)]
journal: introduce cache_space_invalidate()
Introduce a dedicated helper in order to reset the storage space cache.
Franck Bui [Wed, 12 Oct 2016 06:58:04 +0000 (08:58 +0200)]
journal: cache used vfs stats as well
The set of storage space values we cache are calculated according to a couple
of filesystem statistics (free blocks, block size).
This patch caches the vfs stats we're interested in so these values are
available later and coherent with the rest of the space cached values.
Franck Bui [Tue, 11 Oct 2016 14:51:37 +0000 (16:51 +0200)]
journal: don't emit space usage message when opening the journal (#4190)
This patch makes system_journal_open() stop emitting the space usage
message. The caller is now free to emit this message when appropriate.
When restarting the journal, we can now emit the message *after*
flushing the journal (if required) so that all flushed log entries are
written in the persistent journal *before* the status message.
This is required since the status message is always younger than the
flushed entries.
Fixes #4190.
Franck Bui [Tue, 11 Oct 2016 14:46:16 +0000 (16:46 +0200)]
journal: introduce server_space_usage_message()
This commit simply extracts from determine_space_for() the code which emits the
storage usage message and put it into a function of its own so it can be reused
by others paths later.
No functional changes.
Franck Bui [Tue, 4 Oct 2016 15:13:21 +0000 (17:13 +0200)]
journal: introduce JournalStorage and JournalStorageSpace structures
This structure keeps track of specificities for a given journal type
(persistent or volatile) such as metrics, name, etc...
The cached space values are now moved in this structure so that each
journal has its own set of cached values.
Previously only one set existed and we didn't know if the cached
values were for the runtime journal or the persistent one.
When doing:
determine_space_for(s, runtime_metrics, ...);
determine_space_for(s, system_metrics, ...);
the second call returned the cached values for the runtime metrics.
Franck Bui [Mon, 3 Oct 2016 16:12:41 +0000 (18:12 +0200)]
journal: introduce determine_path_usage()
This commit simply extracts from determine_space_for() the code which
determines the FS usage where the passed path lives (statvfs(3)) and put it
into a function of its own so it can be reused by others paths later.
No functional changes.
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 02:57:38 +0000 (22:57 -0400)]
shared/install: report invalid unit files slightly better
When a unit file is invalid, we'd return an error without any details:
$ systemctl --root=/ enable testing@instance.service
Failed to enable: Invalid argument.
Fix things to at least print the offending file name:
$ systemctl enable testing@instance.service
Failed to enable unit: File testing@instance.service: Invalid argument
$ systemctl --root=/ enable testing@instance.service
Failed to enable unit, file testing@instance.service: Invalid argument.
A real fix would be to pass back a proper error message from conf-parser.
But this would require major surgery, since conf-parser functions now
simply print log errors, but we would need to return them over the bus.
So let's just print the file name, to indicate where the error is.
(Incomplete) fix for #4210.
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 01:40:41 +0000 (21:40 -0400)]
shared/install: resolve specifiers in Also=
Test case:
[Install]
WantedBy= default.target
Also=getty@%p.service
$ ./systemctl --root=/ enable testing@instance.service
Created symlink /etc/systemd/system/default.target.wants/testing@instance.service → /etc/systemd/system/testing@.service.
Created symlink /etc/systemd/system/getty.target.wants/getty@testing.service → /usr/lib/systemd/system/getty@.service.
$ ./systemctl --root=/ disable testing@instance.service
Removed /etc/systemd/system/getty.target.wants/getty@testing.service.
Removed /etc/systemd/system/default.target.wants/testing@instance.service.
Fixes part of #4210.
Resolving specifiers in DefaultInstance seems to work too:
[Install]
WantedBy= default.target
DefaultInstance=%u
$ systemctl --root=/ enable testing3@instance.service
Created symlink /etc/systemd/system/default.target.wants/testing3@instance.service → /etc/systemd/system/testing3@.service.
$ systemctl --root=/ enable testing3@.service
Created symlink /etc/systemd/system/default.target.wants/testing3@zbyszek.service → /etc/systemd/system/testing3@.service.
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 01:27:57 +0000 (21:27 -0400)]
shared/install: provide more info if install_info_traverse_fails
Test case:
[Install]
WantedBy= default.target
Also=foobar-unknown.service
Before:
$ systemctl --root=/ enable testing2@instance.service
Failed to enable: No such file or directory.
After
$ ./systemctl --root=/ enable testing2@instance.service
Failed to enable unit, file foobar-unknown.service: No such file or directory.
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 00:56:31 +0000 (20:56 -0400)]
shared/install: in install_context_mark_for_removal ignore not found units
With the following test case:
[Install]
WantedBy= default.target
Also=foobar-unknown.service
disabling would fail with:
$ ./systemctl --root=/ disable testing.service
Cannot find unit foobar-unknown.service. # this is level debug
Failed to disable: No such file or directory. # this is the error
After the change we proceed:
$ ./systemctl --root=/ disable testing.service
Cannot find unit foobar-unknown.service.
Removed /etc/systemd/system/default.target.wants/testing.service.
This does not affect specifying a missing unit directly:
$ ./systemctl --root=/ disable nosuch.service
Failed to disable: No such file or directory.
Lennart Poettering [Tue, 18 Oct 2016 15:03:40 +0000 (17:03 +0200)]
Merge pull request #4382 from keszybz/unit-type-underline
systemctl: use underlines to seperate unit types in listing
Susant Sahani [Tue, 18 Oct 2016 03:19:08 +0000 (08:49 +0530)]
networkd: use proper cast to access VTI6 (#4399)
Fixes #4371.
Luca Bruno [Tue, 18 Oct 2016 00:05:49 +0000 (00:05 +0000)]
core/exec: add a named-descriptor option ("fd") for streams (#4179)
This commit adds a `fd` option to `StandardInput=`,
`StandardOutput=` and `StandardError=` properties in order to
connect standard streams to externally named descriptors provided
by some socket units.
This option looks for a file descriptor named as the corresponding
stream. Custom names can be specified, separated by a colon.
If multiple name-matches exist, the first matching fd will be used.
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 00:51:19 +0000 (20:51 -0400)]
README: list dependencies for testing
Fixes #4365.
Evgeny Vereshchagin [Fri, 14 Oct 2016 18:42:46 +0000 (18:42 +0000)]
tests: add smoke test for systemd-nspawn
Basically, this test runs:
```
systemd-nspawn --register=no -D "$_root" -b
systemd-nspawn --register=no -D "$_root" --private-network -b
systemd-nspawn --register=no -D "$_root" -U -b
systemd-nspawn --register=no -D "$_root" --private-network -U -b
```
and exports the `UNIFIED_CGROUP_HIERARCHY=[yes|no]`, `SYSTEMD_NSPAWN_USE_CGNS=[yes|no]`
Inspired by
* systemd#3589 (comment)
* systemd#4372 (comment)
* systemd#4223 (comment)
* systemd#1555
and so on :-)
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 16:22:44 +0000 (12:22 -0400)]
man: add a note that NULL "s" arg for sd_bus_message_append
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 15:48:12 +0000 (11:48 -0400)]
terminal-util: helper macro for highlighting functions
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 15:37:55 +0000 (11:37 -0400)]
systemctl: ditto for list-unit-files
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 15:37:41 +0000 (11:37 -0400)]
systemctl: use underlines to seperate unit types in listing
(printf("%.*s", -1, "…") is the same as not specifying the precision at all.)
v2: also underline highlighted (failing) units
Fixes #4137.
Lennart Poettering [Mon, 17 Oct 2016 13:50:26 +0000 (15:50 +0200)]
man: avoid abbreviated "cgroups" terminology (#4396)
Let's avoid the overly abbreviated "cgroups" terminology. Let's instead write:
"Linux Control Groups (cgroups)" is the long form wherever the term is
introduced in prose. Use "control groups" in the short form wherever the term
is used within brief explanations.
Follow-up to: #4381
llua [Mon, 17 Oct 2016 12:35:26 +0000 (08:35 -0400)]
zsh-completion: fix for #4318 (#4394)
Escape unit names for the eval call in _call_program
The value of the Id property is transformed back into a unit name
usable by systemctl.
system-systemd\x5cx2dcryptsetup.slice -> system-systemd\x2dcryptsetup.slice
Also filter units by property via parameter expansion, not a for loop
Lennart Poettering [Mon, 17 Oct 2016 10:58:55 +0000 (12:58 +0200)]
Merge pull request #4392 from keszybz/running-timers
Fix for display of elapsed timers
Lennart Poettering [Mon, 17 Oct 2016 09:36:25 +0000 (11:36 +0200)]
Merge pull request #4387 from keszybz/loginctl-tty
loginctl: print TTY field in the session listing
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 01:20:08 +0000 (21:20 -0400)]
shared/install: do not break loop when we enounter a dangling symlink
We should ignore that unit, but otherwise continue.
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 23:44:40 +0000 (19:44 -0400)]
man: mention that systemctl --root=/ operates on the fs directly
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 06:05:30 +0000 (02:05 -0400)]
core/timer: reset next_elapse_*time when timer is not waiting
When the unit that is triggered by a timer is started and running,
we transition to "running" state, and the timer will not elapse again
until the unit has finished running. In this state "systemctl list-timers"
would display the previously calculated next elapse time, which would
now of course be in the past, leading to nonsensical values.
Simply set the next elapse to infinity, which causes list-timers to
show n/a. We cannot specify when the next elapse will happen, possibly
never.
Fixes #4031.
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 05:15:03 +0000 (01:15 -0400)]
pid1: do not use mtime==0 as sign of masking (#4388)
It is allowed for unit files to have an mtime==0, so instead of assuming that
any file that had mtime==0 was masked, use the load_state to filter masked
units.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1384150.
Martin Pitt [Mon, 17 Oct 2016 05:12:20 +0000 (07:12 +0200)]
Merge pull request #4391 from keszybz/treewide-macros
Use mfree more and add another function to simplify a common set&free pattern
Martin Pitt [Mon, 17 Oct 2016 04:56:22 +0000 (06:56 +0200)]
Merge pull request #4381 from keszybz/man-pages
Zbigniew Jędrzejewski-Szmek [Mon, 17 Oct 2016 04:08:43 +0000 (00:08 -0400)]
test-calendarspec: test that hourly timers are incremented properly
Apparently this works just fine, so the issue in #4031 is elsewhere.
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 23:23:35 +0000 (19:23 -0400)]
tree-wide: introduce free_and_replace helper
It's a common pattern, so add a helper for it. A macro is necessary
because a function that takes a pointer to a pointer would be type specific,
similarly to cleanup functions. Seems better to use a macro.
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 22:28:30 +0000 (18:28 -0400)]
tree-wide: use mfree more
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 21:59:37 +0000 (17:59 -0400)]
shared/install: use _cleanup_free_
Also rewrap some comments so that they don't have a very long line and a very
short line.
Peter Hutterer [Mon, 17 Oct 2016 03:17:03 +0000 (13:17 +1000)]
Merge pull request #4380 from bgamari/master
hwdb: Add sensitivity for Dell Latitude E7470 pointing stick
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 19:13:03 +0000 (15:13 -0400)]
loginctl: report tty in session listings
Without the tty it's really hard to tell which session is which.
New output:
$ ./loginctl
SESSION UID USER SEAT TTY
13 1002 zbyszek seat0 tty3
c1 42 gdm seat0 /dev/tty1
11 1002 zbyszek seat0 tty4
3 1002 zbyszek seat0 /dev/tty2
17 1002 zbyszek seat0 tty5
18 1002 zbyszek seat0 tty6
6 sessions listed.
Zbigniew Jędrzejewski-Szmek [Sun, 16 Oct 2016 18:19:06 +0000 (14:19 -0400)]
loginctl: drop casts in printf
Martin Ejdestig [Sun, 16 Oct 2016 14:25:34 +0000 (16:25 +0200)]
man: document sd_event_get_tid() return value (#4385)
Zbigniew Jędrzejewski-Szmek [Sat, 15 Oct 2016 20:46:13 +0000 (16:46 -0400)]
man: drop discouragment of runtime and vendor drop-ins
In certain situations drop-ins in /usr/lib/ are useful, for example when one package
wants to modify the behaviour of another package, or the vendor wants to tweak some
upstream unit without patching.
Drop-ins in /run are useful for testing, and may also be created by systemd itself.
Follow-up for the discussion in #2103.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Oct 2016 20:12:46 +0000 (16:12 -0400)]
man: add journal-upload.conf(5)
Fixes #3370.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Oct 2016 19:24:55 +0000 (15:24 -0400)]
man: add notes about thread safety of sd_journal_* functions
Fixes #4056.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Oct 2016 18:17:05 +0000 (14:17 -0400)]
man: add crosslink between systemd.resource-control(5) and systemd.exec(5)
Fixes #4379.
Lukáš Nykrýn [Sat, 15 Oct 2016 17:54:58 +0000 (19:54 +0200)]
virt: add possibility to skip the check for chroot (#4374)
https://bugzilla.redhat.com/show_bug.cgi?id=1379852
Ben Gamari [Sat, 15 Oct 2016 16:11:03 +0000 (12:11 -0400)]
hwdb: Add sensitivity for Dell Latitude E7470 pointingstick
Tejun Heo [Sat, 15 Oct 2016 01:07:16 +0000 (21:07 -0400)]
core: make settings for unified cgroup hierarchy supersede the ones for legacy hierarchy (#4269)
There are overlapping control group resource settings for the unified and
legacy hierarchies. To help transition, the settings are translated back and
forth. When both versions of a given setting are present, the one matching the
cgroup hierarchy type in use is used. Unfortunately, this is more confusing to
use and document than necessary because there is no clear static precedence.
Update the translation logic so that the settings for the unified hierarchy are
always preferred. systemd.resource-control man page is updated to reflect the
change and reorganized so that the deprecated settings are at the end in its
own section.
Thomas H. P. Andersen [Thu, 13 Oct 2016 21:30:28 +0000 (23:30 +0200)]
nspawn: remove unused variable (#4369)
Lennart Poettering [Thu, 13 Oct 2016 16:36:29 +0000 (18:36 +0200)]
Merge pull request #4243 from endocode/djalal/sandbox-first-protection-kernelmodules-v1
core:sandbox: Add ProtectKernelModules= and some fixes
Zbigniew Jędrzejewski-Szmek [Thu, 13 Oct 2016 16:25:56 +0000 (12:25 -0400)]
Merge pull request #653 from dvdhrm/bus-gold
Daniel Mack [Thu, 13 Oct 2016 13:56:23 +0000 (15:56 +0200)]
Merge pull request #4363 from stefan-it/replace-while-loops
basic,coredump: use for loop instead of while
Daniel Mack [Thu, 13 Oct 2016 13:55:40 +0000 (15:55 +0200)]
Merge pull request #4364 from phomes/man-fixes
man: typo fixes
Evgeny Vereshchagin [Thu, 13 Oct 2016 13:50:46 +0000 (16:50 +0300)]
nspawn: cleanup and chown the synced cgroup hierarchy (#4223)
Fixes: #4181
Zbigniew Jędrzejewski-Szmek [Thu, 13 Oct 2016 11:42:39 +0000 (07:42 -0400)]
Merge pull request #4362 from poettering/journalbootlistfix
Thomas Hindoe Paaboel Andersen [Wed, 12 Oct 2016 21:02:44 +0000 (23:02 +0200)]
man: typo fixes
A mix of fixes for typos and UK english
Stefan Schweter [Wed, 12 Oct 2016 20:49:01 +0000 (22:49 +0200)]
coredump: use for() loop instead of while()
Stefan Schweter [Wed, 12 Oct 2016 20:48:41 +0000 (22:48 +0200)]
basic: use for() loop instead of while()
Lennart Poettering [Wed, 12 Oct 2016 18:41:52 +0000 (20:41 +0200)]
Merge pull request #4358 from fsateler/pam-config
Pam config fixes
Lennart Poettering [Wed, 12 Oct 2016 18:33:33 +0000 (20:33 +0200)]
update TODO
Lennart Poettering [Wed, 12 Oct 2016 18:23:43 +0000 (20:23 +0200)]
journalctl: say in which directory we vacuum stuff
Fixes: #4060
Lennart Poettering [Wed, 12 Oct 2016 18:20:53 +0000 (20:20 +0200)]
journalctl: don't claim the journal was stored on disk
Let's just say that the journal takes up space in the file system, not on disk,
as tmpfs is definitely a file system, but not a disk.
Fixes: #4059
Lennart Poettering [Wed, 12 Oct 2016 16:53:35 +0000 (18:53 +0200)]
journal: refuse opening journal files from the future for writing
Never permit that we write to journal files that have newer timestamps than our
local wallclock has. If we'd accept that, then the entries in the file might
end up not being ordered strictly.
Let's refuse this with ETXTBSY, and then immediately rotate to use a new file,
so that each file remains strictly ordered also be wallclock internally.
Lennart Poettering [Wed, 12 Oct 2016 16:49:51 +0000 (18:49 +0200)]
journald: automatically rotate journal files when the clock jumps backwards
As soon as we notice that the clock jumps backwards, rotate journal files. This
is beneficial, as this makes sure that the entries in journal files remain
strictly ordered internally, and thus the bisection algorithm applied on it is
not confused.
This should help avoiding borked wallclock-based bisection on journal files as
witnessed in #4278.
Lennart Poettering [Wed, 12 Oct 2016 16:46:07 +0000 (18:46 +0200)]
journald: use the event loop dispatch timestamp for journal entries
Let's use the earliest linearized event timestamp for journal entries we have:
the event dispatch timestamp from the event loop, instead of requerying the
timestamp at the time of writing.
This makes the time a bit more accurate, allows us to query the kernel time one
time less per event loop, and also makes sure we always use the same timestamp
for both attempts to write an entry to a journal file.
Lennart Poettering [Wed, 12 Oct 2016 10:36:01 +0000 (12:36 +0200)]
journal: when iterating through entry arrays and we hit an invalid one keep going
When iterating through partially synced journal files we need to be prepared
for hitting with invalid entries (specifically: non-initialized). Instead of
generated an error and giving up, let's simply try to preceed with the next one
that is valid (and debug log about this).
This reworks the logic introduced with
caeab8f626e709569cc492b75eb7e119076059e7
to iteration in both directions, and tries to look for valid entries located
after the invalid one. It also extends the behaviour to both iterating through
the global entry array and per-data object entry arrays.
Fixes: #4088
Lennart Poettering [Wed, 12 Oct 2016 10:22:57 +0000 (12:22 +0200)]
journal: add an explicit check for uninitialized objects
Let's make dissecting of borked journal files more expressive: if we encounter
an object whose first 8 bytes are all zeroes, then let's assume the object was
simply never initialized, and say so.
Previously, this would be detected as "overly short object", which is true too
in a away, but it's a lot more helpful printing different debug options for the
case where the size is not initialized at all and where the size is initialized
to some bogus value.
No function behaviour change, only a different log messages for both cases.
Lennart Poettering [Wed, 12 Oct 2016 10:12:58 +0000 (12:12 +0200)]
journal: also check that our entry arrays are properly ordered
Let's and extra check, reusing check_properly_ordered() also for
journal_file_next_entry_for_data().
Lennart Poettering [Wed, 12 Oct 2016 10:12:05 +0000 (12:12 +0200)]
journal: split out check for properly ordered arrays into its own function
This adds a new call check_properly_ordered(), which we can reuse later, and
makes the code a bit more readable.
Lennart Poettering [Wed, 12 Oct 2016 09:54:36 +0000 (11:54 +0200)]
journal: split out array index inc/dec code into a new call bump_array_index()
This allows us to share a bit more code between journal_file_next_entry() and
journal_file_next_entry_for_data().
Lennart Poettering [Tue, 11 Oct 2016 17:12:41 +0000 (19:12 +0200)]
journal: when we encounter a broken journal file, add some debug logging
Let's make it easier to figure out when we see an invalid journal file, why we
consider it invalid, and add some minimal debug logging for it.
This log output is normally not seen (after all, this all is library code),
unless debug logging is exlicitly turned on.
Felipe Sateler [Wed, 12 Oct 2016 14:56:27 +0000 (11:56 -0300)]
build-sys: Allow disabling installation of pam config snippet
hese10 [Wed, 12 Oct 2016 16:40:28 +0000 (19:40 +0300)]
Avoid forever loop for journalctl --list-boots command (#4278)
When date is changed in system to future and normal user logs to new journal file, and then date is changed back to present time, the "journalctl --list-boot" command goes to forever loop. This commit tries to fix this problem by checking first the boot id list if the found boot id was already in that list. If it is found, then stopping the boot id find loop.
Felipe Sateler [Wed, 12 Oct 2016 14:20:46 +0000 (11:20 -0300)]
systemd-user: add pam_unix account module
Otherwise systemd-user@ fails because systemd validates the account
Fixes: #4342
Ben Harris [Wed, 12 Oct 2016 13:41:56 +0000 (14:41 +0100)]
hwdb: Treat Latitude 2110 brightness keys like on Inspiron 1520 (#4355)
Like the Inspiron 1520, the Dell Latitude 2110 emits brightness-control
key events both through atkbd and acpi-video. This suppresses them on
the atkbd side.
Djalal Harouni [Sun, 9 Oct 2016 10:38:45 +0000 (12:38 +0200)]
test: add test to make sure that ProtectKernelModules=yes disconnect mount propagation