platform/upstream/libHarfBuzzSharp.git
5 years ago[CBDT] Simplify sanitize
Behdad Esfahbod [Mon, 15 Oct 2018 03:37:57 +0000 (20:37 -0700)]
[CBDT] Simplify sanitize

5 years ago[morx] Handle end-of-text conditions in Insertion
Behdad Esfahbod [Mon, 15 Oct 2018 02:39:31 +0000 (19:39 -0700)]
[morx] Handle end-of-text conditions in Insertion

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10955

5 years ago[buffer] Fix output_glyph at end of buffer
Behdad Esfahbod [Mon, 15 Oct 2018 02:36:46 +0000 (19:36 -0700)]
[buffer] Fix output_glyph at end of buffer

Part of https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10955

5 years ago[aat] More protection against buffer fail
Behdad Esfahbod [Mon, 15 Oct 2018 02:30:44 +0000 (19:30 -0700)]
[aat] More protection against buffer fail

5 years ago[hmtx] Whitespace
Behdad Esfahbod [Sun, 14 Oct 2018 23:26:03 +0000 (16:26 -0700)]
[hmtx] Whitespace

5 years agoIgnore signed-integer-overflow while kerning
Behdad Esfahbod [Sun, 14 Oct 2018 22:20:50 +0000 (15:20 -0700)]
Ignore signed-integer-overflow while kerning

Fixes https://github.com/harfbuzz/harfbuzz/issues/1247

5 years ago[kerx] Fix Format1 sanitize
Behdad Esfahbod [Sun, 14 Oct 2018 21:56:32 +0000 (14:56 -0700)]
[kerx] Fix Format1 sanitize

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10948

5 years ago[aat] Whitespace
Behdad Esfahbod [Sun, 14 Oct 2018 21:52:17 +0000 (14:52 -0700)]
[aat] Whitespace

5 years ago[aat] Finish off massaging table
Behdad Esfahbod [Sat, 13 Oct 2018 23:03:33 +0000 (19:03 -0400)]
[aat] Finish off massaging table

5 years ago[aat] WIP remove feature mapping here from hb-coretext
Behdad Esfahbod [Sat, 13 Oct 2018 22:37:14 +0000 (18:37 -0400)]
[aat] WIP remove feature mapping here from hb-coretext

Need to map enum values to numerics since we don't have CoreText headers.

5 years ago[coretext] Prepare AAT feature mapping to be moved
Behdad Esfahbod [Sat, 13 Oct 2018 21:03:32 +0000 (17:03 -0400)]
[coretext] Prepare AAT feature mapping to be moved

5 years ago[kerx] Sanitize more
Behdad Esfahbod [Sat, 13 Oct 2018 17:48:22 +0000 (13:48 -0400)]
[kerx] Sanitize more

5 years ago[kerx] Fix-up previous commit
Behdad Esfahbod [Sat, 13 Oct 2018 17:36:27 +0000 (13:36 -0400)]
[kerx] Fix-up previous commit

A "&" was missing.  Go back to using pointers that are less error-prone.

5 years ago[kerx] Use sanitizer instead of handcoded runtime sanitization
Behdad Esfahbod [Sat, 13 Oct 2018 16:20:33 +0000 (12:20 -0400)]
[kerx] Use sanitizer instead of handcoded runtime sanitization

5 years ago[kerx] Wire up context down to get_kerning
Behdad Esfahbod [Sat, 13 Oct 2018 16:16:12 +0000 (12:16 -0400)]
[kerx] Wire up context down to get_kerning

5 years ago[kerx] Use sanitizer.get_num_glyphs() instead of face->get_num_glyphs()
Behdad Esfahbod [Sat, 13 Oct 2018 15:48:49 +0000 (11:48 -0400)]
[kerx] Use sanitizer.get_num_glyphs() instead of face->get_num_glyphs()

5 years ago[kerx] Protext against overflows
Behdad Esfahbod [Sat, 13 Oct 2018 15:39:12 +0000 (11:39 -0400)]
[kerx] Protext against overflows

5 years ago[hangul] Fix use-after-free issue
Behdad Esfahbod [Sat, 13 Oct 2018 13:47:51 +0000 (09:47 -0400)]
[hangul] Fix use-after-free issue

out_info might have moved since we copied it's position into local
info var.

Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=894937

5 years agoCosmetic and minor changes
Ebrahim Byagowi [Sat, 13 Oct 2018 10:30:05 +0000 (14:00 +0330)]
Cosmetic and minor changes

5 years agoTouch up new API
Behdad Esfahbod [Fri, 12 Oct 2018 20:05:56 +0000 (16:05 -0400)]
Touch up new API

New API:
+hb_ot_layout_feature_get_name_ids()
+hb_ot_layout_feature_get_characters()

5 years agoAdd hb-ot-name.h
Behdad Esfahbod [Fri, 12 Oct 2018 19:52:31 +0000 (15:52 -0400)]
Add hb-ot-name.h

Actual name-fetching API to come later.

New API:
hb_name_id_t
HB_NAME_ID_INVALID

5 years agoAdd two APIs for getting stylistic set labels
Ebrahim Byagowi [Thu, 11 Oct 2018 23:30:59 +0000 (03:00 +0330)]
Add two APIs for getting stylistic set labels

* hb_ot_layout_feature_get_characters
* hb_ot_layout_feature_get_name_ids

However HarfBuzz currently doesn't expose an API for retrieving the actual
information associated with NameId from the `name` table and that should be
done separately.

5 years ago[sanitize] Reorder condition to silence bogus gcc warning
Behdad Esfahbod [Fri, 12 Oct 2018 01:37:45 +0000 (21:37 -0400)]
[sanitize] Reorder condition to silence bogus gcc warning

Was givin a dozen of:

../../src/hb-machinery.hh: In member function ‘bool AAT::ankr::sanitize(hb_sanitize_context_t*) const’:
../../src/hb-machinery.hh:307:23: warning: missed loop optimization, the loop counter may overflow [-Wunsafe-loop-optimizations]
     bool ok = --this->max_ops > 0 &&
               ~~~~~~~~~~~~~~~~~~~~~~
        this->start <= p &&
        ~~~~~~~~~~~~~~~~~~~
        p <= this->end &&
        ~~~~~~~~~~~~~~~^~
        (unsigned int) (this->end - p) >= len;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I believe those are bogus, but this silences them and does not introduce
logic issues I believe.

5 years agoAdd HB_DEPRECATED_FOR and mark relevant symbols
Behdad Esfahbod [Fri, 12 Oct 2018 01:22:49 +0000 (21:22 -0400)]
Add HB_DEPRECATED_FOR and mark relevant symbols

5 years ago[graphite] Add HB_DEPRECATED annotation
Behdad Esfahbod [Fri, 12 Oct 2018 01:19:39 +0000 (21:19 -0400)]
[graphite] Add HB_DEPRECATED annotation

5 years agoAlways compile deprecated symbols
Behdad Esfahbod [Fri, 12 Oct 2018 01:18:20 +0000 (21:18 -0400)]
Always compile deprecated symbols

We haven't been keeping this updated.  So, while we don't expose the
symbols in the headers if HB_DISABLE_DEPRECATED is defined, we still
always build them.

5 years agoAdd missing colons to GObject annotations
David Corbett [Fri, 12 Oct 2018 02:08:14 +0000 (22:08 -0400)]
Add missing colons to GObject annotations

5 years agoFix Indic script tags in Graphite
David Corbett [Fri, 12 Oct 2018 00:37:49 +0000 (20:37 -0400)]
Fix Indic script tags in Graphite

5 years agoAttach CursivePositioning backwards, not forward
Behdad Esfahbod [Fri, 12 Oct 2018 00:45:00 +0000 (20:45 -0400)]
Attach CursivePositioning backwards, not forward

This is how Uniscribe does it.  So, adjust.  This is only relevant
to fonts that apply cursive positioning from a contextual lookup.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1181

5 years ago[myanmar] Implement Zawgyi shaper
Behdad Esfahbod [Fri, 12 Oct 2018 00:20:00 +0000 (20:20 -0400)]
[myanmar] Implement Zawgyi shaper

Enabled if script tag 'Qaag' is passed to HarfBuzz.  Disables mark
advance-zeroing and fallback mark-positioning.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1162

5 years ago[myanmar] Shuffle
Behdad Esfahbod [Fri, 12 Oct 2018 00:15:31 +0000 (20:15 -0400)]
[myanmar] Shuffle

5 years ago[graphite] Remove assert
Behdad Esfahbod [Fri, 12 Oct 2018 00:15:00 +0000 (20:15 -0400)]
[graphite] Remove assert

5 years agoMinor
Behdad Esfahbod [Thu, 11 Oct 2018 23:39:07 +0000 (19:39 -0400)]
Minor

5 years ago[test] Add test for USE indic3
Behdad Esfahbod [Thu, 11 Oct 2018 23:24:52 +0000 (19:24 -0400)]
[test] Add test for USE indic3

5 years agoMinor
Behdad Esfahbod [Thu, 11 Oct 2018 23:23:36 +0000 (19:23 -0400)]
Minor

5 years agoPass indic3 tags to USE shaper
Behdad Esfahbod [Thu, 11 Oct 2018 21:51:21 +0000 (17:51 -0400)]
Pass indic3 tags to USE shaper

Fixes https://github.com/harfbuzz/harfbuzz/issues/539

5 years agoParse Indic3 tags
David Corbett [Thu, 11 Oct 2018 21:15:22 +0000 (17:15 -0400)]
Parse Indic3 tags

5 years agoRemove remains of get-codepoint-fuzzer
Behdad Esfahbod [Thu, 11 Oct 2018 21:31:29 +0000 (17:31 -0400)]
Remove remains of get-codepoint-fuzzer

5 years ago[fuzzing] Fold get-codepoints-fuzzer into subset-fuzzer
Behdad Esfahbod [Thu, 11 Oct 2018 21:08:12 +0000 (17:08 -0400)]
[fuzzing] Fold get-codepoints-fuzzer into subset-fuzzer

5 years ago[aat] Fix two wrongs that made a right before!
Behdad Esfahbod [Thu, 11 Oct 2018 20:41:01 +0000 (16:41 -0400)]
[aat] Fix two wrongs that made a right before!

Unfortunately our static asserts (DEFINE_SIZE_STATIC) don't actually
fail when used in templates, thanks to SFINAE.  Le sighs.

Probably fixes https://oss-fuzz.com/v2/testcase-detail/5740171484463104

5 years ago[aat] Fix mul overflow
Behdad Esfahbod [Thu, 11 Oct 2018 19:56:17 +0000 (15:56 -0400)]
[aat] Fix mul overflow

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10897

5 years agoMinor
Behdad Esfahbod [Thu, 11 Oct 2018 19:42:54 +0000 (15:42 -0400)]
Minor

5 years ago[arabic] Update to latest UTR#53
Behdad Esfahbod [Thu, 11 Oct 2018 19:14:18 +0000 (15:14 -0400)]
[arabic] Update to latest UTR#53

From Lorna Evans: "That was a new character added to Unicode 11.0"

5 years ago[test] Fix use of deprecated symbols
Behdad Esfahbod [Thu, 11 Oct 2018 19:03:21 +0000 (15:03 -0400)]
[test] Fix use of deprecated symbols

5 years ago[graphite] Remove deprecated symbol use
Behdad Esfahbod [Thu, 11 Oct 2018 18:32:59 +0000 (14:32 -0400)]
[graphite] Remove deprecated symbol use

5 years agoWhitespace
Behdad Esfahbod [Thu, 11 Oct 2018 18:30:15 +0000 (14:30 -0400)]
Whitespace

5 years ago[graphite] Fix deva/dev2 resolution
Behdad Esfahbod [Thu, 11 Oct 2018 18:25:48 +0000 (14:25 -0400)]
[graphite] Fix deva/dev2 resolution

See https://github.com/harfbuzz/harfbuzz/pull/730#issuecomment-428277800

5 years agoAdd doc stubs for recently added API
Behdad Esfahbod [Thu, 11 Oct 2018 18:16:55 +0000 (14:16 -0400)]
Add doc stubs for recently added API

Thanks to David Corbett who revamped our script and language processing
and implemented full BCP 47 support.

https://github.com/harfbuzz/harfbuzz/pull/730

New API:
+hb_ot_layout_table_select_script()
+hb_ot_layout_script_select_language()
+HB_OT_MAX_TAGS_PER_SCRIPT
+HB_OT_MAX_TAGS_PER_LANGUAGE
+hb_ot_tags_from_script_and_language()
+hb_ot_tags_to_script_and_language()

Deprecated API:
-hb_ot_layout_table_choose_script()
-hb_ot_layout_script_find_language()
-hb_ot_tags_from_script()
-hb_ot_tag_from_language()

5 years agoRemove use of deprecated function
Behdad Esfahbod [Thu, 11 Oct 2018 18:07:44 +0000 (14:07 -0400)]
Remove use of deprecated function

5 years agoIncrease HB_OT_MAX_TAGS_PER_SCRIPT to 3
David Corbett [Mon, 10 Sep 2018 17:15:00 +0000 (13:15 -0400)]
Increase HB_OT_MAX_TAGS_PER_SCRIPT to 3

No script has 3 tags yet, but the plan is for the Indic scripts to each
get a third tag someday.

5 years agoUpdate language system tag registry to OT 1.8.3
David Corbett [Mon, 10 Sep 2018 16:05:51 +0000 (12:05 -0400)]
Update language system tag registry to OT 1.8.3

5 years agoAdd hb_ot_tags_to_script_and_language
David Corbett [Tue, 24 Jul 2018 01:19:23 +0000 (21:19 -0400)]
Add hb_ot_tags_to_script_and_language

5 years agoSwitch on the first char of a complex language tag
David Corbett [Thu, 19 Jul 2018 17:48:07 +0000 (13:48 -0400)]
Switch on the first char of a complex language tag

This results in a tenfold speed-up for the common case of tags that are
not complex, in the sense of `hb_ot_tags_from_complex_language`.

5 years agoMap Quechua languages to closest ones with tags
David Corbett [Tue, 17 Jul 2018 01:14:48 +0000 (21:14 -0400)]
Map Quechua languages to closest ones with tags

OpenType only officially maps four ISO 639 codes to Quechua languages,
but prior versions of HarfBuzz also mapped qu to 'QUZ '. Because qu is a
macrolanguage, the mapping now applies to all individual Quechua
languages. OpenType calls 'QUZ ' "Quechua", but it really corresponds to
Cusco Quechua, so the individual Quechua languages should not all
necessarily be mapped to it.

5 years agoTest deprecated tag fallback in a font
David Corbett [Thu, 18 Jan 2018 21:33:39 +0000 (16:33 -0500)]
Test deprecated tag fallback in a font

The font supports the deprecated tag 'DHV ' instead of 'DIV '. dv is
mapped to 'DIV ' and 'DHV ', in that order. The test specifies
`--language=dv`, demonstrating that if a font does not support the first
OpenType tag mapped to a BCP 47 tag, it will fall back to the next tag.

5 years agoMatch extlang subtags
David Corbett [Sat, 20 Jan 2018 20:53:09 +0000 (15:53 -0500)]
Match extlang subtags

If the second subtag of a BCP 47 tag is three letters long, it denotes
an extended language. The tag converter ignores the language subtag and
uses the extended language instead.

There are some grandfathered exceptions, which are handled earlier.

5 years agoAutogenerate the BCP 47 to OpenType mappings
David Corbett [Sat, 9 Dec 2017 03:45:52 +0000 (22:45 -0500)]
Autogenerate the BCP 47 to OpenType mappings

The new script, gen-tag-table.py, generates `ot_languages` automatically
from the [OpenType language system tag registry][ot] and the [IANA
Language Subtag Registry][bcp47] with some manual modifications. If an
OpenType tag maps to a BCP 47 macrolanguage, all the macrolanguage's
individual languages are mapped to the same OpenType tag, except for
individual languages with their own OpenType mappings. Deprecated
BCP 47 tags are canonicalized.

[ot]: https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags
[bcp47]: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

Some OpenType tags correspond to multiple ISO 639 codes. The mapping
from ISO 639 codes lists OpenType tags in priority order, such that more
specific or more likely tags appear first.

Some OpenType tags have no corresponding ISO 639 code in the registry so
their mappings use BCP 47 subtags besides the language. For example, any
BCP 47 tag with a fonipa variant subtag is mapped to 'IPPH', and 'IPPH'
is mapped back to und-fonipa.

Other OpenType tags have no corresponding ISO 639 code because it is not
clear what they are for. HarfBuzz just ignores these tags.

One such ignored tag is 'ZHP ' (Chinese Phonetic). It probably means
zh-Latn. However, it is used in Microsoft JhengHei and Microsoft YaHei
with the script tag 'hani', implying that it is not a romanization
scheme after all. It would be simple enough to add this mapping to
gen-tag-table.py once a definitive mapping is determined.

The manual modifications are mainly either obvious mappings that the
OpenType registry omits or mappings for compatibility with previous
versions of HarfBuzz. Some of the old mappings were discarded, though,
for homophonous language names. For example, OpenType maps 'KUI ' to
kxu; previous versions of HarfBuzz also mapped it to kvd, because kvd
and kxu both happen to be called "Kui".

gen-tag-table.py also generates a function to convert multi-subtag tags
like el-polyton and zh-HK to OpenType tags, replacing `ot_languages_zh`
and the hard-coded list of special cases in `hb_ot_tags_from_language`.
It also generates a function to convert OpenType tags to BCP 47,
replacing the hard-coded list of special cases in
`hb_ot_tag_to_language`.

5 years agoDeprecate obsolete functions
David Corbett [Fri, 29 Dec 2017 12:19:05 +0000 (20:19 +0800)]
Deprecate obsolete functions

`hb_ot_tags` replaces `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`.

`hb_ot_layout_table_select_script` replaces
`hb_ot_layout_table_choose_script`.

`hb_ot_layout_script_select_language` replaces
`hb_ot_layout_script_find_language`.

5 years agoRefactor the selection of script and language tags
David Corbett [Fri, 8 Dec 2017 16:21:14 +0000 (11:21 -0500)]
Refactor the selection of script and language tags

The old hb-ot-tag.cc functions, `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`, are now wrappers around a new function:
`hb_ot_tags`. It converts a script and a language to arrays of script
tags and language tags. This will make it easier to add new script tags
to scripts, like 'dev3'. It also allows for language fallback chains;
nothing produces more than one language yet though.

Where the old functions return the default tags 'DFLT' and 'dflt',
`hb_ot_tags` returns an empty array. The caller is responsible for
using the default tag in that case.

The new function also adds a new private use subtag syntax for script
overrides: "x-hbscabcd" requests a script tag of 'abcd'.

The old hb-ot-layout.cc functions,`hb_ot_layout_table_choose_script` and
`hb_ot_layout_script_find_language` are now wrappers around the new
functions `hb_ot_layout_table_select_script` and
`hb_ot_layout_script_select_language`. They are essentially the same as
the old ones plus a tag count parameter.

Closes #495.

5 years agoReplace "ISO 639" with "BCP 47"
David Corbett [Thu, 28 Dec 2017 14:59:29 +0000 (22:59 +0800)]
Replace "ISO 639" with "BCP 47"

`hb_language_from_string` accepts not only ISO 639 but also BCP 47. Not
all ISO 639 codes are valid BCP 47 tags but the function does not accept
overlong language subtags anyway.

5 years ago[aat] Apply kerx if GPOS kern was not applied
Behdad Esfahbod [Thu, 11 Oct 2018 17:26:58 +0000 (13:26 -0400)]
[aat] Apply kerx if GPOS kern was not applied

Ned tells me this is what Apple does.

5 years agoMinor
Behdad Esfahbod [Thu, 11 Oct 2018 17:24:17 +0000 (13:24 -0400)]
Minor

5 years ago[trak] Add tests
Behdad Esfahbod [Thu, 11 Oct 2018 15:30:45 +0000 (11:30 -0400)]
[trak] Add tests

5 years ago[trak] Implement extrapolation
Behdad Esfahbod [Thu, 11 Oct 2018 15:25:07 +0000 (11:25 -0400)]
[trak] Implement extrapolation

This concludes trak, as well as AAT shaping support!

5 years ago[trak] Fix, and hook up
Behdad Esfahbod [Thu, 11 Oct 2018 15:10:06 +0000 (11:10 -0400)]
[trak] Fix, and hook up

Works beautifully!  Test coming.

5 years ago[trak] Handle nSizes=0 and 1
Behdad Esfahbod [Thu, 11 Oct 2018 14:32:08 +0000 (10:32 -0400)]
[trak] Handle nSizes=0 and 1

5 years ago[trak] Fix counting
Behdad Esfahbod [Thu, 11 Oct 2018 14:30:32 +0000 (10:30 -0400)]
[trak] Fix counting

5 years ago[trak] More
Behdad Esfahbod [Thu, 11 Oct 2018 14:29:02 +0000 (10:29 -0400)]
[trak] More

5 years ago[trak] Only adjust around first glyph
Behdad Esfahbod [Thu, 11 Oct 2018 14:22:01 +0000 (10:22 -0400)]
[trak] Only adjust around first glyph

Assumes graphemes only have one base glyph.

5 years ago[trak] Clean up
Behdad Esfahbod [Thu, 11 Oct 2018 14:18:46 +0000 (10:18 -0400)]
[trak] Clean up

5 years ago[kerx] Implement Format4 action_type=1 contour-point-based attachment
Behdad Esfahbod [Thu, 11 Oct 2018 05:22:29 +0000 (01:22 -0400)]
[kerx] Implement Format4 action_type=1 contour-point-based attachment

Untested.

This concludes kerx table support!

5 years ago[kerx] Implement Format4 action_type=2 coordinate-based attachment
Behdad Esfahbod [Thu, 11 Oct 2018 05:17:57 +0000 (01:17 -0400)]
[kerx] Implement Format4 action_type=2 coordinate-based attachment

Untested.

5 years ago[kerx] Implement Format4 'ankr'-based mark attachment
Behdad Esfahbod [Thu, 11 Oct 2018 05:14:18 +0000 (01:14 -0400)]
[kerx] Implement Format4 'ankr'-based mark attachment

Tested with Kannada MN:

$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0CCD,0C95,0CD6
[kn_ka.vattu=0+230|kn_ai_length_mark=1@326,0+607]

5 years ago[aat] Wire up 'ankr' table to apply context
Behdad Esfahbod [Thu, 11 Oct 2018 04:52:07 +0000 (00:52 -0400)]
[aat] Wire up 'ankr' table to apply context

5 years ago[kerx] Flesh out Format4
Behdad Esfahbod [Thu, 11 Oct 2018 04:12:49 +0000 (00:12 -0400)]
[kerx] Flesh out Format4

Doesn't apply actions yet.

5 years ago[ankr] Implement table access
Behdad Esfahbod [Thu, 11 Oct 2018 03:07:03 +0000 (23:07 -0400)]
[ankr] Implement table access

5 years ago[ankr] Start fixing
Behdad Esfahbod [Thu, 11 Oct 2018 02:56:52 +0000 (22:56 -0400)]
[ankr] Start fixing

5 years agoUgh. Re-enable accidentally disabled GPOS
Behdad Esfahbod [Thu, 11 Oct 2018 02:17:07 +0000 (22:17 -0400)]
Ugh. Re-enable accidentally disabled GPOS

5 years ago[kerx] Allow granularly disabling kerning
Behdad Esfahbod [Thu, 11 Oct 2018 02:15:13 +0000 (22:15 -0400)]
[kerx] Allow granularly disabling kerning

5 years ago[kerx] Comment
Behdad Esfahbod [Thu, 11 Oct 2018 01:53:14 +0000 (21:53 -0400)]
[kerx] Comment

5 years ago[kerx] Make Format1 work
Behdad Esfahbod [Thu, 11 Oct 2018 01:46:58 +0000 (21:46 -0400)]
[kerx] Make Format1 work

Tested using Kannada MN:

$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD
[kn_ka.virama=0+1299|kn_ka.vattu=0+115|_blank=0@-115,0+385]

$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD --features=-kern
[kn_ka.virama=0+1799|kn_ka.vattu=0+230|_blank=0+0]

I don't see the GPOS table in the font do the same.  ¯\_(ツ)_/¯

5 years agoDisable mark advance zeroing as well as mark fallback positioning if doing kerx
Behdad Esfahbod [Thu, 11 Oct 2018 01:29:46 +0000 (21:29 -0400)]
Disable mark advance zeroing as well as mark fallback positioning if doing kerx

5 years ago[kerx] Implement Format1
Behdad Esfahbod [Thu, 11 Oct 2018 01:18:37 +0000 (21:18 -0400)]
[kerx] Implement Format1

Untested.

5 years ago[kerx] More UnsizedArrayOf<>
Behdad Esfahbod [Thu, 11 Oct 2018 00:43:21 +0000 (20:43 -0400)]
[kerx] More UnsizedArrayOf<>

5 years ago[kerx] Fix bound-checking error introduced a couple commits past
Behdad Esfahbod [Thu, 11 Oct 2018 00:41:16 +0000 (20:41 -0400)]
[kerx] Fix bound-checking error introduced a couple commits past

5 years ago[kerx] Start fleshing out Format1
Behdad Esfahbod [Thu, 11 Oct 2018 00:37:22 +0000 (20:37 -0400)]
[kerx] Start fleshing out Format1

5 years ago[kerx] Implement Format6
Behdad Esfahbod [Thu, 11 Oct 2018 00:10:20 +0000 (20:10 -0400)]
[kerx] Implement Format6

Untested.  The only Apple font shipping with this format is San Francisco fonts
that use this for their kerx variation tables, which we don't support.

5 years ago[kerx] Move bounds-checking to subtable length itself
Behdad Esfahbod [Thu, 11 Oct 2018 00:00:44 +0000 (20:00 -0400)]
[kerx] Move bounds-checking to subtable length itself

5 years ago[kerx] Start fleshing out Format6
Behdad Esfahbod [Wed, 10 Oct 2018 23:58:20 +0000 (19:58 -0400)]
[kerx] Start fleshing out Format6

5 years ago[kerx] When rejecting variable kerning, also check for tupleCount
Behdad Esfahbod [Wed, 10 Oct 2018 23:20:06 +0000 (19:20 -0400)]
[kerx] When rejecting variable kerning, also check for tupleCount

5 years ago[kerx] No-op
Behdad Esfahbod [Wed, 10 Oct 2018 23:11:30 +0000 (19:11 -0400)]
[kerx] No-op

Tested that Format0 works with Kannada MN font:

$ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+1000|kn_matra_uu=0@-30,0+1345]

$ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-kern
[kn_ka=0+1030|kn_matra_uu=0+1375]

Note that GPOS does the same with 'dist' feature, and applies the whole difference to the
same glyph:

$ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+970|kn_matra_uu=0+1375]

$ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-dist
[kn_ka=0+1030|kn_matra_uu=0+1375]

5 years agoComment
Behdad Esfahbod [Wed, 10 Oct 2018 23:02:32 +0000 (19:02 -0400)]
Comment

5 years agoFix option string matching
Behdad Esfahbod [Wed, 10 Oct 2018 22:59:07 +0000 (18:59 -0400)]
Fix option string matching

5 years ago[kern/kerx] Fix offset base
Behdad Esfahbod [Wed, 10 Oct 2018 22:14:41 +0000 (18:14 -0400)]
[kern/kerx] Fix offset base

Disable kern Format2.

Fix kerx Format2.  Manually tested this with Tamil MN font and it works:

$ HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95
[tgv_au=0+3435|tgc_ka=1@-75,0+1517]

 HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95 --features=-kern
[tgv_au=0+3510|tgc_ka=1+1592]

5 years ago[kerx] Don't loop over kerning subtables if kerning disabled
Behdad Esfahbod [Wed, 10 Oct 2018 22:10:05 +0000 (18:10 -0400)]
[kerx] Don't loop over kerning subtables if kerning disabled

5 years agoAllow HB_OPTIONS=aat to prefer AAT tables over OT
Behdad Esfahbod [Wed, 10 Oct 2018 21:44:46 +0000 (17:44 -0400)]
Allow HB_OPTIONS=aat to prefer AAT tables over OT

Fixes https://github.com/harfbuzz/harfbuzz/issues/322

5 years ago[kerx] Skip variation subtables
Behdad Esfahbod [Wed, 10 Oct 2018 21:32:32 +0000 (17:32 -0400)]
[kerx] Skip variation subtables

5 years agoRemove HAVE_OT
Behdad Esfahbod [Wed, 10 Oct 2018 20:32:35 +0000 (16:32 -0400)]
Remove HAVE_OT

We never tested compiling without it.  Just kill it.  We always build
our own shaper.

5 years ago[kerx] Actually hook up, and fix crash
Behdad Esfahbod [Wed, 10 Oct 2018 17:24:51 +0000 (13:24 -0400)]
[kerx] Actually hook up, and fix crash

5 years agoAdd per-subtable set-digests
Behdad Esfahbod [Wed, 10 Oct 2018 16:07:49 +0000 (12:07 -0400)]
Add per-subtable set-digests

This speeds up Roboto shaping by ~10%.  I was hoping for more.
Still, good defense against lookups with many subtables.