caryclark@google.com [Wed, 8 Feb 2012 17:15:42 +0000 (17:15 +0000)]
[Skia Mac] Make misspelling underline dots unclipped
https://bugs.webkit.org/show_bug.cgi?id=78117
http://code.google.com/p/chromium/issues/detail?id=113154
Reviewed by Stephen White.
No new tests. Existing layout tests cover this.
As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 8 Feb 2012 17:05:08 +0000 (17:05 +0000)]
Moved a Mac-specific test to platform/mac.
* fast/text/synthetic-bold-transformed-expected.html: Removed.
* fast/text/synthetic-bold-transformed.html: Removed.
* platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
* platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 17:01:35 +0000 (17:01 +0000)]
Initial upstreaming of input handling for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77992
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-08
Reviewed by Rob Buis.
* blackberry/WebKitSupport/InputHandler.cpp: Added.
* blackberry/WebKitSupport/InputHandler.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 16:57:45 +0000 (16:57 +0000)]
Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007
This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Source/WebKit/chromium:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 8 Feb 2012 16:42:23 +0000 (16:42 +0000)]
Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
https://bugs.webkit.org/show_bug.cgi?id=78116
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):
LayoutTests:
* inspector/elements/insert-node-expected.txt:
* inspector/elements/insert-node.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 8 Feb 2012 16:31:14 +0000 (16:31 +0000)]
[GTK] Fix a crash when WebKitWebView is created without a WebContext
https://bugs.webkit.org/show_bug.cgi?id=78104
Reviewed by Philippe Normand.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 16:17:20 +0000 (16:17 +0000)]
Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
https://bugs.webkit.org/show_bug.cgi?id=77967
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-08
Reviewed by Yury Semikhatsky.
Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.
* inspector/CodeGeneratorInspector.py:
(Generator.process_command):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 16:02:31 +0000 (16:02 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.
LayoutTests:
* platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 8 Feb 2012 15:51:53 +0000 (15:51 +0000)]
Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
https://bugs.webkit.org/show_bug.cgi?id=77972
When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.
Reviewed by Pavel Feldman.
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 8 Feb 2012 15:51:08 +0000 (15:51 +0000)]
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78099
Reviewed by Martin Robinson.
* MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 8 Feb 2012 15:48:51 +0000 (15:48 +0000)]
[GTK] Fix WebKitWebView::decide-policy API documentation
https://bugs.webkit.org/show_bug.cgi?id=78101
Reviewed by Martin Robinson.
- It refers to WebKitPolicyClient instead of WebKitWebView
- Trailing ':' is missing
- References @decision as WebKitNavigationPolicyDecision instead
of WebKitPolicyDecision
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 8 Feb 2012 15:38:19 +0000 (15:38 +0000)]
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=73431
Reviewed by Chris Fleizach.
Source/WebCore:
Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.
* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.
Source/WebKit/gtk:
Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.
* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 15:11:37 +0000 (15:11 +0000)]
Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022
Patch by Leo Franchi <lfranchi@kde.org> on 2012-02-08
Reviewed by Joseph Pecoraro.
* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 8 Feb 2012 14:57:37 +0000 (14:57 +0000)]
Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 8 Feb 2012 14:49:26 +0000 (14:49 +0000)]
Web Inspector: do not clear entire tree map upon last element deletion.
https://bugs.webkit.org/show_bug.cgi?id=78112
Reviewed by Yury Semikhatsky.
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._forgetChildrenRecursive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 14:39:18 +0000 (14:39 +0000)]
Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
Move createObjectURL & revokeObjectURL from DOMURL implementation to
static methods as per specs - http://www.w3.org/TR/FileAPI/#creating-revoking
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:
LayoutTests:
Added test to check if createObjectURL & revokeObjectURL are static functions.
* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
* platform/gtk/fast/js/global-constructors-expected.txt: ditto.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
* platform/qt/fast/js/global-constructors-expected.txt: ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 8 Feb 2012 14:06:04 +0000 (14:06 +0000)]
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 8 Feb 2012 14:02:21 +0000 (14:02 +0000)]
Unreviewed, update chromium svg expectations after r107067.
* platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 8 Feb 2012 13:22:33 +0000 (13:22 +0000)]
Web Inspector: Add changes for Spectrum colorpicker
https://bugs.webkit.org/show_bug.cgi?id=75454
Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-01
Reviewed by Pavel Feldman.
* inspector/front-end/Color.js:
(WebInspector.Color.fromRGB):
* inspector/front-end/utilities.js:
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 8 Feb 2012 13:00:54 +0000 (13:00 +0000)]
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
https://bugs.webkit.org/show_bug.cgi?id=78084
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 8 Feb 2012 12:59:38 +0000 (12:59 +0000)]
Unreviewed, GTK rebaseline and skipping 2 new failing tests.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 8 Feb 2012 12:58:19 +0000 (12:58 +0000)]
Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=78102
Reviewed by Vsevolod Vlasov.
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Feb 2012 12:48:11 +0000 (12:48 +0000)]
[Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093
Unskip these tests and rebaselines for Qt and GTK.
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.
* platform/gtk/Skipped:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
* platform/qt/Skipped:
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Feb 2012 12:38:46 +0000 (12:38 +0000)]
[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/qt/svg/custom/getTransformToElement-expected.png:
* platform/qt/svg/custom/getTransformToElement-expected.txt:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/custom/text-hit-test-expected.png:
* platform/qt/svg/custom/text-hit-test-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 8 Feb 2012 12:37:31 +0000 (12:37 +0000)]
2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline Gtk/SVG results.
* platform/gtk/svg/carto.net/scrollbar-expected.txt:
* platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 12:34:24 +0000 (12:34 +0000)]
CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
https://bugs.webkit.org/show_bug.cgi?id=69993
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-08
Reviewed by Simon Fraser.
Source/WebCore:
The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.
Tests: fast/css/getComputedStyle/computed-style-select-overflow.html
fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
LayoutTests:
* fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
* fast/forms/select-overflow-scroll-inherited.html: Added.
* fast/forms/select-overflow-scroll.html: Added.
* platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 8 Feb 2012 12:31:11 +0000 (12:31 +0000)]
qt fixes
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mahesh.kulkarni@nokia.com [Wed, 8 Feb 2012 12:24:50 +0000 (12:24 +0000)]
[Qt] Build broken if qt missing openssl
https://bugs.webkit.org/show_bug.cgi?id=77894
Reviewed by Chang Shu.
Build fix. No new test content.
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::onSslErrors):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 12:18:40 +0000 (12:18 +0000)]
Unreviewed. Rebaselined the test that has been failing since r107046.
* http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 8 Feb 2012 12:13:50 +0000 (12:13 +0000)]
[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968
Reviewed by Simon Hausmann.
Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.
* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyiconURL):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 8 Feb 2012 12:12:31 +0000 (12:12 +0000)]
feImage doesn't invalidate when its target SVG element is animated
https://bugs.webkit.org/show_bug.cgi?id=73860
Reviewed by Dirk Schulze.
Source/WebCore:
Consider following testcase:
<defs>
<rect id="rect" fill="red" width="50" height="50"/>
<filter id="filter">
<feImage xlink:href="#rect"/>
</filter>
</defs>
<rect width="50" height="50" filter="url(#filter)"/>
If the <rect id="rect"> gets changed dynamically (attribute/property/style change) the <feImage>
doesn't notice this, as there's no link between the <rect> and the <feImage>, as the <rect> is not
a child of the <feImage/>. To get invalidations working for these situations, we have to track
the referencingElement & referencedElement in SVGDocumentExtensions.
Fixes parts the SVG-Wow twirl testcase and David Daileys SVG waves example.
Tests: svg/filters/feImage-animated-transform-on-target-rect.svg
svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-mutliple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-target-style-change.svg
* rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromFilterCacheAndInvalidateDependencies): Renamed from removeFromFilterCache, as it has another purpose now.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): s/removeFromFilterCache/removeFromFilterCacheAndInvalidateDependencies/.
* rendering/svg/RenderSVGResource.h: Removed removeFromFilterCache, it got inlined.
* svg/SVGDocumentExtensions.cpp: Add a new HashMap<SVGElement*, OwnPtr<HashSet<SVGElement*> > > used for dependency tracking.
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Returns all elements the passed in element depends on.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Register element 'a' referencing target 'b'.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Called by element 'a' on destruction or any target change.
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Called by element 'b' on destruction.
* svg/SVGDocumentExtensions.h: Expose new methods.
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement): Call remove removeAllElementReferencesForTarget on destruction.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):
LayoutTests:
Add lots of new testcases covering <feImage> invalidation, when the referenced target changes.
Thanks to the repaint harness, it uncovered a bug with feImage-late-indirect-update.svg - there no gray
overlay rects are visible, as the whole screen gets repainted, which is a bug!
* platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/mac/svg/filters/feImage-change-target-id-expected.png: Added.
* platform/mac/svg/filters/feImage-change-target-id-expected.txt: Added.
* platform/mac/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/mac/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/mac/svg/filters/feImage-remove-target-expected.png: Added.
* platform/mac/svg/filters/feImage-remove-target-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-add-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-add-to-document-expected.png.
* platform/mac/svg/filters/feImage-target-add-to-document-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt.
* platform/mac/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-changes-id-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.png.
* platform/mac/svg/filters/feImage-target-changes-id-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-id-change-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.png.
* platform/mac/svg/filters/feImage-target-id-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.txt.
* platform/mac/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-inline-style-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-property-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png.
* platform/mac/svg/filters/feImage-target-reappend-to-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt.
* platform/mac/svg/filters/feImage-target-remove-from-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png.
* platform/mac/svg/filters/feImage-target-remove-from-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt.
* platform/mac/svg/filters/feImage-target-style-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-style-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
* svg/filters/feImage-animated-transform-on-target-rect.svg: Added.
* svg/filters/feImage-change-target-id.svg: Added.
* svg/filters/feImage-late-indirect-update.svg: Added.
* svg/filters/feImage-multiple-targets-id-change.svg: Added.
* svg/filters/feImage-remove-target.svg: Added.
* svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg: Added.
* svg/filters/feImage-target-attribute-change-with-use-indirection.svg: Added.
* svg/filters/feImage-target-attribute-change.svg: Added.
* svg/filters/feImage-target-inline-style-change.svg: Added.
* svg/filters/feImage-target-property-change.svg: Added.
* svg/filters/feImage-target-style-change.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Feb 2012 12:02:42 +0000 (12:02 +0000)]
[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 11:53:13 +0000 (11:53 +0000)]
[EFL] Using string method instead of char* operation in the platformLanguage().
https://bugs.webkit.org/show_bug.cgi?id=78077
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.
No new tests. Just fix a bug of platformLanguage function.
* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
Change char* operation to string operation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 8 Feb 2012 11:40:09 +0000 (11:40 +0000)]
Revert a part of the change in r106687 as a build fix.
Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run "svn info" on webkit_base.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 11:15:40 +0000 (11:15 +0000)]
Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 8 Feb 2012 11:13:03 +0000 (11:13 +0000)]
Web Inspector: Touch event emulation fails for iframes
https://bugs.webkit.org/show_bug.cgi?id=77987
Reviewed by Pavel Feldman.
Source/WebCore:
Test: fast/events/touch/emulated-touch-iframe.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
LayoutTests:
* fast/events/touch/emulated-touch-iframe-expected.txt: Added.
* fast/events/touch/emulated-touch-iframe.html: Added.
* fast/events/touch/resources/emulated-touch-iframe2.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Wed, 8 Feb 2012 11:03:52 +0000 (11:03 +0000)]
StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
<http://webkit.org/b/78068>
Rubber-stamped by Ryosuke Niwa.
Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).
* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 8 Feb 2012 10:55:20 +0000 (10:55 +0000)]
Unreviewed, rolling out r107050.
http://trac.webkit.org/changeset/107050
https://bugs.webkit.org/show_bug.cgi?id=78094
May crash editing tests (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Feb 2012 10:42:55 +0000 (10:42 +0000)]
[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=77995
Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-08
Reviewed by Csaba Osztrogonác.
Source/WebCore:
From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.
Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.
* svg/graphics/SVGImage.h:
LayoutTests:
* platform/qt/Skipped: Unskip previously skipped tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 10:39:13 +0000 (10:39 +0000)]
Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
Tests: fast/loader/stateobjects/state-attribute-object-types.html
fast/loader/stateobjects/state-attribute-only-one-deserialization.html
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* page/History.cpp:
(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):
* page/History.h:
(History):
* page/History.idl:
LayoutTests:
* fast/dom/Window/window-appendages-cleared-expected.txt:
* fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-object-types.html: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 8 Feb 2012 10:21:49 +0000 (10:21 +0000)]
SVGLoad event fires too early
https://bugs.webkit.org/show_bug.cgi?id=78084
Reviewed by Hajime Morita.
Source/WebCore:
SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest).
We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer,
which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event",
thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document,
<svg onload="alert(evt.target)"> will say SVGSVGElement).
Consider:
<svg onload="alert('1')>
<g onload="alert('2)">
<rect onload="alert('3')"/>
</svg>
As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired.
So first you'll see '3', then '2', then '1'.
Using:
<svg onload="alert('1')>
<g onload="alert('2)">
<image xlink:href="someExternal.jpg" onload="alert('3')"/>
</svg>
will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire,
then '3', then '2', all as expected and specified in SVG.
http://www.w3.org/TR/SVG/interact.html#LoadEvent says:
"The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is
ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced
external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional
external resources are not required to be ready for the event to be triggered."
What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that
element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after
</svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for
WebKit, as we're not yet "ready to render".
HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent.
At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be
equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks.
Covered by existing tests.
* dom/Document.cpp:
(WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event.
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible.
There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element.
* svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper.
* svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG().
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet.
(WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements.
* svg/SVGElement.h: Add isOutermostSVGSVGElement().
* svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement.
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::createRenderer):
* svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement.
LayoutTests:
Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly.
This is now possible as the outermost <svg> elements load event timing as aligned with HTML.
* fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed.
(runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken).
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/mac/svg/custom/getTransformToElement-expected.png:
* platform/mac/svg/custom/getTransformToElement-expected.txt:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/mac/svg/custom/text-ctm-expected.png:
* platform/mac/svg/custom/text-ctm-expected.txt:
* platform/mac/svg/custom/text-hit-test-expected.png:
* platform/mac/svg/custom/text-hit-test-expected.txt:
* platform/mac/svg/filters/filter-refresh-expected.png:
* svg/carto.net/tabgroup.svg:
* svg/carto.net/window.svg:
* svg/css/shadow-changes.svg:
* svg/custom/loadevents-externalresourcesrequired.svg:
* svg/dom/SVGPathSegList-segment-modification.svg:
* svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
* svg/dom/SVGRectElement/rect-modify-rx.svg:
* svg/filters/animate-fill.svg:
* svg/filters/feImage-reference-invalidation.svg:
* svg/filters/feImage-target-add-to-document.svg:
* svg/filters/feImage-target-changes-id.svg:
* svg/filters/feImage-target-id-change.svg:
* svg/filters/feImage-target-reappend-to-document.svg:
* svg/filters/feImage-target-remove-from-document.svg:
* svg/filters/filter-refresh.svg:
* svg/filters/filter-width-update.svg:
* svg/filters/invalidate-on-child-layout.svg:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:
* svg/hixie/perf/007.xml:
* svg/repaint/container-repaint.svg:
* svg/repaint/filter-child-repaint.svg:
* svg/repaint/image-href-change.svg:
* svg/repaint/image-with-clip-path.svg:
* svg/text/text-text-05-t.svg:
* svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/page/absolute-sized-document-scrollbars.svg:
* svg/zoom/page/relative-sized-document-scrollbars.svg:
* svg/zoom/page/zoom-coords-viewattr-01-b.svg:
* svg/zoom/page/zoom-foreignObject.svg:
* svg/zoom/page/zoom-mask-with-percentages.svg:
* svg/zoom/resources/testPageZoom.js:
(repaintTest):
* svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/text/absolute-sized-document-scrollbars.svg:
* svg/zoom/text/relative-sized-document-scrollbars.svg:
* svg/zoom/text/zoom-coords-viewattr-01-b.svg:
* svg/zoom/text/zoom-foreignObject.svg:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 8 Feb 2012 10:11:31 +0000 (10:11 +0000)]
Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
https://bugs.webkit.org/show_bug.cgi?id=78090
Reviewed by Vsevolod Vlasov.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 8 Feb 2012 10:00:52 +0000 (10:00 +0000)]
Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/lazy-computed-style.html
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
* inspector/elements/elements-panel-styles.html:
* inspector/styles/css-live-edit.html:
* inspector/styles/lazy-computed-style-expected.txt: Added.
* inspector/styles/lazy-computed-style.html: Added.
* inspector/styles/styles-computed-trace.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tommyw@google.com [Wed, 8 Feb 2012 09:52:17 +0000 (09:52 +0000)]
MediaStream API: Adding the onstatechange callback to PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=77954
When readyState changes a callback should be triggered.
Reviewed by Adam Barth.
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
* dom/EventNames.h:
(WebCore):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::changeReadyState):
* mediastream/PeerConnection.h:
(PeerConnection):
(WebCore::PeerConnection::didChangeState):
* mediastream/PeerConnection.idl:
* platform/mediastream/PeerConnectionHandlerClient.h:
(PeerConnectionHandlerClient):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 8 Feb 2012 09:51:14 +0000 (09:51 +0000)]
run-perf-tests doesn't recognize paths that start with PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=78012
Reviewed by Adam Barth.
Use resolve paths using filesystem.relpath before passing it to find_files.find.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):
(test_collect_tests.add_file):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 8 Feb 2012 09:17:27 +0000 (09:17 +0000)]
Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.
* platform/qt/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 08:57:50 +0000 (08:57 +0000)]
Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963
Reviewed by Adam Barth.
This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestInterface.idl:
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 08:57:08 +0000 (08:57 +0000)]
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.
ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.
No new tests, no change in behavior.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 8 Feb 2012 08:47:02 +0000 (08:47 +0000)]
2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing results for a new SVG test.
* platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 8 Feb 2012 08:37:01 +0000 (08:37 +0000)]
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Wed, 8 Feb 2012 08:29:22 +0000 (08:29 +0000)]
Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 08:13:58 +0000 (08:13 +0000)]
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971
Reviewed by Adam Barth.
Source/WebCore:
[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].
Test: http/tests/security/cross-frame-access-frameelement.html
* page/DOMWindow.idl:
LayoutTests:
The added test checks if frameElement is accessible from the same or cross origin iframe.
* http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
* http/tests/security/cross-frame-access-frameelement.html: Added.
* http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 08:05:56 +0000 (08:05 +0000)]
Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081
Reviewed by Adam Barth.
[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/HTMLElement.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 8 Feb 2012 08:05:05 +0000 (08:05 +0000)]
[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959
Reviewed by Martin Robinson.
Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 8 Feb 2012 07:21:31 +0000 (07:21 +0000)]
[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789
Reviewed by Philippe Normand.
Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.
* GNUmakefile.am: Added new source files to the list.
* UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
* UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 06:56:26 +0000 (06:56 +0000)]
[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067
Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
Source/Platform:
This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.
Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.
* Platform.gyp/Platform.gyp:
* Platform.gyp/copy_webcore_headers.py: Added.
(CopyHeaders):
(Main):
* chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.
(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.
(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):
* chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.
(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.
(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.
(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.
(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):
Source/WebKit/chromium:
Add forwarding headers for several API types moved into Platform.
* public/platform/WebFloatPoint.h:
* public/platform/WebFloatQuad.h:
* public/platform/WebFloatRect.h:
* public/platform/WebPoint.h:
* public/platform/WebRect.h:
* public/platform/WebSize.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 06:40:54 +0000 (06:40 +0000)]
Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846
Reviewed by Darin Adler.
In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:
[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/TestTypedArray.idl:
* dom/Attr.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Node.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMURL.idl:
* html/HTMLAppletElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLVideoElement.idl:
* html/TextTrackCue.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* mediastream/LocalMediaStream.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/StorageInfo.idl:
* svg/SVGElement.idl:
* svg/SVGElementInstance.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 8 Feb 2012 06:33:11 +0000 (06:33 +0000)]
[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066
Reviewed by Ryosuke Niwa.
Added a new default constructor. ex-default constructor will be removed
in an upcoming change.
* public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 05:47:36 +0000 (05:47 +0000)]
Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076
Reviewed by Adam Barth.
This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].
Test: bindings/scripts/test/TestCustomNamedGetter.idl
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):
* html/HTMLDocument.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameSetElement.idl:
* bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.
* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.
(WebCore):
(WebDOMTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.
(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.
(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.
(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.
(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.
(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Wed, 8 Feb 2012 05:37:54 +0000 (05:37 +0000)]
Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918
Reviewed by Eric Seidel.
Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.
No new tests.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 05:34:09 +0000 (05:34 +0000)]
Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061
Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 05:06:33 +0000 (05:06 +0000)]
Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
* wtf/Platform.h:
Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
* WebCore.gypi:
* platform/PlatformGestureRecognizer.h: Removed.
* platform/chromium/FramelessScrollView.h:
(WebCore):
(FramelessScrollView):
* platform/chromium/GestureRecognizerChromium.cpp: Removed.
* platform/chromium/GestureRecognizerChromium.h: Removed.
* platform/chromium/PopupContainer.cpp:
(WebCore):
* platform/chromium/PopupContainer.h:
* platform/chromium/PopupListBox.cpp:
(WebCore):
* platform/chromium/PopupListBox.h:
(PopupListBox):
Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
* blackberry/WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
* WebKit.gypi:
* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
* tests/InnerGestureRecognizerTest.cpp: Removed.
LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
* fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/events/touch/touch-gesture-click-expected.txt: Removed.
* fast/events/touch/touch-gesture-click.html: Removed.
* fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
* fast/events/touch/touch-gesture-scroll.html: Removed.
* platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
* platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 8 Feb 2012 04:23:34 +0000 (04:23 +0000)]
[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052
Reviewed by Nate Chapin.
Source/WebCore:
Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.
Covered by existing tests
* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 04:14:02 +0000 (04:14 +0000)]
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059
Reviewed by Adam Barth.
CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].
Test: bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Wed, 8 Feb 2012 04:05:20 +0000 (04:05 +0000)]
[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843
Reviewed by Rob Buis.
Initial upstream, no new tests.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Wed, 8 Feb 2012 03:56:27 +0000 (03:56 +0000)]
Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040
Reviewed by Eric Seidel.
Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.
When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.
In summary, the values are computed as follows:
x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)
We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.
No new tests, no functionality changes.
* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
* rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 8 Feb 2012 03:53:22 +0000 (03:53 +0000)]
Unreviewed gardening.
Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.
* platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Wed, 8 Feb 2012 03:40:33 +0000 (03:40 +0000)]
CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960
Source/WebCore:
Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.
Reviewed by Ojan Vafai.
* css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parsedDouble):
LayoutTests:
Reviewed by Ojan Vafai.
* css3/calc/color-hsl-expected.txt:
* css3/calc/color-rgb-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Wed, 8 Feb 2012 03:26:18 +0000 (03:26 +0000)]
REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>
Reviewed by Ryosuke Niwa.
Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.
* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 8 Feb 2012 03:20:07 +0000 (03:20 +0000)]
Avoid making a window for the Web Inspector when it is docked.
This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.
https://webkit.org/b/78064
Reviewed by Brian Weinstein.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 8 Feb 2012 03:10:38 +0000 (03:10 +0000)]
Remove TextureMapperQt from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=78055
Reviewed by Noam Rosenthal.
TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.
* WebCore.gypi:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 8 Feb 2012 03:00:36 +0000 (03:00 +0000)]
merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036
Reviewed by Darin Adler.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
Source/WebCore:
In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.
No new tests, build refactoring.
* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
* DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
* DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
* WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
* css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
* css/DashboardSupportCSSPropertyNames.in: Removed.
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 02:51:57 +0000 (02:51 +0000)]
Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.
Add the FFTFrame implementation using Intel IPP's DFT algorithm.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
(FFTFrame):
* platform/audio/FFTFrameStub.cpp:
* platform/audio/ipp/FFTFrameIPP.cpp: Added.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 8 Feb 2012 02:47:50 +0000 (02:47 +0000)]
Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033
Reviewed by James Robinson.
There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 02:21:04 +0000 (02:21 +0000)]
Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907
Patch by Chris Palmer <palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.
Source/WebCore:
Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):
LayoutTests:
* http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
* http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 02:06:08 +0000 (02:06 +0000)]
[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039
Patch by Justin Novosad <junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.
Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setDeferred2dCanvasEnabled):
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 02:05:34 +0000 (02:05 +0000)]
[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029
Patch by Yong Li <yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.
When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.
No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 8 Feb 2012 01:51:10 +0000 (01:51 +0000)]
[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928
Reviewed by Daniel Bates.
CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.
.:
* CMakeLists.txt: Set library output path.
* Source/cmake/WebKitFS.cmake: Remove *Programs* creation.
Source/JavaScriptCore:
* shell/CMakeLists.txt: Change *Programs* with *bin*.
Source/WebKit2:
* CMakeLists.txt:
Tools:
* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* Scripts/run-launcher:
* Scripts/webkitdirs.pm:
(jscProductDir):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_driver):
(EflPort._path_to_image_diff):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 01:49:27 +0000 (01:49 +0000)]
Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034
Source/WebCore:
Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.
Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.
No new tests.
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):
- changed to a static member function since 'this' is unused;
removed redundant non-const version
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):
- changed to a static member function since 'this' is unused;
removed redundant non-const version
(WebCore):
* rendering/mathml/RenderMathMLFraction.cpp:
* rendering/mathml/RenderMathMLMath.cpp:
* rendering/mathml/RenderMathMLMath.h:
* rendering/mathml/RenderMathMLOperator.h:
(WebCore):
* rendering/mathml/RenderMathMLRoot.cpp:
* rendering/mathml/RenderMathMLRow.cpp:
* rendering/mathml/RenderMathMLRow.h:
* rendering/mathml/RenderMathMLSquareRoot.cpp:
* rendering/mathml/RenderMathMLSquareRoot.h:
* rendering/mathml/RenderMathMLSubSup.cpp:
* rendering/mathml/RenderMathMLSubSup.h:
* rendering/mathml/RenderMathMLUnderOver.cpp:
* rendering/mathml/RenderMathMLUnderOver.h:
LayoutTests:
Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.
The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.
* mathml/presentation/row.xhtml:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/row-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 01:37:55 +0000 (01:37 +0000)]
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030
Unreviewed.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 8 Feb 2012 01:28:16 +0000 (01:28 +0000)]
Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.
If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 01:16:40 +0000 (01:16 +0000)]
Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.
Move checks from webkit.m4 to configure.ac and modernize macros:
. Check for visibility flags after CXX has been defined
. Use PKG_PROG_PKG_CONFIG for pkg-config lookup
. Drop unused LIBFFTW_REQUIRED_VERSION
. Update ICU libs for mingw (bug 77837).
. Require Pango 1.21.0 (as per unicode backend)
. Bump minimum glib version due to g_thread_init changes
* Source/autotools/webkit.m4: Removed.
* configure.ac:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 01:03:07 +0000 (01:03 +0000)]
[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020
Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.
Source/WebCore:
Revert r101854.
This patch is tested by the following unit test:
- TextureManagerTest.requestTextureExceedingPreferredLimit
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::reserve):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):
Source/WebKit/chromium:
Update TextureManagerTest.requestTextureExceedingPreferredLimit test.
* tests/TextureManagerTest.cpp:
(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 8 Feb 2012 01:00:06 +0000 (01:00 +0000)]
Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/
10247932>
Reviewed by Sam Weinig.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.
(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.
* platform/graphics/Region.cpp:
* platform/graphics/Region.h:
Add a simple contains(const IntPoint&) member function.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 8 Feb 2012 00:59:11 +0000 (00:59 +0000)]
<rdar://problem/
10475450> Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044
Reviewed by Beth Dakin.
Source/WebCore:
Tests: fast/text/synthetic-bold-transformed-expected.html
fast/text/synthetic-bold-transformed.html
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.
LayoutTests:
* fast/text/synthetic-bold-transformed-expected.html: Added.
* fast/text/synthetic-bold-transformed.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 8 Feb 2012 00:55:58 +0000 (00:55 +0000)]
[EFL] Add missing initialization of editable variable.
https://bugs.webkit.org/show_bug.cgi?id=77948
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.
The value of editable in Ewk_Frame_Smart_Data struct is not set.
* ewk/ewk_frame.cpp:
(ewk_frame_editable_set):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 8 Feb 2012 00:52:39 +0000 (00:52 +0000)]
Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914
Reviewed by Eric Seidel.
Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.
No new tests. No changed behavior.
* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderFrameSet.h:
(RenderFrameSet):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 8 Feb 2012 00:40:31 +0000 (00:40 +0000)]
Add JSC support for delivering mutations when the outermost script context exits
https://bugs.webkit.org/show_bug.cgi?id=70289
Reviewed by Eric Seidel.
Source/WebCore:
The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).
The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.
* bindings/js/JSDictionary.h:
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSMainThreadExecState.cpp:
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.
Tools:
* DumpRenderTree/mac/EventSendingController.mm: Add support for
eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
* Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
LayoutTests:
With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).
* fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
* fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
* fast/mutation/observe-characterdata.html: ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 8 Feb 2012 00:17:42 +0000 (00:17 +0000)]
Fix build.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollableAreaBoundingBox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 8 Feb 2012 00:14:42 +0000 (00:14 +0000)]
[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392
Reviewed by Eric Seidel.
Source/WebCore:
Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.
Test: svg/custom/use-disappears-after-style-update.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::didRecalcStyle):
LayoutTests:
* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* svg/custom/use-disappears-after-style-update.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 8 Feb 2012 00:00:18 +0000 (00:00 +0000)]
Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973
Reviewed by Adam Barth.
This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 7 Feb 2012 23:53:02 +0000 (23:53 +0000)]
media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779
Reviewed by Eric Carlson.
Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 7 Feb 2012 23:47:59 +0000 (23:47 +0000)]
Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050
Reviewed by Dan Bernstein.
We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.
* page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.
* platform/ScrollableArea.h:
Add scrollableAreaBoundingBox member function.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 7 Feb 2012 23:46:40 +0000 (23:46 +0000)]
unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310
Reviewed by Eric Seidel.
Source/WebCore:
Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.
Tests: fast/text/international/inline-plaintext-is-isolated-expected.html
fast/text/international/inline-plaintext-is-isolated.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
fast/text/international/inline-plaintext-with-generated-content-expected.html
fast/text/international/inline-plaintext-with-generated-content.html
* platform/text/UnicodeBidi.h:
(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.
* rendering/InlineIterator.h:
(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.
LayoutTests:
Ref tests for unicode-bidi: plaintext on inlines.
* fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
* fast/text/international/inline-plaintext-is-isolated.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
* fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
* fast/text/international/inline-plaintext-with-generated-content.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 7 Feb 2012 23:43:28 +0000 (23:43 +0000)]
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045
Reviewed by Darin Adler.
Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.
* runtime/JSType.h:
- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
and thus is excluded from isVariableObject() checks.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 23:38:19 +0000 (23:38 +0000)]
[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957
Reviewed by Adam Barth.
This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 23:29:58 +0000 (23:29 +0000)]
[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715
Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.
PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.
Tested with manual tests.
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 7 Feb 2012 23:12:27 +0000 (23:12 +0000)]
Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.
* platform/mac/PlatformClockCM.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 7 Feb 2012 23:07:47 +0000 (23:07 +0000)]
Unreviewed gardening after r106982.
* platform/chromium/test_expectations.txt:
We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 23:03:10 +0000 (23:03 +0000)]
[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.
* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc