danno@chromium.org [Thu, 24 Jul 2014 12:39:01 +0000 (12:39 +0000)]
SKIP migration tests to improve unit test time (2x)
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
416003004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22599
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rmcilroy@chromium.org [Thu, 24 Jul 2014 12:30:53 +0000 (12:30 +0000)]
Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer constant pool entries as poitners.")
TBR=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
413173002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22598
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rmcilroy@chromium.org [Thu, 24 Jul 2014 12:12:44 +0000 (12:12 +0000)]
Use heap iterator in store buffer when page was swept precisely.
BUG=
R=rmcilroy@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22592
Review URL: https://codereview.chromium.org/
413693002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22597
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 24 Jul 2014 12:11:30 +0000 (12:11 +0000)]
Flag for serialization when compiling code stubs if --serialize-toplevel.
R=mvstanton@chromium.org
BUG=v8:3465
LOG=N
Review URL: https://codereview.chromium.org/
419503002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22596
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 24 Jul 2014 12:08:23 +0000 (12:08 +0000)]
Keep new arrays allocated with 'new Array(N)' in fast mode
Also explicit length setting with a.length = N should remain in fast mode.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
397593008
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22595
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 24 Jul 2014 11:33:46 +0000 (11:33 +0000)]
Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder
BUG=
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
415953005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22594
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ernstm@chromium.org [Thu, 24 Jul 2014 11:16:01 +0000 (11:16 +0000)]
re-land: Track history of events in GCTracer.
- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- various clean-ups.
This is a re-land of https://codereview.chromium.org/
391413006/ with
- int instead of size_t in ring buffer unit test.
- git cl format
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
411293002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22593
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Thu, 24 Jul 2014 10:45:37 +0000 (10:45 +0000)]
Use heap iterator in store buffer when page was swept precisely.
BUG=
R=rmcilroy@chromium.org
Review URL: https://codereview.chromium.org/
413693002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22592
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 24 Jul 2014 10:43:41 +0000 (10:43 +0000)]
Introduce more debug events for promises.
BUG=v8:3093
LOG=Y
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
393283007
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22591
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Thu, 24 Jul 2014 10:04:14 +0000 (10:04 +0000)]
Skip test on mips.
PASS/FAIL is not enough as the test result is CRASH.
R=yangguo@chromium.org
TBR=yangguo@chromium.org
BUG=v8:3457
LOG=n
Review URL: https://codereview.chromium.org/
415773005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22590
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 24 Jul 2014 09:31:45 +0000 (09:31 +0000)]
Extend the interceptor setter ASSERT to support the JSGlobalProxy case.
BUG=v8:3463
LOG=n
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
415973004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22589
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Thu, 24 Jul 2014 09:26:03 +0000 (09:26 +0000)]
Partially revert "Unflake and speedup JsNative*Sample cpu profile tests"
This reverts the test expectations of commit r22345. Several cpu profiler flakes were happening lately.
BUG=v8:2999
LOG=n
R=bmeurer@chromium.org
TBR=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
418843002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22588
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 24 Jul 2014 09:13:04 +0000 (09:13 +0000)]
X87: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers
port r22551.
original commit message:
Always use the LoadStubCompiler for Load handlers, also for keyedload handlers
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
412903003
Patch from Chunyang Dai <chunyang.dai@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22587
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 24 Jul 2014 09:12:34 +0000 (09:12 +0000)]
X87: Only to the relevant checks in LoadFunctionPrototype
port r22550.
original commit message:
Only to the relevant checks in LoadFunctionPrototype
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
410223002
Patch from Chunyang Dai <chunyang.dai@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22586
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 24 Jul 2014 09:11:59 +0000 (09:11 +0000)]
X87: Move function prototype handling into a special handler rather than IC
port r22526.
original commit message:
Move function prototype handling into a special handler rather than IC
Adjust hydrogen handling of function.prototype to be based on map feedback.
Handle non-instance prototype loading using an IC rather than in the hydrogen
instruction. In the future, remove the special instruction and replace by multiple
hydrogen instructions.
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
410203002
Patch from Chunyang Dai <chunyang.dai@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22585
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Thu, 24 Jul 2014 08:28:02 +0000 (08:28 +0000)]
Move gc notifications from V8 to Isolate and make idle hint mandatory
Embedders should use e.g. isolate->IdleNotification(1000) instead
of v8::V8::IdleNotification()
BUG=397026
R=hpayer@chromium.org, ernstm@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
412163003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22584
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 24 Jul 2014 08:27:06 +0000 (08:27 +0000)]
Add and move DisallowHeapAllocation scope.
The move is necessary since Heap::ReserveSpace called from
DeserializePartial may allocate.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
413663003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22583
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Thu, 24 Jul 2014 08:25:22 +0000 (08:25 +0000)]
Ignore test on mips.
R=yangguo@chromium.org
TBR=yangguo@chromium.org
BUG=v8:3457
LOG=n
Review URL: https://codereview.chromium.org/
413983004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22582
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Thu, 24 Jul 2014 07:36:25 +0000 (07:36 +0000)]
Fix automatic tagging.
BUG=
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/
417973002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22580
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Thu, 24 Jul 2014 07:28:52 +0000 (07:28 +0000)]
[Auto-roll] Bump up version to 3.28.36.0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
411273004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22579
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 23 Jul 2014 20:27:32 +0000 (20:27 +0000)]
Fix ArrayLengthSetter to not throw on non-extensible receivers.
BUG=v8:3460
LOG=n
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
411983003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22576
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 23 Jul 2014 20:11:33 +0000 (20:11 +0000)]
The accessors should get the value from the holder and not from this.
These are all data properties and if they get invoked it means that
they should just return the value of the property from the holder.
BUG=v8:3461
LOG=Y
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
410923003
Patch from Erik Arvidsson <arv@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22575
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 18:58:43 +0000 (18:58 +0000)]
Whitespace change to trigger bots.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
417593004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22574
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Wed, 23 Jul 2014 17:17:48 +0000 (17:17 +0000)]
Minor clarifications and simplifications as well as additional checks.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
417553003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22573
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 16:12:02 +0000 (16:12 +0000)]
Revert "Track history of events in GCTracer."
This reverts commit 22567 for breaking win64 compile.
BUG=
TBR=ernstm@chromium.org
Review URL: https://codereview.chromium.org/
414743002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22572
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 15:56:57 +0000 (15:56 +0000)]
[Auto-roll] Bump up version to 3.28.34.0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
411003002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22571
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Wed, 23 Jul 2014 15:53:00 +0000 (15:53 +0000)]
MIPS: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers.
Port r22551 (0cc23b1)
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
415623002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22570
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Wed, 23 Jul 2014 15:39:08 +0000 (15:39 +0000)]
Revert "Minor clarifications and simplifications as well as additional checks."
This reverts commit
d32eacbdea3fc0c119da06abe95b07a83c67aa48.
TBR=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
410083005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22569
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Wed, 23 Jul 2014 15:30:34 +0000 (15:30 +0000)]
Minor clarifications and simplifications as well as additional checks.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
409743004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22568
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ernstm@chromium.org [Wed, 23 Jul 2014 15:16:53 +0000 (15:16 +0000)]
Track history of events in GCTracer.
- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- various clean-ups.
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
391413006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22567
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Wed, 23 Jul 2014 15:12:40 +0000 (15:12 +0000)]
MIPS: Only to the relevant checks in LoadFunctionPrototype.
Port r22550 (c5209a6)
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
416513002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22566
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
paul.lind@imgtec.com [Wed, 23 Jul 2014 14:54:12 +0000 (14:54 +0000)]
Fix cross-compilation in Makefile.
Fix r22531, I dropped a necessary pair of parens.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
410003003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22565
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Wed, 23 Jul 2014 14:11:30 +0000 (14:11 +0000)]
Fix Handle-related bug in RangeType constructor.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
415603002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22564
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 13:40:01 +0000 (13:40 +0000)]
Mark mjsunit/deserialize-reference as PASS, FAIL on arm64.
R=svenpanne@chromium.org
BUG=v8:3457
LOG=N
Review URL: https://codereview.chromium.org/
415583002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22563
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Wed, 23 Jul 2014 13:29:24 +0000 (13:29 +0000)]
Fix checks to bit flags of PreParserExpression
This fixes checks on the "code_" member of PreParserExpression, in order
to make methods IsThis(), IsThisProperty(), IsProperty(), IsCall() and
IsValidReferenceExpression() work correctly.
BUG=v8:3456
LOG=
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
410873004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22562
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 13:14:26 +0000 (13:14 +0000)]
Add tsan support to v8's gyp and test driver.
Tests only the default variant for now.
BUG=
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
412853002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22561
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 13:12:00 +0000 (13:12 +0000)]
Test landmines.
BUG=
R=jochen@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/
415533003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22560
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Wed, 23 Jul 2014 12:24:11 +0000 (12:24 +0000)]
Express LoadIC extra ic state with LoadIC::State
Soon we will create code stubs that need to match LoadIC state. It's easier to
express if the state is encapsulated in a single class rather than multiple bit
fields.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
415543002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22559
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Wed, 23 Jul 2014 11:39:46 +0000 (11:39 +0000)]
Revert r22544: "Rebaseline/update the intl tests with ICU 52"
The intl tests still fail locally.
BUG=v8:3454
LOG=N
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
410083004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22558
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 11:33:29 +0000 (11:33 +0000)]
Make landmines work on the first landmine.
With the original script, landmines don't work if the initial commit of the landmine script and the first landmine are in the same build. In this case, the landmine file wouldn't exist yet and no landmine would be triggered. But the updated landmine content would have still been written, omitting the landmine.
Now, the script will initialize an empty landmine file if none exists. This will make sure that a landmine is set on the branch builders after the next branch point.
This also adds some debugging output to better trace when landmines are set/deleted.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
410893002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22557
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rmcilroy@chromium.org [Wed, 23 Jul 2014 11:24:12 +0000 (11:24 +0000)]
Avoid redundent redefinition of __STDC_FORMAT_MACROS when building with clang
R=jochen@chromium.org, paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
404333003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22554
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
dcarney@chromium.org [Wed, 23 Jul 2014 11:21:19 +0000 (11:21 +0000)]
Add bailout checks to Message::Get{Start,End}Column()
Also add an initial ON_BAILOUT() check to these two 'bailout enabled'
accessors.
(The need for these was encountered via http://crbug.com/393273)
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
402173003
Patch from Sigbjorn Finne <sof@opera.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22553
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Wed, 23 Jul 2014 11:17:14 +0000 (11:17 +0000)]
Add debugging output to RangeType test.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
411873002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22552
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 23 Jul 2014 11:16:29 +0000 (11:16 +0000)]
Always use the LoadStubCompiler for Load handlers, also for keyedload handlers.
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
414443002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22551
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 23 Jul 2014 11:12:11 +0000 (11:12 +0000)]
Only to the relevant checks in LoadFunctionPrototype
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
412483003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22550
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 23 Jul 2014 10:48:16 +0000 (10:48 +0000)]
tools: more post-mortem constants
Expose more info about post-mortem constants
Useful for node.js and/or other tools.
BUG=
R=danno@chromium.org
Review URL: https://codereview.chromium.org/
404173002
Patch from Fedor Indutny <fedor.indutny@gmail.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22549
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 09:49:00 +0000 (09:49 +0000)]
Do not reverse lookup code stubs dictionary.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
407383004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22548
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 09:35:06 +0000 (09:35 +0000)]
Propagate serialization flag to inner functions.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
407383003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22547
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 09:25:36 +0000 (09:25 +0000)]
Fix version check in push-to-trunk.
The local master branch is not kept up-to-date by the script.
BUG=
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/
411593003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22546
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Wed, 23 Jul 2014 09:17:21 +0000 (09:17 +0000)]
Wait for sweeper threads when a scan on scavenge page is not swept.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
404083002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22545
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Wed, 23 Jul 2014 09:00:43 +0000 (09:00 +0000)]
Rebaseline/update the intl tests with ICU 52
Update the following 4 intl tests after ICU 52 roll.
date-format/parse-MMMdy.js
date-format/parse-mdyhms.js
number-format/parse-decimal.js
number-format/parse-percent.js
BUG=v8:3454
TEST=intl/* tests pass.
LOG=Y
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
410733003
Patch from Jungshik Shin <jshin@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22544
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 08:27:04 +0000 (08:27 +0000)]
Fix debugger-related issues in the code serializer.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
410883003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22543
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Wed, 23 Jul 2014 07:48:19 +0000 (07:48 +0000)]
X87: Introduce FLAG_vector_ics.
port r22500.
original commit message:
Introduce FLAG_vector_ics.
When FLAG_vector_ics is true, then AST nodes that use Load and KeyedLoad ICs
will allocate a type vector slot to store feedback information. Full codegen
will emit a load of the slot into a register if the flag is on.
Support is incomplete, right now the IC doesn't know how to use the feedback
slot.
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
405343002
Patch from Chunyang Dai <chunyang.dai@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22542
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 07:33:47 +0000 (07:33 +0000)]
Expose the content of Sets and WeakSets through SetMirror.
BUG=v8:3093
LOG=Y
R=aandrey@chromium.org, arv@chromium.org, yangguo@chromium.org
Review URL: https://codereview.chromium.org/
402423003
Patch from Alexandra Mikhaylova <amikhaylova@google.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22541
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 23 Jul 2014 07:16:32 +0000 (07:16 +0000)]
Correctly hook up back references to internalized strings in code deserializer.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
411483002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22540
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Wed, 23 Jul 2014 06:30:45 +0000 (06:30 +0000)]
[Auto-roll] Bump up version to 3.28.33.0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
411833004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22539
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Tue, 22 Jul 2014 20:30:08 +0000 (20:30 +0000)]
Disable mjsunit/stack-traces-overflow test for gc stress builders.
BUG=
Review URL: https://codereview.chromium.org/
413583003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22536
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
neis@chromium.org [Tue, 22 Jul 2014 17:33:22 +0000 (17:33 +0000)]
Add constructor for range types.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
409543004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22535
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Tue, 22 Jul 2014 17:14:27 +0000 (17:14 +0000)]
MIPS: Move function prototype handling into a special handler rather than IC.
Port r22526 (d4c953e)
Original commit message:
Adjust hydrogen handling of function.prototype to be based on map feedback. Handle non-instance prototype loading using an IC rather than in the hydrogen instruction. In the future, remove the special instruction and replace by multiple hydrogen instructions.
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
414463002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22534
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Tue, 22 Jul 2014 16:45:08 +0000 (16:45 +0000)]
Fix webkit test status file.
BUG=
Review URL: https://codereview.chromium.org/
406283002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22533
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Tue, 22 Jul 2014 16:30:23 +0000 (16:30 +0000)]
Set the state of a swept page after being done with sweeping.
BUG=
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
407093004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22532
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
paul.lind@imgtec.com [Tue, 22 Jul 2014 15:29:22 +0000 (15:29 +0000)]
Fix remaining CXX cross-compilation builds in Makefile.
r22509 fixed arm and mips (big-endian) cross-compilation builds.
It did not fix mipsel, mips64el, or arm64 builds, since the
toolchain prefix did not match the v8_target_arch.
For mips, the toolchain is typically named mips-linux-gnu-g++,
but it can compile for mipsel or mips64el via flags. (There can
also be mipsel-linux-gnu-g++ toolchains, and this patch will
work for mipsel build in that case).
For arm64, the toolchains seem to be named aarch64-linux-gnu-g++.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
408133002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22531
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Tue, 22 Jul 2014 15:09:58 +0000 (15:09 +0000)]
Landmine after ICU52 roll.
BUG=
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/
412513002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22530
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Tue, 22 Jul 2014 15:06:18 +0000 (15:06 +0000)]
Add landmines support.
The scripts are copied from chromium/src/build and simplified.
BUG=
R=jkummerow@chromium.org, jochen@chromium.org
Review URL: https://codereview.chromium.org/
405373005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22529
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Tue, 22 Jul 2014 14:53:29 +0000 (14:53 +0000)]
Avoid bash-ism in Makefile
BUG=none
TBR=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
412503002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22528
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
balazs.kilvady@imgtec.com [Tue, 22 Jul 2014 14:34:55 +0000 (14:34 +0000)]
MIPS: Never record safepoint with doubles.
Port r22496 (f9dde0f) and r22498 (7a16d69)
BUG=
R=dusan.milosavljevic@imgtec.com
Review URL: https://codereview.chromium.org/
404143002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22527
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 22 Jul 2014 14:27:53 +0000 (14:27 +0000)]
Move function prototype handling into a special handler rather than IC
Adjust hydrogen handling of function.prototype to be based on map feedback. Handle non-instance prototype loading using an IC rather than in the hydrogen instruction. In the future, remove the special instruction and replace by multiple hydrogen instructions.
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
408193002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22526
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Tue, 22 Jul 2014 12:56:53 +0000 (12:56 +0000)]
Skip test262 tests failing on Mac
BUG=none
TBR=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
411533002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22524
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Tue, 22 Jul 2014 12:27:59 +0000 (12:27 +0000)]
Update ICU to 5.2 (matching chromium)
BUG=v8:3452
R=svenpanne@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
411493002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22523
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Tue, 22 Jul 2014 11:35:49 +0000 (11:35 +0000)]
SlotRef::GetValue INT32 case needs to be 64bit big endian aware
On 64bit big endian systems fetch the correct 32bits from the slot
BUG=v8:3449
LOG=N
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
403003002
Patch from Andrew Low <andrew_low@ca.ibm.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22522
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 22 Jul 2014 10:35:38 +0000 (10:35 +0000)]
Add profiling to code serializer.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
408143004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22521
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 22 Jul 2014 09:44:56 +0000 (09:44 +0000)]
Update test and rebaseline
BUG=
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
408183002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22520
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Tue, 22 Jul 2014 09:19:05 +0000 (09:19 +0000)]
[Auto-roll] Bump up version to 3.28.32.0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
405353006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22519
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 22 Jul 2014 08:28:49 +0000 (08:28 +0000)]
Support setting named properties on non-JSObjects.
BUG=
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
407953002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22518
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Tue, 22 Jul 2014 07:19:46 +0000 (07:19 +0000)]
Revert "Set the state of a swept page after being done with sweeping."
This reverts commit r22514, it broke the GC stress builder.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
405373003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22517
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Mon, 21 Jul 2014 19:24:02 +0000 (19:24 +0000)]
Set the state of a swept page after being done with sweeping.
BUG=
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
408843003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22514
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
paul.lind@imgtec.com [Mon, 21 Jul 2014 19:09:56 +0000 (19:09 +0000)]
MIPS: Introduce FLAG_vector_ics.
Port r22500 (8fd2751)
Original commit message:
When FLAG_vector_ics is true, then AST nodes that use Load and KeyedLoad ICs
will allocate a type vector slot to store feedback information. Full codegen
will emit a load of the slot into a register if the flag is on.
Support is incomplete, right now the IC doesn't know how to use the feedback
slot.
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
403393008
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22513
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rmcilroy@chromium.org [Mon, 21 Jul 2014 16:20:19 +0000 (16:20 +0000)]
[Arm]: Assert that movw/movt is only emitted for Armv7 targets
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
402923002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22512
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 21 Jul 2014 16:01:50 +0000 (16:01 +0000)]
Reduce usage of StoreMode.
BUG=
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
409603002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22511
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 21 Jul 2014 15:59:05 +0000 (15:59 +0000)]
Rename CurrentMapForDeprecated to TryUpdate, and introduce Map::Update which potentially deprecates
BUG=
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
401243003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22510
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rmcilroy@chromium.org [Mon, 21 Jul 2014 15:25:50 +0000 (15:25 +0000)]
Add CXX cross-compile detection into Makefile after it was removed from gyp.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
405113002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22509
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Mon, 21 Jul 2014 15:12:19 +0000 (15:12 +0000)]
Enable object evacuation verifier. Perform verification of evacuation candidates when sweeping is done.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
407893004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22508
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 21 Jul 2014 13:51:42 +0000 (13:51 +0000)]
Use 0 instead of undefined for uninitialized stub key.
The CPU profiler looks at uninitialized code objects, which triggers an assertion.
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
404113003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22507
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 21 Jul 2014 13:18:44 +0000 (13:18 +0000)]
Small improvement to String.fromCodePoint.
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
390173004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22506
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 21 Jul 2014 13:10:14 +0000 (13:10 +0000)]
Store both major and minor key on code stubs.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
409613002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22505
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 21 Jul 2014 13:09:11 +0000 (13:09 +0000)]
Fix HSourcePosition when --hydrogen-track-positions is used.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
403373002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22504
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 21 Jul 2014 12:20:05 +0000 (12:20 +0000)]
Missing runtime test
TBR=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
407943002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22503
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Mon, 21 Jul 2014 12:14:36 +0000 (12:14 +0000)]
[Auto-roll] Bump up version to 3.28.31.0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
404103002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22502
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
machenbach@chromium.org [Mon, 21 Jul 2014 12:13:36 +0000 (12:13 +0000)]
Fix automatic version update.
This fixes two things:
1. Guarantee that versions are bumped up also when presubmit errors exists. Those errors originate from other CLs and should not stop the automatic versioning.
2. Calculate the last bleeding edge version when pushing to trunk based on remote branch svn/bleeding_edge and not on local branch master. The master branch is not kept up-to-date by the script.
BUG=
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/
404093002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22501
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Mon, 21 Jul 2014 11:19:56 +0000 (11:19 +0000)]
Introduce FLAG_vector_ics.
When FLAG_vector_ics is true, then AST nodes that use Load and KeyedLoad ICs
will allocate a type vector slot to store feedback information. Full codegen
will emit a load of the slot into a register if the flag is on.
Support is incomplete, right now the IC doesn't know how to use the feedback
slot.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
398053002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22500
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Mon, 21 Jul 2014 10:39:10 +0000 (10:39 +0000)]
Always sweep precisely.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
398013003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22499
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
Jacob.Bramley@arm.com [Mon, 21 Jul 2014 10:31:23 +0000 (10:31 +0000)]
ARM64: never record safepoint with doubles
R=bmeurer@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
400223002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22498
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 21 Jul 2014 10:20:54 +0000 (10:20 +0000)]
Remove harmony-typeof
This was an early experiment in the Harmony era that turned out to
not be compatible with the web.
BUG=None
LOG=Y
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
408463003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22497
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
Jacob.Bramley@arm.com [Mon, 21 Jul 2014 10:15:08 +0000 (10:15 +0000)]
ARM: never record safepoint with doubles
R=bmeurer@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
408473002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22496
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 21 Jul 2014 09:58:01 +0000 (09:58 +0000)]
Implement basic code generation for arrow functions
Implements code generation for arrow functions by desugaring them into
a FunctionLiteral. For the moment, a normal FUNCTION_SCOPE is used, so
"this" and "arguments" behave as in normal functions. Implementing the
correct scoping rules is to be done later on.
BUG=v8:2700
LOG=
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
382893003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22495
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 21 Jul 2014 09:42:21 +0000 (09:42 +0000)]
Fix off-by-one error in Array.concat slow mode check
BUG=chromium:395499
LOG=n
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
399753005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22494
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 21 Jul 2014 08:45:32 +0000 (08:45 +0000)]
Implement String.prototype.codePointAt and String.fromCodePoint.
Contributed by Mathias Bynens <mathiasb@opera.com>.
TBR=mathiasb@opera.com, rossberg@chromium.org
BUG=v8:2840
LOG=Y
Review URL: https://codereview.chromium.org/
406863003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22493
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 21 Jul 2014 08:07:04 +0000 (08:07 +0000)]
Expose the content of Maps and WeakMaps through MapMirror.
BUG=v8:3291
LOG=N
R=aandrey@chromium.org, yangguo@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22452
Review URL: https://codereview.chromium.org/
398513005
Patch from Alexandra Mikhaylova <amikhaylova@google.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22490
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
paul.lind@imgtec.com [Mon, 21 Jul 2014 03:09:19 +0000 (03:09 +0000)]
MIPS64: Correct register use.
TEST: mozilla/js1_5/Regress/regress-366601.
TEST: mozilla/ecma_3/ExecutionContexts/10.1.3-1
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
403993002
Patch from Yu Yin <xwafish@gmail.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22489
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
weiliang.lin@intel.com [Mon, 21 Jul 2014 02:57:42 +0000 (02:57 +0000)]
X87: Cache IC handlers on the prototype's map if possible
port r22483
original commit message:
Cache IC handlers on the prototype's map if possible
instead of on the receiver's map. Lazily overwrite cached handler if it is
identical to the handler that just missed.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
391423003
Patch from Chunyang Dai <chunyang.dai@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22488
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00