Mike Blumenkrantz [Wed, 21 Oct 2015 18:05:02 +0000 (14:05 -0400)]
append new keyboard resources for wayland focused-client to the focused list
fixes all cases where applications would fail to receive focus initially
and then be permanently broken
Mike Blumenkrantz [Wed, 21 Oct 2015 17:49:13 +0000 (13:49 -0400)]
fix typo in wayland keyboard resource unbind list management
Mike Blumenkrantz [Wed, 21 Oct 2015 16:23:44 +0000 (12:23 -0400)]
do not use x11 input windows for grab dialogs when running in wayland
Chris Michael [Wed, 21 Oct 2015 14:26:18 +0000 (10:26 -0400)]
Fix e_menu trying to swallow an object from a different canvas
_e_menu_realize was trying to swallow the menu->container_object into
the menu->bg_object, but the menu->bg_object was being created on the
compositor canvas, and the container object was being created on the
e_comp->elm_win.
With recent EFL changes, this causes an abort inside Evas.
To fix this, set the menu->evas to be the Evas from the e_comp->elm_win.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Mon, 19 Oct 2015 21:19:32 +0000 (17:19 -0400)]
update csd using deltas of previous values
when applying new csd to a window which already has csd, the previous
csd must be removed in order to apply any new csd offsets in order to
avoid unwanted moving/resizing
Seunghun Lee [Mon, 19 Oct 2015 15:43:07 +0000 (11:43 -0400)]
e-comp-wl-input: don't leak the initial keymap.
Summary: remove xkb_map_ref() for keymap in _e_comp_wl_input_keymap_update().
Test Plan: N/A
Reviewers: devilhorns, zmike
Subscribers: ManMower, cedric
Differential Revision: https://phab.enlightenment.org/D3173
Thierry [Fri, 16 Oct 2015 20:29:19 +0000 (13:29 -0700)]
mouse_config: fix accel threshold and numerator limits.
man xset => If the `threshold' parameter is provided and 0, the
`acceleration' parameter will be used in the exponent of a more
natural and continuous formula, giving precise control for slow motion
but big reach for fast motion, and a progressive transition for motions
in between. Recommended `acceleration' value in this case is 3/2 to 3,
but not limited to that range.
Mike Blumenkrantz [Fri, 16 Oct 2015 19:45:23 +0000 (15:45 -0400)]
queue pending buffers for wayland shm clients
due to how deferred rendering works, it's possible for a client to
send a second buffer before enlightenment has rendered the first one.
in this situation, it seems that the best solution is to queue successive
buffers (frames) and pop the queue after each render
ref T2784
Mike Blumenkrantz [Thu, 15 Oct 2015 19:33:28 +0000 (15:33 -0400)]
force a software render in all cases when finalizing x11 client iconify
since ICCCM requires that clients be unmapped while iconified, it's necessary
for the compositor to perform one last render prior to the unmap in order to
ensure that mirror objects will still appear as expected. this render must use
the pixmap buffer data in order to avoid timing issues due to async/deferred
rendering, and it is only necessary for the case of clients rendering with a
native surface
fix T2788
Mike Blumenkrantz [Thu, 15 Oct 2015 19:32:38 +0000 (15:32 -0400)]
clear x11 client pixmap when returning from iconic
ensure pixmap remains usable during the entire hide process
Mike Blumenkrantz [Thu, 15 Oct 2015 17:10:58 +0000 (13:10 -0400)]
check systray dbus name existence before attempting to recover session
in the case that a system error occurs the dbus method for returning the
session name can fail, leading to a null return
CID 1327399
Mike Blumenkrantz [Thu, 15 Oct 2015 16:58:32 +0000 (12:58 -0400)]
use dbus unique name for tracking systray sessions
the env var DBUS_SESSION_BUS_ADDRESS may not be set for all platforms
where enlightenment+dbus are usable, so it's necessary to get the dbus
id to ensure that this value exists and is properly tracked
Mike Blumenkrantz [Thu, 15 Oct 2015 16:40:00 +0000 (12:40 -0400)]
reject deleted clients from x11 sync alarm event callback
E_Client->comp_data is null after a client has been deleted, so
attempting to handle events which require the dereferencing of this
pointer after a client has been deleted will result in a crash
these events should be rejected after delete regardless, since at this
time the compositor has stopped handling events for the client
ref
f42c6aa1871cca6c6ffb39b65e2bfa3815bff35c
Carsten Haitzler (Rasterman) [Thu, 15 Oct 2015 10:26:00 +0000 (19:26 +0900)]
e - comps sync - ec client was null - i think, so protect against crash
i got a crash here and the bt was broken and i couldnt check if
_e_comp_x_client_data_get() returned null, but it's the only thing
that would make sense, so protect against this to avoid a crash. as
this was a one-off, i can't find out more,
@fix
Marcel Hollerbach [Wed, 14 Oct 2015 10:18:41 +0000 (12:18 +0200)]
systray: search for the best available resolution of a icon
For example in telegram the first icon which was transmitted was in a
pretty bad resolution, the new code searches the best res.
Mike Blumenkrantz [Wed, 14 Oct 2015 20:30:41 +0000 (16:30 -0400)]
cache systray items for each dbus session
the current spec does not directly require any behavior from clients
when a systray host, leading to an issue where clients do not re-register
their items when a new host appears
when using an in-process systray watcher, as the current implementation does,
the best choice for maintaining consistency for systray items across restarts
is to cache them according to the current dbus session. the process of setting
up the item will validate it on subsequent restarts, and changes to the session
will clear the cache
fix T2786
Amitesh Singh [Wed, 14 Oct 2015 18:02:07 +0000 (14:02 -0400)]
e_flowlayout: typecast return value to int
Summary:
return value is small enough, so there is no risk in casting from unsigned int to signed int.
CID: 1267211
Reviewers: devilhorns, raster, cedric, zmike
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3179
Mike Blumenkrantz [Wed, 14 Oct 2015 16:51:45 +0000 (12:51 -0400)]
trap shaped x11 clients and prevent compositor blocking with high rect count
in the case where a shaped window with many rects exists, there is a high
probability of the damage rect count being huge, leading to massive blocking for
each frame as the compositor attempts to fetch all of these rects from the xserver.
instead, the compositor can shortcut this by forcing a full-window damage any time
the rect count is sufficiently high, trading a blocking socket operation for some
amount of (potential) overdraw.
testing in affected scenarios has shown huge improvements: where previously the entire
compositor would lock up, things work as expected now
see https://bugzilla.mozilla.org/show_bug.cgi?id=1214746 for a sample case
Mike Blumenkrantz [Wed, 14 Oct 2015 16:50:17 +0000 (12:50 -0400)]
do not return when x11 damage event returns no rects
ensure first_damage flag is set in all cases
Amitesh Singh [Wed, 14 Oct 2015 16:21:00 +0000 (21:51 +0530)]
pulseaudio: pass big data as pass by reference
CID: 1308394
Chris Michael [Wed, 14 Oct 2015 14:59:31 +0000 (10:59 -0400)]
enlightenment: Make sure we have a zone before calling
_bgpreview_viewport_update
@fix CID1324753
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:38:14 +0000 (10:38 -0400)]
enlightenment: Use 'fabs' to compute absolute value of floating point
types
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:30:33 +0000 (10:30 -0400)]
enlightenment: #if 0 out an unused variable
NB: The function which actually uses this variable is also #if 0'd out
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:28:38 +0000 (10:28 -0400)]
enlightenment: Use 'fabs' to get absolute value of floating point types
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:22:19 +0000 (10:22 -0400)]
enlightenment: Fix E_CONFIG_LIMIT to use the proper min & max values
e_config->backlight.idle_dim is actually an unsigned char in the
structure, so use a 0 & 1 for min & max
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:19:43 +0000 (10:19 -0400)]
enlightenment: Add missing field initializers for Eina_Rectangle
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:18:04 +0000 (10:18 -0400)]
enlightenment: Add missing field initializers for Evas_Point
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:17:22 +0000 (10:17 -0400)]
enlightenment: Add missing EINA_UNUSED for unused function paramaters
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:16:25 +0000 (10:16 -0400)]
enlightenment: Add missing EINA_UNUSED for unused function parameters
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 14 Oct 2015 14:14:16 +0000 (10:14 -0400)]
enlightenment: Add missing EINA_UNUSED for unused function paramaters
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Wed, 14 Oct 2015 02:38:50 +0000 (22:38 -0400)]
subtract x11 client damage region even when forcing full override damage
fix T2785
Mike Blumenkrantz [Tue, 13 Oct 2015 21:07:30 +0000 (17:07 -0400)]
force full damage for first frame of x11 override clients
it seems that damages for popup windows in some applications,
namely blink-based browsers, are reported incorrectly, resulting
in sometimes having a blank window
Marcel Hollerbach [Tue, 13 Oct 2015 19:58:21 +0000 (21:58 +0200)]
Fix make distcheck
Marcel Hollerbach [Tue, 13 Oct 2015 18:59:45 +0000 (20:59 +0200)]
mixer: start app from bin directory
before the app was installed into the modules directory, now its
installed to the bin directory
Marcel Hollerbach [Tue, 13 Oct 2015 18:55:50 +0000 (20:55 +0200)]
mixer: install icon and .desktop file
Marcel Hollerbach [Tue, 13 Oct 2015 18:55:15 +0000 (20:55 +0200)]
mixer: install app to bin directory
Mike Blumenkrantz [Tue, 13 Oct 2015 17:31:47 +0000 (13:31 -0400)]
use correct param ordering for setting wayland client frame geometry
function uses l,r,t,b and not x,y,xx,yy
fix T2624
Mike Blumenkrantz [Tue, 13 Oct 2015 17:25:15 +0000 (13:25 -0400)]
remove duplicate surface size update for wayland clients during commit
this has already happened in e_comp_wl_surface_attach()
Tomáš Čech [Mon, 12 Oct 2015 15:56:45 +0000 (11:56 -0400)]
don't forget wl_desktop_shell's header in tarball
Summary: Merge branch 'master' of git://git.enlightenment.org/core/enlightenment
Reviewers: zmike
Subscribers: cedric
Maniphest Tasks: T2776
Differential Revision: https://phab.enlightenment.org/D3170
Carsten Haitzler (Rasterman) [Sat, 10 Oct 2015 02:07:24 +0000 (11:07 +0900)]
e mixer - be more robust if pulse exits/crashes and def sink is null
ensure there are protections everywhere for when default sink is null
- mixer did crash when pulse crashed and a popup was to be shown...
Mike Blumenkrantz [Fri, 9 Oct 2015 19:23:15 +0000 (15:23 -0400)]
explicitly disable screensaver for wayland urgency wakeups
Mike Blumenkrantz [Fri, 9 Oct 2015 19:21:41 +0000 (15:21 -0400)]
make wake-on-urgent apply for all cases of window urgency
in the case that an urgent window is set as urgent again, wakeup should
still occur
Mike Blumenkrantz [Fri, 9 Oct 2015 18:20:25 +0000 (14:20 -0400)]
apply _GTK_FRAME_EXTENTS for xwayland clients
not entirely sure this is worthwhile but may as well
Tom Hacohen [Fri, 9 Oct 2015 08:26:45 +0000 (09:26 +0100)]
Intl: fix potential stack buffer overflow.
CID 1298051
@fix
Tom Hacohen [Fri, 9 Oct 2015 08:19:51 +0000 (09:19 +0100)]
Client: fix potential out of bounds read.
This is an unsigned int underflow that could lead to an out
of bounds read.
CID 1291837
@fix
Chris Michael [Thu, 8 Oct 2015 19:28:55 +0000 (15:28 -0400)]
enlightenment: Update wayland readme
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Thu, 8 Oct 2015 16:16:37 +0000 (12:16 -0400)]
don't crash desktop gadget systrays when adjusting image sizing
desktop gadgets (gadman) do not have a shelf, so derefing that pointer
without checking will guarantee a crash
Carsten Haitzler (Rasterman) [Wed, 7 Oct 2015 23:27:38 +0000 (08:27 +0900)]
e comp data - actually ... NO visibility effect by default is right
so a bit of a config wipe had my comp config reset (some dev
shenanigans) and i got to see what current e "out of box" config is -
and it was horrid for menus. visibilitiy effect was broken. vertial.
default was none - always. forever. like empty. so go back to that. in
fact why do this visibility effect? that was the point of having a
different shadow in the theme - each has its own look + effect. this
makes things far more complex...
Mike Blumenkrantz [Wed, 7 Oct 2015 19:43:29 +0000 (15:43 -0400)]
when removing VERTICAL maximize state, also remove LEFT and RIGHT states
LEFT and RIGHT are supersets of VERTICAL which serve no purpose on their own,
so remove them when removing VERTICAL
fix T2770
Carsten Haitzler (Rasterman) [Wed, 7 Oct 2015 10:54:21 +0000 (19:54 +0900)]
e comp - default config was rather broken - fix
default config didnt select menu style shadow - was selecting
vertical/still which meant animation was rather horrible. fix.
Mike Blumenkrantz [Mon, 5 Oct 2015 21:28:26 +0000 (17:28 -0400)]
only use fast-path pixmap size updating after a resize for x11 clients
updating these values after other operations will result in the pixmap size
being set inaccurately, leading to rendering inconsistencies
Mike Blumenkrantz [Mon, 5 Oct 2015 20:36:39 +0000 (16:36 -0400)]
update wayland readme
Mike Blumenkrantz [Mon, 5 Oct 2015 20:01:10 +0000 (16:01 -0400)]
repopulate app list dialogs when efreet deskop cache updates
should improve usage when installing/uninstalling apps
Mike Blumenkrantz [Mon, 5 Oct 2015 19:56:28 +0000 (15:56 -0400)]
attempt to load default e_bindings if initial load fails
Mike Blumenkrantz [Mon, 5 Oct 2015 19:56:04 +0000 (15:56 -0400)]
do not set frame geometry on frame-possessing wayland clients
Mike Blumenkrantz [Mon, 5 Oct 2015 19:55:44 +0000 (15:55 -0400)]
throw an ACK when trying to set comp frame geometry if frame exists
Mike Blumenkrantz [Mon, 5 Oct 2015 17:37:45 +0000 (13:37 -0400)]
clear menu cache when saving a menu file
force regeneration of menus after editing them
ref T2271
Mike Blumenkrantz [Mon, 5 Oct 2015 17:33:13 +0000 (13:33 -0400)]
make icon selection dialog resizable in .desktop editor
ref T2271
Mike Blumenkrantz [Mon, 5 Oct 2015 17:09:38 +0000 (13:09 -0400)]
move configure init after intl init has completed
gettext calls will not return the correct language string until after
setup has completed, leading to untranslatable strings
fix T2760
Seunghun Lee [Mon, 5 Oct 2015 16:47:29 +0000 (12:47 -0400)]
clear the tiler for input region after setting to comp object.
Summary:
there is no need to set repeatedly input region even if it's already applied.
and this patch remove the code to clear tiler from client's unmapped case.
this fixes that tiler for input region is removed before applying it to comp object in case client is unmmaped yet.
Reviewers: devilhorns, zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3076
Peter Kjellerstedt [Sun, 4 Oct 2015 16:56:46 +0000 (12:56 -0400)]
Add support for the ISO 8601 date format to the clock module
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3129
Chidambar Zinnoury [Sun, 4 Oct 2015 16:44:38 +0000 (18:44 +0200)]
e fm: Use correct string length when copying path.
Sometimes, trying to go to the parent directory wouldn’t work and end up showing some garbage. Unfortunately, the code ended up not NULL-ending the path, which made searching for the path separator buggy.
Peter Kjellerstedt [Sun, 4 Oct 2015 15:53:31 +0000 (11:53 -0400)]
Add "(drag only)" to title for drag only edge bindings
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3128
Chidambar Zinnoury [Sun, 4 Oct 2015 14:35:43 +0000 (16:35 +0200)]
e menus: Fix invalid comparisons.
Fixes CID 1267215 and 1267216.
Mike Blumenkrantz [Sun, 4 Oct 2015 12:41:07 +0000 (08:41 -0400)]
fix systray to work with spec-breaking apps, eg. steam
according to the StatusNotifierItem specification, applications
register "service org.freedesktop.StatusNotifierItem-PID-ID" on the
session bus, and then "must register the unique instance name
to the StatusNotifierWatcher".
some applications, such as steam, instead register the path that they
will run on (/org/ayatana/NotificationItem/steam) and then expect the
watcher to register the method call's send id bus: this is totally bogus.
to catch this, when registering the new item the enlightenment watcher must
first determine if the item is spec-conforming. if yes, proceed as normal.
if no, pretend the application knows what it's doing and try to make things
work as expected anyway
for more details, read the full spec here
http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem
fix T2763
Mike Blumenkrantz [Fri, 2 Oct 2015 17:49:57 +0000 (13:49 -0400)]
move client post-update adding into render function
in some cases, it's possible for a client which expects to render on
the next frame to actually render on the frame after. in these cases,
the compositor must not clear the pixmap image until after the render
has occurred in order to avoid inaccuracies. for this reason, the best
place to flag a client for post-render work is at the time of the client's
render
ref T2762
ref D3120
Mike Blumenkrantz [Fri, 2 Oct 2015 17:44:37 +0000 (13:44 -0400)]
unify comp render returns for argb and non-argb clients
Mike Blumenkrantz [Fri, 2 Oct 2015 17:42:33 +0000 (13:42 -0400)]
fix comp render return value for failed draws of non-argb clients
Mike Blumenkrantz [Fri, 2 Oct 2015 17:41:17 +0000 (13:41 -0400)]
fix return value of comp render for wayland clients
Mike Blumenkrantz [Fri, 2 Oct 2015 17:40:55 +0000 (13:40 -0400)]
add RENDER_DEBUG for forced renders when setting dirty flag
Boram Park [Fri, 2 Oct 2015 16:38:30 +0000 (12:38 -0400)]
should remove a frame resource from pending.frames list also
Summary: Signed-off-by: Boram Park <boram1288.park@samsung.com>
Reviewers: stefan_schmidt, gwanglim, raster, zmike, devilhorns
Reviewed By: zmike, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3079
Amitesh Singh [Thu, 1 Oct 2015 20:20:23 +0000 (16:20 -0400)]
md5: fix wrong sizeof argument (SIZEOF_MISMATCH)
Summary: fixes CID: 222382
Reviewers: raster, zmike, cedric, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3125
Mike Blumenkrantz [Thu, 1 Oct 2015 17:52:35 +0000 (13:52 -0400)]
unset release mode
Mike Blumenkrantz [Thu, 1 Oct 2015 17:43:25 +0000 (13:43 -0400)]
20.0-alpha NEWS updates
Mike Blumenkrantz [Thu, 1 Oct 2015 17:42:45 +0000 (13:42 -0400)]
20.0-alpha release
Mike Blumenkrantz [Thu, 1 Oct 2015 17:13:08 +0000 (13:13 -0400)]
always apply all randr changes after a screen event
fixes case where plugging an external monitor would cause the screen
to expand onto that display without the display being effectively usable
until after a restart
Boram Park [Thu, 1 Oct 2015 12:43:19 +0000 (08:43 -0400)]
wl_desktop_shell: return void
Summary:
_e_input_panel_cb_surface_get() returns void.
Signed-off-by: Boram Park <boram1288.park@samsung.com>
Reviewers: zmike, stefan_schmidt, gwanglim, raster, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3119
Mike Blumenkrantz [Wed, 30 Sep 2015 20:31:20 +0000 (16:31 -0400)]
remove remote colorclass editor usage
match current elm function signatures
Mike Blumenkrantz [Wed, 30 Sep 2015 19:31:34 +0000 (15:31 -0400)]
merge E19 branch NEWS items
Mike Blumenkrantz [Tue, 29 Sep 2015 23:01:04 +0000 (19:01 -0400)]
update wayland readme
Mike Blumenkrantz [Tue, 29 Sep 2015 22:53:15 +0000 (18:53 -0400)]
redo wayland client buffer referencing
the previous methodology was effectively:
attach -> ref(new buffer) x2 / unref(old buffer) x2
...
...
attach -> ref(new buffer) x2 / unref(old buffer) x2
this resulted in buffer management failures and crashing. now the
buffer gets 1x ref before render and 1x unref after render, ensuring
that the lifetime is accurate (assuming evas doesn't lie to us)
now we still have random crashing during resize, but not as much as
before
Mike Blumenkrantz [Tue, 29 Sep 2015 22:50:03 +0000 (18:50 -0400)]
redo CSD for wayland clients to use comp object frame geometry
this fixes issues with client placement and is a more native solution
than the previous hacks
Mike Blumenkrantz [Tue, 29 Sep 2015 20:35:30 +0000 (16:35 -0400)]
never mark wl client pixmaps as dirty or refresh them
this has no meaning for a wl pixmap in the current implementation
Mike Blumenkrantz [Tue, 29 Sep 2015 17:03:35 +0000 (13:03 -0400)]
free x11 damage region rects
Mike Blumenkrantz [Tue, 29 Sep 2015 16:53:59 +0000 (12:53 -0400)]
do not roundtrip for x11 client message DBG if it will not be visible
also free fetched atom name
Mike Blumenkrantz [Tue, 29 Sep 2015 16:58:13 +0000 (12:58 -0400)]
unset E_Client->internal_elm_win before deleting the client in e_win
==24509== Invalid write of size 8
==24509== at 0x502D00: _e_elm_win_trap_del (e_win.c:39)
==24509== by 0x509BFC2: _elm_win_evas_object_smart_del (elm_win.c:1886)
==24509== by 0x91F4643: evas_obj_smart_del (in /usr/lib/libevas.so.1.15.99)
==24509== by 0x91F5B5C: evas_object_smart_del (evas_object_smart.c:1021)
==24509== by 0x91E9107: _evas_object_eo_base_destructor (evas_object_main.c:739)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x5086715: _elm_widget_eo_base_destructor (elm_widget.c:5744)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x4D5B1A: _e_obj_dialog_free (e_obj_dialog.c:125)
==24509== by 0x4D61FB: e_object_free (e_object.c:152)
==24509== by 0x4D61FB: e_object_unref (e_object.c:152)
==24509== by 0x4EDC54: _e_sys_logout_after (e_sys.c:750)
==24509== by 0x4ED7AC: _e_sys_action_do (e_sys.c:925)
==24509== by 0x4EE348: e_sys_action_raw_do (e_sys.c:311)
==24509== by 0x4EE43F: _e_sys_comp_done_cb (e_sys.c:66)
==24509== by 0x6097348: _edje_emit_cb (edje_program.c:1476)
==24509== by 0x6097348: _edje_emit_handle (edje_program.c:1405)
==24509== by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509== by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509== by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509== by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509== by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509== by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509== by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509== by 0x4383F4: main (e_main.c:1047)
==24509== Address 0x14fb1a28 is 1,176 bytes inside a block of size 1,352 free'd
==24509== at 0x4C2A65B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24509== by 0x4D61FB: e_object_free (e_object.c:152)
==24509== by 0x4D61FB: e_object_unref (e_object.c:152)
==24509== by 0x502CED: _e_elm_win_trap_del (e_win.c:37)
==24509== by 0x509BFC2: _elm_win_evas_object_smart_del (elm_win.c:1886)
==24509== by 0x91F4643: evas_obj_smart_del (in /usr/lib/libevas.so.1.15.99)
==24509== by 0x91F5B5C: evas_object_smart_del (evas_object_smart.c:1021)
==24509== by 0x91E9107: _evas_object_eo_base_destructor (evas_object_main.c:739)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x5086715: _elm_widget_eo_base_destructor (elm_widget.c:5744)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x4D5B1A: _e_obj_dialog_free (e_obj_dialog.c:125)
==24509== by 0x4D61FB: e_object_free (e_object.c:152)
==24509== by 0x4D61FB: e_object_unref (e_object.c:152)
==24509== by 0x4EDC54: _e_sys_logout_after (e_sys.c:750)
==24509== by 0x4ED7AC: _e_sys_action_do (e_sys.c:925)
==24509== by 0x4EE348: e_sys_action_raw_do (e_sys.c:311)
==24509== by 0x4EE43F: _e_sys_comp_done_cb (e_sys.c:66)
==24509== by 0x6097348: _edje_emit_cb (edje_program.c:1476)
==24509== by 0x6097348: _edje_emit_handle (edje_program.c:1405)
==24509== by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509== by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509== by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509== by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509== by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509== by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509== by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509== by 0x4383F4: main (e_main.c:1047)
Mike Blumenkrantz [Tue, 29 Sep 2015 16:53:59 +0000 (12:53 -0400)]
do not roundtrip for x11 client message DBG if it will not be visible
also free fetched atom name
Mike Blumenkrantz [Tue, 29 Sep 2015 16:51:36 +0000 (12:51 -0400)]
remove object event callback on notification popdown
==24509== Invalid write of size 8
==24509== at 0x2C5ED500: _notification_popup_del_cb (e_mod_popup.c:404)
==24509== by 0x91AAE93: _eo_evas_object_cb (evas_callbacks.c:92)
==24509== by 0xE54DDEA: _eo_base_event_callback_call (eo_base_class.c:715)
==24509== by 0xE54B67A: eo_event_callback_call (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x91AB323: evas_object_event_callback_call (evas_callbacks.c:264)
==24509== by 0x91E8DE3: _evas_object_eo_base_destructor (evas_object_main.c:691)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x60A3019: _edje_object_eo_base_destructor (edje_smart.c:43)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x6091146: edje_match_callback_exec_check_finals (edje_match.c:556)
==24509== by 0x6091146: edje_match_callback_exec (edje_match.c:711)
==24509== by 0x60974AE: _edje_emit_cb (edje_program.c:1453)
==24509== by 0x60974AE: _edje_emit_handle (edje_program.c:1405)
==24509== by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509== by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509== by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509== by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509== by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509== by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509== by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509== by 0x4383F4: main (e_main.c:1047)
==24509== Address 0x23b3dcb0 is 16 bytes inside a block of size 80 free'd
==24509== at 0x4C2A65B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24509== by 0x2C5ED606: _notification_popdown (e_mod_popup.c:747)
==24509== by 0x2C5ED952: _notification_reshuffle_cb (e_mod_popup.c:700)
==24509== by 0x91AAE93: _eo_evas_object_cb (evas_callbacks.c:92)
==24509== by 0xE54DDEA: _eo_base_event_callback_call (eo_base_class.c:715)
==24509== by 0xE54B67A: eo_event_callback_call (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x91AB323: evas_object_event_callback_call (evas_callbacks.c:264)
==24509== by 0x91E8DE3: _evas_object_eo_base_destructor (evas_object_main.c:691)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x60A3019: _edje_object_eo_base_destructor (edje_smart.c:43)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x504CEF: _e_zoomap_smart_del (e_zoomap.c:266)
==24509== by 0x91F5ABC: evas_object_smart_del (evas_object_smart.c:1019)
==24509== by 0x91E9107: _evas_object_eo_base_destructor (evas_object_main.c:739)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x458C7A: _e_comp_object_util_del (e_comp_object.c:2402)
==24509== by 0x91AAE93: _eo_evas_object_cb (evas_callbacks.c:92)
==24509== by 0xE54DDEA: _eo_base_event_callback_call (eo_base_class.c:715)
==24509== by 0xE54B67A: eo_event_callback_call (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x91AB323: evas_object_event_callback_call (evas_callbacks.c:264)
==24509== by 0x91E8DE3: _evas_object_eo_base_destructor (evas_object_main.c:691)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0x60A3019: _edje_object_eo_base_destructor (edje_smart.c:43)
==24509== by 0xE54A8A3: eo_destructor (in /usr/lib/libeo.so.1.15.99)
==24509== by 0xE5443EC: _eo_del_internal (eo_private.h:221)
==24509== by 0xE5443EC: _eo_unref (eo_private.h:295)
==24509== by 0xE5443EC: _eo_do_end (eo.c:546)
==24509== by 0x6091146: edje_match_callback_exec_check_finals (edje_match.c:556)
==24509== by 0x6091146: edje_match_callback_exec (edje_match.c:711)
==24509== by 0x60974AE: _edje_emit_cb (edje_program.c:1453)
==24509== by 0x60974AE: _edje_emit_handle (edje_program.c:1405)
==24509== by 0x60924EE: _edje_message_queue_process (edje_message_queue.c:787)
==24509== by 0x60926A6: _edje_job (edje_message_queue.c:154)
==24509== by 0xCC5087A: _ecore_job_event_handler (ecore_job.c:121)
==24509== by 0xCC4B204: _ecore_call_handler_cb (ecore_private.h:390)
==24509== by 0xCC4B204: _ecore_event_call (ecore_events.c:565)
==24509== by 0xCC52AE7: _ecore_main_loop_iterate_internal (ecore_main.c:1927)
==24509== by 0xCC52CD6: ecore_main_loop_begin (ecore_main.c:983)
==24509== by 0x4383F4: main (e_main.c:1047)
Mike Blumenkrantz [Tue, 29 Sep 2015 16:29:41 +0000 (12:29 -0400)]
reject client resize attempts for clients with dirty pixmaps
these clients will resize/render correctly only after the next
render loop, so defer until then to avoid #RenderFail
fix T2754
Mike Blumenkrantz [Mon, 28 Sep 2015 19:51:51 +0000 (15:51 -0400)]
s/EAPI/E_API/ ...again
Mike Blumenkrantz [Mon, 28 Sep 2015 19:38:13 +0000 (15:38 -0400)]
use client window coords for resize-moving without a frame_object
improves placement of csd windows
ref T2750
Mike Blumenkrantz [Mon, 28 Sep 2015 19:36:58 +0000 (15:36 -0400)]
do not set client window coordinates during a move until after resizing check
fixes case where values would be erroneously updated when they should instead
have been rejected
ref T2750
Mike Blumenkrantz [Mon, 28 Sep 2015 18:42:21 +0000 (14:42 -0400)]
use more accurate math to determine whether to apply a client maximize change
Mike Blumenkrantz [Mon, 28 Sep 2015 18:41:44 +0000 (14:41 -0400)]
unset the requested maximize state when receiving a client unmaximize request
not sure why it was always removing VERTICAL here but that's a bug
Mike Blumenkrantz [Mon, 28 Sep 2015 18:39:42 +0000 (14:39 -0400)]
allow client resizes on axes currently unrestricted by maximize state
if this isn't explicitly blocked by config options then allowing resizes
on the unmaximized axes is necessary in order to avoid accidentally
queuing a full unmaximize
Mike Blumenkrantz [Mon, 28 Sep 2015 18:37:57 +0000 (14:37 -0400)]
unset E_Client->changes.need_unmaximize after calling unmaximize
...just in case
Mike Blumenkrantz [Mon, 28 Sep 2015 18:36:59 +0000 (14:36 -0400)]
remove client maximize states during unmaximize only if they are active
do not accidentally remove untested states using bad math operations
Mike Blumenkrantz [Mon, 28 Sep 2015 18:02:02 +0000 (14:02 -0400)]
force adjustment of client geometry when changing csd frame size
fix T2750
Mike Blumenkrantz [Mon, 28 Sep 2015 18:01:28 +0000 (14:01 -0400)]
_GTK_FRAME_EXTENTS changes using a property, not a client message
Mike Blumenkrantz [Mon, 28 Sep 2015 18:01:02 +0000 (14:01 -0400)]
reject identical calls to e_comp_object_frame_geometry_set()