Lukasz Stanislawski [Mon, 21 Apr 2014 03:46:11 +0000 (12:46 +0900)]
atspi: refactor atspi_object class into mixins.
Summary:
Allow to create ATSPI aware objects only by attaching Atspi interface to
Eo object. Apply protected rule to all methods, properties which should
not be available to app developer. Remove public atspi header from Elementary.h.
Make Elm_Widget inherit from Atspi interfaces, Elm_Win inherits additional
Atspi_Window interface.
Unified file names - all atspi related objects/interfaces can be found under
elm_atspi_*
and elm_interface_atspi_*.
Test Plan:
build&install, out-off tree example compilation with gcc and g++,
Orca screen reader tests on Ubuntu 12.04.
Reviewers: raster, seoz, tasn, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D718
Carsten Haitzler (Rasterman) [Mon, 21 Apr 2014 03:41:59 +0000 (12:41 +0900)]
fix cursor setting to only set if currently visible
this should fix D715
Carsten Haitzler (Rasterman) [Mon, 21 Apr 2014 03:31:49 +0000 (12:31 +0900)]
entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.
solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.
signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.
Reviewers: jaehwan, woohyun, seoz, Hermet, raster
CC: govi, rajeshps, thiepha
Differential Revision: https://phab.enlightenment.org/D674
Jaeun Choi [Fri, 18 Apr 2014 04:39:08 +0000 (13:39 +0900)]
slider: apply key binding
Summary: This patch applies key binding to elm_slider.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D761
Jaeun Choi [Fri, 18 Apr 2014 03:07:07 +0000 (12:07 +0900)]
multibuttonentry: add key binding in config files
Summary:
This patch adds multibuttonentry key binding info into config files.
Multibuttonentry has some issues in event handling so not suitable for key binding yet.
So, added key binding info first to upgrade config version.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D767
ChunEon Park [Fri, 18 Apr 2014 03:00:32 +0000 (12:00 +0900)]
slider - don't send signals multiple times if the multiple key is pressed/up.
since slider popup has the interval for hide animation(may have, may have not)
just checking visible is not enough but this flag is correct.
ChunEon Park [Fri, 18 Apr 2014 02:55:54 +0000 (11:55 +0900)]
slider: fix comment for readability.
Jaeun Choi [Fri, 18 Apr 2014 02:53:27 +0000 (11:53 +0900)]
slider: removed unnecessary key value check in case of key up event
Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D760
Jaeun Choi [Fri, 18 Apr 2014 02:45:13 +0000 (11:45 +0900)]
slider: code refactoring in widget_event func
Summary:
This patch improves maintainability and readability through code refactoring.
- complete branch statement instead of goto statement
- removed unnecessary codes
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D758
Jaeun Choi [Fri, 18 Apr 2014 02:33:43 +0000 (11:33 +0900)]
multibuttonentry: change key up callback into key down callback for consistency
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.
Test Plan: None
Reviewers: raster, Hermet, seoz, jpeg
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D755
Daniel Juyung Seo [Thu, 17 Apr 2014 19:17:44 +0000 (04:17 +0900)]
spinner: Fixed broken focus movement by direction key.
This was broken by
c9755bd3c828bcd2453a50542331b201089a7160.
Lukasz Stanislawski [Thu, 17 Apr 2014 17:46:15 +0000 (19:46 +0200)]
config: fix crash when finding key bidings
Summary: Crash occured when config was reloaded and hash data become invalid.
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D750
Signed-off-by: Cedric Bail <cedric.bail@free.fr>
Daniel Juyung Seo [Sun, 13 Apr 2014 03:43:41 +0000 (12:43 +0900)]
button: Renamed internal variable of button smart data to match with
actual API.
Jaeun Choi [Thu, 17 Apr 2014 07:03:48 +0000 (16:03 +0900)]
spinner: apply key binding
Summary: This patch applies key binding to elm_spinner.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D752
ChunEon Park [Thu, 17 Apr 2014 06:51:37 +0000 (15:51 +0900)]
ctxpopup: dimiss ctxpopup if escape key is pressed.
rahter than just hide of the ctxpopup, dimiss will be much better for usability.
because press "Escape" is closed to "Cancel" meaning conceptually.
Jaeun Choi [Thu, 17 Apr 2014 06:41:50 +0000 (15:41 +0900)]
ctxpopup: apply key binding
Summary: This patch applies key binding to elc_ctxpopup.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D754
Jaeun Choi [Thu, 17 Apr 2014 06:23:00 +0000 (15:23 +0900)]
ctxpopup: sd->box null check and event_flag set for previous and next focus move.
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix
Test Plan: None
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D753
Jaeun Choi [Thu, 17 Apr 2014 02:51:47 +0000 (11:51 +0900)]
spinner: fixed odd behavior of the spinner
Summary:
when multiple key down is coming while increase/decrease the spinner values,
the speed acceleration will be reset by the new key down.
Instead, it stops the increase/decrease the spinner values behavior.
@fix
Test Plan: None
Reviewers: Hermet, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D749
Ryuan Choi [Wed, 16 Apr 2014 15:32:18 +0000 (00:32 +0900)]
elm_web2: Implement select popup interfaces
Ryuan Choi [Tue, 15 Apr 2014 16:55:22 +0000 (01:55 +0900)]
elm_web2: Implement several interfaces
- elm_web_bg_color_{get|set}
- elm_web_zoom_{get|set}
Jaeun Choi [Wed, 16 Apr 2014 11:58:37 +0000 (20:58 +0900)]
spinner: unified two functions with different name and same functionality
Summary:
This patch unifies two functions with different name and same functionality:
_val_inc_stop and _val_dec_stop into _spin_stop.
Test Plan: None
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D748
Jaeun Choi [Wed, 16 Apr 2014 08:19:33 +0000 (17:19 +0900)]
flipselector: apply key binding
Summary: This patch applies key binding to elm_flipselector.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D745
Jaeun Choi [Wed, 16 Apr 2014 08:19:23 +0000 (17:19 +0900)]
gengrid: apply key binidng
Summary: This patch applies key binding to elm_gengrid.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D744
Jaeun Choi [Wed, 16 Apr 2014 08:18:22 +0000 (17:18 +0900)]
genlist: apply key binding
Summary: This patch applies key binding to elm_genlist.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D743
Stefan Schmidt [Wed, 16 Apr 2014 08:01:34 +0000 (10:01 +0200)]
theme: Add new image files to EXTRA_DIST to fix distcheck
This was broken in
995c0c0257605d857c907aab98fb8f942e4be411
ChunEon Park [Wed, 16 Apr 2014 02:04:25 +0000 (11:04 +0900)]
flipselector - don't say warning.
set EINA_UNUSED for unused argument.
Jaeun Choi [Wed, 16 Apr 2014 02:03:14 +0000 (11:03 +0900)]
web: apply key binding
Summary: This patch applies key binding to elm_web.
Test Plan: None
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D740
ChunEon Park [Wed, 16 Apr 2014 01:59:43 +0000 (10:59 +0900)]
widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.
conceptually, disabled object should not be interacted to user input(key, mouse)
Jaeun Choi [Wed, 16 Apr 2014 01:38:34 +0000 (10:38 +0900)]
win: apply key binding
Summary: This patch applies key binding to elm_win.
Test Plan: None
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D741
Carsten Haitzler (Rasterman) [Tue, 15 Apr 2014 09:42:29 +0000 (18:42 +0900)]
theme - improve efm icons provided by ApB
this fixes T575 wishlist item and improved the icons in default
@feature
Carsten Haitzler (Rasterman) [Tue, 15 Apr 2014 09:41:39 +0000 (18:41 +0900)]
win - add ELM_ACCEL env var to set acel method that is preferred
@feature
Jaeun Choi [Tue, 15 Apr 2014 07:41:16 +0000 (16:41 +0900)]
config: bug fix in popup key binding
Summary: This patch changes 'Tap' into 'Tab'.
Test Plan: None
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D739
Jaeun Choi [Tue, 15 Apr 2014 07:09:12 +0000 (16:09 +0900)]
video: apply key binding
Summary: This patch applies key binding to elm_video.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D738
Jaeun Choi [Tue, 15 Apr 2014 07:07:52 +0000 (16:07 +0900)]
toolbar: apply key binding
Summary: This patch applies key binding to elm_toolbar.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D737
Jaeun Choi [Tue, 15 Apr 2014 07:07:41 +0000 (16:07 +0900)]
slideshow: apply key binding
Summary: This patch applies key binding to elm_slideshow.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D736
Jaeun Choi [Tue, 15 Apr 2014 07:07:17 +0000 (16:07 +0900)]
photocam: apply key binding
Summary: This patch applies key binding to elm_photocam.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D735
Jaeun Choi [Tue, 15 Apr 2014 05:54:58 +0000 (14:54 +0900)]
radio: apply key binding
Summary: This patch applies key binding to elm_radio.
Test Plan: None
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D734
Jaeun Choi [Tue, 15 Apr 2014 05:52:06 +0000 (14:52 +0900)]
map: apply key binding
Summary: This patch applies key binding to elm_map.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D733
Jaeun Choi [Tue, 15 Apr 2014 05:49:35 +0000 (14:49 +0900)]
image: apply key binding
Summary: This patch applies key binding to elm_image.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D732
Jaeun Choi [Tue, 15 Apr 2014 05:47:19 +0000 (14:47 +0900)]
popup: apply key binding
Summary: This patch applies key binding to elc_popup.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D731
Jaeun Choi [Tue, 15 Apr 2014 05:46:39 +0000 (14:46 +0900)]
player: apply key binding
Summary: This patch applies key binding to elm_player.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D730
Jaeun Choi [Tue, 15 Apr 2014 05:40:38 +0000 (14:40 +0900)]
hoversel: apply key binding
Summary: This patch applied key bindiing to elc_hoversel.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D729
Jaeun Choi [Tue, 15 Apr 2014 04:58:01 +0000 (13:58 +0900)]
fileselector: apply key binding
Summary: This patch applies key binding to elm_fileselector.
Test Plan: elementary_test > fileselector > check key events
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D728
Jaeun Choi [Tue, 15 Apr 2014 04:13:57 +0000 (13:13 +0900)]
list: apply key binding
Summary: This patch applies key binding to elm_list.
Test Plan: elementary_test > list > check key events
Reviewers: Hermet, raster, seoz
Differential Revision: https://phab.enlightenment.org/D727
Jaeun Choi [Mon, 14 Apr 2014 10:47:52 +0000 (19:47 +0900)]
key binding infra change for modifiers
Summary: This patch makes key binding support multiple and inverse modifier set.
Test Plan: None
Reviewers: raster, Hermet
Differential Revision: https://phab.enlightenment.org/D717
Ryuan Choi [Mon, 14 Apr 2014 05:00:33 +0000 (14:00 +0900)]
elm_web2: Fix build break with latest EFL
Followes Eo2 changes.
Daniel Juyung Seo [Sat, 12 Apr 2014 17:00:33 +0000 (02:00 +0900)]
toolbar: Initialized some internal variables.
This fixes coverity CID 1199658, 1199659.
Daniel Juyung Seo [Sat, 12 Apr 2014 16:58:43 +0000 (01:58 +0900)]
scroller: Initialized some internal variables.
This fixes coverity CID 1199657, 1199622, 1199621, 1199620.
@fix
Daniel Juyung Seo [Sat, 12 Apr 2014 16:44:22 +0000 (01:44 +0900)]
widget: Initialized internal variables.
This fixes coverity CID 1199625 and 1199626.
@fix
Daniel Juyung Seo [Sat, 12 Apr 2014 16:40:27 +0000 (01:40 +0900)]
test_genlist: Initialize internal variable.
This fixes coverity CID 1193249.
Daniel Juyung Seo [Sat, 12 Apr 2014 16:37:38 +0000 (01:37 +0900)]
test_gengrid: Refactor gengrid test code.
- Added 'unselected' callback to reveal multiselect bug.
- Passed 'gengrid' directly instead of passing 'api' structure and using it indirectly.
- Added more box to make the GUI cleaner.
- Removed unnecessary comments and added more important comment.
Ryuan Choi [Fri, 11 Apr 2014 20:20:23 +0000 (05:20 +0900)]
elm_web2: Fix build break.
There are some missing implementations whith elm_web implements
but elm_web2 didn't yet.
This patch just added dummy implementations to fix build break.
Daniel Zaoui [Fri, 11 Apr 2014 06:39:48 +0000 (09:39 +0300)]
Menu: Fix warnings.
Jaeun Choi [Thu, 10 Apr 2014 10:29:37 +0000 (19:29 +0900)]
removed unnecessary field in key binding
Summary: No need to check ev->string if use ev->key instead of ev->keyname.
Test Plan: None
Reviewers: raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D714
Carsten Haitzler (Rasterman) [Thu, 10 Apr 2014 09:18:21 +0000 (18:18 +0900)]
FIX TOMS BREAKING OF ELEMENTARY!
Tom Hacohen [Thu, 10 Apr 2014 08:49:22 +0000 (09:49 +0100)]
Adjust code to use the slightly different Eo2 API.
With Eo2 you can return values directly without the need to use a pointer
(use the C return).
For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());
@feature
Tom Hacohen [Thu, 3 Apr 2014 14:21:28 +0000 (15:21 +0100)]
atspi: Made some protected functions protected.
They should be protected and they break compilation if they are not. I'm
pretty sure much more functions should be protected, but this one
definitely.
Tom Hacohen [Thu, 3 Apr 2014 16:30:04 +0000 (17:30 +0100)]
test task switcher: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:26:23 +0000 (17:26 +0100)]
test systray: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:25:38 +0000 (17:25 +0100)]
test application server: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:23:03 +0000 (17:23 +0100)]
win: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:21:05 +0000 (17:21 +0100)]
widget: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:13:49 +0000 (17:13 +0100)]
web: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:13:10 +0000 (17:13 +0100)]
video: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:12:41 +0000 (17:12 +0100)]
toolbar: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:00:37 +0000 (17:00 +0100)]
thumb: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:56:23 +0000 (16:56 +0100)]
table: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:55:07 +0000 (16:55 +0100)]
spinner: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:53:52 +0000 (16:53 +0100)]
slideshow: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:53:19 +0000 (16:53 +0100)]
slider: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:51:55 +0000 (16:51 +0100)]
separator: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:51:11 +0000 (16:51 +0100)]
segment control: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:50:15 +0000 (16:50 +0100)]
scroller: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:46:01 +0000 (16:46 +0100)]
route: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:45:35 +0000 (16:45 +0100)]
radio: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:44:14 +0000 (16:44 +0100)]
progressbar: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:42:49 +0000 (16:42 +0100)]
prefs: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:41:59 +0000 (16:41 +0100)]
plug: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:41:05 +0000 (16:41 +0100)]
photocam: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:39:38 +0000 (16:39 +0100)]
photo: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:38:49 +0000 (16:38 +0100)]
panes: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:36:36 +0000 (16:36 +0100)]
notify: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:35:37 +0000 (16:35 +0100)]
menu: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:34:29 +0000 (16:34 +0100)]
mapbuf: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:33:52 +0000 (16:33 +0100)]
map: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:32:21 +0000 (16:32 +0100)]
list: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:30:35 +0000 (16:30 +0100)]
layout: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:27:05 +0000 (16:27 +0100)]
label: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:25:28 +0000 (16:25 +0100)]
inwin: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:23:51 +0000 (16:23 +0100)]
interface scrollable: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:20:32 +0000 (16:20 +0100)]
interface atspi component: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:18:15 +0000 (16:18 +0100)]
index: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:17:22 +0000 (16:17 +0100)]
image: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:15:48 +0000 (16:15 +0100)]
icon: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:13:46 +0000 (16:13 +0100)]
hover: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:10:56 +0000 (16:10 +0100)]
grid: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:10:15 +0000 (16:10 +0100)]
glview: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:09:35 +0000 (16:09 +0100)]
genlist: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:07:36 +0000 (16:07 +0100)]
gengrid: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:06:01 +0000 (16:06 +0100)]
frame: Adjusted to Eo2.