davinci@google.com [Wed, 4 Jul 2012 13:52:11 +0000 (13:52 +0000)]
CPP: port Java changes libphonenumber 4.9
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@487
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Wed, 4 Jul 2012 10:08:41 +0000 (10:08 +0000)]
JAVA/METADATA: Port MetadataManager and data files to open source.
Review URL: https://codereview.appspot.com/6345053
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@486
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Tue, 3 Jul 2012 16:31:41 +0000 (16:31 +0000)]
TOOLS: Update to use refactored BuildMetadataProtoFromXml tool.
Review URL: https://codereview.appspot.com/6353060
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@485
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Tue, 3 Jul 2012 16:31:34 +0000 (16:31 +0000)]
TOOLS: Refactor the BuildMetadataProtoFromXml tool to:
- Make command line parameters named instead of positional.
- Move all information about paths, names, etc., from being hardcoded into the
tool itself to command line parameters, so that new files in the future can
be generated by just adding build rules for them without having to update the
tool.
- Not hard-code class or package names, but get them from the Class object.
- Break code generation up into smaller parts, to make it easier to extend the
code generation and share code while generating different classes.
- Update BuildMetadataFromXml to not output empty region codes.
- Generate either a Map or a Set, depending on whether the mapping table
actually contains any data or not.
All files generated by the tool remain identical to before this change.
Review URL: https://codereview.appspot.com/6343066
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@484
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Mon, 2 Jul 2012 12:28:02 +0000 (12:28 +0000)]
JAVA build: Changing the build file to make it more obvious when tests fail and print a message.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@483
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Mon, 2 Jul 2012 09:53:06 +0000 (09:53 +0000)]
JAVA: Adding new range 0117 4 for GB (Bristol) that will soon come into service. Patch contributed by g1smd.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@482
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Fri, 29 Jun 2012 15:27:49 +0000 (15:27 +0000)]
TOOLS: Update to use the new version of the BuildMetadataProtoFromXml that can also build data files for alternate formats.
Review URL: https://codereview.appspot.com/6351054
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@481
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Fri, 29 Jun 2012 15:18:38 +0000 (15:18 +0000)]
TOOLS: Update the BuildMetadataProtoFromXml tool to build data files for alternate formats as well.
Review URL: https://codereview.appspot.com/6355051
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@480
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Fri, 29 Jun 2012 14:25:30 +0000 (14:25 +0000)]
CPP: Comment fix, including small fix to sample code.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@479
ee073f10-1060-11df-b6a4-
87a95322a99c
roubert@google.com [Fri, 29 Jun 2012 13:11:52 +0000 (13:11 +0000)]
JAVA: Add a build target that runs a specified unit test
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@478
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Thu, 28 Jun 2012 09:51:00 +0000 (09:51 +0000)]
CPP: Remove unused bit_cast() in basictypes.h.
This was also causing a compilation error with GCC 4.8.
This CL also removes basictypes.h.orig accidentally added in the previous
revision.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@477
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 27 Jun 2012 12:38:08 +0000 (12:38 +0000)]
CPP: Add geocoding data generator.
Patch contributed by pmezard.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@476
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 27 Jun 2012 12:27:27 +0000 (12:27 +0000)]
CPP: Metadata changes only (v4.8.5)
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@475
ee073f10-1060-11df-b6a4-
87a95322a99c
davinci@google.com [Wed, 27 Jun 2012 03:04:23 +0000 (03:04 +0000)]
JS: port Java changes from v4.9 (rev 469) and update metadata
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@474
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 26 Jun 2012 07:55:27 +0000 (07:55 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@473
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 26 Jun 2012 07:55:10 +0000 (07:55 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.9
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@471
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Mon, 25 Jun 2012 17:15:29 +0000 (17:15 +0000)]
Provides namespace for PhoneNumberUtil.MatchType and PhoneNumberUtil.ValidationResult.
Review URL: http://codereview.appspot.com/6333054
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@470
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 21 Jun 2012 17:01:20 +0000 (17:01 +0000)]
Java/JS build tools: Adding missing semicolon.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@469
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 21 Jun 2012 16:37:38 +0000 (16:37 +0000)]
JAVA: libphonenumber v4.9. Patch prepared by davinci.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@468
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Fri, 15 Jun 2012 09:02:54 +0000 (09:02 +0000)]
DATA: Fixing small error in xml schema for LI.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@467
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 14 Jun 2012 10:03:56 +0000 (10:03 +0000)]
JAVA/JS: Metadata changes only (v4.8.5)
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@466
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Wed, 13 Jun 2012 14:05:05 +0000 (14:05 +0000)]
DATA: Updated geocoding data for Taiwan in English.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@465
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 12 Jun 2012 07:40:37 +0000 (07:40 +0000)]
Updating link to ISO country codes
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@464
ee073f10-1060-11df-b6a4-
87a95322a99c
davinci@google.com [Wed, 6 Jun 2012 09:15:01 +0000 (09:15 +0000)]
JAVA: Metadata changes only (v4.8.4)
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@463
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 1 Jun 2012 15:33:18 +0000 (15:33 +0000)]
CPP: Implement AreaCodeMap and DefaultMapStorage.
Patch contributed by pmezard.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@462
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 1 Jun 2012 14:36:48 +0000 (14:36 +0000)]
CPP: Adjust phonenumbermatch_test.cc integer types.
This failed with OSX 10.6 default gcc-4.2 and macports gcc-4.8.
Patch contributed by pmezard.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@461
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 1 Jun 2012 12:18:57 +0000 (12:18 +0000)]
CPP: Metadata changes only (v4.8.3).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@460
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Wed, 30 May 2012 07:12:19 +0000 (07:12 +0000)]
JAVA/JS: Metadata changes only (v4.8.3).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@459
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 23 May 2012 09:27:20 +0000 (09:27 +0000)]
CPP: Fix stringutil_test literal types
This failed with OSX 10.6 default gcc-4.2 and macports gcc-4.8.
Patch contributed by pmezard.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@458
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 23 May 2012 09:20:57 +0000 (09:20 +0000)]
CPP: Make cpplint happy with stringutils.*
Patch contributed by pmezard.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@457
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Tue, 22 May 2012 11:09:54 +0000 (11:09 +0000)]
CPP: Fix compilation error with -DUSE_GOOGLE_BASE
This removes the Chromium-specific (outdated) Logger interface from
default_logger.h.
The return type of set_logger_impl() differed from the one in logger.h (changed
in r430) which produced a compilation error in phonenumberutil.cc when
set_logger_impl() is used as a right value.
Logger, defined in logger.h is now used in all cases.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@456
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 16 May 2012 14:41:14 +0000 (14:41 +0000)]
CPP: Metadata changes only (v4.8.2).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@455
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Wed, 16 May 2012 12:41:46 +0000 (12:41 +0000)]
JAVA/JS: Metadata changes only (v4.8.2).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@454
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Thu, 10 May 2012 18:57:05 +0000 (18:57 +0000)]
JS: Fix duplicate keys in countryToMetadata map
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@453
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Thu, 10 May 2012 15:59:25 +0000 (15:59 +0000)]
CPP: Support ICU versions built without support for std::string.
This is the case on Android.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@452
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 9 May 2012 14:08:58 +0000 (14:08 +0000)]
CPP: Metadata changes only (v4.8.1).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@451
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 9 May 2012 11:09:53 +0000 (11:09 +0000)]
TOOLS: Add missing LD flags in continuous-integration.sh
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@450
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Tue, 8 May 2012 10:16:36 +0000 (10:16 +0000)]
JS: Metadata changes only (v4.8.1).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@449
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 8 May 2012 09:12:58 +0000 (09:12 +0000)]
JAVA: Metadata changes only (v4.8.1).
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@448
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 8 May 2012 09:12:00 +0000 (09:12 +0000)]
DEMO: Fixing xml file so can run demo locally on appengine.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@447
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 27 Apr 2012 14:36:02 +0000 (14:36 +0000)]
CPP: libphonenumber 4.8.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@446
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Fri, 27 Apr 2012 11:38:56 +0000 (11:38 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@445
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Fri, 27 Apr 2012 11:38:40 +0000 (11:38 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.8
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@443
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Wed, 25 Apr 2012 10:11:59 +0000 (10:11 +0000)]
JS: libphonenumber 4.8
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@442
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 24 Apr 2012 14:38:21 +0000 (14:38 +0000)]
JAVA: Removing user-names from TODO.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@441
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 24 Apr 2012 14:28:26 +0000 (14:28 +0000)]
JAVA: libphonenumber v4.8 More RFC support, metadata updates (including geocoding), some refactoring.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@440
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 13 Apr 2012 10:06:11 +0000 (10:06 +0000)]
CPP: libphonenumber 4.7.
This is mainly a metadata update.
Modified files:
cpp/src/phonenumbers/lite_metadata.cc
cpp/src/phonenumbers/metadata.cc
cpp/src/phonenumbers/phonenumberutil.cc
cpp/test/phonenumbers/phonenumbermatcher_test.cc
Review URL: https://codereview.appspot.com/6028044
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@439
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Tue, 27 Mar 2012 18:12:07 +0000 (18:12 +0000)]
JS: libphonenumber 4.7
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@438
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Tue, 27 Mar 2012 12:02:56 +0000 (12:02 +0000)]
svn:ignore generated files and update java-build-1.0-SNAPSHOT-jar-with-dependencies.jar
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@437
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Tue, 27 Mar 2012 11:59:36 +0000 (11:59 +0000)]
JAVA: Remove unused imports.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@436
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Wed, 21 Mar 2012 08:24:08 +0000 (08:24 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@435
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Wed, 21 Mar 2012 08:23:57 +0000 (08:23 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.7
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@433
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Mon, 19 Mar 2012 11:46:55 +0000 (11:46 +0000)]
JAVA: Exclude TestMetadataTestCase from test cases.
Review URL: https://codereview.appspot.com/5847065
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@432
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Fri, 16 Mar 2012 15:59:09 +0000 (15:59 +0000)]
JAVA: libphonenumber v4.7. Mainly metadata updates.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@431
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Thu, 15 Mar 2012 17:04:03 +0000 (17:04 +0000)]
CPP: libphonenumber 4.6.
Note that the metadata files were not uploaded to appspot because they were too
large. Here is the list of the files affected by this change (generated by
Git):
cpp/src/phonenumbers/lite_metadata.cc
cpp/src/phonenumbers/logger.h
cpp/src/phonenumbers/metadata.cc
cpp/src/phonenumbers/phonenumbermatcher.cc
cpp/src/phonenumbers/phonenumberutil.cc
cpp/src/phonenumbers/phonenumberutil.h
cpp/src/phonenumbers/region_code.h
cpp/src/phonenumbers/stringutil.cc
cpp/src/phonenumbers/stringutil.h
cpp/test/phonenumbers/asyoutypeformatter_test.cc
cpp/test/phonenumbers/phonenumbermatcher_test.cc
cpp/test/phonenumbers/phonenumberutil_test.cc
cpp/test/phonenumbers/stringutil_test.cc
This CL also fixes the issue reported by Aaron about the logger being invoked
before it is initialized.
Review URL: https://codereview.appspot.com/5786065
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@430
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 9 Feb 2012 15:33:22 +0000 (15:33 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@429
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 9 Feb 2012 15:33:08 +0000 (15:33 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.6
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@427
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 9 Feb 2012 15:17:29 +0000 (15:17 +0000)]
JAVA: libphonenumber v4.6. New countries: BQ, CW, SS, metadata updates & bug fixes.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@426
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Tue, 7 Feb 2012 17:04:48 +0000 (17:04 +0000)]
CPP: Update lite_metadata.cc.
This file was not up-to-date which made some unit tests fail in Chrome.
Note that the file is not displayed on rietveld since it is too large.
Review URL: https://codereview.appspot.com/5636052
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@425
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Mon, 6 Feb 2012 17:22:44 +0000 (17:22 +0000)]
CPP: Fix PhoneNumberMatcher build in Chrome.
Contributors:
- leandrogracia@chromium.org
- georgey@chromium.org
Review URL: https://codereview.appspot.com/5627046
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@424
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 1 Feb 2012 21:35:37 +0000 (21:35 +0000)]
CPP: libphonenumber 4.5
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@423
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos [Fri, 27 Jan 2012 20:10:00 +0000 (20:10 +0000)]
JS: libphonenumber 4.5
Review URL: http://codereview.appspot.com/5574080
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@422
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Tue, 24 Jan 2012 08:54:30 +0000 (08:54 +0000)]
DATA: Fixing AU mobile prefixes. Based on patch contributed by monjiwired. Solves issue 89.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@421
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Mon, 23 Jan 2012 11:29:43 +0000 (11:29 +0000)]
Stop modifying metadata in formatInOriginalFormat().
Bug: http://code.google.com/p/libphonenumber/issues/detail?id=91
Review URL: http://codereview.appspot.com/5573043
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@420
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Fri, 20 Jan 2012 16:31:01 +0000 (16:31 +0000)]
Java: Fix geocoder to return empty string for Global Networks numbers.
Review URL: http://codereview.appspot.com/5557071
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@419
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 19 Jan 2012 15:49:21 +0000 (15:49 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@418
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 19 Jan 2012 15:49:10 +0000 (15:49 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.5
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@416
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 19 Jan 2012 15:41:56 +0000 (15:41 +0000)]
JAVA: libphonenumber 4.5
Review URL: http://codereview.appspot.com/5532089
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@415
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Tue, 17 Jan 2012 12:30:46 +0000 (12:30 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@414
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Tue, 17 Jan 2012 12:30:33 +0000 (12:30 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.4
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@412
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Fri, 9 Dec 2011 23:02:55 +0000 (23:02 +0000)]
JAVA: libphonenumber v4.4
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@411
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Thu, 8 Dec 2011 16:25:44 +0000 (16:25 +0000)]
CPP: Fix compilation error on Clang. Patch contributed by KushalP.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@410
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Thu, 8 Dec 2011 13:38:07 +0000 (13:38 +0000)]
JAVA: Add Maven support for the libphonenumber demo.
That lets the demo be part of the libphonenumber Maven project thus adds the following benefits:
- Automatically update the version of the demo and the libphonenumber artifact the demo depends on when performing a release.
- Let Maven handle the deployment of the demo to AppEngine without any need to install the AppEngine SDK.
- No need to push the dependency JARs (servlet, apache common fileupload/io) even if they are still here to let you use Ant if you prefer.
Note that this CL depends on CL 5395054.
Review URL: http://codereview.appspot.com/5405041
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@409
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 7 Dec 2011 14:52:33 +0000 (14:52 +0000)]
CPP: Add Windows instructions to the README file.
Review URL: http://codereview.appspot.com/5451062
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@408
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 2 Dec 2011 14:44:03 +0000 (14:44 +0000)]
CPP: Refactoring PhoneNumberUtil so that global scoped_ptr variables are now hidden in an internal class. Patch contributed by Lara Rennie.
Review URL: http://codereview.appspot.com/5450068
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@407
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 2 Dec 2011 10:03:30 +0000 (10:03 +0000)]
CPP: Remove static non-POD variables from RegionCode class. Patch contributed by georgey@chromium.org.
Review URL: http://codereview.appspot.com/5449064
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@406
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 2 Dec 2011 08:59:12 +0000 (08:59 +0000)]
CPP: Add missing license in cpp/test/phonenumbers/run_tests.cc.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@405
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 30 Nov 2011 10:42:30 +0000 (10:42 +0000)]
CPP: Update README file.
Review URL: http://codereview.appspot.com/5448055
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@404
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Tue, 29 Nov 2011 10:48:41 +0000 (10:48 +0000)]
CPP: libphonenumber 4.3
Review URL: http://codereview.appspot.com/5445043
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@403
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Tue, 29 Nov 2011 09:23:58 +0000 (09:23 +0000)]
CPP: Fix logger and asyoutypeformatter unit test to let the latest release build in Chromium.
Patch contributed by georgey@chromium.org.
Review URL: http://codereview.appspot.com/5440052
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@402
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 24 Nov 2011 15:46:02 +0000 (15:46 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@399
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 24 Nov 2011 15:45:53 +0000 (15:45 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.3
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@397
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 24 Nov 2011 15:03:01 +0000 (15:03 +0000)]
Refactoring PhoneNumberOfflineGeocoder and updating tests and PhoneNumberUtil.
Review URL: http://codereview.appspot.com/5435067
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@396
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 24 Nov 2011 13:47:31 +0000 (13:47 +0000)]
Update libphonenumber to v4.3
Review URL: http://codereview.appspot.com/5434054
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@395
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 23 Nov 2011 16:49:00 +0000 (16:49 +0000)]
CPP: Update Debian package version number after major version was updated in r369. Patch contributed by roubert@google.com.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@394
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 23 Nov 2011 09:19:28 +0000 (09:19 +0000)]
CPP: Fix CMakeLists to require Boost datetime needed by Boost thread.
This also makes the library link with the Boost static libs on Windows.
Review URL: http://codereview.appspot.com/5430053
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@393
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Wed, 23 Nov 2011 08:51:14 +0000 (08:51 +0000)]
CPP: Fix compilation error in default_logger.h on Visual Studio 2010.
Review URL: http://codereview.appspot.com/5436046
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@392
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Tue, 22 Nov 2011 15:43:10 +0000 (15:43 +0000)]
JAVA: Add Maven support for offline phone number geocoder.
This CL (depending on CL 5376090) adds the Maven support for the offline phone number geocoder.
All the geocoding-related code/data is moved to the new directory java/geocoder.
Additionally a pom.xml file is added to java/ and java/geocoder/.
The pom.xml file located in java/ is the parent pom file which contains the configuration (SCM, developers, encoding...) that applies to both the libphonenumber and geocoder modules.
The libphonenumber and geocoder Maven modules inherit from this parent pom file therefore they don't need to duplicate this configuration.
I also moved build.xml and release_notes.txt back to java/.
BUG=57
Review URL: http://codereview.appspot.com/5395054
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@391
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Mon, 21 Nov 2011 10:45:37 +0000 (10:45 +0000)]
JAVA: Move java code to java/libphonenumber.
This is required for the incoming Maven refactoring adding a separate geocoder module.
BUG=57
Review URL: http://codereview.appspot.com/5376090
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@390
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos [Fri, 18 Nov 2011 10:18:54 +0000 (10:18 +0000)]
JS: libphonenumber 4.2.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@389
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 17 Nov 2011 16:42:12 +0000 (16:42 +0000)]
METADATA: Fixing formatting patterns for Korea to cover all numbers we consider valid.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@388
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Mon, 14 Nov 2011 14:20:32 +0000 (14:20 +0000)]
CPP: libphonenumber 4.2.
Review URL: http://codereview.appspot.com/5372051
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@387
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 10 Nov 2011 14:32:58 +0000 (14:32 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@386
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 10 Nov 2011 14:32:42 +0000 (14:32 +0000)]
[maven-release-plugin] prepare release libphonenumber-4.2
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@384
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 10 Nov 2011 14:02:33 +0000 (14:02 +0000)]
Fixing NPE in getLengthOfNationalDestinationCode reported in issue 73
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@383
ee073f10-1060-11df-b6a4-
87a95322a99c
lararennie@google.com [Thu, 10 Nov 2011 13:02:10 +0000 (13:02 +0000)]
JAVA: libphonenumber 4.2. Includes rest of emergency number data, new region SX.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@382
ee073f10-1060-11df-b6a4-
87a95322a99c
philip.liard@gmail.com [Fri, 4 Nov 2011 12:02:25 +0000 (12:02 +0000)]
Reset PhoneNumberUtil singleton instance in ShortNumberUtilTest and make JUnit tests never fork in both Ant and Maven.
PhoneNumberUtil.resetInstance() should always be used instead. This omission should not be hidden by unit tests that fork.
That also makes the external version consistent with the internal one in which unit tests don't seem to be executed by default in isolated processes.
Review URL: http://codereview.appspot.com/5341042
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@381
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Fri, 28 Oct 2011 10:09:37 +0000 (10:09 +0000)]
- Fix formatNumberForMobileDialing that is modifying its input PhoneNumber.
- Fix incorect use of string equality.
- Fix testGetEnglishDataPath that is failing under windows.
- Remove unused method and variables.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@380
ee073f10-1060-11df-b6a4-
87a95322a99c
tronikos@gmail.com [Mon, 24 Oct 2011 20:06:39 +0000 (20:06 +0000)]
JS: libphonenumber 4.1.
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@379
ee073f10-1060-11df-b6a4-
87a95322a99c
jia.shao.peng [Thu, 20 Oct 2011 22:09:50 +0000 (22:09 +0000)]
[maven-release-plugin] prepare for next development iteration
git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@378
ee073f10-1060-11df-b6a4-
87a95322a99c