Jan Kotas [Wed, 20 Mar 2019 07:39:51 +0000 (00:39 -0700)]
Unify EnumInfo and NamesAndValues
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Thu, 21 Mar 2019 06:54:41 +0000 (23:54 -0700)]
Hoist calls to IsBitwiseEquatable (#23381)
Smaller IL is easier for JIT
Jeremy Koritzinsky [Thu, 21 Mar 2019 05:59:29 +0000 (22:59 -0700)]
Runtime changes for IJW Activation (#22636)
* Implement loading an assembly from an HMODULE on Windows.
* Use the native runtime to execute the main method so I don't have to replicate all of the startup behavior.
* If ijwhost is loaded, then call back into ijwhost to resolve tokens for vtable entries.
* Refactor our various component loaders (COM and IJW) and have IJW load components into separate ALCs when loaded from native.
* Move VTableFixups after DeliverSyncEvents in our incremental load. We need the module to be loaded to at least FILE_LOAD_DELIVER_EVENTS when resolving dependencies loaded via VTableFixups, otherwise they try to load into the default ALC.
* Only try to get ijwhost module handle on Windows.
* Use defined() instead of ifndef
* Fix off-Windows build break and fix unvalid comment.
* ComponentLoadContext->IsolatedComponentLoadContext
* Only build InMemoryAssemblyLoader when targeting windows.
* Add doc comments for IsolatedComponentLoadContext.
* Rename qcall.
* Add comment for boolean parameter.
* Add null check for managed ExecuteMainMethod entrypoint.
* Add comments in ceeload.cpp for the ijwhost method resolution.
* Add test verifying runtime callback to IJW host.
* Add test for InMemoryAssemblyLoader.LoadInMemoryAssembly.
* Fix x86 behavior rel. loading symbols by name and stdcall mangling.
* Remove exe entrypoints. The executable case for mixed-mode will go through the normal .NET Core app model (no special hosting support needed).
* Clean up whitespace
* Add test verifying M->N->M ALC switch behavior with IJW.
* Resolve the ijwhost module by probing the PE for the IJW assembly instead of hardcoding the name.
* Remove static caching in GetTokenGetterFromHostModule.
* Disable new IJW tests on Win7.
* PR Feedback.
* Cleanup extra copy of function.
* Use old-style environment checking in LoadIjwFromModuleHandle since we reference S.P.CL directly.
* Fix break in rebase
* Clean up fake mscoree code.
* Only validate that a CLR header exists. The OS verifies everything else.
* Make ijw host resolution code static to ceeload.cpp
* Use bracketed include for xplatform.h
* Update comment on _CorDllMain
* PR feedback.
* Remove .def file.
* PR feedback.
* Verify we export correctly on x86 and x64.
* Fix path to ijwhostmock for CopyConstructorMarshaler
* Disable IJW tests on arm32 nightly. Can't repro the dependency load failures. Fixes #23358
Sung Yoon Whang [Thu, 21 Mar 2019 02:20:01 +0000 (19:20 -0700)]
Test for PollingCounter (#23257)
* Add test for PollingCounter
* some cleanup
* Comparing mean to failureCountCalled
* fix comparison
* compare to the correct count
* fix casing in csproj file
dotnet-maestro[bot] [Thu, 21 Mar 2019 01:36:34 +0000 (18:36 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190319.04 (#23360)
- Microsoft.NETCore.App - 3.0.0-preview4-27519-04
Egor Chesakov [Wed, 20 Mar 2019 21:47:09 +0000 (14:47 -0700)]
Remove kill-tasks step in eng/build-job.yml and kill_tasks.cmd file (#23351)
Sergey Andreenko [Wed, 20 Mar 2019 17:12:06 +0000 (10:12 -0700)]
Restrict the set of platforms for GCStress testing. (#23353)
Brian Bohe [Wed, 20 Mar 2019 17:08:01 +0000 (10:08 -0700)]
Adding a flag to able/disable scope info (#23298)
* Flag USING_SCOPE_INGO definition
* Enclosing siScope's related functions uses with USING_SCOPE_INFO flag definition check
* Encapsulating genSetScopeInfo when using siVarScope
* Moving comment inside flag defined block
* Include siScope/psiScope functions only when flag USING_SCOPE_INFO is defined
* Disable scope info
* Typo
* Adding comment flag name on #endif
* Remove redundant access levels/flags
* Repeating last accessibility level in case flag is disabled
* Setting use of siScope and psiScope as default way of reporting variable homes
Andy Ayers [Wed, 20 Mar 2019 16:17:30 +0000 (09:17 -0700)]
Add repro case for jit stack overflow failure (#23346)
Repro case for #18582 and #23309.
Sergey Andreenko [Wed, 20 Mar 2019 06:16:26 +0000 (23:16 -0700)]
Exclude GC/Collect from GCStress testing. (#23345)
Jeremy Koritzinsky [Tue, 19 Mar 2019 23:22:47 +0000 (16:22 -0700)]
Implement support for copy constructors when marshalling in IJW (#22805)
Fixes #22219.
I decided to try simplifying the code when bringing this feature over from .NET Framework. The .NETFX x86 implementation of this marshaler adds a lot of extra code-paths, and intercepts the calling stub to enable it to exactly replicate the behavior of what would be the native code by copy-constructing an object in-place where it goes on the stack for the native call.
Instead of adding all of that extra goo, I decided to keep the implementation much more similar to the non-x86 implementation from .NETFX. Instead of intercepting the call and adding bookkeeping helper stubs, the marshaler just copies to a local in the IL stub, just like non-x86. When calling the native function, it just loads the local onto the IL stack and calls the native function as a normal function. There is a difference there, but I cannot think of a way that the difference is observable to the user.
The non-x86 implementation is identical to the .NETFX implementation.
Sung Yoon Whang [Tue, 19 Mar 2019 21:46:18 +0000 (14:46 -0700)]
Remove timer in RuntimeEventSource (#23311)
* Change RuntimeEventSource's counter types
* cleanup
* cleanup
Grant [Tue, 19 Mar 2019 21:20:00 +0000 (14:20 -0700)]
Trim/TrimStart/TrimEnd methods for Memory and Span (#22798)
* Span.Trim
* Add another helper
* Remove redundant comments
* Optimize Trim(ReadOnlySpan<char>)
* Suggested overload for byte
* CR fixes
* CR fix
* Add Span overloads
* Add Memory overloads
* CR
* Rename method
* Optimization
* Tweaks
* Refactor
* Opt
* Use 2 helpers
* CR fixes
* CR fixes
* Nits
* CR fixes
* remove in params
* Bug
* Bug
* Move Trim methods to their own dedicated file
* Add char overloads
* Use Contains
* CR fixes
* Optmize ClampNull
* Nit
* Revert optimization
* Make existing implementations consistent with new
* Revert existing methods
* Move helpers
* Span, Memory and RoM should use consistent pattern
* POC for changing RoS
* Revert POC
* Use consistent idiom
* More inlining of explaining vars
* Use expression body for existing code
* CR fixes
* Nit
* Grammar
* CR fixes
* Fix perf bug in existing code
* Perf fix
* Force CI build
* Force CI
David Mason [Tue, 19 Mar 2019 21:00:36 +0000 (14:00 -0700)]
Reintroduce PR #22617 (Update added types and methoddefs on ApplyMetadata) (#23202)
* Add ApplyMetadata changes back
This reverts commit
f9c10f995fe65c0e7c30aa1734f7bb22c519983d.
* Fix race condition in loading available class hash for R2R with old R2R images or profiler modified R2R images
dotnet-maestro[bot] [Tue, 19 Mar 2019 19:23:59 +0000 (12:23 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190317.10 (#23339)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19167.10
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19167.10
dotnet-maestro[bot] [Tue, 19 Mar 2019 19:23:16 +0000 (12:23 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190318.07 (#23341)
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27518-07
Sergey Andreenko [Tue, 19 Mar 2019 18:34:57 +0000 (11:34 -0700)]
Update CoreFX Windows Arm64 exclusion list. (#23261)
* Reenable CoreFX tests that were fixed on arm64 windows.
* Exclude Microsoft.Win32.SystemEvents.Tests
Jarret Shook [Tue, 19 Mar 2019 18:06:56 +0000 (11:06 -0700)]
Disable Jenkins Innerloop Jobs (#23287)
* Disable Jenkins Innerloop Jobs
This change will:
1) Remove default PR trigger jobs from being run in jenkins
2) Start submitting tests for linux arm32 in coreclr-ci
It is worth noting that this change will not remove jobs from netci.groovy.
This is to say that it is still possible to trigger innerloop and outerloop
jobs in jenkins, they will just not be run automatically on each new PR.
Past this point coreclr-ci will be the only PR triggered jobs to appear in Coreclr.
To see test results, navigate to the coreclr-ci Azure Dev Ops page at:
https://dev.azure.com/dnceng/public/_build?definitionId=228 and view the build related to your PR.
There is a test tab which will report all test results.
* Address PR feedback
* Add queue to array syntax
* Do not create push trigger jobs
Brian Bohe [Tue, 19 Mar 2019 17:21:49 +0000 (10:21 -0700)]
Adding const to functions that don't change or shouldn't change state (#23329)
Jarret Shook [Tue, 19 Mar 2019 16:06:56 +0000 (09:06 -0700)]
Revert "Delete suspicious code in delegate construction (#22830)" (#23291)
This reverts commit
674bdcbc2ac824d005b5179cee3c5826b582b9a6.
Levi Broderick [Tue, 19 Mar 2019 05:58:32 +0000 (22:58 -0700)]
Add Utf8String skeleton (#23209)
Utf8String is an experimental type that is string-like (heap-allocated, immutable, variable-length, null-terminated) but whose inner representation is UTF-8, not UTF-16.
This is a skeleton implementation of the basic API shape. The ecosystem of APIs has not yet been built around it. All Utf8String-related code is currently surrounded by ifdefs to allow easy identification and removal from release branches.
Levi Broderick [Tue, 19 Mar 2019 02:17:20 +0000 (19:17 -0700)]
Add Rune.TryEncodeToUtf8 and related APIs (#23250)
Also renames the existing Encode / Decode APIs per design review feedback
Jeremy Koritzinsky [Tue, 19 Mar 2019 01:01:29 +0000 (18:01 -0700)]
Fix Interop/SizeConst/SizeConstTest to successfully run in all locales. (#20268)
This test initially would fail when run on a multibyte character set with characters for the original value of `s.arr` such as zh-CH. We cannot change the marshaler since there is not a good way to determine how many bytes/character we need at type-load-time (when the size of the native type is determined).
This change allows us to accurately run this test on Windows machines with multi-byte character sets.
Fixes #7793.
William Godbe [Mon, 18 Mar 2019 20:39:34 +0000 (13:39 -0700)]
Merge pull request #23314 from dotnet/darc-master-
648053b9-42fd-4c35-979c-
5fdabc09c8cb
[master] Update dependencies from dotnet/core-setup
Maoni Stephens [Mon, 18 Mar 2019 20:39:29 +0000 (13:39 -0700)]
Fix for running in a container without mem limit set on Windows; (#23297)
also fixing the LocalGC standalone case on Linux
Mathias Lykkegaard Lorenzen [Mon, 18 Mar 2019 20:38:57 +0000 (21:38 +0100)]
Update assemblyloadcontext.md (#23318)
Sinan Kaya [Mon, 18 Mar 2019 18:27:59 +0000 (14:27 -0400)]
Fix explicit constructor calls and Remove multi-line comments (#23162)
* fix implicit constructor call
* extern c
format patch
* muti-line
* Remove direct constructor call
* Conversion
* Need paranthesis
* Return value on resize
* declspec(Thread)
* Ignore warnings for GCC
* Formatting issues
* Move cast to constant
Jan Vorlicek [Mon, 18 Mar 2019 17:53:39 +0000 (18:53 +0100)]
Merge pull request #23307 from franksinankaya/gcc_cleanup_13
Fix conversion, unknown pragmas and Visibility Issues for GCC
Jan Vorlicek [Mon, 18 Mar 2019 17:53:08 +0000 (18:53 +0100)]
Merge pull request #23179 from franksinankaya/gcc_cleanup_11
Correct current script dir detection for GCC
José Rivero [Mon, 18 Mar 2019 17:23:30 +0000 (10:23 -0700)]
[EventPipe] Adding an IPC server to handle out of process communication. (#23106)
This is the first commit to enable a "diagnostic port" using IPC (Named Pipe on Windows and Unix Domain Socket on other platforms). This change currently enable EventPipe to be enabled/disabled without the use of a file drop.
- Split the DiagnosticsIpc into (DiagnosticsIpc/IpcStream)
- DiagnosticsIpc (IPC listener) is meant to be used by the Diagnostic server.
- IpcStream (IPC channel) is meant to be use to communicate with the connected client.
- Change the FastSerializer dependency from `CFileStream` to `StreamWriter`
This abstraction is meant decouple the writing of objects in order to extend its usability.
The main objective is to reuse FastSerializer to stream data through the open IPC channel.
- Moved the EventPipeSessionProvider* classes to their own file.
- Added a more streamlined parsing achievable by defining a simpler binary protocol (by noahfalk).
1. Only one allocation is needed for the EventPipeProviderConfiguration array, no allocations or copies are needed for strings because we can refer to them directly out of the incoming command buffer
2. No change to the EventPipe API for enable is required. EventPipeProviderConfiguration retains its current behavior of not deleting the string pointers it holds.
3. No leaks happen because the command buffer owns the string memory and ensures that it stays alive for the duration of the Enable() call.
Sinan Kaya [Mon, 18 Mar 2019 13:16:31 +0000 (13:16 +0000)]
Add gcc6 and gcc8 to supported compilers
Sinan Kaya [Mon, 18 Mar 2019 02:32:13 +0000 (02:32 +0000)]
Support gcc for build-test.sh
dotnet-maestro [Mon, 18 Mar 2019 12:46:54 +0000 (12:46 +0000)]
Update dependencies from https://github.com/dotnet/core-setup build
20190317.03
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27517-03
Levi Broderick [Mon, 18 Mar 2019 05:30:50 +0000 (22:30 -0700)]
Make more types eligible for vectorized code paths in MemoryExtensions (#20855)
Types like sbyte, ushort, and other 8-bit / 16-bit elemental types are now directed down the fast vectorized code paths that previously only byte and char were eligible for.
Sinan Kaya [Sun, 17 Mar 2019 20:39:59 +0000 (20:39 +0000)]
Correct ignored align attribute
src/vm/threadpoolrequest.h:166:48: error: attribute ignored in declaration of ‘struct ManagedPerAppDomainTPCount::<anonymous>’ [-Werror=attributes]
DECLSPEC_ALIGN(MAX_CACHE_LINE_SIZE) struct {
^
Sinan Kaya [Sun, 17 Mar 2019 20:36:22 +0000 (20:36 +0000)]
Const has static linkage
bin/obj/Linux.x64.Debug/src/dlls/mscorrc/full/mscorrc_debug.cpp:1002:110: error: ‘visibility’ attribute ignored [-Werror=attributes]
const NativeStringResourceTable nativeStringResourceTable_mscorrc_debug __attribute__((visibility("default"))) = {
dotnet-maestro[bot] [Sun, 17 Mar 2019 21:32:41 +0000 (14:32 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190316.06 (#23306)
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27516-06
Sinan Kaya [Sat, 16 Mar 2019 17:31:17 +0000 (17:31 +0000)]
Remove old files
Sinan Kaya [Mon, 11 Mar 2019 17:01:39 +0000 (17:01 +0000)]
Correct current script dir detection
Sinan Kaya [Sun, 17 Mar 2019 20:24:40 +0000 (20:24 +0000)]
Fix conversion issues
Sinan Kaya [Sat, 16 Feb 2019 20:16:53 +0000 (20:16 +0000)]
Suppress compiler warnings
remove no attribute
Egor Bogatov [Sun, 17 Mar 2019 06:10:36 +0000 (07:10 +0100)]
Move Enum and CorElementType to shared (#23177)
Sung Yoon Whang [Sun, 17 Mar 2019 02:06:11 +0000 (19:06 -0700)]
Fixing some payload serialization issue on new EventCounters (#23295)
* Fixing some payload serialization issue on new EventCounters
* Fix build error
Elinor Fung [Sat, 16 Mar 2019 22:02:52 +0000 (15:02 -0700)]
Fix x86 dumps from HandleFatalError showing misleading callstack (#23289)
Nikita Potapenko [Sat, 16 Mar 2019 15:41:47 +0000 (17:41 +0200)]
Fix typo (#23300)
.Net -> .NET
dotnet-maestro[bot] [Sat, 16 Mar 2019 15:35:07 +0000 (08:35 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190313.3 (#23303)
This change updates the following dependencies
- optimization.IBC.CoreCLR - 99.99.99-master-
20190313.3
- optimization.PGO.CoreCLR - 99.99.99-master-
20190313.3
dotnet-maestro[bot] [Sat, 16 Mar 2019 15:34:28 +0000 (08:34 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190314.7 (#23302)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19164.7
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19164.7
dotnet-maestro[bot] [Sat, 16 Mar 2019 15:34:16 +0000 (08:34 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190312.7 (#23301)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19162.7
Andy Ayers [Sat, 16 Mar 2019 15:08:16 +0000 (08:08 -0700)]
JIT: clear stub register assignment for tail calls via helper (#23288)
When we have a VSD tail call via a helper, the stub arg is passed as a normal
arg to the helper and moved to the right special register by the copy routine
that the helper invokes. So the jit does not need to pass the stub value in the
special register when calling the helper.
The stub arg gets set to that register by default, so we now unset it for the
tail call via helper case.
Closes #18943.
Bruce Forstall [Sat, 16 Mar 2019 04:27:56 +0000 (21:27 -0700)]
Introduce COMPlus arm64 HW intrinsics knobs (#23244)
* Introduce COMPlus configuration variables to disable arm64 HW intrinsics classes
Fixes #20708
* Formatting
Brian Bohe [Sat, 16 Mar 2019 03:54:22 +0000 (20:54 -0700)]
Add siVarLoc::Equals (#23275)
Stephen Toub [Sat, 16 Mar 2019 03:44:53 +0000 (23:44 -0400)]
Rename private GetEntryAssembly QCall overload (#22396)
To avoid issues with existing private reflection-based code that now gets a parameter count mismatch exception.
Also renamed GetExecutingAssembly for consistency.
Elinor Fung [Sat, 16 Mar 2019 00:57:38 +0000 (17:57 -0700)]
Use HKLM for CLSID lookup (#23258)
* Use HKLM for CLSID lookup
* Delete unused functions
Brian Sullivan [Fri, 15 Mar 2019 23:49:50 +0000 (16:49 -0700)]
Merge pull request #23294 from briansull/fix-format
Fix formatting error
Brian Sullivan [Fri, 15 Mar 2019 22:40:40 +0000 (15:40 -0700)]
Fix formatting error
Brian Sullivan [Fri, 15 Mar 2019 21:55:51 +0000 (14:55 -0700)]
Merge pull request #23272 from briansull/VNMap_Overwrite
Fix for duplicate call to Set when we run out of budget
Elinor Fung [Fri, 15 Mar 2019 19:33:43 +0000 (12:33 -0700)]
Port AMSI scanning for assembly loads (#23231)
* Port AMSI scanning for assembly loads
* Define PLATFORM_WINDOWS for Windows build
* Remove check for LOAD_LIBRARY_SEARCH_SYSTEM32 support
Jan Vorlicek [Fri, 15 Mar 2019 19:32:48 +0000 (20:32 +0100)]
Fix GetFullAffinityMask for cpuCount==64 (#23276)
The function was incorrectly assuming that shifting 64 bit
constant 1 by 64 bits to the left gets result 0.
Fawad Halim [Fri, 15 Mar 2019 19:32:11 +0000 (14:32 -0500)]
Fixed small typo in path to crossgen (#23286)
Sergey Andreenko [Fri, 15 Mar 2019 17:38:47 +0000 (10:38 -0700)]
Add `Schedule` and 'Manual' as possible triggers for outerloop jobs. (#23271)
Egor Chesakov [Fri, 15 Mar 2019 17:35:25 +0000 (10:35 -0700)]
Exclude tracing/keyword/TwoKeywords test from running on all platforms (#23267)
Related issue: https://github.com/dotnet/coreclr/issues/23224
Koundinya Veluri [Fri, 15 Mar 2019 16:12:27 +0000 (09:12 -0700)]
In CLRLifoSemaphore, start the underlying semaphore with 0 for the initial signal count (#22632)
- Port of a fix from https://github.com/dotnet/corert/pull/6955
- The underlying semaphore is only used to wake up waiters, initially there are no waiters and the signal count should be zero. This was already the case on Windows, this fixes the Unix side. The actual initial signal count is tracked in the upper layer counts.
- The initial signal count passed in is zero anyway in the places where it's used, so it makes no difference for now, just some cleanup
Justin Van Patten [Fri, 15 Mar 2019 14:52:31 +0000 (07:52 -0700)]
Collection<T>: Validate parameters in the public methods (#23166)
I was looking over the new Range methods on `Collection<T>` and it occurred to me that for all existing methods, parameter validation is done in the *public* methods before calling the *protected virtual* methods. This changes the new Range methods to do the same.
Han Lee [Fri, 15 Mar 2019 14:43:28 +0000 (07:43 -0700)]
Update performance-guidelines.md (#23183)
so that it uses run-xunit-perf.py command. run-xunit-perf.cmd is no longer there.
Jeremy Koritzinsky [Fri, 15 Mar 2019 05:24:15 +0000 (22:24 -0700)]
Fix Ubuntu arm build break. (#23270)
* Add platformdefines.h include to fix build break.
Egor Bogatov [Fri, 15 Mar 2019 03:41:05 +0000 (06:41 +0300)]
Move TypeLoadException to shared (#23238)
* fix coding-style
* shorter form for TypeName property
* move coreclr-specific ctor to TypeLoadException
Eric StJohn [Fri, 15 Mar 2019 02:13:11 +0000 (19:13 -0700)]
Make ILProj work in Visual Studio (#23264)
CPS depends the targets defined here and will fail to load a project if these aren't imported.
Jan Kotas [Fri, 15 Mar 2019 01:36:41 +0000 (18:36 -0700)]
Disable failing test against #23262 (#23263)
Brian Sullivan [Thu, 14 Mar 2019 23:19:07 +0000 (16:19 -0700)]
Fix for duplicate call to Set when we run out of budget
Bruce Forstall [Thu, 14 Mar 2019 22:51:30 +0000 (15:51 -0700)]
Merge pull request #23260 from BruceForstall/AlwaysArchiveCrossgenComparisonResults
Archive crossgen comparison job results even if job fails
Jan Vorlicek [Thu, 14 Mar 2019 22:31:25 +0000 (23:31 +0100)]
Merge pull request #23180 from franksinankaya/gcc_cleanup_12
Fix conversion and signedness issues in Event Tracer
Aaron Robinson [Thu, 14 Mar 2019 22:15:56 +0000 (15:15 -0700)]
Fix the calling convention for P/Invokes and delegates to hostpolicy (#23249)
* Fix the calling convention for P/Invokes and delegates
* Update mock library to match official hostpolicy calling conventions
Jan Vorlicek [Thu, 14 Mar 2019 21:30:00 +0000 (22:30 +0100)]
Fix GetProcessAffinityMask (#23247)
The function was returning mask not expected by runtime for coreclr
built with NUMA enabled on machines with multiple NUMA nodes.
The mask was 0 in case the current process was affinitized to CPUs
from multiple NUMA nodes. It was following MSDN doc, however the
doc turned out to be ambiguous. Moreover, the runtime depended
on the fact that on Windows, a process is never run on multiple
NUMA nodes unless is explicitly calls APIs to set ideal processor
for threads. But on Unix, there is no such case and by default, a
process is affinitized to all existing processors over all NUMA
nodes.
And there was one more issue. The GetProcessAffinityMask was returning
a mask within a single CPU group, which is a transformed view of
NUMA node on Windows. So the CPU indices in the mask didn't necessarily
correspond to the native Unix CPU indices. But, the SetThreadAffinityMask
was using the native Unix CPU indices.
To fix the problem, the GetProcessAffinityMask is changed so that
it always returns a mask corresponding to the native Unix CPU indices
(reporting upto 64 processors as the mask is 64 bit wide). Thus it
corresponds to what the SetThreadAffinityMask expects. And it also exactly
matches the behavior when NUMA support is not compiled in.
Moreover, the COMPlus_GCHeapAffinitizeMask bits now correspond to
the native Unix CPU indices.
The GetProcessAffinityMask is used by GC and thread pool only when
NUMA is not enabled using the COMPlus_GCCpuGroup env variable.
dotnet-maestro[bot] [Thu, 14 Mar 2019 20:54:25 +0000 (13:54 -0700)]
[master] Update dependencies from optimization repositories (#23226)
* Update dependencies from https://dnceng@dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190314.1
This change updates the following dependencies
- optimization.IBC.CoreCLR - 99.99.99-master-
20190314.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190314.1
Koundinya Veluri [Thu, 14 Mar 2019 20:51:25 +0000 (13:51 -0700)]
Fix DisableTier0Jit when multi-core JIT is enabled (#23200)
- With multi-core JIT, a method may be jitted before it is called, in which case the call counting entry would not already exist
Sergey Andreenko [Thu, 14 Mar 2019 20:36:03 +0000 (13:36 -0700)]
Update CoreFX Linux Arm64 exclusion list. (#22697)
* Update CoreFX Linux Arm64 exclusion list.
* Exclude System.Globalization.Calendars.Tests.
* Exclude System.Threading.Tasks.Tests.
* Exclude #23242
Bruce Forstall [Thu, 14 Mar 2019 20:34:53 +0000 (13:34 -0700)]
Archive crossgen comparison job results even if job fails
dotnet-maestro[bot] [Thu, 14 Mar 2019 16:02:17 +0000 (09:02 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190313.10 (#23255)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19163.10
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19163.10
Jan Vorlicek [Thu, 14 Mar 2019 09:22:44 +0000 (10:22 +0100)]
Merge pull request #23203 from janvorli/fix-no-return-false-positives
Fix no-return false positives in static analyzer build
Michal Strehovský [Thu, 14 Mar 2019 08:33:59 +0000 (09:33 +0100)]
Delete suspicious code in delegate construction (#22830)
Delegate construction is trying to do some weird special casing around closed delegates to interface methods that is breaking non-virtual delegates to default interface methods. The special casing has suspicious comments indicating people didn't know why it's needed in the first place, so I'm going with a theory that it's a cargo cult (e.g. why the reasons specified in the comments don't apply to normal virtual methods?).
Fixes #22728.
Sung Yoon Whang [Thu, 14 Mar 2019 02:42:28 +0000 (19:42 -0700)]
Disable tracing/inducedgc test on all Unix platforms (#23240)
* Disabling tracing/tracevalidation/inducedgc test on all unix
* Leave the exclusion list on arm64 there
Sergey Andreenko [Thu, 14 Mar 2019 01:31:27 +0000 (18:31 -0700)]
Fix/clean compNoGCHelperCallKillSet for arm. (#23078)
* Add an assert to compNoGCHelperCallKillSet.
That registers that lose GC or byref values also are in compHelperCallKillSet return set.
* Move compNoGCHelperCallKillSet from compiler to emitter.
* Rename `compNoGCHelperCallKillSet` to `emitGetGCRegsKilledByNoGCCall`.
* Fix GCRegsKill sets for arm CORINFO_HELP_PROF_FCN_ENTER and CORINFO_HELP_PROF_FCN_LEAVE.
Sinan Kaya [Mon, 11 Mar 2019 17:58:42 +0000 (17:58 +0000)]
Choose the SString constructor explicitly
Sinan Kaya [Mon, 11 Mar 2019 18:12:01 +0000 (18:12 +0000)]
signedness conversion
Sinan Kaya [Mon, 11 Mar 2019 17:31:46 +0000 (17:31 +0000)]
fix conversion issues
Brian Sullivan [Thu, 14 Mar 2019 00:33:25 +0000 (17:33 -0700)]
Merge pull request #23109 from briansull/gh-21231
Fix for Issue 21231
dotnet-maestro[bot] [Thu, 14 Mar 2019 00:27:22 +0000 (17:27 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190312.12 (#23227)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19162.12
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19162.12
Levi Broderick [Wed, 13 Mar 2019 22:43:25 +0000 (15:43 -0700)]
Add OperationStatus-based UTF8 transcoding APIs (#23219)
Bruce Forstall [Wed, 13 Mar 2019 22:38:41 +0000 (15:38 -0700)]
Merge pull request #23220 from BruceForstall/FixArm64HfaJmpCallNyi
Arm64: Implement JMP call for HFA register arguments
Brian Sullivan [Thu, 7 Mar 2019 22:20:44 +0000 (14:20 -0800)]
Fix for Issue 21231
When transferring a Zero offset from one GenTree node to another, we need to check if there already is a FieldSeq and append to it.
Added third parameter 'kind' to JitHashTable::Set, and Added enum SetKind
Only allow Set to overwrite an existing entry when kind is set to Overwrite.
Added validation for all calls to JitHashTable::Set
asserting that we don't expect the key to already exist or that we passed Overwrite indicating that we expect to handle it properly.
Added two test cases for Issue 21231
Juan Hoyos [Wed, 13 Mar 2019 21:39:25 +0000 (14:39 -0700)]
Remove fixed sign tool version (#23182)
Juan Hoyos [Wed, 13 Mar 2019 21:38:41 +0000 (14:38 -0700)]
Update documentation: make docker images point to the registry. (#23243)
Carol Eidt [Wed, 13 Mar 2019 21:26:51 +0000 (14:26 -0700)]
Fix SIMD handle issues (#23193)
* Fix SIMD handle issues
PR #23052 was overly aggressive at applying the provided class handle (which defaults to NO_CLASS_HANDLE). In addition, make a small change to `SIMDIntrinsicWiden`, as it doesn't need to go through the complexity of inferring a class handle when it already exists on the node it's duplicating.
Fix #23159
Carol Eidt [Wed, 13 Mar 2019 21:19:17 +0000 (14:19 -0700)]
Merge pull request #23212 from CarolEidt/VectorABITest
Preliminary Vector ABI test
Sergey Andreenko [Wed, 13 Mar 2019 20:08:38 +0000 (13:08 -0700)]
exclude tracing/keyword/TwoKeywords/TwoKeywords on WIndows x86. (#23237)
JC Aguilera [Wed, 13 Mar 2019 19:59:46 +0000 (12:59 -0700)]
Merge pull request #23236 from jcagme/updateOptimizationUrl
Update optimization repo url
juanam [Wed, 13 Mar 2019 19:52:54 +0000 (12:52 -0700)]
Update optimization repo url
Michal Strehovsky [Wed, 13 Mar 2019 12:30:44 +0000 (05:30 -0700)]
Fix missed RelocatedType annotation
[tfs-changeset: 1735855]
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Michal Strehovský [Wed, 13 Mar 2019 18:50:13 +0000 (19:50 +0100)]
Enable FeatureDefaultInterfaces unconditionally (#23225)
Fixes #22940.
Andrew Au [Wed, 13 Mar 2019 16:56:41 +0000 (09:56 -0700)]
Fix issue 23151 (Cleanup TODO introduced by PR #23148)