Charles Yin [Wed, 20 Jul 2011 06:13:31 +0000 (16:13 +1000)]
polish canvas stock chart example
Change-Id: Ie79859af8572c3c79185d98c54c2aae35190d257
Reviewed-on: http://codereview.qt.nokia.com/1908
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Mon, 18 Jul 2011 06:51:55 +0000 (16:51 +1000)]
put all context2d code into context2d directory
Change-Id: I38442c8d2bcb9f2dcaa433b6bcfd7dbc21439f63
Reviewed-on: http://codereview.qt.nokia.com/1907
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Alan Alpert [Tue, 26 Jul 2011 06:47:09 +0000 (16:47 +1000)]
Fix Column/Row size when no items being positioned
Change-Id: I0bf55c13e55856dd7292e5eda159086096dea86b
Reviewed-on: http://codereview.qt.nokia.com/2158
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Martin Jones [Tue, 26 Jul 2011 23:19:47 +0000 (09:19 +1000)]
Document view touch interaction with their content.
Fixes: QTBUG-18601
Change-Id: I9e793fa205d0eb2f2c312a9a73559720a4d4f00a
Reviewed-on: http://codereview.qt.nokia.com/2223
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kent Hansen [Tue, 26 Jul 2011 10:53:00 +0000 (12:53 +0200)]
Don't build V8 as a static library
In the future, we'll need to be able to export the V8
symbols from the QtDeclarative library, which requires
compiling V8 straight in. It's not possible to achieve
this using a static library.
Change-Id: Ie9e31984d2c03639a311cef11ddd33ba0aa15fd9
Reviewed-on: http://codereview.qt.nokia.com/2187
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Martin Jones [Tue, 26 Jul 2011 06:28:19 +0000 (16:28 +1000)]
A long press should allow onClicked if there is no onPressAndHold
Fixes: QTBUG-19726
Change-Id: I896c9264c1cf408dcd533b5d6d463d53c785d787
Reviewed-on: http://codereview.qt.nokia.com/2155
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Michael Brasser [Mon, 25 Jul 2011 06:43:55 +0000 (16:43 +1000)]
Fix crash when assigning a list property to transitions.
This fixes the crash, but doesn't actually assign any
Transitions (the transitions list will now be empty, rather
than contain a null Transition object). Correct assignment
is a general language issue, and will be fixed separately.
Task-number: QTBUG-20227
Change-Id: Ie224d06b1d8bb82d03c5eba378affb7167f08724
Reviewed-by: Alan Alpert
Reviewed-on: http://codereview.qt.nokia.com/2152
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Michael Brasser [Mon, 25 Jul 2011 23:42:46 +0000 (09:42 +1000)]
Cleanup QMLViewer properly when exiting via File->Quit.
Task-number: QTBUG-14972
Change-Id: I9b8738fe0ae94a1bbed7427f137a6ab5c7a8ff86
Reviewed-on: http://codereview.qt.nokia.com/2154
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Martin Jones [Tue, 26 Jul 2011 05:33:58 +0000 (15:33 +1000)]
Add headerItem and footerItem properties to views.
Fixes: QTBUG-19684
Change-Id: Iea7d4a4f902cc45cb0cca8e1221fdb993f0bebd2
Reviewed-on: http://codereview.qt.nokia.com/2151
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Tue, 26 Jul 2011 03:48:45 +0000 (13:48 +1000)]
qmlviewer resizes the root object multiple times.
In SizeRootObjectToView mode on initial load the view was set to
root object size, then the sceneResized() slot would resize back,
then we would finally reset back to the correct value in
statusChanged(true). Now react directly to the initial size being
set.
Change-Id: Ib6977cf7bad3fe79b9ac80bb6d916fb0f57c5f5e
Fixes: QTBUG-16499
Reviewed-on: http://codereview.qt.nokia.com/2148
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Alan Alpert [Tue, 26 Jul 2011 04:21:22 +0000 (14:21 +1000)]
Update PhotoViewer to QtQuick 2.0
Seems to work fine.
Change-Id: I2da6487a6b3a5dc9ce1fb2036450ef0a0588430f
Reviewed-on: http://codereview.qt.nokia.com/2149
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Martin Jones [Tue, 26 Jul 2011 00:34:53 +0000 (10:34 +1000)]
QDeclarativeView/QSGView SizeRootObjectToView still resizes view
Only resize view to object in SizeRootObjectToView if the view
has not had a size set, i.e. at initial construction.
Change-Id: Ic5ad3cbb3b071c3498047be893da2c7bf0957986
Fixes: QTBUG-15863
Reviewed-on: http://codereview.qt.nokia.com/2132
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Alan Alpert [Mon, 25 Jul 2011 07:13:18 +0000 (17:13 +1000)]
Use visible only, and not opacity, in positioners
Task-number: QTBUG-12940
Change-Id: Id637bbd7c30aea8bc23c2aeaccfb069a8de7955f
Reviewed-on: http://codereview.qt.nokia.com/2082
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Tue, 26 Jul 2011 01:47:19 +0000 (11:47 +1000)]
Remove onMousePositionChanged signal.
This signal was meant to be "private" (not directly used from QML).
Provide separate signals for onMouseXChanged and onMouseYChanged.
Task-number: QTBUG-18656
Change-Id: Iefc3d78e270db9c037bbb1b890925b4841f2d5fa
Reviewed-by: Martin Jones
Reviewed-on: http://codereview.qt.nokia.com/2142
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Tue, 26 Jul 2011 01:32:09 +0000 (11:32 +1000)]
Reference resources to prevent crash (on some platforms)
Prevent the data blob from being deleted in done().
Task-number: QTBUG-18268
Change-Id: Ib265e6fc3e1539d0baf20e365c1f88f615b121dc
Reviewed-on: http://codereview.qt.nokia.com/2138
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Tue, 26 Jul 2011 00:44:16 +0000 (10:44 +1000)]
Autotest
Task-number: QTBUG-16878
Change-Id: I0d074c13b32670697f4811060ddf4edbdf6c6451
Reviewed-on: http://codereview.qt.nokia.com/2133
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Mon, 25 Jul 2011 05:01:30 +0000 (15:01 +1000)]
Ouptut non-NOTIFYable warnings again
Task-number: QTBUG-20280
Change-Id: Ia950c8c9dfa14e568a306beeb72474b2d5049db1
Reviewed-on: http://codereview.qt.nokia.com/2069
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 04:11:42 +0000 (14:11 +1000)]
Update polish even when animations aren't running
Task-number: QTBUG-20078
Change-Id: I095a872d72da61248794ec4a2a85f91ee618cdbc
Reviewed-on: http://codereview.qt.nokia.com/2063
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Andrew den Exter [Tue, 26 Jul 2011 00:10:50 +0000 (10:10 +1000)]
Move the cursor position to the end when TextInput.readOnly is cleared.
Improves consistency with TextEdit.
Task-number: QTBUG-18747
Change-Id: Ieb0a332441557fc6ba4c5ddaafea5c634aff1ee4
Reviewed-on: http://codereview.qt.nokia.com/2131
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Yann Bodson [Wed, 20 Jul 2011 02:56:38 +0000 (12:56 +1000)]
Bounding rectangle for image is wrong for PreserveAspectCrop
Task-number: QTBUG-20300
Change-Id: I8aa84ec64f7be536e56cdc1c04a6c2f204e06c26
Reviewed-on: http://codereview.qt.nokia.com/1859
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Yann Bodson [Tue, 26 Jul 2011 02:43:25 +0000 (12:43 +1000)]
Fixes AnimatedImage documentation
Animated images are not cached or shared internally.
Task-number: QTBUG-14847
Change-Id: I0b9362a4ff9299b4c18057fb6f005925386f48d1
Reviewed-on: http://codereview.qt.nokia.com/2143
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Alan Alpert [Mon, 25 Jul 2011 04:13:53 +0000 (14:13 +1000)]
Crash even less
Should not set pointer to zero if we're going to use it again.
Task-number: QTBUG-20407
Change-Id: Iea1ea879bf3fe53e2e8ac8d93648ab28a0fc7b12
Reviewed-on: http://codereview.qt.nokia.com/2064
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Bea Lam [Thu, 21 Jul 2011 05:10:30 +0000 (15:10 +1000)]
Don't error if response results in UnknownContentError
XMLHttpRequest specs state that only 'network errors' should result
in a request error, and a HTTP response like 400 Bad Request (which
results in QNetworkReply::UnknownContentError) is an indication of the
HTTP server response rather than a network error.
Task-number: QTBUG-20146
Change-Id: I10c132788200e15b0362da839689a0bb3c2b4a0d
Reviewed-on: http://codereview.qt.nokia.com/1915
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 07:51:59 +0000 (17:51 +1000)]
Autotest
Task-number: QTBUG-16026
Change-Id: Iafcd0ae99016ea684c162e54da1090417f781790
Reviewed-on: http://codereview.qt.nokia.com/2089
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Andrew den Exter [Mon, 25 Jul 2011 04:50:19 +0000 (14:50 +1000)]
Correct TextInput.PasswordEchoOnEdit documentation.
The documentation incorrectly stated that this mode masked all but
the last character, the actual behavior is as described in the
QLineEdit documentation.
Task-number: QTBUG-20003
Change-Id: I8a89a6818c930125821435bc04121340968dfbb2
Reviewed-on: http://codereview.qt.nokia.com/2067
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 07:40:57 +0000 (17:40 +1000)]
Set classname for cloned extension meta objects
Task-number: QTBUG-16273
Change-Id: I33c6e2985caba8e506312ddb9007aaea3d00befd
Reviewed-on: http://codereview.qt.nokia.com/2087
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 06:24:01 +0000 (16:24 +1000)]
Reverse lookup ids by object pointer
Task-number: QTBUG-18554
Change-Id: Ia4effb629d19aa36b835f6c09a63d9495e5c26e7
Reviewed-on: http://codereview.qt.nokia.com/2079
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Andrew den Exter [Mon, 25 Jul 2011 03:17:35 +0000 (13:17 +1000)]
Scroll correctly when cursorPosition is changed within onTextChanged.
Emit textChanged() before adjusting size and scroll positions otherwise
the calculations will be based on the cursor position before it's moved
in handler and because the cursor position won't ultimately have changed
there won't be a follow up cursorPositionChanged() signal to trigger a
second set of calculation.
Task-number: QTBUG-19912
Reviewed-by: Martin Jones
(cherry picked from commit
bb11b53bedb8e239b9439b4a3fc3320e35c2de57)
Conflicts:
src/declarative/graphicsitems/qdeclarativetextinput.cpp
Change-Id: I579bc3fe6c80766dfadfbc9dbd46144607bf7b03
Reviewed-on: http://codereview.qt.nokia.com/2058
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 06:03:57 +0000 (16:03 +1000)]
Use engine where appropriate in QDeclarativeProperty
Task-number: QTBUG-14697
Change-Id: Id15def75271666699b1fe23e39991710afebff59
Reviewed-on: http://codereview.qt.nokia.com/2077
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Mon, 25 Jul 2011 05:07:42 +0000 (15:07 +1000)]
Only manage opacity when m_fade is true
In all cases, visualize lifecycle with 'visible' property instead.
Task-number: QTBUG-20438
Change-Id: Ib0b732708e14ad043c5b673205eaec0467e38174
Reviewed-on: http://codereview.qt.nokia.com/2071
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 05:47:40 +0000 (15:47 +1000)]
Allow object to be accessed by multiple QDeclarativeEngines
Task-number: QTBUG-18610
Change-Id: Idd9444018b5344586d6579ddac6a0ffd26bf7139
Reviewed-on: http://codereview.qt.nokia.com/2075
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 03:52:49 +0000 (13:52 +1000)]
Allow static alias to composite type
Task-number: QTBUG-20200
Change-Id: I2a118dfc9ce1956e038f70049c905ec38396fe5e
Reviewed-on: http://codereview.qt.nokia.com/2062
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Martin Jones [Mon, 25 Jul 2011 03:21:25 +0000 (13:21 +1000)]
Handle pinch correctly when one point is released and repressed.
The pinch is not finished at the time one point is released. Ensure
that a onPinchStarted is called each time a repress happens, and
that onPinchFinished is called when all points are released.
Fixes: QTBUG-19632
Change-Id: I467dd612383f7dd11d58a9df063dd86860796216
Reviewed-on: http://codereview.qt.nokia.com/2059
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 03:35:03 +0000 (13:35 +1000)]
Support better boolean conversion semantics
Task-number: QTBUG-20242
Change-Id: Ie678f6189a8060de600b5394fbaaaef49be274c6
Reviewed-on: http://codereview.qt.nokia.com/2061
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Bea Lam [Mon, 18 Jul 2011 04:14:43 +0000 (14:14 +1000)]
Fix unstable GridView test
Change-Id: I1e1f1afe38cced3c85b3e20d37e9859b8304e69c
Reviewed-on: http://codereview.qt.nokia.com/1729
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Aaron Kennedy [Mon, 25 Jul 2011 03:14:24 +0000 (13:14 +1000)]
Check objects can be passed as signal parameters
Task-number: QTBUG-12457
Change-Id: I2d78c8885e488e51364fe4f2a30bde36fa78636a
Reviewed-on: http://codereview.qt.nokia.com/2057
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 03:06:28 +0000 (13:06 +1000)]
Correctly load flags for binding properties
Change-Id: I80e79ff7de8d879f700f9f4fe96d796de0f17aff
Reviewed-on: http://codereview.qt.nokia.com/2055
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Andrew den Exter [Mon, 25 Jul 2011 02:55:57 +0000 (12:55 +1000)]
Notify when the TextInput cursorRectangle property changes within pre-edit
Apply
452e13b5407fa4c36f9a573c305d41f551762b93 to scene graph items.
Task-number: QTBUG-19089
Change-Id: I4501bdc940cbac9ba2ef068b87ded83b1c86976f
Reviewed-on: http://codereview.qt.nokia.com/2054
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Aaron Kennedy [Tue, 12 Jul 2011 05:09:18 +0000 (15:09 +1000)]
Don't assert on incorrect file url
Exceptions thrown from within a QObject method have the same special
origin "string" that we use to identify QObject function objects as
QObject function objects. Until we can modify this, or switch to
function objects in a later V8, we can't get correct source information
for these exceptions.
Task-number: QTBUG-20344
Change-Id: I02aa2d81ac78c2951d7ea714f33612160ded2476
Reviewed-on: http://codereview.qt.nokia.com/1475
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 25 Jul 2011 02:40:20 +0000 (12:40 +1000)]
Enter context scope
Task-number: QTBUG-20485
Change-Id: Ifc7fa998a253b01d8114d00d537faca5df5c93c9
Reviewed-on: http://codereview.qt.nokia.com/2053
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Casper van Donderen [Thu, 14 Jul 2011 09:15:36 +0000 (11:15 +0200)]
Documentation fix.
Fixes: QTBUG-20390
Change-Id: I30a4b4d1618f80c9a1246955a9b1d6c9f8fbfd57
Reviewed-on: http://codereview.qt.nokia.com/1655
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Bea Lam [Mon, 18 Jul 2011 03:29:18 +0000 (13:29 +1000)]
Fix layout bug from view refactoring
GridView should call layout() not layoutVisibleItems() in
setCellWidth(), setCellHeight() and itemsMoved()
Bug introduced when refactoring view code into QSGItemView.
Change-Id: I48bc63c0a08c10c005bf45a2a7902cb01632cbf9
Reviewed-on: http://codereview.qt.nokia.com/1726
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Aaron Kennedy [Thu, 14 Jul 2011 04:46:23 +0000 (14:46 +1000)]
Update V8
Fixes a bug in threadsafe symbol id generation, and adds a ComputeHash
implementation for const char * strings.
Change-Id: Id1fb4c7d9bf8eae59229b3893e8a9ef20dede336
Reviewed-on: http://codereview.qt.nokia.com/1621
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Kim Motoyoshi Kalland [Thu, 21 Jul 2011 08:49:44 +0000 (10:49 +0200)]
Compile fix.
Change-Id: Ie6e1f814b6791ddc2b02a845ebd8bc20765f7193
Reviewed-on: http://codereview.qt.nokia.com/1941
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Christiaan Janssen [Tue, 19 Jul 2011 16:07:46 +0000 (18:07 +0200)]
Qml Debugging: only read properties that can be displayed in the debugger
Change-Id: I68a6636aae271924bcec31ce7ad76c01fc43080b
Task-number: QTCREATORBUG-5075
Reviewed-on: http://codereview.qt.nokia.com/1893
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Bea Lam [Thu, 14 Jul 2011 03:55:20 +0000 (13:55 +1000)]
Always position headers at a negative position
Previously headers were either positioned at 0 if there were no items in
the view, or at (0 - headerSize) if items were present. With this fix
they are always positioned at (0 - headerSize) to be consistent.
Due to the change, setPosition(-headerSize()) is now called from
componentCompleted() to ensure the header is visible.
This change also fixes GridView's header and footer positioning in
TopToBottom + RightToLeft mode.
Also added extra tests for header and footer positioning and fixed
incorrect test value in tst_QSGGridView::positionViewAtIndex() (was 460
instead of 430 because previously rowPosAt() always added the header
size, so if positionViewAtIndex() jumped past all visible items and
caused them to be released, the new items started at +headerSize()
instead of 0).
Change-Id: I1015bed457d4ae964a7fb13702e2dfc470a168a9
Reviewed-on: http://codereview.qt.nokia.com/1618
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Thu, 14 Jul 2011 23:02:55 +0000 (09:02 +1000)]
Bulk update of QtQuick 1 docs to \qmlmodule syntax
Change-Id: I7ed2b54ef5a706dcaf7e19d221a6dda7b2620e8c
Reviewed-on: http://codereview.qt.nokia.com/1681
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Bea Lam [Wed, 13 Jul 2011 03:46:57 +0000 (13:46 +1000)]
Make lastPosition() result consistent among GridView and ListView
lastPosition() returns the end position of the last item so it should
always include a -1 calculation for the last item (as
FxListItemSG::endPosition() and FxGridItemSG::endPosition() do) to get
the last edge pixel of the item. With this fix, both views now
calculate startPosition() and endPosition() in the same way.
This also fixes positioning of GridView items in TopToBottom+RightToLeft
layouts. Incorrect test values in positionViewAtIndex_rightToLeft()
test are fixed (the last edge of a 1-pixel border shouldn't be visible,
since the bottom edge of a 1-pixel border is actually drawn outside,
not inside, the Rectangle).
Change-Id: I253c3836f871c61e13c08f67007ebc75e09378d6
Reviewed-on: http://codereview.qt.nokia.com/1547
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Simon Hausmann [Wed, 20 Jul 2011 08:50:21 +0000 (10:50 +0200)]
Fix memory leaks with QV8Engine's ExtensionData
The destructor has to be virtual for Deletable in order to call
the destructor of the super-class.
Change-Id: I3aeebe28c0a6bbfbbe3b069e88a6096dd9e173f5
Reviewed-on: http://codereview.qt.nokia.com/1867
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Charles Yin [Fri, 15 Jul 2011 06:31:06 +0000 (16:31 +1000)]
add font support for context2d
Change-Id: I77a7af006e1c0264365ae6d93bf78416f8b38a62
Reviewed-on: http://codereview.qt.nokia.com/1686
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Wed, 13 Jul 2011 07:07:06 +0000 (17:07 +1000)]
more on canvas stock chart example.
Change-Id: I7e92414d397b8a0bfdd514c9045677cd00422263
Reviewed-on: http://codereview.qt.nokia.com/1627
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Bea Lam [Thu, 14 Jul 2011 06:29:05 +0000 (16:29 +1000)]
Add isEmpty() method
Change-Id: Ia0eadcd20b2f14433a7e3a89d97d7a21ec353aa5
Reviewed-on: http://codereview.qt.nokia.com/1628
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Bea Lam [Tue, 5 Jul 2011 05:07:05 +0000 (15:07 +1000)]
Refactor ListView and GridView implementations
Places common code into QSGItemView.
Change-Id: Ic310dbe7e16774163ba393860da64a0da7d4ea0a
Reviewed-on: http://codereview.qt.nokia.com/1200
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Alan Alpert [Fri, 1 Jul 2011 06:12:23 +0000 (16:12 +1000)]
Hook up durationVariation on Sprites
Change-Id: I11ea38fc87373604debd469e03af3447b8adcecb
Reviewed-on: http://codereview.qt.nokia.com/985
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Mon, 11 Jul 2011 01:20:58 +0000 (11:20 +1000)]
Initial stab at docs for QtQuick.Particles 2.0
Change-Id: I3c53f7998dff95616a994edf19094fa4007d74ab
Reviewed-on: http://codereview.qt.nokia.com/1388
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Thu, 7 Jul 2011 07:24:18 +0000 (17:24 +1000)]
Remove traces of webkit
Removes the entire wince section for qmlviewer.pro, as wince is not yet
supported for qt5 and its unclear what damage removing the webkit part
would have done to it.
Change-Id: Ib0c721856bb7a28c3238e85c8cc93b43e6e63368
Reviewed-on: http://codereview.qt.nokia.com/1267
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Kim Motoyoshi Kalland [Tue, 19 Jul 2011 10:14:39 +0000 (12:14 +0200)]
Renamed the Bindable class to QSGBindable.
Change-Id: Id00868bd0ea93010912f06fba67624fb325ecc41
Reviewed-on: http://codereview.qt.nokia.com/1818
Reviewed-by: Kim M. Kalland <kim.kalland@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Kim Motoyoshi Kalland [Thu, 14 Jul 2011 13:55:29 +0000 (15:55 +0200)]
Improved the performance of distance-field generation.
Change-Id: Ie17650196c7e4531cbc6f760905e41d95808efcd
Reviewed-on: http://codereview.qt.nokia.com/1675
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Yoann Lopes [Mon, 18 Jul 2011 11:17:46 +0000 (13:17 +0200)]
Fixed QSGDistanceFieldGlyphNode initialization order.
Change-Id: Id2e8ccf6441ce7e7a2bcdd6f0d50745e7d9ba653
Reviewed-on: http://codereview.qt.nokia.com/1750
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yoann Lopes <yoann.lopes@nokia.com>
Charles Yin [Wed, 20 Jul 2011 01:28:26 +0000 (11:28 +1000)]
fix qmltest bugs
Change-Id: If814516b1094b85fba46e215b44e1a2b582179c5
Reviewed-on: http://codereview.qt.nokia.com/1858
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Alan Alpert [Thu, 14 Jul 2011 22:14:39 +0000 (08:14 +1000)]
Crash less
Can't run any particles without a system set. Just skip the
'prepareFrame' function in that case.
Task-Number: QTBUG-20386
Change-Id: I22332636084d1696d5aff5386a5ca4ff0f2f1866
Reviewed-on: http://codereview.qt.nokia.com/1680
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Thu, 14 Jul 2011 08:46:09 +0000 (18:46 +1000)]
Export qmlRegisterTypeNotAvailable (used by libqtquick1)
Change-Id: Iec7eba4bb8db97d5df486e512e8767a23b25c47b
Reviewed-on: http://codereview.qt.nokia.com/1647
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Oswald Buddenhagen [Mon, 18 Jul 2011 14:08:51 +0000 (16:08 +0200)]
make debug_and_release setting statement consistent with qt_module_config
Change-Id: I2e3e7a40e6bf8701715e7d7068ba7d47138e8d6c
Reviewed-on: http://codereview.qt.nokia.com/1784
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Marius Storm-Olsen [Tue, 19 Jul 2011 15:13:11 +0000 (15:13 +0000)]
Don't use QT_BUILD_TREE anymore
It's only valid in QtBase now, and even there one should not use it.
Change-Id: Ie3dae869b6523f6e2ef727771ae98e9b3f4678c3
Reviewed-on: http://codereview.qt.nokia.com/1838
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Marius Storm-Olsen [Tue, 19 Jul 2011 15:06:22 +0000 (15:06 +0000)]
Don't use CONFIG -= explicitlib as it messes up the PRL system
Change-Id: I75245d0eb21b2b612fd9c7f27a0eb86476e8ff8c
Reviewed-on: http://codereview.qt.nokia.com/1837
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Rohan McGovern [Tue, 19 Jul 2011 06:06:52 +0000 (16:06 +1000)]
Fixed compile (for certain configurations)
This project tried to use libQtTest, but omitted `QT+=testlib'.
In most configurations, this didn't matter, because:
- for includes, QtQuickTest has copied the content of some QtTest
headers, instead of #including them, so the bad INCLUDEPATH went
unnoticed
- for libraries, libQtTest would be pulled in implicitly either via
.prl files or via the system's linker, so the bad LIBS went
unnoticed
Change-Id: Ie3286718789758bfb80f6832aac7c08bdd85212a
Reviewed-on: http://codereview.qt.nokia.com/1812
Reviewed-by: Jonni Rainisto <jonni.rainisto@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Christian Kamm [Thu, 14 Jul 2011 07:04:17 +0000 (09:04 +0200)]
qmldump: Fix creation of objects from QDeclarativeTypes.
Previously, the import statement was not necessarily set up correctly
for the type we wanted to instantiate. We simply use
QDeclarativeType::create now and thus can skip finding the right import.
Mirrors qtcreator/
f326bd067d455e979b5d83195e19581a9e2fd494
Mirrors qt4.8/
bdbc3ff0a32bb37a32dc4825413e60f9d75e5007
Change-Id: Ic9e652b341854941c0e6a51f49f23dfaae4f87d7
Reviewed-on: http://codereview.qt.nokia.com/1648
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Michael Brasser [Mon, 18 Jul 2011 23:36:07 +0000 (09:36 +1000)]
Fix QSGItem transforms.
If a complex transform exists, it needs to be applied whenever there
are relevant changes (TransformUpdateMask), and not just when the
transform changes (ComplexTransformUpdateMask).
Change-Id: I395f6bed02a671b23dcb5d4ccb3be204d4bafd82
Reviewed-on: http://codereview.qt.nokia.com/1793
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Yann Bodson [Fri, 15 Jul 2011 04:28:57 +0000 (14:28 +1000)]
Add documentation for QSGImage
Change-Id: I1cfae5fb57025372789391632bac4cb97b8450dc
Reviewed-on: http://codereview.qt.nokia.com/1684
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Yann Bodson [Tue, 5 Jul 2011 03:06:54 +0000 (13:06 +1000)]
Improvements to Image element
- add Image.Pad as a fillMode
- add horizontal and vertical alignment properties
Task-number: QTBUG-18291
Change-Id: Iaaf3b2d02c47ad01d2c8b49d146f1a9401b2558d
Reviewed-on: http://codereview.qt.nokia.com/1468
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Michael Brasser [Mon, 18 Jul 2011 22:57:41 +0000 (08:57 +1000)]
qsgitem2 autotest fixes.
Change-Id: I7b15427af4f829e21b0a1266a70edc36b104f674
Reviewed-on: http://codereview.qt.nokia.com/1792
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Michael Brasser [Tue, 19 Jul 2011 07:24:56 +0000 (17:24 +1000)]
Fix qdeclarativexmlhttprequest autotest.
Updated test to expect deflate support after
2b5dcfcee118265ef7930cc7c5c16bff22d580fd in qtbase.
Change-Id: Ia2c98aecf7de6f1e12396b6e9adb27a322b0b283
Reviewed-on: http://codereview.qt.nokia.com/1815
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Christian Kamm [Thu, 7 Jul 2011 12:07:45 +0000 (14:07 +0200)]
qmlplugindump: Place executable in QT_BUILD_TREE/bin.
Change-Id: I751e8186aeaa2b87046cbe50c690cb0a312f71c5
Reviewed-on: http://codereview.qt.nokia.com/1306
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Charles Yin [Tue, 12 Jul 2011 06:49:15 +0000 (16:49 +1000)]
Add stock chart example for canvas item
Change-Id: I72aacfcb72b90d4d18f95cef3038a169c991a336
Reviewed-on: http://codereview.qt.nokia.com/1480
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Aaron Kennedy [Tue, 12 Jul 2011 06:46:09 +0000 (16:46 +1000)]
Enable support for QObject based module APIs
Task-number: QTBUG-17318
Change-Id: Ia887f563b337b1c34ff65a0559bb7f33c18b4e28
Reviewed-on: http://codereview.qt.nokia.com/1479
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Martin Jones [Mon, 11 Jul 2011 03:47:51 +0000 (13:47 +1000)]
Extract all QtQuick 1 elements into a separate library/plugin.
Change-Id: I41a280de2739ee08202f4be2519e5012870090f2
Reviewed-on: http://codereview.qt.nokia.com/1391
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Charles Yin [Mon, 11 Jul 2011 23:21:27 +0000 (09:21 +1000)]
Rewrite the canvas item's paint logic.
1. Only allow the context API calls inside onPaint() slot function,
makes the context2d handle invalid when out of scope.
2. requestPaint() method supports region parameter
3. Emit paint() signal in updatePolish() function to allow
threaded scene graph rendering work properly with context2d api
4. Allow request painting mutiple dirty regions between 2 frames.
5. Add svgpath for context2d
Change-Id: I5ec48f7c0eb6820d5c9c16a8d0dcc0aae8d0fd2f
Reviewed-on: http://codereview.qt.nokia.com/1465
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Samuel Rødal [Mon, 11 Jul 2011 10:35:43 +0000 (12:35 +0200)]
Fixed rendering errors in complex particle system.
We need to set the texture unit of the texture uniform as well, and we
might as well set all the texture units in initialize() since they're
constant.
Change-Id: Ifcc690351ec7d1db1d98ab74644e248ec43cd328
Reviewed-on: http://codereview.qt.nokia.com/1410
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kim M. Kalland <kim.kalland@nokia.com>
Casper van Donderen [Mon, 4 Jul 2011 10:32:16 +0000 (12:32 +0200)]
Remove references to demos.
Change-Id: I21f935b6de8bdf6a5205f6048cdabf97e16b613a
Reviewed-on: http://codereview.qt.nokia.com/1060
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Samuel Rødal [Fri, 8 Jul 2011 10:18:04 +0000 (12:18 +0200)]
Fixed build of declarative against v8 on a x86_64 machine.
Change-Id: I3a8ca97e8f50754542af142e07bdeb6cb7d6f0de
Reviewed-on: http://codereview.qt.nokia.com/1362
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jocelyn Turcotte
Reviewed-by: <jedrzej.nowacki@nokia.com>
Aaron Kennedy [Fri, 8 Jul 2011 05:56:48 +0000 (15:56 +1000)]
Merge branch 'v8'
Conflicts:
src/declarative/qml/qdeclarativescarceresourcescriptclass.cpp
src/declarative/qml/qdeclarativescarceresourcescriptclass_p.h
Change-Id: I54e579307cbeafbbad21884218c5e797ba245c8b
Jyri Tahtela [Thu, 7 Jul 2011 12:52:03 +0000 (15:52 +0300)]
Update licenseheader text in source files for qtdeclarative Qt module
Replace old license header with correct one.
Change-Id: I492ddaaa0227b2c8faf11bdcd6e12e7231a54a10
Reviewed-on: http://codereview.qt.nokia.com/1312
Reviewed-by: Jyri Tahtela <jyri.tahtela@nokia.com>
Lars Knoll [Mon, 27 Jun 2011 21:00:28 +0000 (23:00 +0200)]
Replace the QGraphicsSceneHoverEvent with a QHoverEvent
One step towards getting rid of the remaining graphics view
dependencies
Change-Id: Ieeb84fc115c96393fdee453615a424679dc48177
Reviewed-on: http://codereview.qt.nokia.com/1139
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Alan Alpert [Tue, 5 Jul 2011 05:16:55 +0000 (15:16 +1000)]
Fix possible index out of bounds exception
The sprite engine count needs to grow to the same size as the system
index count, as the indexes are synchronized.
Change-Id: I299816bfe6ea437202a60078a512b8f1114cfea3
Reviewed-on: http://codereview.qt.nokia.com/1138
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Tue, 5 Jul 2011 10:38:46 +0000 (20:38 +1000)]
Update sync.profile dependencies to new syntax
%dependencies now has a simpler format of gitmodule => gitref instead of
using qt modules and keywords.
Change-Id: I8961a7f918b44176f55852de57d2effae016ebaa
Reviewed-on: http://codereview.qt.nokia.com/1159
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Casper van Donderen [Mon, 4 Jul 2011 10:11:38 +0000 (12:11 +0200)]
Move the demos to the examples folder.
Change-Id: I094383099bf116357a3bb6eed0052d6d14408558
Reviewed-on: http://codereview.qt.nokia.com/1059
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 04:19:01 +0000 (14:19 +1000)]
Remove unused fields
Change-Id: I344beb3a01de5b7573a10f4709f334ac64677ad2
Reviewed-on: http://codereview.qt.nokia.com/1131
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Tue, 5 Jul 2011 03:46:30 +0000 (13:46 +1000)]
Register QDeclarativeV8Handle during construction
Otherwise it sometimes works, sometimes doesn't depending on whether
it was registered by a side effect.
Change-Id: Iaf62bcb0a92a7bc8f8858f38e2fe17ab53a733af
Reviewed-on: http://codereview.qt.nokia.com/1130
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Lars Knoll [Thu, 30 Jun 2011 08:53:50 +0000 (10:53 +0200)]
Use QWheelEvent instead of QGraphicsSceneWheelEvent
Since WheelEvent is not floating point based, we can
use it instead of the graphics scene event.
Change-Id: Ifa8411ca9c3a986ea311c8741f60213637b7c6ae
Reviewed-on: http://codereview.qt.nokia.com/1140
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Aaron Kennedy [Tue, 5 Jul 2011 03:01:50 +0000 (13:01 +1000)]
Correct handling of QObject* and QWidget* properties
Change-Id: I28eb68bc0236d5f7a7f9cc178462c3ad6055924e
Reviewed-on: http://codereview.qt.nokia.com/1128
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Yann Bodson [Wed, 6 Jul 2011 04:32:37 +0000 (14:32 +1000)]
Fix QSGBorderImage autotests
Change-Id: I6dd87232fc3d12a0ea3b8c25932d2ca01879fb3b
Reviewed-on: http://codereview.qt.nokia.com/1196
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Yann Bodson [Wed, 6 Jul 2011 03:39:23 +0000 (13:39 +1000)]
Fix QSGImage autotests
Change-Id: I05b7bd4ad98c952ef4d536b987e6afd589a729fb
Reviewed-on: http://codereview.qt.nokia.com/1194
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Christian Kamm [Tue, 5 Jul 2011 11:48:03 +0000 (13:48 +0200)]
qmlplugindump: Update qmltypes file format documentation.
(cherry picked from commit
bdae42967cd7fa9eb0182e1f25c1e743f35835f7)
Change-Id: Ia83eb42ad11f937b2977a53ee0f89c2e1b157278
Reviewed-on: http://codereview.qt.nokia.com/1164
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Alan Alpert [Mon, 4 Jul 2011 08:15:28 +0000 (18:15 +1000)]
Squashed Particle System Stateful Rewrite
Add TargetAffector
Fix for ParticlePainter offsets
Adds a particleStates property to ParticleSystem
Augment SpriteGoal to change system states as well
Also add 'collidingParticles' list to affector.
Particle Stochastic States Now actually working, and you can put
emitters, affectors and painters inside their targeted state.
Fireworks example uses states instead of delegates.
Replaced the delegate example with a text thing.
The examples launcher now also contains all the custom examples.
Adds CumulativeDirection and working null Affector (for affected
signal).
Add spaces after all flow control keywords.
Change-Id: I77b7e3044a9800dbfff6db833914d63127602cf5
Reviewed-on: http://codereview.qt.nokia.com/968
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 03:52:57 +0000 (13:52 +1000)]
Implement translation functions for V8
Change-Id: Ida84754969a355e7915233393a552655896ad359
Reviewed-on: http://codereview.qt.nokia.com/1028
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 03:27:59 +0000 (13:27 +1000)]
Remove ASCII cache from QStringHash
Now that we have symbol ids, we struggle to recover the time spent
creating the ascii hash. We can reintroduce it if we need to.
Change-Id: Icb2adac6bbe69f94050e57418b7a8a7bfdb7e221
Reviewed-on: http://codereview.qt.nokia.com/1027
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 02:41:21 +0000 (12:41 +1000)]
Optimize QDeclarativePropertyCache
The creation of QDeclarativePropertyCaches contributes significantly
to the initial compile time of a QML app.
Change-Id: Iac5d1578155dfa4678a0e21eab51f4c1675762a9
Reviewed-on: http://codereview.qt.nokia.com/1026
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 01:57:47 +0000 (11:57 +1000)]
Don't exceed SMI bounds
If we use an integer that is greater than the maximum SMI value on
32-bit systems (like ARM), v8 allocates the integer as a HeapNumber
which is unbelievably slower.
Change-Id: I518b5947627631a2621344b656afa0dde002fe82
Reviewed-on: http://codereview.qt.nokia.com/1025
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 4 Jul 2011 01:41:43 +0000 (11:41 +1000)]
Compile
Change-Id: I3bc97df3cb768bcfba6581a291c6a8136cec8a92
Reviewed-on: http://codereview.qt.nokia.com/1024
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Mon, 4 Jul 2011 04:51:24 +0000 (14:51 +1000)]
Avoid crash on exit
QSParticlePainter could call QSGItem::mapFromItem while the scene was
being destroyed.
Change-Id: If9356dae6aadf97b853c2aaf51870751bbbab711
Reviewed-on: http://codereview.qt.nokia.com/1023
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones
projects / profile / ivi / qtdeclarative.git / log