Brian Osman [Fri, 14 Oct 2016 20:48:17 +0000 (16:48 -0400)]
Fix bad test that was asserting on Vulkan Win10 bot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3504
Change-Id: Ifd1280402e6701e940c325654a8e9968b1b42065
Reviewed-on: https://skia-review.googlesource.com/3504
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Mike Klein [Fri, 14 Oct 2016 18:04:56 +0000 (14:04 -0400)]
GN/Win: Vulkan support, convert -Vulkan bots.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Release-Vulkan-Trybot;master.client.skia:Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Release-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3421
Change-Id: I7012719fff66778488589ab9c15fd2fa2a109cd1
Reviewed-on: https://skia-review.googlesource.com/3421
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Brian Salomon [Fri, 14 Oct 2016 15:30:51 +0000 (11:30 -0400)]
Capture ES3 MSAA blit restrictions using BlitFramebufferSupport not MSFBOType.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3416
Change-Id: I2baeb954bceb9d92e43e585320ae5fda1b996641
Reviewed-on: https://skia-review.googlesource.com/3416
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Brian Salomon [Fri, 14 Oct 2016 19:41:54 +0000 (15:41 -0400)]
Disable ANGLE GL backed on windows perf bots
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3501
Change-Id: I0e3a166cd07560501cb350b780e264c274c81601
Reviewed-on: https://skia-review.googlesource.com/3501
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
ethannicholas [Fri, 14 Oct 2016 19:14:46 +0000 (12:14 -0700)]
another SkSL crash fix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2420163002
Review-Url: https://codereview.chromium.org/
2420163002
Matt Sarett [Fri, 14 Oct 2016 17:04:55 +0000 (13:04 -0400)]
Refactor color_xform_RGBA() to improve performance
Now that we've identified this as the "fast path", it has
become (somewhat) stable, and I'm ready to ship it, I feel
comfortable playing games with clang to get the behavior
we want.
toSRGB Performance on HP z620:
Before: 370us or 470us (depending on the mood of my computer)
After: 345us (or better, always)
My guess is that clang optimizers do a better job of interleaving
instructions effectively when we put everything into one function.
Regardless of being silly about performance, I also acutally
prefer how the code reads this way.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3440
Change-Id: Id7a40fb9966341ab184a5331b3e4da19b3af3344
Reviewed-on: https://skia-review.googlesource.com/3440
Commit-Queue: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
borenet [Fri, 14 Oct 2016 17:11:44 +0000 (10:11 -0700)]
Revert of Presubmit recipe: commit the patch (patchset #3 id:40001 of https://codereview.chromium.org/
2398653002/ )
Reason for revert:
Instead of trying to run the presubmit for try jobs and at every commit, let's do it only for try jobs, which worked fine without this CL.
Original issue's description:
> Presubmit recipe: call presubmit_support.py directly
>
> For some reason, presubmit_support.py can't find PRESUBMIT.py
> unless it has a diff. Calling this script directly allows us
> to specify a fake upstream to force it to find a diff and
> therefore be able to find PRESUBMIT.py.
>
> BUG=skia:5823
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2398653002
>
> Committed: https://skia.googlesource.com/skia/+/
c1c7c21fdd2793b2c03b8ffc06461a00c4241a18
TBR=rmistry@google.com,borenet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:5823
Review-Url: https://codereview.chromium.org/
2414133003
ethannicholas [Fri, 14 Oct 2016 16:56:33 +0000 (09:56 -0700)]
more SkSL fuzzer crash fixes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2414413002
Review-Url: https://codereview.chromium.org/
2414413002
Brian Osman [Fri, 14 Oct 2016 15:42:20 +0000 (11:42 -0400)]
Always use RGBA textures for color font atlases
This is the last use of kSkiaGamma8888_GrPixelConfig
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3417
Change-Id: I307479c41f1ca437733dfafd044bb1baeb42f31d
Reviewed-on: https://skia-review.googlesource.com/3417
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
ethannicholas [Fri, 14 Oct 2016 15:37:32 +0000 (08:37 -0700)]
fix skslc crashes uncovered by fuzz testing
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2413423003
Review-Url: https://codereview.chromium.org/
2413423003
fmalita [Fri, 14 Oct 2016 15:18:24 +0000 (08:18 -0700)]
Faster 4f gradient premul path
Similar to https://codereview.chromium.org/
2409583003/, perform the
premul in 4f. It turns out it's even faster to avoid the 255 load
multiplication in this case.
Also includes some template plumbing because DstTraits<>::load now needs
to be premul-aware (previously it wasn't).
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2416233002
Review-Url: https://codereview.chromium.org/
2416233002
bsalomon [Fri, 14 Oct 2016 15:13:48 +0000 (08:13 -0700)]
Explicit control in tools of ANGLE frontend and backend
Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend.
This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends.
Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends).
BUG=skia:5804
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2381033002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot
Review-Url: https://codereview.chromium.org/
2381033002
Brian Osman [Fri, 14 Oct 2016 13:16:21 +0000 (09:16 -0400)]
Remove many uses of kSkia8888 and kSkiaGamma8888
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3405
Change-Id: Ie920f4bcbb3dd28114a66f2363643bb10009b840
Reviewed-on: https://skia-review.googlesource.com/3405
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Brian Salomon [Fri, 14 Oct 2016 14:03:36 +0000 (10:03 -0400)]
Update CQ_INCLUDE_TRYBOTS examples in docs to actually be "real world"
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3409
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3409
Change-Id: I5f524b2d04822dd9780302fae9bd064d81f10c6c
Reviewed-on: https://skia-review.googlesource.com/3409
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
bungeman [Thu, 13 Oct 2016 21:36:40 +0000 (17:36 -0400)]
Move skdiff tool and add to gn build.
I really wanted this today, so I got it working again.
Change-Id: I1a37d48d4806198b55c59d1df5ff15a03500195f
Reviewed-on: https://skia-review.googlesource.com/3383
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Matt Sarett [Thu, 13 Oct 2016 22:24:20 +0000 (18:24 -0400)]
Add NewRGB() with float gamma to SkColorSpace public API
Necessary because PNGs like to specify their gamma this way.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3402
Change-Id: I399984d611db907b115b345df1afc88d39326fbb
Reviewed-on: https://skia-review.googlesource.com/3402
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Greg Daniel [Fri, 14 Oct 2016 13:12:53 +0000 (09:12 -0400)]
Add support for Atrace and hook into SkEventTracer framework.
This change is a different version of:
https://skia-review.googlesource.com/c/3269/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3345
Change-Id: I49d4f2987740d3ad1307f6aba3add0d63a46b22d
Reviewed-on: https://skia-review.googlesource.com/3345
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@google.com>
ethannicholas [Fri, 14 Oct 2016 13:40:02 +0000 (06:40 -0700)]
added SkSL support for mustForceNegatedAtanParamToFloat cap
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2413363002
Review-Url: https://codereview.chromium.org/
2413363002
borenet [Fri, 14 Oct 2016 13:32:09 +0000 (06:32 -0700)]
Add infra_tests.py, recipe, buildbotless bot
Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2415193002
Review-Url: https://codereview.chromium.org/
2415193002
Hal Canary [Thu, 13 Oct 2016 19:30:11 +0000 (15:30 -0400)]
experimental: xps_to_png program (windows only)
BUG=skia:409
NOTRY=true
Change-Id: Ib0df603535de71b0a324808c17e47691435df666
Reviewed-on: https://skia-review.googlesource.com/3342
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Mike Klein [Thu, 13 Oct 2016 21:18:04 +0000 (17:18 -0400)]
GN/Win: hook in GPU support
Just a simple oversight... this should make Ganesh work.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3382
Change-Id: I90353732a137d004b884cea75f1bd722ede24888
Reviewed-on: https://skia-review.googlesource.com/3382
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Thu, 13 Oct 2016 19:45:07 +0000 (15:45 -0400)]
GN/Win: suppport GDI, convert GDI bots to build with GN.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-GDI-Trybot,Build-Win-MSVC-x86-Release-GDI-Trybot;master.client.skia:Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3324
Change-Id: I3ff2f5d16de9fff7ed77fa5127b96bef55bef957
Reviewed-on: https://skia-review.googlesource.com/3324
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Thu, 13 Oct 2016 20:08:36 +0000 (16:08 -0400)]
Slightly generalize GPU hard stop gradient implementation.
With this CL we handle single off-center hardstop gradients.
BUG=chromium:543625
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3303
Change-Id: Ic754e87469475ce15865c54055b8ed492e1d826d
Reviewed-on: https://skia-review.googlesource.com/3303
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
ethannicholas [Thu, 13 Oct 2016 20:25:34 +0000 (13:25 -0700)]
added basic dataflow analysis to skslc
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2405383003
Review-Url: https://codereview.chromium.org/
2405383003
junov [Thu, 13 Oct 2016 20:14:27 +0000 (13:14 -0700)]
Allow F16 color type on direct raster canvases
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2416063002
Review-Url: https://codereview.chromium.org/
2416063002
Mike Klein [Thu, 13 Oct 2016 18:18:09 +0000 (14:18 -0400)]
remove SkError
It has not caught on.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3321
Change-Id: Ib2ee4ef99bc89c8f4b7504e42a9d7d9dfc483015
Reviewed-on: https://skia-review.googlesource.com/3321
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Klein [Thu, 13 Oct 2016 18:54:32 +0000 (14:54 -0400)]
Add timestamp to bot ninja output.
The default NINJA_STATUS format is "[%f/%t] ". This prepends %e to help diagnose slow builds.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3323
Change-Id: Ied27317cedc2b07ff57c59eae61fe9e86c7fea33
Reviewed-on: https://skia-review.googlesource.com/3323
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Mike Klein [Thu, 13 Oct 2016 18:31:01 +0000 (14:31 -0400)]
GN/Win: quieter builds
It's hard to read the logs as they are now. This simplifies down the descriptions, and stifles a warning about linking object files with no symbols into a static library.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3322
Change-Id: I52beb3b8405ebb2c370cad432669834b64baa840
Reviewed-on: https://skia-review.googlesource.com/3322
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Tue, 11 Oct 2016 21:40:33 +0000 (14:40 -0700)]
Workaround unreachable code warning in GrGLCaps
BUG=skia:5833
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3179
Change-Id: I0b5ba57e533280e85b3672f476017dc12aefbbe5
Reviewed-on: https://skia-review.googlesource.com/3179
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
raftias [Thu, 13 Oct 2016 17:45:44 +0000 (10:45 -0700)]
Removed makeLinearGamma() from the public API for SkColorSpace
It will now reside in SkColorSpace_Base. Future work for SkColorSpace
will cause this function to not be desirable or sensible to call on
all SkColorSpaces. Call sites were changed to make a kSRGBLinear_Named
instead of kSRGB_Named -> makeLinearGamma() (the majority of cases),
and if that was not possible, SkColorSpace_Base::makeLinearGamma()
was called instead.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2412613005
Review-Url: https://codereview.chromium.org/
2412613005
Ben Wagner [Wed, 5 Oct 2016 16:30:14 +0000 (12:30 -0400)]
Remove SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2988
Change-Id: Ib39913a67cdd05662e7a91b4f05fbe5429eb0c42
Reviewed-on: https://skia-review.googlesource.com/2988
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Mike Klein [Thu, 13 Oct 2016 17:19:25 +0000 (13:19 -0400)]
GN/Win: pass /DEBUG to linker to get debug symbols.
Not much used for debug symbols if they're not linked in.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3320
Change-Id: I506ae624ec412d4151a025879a5dd14d90183bd8
Reviewed-on: https://skia-review.googlesource.com/3320
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
borenet [Thu, 13 Oct 2016 17:31:08 +0000 (10:31 -0700)]
Stop rebooting Android devices during Swarming tasks
Swarming will reboot the devices after each task.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2402403002
Review-Url: https://codereview.chromium.org/
2402403002
borenet [Thu, 13 Oct 2016 17:25:52 +0000 (10:25 -0700)]
[task scheduler] Trybots assume rietveld for now
Eventually we'll switch to gerrit-only. Supporting both will probably be
more complicated than it's worth.
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2413653005
Review-Url: https://codereview.chromium.org/
2413653005
halcanary [Thu, 13 Oct 2016 15:44:11 +0000 (08:44 -0700)]
SkXPS: compile under clang on win
BUG=chromium:616763
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2408133006
Review-Url: https://codereview.chromium.org/
2408133006
Ravi Mistry [Thu, 13 Oct 2016 14:36:50 +0000 (10:36 -0400)]
Output location of rankings CSV and a link to download SKPs by rank
Example run: https://luci-milo.appspot.com/swarming/task/
31cdda8d5cb95310
BUG=skia:5826
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3173
Change-Id: I56f4143e919f4328d0f573e8a4a4321eceb8564a
Reviewed-on: https://skia-review.googlesource.com/3173
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
mtklein [Thu, 13 Oct 2016 14:46:14 +0000 (07:46 -0700)]
Revert of leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster (patchset #1 id:1 of https://codereview.chromium.org/
2412633002/ )
Reason for revert:
Reverting while we think about skia:5854 so the bot doesn't regress further.
Original issue's description:
> leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2412633002
>
> Committed: https://skia.googlesource.com/skia/+/
c64ef3563dc8badac3d64544513b03df826cf8c3
TBR=mtklein@chromium.org,bsalomon@google.com,reed@google.com,lsalzman@mozilla.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5854
Review-Url: https://codereview.chromium.org/
2421473003
brianosman [Thu, 13 Oct 2016 13:44:23 +0000 (06:44 -0700)]
Preserve color space of images in deferred texture API
For raster images, this already worked (we were peeking the
pixmap's info). But for generated images, we discarded
format and color space information. Fixes an error with the
deferred GMs in sRGB modes, and also should help the Chrome
color correctness work.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2416453004
Review-Url: https://codereview.chromium.org/
2416453004
borenet [Thu, 13 Oct 2016 13:23:45 +0000 (06:23 -0700)]
Recipe fixes to support try jobs in task scheduler
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2410843002
Review-Url: https://codereview.chromium.org/
2410843002
Mike Klein [Thu, 13 Oct 2016 03:58:06 +0000 (23:58 -0400)]
GN/Win: warnings and warn-as-error
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3258
Change-Id: Ia2b85904bed1e6ca72c68abaecf6c2854795342c
Reviewed-on: https://skia-review.googlesource.com/3258
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Thu, 13 Oct 2016 02:42:55 +0000 (22:42 -0400)]
GN: naive attempt for 32-bit Windows support
This uses the win_toolchain's SetEnv.cmd script to set up the environment for x86 builds. Some of what it sets is redundant with what we set: include_dirs (INCLUDE), lib_dirs (LIB). I'd sort of like to learn what parts of it actually matter: VSINSTALLDIR? VCINSTALLDIR? likely PATH?
This will not work for local builds not using win_toolchain. I don't mind that too much, at least for now, maybe forever. Most humans should be using 64-bit builds.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3257
Change-Id: Ib880fb738bc4b493e8905903706526110213be47
Reviewed-on: https://skia-review.googlesource.com/3257
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 23:27:41 +0000 (19:27 -0400)]
GN: take over Windows -Exceptions bot.
This will make it temporarily 64-bit until I sort out 32-bit builds (tomorrow?) but that's an unimportant dimension for this bot... we just want to make sure we can build with /EHsc.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3255
Change-Id: Ie3c604e7ce779d0b45149e0151b7ecc93f9dd523
Reviewed-on: https://skia-review.googlesource.com/3255
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 23:36:09 +0000 (19:36 -0400)]
GN: windows flags tweaks.
Should be no need for /TC, /TP.
Don't set GCC-like 32-bit build flags on Windows.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Debug-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3256
Change-Id: Ifa11606ca55a86d416724247328024ddea59e8bc
Reviewed-on: https://skia-review.googlesource.com/3256
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
lsalzman [Wed, 12 Oct 2016 23:50:16 +0000 (16:50 -0700)]
leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2412633002
Review-Url: https://codereview.chromium.org/
2412633002
Mike Klein [Wed, 12 Oct 2016 21:06:48 +0000 (17:06 -0400)]
Disable MSVC optimization of sk_tool_utils::make_big_path().
This one function takes MSVC about 2 minutes to compile with optimization turned on, and roughly doubles my clean build wall time on a Z840 (186s before this change -> 95s after).
It's test-only, so who really cares how fast it is?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3254
Change-Id: I1318024caee281f3f8d44c05258b2bd4bd4eb695
Reviewed-on: https://skia-review.googlesource.com/3254
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 20:25:27 +0000 (16:25 -0400)]
GN/Win: flesh out compiler flags.
This should turn on the basics: optimization, debug symbols, disabled RTTI.
Release builds compile monobench, and cl.exe isn't happy with 1.0/0.0 there, so I swapped that into infinity().
Also, gn format I skipped last time.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3252
Change-Id: I8718d583e3fba4496b789eb25971462b972a5425
Reviewed-on: https://skia-review.googlesource.com/3252
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
fmalita [Wed, 12 Oct 2016 20:43:43 +0000 (13:43 -0700)]
Fix double-accounting of SkPictureShader bitmap memory
The pixels RAM is accounted via SkImageGenerator/SkImageCacherator, we
don't need to report it as part of SkPictureShader's BitmapShaderRec.
R=reed@google.com
BUG=chromium:619929
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2415673002
Review-Url: https://codereview.chromium.org/
2415673002
Mike Klein [Wed, 12 Oct 2016 19:52:44 +0000 (15:52 -0400)]
GN/Win: support win_toolchain asset?
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Debug-GN-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3246
Change-Id: Ib38d4f16788bc27ad81975a4c1b0a732e5df1de3
Reviewed-on: https://skia-review.googlesource.com/3246
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 18:32:09 +0000 (14:32 -0400)]
Update GN recipes for Windows.
fetch-gn is a Python script, gn is a batch script, and ninja is an exe.
Pass the win_toolchain package to GN as windk. This won't work yet.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3245
Change-Id: Iacc59c70c06ec118fc6a45d0cdb67095ff2b951b
Reviewed-on: https://skia-review.googlesource.com/3245
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
ethannicholas [Wed, 12 Oct 2016 18:46:07 +0000 (11:46 -0700)]
fixed GLVec4ScalarBench
TBR=jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2419573002
Review-Url: https://codereview.chromium.org/
2419573002
Ben Wagner [Wed, 12 Oct 2016 15:04:25 +0000 (11:04 -0400)]
Remove hack allowing fRefCnt of 0.
In some legacy situations users of SkRefCnt subclasses were keeping
the objects alive with a reference count of 0. Now that these users are
cleaned up, remove the hack which allowed such code to keep functioning.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3264
Change-Id: I22f63d87b6d995cad6326998284930ad9eaa2983
Reviewed-on: https://skia-review.googlesource.com/3264
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Mike Klein [Wed, 12 Oct 2016 15:05:05 +0000 (11:05 -0400)]
Add SkRasterPipeline support to SkModeColorFilter.
The shader leaves its color in r,g,b,a, so to implement this color filter, we move {r,g,b,a} into {dr,dg,db,da}, then load the filter's color in {r,g,b,a}, then apply the xfermode as usual.
I've left a note about how we could sometimes cut a stage for some xfermodes. Similarly we really only need to move_src_dst instead of swap_src_dst, but it seemed handy and less error prone to do a full two way swap. As usual, we can always circle back and fine-tune these things if we want.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3243
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I928c0fb25236eb75cf238134c6bebb53af5ddf07
Reviewed-on: https://skia-review.googlesource.com/3243
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>
Mike Klein [Wed, 12 Oct 2016 16:28:03 +0000 (12:28 -0400)]
Remove workaround for old compilers that do not support SSSE3.
We now require SSSE3, SSE4.1, SSE4.2, AVX, F16C, AVX2, and FMA compiler support on x86. This lone workaround for missing SSSE3 support is incongruous. It's also unlikely that there's any x86 compiler that supports C++11 but not SSSE3, certainly none we care about.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3244
Change-Id: Ie83f5ebb3f214eec726fedd0df6f46e72f735f38
Reviewed-on: https://skia-review.googlesource.com/3244
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 16:20:25 +0000 (12:20 -0400)]
GN/Win: everything links on my machine.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3267
Change-Id: I9879e3e33104a4eea6e5a87573a1b081dcc5ed54
Reviewed-on: https://skia-review.googlesource.com/3267
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 12 Oct 2016 13:52:55 +0000 (09:52 -0400)]
SkRasterPipeline: 8x pipelines, without any 8x code enabled.
Original review here: https://skia-review.googlesource.com/c/2990/
Second attempt here: https://skia-review.googlesource.com/c/3064/
This is the same as the second attempt, but with the change to SkOpts_hsw.cpp left out.
That omitted part is the key piece... this just lands the refactoring.
CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot,Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-GN,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot;master.client.skia.compile:Build-Win-MSVC-x86_64-Debug-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3242
Change-Id: Iaafa793a4854c2c9cd7e85cca3701bf871253f71
Reviewed-on: https://skia-review.googlesource.com/3242
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Greg Daniel [Wed, 12 Oct 2016 13:47:22 +0000 (09:47 -0400)]
Don't pass in RT to individual Gpu CommandBuffer calls
The Vulkan backend already stored a GrVkRT, but was inconsistent
in sometimes using the stored value and sometimes the passed in
value (though they should be the same). This just cleans up the
code so that everyone uses a stored RT.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3126
Change-Id: I571de4bfb1da612d61171321d5224a9a19d8e545
Reviewed-on: https://skia-review.googlesource.com/3126
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Greg Daniel [Tue, 11 Oct 2016 20:31:05 +0000 (16:31 -0400)]
Fix interface validation in Vulkan.
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3176
Change-Id: Ifad3249e6839e9b4aa34792646b2d54ff9304da7
Reviewed-on: https://skia-review.googlesource.com/3176
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
senorblanco [Wed, 12 Oct 2016 13:47:44 +0000 (06:47 -0700)]
GrTessellator: make inverse fill types more sane.
In the screenspace AA tessellator, a path's fill types would be applied
twice: once when extracting contours, and then again when filling polys.
It was supposed to be forced to kWinding_FillType by the second call to
mesh_to_polys(), but for hysterical reasons this parameter is unused!
For kInverseWinding_FillType (the only mode where this actually caused a bug),
I unwittingly papered over the problem by reversing the outer contour for the
inverse fill types, and comparing against -1 instead of 1.
The better fix is to actually pass a winding mode of kWinding_FillType
to polys_to_triangles(), and remove the (ignored) param from mesh_to_polys().
Then we can pass a clockwise outer contour as before, and compare
against 1 instead of -1.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2404403003
Review-Url: https://codereview.chromium.org/
2404403003
ethannicholas [Wed, 12 Oct 2016 13:39:56 +0000 (06:39 -0700)]
Turned on SkSL->GLSL compiler
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
Committed: https://skia.googlesource.com/skia/+/
dcfe6dba4a335e50e86ff68e3252065d4197432c
Committed: https://skia.googlesource.com/skia/+/
ccb1dd8f267f9d7fe7c9d0ce222ebc81b41853b3
Review-Url: https://codereview.chromium.org/
2288033003
csmartdalton [Wed, 12 Oct 2016 01:28:54 +0000 (18:28 -0700)]
skpbench: add warmup run
Does actual work while waiting for hardware settings to kick in,
rather than just sleeping.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2410373002
Review-Url: https://codereview.chromium.org/
2410373002
Mike Klein [Tue, 11 Oct 2016 23:59:22 +0000 (19:59 -0400)]
NDK Clang can build hb-icu.cc for mipsel now.
I haven't explicitly confirmed this, but it's likely that today's r12b -> r13 upgrade made this possible.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-mipsel-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-mipsel-Release-GN_Android-Trybot
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3241
Change-Id: I4d19ad48f387d48e0fa4a9f1637c67eb6e1ba4ae
Reviewed-on: https://skia-review.googlesource.com/3241
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 11 Oct 2016 22:13:53 +0000 (18:13 -0400)]
GN/Win: everything but skiaserve links.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3240
Change-Id: I85c306f89f3a7faa7f50dadf465122844d015604
Reviewed-on: https://skia-review.googlesource.com/3240
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 11 Oct 2016 21:49:33 +0000 (17:49 -0400)]
GN/Windows: fiddle links and runs
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3220
Change-Id: Ia8a47d4304a6b8e73b5ef068da9a5ac218ef3f72
Reviewed-on: https://skia-review.googlesource.com/3220
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Matt Sarett [Tue, 11 Oct 2016 20:57:50 +0000 (16:57 -0400)]
Add SkColorSpaceTransferFn to SkColorSpace
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3178
Change-Id: I354342d4469cee0e25a7b0d189e925e431da623c
Reviewed-on: https://skia-review.googlesource.com/3178
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Mike Klein [Tue, 11 Oct 2016 21:08:53 +0000 (17:08 -0400)]
More steps toward GN/Windows.
I think I'm now at the point of needing to just resolve missing symbols.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3201
Change-Id: Ib908bd72c23f2d4bafd17182eedcb2fc85c422e5
Reviewed-on: https://skia-review.googlesource.com/3201
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
lsalzman [Tue, 11 Oct 2016 21:29:12 +0000 (14:29 -0700)]
implement A8 destination fast-path for SkPixelInfo::CopyPixels
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2407093002
Review-Url: https://codereview.chromium.org/
2407093002
Mike Klein [Tue, 11 Oct 2016 20:26:57 +0000 (16:26 -0400)]
GN: windows compiles locally.
Not yet linking. Ignoring bots for now.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3200
Change-Id: Idd75033313df60844c2ba602f7845b3c52987bc2
Reviewed-on: https://skia-review.googlesource.com/3200
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
lsalzman [Tue, 11 Oct 2016 19:20:17 +0000 (12:20 -0700)]
fix vertex alpha calculation in GrTesselator
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2405813003
Review-Url: https://codereview.chromium.org/
2405813003
liyuqian [Tue, 11 Oct 2016 19:20:08 +0000 (12:20 -0700)]
Add AA Analytic Compile Flag (and small fixes)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2410303002
Review-Url: https://codereview.chromium.org/
2410303002
csmartdalton [Tue, 11 Oct 2016 19:15:13 +0000 (12:15 -0700)]
skpbench: add debug prints for thermal trip points
Prints thermal trip points that have been exceeded when a
HardwareException is raised, and verbosity is set to debug. This can
help us correlate thermal trip points with throttling and detect
future throttling before it occurs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2408893002
Review-Url: https://codereview.chromium.org/
2408893002
Brian Osman [Mon, 10 Oct 2016 21:04:52 +0000 (17:04 -0400)]
Fix 32-bit Vulkan build
In 32-bit land, VkFence is uint64_t, so reinterpret_cast (between two
identical integral types) is illegal.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3143
Change-Id: Iba9507f5678f647710f4abd35023c192bf6eed66
Reviewed-on: https://skia-review.googlesource.com/3143
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
msarett [Tue, 11 Oct 2016 19:15:03 +0000 (12:15 -0700)]
Add SkColorSpaceXform to the public API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2390263002
Review-Url: https://codereview.chromium.org/
2390263002
Mike Klein [Tue, 11 Oct 2016 18:03:06 +0000 (14:03 -0400)]
Fix GN formatting presubmit on Windows.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3182
Change-Id: I6e19b18d6851516357f71930e406b9fb324ea81f
Reviewed-on: https://skia-review.googlesource.com/3182
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Mike Klein [Tue, 11 Oct 2016 17:51:55 +0000 (13:51 -0400)]
Make `gn gen` work on Windows again.
Clang detection is specific to GCC-like toolchains.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3171
Change-Id: I7144bc8e5cd3e774625b51a6dda981284ed1fdc1
Reviewed-on: https://skia-review.googlesource.com/3171
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 11 Oct 2016 15:21:36 +0000 (11:21 -0400)]
Update to Android NDK r13.
The libc++ include paths have changed very slightly. I've left GN compatible with both older r12 NDKs and the new r13 to smooth the transition.
The libc++ in r13 depends on long-double math.h functions (cosl, atanl, etc.) only available in Android API v21 (Lollipop) and up. That's what the 64-bit bots were already on, so we just pull the 32-bit bots up to the same target. Conveniently, the oldest bots we have (N7 and N10) are on Lollipop.
The r13 MIPS64 sysroots are a little weird... /usr/include and /usr/lib64 but no /usr/lib. That'd be fine---we only want 64-bit builds---but Clang searches for /usr/lib64 via its path to /usr/lib, and without at least an empty /usr/lib, it can't find /usr/lib64. So you'll see a special mips64el section in the GN config where we do this all manually (other platforms pick this all up correctly from --sysroot). I've chosen to do this rather than fix it up in the asset create.py scripts so that we stay compatible with vanilla NDKs, which is convenient for developers.
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Mac-Clang-arm64-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-arm-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-arm-Release-GN_Android-Trybot,Build-Ubuntu-Clang-arm64-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-arm64-Debug-GN_Android_FrameworkDefs-Trybot,Build-Ubuntu-Clang-arm64-Debug-GN_Android_Vulkan-Trybot,Build-Ubuntu-Clang-arm64-Release-GN_Android-Trybot,Build-Ubuntu-Clang-mips64el-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-mips64el-Release-GN_Android-Trybot,Build-Ubuntu-Clang-mips64el-Release-GN_Android-Trybot,Build-Ubuntu-Clang-mipsel-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-mipsel-Release-GN_Android-Trybot,Build-Ubuntu-Clang-x64-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-x64-Release-GN_Android-Trybot,Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-x86-Release-GN_Android-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3180
Change-Id: I6f3b5d9411ded0ee49c1099490f41fa86a8736f8
Reviewed-on: https://skia-review.googlesource.com/3180
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
jvanverth [Tue, 11 Oct 2016 17:03:56 +0000 (10:03 -0700)]
Revert of Turned on SkSL->GLSL compiler (patchset #49 id:1240001 of https://codereview.chromium.org/
2288033003/ )
Reason for revert:
Pre-emptive revert. Sorry, but we're getting back up on our roll and Chrome reverted our last one for apparently no reason.
Original issue's description:
> Turned on SkSL->GLSL compiler
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
>
> Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
> Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
> Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
> Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
> Committed: https://skia.googlesource.com/skia/+/
dcfe6dba4a335e50e86ff68e3252065d4197432c
> Committed: https://skia.googlesource.com/skia/+/
ccb1dd8f267f9d7fe7c9d0ce222ebc81b41853b3
TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2408193002
msarett [Tue, 11 Oct 2016 16:41:16 +0000 (09:41 -0700)]
Add SkColorSpacePrimaries to help with making D50 matrices
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2304753002
Review-Url: https://codereview.chromium.org/
2304753002
drott [Tue, 11 Oct 2016 16:03:46 +0000 (09:03 -0700)]
Remove restrictive format pattern for Fontconfig matching
This pattern pushes CFF fonts too far low in the list. Instead
it is enough to rely on the isValidPattern function to skip
Type 1 fonts.
BUG=skia:5846
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2410063002
Review-Url: https://codereview.chromium.org/
2410063002
ethannicholas [Tue, 11 Oct 2016 15:47:04 +0000 (08:47 -0700)]
Turned on SkSL->GLSL compiler
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
Committed: https://skia.googlesource.com/skia/+/
dcfe6dba4a335e50e86ff68e3252065d4197432c
Review-Url: https://codereview.chromium.org/
2288033003
Robert Phillips [Tue, 11 Oct 2016 14:18:18 +0000 (10:18 -0400)]
Add new GM to demonstrates SkGaussianEdgeShader
This would've caught the incorrect distances in the center bug
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3111
Change-Id: I9461a8865b561cc139a18a5e779e933d7979ee0d
Reviewed-on: https://skia-review.googlesource.com/3111
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
mtklein [Tue, 11 Oct 2016 02:41:32 +0000 (19:41 -0700)]
Revert of Turned on SkSL->GLSL compiler (patchset #48 id:1220001 of https://codereview.chromium.org/
2288033003/ )
Reason for revert:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/26798
Original issue's description:
> Turned on SkSL->GLSL compiler
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
>
> Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
> Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
> Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
> Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
> Committed: https://skia.googlesource.com/skia/+/
dcfe6dba4a335e50e86ff68e3252065d4197432c
TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2408053002
lsalzman [Mon, 10 Oct 2016 22:36:24 +0000 (15:36 -0700)]
fix 'GrClip::quickContains was hidden' warning in GrNoClip
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2394113002
Review-Url: https://codereview.chromium.org/
2394113002
Mike Klein [Wed, 5 Oct 2016 19:41:01 +0000 (15:41 -0400)]
GN: build dump_record
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3021
Change-Id: I447ef9a880e5b13103bac76d41e176c7940c8512
Reviewed-on: https://skia-review.googlesource.com/3021
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
borenet [Mon, 10 Oct 2016 20:20:49 +0000 (13:20 -0700)]
More fixes for webpages_playback
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2409753002
Review-Url: https://codereview.chromium.org/
2409753002
scroggo [Mon, 10 Oct 2016 18:35:01 +0000 (11:35 -0700)]
Simplify rowsDecoded returned by incrementalDecode
When sampling, we previously had to figure out the number of rows that
were written to the output based on the value reported by
incrementalDecode. (We also messed up the first time - see the fix in
crrev.com/
2343153003.)
Instead, make incrementalDecode report the actual number of rows
written to. This can be provided directly to fill.
Make SkPngCodec report the correct number of rows, by incrementing its
count when it actually writes to the destination.
This also will simplify my in progress GIF change.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2407543002
Review-Url: https://codereview.chromium.org/
2407543002
borenet [Mon, 10 Oct 2016 17:37:30 +0000 (10:37 -0700)]
RecreateSKPs: Don't download and use the .boto file
It's not needed for the new bucket.
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2408793002
Review-Url: https://codereview.chromium.org/
2408793002
borenet [Mon, 10 Oct 2016 17:17:49 +0000 (10:17 -0700)]
Specify the Android build number as a swarming dimension
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2403103002
Review-Url: https://codereview.chromium.org/
2403103002
ethannicholas [Mon, 10 Oct 2016 17:09:00 +0000 (10:09 -0700)]
Turned on SkSL->GLSL compiler
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
Review-Url: https://codereview.chromium.org/
2288033003
Robert Phillips [Fri, 7 Oct 2016 18:44:07 +0000 (14:44 -0400)]
Update AndroidShadows slide with new stroking offset
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3080
Change-Id: I0a60e99b357f930a5215201d8bb8b5f3c91819b1
Reviewed-on: https://skia-review.googlesource.com/3080
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
jvanverth [Mon, 10 Oct 2016 16:18:23 +0000 (09:18 -0700)]
Revert of Turned on SkSL->GLSL compiler (patchset #47 id:1200001 of https://codereview.chromium.org/
2288033003/ )
Reason for revert:
Looks like it introduces new static initializers, and it's failing the Chrome roll.
Original issue's description:
> Turned on SkSL->GLSL compiler
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
>
> Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
> Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
> Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
> Committed: https://skia.googlesource.com/skia/+/
08b2ccf398e2b81bc05d2c105837e5419899469b
TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2403083002
Brian Osman [Mon, 10 Oct 2016 15:26:43 +0000 (11:26 -0400)]
Update comment, move constant inside helper struct
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3109
Change-Id: Ife8a2434ff591bd77be1cd0fbcce50430e18c86c
Reviewed-on: https://skia-review.googlesource.com/3109
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
borenet [Mon, 10 Oct 2016 15:14:11 +0000 (08:14 -0700)]
webpages_playback: Fix GS path with extra '/'
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2409593002
Review-Url: https://codereview.chromium.org/
2409593002
stephana [Mon, 10 Oct 2016 14:59:08 +0000 (07:59 -0700)]
Add description to Gold
BUG=skia:
R=hcm,jcgregorio
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2406753002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2406753002
Review-Url: https://codereview.chromium.org/
2406753002
jvanverth [Mon, 10 Oct 2016 14:39:38 +0000 (07:39 -0700)]
Fix iOS surface creation for SampleApp
BUG=skia:5810
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2394843003
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/
2394843003
Mike Klein [Mon, 10 Oct 2016 14:23:37 +0000 (14:23 +0000)]
Revert "SkRasterPipeline: 8x pipelines, attempt 2"
This reverts commit Id0ba250037e271a9475fe2f0989d64f0aa909bae.
crbug.com/654213
Looks like Chrome Canary's picking up Haswell code on non-Haswell machines.
Change-Id: I16f976da24db86d5c99636c472ffad56db213a2a
Reviewed-on: https://skia-review.googlesource.com/3108
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
scroggo [Mon, 10 Oct 2016 14:17:32 +0000 (07:17 -0700)]
Report 0 rowsDecoded for no rows (SkPngCodec interlaced)
incrementalDecode is supposed to report the number of rows decoded. It
failed to if none were decoded (for an interlaced png). Fix the bug and
add a test.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2402063002
Review-Url: https://codereview.chromium.org/
2402063002
scroggo [Mon, 10 Oct 2016 13:45:32 +0000 (06:45 -0700)]
Fix an assert statement in SkPngCodec
allRowsCallback was asserting that
rowNum - fFirstRow == fLinesDecoded
But it was expecting fFirstRow to be 0 (logically, it is, since we are
decoding all rows), and it never set it (because it doesn't really need
to, except for this assert). This is only a problem if we reuse an
SkPngCodec after previously scaling with it. Add a test that triggers
the assert, and fix it.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2401133002
Review-Url: https://codereview.chromium.org/
2401133002
Joe Gregorio [Mon, 10 Oct 2016 13:38:59 +0000 (09:38 -0400)]
Update Perf docs and add a couple screenshots.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3121
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3121
Change-Id: Ic2d1743b2dc42701202ff316277db4c944d969d3
Reviewed-on: https://skia-review.googlesource.com/3121
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
ethannicholas [Mon, 10 Oct 2016 13:40:23 +0000 (06:40 -0700)]
Turned on SkSL->GLSL compiler
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
Committed: https://skia.googlesource.com/skia/+/
b12b3c6908c62c908b3680be01e3b5bfd30de310
Committed: https://skia.googlesource.com/skia/+/
f008b0a59f45c0d4bea3e66faf3b01805009ec89
Review-Url: https://codereview.chromium.org/
2288033003
Brian Osman [Mon, 3 Oct 2016 22:29:03 +0000 (18:29 -0400)]
Convert gradient params test helper to a struct
Much less copy-pasted code, fewer implementation details leaking out,
and going to be easier to extend for 4f and color space testing.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2900
Change-Id: Icc468c606aa35fbe82c64bcc398e7e348e0faa20
Reviewed-on: https://skia-review.googlesource.com/2900
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
projects / platform / upstream / libSkiaSharp.git / log