Vivia Nikolaidou [Tue, 31 Aug 2021 13:35:06 +0000 (16:35 +0300)]
mpegtsbase: Search SCTE-35 DRF_ID_CUEI in multiple registration descriptors
There are streams in the wild that have to add a SCTE-35 trigger in
another e.g. GA94 stream. Most encoders would replace the GA94
descriptor ID with the CUEI one temporarily, but there are some that
will add two registration ID descriptors, one with GA94 and one with
CUEI.
Failing to parse the CUEI registration ID in that case would return
FALSE in _stream_is_private_section , therefore setting it as known PES
and pushing packets downstream instead of calling handle_psi.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/979>
Thibault Saunier [Fri, 15 Oct 2021 02:02:36 +0000 (23:02 -0300)]
smartencoder: Force reencoding of vp9 for profiles can't support
If the input file is in a profile we won't be able to output (1 or 3 in BGR
format), simply reencode everything for now.
Once we add support for that case we can remove that code
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Thibault Saunier [Fri, 15 Oct 2021 01:55:35 +0000 (22:55 -0300)]
encoding-profile: ignore more fields when creating for discover info
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Thibault Saunier [Fri, 15 Oct 2021 01:29:19 +0000 (22:29 -0300)]
smartencoder: Always plug a vp9parse when encoding vp9
This way we know that all relevant fields about video format are
added and we avoid renegotiation issues.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Thibault Saunier [Tue, 5 Oct 2021 15:28:22 +0000 (12:28 -0300)]
qtmux: Allow more fields changes renegotiating h264
And consider interlace-mode=progress as equivalent to the field not
being specified.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Thibault Saunier [Tue, 5 Oct 2021 13:50:32 +0000 (10:50 -0300)]
matroskamux: Ignore some fields when renegotiating
Those values are never used in the muxer so we should not fail the
negotiation if those are changing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Thibault Saunier [Tue, 5 Oct 2021 13:46:26 +0000 (10:46 -0300)]
smartencoder: Fix renegotiating when reencoding parts of the stream with vpx
In the encoded streams we might not have all the information about the
raw video stream, but when reencoding they end up being specified, even
if those are default values.
As vp8 decoders always output frames in some YUV color space we can
ensure that when upstream doesn't specify any value in its caps we
use the default one which is what we end up doing when decoding/reencoding
anyway, so this way downstream (matroskamux in that case) doesn't need
to be able to renegotiate (which it doesn't).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>
Edward Hervey [Fri, 1 Oct 2021 12:36:48 +0000 (14:36 +0200)]
tsdemux: Improve gap detection
We should also take into account whether data is currently pending when checking
for gap on streams. It could very well be that some streams have very low
bitrate (and spread out) data. For those we don't want to push out a gap event.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>
Edward Hervey [Sun, 5 Sep 2021 09:57:18 +0000 (11:57 +0200)]
tsdemux: Handle "negative" timestamps
This is only enabled in push time mode. Furthermore it's only enabled for now if
PCR is to be ignored.
The problem is dealing with streams where the initial PTS/DTS observation might
be greater than following ones (from other PID for example). Before this patch,
this would result in sending buffers without any timestamp which would cause a
wide variety of issues.
Instead, pad segment and buffer timestamps with an extra
value (packetizer->extra_shift, default to 2s), to ensure that we can get valid
timestamps on outgoing buffers (even if that means they are before the segment
start).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>
Edward Hervey [Sun, 5 Sep 2021 09:55:55 +0000 (11:55 +0200)]
tsdemux: Handle streams with bogus PTS vs DTS
PTS and DTS should be within a reasonable distance of each other.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>
Edward Hervey [Sun, 5 Sep 2021 09:53:05 +0000 (11:53 +0200)]
tsdemux: Handle PTS->TS at wraparound
This has been a FIXME for ages.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>
Rob Agar [Thu, 14 Oct 2021 13:07:07 +0000 (14:07 +0100)]
webrtcbin: fix prevention of webrtcbin deletion due to ref held by probe callback
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/810
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1150>
Seungha Yang [Sat, 16 Oct 2021 10:01:27 +0000 (19:01 +0900)]
d3d11: d3d11{convert,scale}: Add add-borders property
Functionally identical to that of videoscale element.
When disabled, d3d11convert or d3d11scale element will scale
image without adding borders, meaning that display aspect ratio
will not be preserved.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1170>
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:58:53 +0000 (10:58 +0200)]
vapostproc: Add add-borders property to keep dar
Just as videoscale, it enables add-borders property (FALSE by default)
in vapostproc to add border, if necessary, to keep the display aspect
ratio from the original image.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:51:57 +0000 (10:51 +0200)]
vapostproc: Fix early fixation.
First copy missing fields and then fixate all remaining fields.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>
Tim-Philipp Müller [Thu, 14 Oct 2021 18:08:49 +0000 (19:08 +0100)]
ofa: remove ofa audio fingerprinting plugin
I think the MusicIP database for this has been defunct for years,
so I can't imagine this plugin is particularly useful or still
used by anyone.
See https://musicbrainz.org/doc/Fingerprinting#PUID
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1153>
Nirbheek Chauhan [Wed, 13 Oct 2021 08:05:51 +0000 (13:35 +0530)]
meson: Define cpp_std in the top-level project()
Due to a bug, meson ignores ${lang}_std settings in default_options
for subprojects: https://github.com/mesonbuild/meson/issues/1889
This causes build failures when a subproject requires c++11 or c++14,
etc. Compilers that support those cpp_stds are very common, and all
the toolchains that we support include c++ compilers, so we can
add cpp_std=c++14 to the top-level.
This fixes the webrtc-audio-processing build on Linux, and harfbuzz on
macOS.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1133>
Seungha Yang [Sat, 16 Oct 2021 13:43:32 +0000 (22:43 +0900)]
meson: wasapi2,mediafoundation: Work around Windows SDK header issue
Some SDK headers are not standard compliant, so MSVC will
complain when such headers are in use with "/permissive-" compile
option. Use "/Zc:twoPhase-" to work around the issue as documented in
https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-160#windows-header-issues
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1174>
Thibault Saunier [Sun, 17 Oct 2021 04:59:35 +0000 (01:59 -0300)]
lame:meson: Avoid using fallback when we could use system install
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1176>
Tim-Philipp Müller [Sat, 16 Oct 2021 22:53:04 +0000 (23:53 +0100)]
subprojects: update vorbis wrap to 1.3.7 and add fallback url
The Windows CI runners complain about self-signed certificates
with the download.xiph.org urls.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>
Tim-Philipp Müller [Sat, 16 Oct 2021 22:50:51 +0000 (23:50 +0100)]
subprojects: update ogg wrap to 1.3.5 and add fallback url
The windows ci runners complain about a self-signed certificate
with the download.xiph.org urls.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>
Thibault Saunier [Sat, 16 Oct 2021 14:32:53 +0000 (11:32 -0300)]
validate:known_issues:rtsp: Mark error message on bus as known
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/814
And reindent file.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>
Thibault Saunier [Sat, 16 Oct 2021 12:29:28 +0000 (09:29 -0300)]
meson: Mark newly fdkaac/ogg/vorbis as allow fallback
This way when the dep is `auto` we will fallback if the system
dependency is not available.
And use https to get libvorbis
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>
Seungha Yang [Fri, 15 Oct 2021 16:15:06 +0000 (01:15 +0900)]
mediafoundation: Use GetProcAddress() for OS version dependent symbols
We are using some symbols which are not available on Windows 7,
specifically D3D11 interop related ones
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1167>
Víctor Manuel Jáquez Leal [Wed, 6 Oct 2021 01:26:25 +0000 (03:26 +0200)]
vapostproc: Transfer colorimetry at fixate if possible.
Taken from videoconvert element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1110>
Thibault Saunier [Sat, 16 Oct 2021 01:07:39 +0000 (22:07 -0300)]
meson: Fix warning building GstGLEGL
We forgot to add the `GstGL` gir as a dependency which was properly
done for GstGLWayland and GstGLX11.
And document why we use a list for `all_libraries`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1168>
Thibault Saunier [Tue, 5 Oct 2021 14:38:33 +0000 (11:38 -0300)]
meson: Support building lame as subproject
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>
Thibault Saunier [Mon, 4 Oct 2021 17:41:28 +0000 (14:41 -0300)]
meson: Add wrap for libvorbis and libogg
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>
Thibault Saunier [Tue, 5 Oct 2021 21:51:57 +0000 (18:51 -0300)]
meson: Add wrap for fdkaac
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>
Thibault Saunier [Wed, 22 Sep 2021 16:12:07 +0000 (13:12 -0300)]
python:meson: Do not build plugin when statically built
It is not supported yet
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Tue, 14 Sep 2021 21:25:46 +0000 (18:25 -0300)]
python: Add an option to disable tests
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Wed, 13 Oct 2021 02:28:57 +0000 (23:28 -0300)]
ci: Build introspection support on static builds
But disable python in GES as it is not supported on static builds
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Wed, 13 Oct 2021 02:25:40 +0000 (23:25 -0300)]
ges:docs: Ignore GESImageSource as it is plain useless now
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Wed, 13 Oct 2021 00:29:00 +0000 (21:29 -0300)]
meson: Add info about 'gstreamer-full'
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Tue, 12 Oct 2021 18:52:48 +0000 (15:52 -0300)]
meson: Streamline the way we detect when to build documentation
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Fri, 8 Oct 2021 01:34:38 +0000 (22:34 -0300)]
tests: Simple test to use gst-full in python
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Sat, 2 Oct 2021 14:54:00 +0000 (11:54 -0300)]
validate:build: Disable static building validate tracer
It introduce duplication of symbols and we need to rework the way we implement it
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Tue, 14 Sep 2021 11:57:15 +0000 (08:57 -0300)]
build: Expose ges symbols in gst-full
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Mon, 13 Sep 2021 21:33:01 +0000 (18:33 -0300)]
ges:build: Disable python modules when statically building
Introspection fails otherwise
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Mon, 13 Sep 2021 21:20:11 +0000 (18:20 -0300)]
Use new `libraries` subprojects variables to statically link then
And also build the girs against `gstreamer-full` when possible. Also
making `gst_init_static_plugins` available from the bindings.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Sat, 27 Jun 2020 04:39:00 +0000 (00:39 -0400)]
meson: List libraries and their corresponding gir definition
Introduces a `libraries` variable that contains all libraries in a
list with the following format:
``` meson
libraries = [
[pkg_name, {
'lib': library_object
'gir': [ {full gir definition in a dict } ]
],
....
]
```
It therefore refactors the way we build the gir so that we can reuse the
same information to build them against 'gstreamer-full' in gst-build
when linking statically
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Sat, 27 Jun 2020 04:37:39 +0000 (00:37 -0400)]
meson: Mark files as files()
Making it more robust and future proof
And fix issues that it creates
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Mon, 13 Sep 2021 20:53:12 +0000 (17:53 -0300)]
bad:audio: Add generated files sources in declare_dependency
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>
Thibault Saunier [Thu, 14 Oct 2021 20:01:01 +0000 (17:01 -0300)]
python: Fix using overrides when not building PyGObject
Since
547570cd790f2b2e390edc1dfb5df4c7a33de45c we do not always build
PyGObject and our development environment is broken when trying to use
GStreamer python when built against system PyGObject with the following
error importing Gst in there:
```
12345678** (gst-plugin-scanner:710617): CRITICAL **: 11:45:02.343: can't find gi.repository.Gst
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/gi/repository/__init__.py", line 23, in <module>
from ..importer import DynamicImporter
File "/usr/lib64/python3.9/site-packages/gi/importer.py", line 33, in <module>
from .overrides import load_overrides
ImportError: cannot import name 'load_overrides' from 'gi.overrides' (/var/home/thiblahute/devel/gstreamer/gstreamer/subprojects/gst-editing-services/bindings/python/gi/overrides/__init__.py)
Factory Details:
```
The approach to fixing it is to implement override `gi` in
`gst-python/gi/` which we add to `PYTHONPATH`) and in there reset the
`gi` module to the right place and we get overrides from paths from
`_GI_OVERRIDES_PATH` we set in `gst-env.py` which points to all the
overrides that will be installed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1155>
Seungha Yang [Fri, 15 Oct 2021 14:18:41 +0000 (23:18 +0900)]
mediafoundation: Fix various string constness handling
... with fixing typo (g_strup -> g_strdup)
Constness needs to be explicit in C++ world otherwise compiler
would complain about that.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1164>
Veronika Kremneva [Fri, 8 Oct 2021 10:56:02 +0000 (13:56 +0300)]
gstreamer/gst/gstconfig.h.in: Add support for ARC64 architecture
Signed-off-by: Veronika Kremneva <kremneva@synopsys.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1161>
Rob Agar [Fri, 15 Oct 2021 09:03:46 +0000 (10:03 +0100)]
missing transceiver unref in WebRTC renegotiation example
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1160>
He Junyan [Thu, 14 Oct 2021 16:33:39 +0000 (00:33 +0800)]
Docs: Fix a typo for Intel's vaapi driver name.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1151>
Thibault Saunier [Fri, 15 Oct 2021 00:00:59 +0000 (21:00 -0300)]
wraps:ffmpeg: Move to 4.4
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1156>
Mengkejiergeli Ba [Wed, 13 Oct 2021 09:17:44 +0000 (17:17 +0800)]
tests:va: Fix null ptr dereference in multi-vpp
Dereference the pointer err before null check, which raised a null
pointer dereference issue by Coverity. Modify it to do the null check
of err first, then dereference it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>
Mengkejiergeli Ba [Wed, 13 Oct 2021 07:58:29 +0000 (15:58 +0800)]
va: Fix null ptr dereference for vadeocder
Making a null check in gst_va_decode_picture_free () indicates pic->buffers or pic->slices
can be null, then in _destroy_buffers () the pointers are dereferenced, which is detected
as dereference after null check by Coverity. Thus, modify the code to do null check in
_detroy_buffers ().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>
Xavier Claessens [Thu, 14 Oct 2021 17:01:41 +0000 (13:01 -0400)]
Pin all wrap files to closest tag or commit sha1
Tracking branches, especially master, can cause regressions at any time.
We should try to use as much stable release tags as possible in the
future.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1152>
Vivia Nikolaidou [Mon, 5 Apr 2021 07:29:37 +0000 (10:29 +0300)]
tsdemux: Handle delayed seek events
Store the event in case it cannot be processed immediately and process
it after the first segment has been produced.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>
Vivia Nikolaidou [Mon, 5 Apr 2021 07:28:51 +0000 (10:28 +0300)]
tsdemux: Protect demux->segment_event with a mutex
Would otherwise cause weird issues when processing a delayed seek event
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>
Piotrek Brzeziński [Wed, 13 Oct 2021 19:28:58 +0000 (21:28 +0200)]
video-converter: Fix v210->I420 last line conversion
Last line would not be converted correctly if height was an odd number.
Fixed by accounting for data type (8bit vs. 16bit) differences between
respective packing and unpacking functions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>
Piotrek Brzeziński [Wed, 13 Oct 2021 14:53:41 +0000 (16:53 +0200)]
video-format: Clean up v210 packing code
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>
Piotrek Brzeziński [Wed, 13 Oct 2021 15:25:41 +0000 (17:25 +0200)]
video-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>
Nicolas Dufresne [Thu, 14 Oct 2021 18:35:45 +0000 (14:35 -0400)]
codecs: h264: Fix wrong type of ret variable
This ret is not a GstFlowReturn. This broke v4l2 decoder which does not
implement new_picture() virtual function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1154>
Seungha Yang [Wed, 13 Oct 2021 12:45:34 +0000 (21:45 +0900)]
d3d11: Rename screen capture element
Old name "desktopdup" may confuse users. Now it's renamed to
"screencapture"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1136>
Seungha Yang [Wed, 13 Oct 2021 15:40:16 +0000 (00:40 +0900)]
gitignore: Ignore *.wrap files again
There are various redirection *.wrap files which result in noisy
diff. Just ignore the entire wrap files. We can update wrap files
anytime via -f option.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1140>
Thibault Saunier [Wed, 13 Oct 2021 21:10:40 +0000 (18:10 -0300)]
ci: Move rules from `.build fedora x86_64` to `.build`
They should apply to all job that extend it as the 2 jobs that depend on
`.build` but not on `.build fedora x86_64` is
`build nodebug fedora x86_64` which pulls `build static nodebug fedora x86_64`
both jobs should be manual on `main` and they should run only if some
files "modules_changes" happened
Also make sure we do no automatically run job on `main` branches from forks
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1141>
Thibault Saunier [Wed, 13 Oct 2021 21:00:13 +0000 (18:00 -0300)]
ci: Fix ordering of rules to always build on main
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1141>
Thibault Saunier [Tue, 12 Oct 2021 21:09:16 +0000 (18:09 -0300)]
hooks:python: Max line length should be 120
As we ignore line length in pycodestyle and we have many places with
line with more than 80 and less than 120 chars
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>
Thibault Saunier [Tue, 12 Oct 2021 21:05:52 +0000 (18:05 -0300)]
validate:launcher: Reindent utils.py
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>
Thibault Saunier [Tue, 12 Oct 2021 20:59:03 +0000 (17:59 -0300)]
validate:launcher: Check if the running MR will close a referenced issue
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>
Thibault Saunier [Tue, 12 Oct 2021 20:19:46 +0000 (17:19 -0300)]
ci: Check for closed bugs for unit tests too
And add FIXMEs for test that should have been reenabled but haven't,
we will reenable them when CI is stable enough!
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>
Thibault Saunier [Tue, 12 Oct 2021 20:14:49 +0000 (17:14 -0300)]
tests: Move all unit tests issues to the GStreamer monorepo
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>
Thibault Saunier [Tue, 5 Oct 2021 21:52:25 +0000 (18:52 -0300)]
transcoder: Set state back to NULL after run() finishes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063>
Thibault Saunier [Mon, 13 Sep 2021 21:02:03 +0000 (18:02 -0300)]
transcoder: Use full path for includes in 'gsttranscoder.h'
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063>
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:50:31 +0000 (17:50 +0800)]
va:display: Don't close an fd with negative value
Cannot pass negative parameter to close() and thus no need to apply
close() when fd < 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:48:17 +0000 (17:48 +0800)]
va: Fix error handling for decoder
Need to check if va decoder is closed successfully.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:44:27 +0000 (17:44 +0800)]
va: Fix error handling for base transform
Need to check the returned value of gst_buffer_pool_set_active() when
setting the active status of buffer pool.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>
Andoni Morales Alastruey [Tue, 12 Oct 2021 21:13:44 +0000 (23:13 +0200)]
Fix GStreamer msys2 builds in the CI
Install ninja and the toolchain in the docker image.
Use the UCRT64 environment for building
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1000>
Andoni Morales Alastruey [Fri, 1 Oct 2021 15:20:30 +0000 (17:20 +0200)]
ci: prepare the Windows image for MSYS2 cerbero builds
* Install MSYS2 and VS with choco
* Install Windows SDK 8.1 requied for libvpx
* Improve build time of the windows image using as much RUN layers as
possible
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1000>
Matthew Waters [Thu, 14 Oct 2021 06:48:59 +0000 (17:48 +1100)]
gl/dmabuf: add some debug logging about why things may fail to be uploaded
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1145>
Matthew Waters [Fri, 24 Sep 2021 05:02:27 +0000 (15:02 +1000)]
playbin2/3: autoplug/caps: don't expand caps to ANY
Retrieving the pad template caps from a ghost pad returns ANY which when
merged with any other caps will return ANY. ANY is not very specific
and may cause suboptimal code paths in e.g. decoders that assume the
lowest common denominator when presented with ANY caps.
Fixes negotiating dma-buf with vaapidecodebin between glupload in the
video sink element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1144>
Thibault Saunier [Thu, 14 Oct 2021 00:26:53 +0000 (21:26 -0300)]
meson:avtp: Error out if sock_txtime is not present and avtp is enabled
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1142>
Thibault Saunier [Wed, 13 Oct 2021 14:09:20 +0000 (11:09 -0300)]
Revert "tests: Blacklist some tests that recently failed"
This reverts commit
9f13ee5b0eada5ca0997e59be2ef46d5c2dd1dcd as
it was merge as part of the bigger CI gardening MR
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1139>
Philippe Normand [Wed, 13 Oct 2021 13:42:15 +0000 (14:42 +0100)]
soup-stub: Gate G_URI_FLAGS_SCHEME_NORMALIZE behind glib version check
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1138>
Thibault Saunier [Wed, 13 Oct 2021 01:35:38 +0000 (22:35 -0300)]
ci: Run tests post merge
This will make tracking new races much easier
Mark other jobs as manual when pipeline is running on master
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1129>
Thibault Saunier [Wed, 13 Oct 2021 03:17:27 +0000 (00:17 -0300)]
ges:test: Document some GES failures
Namely races in:
* check.gst-editing-services.edit_while_seeked_with_stop_it
* check.gst-editing-services.check_layer_activness_gaps_it
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/803
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/804
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>
Thibault Saunier [Wed, 13 Oct 2021 03:07:20 +0000 (00:07 -0300)]
ges:tests: Create shorter assets to avoid timeouts
And use a simple GStreamer pipeline as testsrcbin with GstTranscoder
doesn't let us easily set the framerate of the source and we end up
having videorate dropping frames leading to the rendered file having
an unprecise duration.
This should fix races with `check.gst-editing-services.pythontests.pyunittest.python.test_assets.TestTimeline.test_reload_asset`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>
Thibault Saunier [Wed, 13 Oct 2021 03:06:34 +0000 (00:06 -0300)]
validate:launcher: Avoid spamming terminal when inspecting unit tests
And redirect GStreamer logs when necessary
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>
Thibault Saunier [Wed, 13 Oct 2021 02:05:20 +0000 (23:05 -0300)]
validate:launcher: Run validate unit tests as GstValidate tests
So we have all the features and we can properly document known issue
for them
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>
Seungha Yang [Sat, 9 Oct 2021 16:56:32 +0000 (01:56 +0900)]
codecparsers: {h264,h265}parser: Fix typo around SEI nalu generator
Fix to create correct SEI nalu when the size of payloadType and/or
payloadType is larger than 255 (0xff)
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1601
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1106>
Stéphane Cerveau [Thu, 30 Sep 2021 10:33:35 +0000 (12:33 +0200)]
rebase-branch-from-old: few improvments
- Enhance the documentation
- Allow to revert cherry-pick
- coding style
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1094>
Seungha Yang [Thu, 7 Oct 2021 10:28:41 +0000 (19:28 +0900)]
validate: flow: Fix for line-ending mismatch issue on Windows
Unlike POSIX system, Windows distinguishes "w" and "wb" and when
a file is opened with text mode, OS will translate \n into \r\n.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1092>
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:44 +0000 (20:15 +0200)]
vapostproc: Negotiate interlaced.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Copy missing fields at fixate.
When caps negotiation implies a caps feature change, some fields might
get lost. This patch brings them back from input caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Simplify size fixate.
gst_va_vpp_fixate_size() returned the fixated caps, but that is not
needed since `othercaps` are modified inline.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Simplify fixate.
The first approach to fixate was simply a copy&paste of both
videoconvert and videoscale, trying to keep their logic as isolated
as possible. But that brought duplicated and sparse logic.
This patch merge both approaches simplifying the fixate operation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 15:41:57 +0000 (17:41 +0200)]
va: filter, deinterlace, vpp: Add gst_va_buffer_get_surface_flags().
Add a helper function to get, from GstVideoInfo and GstBuffers flags,
the VA interlace surface flags. This is used currently by vainterlace
element, but it will be used in vapostproc too if it can process
interlaced frames.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>
Bastien Nocera [Wed, 13 Oct 2021 10:38:35 +0000 (12:38 +0200)]
build: Disable pygobject submodule if system version exists
If pygobject is available on the system, its version is new enough,
don't build the older pygobject and rely on that system one.
This fixes totem not being able to use libpeas' Python support.
** (totem:544972): WARNING **: 12:04:05.407: Error initializing Python Plugin Loader: PyGObject initialization failed
ImportError: could not import gobject (version mismatch, 3.40.1 is required, found 3.38.1)
Closes: #806
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1135>
Thibault Saunier [Sun, 26 Sep 2021 02:40:31 +0000 (23:40 -0300)]
tests: Blacklist some tests that recently failed
See:
- https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/739
- https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/740
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/927>
Bastien Nocera [Wed, 13 Oct 2021 08:38:07 +0000 (10:38 +0200)]
gtkglsink: Avoid assertion when applying "auto" rotation method
Guard against the orientation not coming from an inexistant tag, nor
from the application (rotation set to "auto") which caused an assertion.
When the application requests the auto rotation method, make sure it is
resolved to a rotation that's applicable.
ERROR:gstreamer/subprojects/gst-plugins-good/ext/gtk/gtkgstglwidget.c:745:gtk_gst_gl_widget_set_rotate_method: code should not be reached
Fixes:
103ceb853a5f7dade07a1ac4aa517e9df6ed5ded
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1134>
Philippe Normand [Mon, 4 Oct 2021 08:31:02 +0000 (09:31 +0100)]
soup: Runtime compatibility support for libsoup2 and libsoup3
The src and sink elements no longer link against libsoup. It is now loaded at
runtime. If any version is resident already, it is used. Otherwise we first try
to load libsoup3 and if it's not found we fallback to libsoup2.
For the unit-tests, we now build one version of the test unit file per libsoup
version found. So if both libsoup2 and libsoup3 are available on the host, the
CI will cover them both.
Based on initial patch by Daniel Kolesa <dkolesa@igalia.com> and
Patrick Griffis <pgriffis@igalia.com>.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1044>
Seungha Yang [Mon, 2 Aug 2021 08:46:37 +0000 (17:46 +0900)]
examples: playback-test: Fix for UI resize scenario on Windows
Application needs to notify videosink element of video widget resize
via gst_video_overlay_set_render_rectangle() since WM_SIZE event
wouldn't be notified.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1115>
Olivier Crête [Thu, 16 Apr 2020 03:41:52 +0000 (23:41 -0400)]
audio: Merge simd libs into the main one
Actually extract the .o objects from the convience libraries and put
them into the main one. Without this, they will just be referenced by
the .pc file, but it will be unusable because they are not installed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1122>
Jordan Petridis [Tue, 12 Oct 2021 19:09:35 +0000 (22:09 +0300)]
ci: have the fedora docker build depend on the trigger job
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1120>
Nirbheek Chauhan [Tue, 12 Oct 2021 21:28:29 +0000 (02:58 +0530)]
meson: Remove duplicate definition of 'examples' option
This is a hard error starting with Meson 0.60.0rc1, due to
https://github.com/mesonbuild/meson/pull/9184#issuecomment-
941603358
The upstream change might get reverted before release, but we should
of course fix this regardless.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1127>