Yeongjong Lee [Mon, 17 Feb 2020 10:28:27 +0000 (19:28 +0900)]
elementary_tizen/ctxpopup: rename widget_event to input_event_handler
`widget_event` has been renamed to `input_event_handler` since commit
298d112dbb1151fe119480af275931b45828fafd.
For tizen elc_ctxpopup, KeyEvent will work again.
Also, Fixes compiler warnings.
```
../src/lib/elementary_tizen/elc_ctxpopup.c:1314:1: warning: '_elm_ctxpopup_efl_ui_widget_event' defined but not used [-Wunused-function]
1314 | _elm_ctxpopup_efl_ui_widget_event(Eo *obj, Elm_Ctxpopup_Data *sd, Evas_Object *src EINA_UNUSED, Evas_Callback_Type type, void *event_info)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/lib/elementary_tizen/elc_ctxpopup.c:165:1: warning: '_key_action_move' defined but not used [-Wunused-function]
165 | _key_action_move(Evas_Object *obj, const char *params)
```
@tizen_fix
Change-Id: I95faa5d0d5647df276be03de109e45c2baaf6bfe
Yeongjong Lee [Mon, 17 Feb 2020 05:21:23 +0000 (14:21 +0900)]
elm_conform: comment out unused CONFORMANT_KEY
Change-Id: Idb4cc65936318550664b44b544509ce4516b080e
Subodh Kumar [Mon, 17 Feb 2020 09:03:40 +0000 (14:33 +0530)]
edje_text: Restore legacy edje text x fit calculation.
Current fit calculation is breaking some use cases from Tizen 4.0
example: Edit mode ctxpopup text
@tizen_fix
Change-Id: I785e5f53ae795952e8c2ac21c0c5b4b35f41607d
Felipe Magno de Almeida [Tue, 11 Feb 2020 17:48:26 +0000 (17:48 +0000)]
C#: Add error checking for Eina.Success_Flag return type
When a get and/or set from property is defined to return, explicitly,
a Eina.Success_Flag, the mono generator will check the return value
and generate an exception if the call fails.
Resolves T8383.
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11281
João Paulo Taylor Ienczak Zanette [Tue, 18 Feb 2020 19:17:56 +0000 (19:17 +0000)]
csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types
Adds a special case for "accessor" complex types in `implicit operator` for
structs and `IntPtr`s, in which an IEnumerator must be converted to/from an
IntPtr.
Reviewed-by: YeongJong Lee <cleanlyj@naver.com>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11210
Felipe Magno de Almeida [Thu, 30 Jan 2020 19:49:04 +0000 (16:49 -0300)]
eolian-mono: Make Get/Set internal for generated properties
Make Get and Set methods internal for properties that get the
property syntax generated.
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11252
Hermet Park [Tue, 18 Feb 2020 11:07:08 +0000 (20:07 +0900)]
Revert "canvas mask: fix incorrect render surface size."
This reverts commit
e3af5eb27f70edf531d5d8de3e3f2c940536d396.
Seems previous is correct. My misunderstanding.
Hermet Park [Tue, 18 Feb 2020 10:09:16 +0000 (19:09 +0900)]
canvas mask: fix incorrect render surface size.
This render context works on a mask surface,
Size should be mask's own, not canvas output size.
@fix
JunsuChoi [Tue, 18 Feb 2020 07:23:11 +0000 (16:23 +0900)]
Efl.Gfx.Path: Fix condition of for loop in current search
END enum is 0. Fixed due to
064690d46e7ed67becf9710588e7c37a31ab807f
@fix
Change-Id: I9c70d34c102d57284ae93f1e211f960ebe1dc555
Wonki Kim [Mon, 17 Feb 2020 12:57:01 +0000 (21:57 +0900)]
ecore: fix a memory leaking
this patch fixes a memory leaking.
Change-Id: I909d038812f2a66c6bd5e503b16767e73472f5bc
JunsuChoi [Tue, 18 Feb 2020 04:33:28 +0000 (13:33 +0900)]
elm_atspi_ewk_wrapper: Prevent memory leak
Change-Id: Id6e26224b2b4fdbf21134cdd2016ca0de37f8132
JunsuChoi [Mon, 17 Feb 2020 10:05:22 +0000 (19:05 +0900)]
edje: Disable the json vector animation feature with a flag.
Summary:
Json vector animation requires the json loader to be loaded.
Therefore, if the loader does not load,
it prints an appropriate error message and disables the feature.
Depends on D11228
Test Plan: N/A
Reviewers: Hermet, Jaehyun_Cho, id213sin
Reviewed By: Hermet
Subscribers: raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11230
Change-Id: I4c7b966189c8612d06ff44739d0e57b6d15c9faa
YoungBok Shin [Mon, 17 Feb 2020 09:59:09 +0000 (18:59 +0900)]
edje: add json file support feature
Summary:
It also starts to support following new edc properties.
This is backported patch from Tizen 5.0
1. frame
desc { "default"
vector {
frame: 0.5; // 0.0 ~ 1.0
}
}
2. actions
program { "vector_animation";
// VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
// VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
action: VG_ANIM_PLAY;
target: "your_vector_part";
}
@feature
Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
- Fix to remove Efl.Canvas.Animation_Player on edje
Test Plan:
{
F3840540}
{
F3840542}
{
F3840543}
make and test attached file
edje_cc -beta -id ./ json_edc.edc json.edj
gcc -o test test_edc.c -g `pkg-config --cflags --libs evas elementary rlottie`
./test
Reviewers: Hermet, Jaehyun_Cho, id213sin
Reviewed By: Hermet
Subscribers: segfaultxavi, raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11228
Change-Id: I3f27e381e5ae2ed76794ec738809c78f095cbc02
Xavi Artigas [Mon, 17 Feb 2020 11:35:00 +0000 (12:35 +0100)]
mono: Add "out" as a reserved word
This will turn it into kw_out just like it is done for "in".
Otherwise it cannot be used as a parameter name, for example.
Yeongjong Lee [Mon, 17 Feb 2020 09:48:11 +0000 (18:48 +0900)]
efl_ui_selection_manager: fix a compiler warning for Wayland support
Summary: `_sel_manager_seat_selection_get` is used only for x11.
Test Plan: meson build -Dx11=false -Dwl=true
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11363
Yeongjong Lee [Mon, 17 Feb 2020 09:47:54 +0000 (18:47 +0900)]
efl_ui_selection_manager: remove unnecessary variable
Summary: No logical changes.
Test Plan: meson build
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11362
Yeongjong Lee [Mon, 17 Feb 2020 06:36:03 +0000 (15:36 +0900)]
els_cursor: Fix a compiler warning for Wayland support
Summary:
`_curosors` is not used when Elementary is compiled for Wayland.
It Fixes a compiler warning.
```
../src/lib/elementary/els_cursor.c:46:26: warning: ‘_cursors’ defined but not used [-Wunused-variable]
static struct _Cursor_Id _cursors[] =
```
Test Plan: meson build -Dx11=false -Dwl=true
Reviewers: zmike, Hermet, Jaehyun_Cho
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11360
Yeongjong Lee [Mon, 17 Feb 2020 06:35:57 +0000 (15:35 +0900)]
edje_multisense: fix a compiler warning for pulseaudio disable mode
Summary: `_out_fail` is not used when edje is compiled without pulseaudio.
Test Plan: meson build -Dpulseaudio=false
Reviewers: zmike, Hermet, Jaehyun_Cho
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11361
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 18:37:06 +0000 (18:37 +0000)]
elm - scroller wheel accel - limit to avoid over/underflow
limit wheell accel multiplier to 100,000 ... this way sane values of
wheel_event->z will not overflow. also up intermediate coors to long
longs and clamp to be sure.
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 14:36:09 +0000 (14:36 +0000)]
edje player - make it more useful with padding option
so you can see the overflow outside and edje object, add padding as an
option to move the obj inside the win. this means also nuking the
over-engineered box stacking thing... :)
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 11:56:13 +0000 (11:56 +0000)]
ecore con - also be paranoid with same nul byte checks in path str
this won't affect the target system which doesn't do abstract sockets
anyway, and it's just unlink "" ... but check if first byte is nul for
an asbtract socket and dont do lock files or unlinking in this case
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 11:31:43 +0000 (11:31 +0000)]
ecore_con - on bsd if we get flock unlink old socket by force
trying to address other parts of the bsd socket hanging on bind() etc.
... unlink socket if we get the file lock as we should now have an
exclusive lock on the socket anyway - clear out the old one by force
once we have the lock.
Carsten Haitzler (Rasterman) [Fri, 14 Feb 2020 13:18:53 +0000 (13:18 +0000)]
eina file - close on exec - doesnt exist on windows - vtorri
Marcel Hollerbach [Fri, 14 Feb 2020 16:06:29 +0000 (17:06 +0100)]
evas: stop handdefining eo types
that is just technical dept carrying arround.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11356
Marcel Hollerbach [Fri, 14 Feb 2020 16:05:59 +0000 (17:05 +0100)]
efl_ui_spotlight_fade_manager: fix wrong typedef
the typedef used here is not really existing anymore.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11355
Yeongjong Lee [Fri, 14 Feb 2020 13:34:36 +0000 (08:34 -0500)]
elm_main: remove unreachable condition
Summary: The condition `!*p` is always false because of line 1336.
Reviewers: zmike, Hermet, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11349
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:49 +0000 (08:33 -0500)]
tests/evas: add simple test for skip_head property
Summary:
when using this property, there should be no mmap loaded after a call
to evas_object_image_file_set, and we want to make sure the image is
eventually loaded
ref T8378
Depends on D11340
Reviewers: raster
Reviewed By: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8378
Differential Revision: https://phab.enlightenment.org/D11341
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:43 +0000 (08:33 -0500)]
evas: restore codepath for loading images from files with skip_head set
Summary:
this was never handled during refactoring because it had already been
removed from the tree by that point
fix T8378
Depends on D11339
Reviewers: raster
Reviewed By: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8378
Differential Revision: https://phab.enlightenment.org/D11340
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:38 +0000 (08:33 -0500)]
Revert "evas: Compile out unused functions"
Summary:
This reverts commit
7d36ef88bcea82bfdc0146245e13d9e74572fa8f.
Depends on D11338
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11339
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:32 +0000 (08:33 -0500)]
Revert "evas: remove image_load from the engine."
Summary:
This reverts commit
867d826395f988b9a9cbc3b5f93bf57ce031885d.
Depends on D11337
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11338
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:26 +0000 (08:33 -0500)]
Revert "evas: remove unused fonction evas_gl_common_image_load."
Summary:
This reverts commit
fc7e244e99bbcaa8303e0e11a533d0d96b7525bd.
Depends on D11336
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11337
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:20 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_common_load_image_from_file."
Summary:
This reverts commit
7672d1050ea9e1050c27ce2eda68718ea054b638.
Depends on D11335
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11336
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:13 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_cache_engine_image_request."
Summary:
This reverts commit
90e1ca715402371575104814162bcddd3664a8ba.
Depends on D11334
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11335
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:07 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_cache_image_request."
Summary: This reverts commit
ee3f4e052956ceb49486efae72ece1eccd982b68.
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11334
Carsten Haitzler (Rasterman) [Thu, 13 Feb 2020 19:27:42 +0000 (19:27 +0000)]
ecore x - fix debug printf format to print time
Marcel Hollerbach [Mon, 3 Feb 2020 15:16:01 +0000 (16:16 +0100)]
efl_canvas_gesture: replace parse with import
we probebly want to use import here, as we want to rebuild this file
when efl_canvas_gesture_events is changed.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11273
Mike Blumenkrantz [Wed, 12 Feb 2020 14:02:48 +0000 (09:02 -0500)]
elm_test: add zoom recognizer handling to gesture test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11330
Mike Blumenkrantz [Tue, 11 Feb 2020 15:48:44 +0000 (10:48 -0500)]
efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type
this serves no purpose and isn't used anywhere
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11323
Mike Blumenkrantz [Tue, 11 Feb 2020 15:29:11 +0000 (10:29 -0500)]
efl/gesture: rework custom gesture recognizer methodology
this needs to return the actual gesture class type so that custom gesture
events can implement their own properties if necessary
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11322
Mike Blumenkrantz [Tue, 11 Feb 2020 15:10:57 +0000 (10:10 -0500)]
efl/gesture: improve docs
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11321
Mike Blumenkrantz [Tue, 11 Feb 2020 15:10:05 +0000 (10:10 -0500)]
efl/gesture: remove bespoke recognizer properties for tap timeout
this should all be managed by efl.config
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11320
Mike Blumenkrantz [Tue, 11 Feb 2020 15:08:23 +0000 (10:08 -0500)]
efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues
recognizers need to be able to get and set this appropriately
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11319
Mike Blumenkrantz [Fri, 7 Feb 2020 17:00:39 +0000 (12:00 -0500)]
efl/gesture: api renames for Efl.Canvas.Gesture_Touch
ref T8554
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11300
Mike Blumenkrantz [Fri, 7 Feb 2020 16:54:40 +0000 (11:54 -0500)]
efl/gesture: fix long tap timeout errors
this is the timer pointer, and we need to be able to delete the timer when
the gesture ends
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11299
Mike Blumenkrantz [Wed, 5 Feb 2020 14:55:50 +0000 (09:55 -0500)]
tests/gesture: add another tap test to check finger size works
add some move events in to shake up the recognizers and check whether
taps are still working
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11292
Mike Blumenkrantz [Wed, 5 Feb 2020 14:48:57 +0000 (09:48 -0500)]
efl/gesture: fix touch state tracking
correctly set 'pressed' member of touch data only on press events and
don't change it on move events in order to avoid having mismatched states
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11291
Mike Blumenkrantz [Tue, 4 Feb 2020 14:34:20 +0000 (09:34 -0500)]
efl/gesture: remove recognizer::reset method
this wasn't used and doesn't seem necessary
ref T8503
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11279
Mike Blumenkrantz [Mon, 3 Feb 2020 17:16:27 +0000 (12:16 -0500)]
efl/gesture: fix tap gesture type naming
we use c_enum_naming_style in our enums, not cSharpEnumNamingStyle
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11275
Mike Blumenkrantz [Mon, 3 Feb 2020 17:10:31 +0000 (12:10 -0500)]
efl/gesture: remove gesture_touch::multi_touch
this is redundant now that touch_count exists
ref T8554
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11274
Mike Blumenkrantz [Fri, 31 Jan 2020 15:44:23 +0000 (10:44 -0500)]
efl/gesture: rework gesture_recognizer::add to be a 'type' property
this simplifies (and optimizes) a bunch of code by letting gesture recognizers
return directly the type of gesture they recognize for use internally
ref T8503
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11267
Mike Blumenkrantz [Fri, 31 Jan 2020 14:55:06 +0000 (09:55 -0500)]
efl/gesture: use new config value for thumbscroll friction
the old one used here is marked deprecated
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11263
Mike Blumenkrantz [Wed, 5 Feb 2020 17:22:20 +0000 (12:22 -0500)]
elm/config: fix thumbscroll config
this was broken a while ago by failing to correctly update all the configs
ref
6409cfa41b19f04ef7b4247d078d626e9ec77a8f
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11294
Mike Blumenkrantz [Thu, 30 Jan 2020 16:40:40 +0000 (11:40 -0500)]
efl/config: add missing gesture config value handlers
these are stored in the config here so they should be manageable here as well
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11250
Mike Blumenkrantz [Thu, 30 Jan 2020 16:46:59 +0000 (11:46 -0500)]
efl/config: merge all gesture manager config code into efl.config
this is all just duplicated code, so we can deduplicate it with minimal
effort to clean up the api
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11251
Mike Blumenkrantz [Thu, 30 Jan 2020 16:39:52 +0000 (11:39 -0500)]
efl/win: change a couple config init sets for gesture manager to use legacy config
these values are deprecated, so stop setting them in efl_config
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11249
Mike Blumenkrantz [Thu, 30 Jan 2020 15:46:24 +0000 (10:46 -0500)]
efl/gesture: remove manager config
we can just use efl.config here instead of duplicating it
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11248
Mike Blumenkrantz [Thu, 30 Jan 2020 15:45:39 +0000 (10:45 -0500)]
efl/config: move C wrappers for this out of elm_config.h to Efl.h
this is beta API and belongs in its proper header
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11247
Mike Blumenkrantz [Wed, 29 Jan 2020 19:09:16 +0000 (14:09 -0500)]
efl/gesture: move manager's recognizer cleanup function to eo
this is needed by recognizers which use timers in order to do timeouts
on gestures
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11245
Marcel Hollerbach [Fri, 14 Feb 2020 07:58:43 +0000 (08:58 +0100)]
evas_model_loader: fix
8f3bef248bb0002cbbd40052eb759d1b2ae29ce9
The commit fixed a mem leak with freeing one element in the array, which
was never going to work, as only the array is a pointer you can
allocate.
This could have been discovered by simply running ninja test.
Marcel Hollerbach [Thu, 6 Feb 2020 09:52:08 +0000 (10:52 +0100)]
efl-check: do not print expected errors
that is just a waste of log space.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11297
Marcel Hollerbach [Thu, 6 Feb 2020 09:49:19 +0000 (10:49 +0100)]
eina-suite: do not print that many errors
we should expect errors in these conditions, this also safes a lot of
space in logs.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11296
SangHyeon Jade Lee [Fri, 14 Feb 2020 05:22:57 +0000 (14:22 +0900)]
elm : fix unintialized data set
Summary:
fw, fh can be referenced in _box_object_aspect_calc
without initialized when ax, ay is greater or equal than 0.
Reviewers: eagleeye
Reviewed By: eagleeye
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11348
WooHyun Jung [Fri, 14 Feb 2020 01:57:22 +0000 (10:57 +0900)]
edje_load: just remove unreachable code
WooHyun Jung [Fri, 14 Feb 2020 01:38:24 +0000 (10:38 +0900)]
edje_calc: add null checking and remove unreachable code
wonki kim [Mon, 17 Feb 2020 12:49:22 +0000 (12:49 +0000)]
Revert "ecore_con: fix a memory leaking"
This reverts commit
3471f879321089210a8ce0bee740598da1292c88.
Change-Id: I55efe076ebe594f18338e945ab03f74db6d36b58
Shinwoo Kim [Mon, 17 Feb 2020 12:29:56 +0000 (21:29 +0900)]
elm_transit: remove unnecessary image preload invocation
Summary:
If user uses image object with following step, then unnecessary preloading
related line is invocated in elm_image_file_set.
elm_image_file_set(obj, file, NULL)
elm_icon_preload_disabled_set(obj, EINA_TRUE)
The following is the preloading related line triggered by elm_image_file_set.
(#0) _image_preload_internal
(#1) _evas_image_load_async_start
(#2) evas_object_image_preload
(#3) _efl_ui_image_smart_internal_file_set
(#4) _efl_ui_image_efl_file_load
(#5) efl_file_load
(#6) efl_file_simple_load
(#7) elm_image_file_set
Moreover there is a flickering issue caused by the unnecessary preloading.
A test code is attached.
Test Plan:
Use following test code. The flickering issue occurs with `ELM_SCALE=10 ELM_ACCEL=gl ./test_transit`
{
F3847288}
Reviewers: Hermet, jsuya
Reviewed By: Hermet, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11364
Change-Id: I46f2acaa475a465b2a71c9a4e8911ca6c43af55f
Yeongjong Lee [Mon, 17 Feb 2020 05:02:44 +0000 (14:02 +0900)]
efl_ui_layout: add EFL_OBJECT_OP_FUNC for callback_priority_add
This code is missing after migration.
See also, commit
c471f4a90966e03d1cc80f204f3c7c20ef869618.
Fixes complier warnings.
```
[ 190s] [1723/2497] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha/efl_ui_layout.c.o'.
[ 190s] ../src/lib/elementary/efl_ui_layout.c:3272:1: warning: '_efl_ui_layout_base_efl_object_event_callback_array_priority_add' defined but not used [-Wunused-function]
[ 190s] 3272 | _efl_ui_layout_base_efl_object_event_callback_array_priority_add(Eo *obj, Efl_Ui_Layout_Data *pd, const Efl_Callback_Array_Item *array, Efl_Callback_Priority priority, const void *user_data)
[ 190s] ../src/lib/elementary/efl_ui_layout.c:3261:1: warning: '_efl_ui_layout_base_efl_object_event_callback_priority_add' defined but not used [-Wunused-function]
[ 190s] 3261 | _efl_ui_layout_base_efl_object_event_callback_priority_add(Eo *obj, Efl_Ui_Layout_Data *pd, const Efl_Event_Description *desc, Efl_Callback_Priority priority, Efl_Event_Cb func, const void *user_data)
```
@tizen_fix
Change-Id: I8b212b6e36ba151a593291091bd119794f035c93
Yeongjong Lee [Mon, 17 Feb 2020 06:53:43 +0000 (15:53 +0900)]
elm_index_eo: resotre missing state_set_get method
At commit
e1a5d0fe7c6768c4e2a9031e87e9b3c1bda9cad0,
`Efl.Access.state_set` was replaced with `Efl.Access.access_children`.
`Efl.Access.children` should have been replaced instead of `Efl.Access.state_set`.
And `Efl.Access.children` was removed at
fbf501b67ab58267fd9aa8ef36d8733fa6a49d98.
@tizen_fix
Change-Id: I23618db6000ea675f811f4c112770f83981d2213
Wonki Kim [Fri, 14 Feb 2020 12:27:03 +0000 (21:27 +0900)]
emile: fix a potention leaking
Change-Id: I07a41e7e04e499c41d77c80a735a97dce266a5fc
Wonki Kim [Fri, 14 Feb 2020 12:23:49 +0000 (21:23 +0900)]
emile: removing a using logic after free.
Change-Id: I24f2df638125bdf79447bf817d754902a58f2f5f
Wonki Kim [Fri, 14 Feb 2020 10:32:45 +0000 (19:32 +0900)]
ecore: fix a memory leak
this patch fixes a memory leaking
Change-Id: Ib218ec144243be6b8f9e188f76c559568afd5bbd
Wonki Kim [Fri, 14 Feb 2020 10:39:14 +0000 (19:39 +0900)]
ecore_con: fix a memory leaking
this removes a memory leaking
Change-Id: I82bdab8bc9e4f7811a2e5b08007104d298b1c5c5
Wonki Kim [Fri, 14 Feb 2020 10:44:56 +0000 (19:44 +0900)]
efl_con: add a default condition to switch statement
this patch add a default condition to switch to make code unreachable below.
Change-Id: I9c36084d0a9c9e481bc2b584513dede8fe3db8f0
Wonki Kim [Fri, 14 Feb 2020 12:11:03 +0000 (21:11 +0900)]
ecore_con: fix to check a return value of functions
this path fixes to check a return value of functions.
Change-Id: Ib53f31b446c7aa8f655b734d1b0e863421065ebd
Wonki Kim [Fri, 14 Feb 2020 11:09:09 +0000 (20:09 +0900)]
elementary: fix data los by dividing by integer
this patch fix a warning from static analyzer
Change-Id: I476ddb3a85e4b79df6c922f87d0eec5baf49f335
Wonki Kim [Fri, 14 Feb 2020 12:13:31 +0000 (21:13 +0900)]
efl_ui_scroller: fix a potentional null dereferencing
Change-Id: I5c3ce98d1183c252aabb27453e151f3772387ebf
Bowon Ryu [Fri, 14 Feb 2020 10:14:54 +0000 (19:14 +0900)]
edje: add null check for textblock styles
@tizen_fix
Change-Id: Ie7473e9f8353f39a1718b14b79c7b3d8eccdd5c3
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Hermet Park [Fri, 14 Feb 2020 09:40:31 +0000 (18:40 +0900)]
evas engine tbm: remove debugging logs.
These fprintf is not quite working well with tizen dlog system
Probably we can use ERR() otherwise remove them.
Change-Id: Ie583eaaf2c7edd13f6155fa6f3c4fb3dc1cf76dc
Hermet Park [Fri, 14 Feb 2020 09:38:30 +0000 (18:38 +0900)]
evas engine tbm: check return value as its spec designed.
Change-Id: I4054702831cd5f3684cf4b79ee5827e51ff4e275
Hermet Park [Fri, 14 Feb 2020 09:33:19 +0000 (18:33 +0900)]
ecore_evas tbm: check return value as its spec designed.
Change-Id: Idd8e41b6fcdc70a471b9056aeb0f798cf743bf35
Yeongjong Lee [Fri, 14 Feb 2020 09:17:25 +0000 (18:17 +0900)]
eina_rbtree: avoid defererencing null pointer
Summary: Pointer 'it->stack' is dereferenced at `_eina_rbtree_iterator_free`.
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11346
Change-Id: I93701e137d6901c84ff8eb1df8612e3455076b6e
Hermet Park [Fri, 14 Feb 2020 08:32:59 +0000 (17:32 +0900)]
elementary atspi_bridge: fix memory leak at the corner case
Change-Id: I1af3b84fa64946981fb71fd880925e611484bdf3
Yeongjong Lee [Fri, 14 Feb 2020 03:32:19 +0000 (12:32 +0900)]
elm_focus: comment out unreachable code
@tizen_fix
Change-Id: Ifd438824368103dcdc911dee7df2594d08100201
Hermet Park [Fri, 14 Feb 2020 08:22:53 +0000 (17:22 +0900)]
elementary value provider: replace sprintf() with snprintf()
Avoid vulerable function usage in the test code
Change-Id: I1d53f54b8ed7a13072664b6d3a3e4e29bc3771d4
Hermet Park [Fri, 14 Feb 2020 08:06:44 +0000 (17:06 +0900)]
canvas image: remove unnecessary condition check.
Change-Id: I3c006ff9ee42928af0d45fa8899f754f7c8438d1
JunsuChoi [Fri, 14 Feb 2020 07:27:27 +0000 (16:27 +0900)]
elm_dbus_menu: Remove unreached code.
Summary:
The property parameter used in this function are passed from _str_to_property.
_str_to_property does not pass anything other than the enum value.
Therefore this log is an unreached line.
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11347
Change-Id: I458013b5b64e3d295eb2b515fe4cec63b9b784da
JunsuChoi [Fri, 14 Feb 2020 07:27:12 +0000 (16:27 +0900)]
eldbus_service: Prevent memory leak
Summary:
If obj->introspection_data is null, the function returns
without freeing the memory.
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11345
Change-Id: I946cf88d4e86e7bf94e4dae8651b1fa7ff1ac013
JunsuChoi [Fri, 14 Feb 2020 07:26:52 +0000 (16:26 +0900)]
efl_ui_image : Avoid integral division
Summary:
Assigning a result of integral division to a double type variable
is not useful for division calculation.
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11344
Change-Id: I82c9f42a93cabc3145d9ac16234da2de3833d2e5
JunsuChoi [Fri, 14 Feb 2020 04:22:22 +0000 (13:22 +0900)]
efl_ui_win_socket: Prevent memory leak
Change-Id: Iecce6e57eee8648f5ccbaf45ac50d71fe92cec42
Woochanlee [Fri, 14 Feb 2020 05:32:19 +0000 (14:32 +0900)]
elc_multibuttonentry: Fix Svace warning.
fix unreachable condition.
Change-Id: Ib1209e121c4ddca103bcc39e2bcfacff6cea05b3
WGID: 424847
Hermet Park [Fri, 14 Feb 2020 04:51:46 +0000 (13:51 +0900)]
canvas model_loaders: fix memory leak in ply loader.
eina_str_split() newly allocate memory to return,
caller must take over its resource free..
Change-Id: Ie7d5651a6904f1c81a4dd353b87714c4accf4c2a
Hermet Park [Fri, 14 Feb 2020 04:42:43 +0000 (13:42 +0900)]
image loaders pmaps: decide data size at the compile time.
Change-Id: Ie92a4f2b016c99a6019aeb1a0a3e6391668e710c
Hermet Park [Fri, 14 Feb 2020 04:36:53 +0000 (13:36 +0900)]
canvas engine: + null check for safety
Change-Id: I9298eeccf9ebc4520de25681299a76f3d2b2d9b2
Hermet Park [Fri, 14 Feb 2020 04:27:11 +0000 (13:27 +0900)]
gl image: free the resource properly at the corner case.
Change-Id: I5b5f3cfce45b4c91c6879dbe1b2779e6361732af
Hermet Park [Fri, 14 Feb 2020 04:17:48 +0000 (13:17 +0900)]
gfx path: remove unreacheable code
Change-Id: Ib9271abf0526d4612b21bce5136105e7772bdc22
Hermet Park [Fri, 14 Feb 2020 04:15:11 +0000 (13:15 +0900)]
gfx path: + null check for safety
Change-Id: I9527c0d79353cb91084b157d27d5de2f42eabd34
Hermet Park [Fri, 14 Feb 2020 04:09:14 +0000 (13:09 +0900)]
gfx mapping: + null check for safety
Change-Id: Ia91a1ad303841012c62752523d2447138126e83d
Hermet Park [Fri, 14 Feb 2020 04:03:58 +0000 (13:03 +0900)]
canvas vector: remove unreacheable code.
pd->buffer is always false.
Change-Id: Ic4ae0b6c0fb5792a3a28f0334adbcd297a624d02
Hermet Park [Fri, 14 Feb 2020 03:58:18 +0000 (12:58 +0900)]
elementary genlist: remove duplicated instruction.
Change-Id: I67602e2e0834357fab871f8bcaa2e78025f86808
SangHyeon Jade Lee [Thu, 13 Feb 2020 12:42:45 +0000 (21:42 +0900)]
genlist: remove wrong null value check. itb is always existed and already dereferenced.
Change-Id: I9bb2d665296836606ec5f94ec10808e2d1ea76b8
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>