Taylon Silmer [Tue, 27 Apr 2010 18:21:27 +0000 (18:21 +0000)]
l10n: Updates to Portuguese (Brazilian) (pt_BR) translation
New status: 721 messages complete with 1 fuzzy and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
Panu Matilainen [Thu, 22 Apr 2010 10:48:58 +0000 (13:48 +0300)]
Protect rpmtsVerifyDB() with transaction lock
- BDB docs state that db->verify() doesn't perform any locking even
when used within an environment, and should only be used on files
that are not being modified by another thread of control. Grabbing
the transaction lock while verifying mostly ensures nobodys writing
to the db behind our back.
Panu Matilainen [Thu, 22 Apr 2010 09:49:03 +0000 (12:49 +0300)]
Ditch "fcntl_locking" bdb config option
- This is an undocumented BDB interface (only documented in the db.h header),
and its not something users should be messing around with
Panu Matilainen [Thu, 22 Apr 2010 09:23:24 +0000 (12:23 +0300)]
Make transaction lock path per-transaction
- Although it doesn't really happen in practise, rpm's API permits several
transactions with possibly differing roots within process lifetime.
Previously the lock path was calculated just once globally so we could
easily be locking in a completely wrong place (eg locking in a previously
accessed chroot when system rpmdb should be transaction-locked)
Panu Matilainen [Thu, 22 Apr 2010 08:01:27 +0000 (11:01 +0300)]
Further generalize the rpmlock interface
- Move transaction lock path handling into rpmts.c, export new low
level rpmlockAcquire() function to actually grab a lock
- Rename rpmtsFreeLock() to rpmlockFree() and return NULL in the
general rpm style
Panu Matilainen [Thu, 22 Apr 2010 07:44:38 +0000 (10:44 +0300)]
Generalize rpmlock_new() by moving transaction lock path calculation out
Panu Matilainen [Thu, 22 Apr 2010 07:37:51 +0000 (10:37 +0300)]
Make rpmlock type visible inside rpm, use instead of void*
Panu Matilainen [Wed, 21 Apr 2010 10:00:43 +0000 (13:00 +0300)]
Lose the useless header refcounting debug junk
- one more of these still left behind.. pff
Rakesh Pandit [Wed, 14 Apr 2010 11:14:52 +0000 (16:44 +0530)]
Eliminate unused "known problems" based filtering from rpmtsRun()
- This mechanism has never been used by anything at all, which suggests
its not a particularly useful feature
- Removing unused rpmpsTrim() from rpmps
- Marking okProbs parameter of rpmtsRun() function as unused to avoid
unnecessary breakage
Alexey Tourbin [Wed, 21 Apr 2010 07:10:15 +0000 (11:10 +0400)]
rpmdb.c (dbiOpen): fix dbix condition
In the loop, dbix is always initialized to 0, so checking (dbix < 0)
is uselss. Insetead, we sould check (dbix >= dbiTagsMax).
Panu Matilainen [Thu, 15 Apr 2010 07:24:03 +0000 (10:24 +0300)]
Only check the type of dependency requested in checkInstDeps()
- This gets called separately for requires, conflicts and obsoletes,
wth should it loop over conflicts when looking for requires?
Panu Matilainen [Wed, 14 Apr 2010 09:24:37 +0000 (12:24 +0300)]
Add a basic reinstall test to test-suite
- this currently fails due to commit
e16695e932e294ec600e673d38c41bde20931204,
on reinstall element header vs db header mismatch, adding this as
a reminder to fix it...
Panu Matilainen [Wed, 14 Apr 2010 06:22:07 +0000 (09:22 +0300)]
...but make sure the pre-requisite isn't also an erasure-dependency
- fixes eg Requires(pre,postun) case which must not be filtered out here
Panu Matilainen [Wed, 14 Apr 2010 06:05:55 +0000 (09:05 +0300)]
Pre-requisites of installed packages dont need to be verified (RhBug:223642)
Panu Matilainen [Tue, 13 Apr 2010 05:50:08 +0000 (08:50 +0300)]
Update a few tag descriptions + visibility
- RPMTAG_CAPABILITY and RPMTAG_RHNPLATFORM are truly obsolete and
should've been taken out a long time ago
Panu Matilainen [Tue, 13 Apr 2010 05:35:45 +0000 (08:35 +0300)]
Use correct tag for NOPATCH
- dumb copy-paste error from commit
a317eaadc3f7b9b4ec373719e7d60fb8b98e2c21
Panu Matilainen [Tue, 13 Apr 2010 05:32:49 +0000 (08:32 +0300)]
RPMTAG_NOSOURCE and NOPATCH aren't internal, they end up in nosrc headers
Michael Schroeder [Mon, 12 Apr 2010 10:12:46 +0000 (12:12 +0200)]
Gnu tar sometimes prints a "tar: Record size = 16" message, breaking
rpmbuild -ta.
Michael Schroeder [Mon, 12 Apr 2010 10:11:56 +0000 (12:11 +0200)]
Adapt the Makefile as rpmdb_svc can no longer be built.
Michael Schroeder [Mon, 12 Apr 2010 10:11:05 +0000 (12:11 +0200)]
New gcc versions comlpain about undefined behaviour...
Michael Schroeder [Mon, 12 Apr 2010 10:10:20 +0000 (12:10 +0200)]
readLineFromOFI may modify the fileStack, thus we have to re-set
ofi after calling it
Michael Schroeder [Mon, 12 Apr 2010 10:09:04 +0000 (12:09 +0200)]
Do not load keyring if signature checking is disabled.
Michael Schroeder [Mon, 12 Apr 2010 10:07:01 +0000 (12:07 +0200)]
Seems like a change was made to make %attr(-) go back to the
defattr setting. Unfortunatelly this broke %defattr(-).
Panu Matilainen [Fri, 9 Apr 2010 13:36:17 +0000 (16:36 +0300)]
Clean up dbiOpen() a bit
- eliminate now redundant rc-condition, move local variables to the
scope their used in
Panu Matilainen [Fri, 9 Apr 2010 12:52:29 +0000 (15:52 +0300)]
Move environment open "refcounting" to db_init() / db_fini()
Panu Matilainen [Fri, 9 Apr 2010 12:06:59 +0000 (15:06 +0300)]
And now lose db_use_env from rpmdb struct
- Environment is always used, shared if possible private otherwise
Panu Matilainen [Fri, 9 Apr 2010 11:53:31 +0000 (14:53 +0300)]
Simplify the dbenv->open() flags shuffle
- We always create an environment. If we dont have permissions to create
or join a shared environment, we use a private environment. Instead
of trying to figure out what to do beforehand, retry dbenv->open()
with different flags to see if it succeeds. This eliminates some
potential races when others might create/remove the environment
while we're pondering about appropriate flags.
- Lose the "create" bdb config option, this is something we always
want to decide internally.
- Remove "force" bdb config option, DB_FORCE is dbenv->remove() option
and its value clashes with DB_CREATE...
Panu Matilainen [Fri, 9 Apr 2010 08:16:37 +0000 (11:16 +0300)]
Move dbi_use_dbenv from dbi to rpmdb, this is a per-rpmdb setting
Panu Matilainen [Fri, 9 Apr 2010 07:50:32 +0000 (10:50 +0300)]
Move dbhome directory create/verify to openDatabase()
- all db opens must go through openDatabase(), no need to track this
with a separate variable on each index open
Panu Matilainen [Thu, 8 Apr 2010 13:15:16 +0000 (16:15 +0300)]
Eliminate DB_JOINENV usage and config option
- DB_JOINENV is a no-op since BDB >= 4.4
Panu Matilainen [Thu, 8 Apr 2010 13:07:58 +0000 (16:07 +0300)]
Eliminate "thread" BDB option
- this is not something that users should be tweaking
- its never been enabled, leave it that way for now
Panu Matilainen [Thu, 8 Apr 2010 13:04:37 +0000 (16:04 +0300)]
Lose redundant dbi_use_env check
- its always enabled when we get here, but might get turned off
in the initialization process (at least for now)
Panu Matilainen [Thu, 8 Apr 2010 13:01:20 +0000 (16:01 +0300)]
A little bit of sanity to dbiNew()
- lose the hysterical dbi_use_env condition and usedbenv option
this is always enabled
- ensure mpool is always initialized, lose the config option (this
is a mandatory BDB subsystem, not a bleeping configurable)
- let pagesize be what it is even when no configuration is present
- avoid overriding dbi_mmapsize and dbi_cachesize if set in the configuratio
- these are all per-environment, not per-dbi settings but for now...
Panu Matilainen [Thu, 8 Apr 2010 11:39:07 +0000 (14:39 +0300)]
Eliminate exclusive and rdonly BDB configuration options
- we never want DB_CREATE to cause failure - let BDB create the
db if it needs to, otherwise DB_CREATE doesn't do anything
- rdonly is decided elsewhere, not in bleeping configuration
Panu Matilainen [Thu, 8 Apr 2010 11:37:51 +0000 (14:37 +0300)]
Mop up ancient BDB leftovers
Panu Matilainen [Thu, 8 Apr 2010 11:36:55 +0000 (14:36 +0300)]
Eliminate BDB transaction tuning knobs from configuration
- we dont support transactions yet, and this stuff doesn't
belong to "user configuration" anyhow, these are just useless
Panu Matilainen [Thu, 8 Apr 2010 10:59:05 +0000 (13:59 +0300)]
db_env_create() doesn't take any flags currently
Panu Matilainen [Thu, 8 Apr 2010 10:46:13 +0000 (13:46 +0300)]
Remove per-dbi perms and configuration
- the file permissions are per-db global, no need to be able to
speficy different modes for indexes
Panu Matilainen [Thu, 8 Apr 2010 10:39:08 +0000 (13:39 +0300)]
Remove per-dbi mode and configuration
- read/write/create mode is global to the entire db, either its
just readonly or its not
- this doesn't belong to configuration
Panu Matilainen [Thu, 8 Apr 2010 09:33:19 +0000 (12:33 +0300)]
Require BDB >= 4.5 for sanity's sake
- replace unused feature tests in configure.ac with a simple version check
Panu Matilainen [Thu, 8 Apr 2010 07:53:08 +0000 (10:53 +0300)]
Remove unused dbi_txnid member from dbiIndex
- transactions aren't currently used, we'll need txnid handles eventually
but the dbi is unlikely to be the right level to store this, add
where actually needed when the time comes
Panu Matilainen [Thu, 8 Apr 2010 07:31:00 +0000 (10:31 +0300)]
db_create() doesn't take any flags currently
Panu Matilainen [Thu, 8 Apr 2010 06:10:13 +0000 (09:10 +0300)]
Eliminate dbiIndexNewItem()
- this is just simple struct with no special allocation, and contents
are memcpy()'ed so theres no need to malloc it
Panu Matilainen [Wed, 7 Apr 2010 10:23:03 +0000 (13:23 +0300)]
Change nextInstance() to permit retrieval too, use it for bitmap alloc
- The "was this verified already" bitmap uses header instance numbers
which are monotonically increasing and can be much much larger than
the number of actually installed headers. Grab the current instance
number for a better idea how much we'll at least need.
- Throw out the db stats based dbiNumKeys(), this doesn't have the
kind of performance penalty that stats have and suits our purposes
better anyway
Panu Matilainen [Wed, 7 Apr 2010 09:43:20 +0000 (12:43 +0300)]
Make rpmdbAdd() and rpmdbRemove() internal-only
- all additions and removals to the rpmdb need to go through the
transaction machinery, these are very low-level functions that
API users have no business messing with
Panu Matilainen [Wed, 7 Apr 2010 09:38:20 +0000 (12:38 +0300)]
Stash rpmdb struct definition out of sight into dbi.h
- not perhaps the ideal place for it but the backend level needs
access to the main db in several places anyway, and this leaves
rpmdb_internal.h clear for internal-only APIs
Panu Matilainen [Wed, 7 Apr 2010 09:28:02 +0000 (12:28 +0300)]
Unify rpmdbAdd/Remove() interfaces
- rpmdbRemove() takes now a header as argument too - we need both
the header number and the header itself there anyway, so might as
well use the header we already have instead of flipping through backwards
hoops to get to it
Panu Matilainen [Wed, 7 Apr 2010 09:12:51 +0000 (12:12 +0300)]
Eliminate the headerCheck() foo from rpmdbAdd/Remove()
- for rpmdbRemove() these have been completely unused, and for rpmdbAdd()
the higher levels have had more than one chance of verifying the
header if checking is enabled in the transaction set
Panu Matilainen [Wed, 7 Apr 2010 08:11:55 +0000 (11:11 +0300)]
Lift RPMDBI_PACKAGES handling from db add/remove to separate helper
- Remove vs add is rather similar, unify the copy-pasteish code
- Be a bit more careful about error returns from the primary db functions
Panu Matilainen [Wed, 7 Apr 2010 06:18:44 +0000 (09:18 +0300)]
Lift header instance number figuring out of rpmdbAdd() to helper function
Panu Matilainen [Wed, 7 Apr 2010 05:58:23 +0000 (08:58 +0300)]
Verify header sanity as the first thing in rpmdbAdd()
- avoid allocating header instance for something that we'd fail to add
- avoid possibly adding data to indexes even if adding the header
itself fails, duh
Panu Matilainen [Wed, 7 Apr 2010 05:35:14 +0000 (08:35 +0300)]
Move header INSTALLTID manipulation out of rpmdbAdd()
Panu Matilainen [Wed, 7 Apr 2010 04:48:33 +0000 (07:48 +0300)]
Remove unused require- and provideversion indexes
- For completely unused indexes, these are fairly expensive too
Panu Matilainen [Wed, 7 Apr 2010 03:55:15 +0000 (06:55 +0300)]
Eliminate redundant/bogus temporary variable shuffling
- This fetches the special key zero which is used for bookkeeping of
header "instance" numbers, the actual header to be stored is NOT
relevant here
- keyp, keylen, datap and datalen are just redundant fluff, manipulate
the key and data DBT directly
Panu Matilainen [Tue, 6 Apr 2010 10:13:14 +0000 (13:13 +0300)]
Remove unused _DBI defines
Panu Matilainen [Tue, 6 Apr 2010 10:09:34 +0000 (13:09 +0300)]
Lose unused fluff from openDatabase()
- As RPMDBI_PACKAGES is always the first index, the for-loop never
did anything else than open the Packages db and exit with success/fail.
For the same reason RPMDB_FLAG_MINIMAL didn't do anything at all here,
lose the unnecessary flag..
Panu Matilainen [Tue, 6 Apr 2010 10:02:58 +0000 (13:02 +0300)]
Eliminate static _rebuildinprogress hack, use per-db flag instead
- replace unused RPMDB_FLAG_CHROOT with RPMDB_FLAG_REBUILD and pass
around as necessary
Panu Matilainen [Tue, 6 Apr 2010 09:59:06 +0000 (12:59 +0300)]
Bury rpmdb flags inside rpmdb.c, not used by anything outside it
Panu Matilainen [Mon, 5 Apr 2010 15:09:57 +0000 (18:09 +0300)]
Unbreak --rebuilddb
- managed to bust up the rebuilddb-path generation once again in commit
890cea56c91ff6ff887a439c036d345715e6c5c2, doh
- make the intended logic more obviours
Yuri Chornoivan [Mon, 5 Apr 2010 07:22:31 +0000 (07:22 +0000)]
l10n: Updates to Ukrainian (uk) translation
Transmitted-via: Transifex (www.transifex.net)
Misha Shnurapet [Fri, 2 Apr 2010 12:55:37 +0000 (12:55 +0000)]
l10n: Updates to Russian (ru) translation
Transmitted-via: Transifex (www.transifex.net)
Panu Matilainen [Thu, 1 Apr 2010 15:19:49 +0000 (18:19 +0300)]
Nuke bogus comments + related NULL-checks
- db->_dbi cannot be NULL if db is not NULL, it's allocated at
newRpmDB() and freed in rpmdbClose() and nothing else touches it
Panu Matilainen [Thu, 1 Apr 2010 14:59:38 +0000 (17:59 +0300)]
Clean up rpmdb struct initialization
- lose the dumb template assignment and related defines
Panu Matilainen [Thu, 1 Apr 2010 14:49:07 +0000 (17:49 +0300)]
Lose unused static initialization foo
Panu Matilainen [Thu, 1 Apr 2010 13:58:12 +0000 (16:58 +0300)]
Clean up formatting in rpmdbCountPackages() (just cosmetics)
Panu Matilainen [Thu, 1 Apr 2010 13:29:38 +0000 (16:29 +0300)]
Remove unused rpmdbCloseDBI()
- this was used by the Depends temporary db hack, forcing it
to be exposed in the API... not anymore
Panu Matilainen [Thu, 1 Apr 2010 12:28:45 +0000 (15:28 +0300)]
Generate package database statistics on close & make use of it on open
- Turn dbiStat() into more useful: return the number of keys in the
index, hiding away the BDB internal access method stuff into the backend
- Force statistics gathering at Packages db close, take advantage of
that when its opened to get a fairly accurate count of packages for
initial "header verified" bitmap allocation. Previously DB_FAST_STAT
was used on open but it never returns anything when no stats have
been previously collected, hence the need for the expensive slow stat.
- The performance hit from stat generation is hardly worth it for
the bitmap allocation alone, but lets see if there are other uses...
- Also gets rid of dbi_stats member, this is not particularly useful
Panu Matilainen [Thu, 1 Apr 2010 10:54:39 +0000 (13:54 +0300)]
Lose "support" for truly ancient BDB versions
- BDB >= 4.3 is required now, and even thats several years old
Panu Matilainen [Thu, 1 Apr 2010 09:48:17 +0000 (12:48 +0300)]
Rename dbiOpen() + dbiOpenDB() to make their layer obvious from the name
- dbiOpen() in rpmdb.c operates on "rpmdb layer" so calling it
rpmdbOpenIndex(), dbiOpenDB() on the other hand is the lowest level
backend thing, which is now called dbiOpen() to be in line with
the other operations like dbiClose()
Panu Matilainen [Thu, 1 Apr 2010 09:34:59 +0000 (12:34 +0300)]
Pass rpmdb to dbiFindByLabel() / rpmdbiFindMatch() directly
- avoids having to go backwards from the dbi to rpmdb when we very well
have the rpmdb handle at hand here...
Panu Matilainen [Thu, 1 Apr 2010 09:25:04 +0000 (12:25 +0300)]
Eliminate dbi_rpmtag member from dbiIndex struct
- the backend doesn't care about the tag beyond initialization,
and the tag is only used for error messages from rpmdb layer which
already knows what the tag is
Panu Matilainen [Thu, 1 Apr 2010 09:01:28 +0000 (12:01 +0300)]
Define + use enum for primary/secondary index types + api to get it
- no functional changes, making the type more obvious than
"case 2*sizeof(int32_t):"
Panu Matilainen [Thu, 1 Apr 2010 08:47:15 +0000 (11:47 +0300)]
Rename the dbi access method member dbi_type -> dbi_dbtype
- make it more obvious what it is
Panu Matilainen [Thu, 1 Apr 2010 08:13:37 +0000 (11:13 +0300)]
Split dbiIndex out of rpmdb_internal.h into header of its own
- the dbi presents an internal api of its own, and deserves a separate
header (baby steps to making dbiIndex opaque outside the backend)
- move dbiVerify() to the backend where it belongs
- mark all the dbiFoo() functions as internal
Panu Matilainen [Thu, 1 Apr 2010 07:25:55 +0000 (10:25 +0300)]
Eliminate unnecessary argument to dbiCopen()
- txnid (which is unused...) is stored in dbi so dbiCopen() can already
get to it
Panu Matilainen [Thu, 1 Apr 2010 07:18:05 +0000 (10:18 +0300)]
Move dbi_no_dbsync logic to inside dbiSync()
- avoids having to check for it in every single caller
Panu Matilainen [Thu, 1 Apr 2010 07:03:21 +0000 (10:03 +0300)]
On header iteration format queries, dump the contents as-is
- This makes eg --xml query of packages give out the true contents
of the package, raw i18n strings and all, which is what you probably
want when examining the contents on this level. Regular queries still
run with all bells 'n whistless enabled.
Panu Matilainen [Thu, 1 Apr 2010 06:15:06 +0000 (09:15 +0300)]
Disable header i18n lookup in headerCopyTags() (RhBug:578299)
- without HEADERGET_RAW here, only one of the translations in header
(whatever happens to be "current" locale) gets copied
Panu Matilainen [Wed, 31 Mar 2010 09:17:00 +0000 (12:17 +0300)]
Remove BDB recno + queue access methods from configuration
- these rather limited access methods have never been used for anything,
rpm always used hash access and later btree to varying degree
Panu Matilainen [Tue, 30 Mar 2010 23:51:39 +0000 (02:51 +0300)]
Database metadata integer byte order is not user serviceable config
Panu Matilainen [Tue, 30 Mar 2010 23:48:03 +0000 (02:48 +0300)]
Lose dbi file configuration option
- index names are rpm tag names, period
- also we dont need to strdup() the tag name, rpmTagGetName() returns
pointers to const strings these days
Panu Matilainen [Tue, 30 Mar 2010 23:47:33 +0000 (02:47 +0300)]
Make dbiVerify() and dbiOpen() static, not needed outside rpmdb.c
Panu Matilainen [Tue, 30 Mar 2010 23:37:13 +0000 (02:37 +0300)]
Bury dbiIndexItem and dbiIndexSet structs inside rpmdb.c
Panu Matilainen [Tue, 30 Mar 2010 23:34:21 +0000 (02:34 +0300)]
Make dbiIndexSet operations static inside rpmdb.c
Panu Matilainen [Tue, 30 Mar 2010 23:16:54 +0000 (02:16 +0300)]
Lose the BDB access method configuration options
- In the ~10 years of their existance none of them have been used,
and besides users have no business messing with fundamental database
behavior such as whether duplicates are allowed or not
Panu Matilainen [Tue, 30 Mar 2010 23:04:21 +0000 (02:04 +0300)]
We really dont care about macro expanded per-db error prefix
Panu Matilainen [Tue, 30 Mar 2010 22:59:27 +0000 (01:59 +0300)]
Lose shmkey + shared BDB config options
- we dont want anything to do with System V IPC, really... BDB uses
file backed mmap when it needs, this suits us just fine
Panu Matilainen [Tue, 30 Mar 2010 22:55:06 +0000 (01:55 +0300)]
Remove "truncate" BDB config option
- Truncate is so dangerous that dbiOpenDB() discarded it even if
set in configuration. How useful is that?
Panu Matilainen [Tue, 30 Mar 2010 22:53:12 +0000 (01:53 +0300)]
We dont want to use DB_HOME environment, ever
- rpm has its own switches for overriding the db home when that's
necessary, DB_HOME it should use not
Panu Matilainen [Tue, 30 Mar 2010 22:45:26 +0000 (01:45 +0300)]
We dont have any temporary databases anymore, lose the config switches
- The last temporary db was Depends which is now replaced with an
in-memory hash, and the temporary dbs were troublesome with
chroot operations anyway, good riddance
Panu Matilainen [Tue, 30 Mar 2010 22:41:04 +0000 (01:41 +0300)]
Lose pointless per-db and per-dbi errfile and errcall pointers
- BDB uses stderr for errfile when not set, which is what we set it
to through various hoops. Just leave it alone.
- db_errcall has always been (intentionally) NULL to disable that output,
the errors get logged though cvtdberr() with slight filtering
Panu Matilainen [Tue, 30 Mar 2010 22:27:04 +0000 (01:27 +0300)]
Shred a pile of BDB config goo that's never been actually implemented
- with the exception subfile (used by now extinct sqlite backend)
none of this was ever even connected to the bdb configuration...
Panu Matilainen [Tue, 30 Mar 2010 22:12:15 +0000 (01:12 +0300)]
Shed the pointless per-dbi memory allocators
- we want to use our own allocators for exit-on-enomem behavior but
having per-index allocator configuration makes no sense whatsoever
Panu Matilainen [Tue, 30 Mar 2010 22:09:51 +0000 (01:09 +0300)]
Eliminate now unnecessary db_ndbi field, number of indexes is constant
Panu Matilainen [Tue, 30 Mar 2010 22:05:03 +0000 (01:05 +0300)]
Make rpmdb index list hard-wired
- We dont grow new indexes every other day, and especially this
is not activity that users need to be able to do
- Gets rid of the hysterical initialization and million can't happen
NULL-checks
Panu Matilainen [Tue, 30 Mar 2010 21:43:34 +0000 (00:43 +0300)]
Minor cleanup to rpmdbAdd()
- move dbiOpen() + check to more sensible place, curing the
busted indentation
- initialize at declaration save a few unnecessary lines
Panu Matilainen [Tue, 30 Mar 2010 21:40:23 +0000 (00:40 +0300)]
Add + use a helper function for retrieving single header at offset
Panu Matilainen [Tue, 30 Mar 2010 20:23:53 +0000 (23:23 +0300)]
Minor cleanups to rpmdbAdd() and rpmdbRemove()
Panu Matilainen [Tue, 30 Mar 2010 20:11:21 +0000 (23:11 +0300)]
Minor cleanup to rpmdbRebuild(), use rstreq() instead of hand-comparing
Panu Matilainen [Mon, 29 Mar 2010 15:36:21 +0000 (18:36 +0300)]
Hide rpmte open/close/error etc logic inside rpmteProcess()
- make a bunch of helper functions static now that they're not needed
elsewhere, rpmte is slowly becoming self-aware ;)