reed [Tue, 25 Nov 2014 03:59:22 +0000 (19:59 -0800)]
free up picturerecorder refs after returning picture or drawable
this just accelerates what would happen on the next beginRecording() call or the destructor. chrome has unittests that break (shaders on the stack) if we hold on to the internals past endRecording().
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
758813002
reed [Tue, 25 Nov 2014 03:11:48 +0000 (19:11 -0800)]
more c
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
736133006
tfarina [Tue, 25 Nov 2014 01:53:55 +0000 (17:53 -0800)]
Cleanup: Remove bug_chomper entry from .gitignore.
This is not necessary anymore, now that bug_chomper was moved into
skia.googlesource.com/buildbot.git
BUG=None
TBR=borenet@google.com
Review URL: https://codereview.chromium.org/
748363002
mtklein [Mon, 24 Nov 2014 22:45:47 +0000 (14:45 -0800)]
SkRecord: outline methods that are not called O(N) times.
Looks like a noop-to-minor-win:
tabl_sahadan.skp 94.9us -> 98.6us 1x
desk_jsfiddlebigcar.skp 38.9us -> 39.7us 1x
desk_silkfinance.skp 78us -> 78.9us 1x
desk_jsfiddlehumperclip.skp 43.8us -> 44.3us 1x
desk_sfgate.skp 547us -> 548us 1x
tabl_gmail.skp 19.9us -> 19.8us 1x
tabl_worldjournal.skp 230us -> 229us 1x
desk_css3gradients.skp 248us -> 247us 1x
tabl_cnn.skp 205us -> 203us 0.99x
desk_linkedin.skp 342us -> 340us 0.99x
desk_wowwiki.skp 1.63ms -> 1.62ms 0.99x
tabl_cnet.skp 142us -> 141us 0.99x
desk_pokemonwiki.skp 9.76ms -> 9.67ms 0.99x
desk_espn.skp 267us -> 264us 0.99x
desk_youtube.skp 576us -> 570us 0.99x
tabl_pravda.skp 238us -> 235us 0.99x
tabl_ukwsj.skp 566us -> 560us 0.99x
tabl_engadget.skp 630us -> 622us 0.99x
desk_googlespreadsheetdashed.skp 1.66ms -> 1.64ms 0.99x
desk_mobilenews.skp 486us -> 480us 0.99x
tabl_googlecalendar.skp 211us -> 208us 0.99x
desk_samoasvg.skp 740us -> 730us 0.99x
desk_gws.skp 187us -> 184us 0.99x
desk_ebay.skp 234us -> 230us 0.99x
desk_mapsvg.skp 1.6ms -> 1.58ms 0.98x
tabl_nytimes.skp 130us -> 128us 0.98x
tabl_googleblog.skp 305us -> 300us 0.98x
desk_fontwipe.skp 40.3us -> 39.6us 0.98x
desk_tigersvg.skp 189us -> 186us 0.98x
tabl_androidpolice.skp 662us -> 650us 0.98x
desk_wordpress.skp 824us -> 809us 0.98x
tabl_mlb.skp 338us -> 331us 0.98x
tabl_culturalsolutions.skp 390us -> 382us 0.98x
desk_baidu.skp 213us -> 208us 0.98x
tabl_gspro.skp 72.9us -> 71.1us 0.97x
tabl_nofolo.skp 74us -> 71.9us 0.97x
desk_yahooanswers.skp 173us -> 168us 0.97x
tabl_frantzen.skp 57.3us -> 55.6us 0.97x
desk_chalkboard.skp 891us -> 865us 0.97x
desk_pinterest.skp 154us -> 149us 0.97x
desk_blogger.skp 537us -> 519us 0.97x
tabl_hsfi.skp 10.1us -> 9.69us 0.96x
desk_gmailthread.skp 333us -> 318us 0.96x
tabl_digg.skp 926us -> 883us 0.95x
desk_googlespreadsheet.skp 586us -> 558us 0.95x
desk_forecastio.skp 101us -> 95.7us 0.95x
desk_booking.skp 1.1ms -> 1.04ms 0.95x
tabl_deviantart.skp 144us -> 136us 0.95x
desk_facebook.skp 584us -> 553us 0.95x
desk_weather.skp 289us -> 272us 0.94x
desk_googlehome.skp 61.1us -> 57.5us 0.94x
desk_googleplus.skp 914us -> 849us 0.93x
desk_twitter.skp 499us -> 463us 0.93x
BUG=skia:
Review URL: https://codereview.chromium.org/
756783002
Mike Klein [Mon, 24 Nov 2014 22:44:23 +0000 (17:44 -0500)]
Don't count a leading 1 as a signficant digit in the ratio.
What used to look like this:
desk_pokemonwiki.skp 9.38ms -> 9.76ms 1x
tabl_pravda.skp 237us -> 241us 1x
desk_css3gradients.skp 249us -> 254us 1x
....
desk_fontwipe.skp 39.6us -> 38.7us 0.98x
tabl_digg.skp 922us -> 893us 0.97x
tabl_gmail.skp 20.7us -> 20us 0.96x
Now will print more like this:
desk_pokemonwiki.skp 9.38ms -> 9.76ms 1.04x
tabl_pravda.skp 237us -> 241us 1.02x
desk_css3gradients.skp 249us -> 254us 1.02x
....
desk_fontwipe.skp 39.6us -> 38.7us 0.98x
tabl_digg.skp 922us -> 893us 0.97x
tabl_gmail.skp 20.7us -> 20us 0.96x
BUG=skia:
Review URL: https://codereview.chromium.org/
756643004
reed [Mon, 24 Nov 2014 22:41:51 +0000 (14:41 -0800)]
option to return drawable from recording
patch from issue
747033005 at patchset 80001 (http://crrev.com/
747033005#ps80001)
BUG=skia:
Review URL: https://codereview.chromium.org/
732653004
Mike Klein [Mon, 24 Nov 2014 22:31:54 +0000 (17:31 -0500)]
Blink hasn't rolled yet, better.
BUG=skia:
Review URL: https://codereview.chromium.org/
758693002
mtklein [Mon, 24 Nov 2014 22:28:55 +0000 (14:28 -0800)]
Revert of Blink hasn't rolled yet. (patchset #1 id:1 of https://codereview.chromium.org/
754133002/)
Reason for revert:
Not thorough enough.
Original issue's description:
> Blink hasn't rolled yet.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
fa14113d0563686af9f7e2d8e041dd7bf538cfa2
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
752303002
reed [Mon, 24 Nov 2014 22:13:55 +0000 (14:13 -0800)]
restore old convention of asserting refcnt==1 in destructor
BUG=skia:
Review URL: https://codereview.chromium.org/
757563003
Mike Klein [Mon, 24 Nov 2014 21:26:15 +0000 (16:26 -0500)]
Blink hasn't rolled yet.
BUG=skia:
Review URL: https://codereview.chromium.org/
754133002
mtklein [Mon, 24 Nov 2014 21:09:39 +0000 (13:09 -0800)]
make SkRefCnt::getRefCnt() debug-only, remove it from SkNVRefCnt.
Only (unused) API removed.
TBR=reed@google.com
BUG=skia:3160
Review URL: https://codereview.chromium.org/
752263002
mtklein [Mon, 24 Nov 2014 20:39:59 +0000 (12:39 -0800)]
Add nanobench stats scripts to Skia repo.
These are the scripts I've been homegrowing for measuring perf impact. I think we found them useful today as a way of sifting through the noise.
BUG=skia:
Review URL: https://codereview.chromium.org/
703713002
bsalomon [Mon, 24 Nov 2014 20:19:05 +0000 (12:19 -0800)]
Revert "Use scratch keys for stencil buffers."
This reverts commit
91175f19664a62851da4ca4e0984a7c7c45b258f.
Revert "Cleanup res cache bench and split out into a unit test."
This reverts commit
4e4303f002c5958c6c958e7ba8e49b24c25f0b22.
Revert "rebaselines"
This reverts commit
65ba7b57759bfca60b24bc34dc46fc8caaf146f0.
TBR=tomhudson@google.com
Review URL: https://codereview.chromium.org/
752233002
reed [Mon, 24 Nov 2014 20:02:31 +0000 (12:02 -0800)]
add some debugging to SkNVRefCnt
BUG=skia:
Review URL: https://codereview.chromium.org/
745383003
tomhudson [Mon, 24 Nov 2014 19:27:41 +0000 (11:27 -0800)]
Revert of More rebaselines (patchset #1 id:1 of https://codereview.chromium.org/
754833003/)
Reason for revert:
Reverted causative patchset (https://codereview.chromium.org/
747043004)
Original issue's description:
> More rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/
0ef7ba2a43a41e8e1e49a5187073db6dcca345b4
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
756633004
tomhudson [Mon, 24 Nov 2014 19:24:46 +0000 (11:24 -0800)]
Revert of more rebaselines (patchset #1 id:1 of https://codereview.chromium.org/
755653003/)
Reason for revert:
Reverted causative patch (https://codereview.chromium.org/
747043004)
Original issue's description:
> more rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/
f2fdc8b746acac9daa94b21d3849f60a87064fd4
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
754103002
tomhudson [Mon, 24 Nov 2014 19:22:36 +0000 (11:22 -0800)]
Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #1 id:1 of https://codereview.chromium.org/
750973003/)
Reason for revert:
Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/
747043004/); suspecting driver bug?
Original issue's description:
> Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/
754653002/)
>
> Reason for revert:
> Suspected in DM crashes, e.g.
>
> 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp
> Signal 11:
> _sigtramp (+0x1a)
> create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
> test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
> skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
> skiatest::Test::run() (+0x7c)
> DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
> DM::GpuTask::run(GrContextFactory*) (+0xa6)
> DM::TaskRunner::wait() (+0x7f)
> dm_main() (+0x33f)
> main (+0x27)
>
>
> On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
>
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
>
>
> Original issue's description:
> > Add gpu support for Apple specific 'Vertex Arrays' functions
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
af000f469e1b0153ce445c96ca3d20e6d12224cc
>
> TBR=bsalomon@google.com,paraboul@gmail.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
55fe3d7748b873e362edc4e6a43bd77914ed25fb
TBR=bsalomon@google.com,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
734633005
robertphillips [Mon, 24 Nov 2014 18:56:21 +0000 (10:56 -0800)]
Suppress additional multipicturedraw GM for Android
One Android bot is failing on the rect test case.
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
750203003
robertphillips [Mon, 24 Nov 2014 18:23:07 +0000 (10:23 -0800)]
Sigh - remove whitespace from end of suppressions text line
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
754783003
robertphillips [Mon, 24 Nov 2014 18:06:47 +0000 (10:06 -0800)]
Add suppressions for https://codereview.chromium.org/
748853002
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
753103005
tomhudson [Mon, 24 Nov 2014 17:59:41 +0000 (09:59 -0800)]
Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/
754653002/)
Reason for revert:
Suspected in DM crashes, e.g.
2033 tasks left 344M peak 843ms tabl-cuteoverload_skp
Signal 11:
_sigtramp (+0x1a)
create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
skiatest::Test::run() (+0x7c)
DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
DM::GpuTask::run(GrContextFactory*) (+0xa6)
DM::TaskRunner::wait() (+0x7f)
dm_main() (+0x33f)
main (+0x27)
On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
Original issue's description:
> Add gpu support for Apple specific 'Vertex Arrays' functions
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
af000f469e1b0153ce445c96ca3d20e6d12224cc
TBR=bsalomon@google.com,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
750973003
robertphillips [Mon, 24 Nov 2014 17:49:17 +0000 (09:49 -0800)]
Add support for hoisting layers in pictures drawn with a matrix
Although Chromium doesn't use the drawPicture matrix parameter for their tiling, our local code does. Without such drawPicture calls break layer hoisting.
BUG=skia:2315
Review URL: https://codereview.chromium.org/
748853002
mtklein [Mon, 24 Nov 2014 17:11:45 +0000 (09:11 -0800)]
Add Sk prefix to CreateBitmapShader.
It's neither static nor namespaced, so we should probably prefix it.
BUG=skia:
Review URL: https://codereview.chromium.org/
754083002
scroggo [Mon, 24 Nov 2014 17:05:35 +0000 (09:05 -0800)]
Remove android-framework-only unused parameter.
Allows -Werror=unused-parameter to build on android framework.
Review URL: https://codereview.chromium.org/
757633002
bsalomon [Mon, 24 Nov 2014 16:39:08 +0000 (08:39 -0800)]
More rebaselines
TBR=
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
754833003
bsalomon [Mon, 24 Nov 2014 16:25:05 +0000 (08:25 -0800)]
Cleanup res cache bench and split out into a unit test.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
754833002
mtklein [Mon, 24 Nov 2014 16:20:57 +0000 (08:20 -0800)]
Remove Picture deletion listeners.
Looks like we can just have ~SkPicture put the message on the bus directly.
BUG=skia:3144
Review URL: https://codereview.chromium.org/
751663002
bsalomon [Mon, 24 Nov 2014 16:13:49 +0000 (08:13 -0800)]
more rebaselines
TBR=
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
755653003
bsalomon [Mon, 24 Nov 2014 16:03:24 +0000 (08:03 -0800)]
rebaselines
NOTRY=true
NOTREECHECKS=true
TBR=
Review URL: https://codereview.chromium.org/
753133003
paraboul [Mon, 24 Nov 2014 15:05:27 +0000 (07:05 -0800)]
Add gpu support for Apple specific 'Vertex Arrays' functions
BUG=skia:
Review URL: https://codereview.chromium.org/
754653002
bsalomon [Mon, 24 Nov 2014 15:05:15 +0000 (07:05 -0800)]
Use scratch keys for stencil buffers.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
747043004
qiankun.miao [Mon, 24 Nov 2014 14:59:44 +0000 (06:59 -0800)]
Cleanup of S32_D565_Opaque_SSE2()
BUG=skia:
Review URL: https://codereview.chromium.org/
725693003
bsalomon [Mon, 24 Nov 2014 14:47:48 +0000 (06:47 -0800)]
Create GrOptDrawState directly in the cmd buffer in GrIODB.
Review URL: https://codereview.chromium.org/
746243002
reed [Mon, 24 Nov 2014 02:37:14 +0000 (18:37 -0800)]
use int instead of size_t to match skia convention
BUG=skia:
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
753903002
skia.buildbots [Sun, 23 Nov 2014 06:47:34 +0000 (22:47 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
747323005
skia.buildbots [Sat, 22 Nov 2014 07:06:21 +0000 (23:06 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
728943003
mtklein [Fri, 21 Nov 2014 22:42:35 +0000 (14:42 -0800)]
Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of https://codereview.chromium.org/
702893003/)
Reason for revert:
Not clean yet.
Original issue's description:
> Add -ftrapv to debug builds.
>
> This adds instrumentation to check that signed integers never under- or
> overflow, which is undefined behavior.
>
> BUG=skia:3096
>
> Committed: https://skia.googlesource.com/skia/+/
ebacb6127a952910f43a59460af43427d93df46c
TBR=bungeman@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3096
Review URL: https://codereview.chromium.org/
751713002
bsalomon [Fri, 21 Nov 2014 22:38:06 +0000 (14:38 -0800)]
Add pop_back to GrTRecorder.h
Review URL: https://codereview.chromium.org/
750613002
mtklein [Fri, 21 Nov 2014 22:24:04 +0000 (14:24 -0800)]
Add -ftrapv to debug builds.
This adds instrumentation to check that signed integers never under- or
overflow, which is undefined behavior.
BUG=skia:3096
Review URL: https://codereview.chromium.org/
702893003
bungeman [Fri, 21 Nov 2014 21:18:34 +0000 (13:18 -0800)]
Clean up FreeType code for 2.3.8.
We already require FreeType 2.3.8 in order to compile and run.
Make this requirement explicit and take advantage of it.
Review URL: https://codereview.chromium.org/
748063003
mtklein [Fri, 21 Nov 2014 20:52:46 +0000 (12:52 -0800)]
ack verylargebitmap diffs
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
752693002
mtklein [Fri, 21 Nov 2014 20:20:35 +0000 (12:20 -0800)]
SkPicture::SnapshotArray doesn't really stand to benefit from refcounting.
BUG=skia:
Review URL: https://codereview.chromium.org/
748803005
mtklein [Fri, 21 Nov 2014 20:10:33 +0000 (12:10 -0800)]
Switch SkBitmapProcState's SkFractionalInt to 32.32.
16 bits are not enough to hold the integral part of fx in
Clamp_S32_opaque_D32_nofilter_DX_shaderproc.
Weirdly, no GM diffs on my desktop.
BUG=skia:3096
Review URL: https://codereview.chromium.org/
733163003
mtklein [Fri, 21 Nov 2014 19:41:35 +0000 (11:41 -0800)]
Simplfy DEPS: always pull all deps, remove unused barelinux platform.
Left some notes about where we might further clean up.
BUG=skia:
Review URL: https://codereview.chromium.org/
753633002
mtklein [Fri, 21 Nov 2014 19:38:53 +0000 (11:38 -0800)]
Watch out for SkFixed overflow in SkMipMap.cpp.
Tested with -fsanitize=signed-integer-overflow.
This new assert used to trigger in MipMap unit test.
Don't appear to be any GM diffs.
BUG=skia:
Review URL: https://codereview.chromium.org/
729373004
mtklein [Fri, 21 Nov 2014 19:13:15 +0000 (11:13 -0800)]
public SkNVRefCnt<SnapshotArray>
Should fix broken build.
NOTRY=true
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
748143002
mtklein [Fri, 21 Nov 2014 19:06:04 +0000 (11:06 -0800)]
SkData -> SkPicture::SnapshotArray
Restores type safety with all the same features.
(Also note, less code: 29 insertions, 50 deletions.)
BUG=skia:
Review URL: https://codereview.chromium.org/
746553002
reed [Fri, 21 Nov 2014 18:27:53 +0000 (10:27 -0800)]
clarify samplecount field in imagegpu
BUG=skia:
TBR=bsalomon
Review URL: https://codereview.chromium.org/
750023002
robertphillips [Fri, 21 Nov 2014 18:16:25 +0000 (10:16 -0800)]
Fix error in Ganesh' tiled bitmap drawing
When the paint filter level is high ShouldUseBicubic doesn't always return true. In this case the paint's filter level will differ from the filtering Ganesh will use. This was leading to a mismatch between the tiling computed in SkGpuDevice::drawBitmapCommon and the one in SkGpuDevice::drawTiledBitmap.
The end result of this was that the max texture restriction could be violated which is currently being seen on the Xoom & N7 bots. Both of them have a max texture size of 2048 which is invoking the tiled drawbitmap case.
Review URL: https://codereview.chromium.org/
752623002
joshualitt [Fri, 21 Nov 2014 17:03:45 +0000 (09:03 -0800)]
remove GrAllocPool
BUG=skia:
Review URL: https://codereview.chromium.org/
742253002
mtklein [Fri, 21 Nov 2014 16:48:35 +0000 (08:48 -0800)]
All the small packing tweaks mentioned in the bug.
BUG=skia:3144
Review URL: https://codereview.chromium.org/
748063002
reed [Fri, 21 Nov 2014 16:46:37 +0000 (08:46 -0800)]
add SkImage::newSurface
BUG=skia:
Review URL: https://codereview.chromium.org/
741763002
reed [Fri, 21 Nov 2014 16:07:41 +0000 (08:07 -0800)]
simplify uniqueID code in picture
patch from issue
750003002 at patchset 1 (http://crrev.com/
750003002#ps1)
BUG=skia:
Review URL: https://codereview.chromium.org/
752573002
robertphillips [Fri, 21 Nov 2014 15:24:01 +0000 (07:24 -0800)]
Ignore a flaky msaa4 GM and some perma-broken S4 GMs
The Ubuntu12 msaa4 image seems to flake randomly
The S4 images are covered by skia:3116 (Galaxy S4 exhibits some saveLayer bugs (both normal and with hoisting))
TBR=humper@google.com
Review URL: https://codereview.chromium.org/
748773003
robertphillips [Fri, 21 Nov 2014 14:53:00 +0000 (06:53 -0800)]
Fix memory leak in nanobench
This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/
731973005/)
Review URL: https://codereview.chromium.org/
730343003
mtklein [Fri, 21 Nov 2014 14:48:43 +0000 (06:48 -0800)]
Small changes to get things building and running on Linux/ARM.
ninja -C out/Debug works, and I tested out/Debug/dm --nogpu (no X yet).
The only problems encountered were:
- Like CrOS, I also needed to use the default float ABI (presumably hard).
- The strings in GrBinHashKeyTest weren't necessarily 4-byte aligned.
BUG=skia:
Review URL: https://codereview.chromium.org/
746043002
robertphillips [Fri, 21 Nov 2014 14:19:36 +0000 (06:19 -0800)]
Add MultiPictureDraw to nanobench
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
TBR=bsalomon@google.com
Committed: https://skia.googlesource.com/skia/+/
0ddad31012dabfc1267effc8071d37f7d606efbe
Review URL: https://codereview.chromium.org/
731973005
robertphillips [Fri, 21 Nov 2014 13:50:21 +0000 (05:50 -0800)]
Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/
731973005/)
Reason for revert:
Needs more work
Original issue's description:
> Add MultiPictureDraw to nanobench
>
> I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
>
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
0ddad31012dabfc1267effc8071d37f7d606efbe
TBR=mtklein@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
750583002
robertphillips [Fri, 21 Nov 2014 13:35:54 +0000 (05:35 -0800)]
Add MultiPictureDraw to nanobench
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
731973005
fmalita [Fri, 21 Nov 2014 04:44:04 +0000 (20:44 -0800)]
Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (patchset #1 id:1 of https://codereview.chromium.org/
735233003/)
Reason for revert:
Chrome unit_tests failures on Mac & Win, blocking the roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/5613
Original issue's description:
> SkCanvas::clear() should call down to devices even when the clip is empty.
>
> SkDrawIter had a lovely, completely unused, option for this. Oversight?
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
378e70d8e561b72a904286ea231946f5c8345b9a
TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
748733002
tfarina [Fri, 21 Nov 2014 02:20:06 +0000 (18:20 -0800)]
Cleanup: Delete webtry.gyp
Looks like this was left over when we moved it into buildbot.
Also remove a few other, now unnecessary, references to webtry.
BUG=None
R=humper@google.com
Review URL: https://codereview.chromium.org/
726833004
joshualitt [Fri, 21 Nov 2014 00:51:50 +0000 (16:51 -0800)]
rebasing a bunch of 0% android mismatches
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
744383002
joshualitt [Thu, 20 Nov 2014 22:50:39 +0000 (14:50 -0800)]
Adding GeometryData object
BUG=skia:
Review URL: https://codereview.chromium.org/
745663002
cdalton [Thu, 20 Nov 2014 22:30:08 +0000 (14:30 -0800)]
Rebaseline textblobshader expectation for nvpr
Rebaseline after https://codereview.chromium.org/
712223002. The
difference is a result of using different bounding boxes to cover
gradient fills, which caused a few pixels do differ by a value of one.
BUG=skia:
Review URL: https://codereview.chromium.org/
746603002
Florin Malita [Thu, 20 Nov 2014 21:56:22 +0000 (16:56 -0500)]
Add SkNVRefCnt::getRefCnt()
Used in Blink unit tests.
TBR=mtklein@google.com,humper@google.com
Review URL: https://codereview.chromium.org/
746693002
fmalita [Thu, 20 Nov 2014 18:44:58 +0000 (10:44 -0800)]
Disable LCD text explicitly in SkPictureImageFilter::onFilterImage()
As an intermediate fix for
https://code.google.com/p/skia/issues/detail?id=3142, we can use a
non-public SkCanvas constructor and force-disable LCD text.
BUG=skia:3142
R=reed@google.com,senorblanco@google.com
Review URL: https://codereview.chromium.org/
725243004
mtklein [Thu, 20 Nov 2014 18:07:54 +0000 (10:07 -0800)]
Add SkNVRefCnt::deref().
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
744853002
bsalomon [Thu, 20 Nov 2014 17:56:11 +0000 (09:56 -0800)]
Don't use NULL GrOptDrawState to indicate that draw should be skipped.
Review URL: https://codereview.chromium.org/
742853002
mtklein [Thu, 20 Nov 2014 17:18:31 +0000 (09:18 -0800)]
Add SkNVRefCnt, prune down SkPicture's size
SkNVRefCnt is a variant of SkRefCnt that's Not Virtual, so weighs 4 bytes
instead of 8 or 16. There's only benefit to doing this if the deriving class
does not otherwise need a vtable, e.g. SkPicture.
I've stripped out some cruft from SkPicture, rearranged fields to pack tightly,
and added compile asserts for the sizes of SkPicture, SkRecord, and
SkVarAlloc.
BUG=skia:3144
Review URL: https://codereview.chromium.org/
741793002
mtklein [Thu, 20 Nov 2014 17:14:28 +0000 (09:14 -0800)]
SkRecord: Pack SkRegion::Op and AA bit together.
Saves 4 bytes per clip op.
BUG=skia:
Review URL: https://codereview.chromium.org/
741093002
mtklein [Thu, 20 Nov 2014 16:58:02 +0000 (08:58 -0800)]
SkCanvas::clear() should call down to devices even when the clip is empty.
SkDrawIter had a lovely, completely unused, option for this. Oversight?
BUG=skia:
Review URL: https://codereview.chromium.org/
735233003
bsalomon [Thu, 20 Nov 2014 16:02:46 +0000 (08:02 -0800)]
Stop overloading internal_dispose in SkTextBlob and SkData
Review URL: https://codereview.chromium.org/
737093002
mtklein [Thu, 20 Nov 2014 16:01:09 +0000 (08:01 -0800)]
Make sure pictures draw Clears even when the clip is empty.
We fix this by rewriting empty queries to very tiny queries, which will certainly
hit ops that span the entire picture (like Clear) and hopefully not much more.
(This doesn't quite work in the full cull rect world if [0,0,ε,ε] doesn't
overlap the picture. Let's cross that bridge when we get there.)
BUG=432991
Review URL: https://codereview.chromium.org/
732723004
joshualitt [Thu, 20 Nov 2014 15:28:52 +0000 (07:28 -0800)]
dstCopy on optdrawstate
BUG=skia:
Review URL: https://codereview.chromium.org/
735363003
rosca [Thu, 20 Nov 2014 15:24:32 +0000 (07:24 -0800)]
Preventing division by 0 in non-separable blend mode shaders.
In the software path, the same issue has been fixed some time ago:
https://codereview.chromium.org/
114173002
BUG=skia:
Review URL: https://codereview.chromium.org/
666043003
kkinnunen [Thu, 20 Nov 2014 06:49:03 +0000 (22:49 -0800)]
Implement conics for NVPR
Implement conics for NVPR. Verified with currently disabled conicpaths
gm, produces mostly same shapes with nvprmsaa4 and msaa4.
BUG=skia:2033
Review URL: https://codereview.chromium.org/
694503003
Greg Humphreys [Wed, 19 Nov 2014 22:28:53 +0000 (17:28 -0500)]
even more stragglers -- hopefully this makes the gtx machine go green?
BUG=skia:
Review URL: https://codereview.chromium.org/
716243005
Greg Humphreys [Wed, 19 Nov 2014 22:02:31 +0000 (17:02 -0500)]
more rebaseline stragglers
BUG=skia:
Review URL: https://codereview.chromium.org/
726373004
mtklein [Wed, 19 Nov 2014 21:36:19 +0000 (13:36 -0800)]
Store DM failures in an array, not a single string.
This should fix the problem where a repeatedly failing test causes this assertion:
../../src/core/SkString.cpp:572: failed assertion "length >= 0 && length < SkToInt(kBufferSize)"
Example output:
0 GMs x 7 configs, 2 tests, 0 pictures
0 tasks left, 100 failed
Failures:
test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount()
test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount()
test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount()
test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount()
< 95 lines elided >
test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount()
100 failures.
BUG=skia:
Review URL: https://codereview.chromium.org/
741833002
Greg Humphreys [Wed, 19 Nov 2014 21:35:20 +0000 (16:35 -0500)]
a few straggling rebaselines
BUG=skia:
Review URL: https://codereview.chromium.org/
742893002
bsalomon [Wed, 19 Nov 2014 20:36:22 +0000 (12:36 -0800)]
Small cleanups after GrDrawState/GrOptDrawState base class elimination.
Review URL: https://codereview.chromium.org/
739133004
tomhudson [Wed, 19 Nov 2014 18:41:14 +0000 (10:41 -0800)]
Implement SkPicture::bytesUsed() for SkRecord backend
BUG=chromium:230419
R=mtklein@google.com,reed@google.com
Review URL: https://codereview.chromium.org/
490253003
mtklein [Wed, 19 Nov 2014 18:37:20 +0000 (10:37 -0800)]
No need to short circuit the query rect here anymore.
Whatever assertion was triggering in SkRTree.cpp seems to be gone now.
BUG=432991
Review URL: https://codereview.chromium.org/
725373003
mtklein [Wed, 19 Nov 2014 17:41:27 +0000 (09:41 -0800)]
Remove debug-only fData from SKTDArray.
It makes the code harder to read, and makes Debug and Release SkTDArrays
different sizes. Looks like fData is left over from when debuggers weren't
very good at inspecting data structures.
No API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
739263002
joshualitt [Wed, 19 Nov 2014 17:38:51 +0000 (09:38 -0800)]
scissor state on optstate
waiting
BUG=skia:
Review URL: https://codereview.chromium.org/
742763002
fmalita [Wed, 19 Nov 2014 17:23:22 +0000 (09:23 -0800)]
Add an image filter row to GM:lcdtextprops
We should be disabling LCD text when rendering image filters, but
currently don't. Add a GM to capture this behavior.
R=reed@google.com
Review URL: https://codereview.chromium.org/
741433003
bsalomon [Wed, 19 Nov 2014 16:59:58 +0000 (08:59 -0800)]
Remove /arch:SSE2 from Win 64 Release builds
Review URL: https://codereview.chromium.org/
740733002
humper [Wed, 19 Nov 2014 16:32:19 +0000 (08:32 -0800)]
add runtime config option to retain stream for custom typefaces
BUG=skia:
Review URL: https://codereview.chromium.org/
729973004
joshualitt [Wed, 19 Nov 2014 16:24:09 +0000 (08:24 -0800)]
move GrGeometryProcessor to src
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
739943003
bsalomon [Wed, 19 Nov 2014 16:23:49 +0000 (08:23 -0800)]
Create GrOptDrawState before recording draw in GrInOrderDrawBuffer
Review URL: https://codereview.chromium.org/
739673002
reed [Wed, 19 Nov 2014 16:04:34 +0000 (08:04 -0800)]
Allow pictures to have a full bounds
This reverts commit
7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264.
BUG=skia:
Review URL: https://codereview.chromium.org/
738083002
reed [Wed, 19 Nov 2014 15:17:16 +0000 (07:17 -0800)]
Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/
736583004/)
Reason for revert:
needed to update legacy width() helpers
Original issue's description:
> allow pictures to have a full bounds
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
7e76bff26e7c74902841ca4f607eb0b24a833a4a
TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
722043005
reed [Wed, 19 Nov 2014 14:59:41 +0000 (06:59 -0800)]
allow pictures to have a full bounds
BUG=skia:
Review URL: https://codereview.chromium.org/
736583004
egdaniel [Wed, 19 Nov 2014 14:22:39 +0000 (06:22 -0800)]
Add processor name to comment when printing out shaders.
BUG=skia:
Review URL: https://codereview.chromium.org/
735153002
reed [Wed, 19 Nov 2014 13:03:18 +0000 (05:03 -0800)]
add roundOut that returns its result
BUG=skia:
Review URL: https://codereview.chromium.org/
742663002
skia.buildbots [Wed, 19 Nov 2014 07:06:53 +0000 (23:06 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
738003002
reed [Wed, 19 Nov 2014 02:06:45 +0000 (18:06 -0800)]
change roundOut() to take a dst, so we can use that signature to return IRect
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/
731373003
joshualitt [Wed, 19 Nov 2014 01:38:35 +0000 (17:38 -0800)]
setting patch_primitive_nvprmsaa4 on K1 to ignore
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
743563003
joshualitt [Tue, 18 Nov 2014 22:24:27 +0000 (14:24 -0800)]
drawinfo carries bufferinfo
BUG=skia:
Review URL: https://codereview.chromium.org/
737723003
Greg Humphreys [Tue, 18 Nov 2014 20:42:19 +0000 (15:42 -0500)]
ignore dashcubics test pending skia bug 2049
BUG=skia:2049
Review URL: https://codereview.chromium.org/
741533002