Brian Sullivan [Thu, 30 Mar 2017 22:03:49 +0000 (15:03 -0700)]
Merge pull request #10513 from briansull/profile-data
Crossgen support for ExcludeHotMethodCode and ExcludeColdMethodCode
Pat Gavlin [Thu, 30 Mar 2017 22:02:10 +0000 (15:02 -0700)]
Fix Issue #10022. (#10587)
This issue occurred because the JIT currently inserts the P/Invoke
method prolog into the first block of a function without ensuring that
this block will only execute once. This is not safe, as executing the
P/Invoke prolog multiple times can create cycles in the frame list and
casue the stack unwinder to hang.
This change ensures that lowering inserts a new, single-entry basic
block at the beginning of the function for functions that require P/Invoke prologs.
Jonghyun Park [Thu, 30 Mar 2017 21:20:01 +0000 (06:20 +0900)]
[x86/Linux] Use CDECL instead of STDCALL (#10410)
[x86/Linux] Use CDECL instead of STDCALL
Use STDCALL/THISCALL/FASTCALL if callconv is explicitly specified
Merge two adjustment (argument/alignment) into one
Bruce Forstall [Thu, 30 Mar 2017 21:16:47 +0000 (14:16 -0700)]
Merge pull request #10228 from mskvortsov/ryujit-arm32-copy-barrier
[RyuJIT/ARM32] Enable GT_COPY and GT_MEMORYBARRIER
Jarret Shook [Thu, 30 Mar 2017 20:46:59 +0000 (13:46 -0700)]
Merge pull request #10588 from jashook/add_correct_failure_metadata_for_b08046
Re-disable b08046 and add correct metadata.
Sujin Kim [Thu, 30 Mar 2017 20:37:13 +0000 (05:37 +0900)]
[Ryujit/ARM32] Implement NYI related with overflow for ARM (#10491)
* Implement NYI(overflow checks) for ARM
On last comment of #8496, the NYI message of overflow checks is printed after running the CodeGenBringUpTests.
That was the message about temp register setup for overflow checks.
It was referenced
https://github.com/dotnet/coreclr/blob/master/src/jit/lsraarm64.cpp#L399
I think it doesn't make any problem even though writing it the same as arm64.
* modifiy for coding convention
* Implement NYI : Unimplmented GT_CAST:int <--> int with overflow
I think it doesn't make any problem even though writing it the same as arm64.
So I copied parts of CodeGen::genIntToIntCast() and modified some below codes.
```
if (emitter::emitIns_valid_imm_for_cmp(castInfo.typeMax, cmpSize))
```
-->
```
if (emitter::emitIns_valid_imm_for_cmp(castInfo.typeMax, INS_FLAGS_DONT_CARE))
```
* Implement NYI : genLongToIntCast: overflow check
I copied and pasted codes from codegenxarch.cpp.
But It seemed be necessary that conditional execution values are changed by each architectures.
So I used 'genJumpKindForOper' for getting the emitJumpKind value.
The sample app has been checked to work well.
* Modify the implementation of emitter::emitIns_valid_imm_for_cmp
According to reference manual, I figured out CMP and ADD have different mechanisms on ARM unlike ARM64.
So I defined "...for_cmp" function not just use "..for_add" in the function likes ARM64.
Joseph Tremoulet [Thu, 30 Mar 2017 18:57:06 +0000 (14:57 -0400)]
Merge pull request #10569 from sdmaclea/PR-FIX-10359
Handle null ref in Compiler::optCreateAssertion
jashook [Thu, 30 Mar 2017 18:07:13 +0000 (11:07 -0700)]
Re-disable b08046 and add correct metadata.
\JIT\Regression\CLR-x86-JIT\V1.2-M01\b08046\b08046\b08046.cmd was disabled because the issue #2414
was closed but the tests tagged with that issue were not removed. b08046's correct issue is #4849.
Sean Gillespie [Thu, 30 Mar 2017 17:11:28 +0000 (10:11 -0700)]
Fix an issue where the DAC and GC versions of the heap_segment data structure did not agree on the location of the heap field (#10576)
Fix formatting
Andrey Akinshin [Thu, 30 Mar 2017 13:25:42 +0000 (18:25 +0500)]
Fix magic number explanation in filetime.cpp (#10582)
89 * 366 + 280 * 365 equals to 134774 (not 134744)
Igor Kulaychuk [Thu, 30 Mar 2017 09:54:02 +0000 (12:54 +0300)]
[Linux][GDB-JIT] Remove (nothrow) when using new (#10457)
* Merge ByteTypeInfo into PrimitiveTypeInfo
* Remove ArrayTypeInfo ownership over its array element type
ArrayTypeInfo should not delete memory for its array element type
because element type is owned by NotifyGdb::PTK_TypeInfoMap.
* Make NamedRefTypeInfo to own its value type pointer
* Fix memory leak when creating ArrayTypeInfo
* Refactor creation of PrimitiveTypeInfo class
* Move code from GetTypeInfoFromTypeHandle to ClassTypeInfo constructor
* Move code from GetTypeInfoFromTypeHandle to RefTypeInfo constructor
* Remove (nothrow) usage from GetTypeInfoFromTypeHandle function
* Remove most usages of (nothrow) from gdbjit
* Remove all remaining (nothrow) usages from gdbjit
* Throw COR_E_NOTSUPPORTED from GetTypeInfoFromTypeHandle when dumping unsupported types
* Remove (nothrow) usage from MemBuf::Resize
* Use NewArrayHolder for vars in FunctionMember class
* Use NewArrayHolder for m_type_name in TypeInfoBase class
* Use NewArrayHolder for m_typedef_name in TypeDefInfo class
* Use NewArrayHolder for m_member_name in TypeMember class
* Use NewArrayHolder for m_var_name in VarDebugInfo class
* Use NewArrayHolder for members in ClassTypeInfo class
* Add m_symbol_name field to Elf_Symbol struct for managing symbol name memory
* Add m_value_type_storage field to NamedRefTypeInfo class for managing referenced type memory
* Remove CalledMethod list cleanup - avoid having dangling pointer in CodeHeader class
* Fix memory leak in GetMethodNativeMap function
* Simplify FunctionMemberPtrArrayHolder class
Since FunctionMemberPtrArrayHolder instance lifetime is limited to
NotifyGdb::MethodCompiled method, there is no need for complicated reallocation code.
* Wrap NotifyGdb::MethodCompiled endtry point in try/catch block
* Fix argument naming style - rename MethodDescPtr to methodDescPtr
Noah Falk [Thu, 30 Mar 2017 06:24:57 +0000 (23:24 -0700)]
Merge pull request #10478 from noahfalk/fitjit
Tiered Compilation step 1
dotnet bot [Thu, 30 Mar 2017 03:49:47 +0000 (20:49 -0700)]
Update CoreClr to preview1-25130-01 (#10573)
Aditya Mandaleeka [Thu, 30 Mar 2017 02:37:00 +0000 (19:37 -0700)]
Merge pull request #10575 from adityamandaleeka/544701_reduce_consolewrites
Reduce console writes in 544701
noahfalk [Sat, 25 Mar 2017 05:43:47 +0000 (22:43 -0700)]
Tiered Compilation step 1
Tiered compilation is a new feature we are experimenting with that aims to improve startup times. Initially we jit methods non-optimized, then switch to an optimized version once the method has been called a number of times. More details about the current feature operation are in the comments of TieredCompilation.cpp.
This is only the first step in a longer process building the feature. The primary goal for now is to avoid regressing any runtime behavior in the shipping configuration in which the complus variable is OFF, while putting enough code in place that we can measure performance in the daily builds and make incremental progress visible to collaborators and reviewers. The design of the TieredCompilationManager is likely to change substantively, and the call counter may also change.
Daniel Podder [Thu, 30 Mar 2017 02:01:55 +0000 (19:01 -0700)]
Add PGO support for Clang/LLVM on Unix (#10533)
Extend PGO support from VC++ on WIN32 to Clang/LLVM on UNIX as well.
* Just like on Windows: if profile data is missing, skip enabling PGO
(allows non-PGO builds in branches where we don't publish PGO data).
* PGO with LTO requires additional dependencies (namely a discoverable
`ld.gold` and `LLVMgold.so`). To protect against broken support and
keep the build flexible across a wider array of distros, attempt to
detect whether PGO compilation would work (using cmake's
`try_compile()`), and fall back to a non-PGO/non-LTO build if the test
fails.
Jan Kotas [Wed, 29 Mar 2017 23:01:23 +0000 (16:01 -0700)]
Delete moved files
Jan Kotas [Wed, 29 Mar 2017 18:45:24 +0000 (11:45 -0700)]
Merge pull request dotnet/corert#3141 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Thu, 30 Mar 2017 01:30:23 +0000 (21:30 -0400)]
Revert "TimeSpan.FromMilliseconds(TimeSpan.MaxValue.TotalMilliseconds) exception fix (#10352)" (#10552)
This reverts commit
7951bc9accbbf9552d9b5c8105df8f5a32d6c3ab.
Brian Sullivan [Tue, 28 Mar 2017 00:00:51 +0000 (17:00 -0700)]
Added two new profile data flags: ExcludeHotMethodCode and ExcludeColdMethodCode
Refactored zapimage CompileProfileData into four new methods:
CompileHotRegion, CompileColdRegion, PlaceMethodIL and ProfileDisableInlining
Preserve the CompileStatus and methodProfilingDataFlags used when we compile methods during CompileHotRegion()
Then during CompileColdRegion retrieve these value and exclude the method from the AOT native image if the status is COMPILE_EXCLUDED.
Aditya Mandaleeka [Thu, 30 Mar 2017 00:41:08 +0000 (17:41 -0700)]
Reduce console writes in 544701.
Gaurav Khanna [Wed, 29 Mar 2017 23:34:58 +0000 (16:34 -0700)]
Reflect PortableRIDs in Identity packages (#10567)
Hyeongseok Oh [Wed, 29 Mar 2017 23:31:52 +0000 (08:31 +0900)]
[Linux/x86] Change non-PR Linux/x86 build CI job to daily job (#10551)
This commit change non-PR Linux/x86 build CI job to daily job.
This job only perform build process now,
but it will be perform Linux/x86 CoreCLR unittest later.
And build result could be used for Linux/x86 CoreFX unittest.
Gaurav Khanna [Wed, 29 Mar 2017 22:55:28 +0000 (15:55 -0700)]
Switch to produce Preview1 packages (#9886)
Aditya Mandaleeka [Wed, 29 Mar 2017 21:55:34 +0000 (14:55 -0700)]
Merge pull request #10506 from adityamandaleeka/handle_table_local_gc_init
Create an IGCHandleTable interface
Handle null ref in Compiler::optCreateAssertion
Code as recommended by Eugene Rozenfeld in #10359
Fixes #10359
Andy Ayers [Wed, 29 Mar 2017 21:16:46 +0000 (14:16 -0700)]
JIT: improve types for single def locals and temps (#10471)
* JIT: improve types for single def locals and temps
Track whether a local has a single definition, and if so, if it has
a reference type, try and update its type from the declared type to
a better type taken from the value being assigned to the local.
Obtain types for some of the 'short-lived' ref type temps that should
have a single definition. Use both the tree and the eval stack as sources
of type information (the latter can be phased out if/when all tree nodes
can return rich type information).
Refactor the code that sets or updates lvClassHnd into utilities
to provide better auditing of type flow and make the set/update process
a bit more rigorous.
Cleanup the code that passes argument values a bit by commoning redundant
argument lookup expressions.
Joseph Tremoulet [Wed, 29 Mar 2017 21:14:42 +0000 (17:14 -0400)]
Merge pull request #10564 from JosephTremoulet/SelfAssign
Take fields into account checking for self-assign
dotnet bot [Wed, 29 Mar 2017 21:12:21 +0000 (14:12 -0700)]
Update CoreClr, CoreFx to beta-25129-03, beta-25129-02, respectively (#10539)
dotnet bot [Wed, 29 Mar 2017 20:21:41 +0000 (13:21 -0700)]
change JitEE interface signature for getReadyToRunDelegateCtorHelper (#10562)
[tfs-changeset: 1652444]
Swaroop Sridhar [Wed, 29 Mar 2017 01:51:56 +0000 (18:51 -0700)]
Fix some bugs in Linux ILLINK testing.
Fix a few problems in the <test>.sh generation for
running CoreCLR tests on Linux via ILLINK
Aditya Mandaleeka [Thu, 23 Mar 2017 23:23:05 +0000 (16:23 -0700)]
Create a GCHandleTable interface with Init/Shutdown.
smile21prc [Wed, 29 Mar 2017 18:52:25 +0000 (11:52 -0700)]
Re-enable multi-queue for coreclr (#10541)
* Add multiqueue Support for coreclr.
Add multiqueue Support for coreclr.
* Upload build results to ONE linux container
Upload build results to ONE linux container
* Fix helixpublish.proj
Fix helixpublish.proj
* Adding more logs.
Adding more logs.
* Revert logging changes.
Revert logging changes.
* Use build version containing support of "+" delimiter
Use build version containing support of "+" delimiter
* Fix indention.
Fix indention.
* Update to use latest tools.
Update to use latest tools.
* Use an older tool as latest has a wired error on "Run build.sh" step.
Error details:
2017-03-28T23:30:13.2659430Z Running:
/root/coreclr/Tools/dotnetcli/dotnet /root/coreclr/Tools/run.exe
/root/coreclr/config.json build -Project=/root/coreclr/build.proj
-MsBuildLog=/flp:Verbosity=normal;LogFile=/root/coreclr/bin/Logs/System.Private.CoreLib_Checked.log
-BuildTarget -__IntermediatesDir=/root/coreclr/bin/obj/Linux.x64.Checked
-__RootBinDir=/root/coreclr/bin -BuildNugetPackage=false
-UseSharedCompilation=false -BuildArch=x64 -BuildType=Checked
-BuildOS=Linux
-OptimizationDataDir="/root/coreclr/packages/optimization.Linux-x64.IBC.CoreCLR//data/"
-EnableProfileGuidedOptimization=true -skiprestore
-OfficialBuildId=
20170329-01 -- /p:ConfigurationGroup=Release
/flp:v=diag
2017-03-28T23:30:13.6855470Z Running: /root/coreclr/Tools/msbuild.sh
/nologo /verbosity:minimal /clp:Summary /maxcpucount
/l:BinClashLogger,Tools/net46/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log
/p:RestoreDuringBuild=false /root/coreclr/build.proj
/p:__BuildType=Checked /p:__BuildArch=x64 /p:__BuildOS=Linux
/p:__RootBinDir=/root/coreclr/bin
/p:__IntermediatesDir=/root/coreclr/bin/obj/Linux.x64.Checked
/p:OfficialBuildId=
20170329-01 /p:EnableProfileGuidedOptimization=true
/p:OptimizationDataDir="/root/coreclr/packages/optimization.Linux-x64.IBC.CoreCLR//data/"
/flp:Verbosity=normal;LogFile=/root/coreclr/bin/Logs/System.Private.CoreLib_Checked.log
/p:BuildNugetPackage=false /t:Build /p:UseSharedCompilation=false
/p:ConfigurationGroup=Release /flp:v=diag
2017-03-28T23:30:15.5843800Z
/root/coreclr/Tools/Microsoft.CSharp.CurrentVersion.targets(321,5):
error MSB4019: The imported project
"/root/coreclr/Tools/Microsoft.Net.Compilers/2.0.0-rc/tools/Microsoft.CSharp.Core.targets"
was not found. Confirm that the path in the <Import> declaration is
correct, and that the file exists on disk.
[/root/coreclr/src/ToolBox/SOS/NETCore/SOS.NETCore.csproj]
2017-03-28T23:30:16.6459770Z
/root/coreclr/Tools/Microsoft.CSharp.CurrentVersion.targets(321,5):
error MSB4019: The imported project
"/root/coreclr/Tools/Microsoft.Net.Compilers/2.0.0-rc/tools/Microsoft.CSharp.Core.targets"
was not found. Confirm that the path in the <Import> declaration is
correct, and that the file exists on disk.
[/root/coreclr/src/mscorlib/System.Private.CoreLib.csproj]
* New builds have errors, revert to use older builds.
New builds have errors, revert to use older builds.
Rahul Kumar [Wed, 29 Mar 2017 18:50:38 +0000 (11:50 -0700)]
Merge pull request #10446 from rahku/fix9879
Allow assemblies in TPA to loaded using LoadFrom
Alex Perovich [Wed, 29 Mar 2017 18:41:45 +0000 (13:41 -0500)]
Add shared directory README (#10535)
* Add shared directory README
* PR feedback
Joseph Tremoulet [Tue, 28 Mar 2017 18:56:27 +0000 (14:56 -0400)]
Take fields into account checking for self-assign
The code in `fgMorphCopyBlock` that removes self-assigns checks if the LHS
and RHS refer to the same `lclVar`; update it to also check if the LHS and
RHS refer to the same field(s) of that `lclVar`, since otherwise copies
from one field to another of a struct can get lost.
Fixes #10481.
Hyung-Kyu Choi [Wed, 29 Mar 2017 17:28:13 +0000 (02:28 +0900)]
Fix indentation of diagram in comment (#10554)
Fix indentation of diagram in comment
in Compiler::fgRecognizeAndMorphBitwiseRotation
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Rahul Kumar [Wed, 29 Mar 2017 17:26:35 +0000 (10:26 -0700)]
Fix duplicate fcall entries for GetAssemblyName (#10546)
Jonghyun Park [Wed, 29 Mar 2017 17:25:15 +0000 (02:25 +0900)]
[x86/Linux] Use Portable ArrayInitializeWorker (#10550)
Hyeongseok Oh [Wed, 29 Mar 2017 08:28:57 +0000 (17:28 +0900)]
Fix dependency to coreclr and mscorrc in Linux (#10138)
* Fix dependency to coreclr and mscorrc in Linux
Remove dependency with coreclr in some projects for Linux
Recover build mscorrc for cross architecture in Linux
* Fix CMakeLists.txt in src/dlls
minimize uses of CLR_CROSS_COMPONENTS_BUILD flag in CMakeLists.txt
Modify root/CMakeLists.txt to exclude corerun and coreconsole build
during cross component build
ragmani [Wed, 29 Mar 2017 08:21:25 +0000 (17:21 +0900)]
[x86/Linux] fix a typo of FillRegDisplay method. (#10547)
Signed-off-by: ragmani <ragmani0216@gmail.com>
Jan Kotas [Wed, 29 Mar 2017 01:56:43 +0000 (18:56 -0700)]
Delete moved file
Jan Kotas [Wed, 29 Mar 2017 01:45:38 +0000 (18:45 -0700)]
Merge pull request dotnet/corert#3134 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jonghyun Park [Wed, 29 Mar 2017 03:39:37 +0000 (12:39 +0900)]
[x86/Linux] Fix signature mismatch inside InstantiatingStub (#10538)
Rama krishnan Raghupathy [Wed, 29 Mar 2017 02:37:43 +0000 (19:37 -0700)]
Merge pull request #10537 from ramarag/cleanup_longfile
Removing Unnecessary CloseBuffer calls
Rama Krishnan Raghupathy [Wed, 29 Mar 2017 01:09:12 +0000 (18:09 -0700)]
Removing Unnecessary CloseBuffer calls
Brian Sullivan [Wed, 29 Mar 2017 00:37:39 +0000 (17:37 -0700)]
Merge pull request #10534 from sdmaclea/PR-ARM64-GC-ASSIGN-BYREF
[Arm64] Revise CORINFO_HELP_ASSIGN_BYREF code
Zverev Eugene [Tue, 28 Mar 2017 23:50:14 +0000 (02:50 +0300)]
TimeSpan.FromMilliseconds(TimeSpan.MaxValue.TotalMilliseconds) exception fix (#10352)
The problem is discussed here: https://connect.microsoft.com/VisualStudio/feedback/details/542235/timespan-structure-incorrectly-handles-values-close-to-min-and-max-value
The existing overflow checks are ignorant and superfluous.
Jonghyun Park [Tue, 28 Mar 2017 23:43:34 +0000 (08:43 +0900)]
[x86/Linux] Align frame before SetObjectAppDomain call (#10519)
Sergey Andreenko [Tue, 28 Mar 2017 23:25:58 +0000 (16:25 -0700)]
Ctor Jit-EE interface change (#10512)
Change JIT-EE interface for getReadyToRunDelegateCtorHelper.
Update GUID.
[Arm64] Revise CORINFO_HELP_ASSIGN_BYREF code
Reverts #9655 which didn't work correctly
Revised code to match amd64
Fixes many failing GCStress tests
Aditya Mandaleeka [Thu, 23 Mar 2017 22:49:12 +0000 (15:49 -0700)]
Separate finalizer thread creation from GC initialization in EE Startup.
Sergey Andreenko [Tue, 28 Mar 2017 21:39:44 +0000 (14:39 -0700)]
Merge pull request #10503 from sandreenko/fgOptimizeDelegateConstructor-cleanup
small fgOptimizeDelegateConstructor code refactoring
Atsushi Kanamori [Tue, 28 Mar 2017 21:03:21 +0000 (14:03 -0700)]
Get VS to quit bugging me about replacing SR.cs already. (#10530)
Fix https://github.com/dotnet/coreclr/issues/10358
Rahul Kumar [Tue, 28 Mar 2017 20:25:27 +0000 (13:25 -0700)]
return TPA assembly if loadfrom is passed a path to assembly with same identity
Swaroop Sridhar [Thu, 23 Mar 2017 01:09:05 +0000 (18:09 -0700)]
Add support for CoreCLR testing via ILLINK on Linux
Made changes to the test infrastructure to
1) Generate <test>.sh with commands to invoke ILLINK and run the output
2) Add runtest.sh --link=<path-to-illink> to invoke the ILLINK testing
303248153 [Tue, 28 Mar 2017 18:12:18 +0000 (02:12 +0800)]
Fix comment on mark::recover_plug_info (#10516)
Eric Erhardt [Tue, 28 Mar 2017 17:56:04 +0000 (12:56 -0500)]
Merge pull request #10507 from eerhardt/TZBinarySearch
Binary Search in TimeZoneInfo.GetAdjustmentRuleForTime
Sean Gillespie [Tue, 28 Mar 2017 16:59:04 +0000 (09:59 -0700)]
[Local GC] Use standard C++ types (bool) and consistent types (void*) on the interface (#10463)
* [Local GC] BOOL -> bool on IGCHeap
* [Local GC] size_t -> void* on IGCHeap
* [Local GC] Silence warnings by being explicit about BOOl -> bool conversions
* Address code review feedback: FinalizeAppDomain BOOL -> bool
* Fix warnings
* Address code review feedback:
1) Fix a missed default parameter (FALSE) on a parameter of type bool,
2) Fix invocations of the diagnostic callbacks to use boolean literals
instead of TRUE and FALSE,
3) Fix various invocations of GC interface methods in the VM to use
boolean literals instead of TRUE and FALSE
* Address code review feedback: fix inconsistency
Hanjoung Lee [Tue, 28 Mar 2017 15:53:08 +0000 (00:53 +0900)]
Fix usage text of runtest.sh (#10518)
dotnet bot [Tue, 28 Mar 2017 14:47:07 +0000 (07:47 -0700)]
Update CoreClr to beta-25128-03 (#10517)
Eric Erhardt [Mon, 27 Mar 2017 17:50:36 +0000 (12:50 -0500)]
Binary Search in TimeZoneInfo.GetAdjustmentRuleForTime
Since Unix uses IANA tzdata files, there can be hundreds of adjustment rules for each time zone. To make the search for a given rule faster, use a binary search since the rules are guaranteed to be in chronological order. See ValidateTimeZoneInfo.
Fix #5716
Koundinya Veluri [Tue, 28 Mar 2017 05:38:53 +0000 (22:38 -0700)]
Don't ignore exceptions thrown from handlers of some events (#10502)
Fixes dotnet/corefx#14747:
- Events include: AssemblyLoadContext.Unloading, AppDomain.ProcessExit
- Made the same change for AppDomain.DomainUnload for consistency, but it's not raised
Olof Olsson [Tue, 28 Mar 2017 03:32:35 +0000 (05:32 +0200)]
Fix link for up-for-grabs issues (#10488)
* Fix link for up-for-grabs issues
Alex Perovich [Mon, 27 Mar 2017 22:44:34 +0000 (15:44 -0700)]
Move deleted files and remove m_ prefix in shared file
Alex Perovich [Mon, 27 Mar 2017 18:12:31 +0000 (11:12 -0700)]
Add DateTimeFormat and Parse to shared and remove moved file
dotnet bot [Tue, 28 Mar 2017 00:59:59 +0000 (17:59 -0700)]
Update CoreClr, CoreFx to beta-25127-03, beta-25124-07, respectively (#10468)
Dan Moseley [Tue, 28 Mar 2017 00:58:14 +0000 (17:58 -0700)]
Some missing stragglers (#10509)
Bruce Forstall [Tue, 28 Mar 2017 00:05:45 +0000 (17:05 -0700)]
Implement TLS field handles for RyuJIT/x86 (#10510)
Implement TLS field handles for RyuJIT/x86
This isn't used by .NET Core, but helps us run desktop testing.
Sergey Andreenko [Mon, 27 Mar 2017 19:46:59 +0000 (12:46 -0700)]
small changes in fgOptimizeDelegateConstructor
Delete unnecessary condition.
Use default methods to work with lists.
ArgList construction reordering.
Koundinya Veluri [Mon, 27 Mar 2017 18:10:07 +0000 (11:10 -0700)]
Add heuristic to trigger GC to finalize dead threads and clean up han… (#10413)
Add heuristic to trigger GC to finalize dead threads and clean up handles and memory
A thread that is started allocates some handles in Thread::AllocHandles(). After it terminates, the managed thread object needs to be collected by a GC for the handles to be released. Some applications that are mostly idle but have a timer ticking periodically will cause a thread pool thread to be created on each tick, since the thread pool preserves threads for a maximum of 20 seconds currently. Over time the number of handles accumulates to a high value. Thread creation adds some memory pressure, but that does not force a GC until a sufficiently large handle count, and for some mostly idle apps, that can be very long. The same issue arises with directly starting threads as well.
Fixes #6602:
- Track a dead thread count separately from the current dead thread count. This is the count that will contribute to triggering a GC, once it reaches a threshold. The count is tracked separately so that it may be reset to zero when a max-generation GC occurs, preventing dead threads that survive a GC due to references from contributing to triggering a GC again in this fashion.
- If the count exceeds a threshold, enumerate dead threads to see which GC generation the corresponding managed thread objects are in. If the duration of time since the last GC of the desired generation also exceeds a threshold, trigger a preferably non-blocking GC on the finalizer thread.
- Removed a couple of handles and some code paths specific to user-requested thread suspension, which is not supported on CoreCLR
Atsushi Kanamori [Mon, 27 Mar 2017 18:09:21 +0000 (11:09 -0700)]
Move Pointer.cs to the shared partition. (#10499)
* Move Pointer.cs to the shared partition.
(The two internal helpers are not yet used
on CoreRT but that's only because CoreRT
doesn't yet implement Pointer support
for Reflection invoke. Exposing them
unconditionally now to save us the trouble
of removing the #ifdef's later.)
Ben Monroe [Mon, 27 Mar 2017 17:04:32 +0000 (02:04 +0900)]
Path may contain spaces. Wrap in quotes. (#10493)
Joseph Tremoulet [Mon, 27 Mar 2017 15:45:18 +0000 (11:45 -0400)]
Merge pull request #10484 from mikedn/map-vn-assert
Correctly update bitvector in optAddVnAssertionMapping
Stephen Toub [Sun, 26 Mar 2017 21:04:40 +0000 (17:04 -0400)]
Merge pull request #10489 from stephentoub/capturethrow
Add static ExceptionDispatchInfo.Throw method
Stephen Toub [Sun, 26 Mar 2017 18:26:34 +0000 (14:26 -0400)]
Add static ExceptionDispatchInfo.Throw method
Aditya Mandaleeka [Sun, 26 Mar 2017 14:59:49 +0000 (07:59 -0700)]
Change typedef for BOOL in gcenv.base.h to int. (#10486)
Cyd Haselton [Sun, 26 Mar 2017 14:57:46 +0000 (09:57 -0500)]
Update for Android cross build script (#10483)
Updated URLs for libandroid-support and libandroid-support-dev downloads.
Added URLs and folders for libunwind and libunwind-dev
Removed libunwind build
Mandar Sahasrabuddhe [Sun, 26 Mar 2017 02:07:42 +0000 (07:37 +0530)]
CoreFx 14486 Update API summary. (#10485)
Mike Danes [Sat, 25 Mar 2017 07:45:15 +0000 (09:45 +0200)]
Correctly update bitvector in optAddVnAssertionMapping
When short bitvectors are used only the first assertion was stored in the map stored bitvector, all subsequent assertions were stored into copies of that bitvector.
Tarek Mahmoud Sayed [Sat, 25 Mar 2017 17:41:39 +0000 (10:41 -0700)]
Enable global invariant on OSX (#10470)
* Enable Globalization Invariant on OSX
* Fix typo
* Fix small typo
* Remove static link to ICU lib
* Addressing the feedback
Ofer Zelig [Sat, 25 Mar 2017 15:31:45 +0000 (02:31 +1100)]
Typo correction (#10482)
Jan Kotas [Sat, 25 Mar 2017 15:30:40 +0000 (08:30 -0700)]
Delete pointless <internalonly/> comments (#10479)
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 15:04:23 +0000 (20:34 +0530)]
Issue #7061 Remove private _Prop from StreamReader, StreamWriter (#10480)
mikedn [Sat, 25 Mar 2017 14:45:10 +0000 (16:45 +0200)]
Some BitVecOps improvements (#10437)
* Avoid virtual calls when allocating bitvectors
* Use specialized BitVecOps when possible
* Avoid unnecessary bitvector copying
* Cleanup CSE_DataFlow
Jan Kotas [Sat, 25 Mar 2017 07:42:49 +0000 (00:42 -0700)]
Add Interlocked.MemoryBarrierProcessWide (#10476)
Contributes to #16799
Ahson Ahmed Khan [Sat, 25 Mar 2017 05:50:14 +0000 (22:50 -0700)]
Remove return statement and throwing directly for obselete methods. (#10477)
Brian Sullivan [Sat, 25 Mar 2017 04:45:50 +0000 (21:45 -0700)]
Merge pull request #10469 from briansull/ibc-dump
Change the Jit Disasm message when we have profile data
Brian Sullivan [Sat, 25 Mar 2017 04:44:51 +0000 (21:44 -0700)]
Merge pull request #10466 from briansull/stress-fix
Fix for JitStress test failures
Alex Perovich [Sat, 25 Mar 2017 04:10:49 +0000 (23:10 -0500)]
Move DateTime to shared partition (#10460)
* Move DateTime to shared partition
Depends on dotnet/corefx#17484
* Use CoreCLR specific impl of UtcNow on windows
* Use the internal call on unix as well
* Port good corert changes
Alex Perovich [Sat, 25 Mar 2017 03:13:09 +0000 (22:13 -0500)]
Cleanup unnecessary import (#10472)
Dan Moseley [Sat, 25 Mar 2017 03:02:35 +0000 (20:02 -0700)]
Rename resource strings to match resx (#10475)
Jan Kotas [Sat, 25 Mar 2017 02:31:22 +0000 (19:31 -0700)]
Fixed m_ prefixes in a few files from shared partition (#10473)
Brian Sullivan [Fri, 24 Mar 2017 23:29:27 +0000 (16:29 -0700)]
Change the Jit Disasm message when we have profile date to include
information about the edge weights and the value of fgCalledCount.
Example:
; with IBC profile data, edge weights are valid, and fgCalledCount is 145
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 01:21:56 +0000 (06:51 +0530)]
CoreFx 14486 Remove argument validation in DangerousCreate (#10462)
Brian Sullivan [Sat, 25 Mar 2017 00:51:47 +0000 (17:51 -0700)]
CR feedback
Removed assert about BB_NONE
Dan Moseley [Sat, 25 Mar 2017 00:42:44 +0000 (17:42 -0700)]
Remove dead strings (#10445)
Removed 436 dead strings from .resx, kept 1034
Alex Perovich [Sat, 25 Mar 2017 00:18:37 +0000 (19:18 -0500)]
Sort entries in shared project (#10465)
Brian Sullivan [Fri, 24 Mar 2017 22:42:04 +0000 (15:42 -0700)]
Fix for JitStress test failures