William Godbe [Tue, 11 Apr 2017 23:37:34 +0000 (16:37 -0700)]
Merge pull request #10899 from wtgodbe/PipelineReporting
Add last set of reportingParameters to pipelines.json
wtgodbe [Tue, 11 Apr 2017 20:03:45 +0000 (13:03 -0700)]
Add last set of reportingParameters to pipelines.json
Andy Ayers [Tue, 11 Apr 2017 21:31:11 +0000 (14:31 -0700)]
Merge pull request #10867 from AndyAyersMS/FixSingleDefBug
Jit: fix issue with single-def type propagation
Mandar Sahasrabuddhe [Tue, 11 Apr 2017 20:43:22 +0000 (02:13 +0530)]
CoreFx #15622 Dictionary<TKey, TValue>.Remove(TKey, out TValue) (#10203)
Bruce Forstall [Tue, 11 Apr 2017 20:38:37 +0000 (13:38 -0700)]
Merge pull request #10880 from BruceForstall/ArmCommon
Create common files for ARM32 and ARM64 common code
Pat Gavlin [Tue, 11 Apr 2017 20:29:23 +0000 (13:29 -0700)]
Merge pull request #10876 from pgavlin/VSO406156
Fix a few errors in cast decomposition.
Jan Kotas [Tue, 11 Apr 2017 20:22:50 +0000 (13:22 -0700)]
Move a few more types from CoreFX to CoreLib (#10893)
Reducing shards between CoreCLR and CoreRT shards
Matt Galbraith [Tue, 11 Apr 2017 18:39:27 +0000 (11:39 -0700)]
Merge pull request #10894 from dotnet/Add_Build_Type
Add some BuildType and Subtype info to CoreCLR build pipeline definition
Jan Kotas [Tue, 11 Apr 2017 16:00:23 +0000 (09:00 -0700)]
Merge pull request dotnet/corert#3288 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Bruce Forstall [Tue, 11 Apr 2017 02:01:34 +0000 (19:01 -0700)]
Create common files for ARM32 and ARM64 common code
Create codegenarmarch.cpp, lowerarmarch.cpp, lsraarmarch.cpp.
For codegenarmarch.cpp, I copied over a bunch of functions that
are almost identical between arm and arm64. I left the functions
intact (didn't change anything), so created one for ARM32 and
one for ARM64, unless they were truly identical. A follow-up
will be to actually merge the functions.
For lowerarmarch.cpp and lsraarmarch.cpp, I did the function
merge for nearly (or completely) identical functions, since
there were so many that were so similar.
Matt Galbraith [Tue, 11 Apr 2017 17:25:51 +0000 (10:25 -0700)]
Add some BuildType and Subtype info to CoreCLR build pipeline definition
Pat Gavlin [Tue, 11 Apr 2017 17:18:57 +0000 (10:18 -0700)]
Merge pull request #10886 from hseok-oh/ci/fix_ci_error
Fix CI test error: permission error
Jan Kotas [Tue, 11 Apr 2017 02:37:42 +0000 (19:37 -0700)]
Merge pull request dotnet/corert#3285 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Hyeongseok Oh [Tue, 11 Apr 2017 08:08:43 +0000 (17:08 +0900)]
Remove sudo in netci.groovy
Hyeongseok Oh [Tue, 11 Apr 2017 07:49:34 +0000 (16:49 +0900)]
Overwrite permission in coreoverlay generation
fix runtest.sh to overwrite corerun's permission in coreoverlay generation
Hyeongseok Oh [Tue, 11 Apr 2017 07:47:27 +0000 (16:47 +0900)]
Fix netci.groovy
Fix netci.groovy instead of test script to avoid rebase
Hyeongseok Oh [Tue, 11 Apr 2017 07:12:10 +0000 (16:12 +0900)]
Fix CI test error: permission error
Fix CoreCLR/CoreFX copy order: permission problem
Sergey Andreenko [Tue, 11 Apr 2017 03:53:38 +0000 (20:53 -0700)]
Do not spill eeStack after ldtoken opcode. (#10215)
Do not spill eeStack if the last opcode was ldtoken.
Koundinya Veluri [Tue, 11 Apr 2017 02:48:54 +0000 (19:48 -0700)]
Fix some static methods on ThreadPool to wait for initialization (#10869)
Fix for part of #10521
Bruce Forstall [Tue, 11 Apr 2017 01:50:10 +0000 (18:50 -0700)]
Merge pull request #10782 from parjong/fix/x86_funclet_unwinding
[x86/Linux] Use GCInfo for funclet unwinding
dotnet bot [Tue, 11 Apr 2017 01:02:57 +0000 (18:02 -0700)]
Update CoreClr to preview1-25210-04 (#10862)
Pat Gavlin [Tue, 11 Apr 2017 00:12:40 +0000 (17:12 -0700)]
Merge pull request #10871 from pgavlin/PipelineCompatJit
Package compatjit.dll in pipeline builds.
Pat Gavlin [Mon, 10 Apr 2017 23:58:46 +0000 (16:58 -0700)]
Merge pull request #10866 from pgavlin/VSO405852
Fix VSO bug 405852.
Pat Gavlin [Mon, 10 Apr 2017 23:26:17 +0000 (16:26 -0700)]
Fix a few errors in cast decomposition.
The cursor was not guaranteed to be in the correct location after cast
decomposition due to the location in which the high result was typically
placed. This mispositioning can cause re-decomposition, which can lead
to asserts e.g. when encountering a GT_LONG node that was left behind by
a previously-decomposed node. This change ensures that the high result
immediately follows the cast node so that the cursor will be in the
correct location following decomposition of the cast.
Dan Moseley [Mon, 10 Apr 2017 23:20:05 +0000 (16:20 -0700)]
empty array (#10841)
Make EmptyArray private in favor of Array.Empty<T>
Roman Artemev [Mon, 10 Apr 2017 22:55:54 +0000 (15:55 -0700)]
Merge pull request #10814 from rartemev/ilasm_reference_resolver_fix
Added 'netstandard' corelib name into ilasm reference resolver
Bruce Forstall [Mon, 10 Apr 2017 22:55:14 +0000 (15:55 -0700)]
Merge pull request #10808 from sdmaclea/PR-ARM64-enable-initblk-unroll
[Arm64] enable initblk loop unrolling
Jonghyun Park [Mon, 10 Apr 2017 22:50:56 +0000 (07:50 +0900)]
Extract genInterruptible setting as a separate region
Jonghyun Park [Mon, 10 Apr 2017 22:49:08 +0000 (07:49 +0900)]
Use hasPartialArgInfo instead of isPartialArgInfo
Sergey Andreenko [Mon, 10 Apr 2017 22:41:54 +0000 (15:41 -0700)]
add test with deep execution tree without stores. (#10835)
Add a test that should fail with stack overflow if the compiler doesn't spill trees from time to time.
Pat Gavlin [Mon, 10 Apr 2017 22:27:07 +0000 (15:27 -0700)]
Package compatjit.dll in pipeline builds.
Just what it says on the tin.
Pat Gavlin [Mon, 10 Apr 2017 22:13:58 +0000 (15:13 -0700)]
Format code.
Pat Gavlin [Mon, 10 Apr 2017 21:17:08 +0000 (14:17 -0700)]
Fix VSO bug 405852.
This bug was due to a mismatch between the semantics of the FP modulus
operator as specified by ECMA-335 and as implemented by value numbering.
ECMA-335 requires the following behavior for FP modulus:
- If the divisor is 0 or the dividend is not finite, the result is NaN
- If the divisor is not finite and is not NaN, the result is the
dividend.
Value numbering, however, simply used `fmod`, which does not have these
semantics. This change implements the required semantics in VN.
Jan Kotas [Mon, 10 Apr 2017 20:57:03 +0000 (13:57 -0700)]
Add back UnmanagedType.LPUTF8Str (#10859)
Rew [Mon, 10 Apr 2017 20:06:49 +0000 (16:06 -0400)]
CoreLib Build System portability updates (#10839)
Updates to corelib project file for target specific includes. Intended
to ease maintainability of existing targets and clarify necessary work
for new targets.
Koundinya Veluri [Mon, 10 Apr 2017 20:00:48 +0000 (13:00 -0700)]
Fix contract to allow call into GarbageCollect() to throw (#10856)
I did not intend to mark this function as NOTHROW, and there is no reason to expect NOTHROW here. Other functions that call into GarbageCollect() allow THROWS.
Aditya Mandaleeka [Mon, 10 Apr 2017 19:53:41 +0000 (12:53 -0700)]
Merge pull request #10823 from adityamandaleeka/move_variable_handle_creation
Refactor variable strength handle creation
Omar Tawfik [Mon, 10 Apr 2017 19:52:22 +0000 (12:52 -0700)]
Add empty System.Runtime.CompilerServices.RuntimeFeature.IsSupported() API (#10779)
Roman Artemev [Fri, 7 Apr 2017 23:07:14 +0000 (16:07 -0700)]
Added netstandard corelib into ilasm reference resolver
Atsushi Kanamori [Mon, 10 Apr 2017 19:43:24 +0000 (12:43 -0700)]
Fix perf penalty for creating dictionaries the easy way. (#10855)
We went to the trouble of mitigating the perf hit
introduced by using randomized string hashing.
I assume that said perf benefit wasn't meant to be denied
to the 90% case where people use the nullary
constructor to create the Dictionary...
Andy Ayers [Mon, 10 Apr 2017 19:05:49 +0000 (12:05 -0700)]
Jit: fix issue with single-def type propagation
To avoid overly aggressive type propagation when there are multiple
reaching definitions, only propagate types to single-IL-def locals
when the definiting value comes from the same basic block as the store.
We check this conservatively by insisting that the block's entry stack
be empty.
Added a test case where the jit will improperly devirtualize without
such a check.
Closes #10858.
[Arm64] Cleanup/fix InitBlkUnroll
dotnet bot [Mon, 10 Apr 2017 18:18:31 +0000 (11:18 -0700)]
Update CoreFx to preview1-25210-01 (#10850)
James Ko [Mon, 10 Apr 2017 17:26:12 +0000 (13:26 -0400)]
Implement slicing APIs for ArraySegment<T> (#9926)
Ilya [Mon, 10 Apr 2017 17:21:41 +0000 (20:21 +0300)]
Incorrect parameter order found by PVS-Studio (#10497)
* Incorrect parameter order found by PVS-Studio
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V3066 diagnostic https://www.viva64.com/en/w/V3066/
Atsushi Kanamori [Mon, 10 Apr 2017 17:14:09 +0000 (10:14 -0700)]
Get rid of "#if FEATURE_RANDOMIZED_STRING_HASHING" in shared partition. (#10851)
Since CoreCLR defines it (for now) and CoreRT doesn't, let's not have
"#if's" on this in shared code. It just creates confusion.
The only ones are in StringComparer.cs and fortunately, they are quite
expendable as...
1. It's only purpose is serialize Hashtables and Dictionaries in
a way that CLR 1.1 can deserialize them. We don't care about that in
.NET Core.
2. In CoreCLR as of today, this infrastructure is not changing the serialization
blob one iota since all the GetEqualityComparerForSerialization() methods
return "this."
So this removes the appearance of downgrading the comparers to non-randomized
versions for serialization purposes (and yes, we could go on and remove
all the other "let's do it for Everett and RTM" stuff in Hashtable.cs, but
I want to keep this PR on topic. Hashtable.cs is not going to be imported
into CoreRT so it's low priority for me.)
Cyd Haselton [Mon, 10 Apr 2017 17:03:53 +0000 (12:03 -0500)]
Updating CODE_OWNERS.TXT (#10834)
Added Nuget package implementation owners
Sergey Andreenko [Mon, 10 Apr 2017 16:41:49 +0000 (09:41 -0700)]
Forbid lea without index and base. (#10771)
Jan Kotas [Mon, 10 Apr 2017 16:28:38 +0000 (09:28 -0700)]
Delete FEATURE_READYTORUN define for CoreLib build (#10840)
This define does not have much value for the CoreLib build, and it was missing on arm64.
Also deleted dead props and targets files left over from the legacy build
Jonghyun Park [Mon, 10 Apr 2017 13:21:11 +0000 (22:21 +0900)]
[x86/Linux] Set ResumeEsp as Caller Sp when unwond to native frame (#10838)
Jonghyun Park [Mon, 10 Apr 2017 12:51:10 +0000 (21:51 +0900)]
[x86/Linux] 16-byte aligned ResolveWorkerChainLookupAsmStub (#10754)
Buyduck [Mon, 10 Apr 2017 12:48:57 +0000 (16:48 +0400)]
* Fixed issue, when structures with many fields had wrong size in dwarf (#10797)
Jan Kotas [Mon, 10 Apr 2017 05:53:50 +0000 (22:53 -0700)]
Move files to shared CoreLib partition (#10837)
Aditya Mandaleeka [Sat, 8 Apr 2017 01:44:23 +0000 (18:44 -0700)]
Move variable handle creation.
Sean Gillespie [Sun, 9 Apr 2017 20:58:29 +0000 (13:58 -0700)]
[Local GC] Move knowledge of the free object method table outside of the GC (#10755)
* [Local GC] Move knowledge of the free object method table outside of the GC
* Revert "[Local GC] Move knowledge of the free object method table outside of the GC"
This reverts commit
02979e5eb12dd44edb2603e16411dd7d7ffc377d.
* Address code review feedback: leave ArrayBase alone, as it should be part of the binary contract between the EE and the GC
* Correct a bad merge
Jan Kotas [Sun, 9 Apr 2017 13:55:23 +0000 (06:55 -0700)]
Move files to shared CoreLib partition (#10830)
Joseph Tremoulet [Sun, 9 Apr 2017 06:50:02 +0000 (02:50 -0400)]
Update VS2017 'Individual Components' install info (#10695)
A few small changes to make it easier to compare selections in the
installer UI against the list in the doc:
- Re-order the list to match the order presented in the installer UI
- Place the individual items under groupings matching the installer
- Change casing to match installer UI
Jan Kotas [Sun, 9 Apr 2017 05:12:22 +0000 (22:12 -0700)]
Delete reference to model.xml since it no longer exists (#10827)
Jim Ma [Sun, 9 Apr 2017 03:43:12 +0000 (11:43 +0800)]
Fix the broken link in contributing.md (#10828)
The List.cs link is broken in contributing.md. This PR updates the link to List.cs accordingly.
Fix #10822
Bruce Forstall [Sun, 9 Apr 2017 03:23:52 +0000 (20:23 -0700)]
Merge pull request #10776 from sdmaclea/PR-ARM64-CpBlkUnroll
[Arm64] Enable cpblk loop unrolling
Bruce Forstall [Sun, 9 Apr 2017 03:23:34 +0000 (20:23 -0700)]
Merge pull request #10736 from sdmaclea/PR-ARM64-GC-genLeaInstruction
[Arm64] Fix GC Hole in genLeaInstruction
Hadi Brais [Sat, 8 Apr 2017 19:24:23 +0000 (00:54 +0530)]
Fix corerun issue when loaded from PATH (#10745)
Alex Perovich [Sat, 8 Apr 2017 19:24:01 +0000 (14:24 -0500)]
Use a monotonic clock for test timing (#10812)
Fixes #8348
Koundinya Veluri [Sat, 8 Apr 2017 19:23:33 +0000 (12:23 -0700)]
Handle SIGTERM on OSX (#10723)
* Handle SIGTERM on OSX
Fixes #7394
* Address feedback
Jim Ma [Sat, 8 Apr 2017 16:43:47 +0000 (00:43 +0800)]
Exit gracefully when running ildasm -nat against unsupported ni file. (#10821)
ildasm -nat only works for fragile native images (ie CoreLib only by default).
Running ildasm -nat against unsupported native images would cause a segmentation fault. This PR checks pNativeHeader->Signature == CORCOMPILE_SIGNATURE and end the program with a meaningful error message.
fix #10247
Bruce Forstall [Sat, 8 Apr 2017 15:37:44 +0000 (08:37 -0700)]
Merge pull request #10811 from BruceForstall/RemoveRELOC_SUPPORT
Remove RELOC_SUPPORT define
Sean Gillespie [Sat, 8 Apr 2017 06:59:00 +0000 (23:59 -0700)]
[Local GC] Fix some interface violations (#10817)
Jan Kotas [Fri, 7 Apr 2017 23:49:04 +0000 (16:49 -0700)]
Merge pull request dotnet/corert#3262 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Fri, 7 Apr 2017 23:49:58 +0000 (16:49 -0700)]
Find & replace Exception.SetErrorCode with Exception.HResult setter (#10810)
Aditya Mandaleeka [Fri, 7 Apr 2017 22:02:53 +0000 (15:02 -0700)]
Merge pull request #10757 from adityamandaleeka/handle_table_local_gc_init
[Local GC] Move handle creation to IGCHandleTable
Aditya Mandaleeka [Fri, 7 Apr 2017 01:11:57 +0000 (18:11 -0700)]
Move OBJECTHANDLE definition to gcinterface.h
Aditya Mandaleeka [Thu, 6 Apr 2017 02:31:32 +0000 (19:31 -0700)]
Add creation of special handle types to IGCHandleTable.
Omar Tawfik [Fri, 7 Apr 2017 21:48:09 +0000 (14:48 -0700)]
Add System.Runtime.CompilerServices.ReadOnlyAttribute (#10777)
Davis Goodin [Fri, 7 Apr 2017 21:38:02 +0000 (16:38 -0500)]
Temporarily disable symweb indexing (#10807)
Bruce Forstall [Fri, 7 Apr 2017 21:18:26 +0000 (14:18 -0700)]
Remove RELOC_SUPPORT define
It's always defined, is always expected to be defined, and the build
doesn't work without it.
Also remove unused `SECURITY_CHECK` and `VERIFY_IMPORTER` defines.
Jeremy Kuhne [Fri, 7 Apr 2017 21:21:47 +0000 (14:21 -0700)]
Strip out unused reg code. (#10741)
* Strip out unused reg code.
Removing the unused code to better be able to audit our CoreLib usage and to prepare for targeted code sharing with CoreFX. Wraps key usages in using statements.
* Fix static init and remove Contract
[Arm64] enable initblk loop unrolling
William Godbe [Fri, 7 Apr 2017 20:46:11 +0000 (13:46 -0700)]
Merge pull request #10806 from wtgodbe/portableMac
Publish portable OSX binaries into separate container in pipeline
Jan Kotas [Fri, 7 Apr 2017 18:38:02 +0000 (11:38 -0700)]
Delete moved file
Jan Kotas [Fri, 7 Apr 2017 15:34:41 +0000 (08:34 -0700)]
Merge pull request dotnet/corert#3247 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Ahson Ahmed Khan [Fri, 7 Apr 2017 20:05:29 +0000 (13:05 -0700)]
Using AsSpan since we no longer have slice on string. Renaming Tests. (#10758)
Bruce Forstall [Fri, 7 Apr 2017 19:54:00 +0000 (12:54 -0700)]
Merge pull request #10799 from sdmaclea/PR-Fix-lvRegister-assert
Correct assert w.r.t meaning of lvRegister
wtgodbe [Fri, 7 Apr 2017 19:47:22 +0000 (12:47 -0700)]
Publish portable OSX binaries into separate container in pipeline
Jan Kotas [Fri, 7 Apr 2017 18:31:03 +0000 (11:31 -0700)]
Move public ThreadAbortException back to CoreLib (#10801)
dotnet bot [Fri, 7 Apr 2017 18:20:52 +0000 (11:20 -0700)]
Update CoreClr, CoreFx to preview1-25207-02, preview1-25205-01, respectively (#10787)
Address #10799 comments
Bruce Forstall [Fri, 7 Apr 2017 18:09:16 +0000 (11:09 -0700)]
Merge pull request #10656 from hseok-oh/ryujit/fix_10654
[RyuJIT/ARM32] [ReadyToRun] Fix target register for invocation to Thunk
Roman Artemev [Fri, 7 Apr 2017 18:09:02 +0000 (11:09 -0700)]
Merge pull request #10781 from rartemev/ilasm_path_length_fix
Changes for #9757 issue. Handle long parameters in the right way.
William Godbe [Fri, 7 Apr 2017 17:45:37 +0000 (10:45 -0700)]
Merge pull request #10704 from wtgodbe/BuildDefs
Initial commit of checked in build definitions for CoreCLR
[Arm64] Use ldp/stp in CpBlkUnroll
Michelle McDaniel [Fri, 7 Apr 2017 17:02:04 +0000 (10:02 -0700)]
Merge pull request #10798 from adiaaida/fixjit32Perf
Fix jit32 Perf testing
Jan Kotas [Fri, 7 Apr 2017 13:29:10 +0000 (06:29 -0700)]
Delete duplicate files and fix build breaks
Jan Kotas [Fri, 7 Apr 2017 06:54:36 +0000 (23:54 -0700)]
Merge pull request dotnet/corert#3243 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Address review feedback
Correct assert w.r.t meaning of lvRegister
Per recomendation of Pat Gavlin in #9898
Fixes #9898
Michelle McDaniel [Fri, 7 Apr 2017 15:45:30 +0000 (08:45 -0700)]
Fix jit32 Perf testing
In the CI, we were moving compatjit.dll into the Products directory
instead of the core_root directory, so the jit32 compatjit.dll was not
being picked up by the build. This change moves the nuget logic to before
we run runtest.cmd generatelayoutonly, so the jit32 compatjit.dll will be
moved to the core_root directory along with everything else.
Jim Ma [Fri, 7 Apr 2017 15:33:21 +0000 (23:33 +0800)]
Handle unsupported varargs tests on Unix gracefully. (#10794)
Some of mcc_i* tests caused segmentation faults on Unix. This commit make these tests exit by throwing a System.EntryPointNotFoundException exception instead of causing a segmentation fault.
Fix #9530
Yi Zhang (CLR) [Fri, 7 Apr 2017 14:29:10 +0000 (07:29 -0700)]
Bring back DefaultDllImportSearchPathsAttribute (#10786)
Jan Vorlicek [Fri, 7 Apr 2017 13:35:34 +0000 (15:35 +0200)]
Add reporting swap file size to GlobalMemoryStatusEx on Unix (#10700)
The swap file size reporting is added using the Linux, OSX and FreeBSD
means. Also a new PAL test was added to exercise the function.
Jan Kotas [Fri, 7 Apr 2017 04:00:36 +0000 (21:00 -0700)]
Delete duplicate files and fix build breaks