Sam Asadi [Sun, 20 Jul 2014 14:06:24 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: an issue in code style fixed
An issue in 'line over 80 characters' fixed by removing over-lined
comment to the previous line.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:23 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: an issue in line over 80 fixed
An issue in 'line over 80 characters' fixed by removing over-lined comment
to the previous line.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:22 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: a line over 80 characters resolved
An issue in 'line over 80 characters' fixed by taking back over-lined comment
a few characters.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:21 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: a line over 80 characters fixed
An issue in 'line over 80 characters' fixed and over-lined comment
removed to the previous line.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:20 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: A line style issue fixed
A 'line over 80 characters' fixed by removing over-lined comment
to previous line.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:19 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: a line over 80 issue fixed
By removing a comment to previous line, 'line over 80' issue
fixed.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sun, 20 Jul 2014 14:06:18 +0000 (17:06 +0300)]
Staging: comedi: adv_pci1710: a line over 80 fixed
A 'line over 80' issue fixed, by removing comment to previous line. And
also, by this, 'a blank line' isssue resolved.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Sat, 19 Jul 2014 11:53:03 +0000 (14:53 +0300)]
Staging: comedi: adl_paci9118: organized entry comments
Introductory comments organized according to Linux's comment
coding style.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:23:36 +0000 (17:23 -0700)]
staging: comedi: drivers: remove unnecessary *_{IO, MEM}SIZE defines
Some of the legacy comedi drivers have a *_{IO,MEM}SIZE define that is
only passed to comedi_request_region() to specify the size of the region.
For aesthetics, remove these defines.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:24 +0000 (17:01 -0700)]
staging: comedi: drivers: use dev->board_name in request_irq()
Most of the comedi drivers use the dev->board_name for the id string
passed to request_irq(). Fix the couple that still pass something
else.
Also, propogate the errno from request_irq().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:23 +0000 (17:01 -0700)]
staging: comedi: drivers: remove unnecessary DRIVER_NAME defines
These defines are usually only used to initialize the driver_name
member of the comedi_driver struct. Some of the drivers also use
the define as part of dev_{level}() messages and/or when doing a
request_irq().
The addition of the DRIVER_NAME to the messages is just added noise
and the dev->board_name is typically used in the request_irq().
Just remove all the DRIVER_NAME defines.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:22 +0000 (17:01 -0700)]
staging: comedi: drivers: remove unnecessary *_SIZE defines
Some of the legacy comedi drivers have a *_SIZE define that is only
passed to comedi_request_region() to specify the size of the region.
Some of the pnp drivers (pci, etc.) also have a *_SIZE define which
is unused.
For aesthetics, remove these defines.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:21 +0000 (17:01 -0700)]
staging: comedi: drivers: remove unnecessary PCI_DEVICE_ID_* defines
These defines are only used once in the pci_device_id tables. Remove
them and just open code the values.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:20 +0000 (17:01 -0700)]
staging: comedi: pcl816: remove forward declaration
Move check_channel_list() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:19 +0000 (17:01 -0700)]
staging: comedi: pcm3724: use default (*io) callback from 8255 module
The private (*io) callback used by this driver is identical to the
default one provided by the 8255 module. Use the default one instead.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:18 +0000 (17:01 -0700)]
staging: comedi: ni_pcidio: remove forward declarations
Move some of the functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:17 +0000 (17:01 -0700)]
staging: comedi: ni_at_a2150: remove forward declarations
Move some of the functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Sat, 19 Jul 2014 00:01:16 +0000 (17:01 -0700)]
staging: comedi: drivers: cleanup cmd->flags use
Most of the comedi drivers that support async commands have some sort
of timer to control the acquisition timing. For these drivers, Step 4
of the (*do_cmdtest) operations calls a ns_to_timer() function that
converts the desired ns time of the command into a value used to set
the timer. These ns_to_timer() functions also typically pass the
cmd->flags in order to determine the desired rounding mode.
Some of the drivers mask the cmd->flags with TRIG_ROUND_MASK when
calling the ns_to_timer() functions. Move all the masking into the
ns_to_timer() functions and just pass the cmd->flags directly.
The cmd->flags member is an unsigned int, change the parameter type
in the the ns_to_timer() functions to match.
For aesthetics, rename the parameter in all the ns_to_timer()
functions to 'flags'.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 21 Jul 2014 18:47:45 +0000 (14:47 -0400)]
staging: unisys: added virthba enable_ints entry
This patch adds enable_ints entry to virthba directory
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 21 Jul 2014 18:47:44 +0000 (14:47 -0400)]
staging: unisys: added virthba rqwait entry
This patch adds the rqwait entry into the virthba debugfs directory
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 21 Jul 2014 18:47:43 +0000 (14:47 -0400)]
staging: unisys: added virthba debugfs dir and info entry
This patch adds virthba debugfs directory and info entry
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Mon, 21 Jul 2014 18:47:42 +0000 (14:47 -0400)]
staging: unisys: remove virthba proc files
This patch removes all proc entries, directories, and functions
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thierry Reding [Mon, 21 Jul 2014 11:54:41 +0000 (13:54 +0200)]
staging/nvec: Remove double const qualifier
The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's
no need to repeat it.
Signed-off-by: Thierry Reding <treding@nvidia.com>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Petar Dimitrijevic [Sun, 20 Jul 2014 07:34:55 +0000 (09:34 +0200)]
staging: vt6655: Fixed checkpatch errors
This patch fixes the errors report by the checkpatch script.
Most of them are use of C99 comments.
The checkpatch doesn't report any errors after the clean up.
However, please not that there are still ton of warnings left.
Signed-off-by: Petar Dimitrijevic <petar.dimitrijevic@vorteksed.com.mk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Igor Bezukh [Sun, 20 Jul 2014 09:34:00 +0000 (12:34 +0300)]
Staging: vt6655: Remove redundant comments in wcmd.h
Removed redundant comments in the header file wcmd.h
Signed-off-by: Igor Bezukh <igbzkh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 20 Jul 2014 13:14:13 +0000 (15:14 +0200)]
Staging: bcm: nvm.c: replaced member accessing with variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 20 Jul 2014 13:14:12 +0000 (15:14 +0200)]
Staging: bcm: nvm.c: Removed indentation level by concatenating nested if statements
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 20 Jul 2014 13:14:11 +0000 (15:14 +0200)]
Staging: bcm: nvm.c: Removed indentation level by using continue statement
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 20 Jul 2014 13:14:10 +0000 (15:14 +0200)]
Staging: bcm: nvm.c: Outsourced chunk of code into function
This patch outsources a chunk of code into an own function. It also
refactors the variable names which are used within this function.
The function name may be not appropriate.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 20 Jul 2014 13:14:09 +0000 (15:14 +0200)]
Staging: bcm: nvm.c: Shortened lines
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Riccardo Lucchese [Mon, 21 Jul 2014 10:19:05 +0000 (12:19 +0200)]
staging: lustre: lov: Add a space before open braces '{' in lov_request.c
Fix the following checkpatch.pl issue in lov_request.c:
ERROR: space required before the open brace '{'
Signed-off-by: Riccardo Lucchese <riccardo.lucchese@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Riccardo Lucchese [Mon, 21 Jul 2014 10:15:56 +0000 (12:15 +0200)]
staging: lustre: lov: Add a blank line after declarations in lov_request.c
Fix the following checkpatch.pl issue in lov_request.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Riccardo Lucchese <riccardo.lucchese@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Riccardo Lucchese [Mon, 21 Jul 2014 10:15:55 +0000 (12:15 +0200)]
staging: lustre: lov: Cleanup lov_check_set() in lov_request.c
Make the code clearer by introducing a local variable and removing the
unnecessary 'if' statement.
Signed-off-by: Riccardo Lucchese <riccardo.lucchese@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Phong Tran [Sun, 20 Jul 2014 04:10:55 +0000 (11:10 +0700)]
staging: android: ion: ion_cma_heap.c: Fix checkpatch warning
This patch fix coding style:
- Remove "fail memory allocation" waring
- Remove return of void function
Tested by compilation only
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
LABBE Corentin [Sat, 19 Jul 2014 17:34:42 +0000 (19:34 +0200)]
staging: sep: Fix blank lines issue reported by checkpatch
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
LABBE Corentin [Sat, 19 Jul 2014 17:34:41 +0000 (19:34 +0200)]
staging: sep: Fix misceanellous problems reported by checkpatch
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
LABBE Corentin [Sat, 19 Jul 2014 17:34:40 +0000 (19:34 +0200)]
staging: sep: No else is necessary after a break (reported by checkpatch)
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:35 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_usb_send_context context into vnt_get_duration_le
Removing priv, frame_length and need_ack
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:34 +0000 (15:33 +0100)]
staging; vt6656: rxtx add current_rate into vnt_usb_send_context as tx_rate
Create u8 tx_rate and remove current_rate from function declarations
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:33 +0000 (15:33 +0100)]
staging: vt6656: rxtx move frame_len/size into vnt_usb_send_context as frame_len
Removing frame_len and frame_size from function declarations
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:32 +0000 (15:33 +0100)]
staging: vt6656: move need_ack into into vnt_usb_send_context
Fixing need_ack to u8 and removing from function declarations.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:31 +0000 (15:33 +0100)]
staging: vt6656: rxtx move pkt_type into vnt_usb_send_context
Removing pkt_type from functions
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:30 +0000 (15:33 +0100)]
staging: vt6656: vnt_get_duration_le fix typo piv to priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:29 +0000 (15:33 +0100)]
staging: vt6656: dead code remove channel switch.
The driver needs to do anything special for channel switch.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:28 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private rename byBBPreEDIndex with bb_pre_ed_index
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:27 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byBBPreEDRSSI with bb_pre_ed_rssi
Remove type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:26 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove dead code ldBmThreshold
ldBmThreshold was used in old function s_vCheckSensitivity which
had been disabled in orginal vendors code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:25 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace abyBBVGA with bb_vga
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:24 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byAutoFBCtrl with auto_fb_ctrl
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:23 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wSeqCounter with seq_counter
Removing type prefix and camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:22 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove dead variable bBarkerPreambleMd
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:21 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace bShortSlotTime with short_slot_time
Removing type prefix and camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:20 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove camel case retry limit
camel case changes
byShortRetryLimit -> short_retry_limit
byLongRetryLimit -> long_retry_limit
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:19 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wCurrentRate with current_rate
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:18 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private rf power table remove camel case
Camel case changes
byCCKPwr -> cck_pwr
byOFDMPwrG -> ofdm_pwr_g
byOFDMPwrA -> ofdm_pwr_a
byCurPwr -> power
abyCCKPwrTbl -> cck_pwr_tbl
abyOFDMPwrTbl -> ofdm_pwr_tbl
abyOFDMAPwrTbl -> ofdm_a_pwr_tbl
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:17 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byPreambleType with preamble_type
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:16 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace abyEEPROM with eeprom
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:15 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byTopCCKBasicRate with top_cck_basic_rate
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:14 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byTopOFDMBasicRate with top_ofdm_basic_rate
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:13 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wBasicRate with basic_rates
The same name as in struct ieee80211_bss_conf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:12 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byPacketType with packet_type
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 20 Jul 2014 14:33:11 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byBBType with bb_type
Removing type prefix and camel case.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:18 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove camel case IFS names
Camel case changes
uSIFS -> sifs
uDIFS -> difs
uEIFS -> eifs
uSlot -> slot
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:17 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove uCwMin/uCwMax
Although set these variables are not used.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:16 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove camel case antenna variables
Camel case changes
bTxRxAntInv -> tx_rx_ant_inv
dwRxAntennaSel -> rx_antenna_sel
byRxAntennaMode -> rx_antenna_mode
byTxAntennaMode -> tx_antenna_mode
byRadioCtl -> radio_ctl
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:15 +0000 (12:30 +0100)]
staging: vt6656: antenna modes remove unused variables
dwTxAntennaSel is always the same as dwRxAntennaSel
byAntennaCount is never used.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:14 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename uCurrRSSI to current_rssi
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:13 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename qwCurrTSF to current_tsf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:12 +0000 (12:30 +0100)]
staging: vt6656: replace bExistSWNetAddr with exist_sw_net_addr
Always needed as u8 type.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:11 +0000 (12:30 +0100)]
staging: vt6656: rename abyPermanentNetAddr to permanent_net_addr
Removing prefix and camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:10 +0000 (12:30 +0100)]
staging: vt6656: remame abyCurrentNetAddr to current_net_addr
Removing prefix and camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:09 +0000 (12:30 +0100)]
staging: vt6656: remove variable byZoneType
Zone types are nolonger handled by driver.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:08 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename byBBRxConf to bb_rx_conf
Remove camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:07 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private replace byRFType with rf_type
Remove camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:06 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename byLocalID to local_id
Removing camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:05 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename wFirmwareVersion to firmware_version
Removing camel case
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:04 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename cdTD to num_tx_context
number of tx_context
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 19 Jul 2014 11:30:03 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename cbRD to num_rcb
Number of rcb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:09 +0000 (11:25 +0200)]
staging: rtl8723au: rtw_resume(): release semaphore before exit on error
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:08 +0000 (11:25 +0200)]
staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:07 +0000 (11:25 +0200)]
staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:06 +0000 (11:25 +0200)]
staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:05 +0000 (11:25 +0200)]
staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions
The whole antenna diversity selection was completely pointless as all
the end functions called were no-ops.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:04 +0000 (11:25 +0200)]
staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:03 +0000 (11:25 +0200)]
staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:02 +0000 (11:25 +0200)]
staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:01 +0000 (11:25 +0200)]
staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:25:00 +0000 (11:25 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:59 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:58 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:57 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:56 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:55 +0000 (11:24 +0200)]
staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *
This will allow us to access variables in the hal_data struct
directly, and get rid of the horrendous ODM_CMNINFO spaghetti API.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:54 +0000 (11:24 +0200)]
staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:53 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of awful unused ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:52 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of useless ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:51 +0000 (11:24 +0200)]
staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:50 +0000 (11:24 +0200)]
staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:49 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:48 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>