Jakub Jelinek [Tue, 20 Nov 2018 20:44:38 +0000 (21:44 +0100)]
re PR tree-optimization/87895 (ICE in purge_dead_edges, at cfgrtl.c:3246)
PR tree-optimization/87895
* omp-simd-clone.c (ipa_simd_modify_function_body): When removing
or replacing GIMPLE_RETURN, set EDGE_FALLTHRU on the edge to EXIT.
(simd_clone_adjust): Don't set EDGE_FALLTHRU here. In a loop that
redirects edges to EXIT to edges to incr_bb, iterate while EXIT
has any preds and always use EDGE_PRED (, 0).
* gcc.dg/gomp/pr87895-1.c: New test.
* gcc.dg/gomp/pr87895-2.c: New test.
* gcc.dg/gomp/pr87895-3.c: New test.
From-SVN: r266328
Uros Bizjak [Tue, 20 Nov 2018 19:43:20 +0000 (20:43 +0100)]
re PR target/88070 (ICE in create_pre_exit, at mode-switching.c:438)
PR target/88070
* mode-switching.c (create_pre_exit): After reload, always split the
fallthrough edge to the exit block.
testsuite/ChangeLog:
PR target/88070
* gcc.target/i386/pr88070.c: New test.
From-SVN: r266326
Jan Hubicka [Tue, 20 Nov 2018 18:06:03 +0000 (19:06 +0100)]
ipa-devirt.c (add_type_duplicate): Do not ICE on incomplete enums.
* ipa-devirt.c (add_type_duplicate): Do not ICE on incomplete enums.
* tree.c (build_array_type_1): Forward declare.
(fld_type_variant_equal_p): Add INNER_TYPE parameter.
(fld_type_variant): Likewise.
(fld_simplified_types): New hash.
(fld_process_array_type): New function.
(fld_incomplete_type_of): Handle array and enumeration types.
(fld_simplified_type): Handle simplification of arrays.
(free_lang_data): Allocate and free simplified types hash.
From-SVN: r266325
Jan Hubicka [Tue, 20 Nov 2018 17:00:46 +0000 (17:00 +0000)]
Fix missing commit log.
From-SVN: r266323
Jan Hubicka [Tue, 20 Nov 2018 16:22:19 +0000 (17:22 +0100)]
re PR ipa/87957 (ICE tree check: expected tree that contains ‘decl minimal’ structure, have ‘identifier_node’ in warn_odr, at ipa-devirt.c:1051 since r265519)
PR lto/87957
* ipa-devirt.c (odr_subtypes_equivalent_p): Report ODR violation
when sybtype already violates ODR.
(get_odr_type): Do not ICE when insert is false and type duplicate
is not registered yet.
(register_odr_type): Be sure to register subtypes first.
From-SVN: r266322
Andreas Krebbel [Tue, 20 Nov 2018 16:19:54 +0000 (16:19 +0000)]
S/390: Fix flogr RTX.
The flogr instruction uses a 64 bit register pair target operand. In
the RTX we model this as a write to a TImode register. Unfortunately
the RTX's being assigned to the two parts of the target operand were
swapped. This is no problem if in the end the flogr instruction will
be emitted since the instruction still does what the clzdi expander
expects. However, a problem arises when the RTX is used to optimize
CLZ for a constant input operand. Even then it matters only if the
expression couldn't be folded on tree level already.
In the testcase this happened thanks to loop unrolling on RTL level.
The iteration variable is used as an argument to the clz
builtin. Due to the loop unrolling it becomes a constant and after
folding the broken RTX leads to a wrong assumption.
gcc/ChangeLog:
2018-11-20 Andreas Krebbel <krebbel@linux.ibm.com>
* config/s390/s390.md ("clztidi2"): Swap the RTX's written to the
DImode parts of the target operand.
gcc/testsuite/ChangeLog:
2018-11-20 Andreas Krebbel <krebbel@linux.ibm.com>
* gcc.target/s390/flogr-1.c: New test.
From-SVN: r266321
Jan Hubicka [Tue, 20 Nov 2018 15:58:37 +0000 (15:58 +0000)]
re PR ipa/87706 (Inlined functions trigger invalid -Wmissing-profile warning)
PR ipa/87706
* ipa-fnsummary.c (pass_ipa_fnsummary): Do not remove functions
* ipa.c (possible_inline_candidate_p): Break out from ..
(process_references): ... here ; drop before_inlining_p;
cleanup handling of alises.
(walk_polymorphic_call_targets): Likewise.
(symbol_table::remove_unreachable_nodes): Likewise.
* passes.c (pass_data_ipa_remove_symbols): New structure.
(pass_ipa_remove_symbols): New pass.
(make_pass_ipa_remove_symbols): New function.
* tree-pass.h (make_pass_ipa_remove_symbols): Declare.
* passes.def (pass_ipa_remove_symbols): Schedule after early passes.
From-SVN: r266320
Nathan Sidwell [Tue, 20 Nov 2018 15:54:12 +0000 (15:54 +0000)]
re PR tree-optimization/87926 (bad array-index warning breaks --disable-checking bootstrap)
PR 87926
* Makefile.in (bitmap.o-warn): Use -Wno-error=array-bounds.
From-SVN: r266319
Jan Hubicka [Tue, 20 Nov 2018 14:09:27 +0000 (15:09 +0100)]
re PR lto/87997 (ICE in cp_var_mod_type_p at gcc/cp/cp-objcp-common.c:107 since r265870)
PR lto/87997
* tree.c (free_lang_data_in_cgraph): Add argument fld; break out
type checking to...
(free_lang_data) ... here; update call of free_lang_data_in_cgraph.
From-SVN: r266316
Jan Hubicka [Tue, 20 Nov 2018 13:25:04 +0000 (14:25 +0100)]
re PR ipa/87706 (Inlined functions trigger invalid -Wmissing-profile warning)
PR ipa/87706
* ipa-fnsummary.c (pass_ipa_fnsummary): Do not remove functions
* ipa.c (possible_inline_candidate_p): Break out from ..
(process_references): ... here ; drop before_inlining_p;
cleanup handling of alises.
(walk_polymorphic_call_targets): Likewise.
(symbol_table::remove_unreachable_nodes): Likewise.
* passes.c (pass_data_ipa_remove_symbols): New structure.
(pass_ipa_remove_symbols): New pass.
(make_pass_ipa_remove_symbols): New functoin.
* passes.def (pass_ipa_remove_symbols): Schedule after early passes.
From-SVN: r266315
Richard Biener [Tue, 20 Nov 2018 12:20:40 +0000 (12:20 +0000)]
tree-vect-stmts.c (vectorizable_condition): Do not get at else_clause vect def for EXTRACT_LAST_REDUCTION.
2018-11-20 Richard Biener <rguenther@suse.de>
* tree-vect-stmts.c (vectorizable_condition): Do not get
at else_clause vect def for EXTRACT_LAST_REDUCTION. Remove
pointless vect_is_simple_use calls.
From-SVN: r266314
Richard Biener [Tue, 20 Nov 2018 12:18:58 +0000 (12:18 +0000)]
re PR tree-optimization/88074 (g++ hangs on math expression)
2018-11-20 Richard Biener <rguenther@suse.de>
PR tree-optimization/88074
* tree-ssa-dom.c (pass_dominator::execute): Do not walk
backedges.
* gcc.dg/pr88074.c: New testcase.
From-SVN: r266313
Martin Liska [Tue, 20 Nov 2018 12:07:53 +0000 (13:07 +0100)]
Move some i386 C++ tests into g++.target/i386.
2018-11-20 Martin Liska <mliska@suse.cz>
* pr57362.C: Move to g++.target/i386 folder.
* pr57548.C: Likewise.
* pr59492.C: Likewise.
* pr82625.C: Likewise.
* pr85329-2.C: Likewise.
* pr85329.C: Likewise.
From-SVN: r266312
Ville Voutilainen [Tue, 20 Nov 2018 10:42:28 +0000 (12:42 +0200)]
Housekeeping for the effective targets of optional's tests.
* testsuite/20_util/optional/77288.cc: Adjust.
* testsuite/20_util/optional/84601.cc: Likewise.
* testsuite/20_util/optional/assignment/1.cc: Likewise.
* testsuite/20_util/optional/assignment/2.cc: Likewise.
* testsuite/20_util/optional/assignment/3.cc: Likewise.
* testsuite/20_util/optional/assignment/4.cc: Likewise.
* testsuite/20_util/optional/assignment/5.cc: Likewise.
* testsuite/20_util/optional/assignment/6.cc: Likewise.
* testsuite/20_util/optional/assignment/7.cc: Likewise.
* testsuite/20_util/optional/assignment/8.cc: Likewise.
* testsuite/20_util/optional/cons/77727.cc: Likewise.
* testsuite/20_util/optional/cons/copy.cc: Likewise.
* testsuite/20_util/optional/cons/deduction.cc: Likewise.
* testsuite/20_util/optional/cons/default.cc: Likewise.
* testsuite/20_util/optional/cons/move.cc: Likewise.
* testsuite/20_util/optional/cons/trivial.cc: Likewise.
* testsuite/20_util/optional/cons/value.cc: Likewise.
* testsuite/20_util/optional/cons/value_neg.cc: Likewise.
* testsuite/20_util/optional/constexpr/cons/default.cc: Likewise.
* testsuite/20_util/optional/constexpr/cons/value.cc: Likewise.
* testsuite/20_util/optional/constexpr/in_place.cc: Likewise.
* testsuite/20_util/optional/constexpr/nullopt.cc: Likewise.
* testsuite/20_util/optional/constexpr/observers/1.cc: Likewise.
* testsuite/20_util/optional/constexpr/observers/4.cc: Likewise.
* testsuite/20_util/optional/constexpr/observers/5.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/1.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/2.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/3.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/4.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/5.cc: Likewise.
* testsuite/20_util/optional/constexpr/relops/6.cc: Likewise.
* testsuite/20_util/optional/in_place.cc: Likewise.
* testsuite/20_util/optional/make_optional.cc: Likewise.
* testsuite/20_util/optional/nullopt.cc: Likewise.
* testsuite/20_util/optional/observers/1.cc: Likewise.
* testsuite/20_util/optional/observers/2.cc: Likewise.
* testsuite/20_util/optional/observers/3.cc: Likewise.
* testsuite/20_util/optional/observers/4.cc: Likewise.
* testsuite/20_util/optional/observers/5.cc: Likewise.
* testsuite/20_util/optional/observers/6.cc: Likewise.
* testsuite/20_util/optional/relops/1.cc: Likewise.
* testsuite/20_util/optional/relops/2.cc: Likewise.
* testsuite/20_util/optional/relops/3.cc: Likewise.
* testsuite/20_util/optional/relops/4.cc: Likewise.
* testsuite/20_util/optional/relops/5.cc: Likewise.
* testsuite/20_util/optional/relops/6.cc: Likewise.
* testsuite/20_util/optional/relops/7.cc: Likewise.
* testsuite/20_util/optional/requirements.cc: Likewise.
* testsuite/20_util/optional/swap/1.cc: Likewise.
* testsuite/20_util/optional/swap/2.cc: Likewise.
* testsuite/20_util/optional/typedefs.cc: Likewise.
From-SVN: r266310
Jakub Jelinek [Tue, 20 Nov 2018 10:39:53 +0000 (11:39 +0100)]
re PR bootstrap/88106 (Bootstrap failure on mingw32)
PR bootstrap/88106
* config/mingw32/affinity-fmt.c: New file.
From-SVN: r266309
Richard Biener [Tue, 20 Nov 2018 10:27:57 +0000 (10:27 +0000)]
re PR tree-optimization/88069 (ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.c:709)
2018-11-20 Richard Biener <rguenther@suse.de>
PR tree-optimization/88069
* tree-ssa-sccvn.c (visit_phi): Do not value-number to unvisited
virtual PHI arguments.
* gcc.dg/pr88069.c: New testcase.
From-SVN: r266308
Martin Liska [Tue, 20 Nov 2018 10:17:29 +0000 (11:17 +0100)]
Add -fomit-frame-pointer to a test-case (PR ipa/88093).
2018-11-20 Martin Liska <mliska@suse.cz>
PR ipa/88093
* gcc.target/i386/ipa-stack-alignment.c: Add
-fomit-frame-pointer.
From-SVN: r266307
Ilya Leoshkevich [Tue, 20 Nov 2018 09:32:49 +0000 (09:32 +0000)]
S/390: Skip LT(G) peephole when literal pool is involved
By the time peephole optimizations run, we've already made up our mind
whether to use base-register or relative addressing for literal pool
entries. LT(G) supports only base-register addressing, and so it is
too late to convert L(G)RL + compare to LT(G). This change should not
make the code worse unless building with e.g. -fno-dce, since comparing
literal pool entries to zero should be optimized away during earlier
passes.
gcc/ChangeLog:
2018-11-20 Ilya Leoshkevich <iii@linux.ibm.com>
PR target/88083
* config/s390/s390.md: Skip LT(G) peephole when literal pool is
involved.
* rtl.h (contains_constant_pool_address_p): New function.
* rtlanal.c (contains_constant_pool_address_p): Likewise.
gcc/testsuite/ChangeLog:
2018-11-20 Ilya Leoshkevich <iii@linux.ibm.com>
PR target/88083
* gcc.target/s390/pr88083.c: New test.
From-SVN: r266306
Richard Biener [Tue, 20 Nov 2018 09:31:06 +0000 (09:31 +0000)]
re PR middle-end/83215 (C++: struct with char-array assumed to alias with everything)
2018-11-20 Richard Biener <rguenther@suse.de>
PR middle-end/83215
* alias.c (component_uses_parent_alias_set_from): Remove
alias-set zero and TYPE_TYPELESS_STORAGE case both already
handled in other ways.
* g++.dg/tree-ssa/pr83215.C: New testcase.
From-SVN: r266305
Eric Botcazou [Tue, 20 Nov 2018 08:59:30 +0000 (08:59 +0000)]
re PR rtl-optimization/85925 (compilation of masking with 257 goes wrong in combine at -02)
PR rtl-optimization/85925
* rtl.h (word_register_operation_p): New predicate.
* combine.c (record_dead_and_set_regs_1): Only apply specific handling
for WORD_REGISTER_OPERATIONS targets to word_register_operation_p RTX.
* rtlanal.c (nonzero_bits1): Likewise. Adjust couple of comments.
(num_sign_bit_copies1): Likewise.
From-SVN: r266302
Richard Biener [Tue, 20 Nov 2018 08:06:09 +0000 (08:06 +0000)]
re PR lto/88087 (ICE in execute at tree-ssa-pre.c:4220 since r266183)
2018-11-20 Richard Biener <rguenther@suse.de>
PR tree-optimization/88087
* tree-ssa-pre.c (create_expression_by_pieces): Re-materialize
call fntype.
* tree-ssa-sccvn.c (copy_reference_ops_from_call): Remember
call fntype.
* gcc.dg/tree-ssa/pr88087.c: New testcase.
From-SVN: r266301
Richard Biener [Tue, 20 Nov 2018 08:04:26 +0000 (08:04 +0000)]
re PR bootstrap/88089 (build failure with GCC 4.9 on SPARC/Solaris)
2018-11-20 Richard Biener <rguenther@suse.de>
PR middle-end/88089
* tree-data-ref.c (lambda_matrix_right_hermite): Use abs_hwi.
From-SVN: r266300
Paul Koning [Tue, 20 Nov 2018 01:54:46 +0000 (20:54 -0500)]
align-3.c: Skip if pdp11.
* gcc.c-torture/execute/align-3.c: Skip if pdp11.
* gcc.c-torture/execute/pr23467.c: Ditto.
* gcc.c-torture/execute/pr36093.c: Ditto.
* gcc.c-torture/execute/pr43783.c: Ditto.
* gcc.dg/const-elim-2.c: Xfail if pdp11.
* gcc.dg/torture/pr36400.c: Ditto.
* gcc.dg/tree-ssa/loop-1.c: Xfail for pdp11. Add pdp11 to check
for jsr.
From-SVN: r266299
Paul Koning [Tue, 20 Nov 2018 01:39:08 +0000 (20:39 -0500)]
target-supports.exp (check_weak_available): Return "no" for pdp11.
* lib/target-supports.exp (check_weak_available): Return "no" for
pdp11.
From-SVN: r266297
GCC Administrator [Tue, 20 Nov 2018 00:16:37 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266293
Alexandre Oliva [Tue, 20 Nov 2018 00:07:47 +0000 (00:07 +0000)]
PR81878: fix --disable-bootstrap --enable-languages=ada
gnattools build machinery uses just-build xgcc and xg++ as $(CC) and
$(CXX) in native builds. However, if C and C++ languages are not
enabled, it won't find them. So, enable C and C++ if Ada is enabled.
Most of the time, this is probably no big deal: C is always enabled
anyway, and C++ is already enabled for bootstraps.
We need not enable those for cross builds, however. At first I just
took the logic from gnattools/configure, but found it to be lacking:
it would use the just-built tools even in cross-back settings, whose
tools just built for the host would not run on the build machine. So
I've narrowed down the test to rely on autoconf-detected cross-ness
(build->host only), but also to ensure that host matches build, and
that target matches host.
I've considered sourcing ada/config-lang.in from within
gnattools/configure, and testing lang_requires as set by it, so as to
avoid a duplication of tests that ought to remain in sync, but decided
it would be too fragile, as ada/config-lang.in does not expect srcdir
to refer to gnattools.
for gcc/ada/ChangeLog
PR ada/81878
* gcc-interface/config-lang.in (lang_requires): Set to "c c++"
when gnattools wants it.
for gnattools/ChangeLog
PR ada/81878
* configure.ac (default_gnattools_target): Do not mistake
just-built host tools as native in cross-back toolchains.
* configure: Rebuilt.
From-SVN: r266290
Jan Hubicka [Mon, 19 Nov 2018 23:27:10 +0000 (00:27 +0100)]
re PR ipa/87957 (ICE tree check: expected tree that contains ‘decl minimal’ structure, have ‘identifier_node’ in warn_odr, at ipa-devirt.c:1051 since r265519)
PR lto/87957
* ipa-devirt.c (free_enum_values): Do not ICE on ODR vilations.
From-SVN: r266289
Sandra Loosemore [Mon, 19 Nov 2018 21:53:09 +0000 (16:53 -0500)]
re PR driver/50250 (Driver documentation on -l does not mention shared libraries)
2018-11-19 Sandra Loosemore <sandra@codesourcery.com>
PR driver/50250
gcc/
* doc/invoke.texi (Link Options): Mention shared libraries
in documentation for the -l option. Simplify discussion and
point to the system linker documentation for details.
From-SVN: r266287
Marek Polacek [Mon, 19 Nov 2018 21:37:01 +0000 (21:37 +0000)]
PR c++/87781 - detect invalid elaborated-type-specifier.
* parser.c (cp_parser_elaborated_type_specifier): Ensure that
typename follows a nested-name-specifier.
* g++.dg/parse/elab3.C: New test.
* g++.dg/template/crash115.C: Adjust dg-error.
From-SVN: r266285
François Dumont [Mon, 19 Nov 2018 21:02:17 +0000 (21:02 +0000)]
2018-11-19 François Dumont <fdumont@gcc.gnu.org>
* include/ext/throw_allocator.h
(annotate_base::insert(void*, size_t)): Use insert result to check for
double insert attempt.
(annotate_base::insert_construct(void*)): Likewise.
(annotate_base::check_allocated(void*, size_t)): Return found iterator.
(annotate_base::erase(void*, size_t)): Use latter method returned
iterator.
(annotate_base::check_constructed(void*, size_t)): Return found iterator.
(annotate_base::erase_construct(void*)): Use latter method returned
iterator.
From-SVN: r266284
Peter Bergner [Mon, 19 Nov 2018 19:35:51 +0000 (19:35 +0000)]
re PR rtl-optimization/88033 (ICE on valid code at -O2 and -O3 on x86-64-linux-gnu: in remove_some_program_points_and_update_live_ranges, at lra-lives.c:1179)
gcc/
PR rtl-optimization/88033
* ira-lives.c (non_conflicting_reg_copy_p): Skip copies from a register
to itself. Use HARD_REGISTER_NUM_P.
gcc/testsuite/
PR rtl-optimization/88033
* gcc.target/i386/pr88033.c: New test.
From-SVN: r266282
Kyrylo Tkachov [Mon, 19 Nov 2018 17:58:00 +0000 (17:58 +0000)]
Disable unrolling for loops vectorised with non-constant VF
This is an alternative to https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00694.html
As richi suggested, this disables unrolling of loops vectorised with variable-length SVE
in the vectoriser itself through the loop->unroll member.
It took me a few tries to get it right, as it needs to be set to '1' to disable unrolling,
the rationale for that mechanism is described in the comment in cfgloop.h.
* tree-vect-loop.c (vect_transform_loop): Disable further unrolling
of the loop if vf is non-constant.
* gcc.target/aarch64/sve/unroll-1.c: New test.
From-SVN: r266281
David Malcolm [Mon, 19 Nov 2018 16:42:03 +0000 (16:42 +0000)]
Fix -fsave-optimization-record ICE (PR tree-optimization/87025)
PR tree-optimization/87025 reports an ICE within
-fsave-optimization-record's optrecord_json_writer.
The issue is that dump_context::begin_scope creates an optinfo
of kind OPTINFO_KIND_SCOPE, but fails to call
dump_context::end_any_optinfo, so the optinfo for the scope remains
pending.
The JSON writer would normally push a JSON array for the "scope" optinfo
when the latter is emitted. However, if a dump_* call happens that
doesn't flush the "scope" optinfo e.g. dump_printf (as opposed to
dump_printf_loc), that dump_ call is added to the pending optinfo, and
optinfo::handle_dump_file_kind changes the pending optinfo's m_kind
(e.g. to OPTINFO_KIND_NOTE). Hence when the pending optinfo is
eventually emitted, it isn't OPTINFO_KIND_SCOPE anymore, and hence
the JSON writer doesn't create and push a JSON array for it, leading
to dump_context's view of scopes getting out-of-sync with that of
the JSON writer's.
Later, dump_context::end_scope unconditionally tries to pop the JSON scope
array, but no JSON scope array was added, leading to an assertion
failure (or crash).
The fix is to call dump_context::end_any_optinfo immediately after
creating the scope optinfo, so that it is emitted immediately, ensuring
that the JSON writer stays in-sync with the dump_context.
gcc/ChangeLog:
PR tree-optimization/87025
* dumpfile.c (dump_context::begin_scope): Call end_any_optinfo
immediately after creating the scope optinfo.
(selftest::test_pr87025): New function.
(selftest::dumpfile_c_tests): Call it.
* optinfo-emit-json.cc (optrecord_json_writer::pop_scope): Assert
that we're not popping the top-level records array.
* optinfo.cc (optinfo::handle_dump_file_kind): Assert that we're
not changing the kind of a "scope" optinfo.
gcc/testsuite/ChangeLog:
PR tree-optimization/87025
* gcc.dg/pr87025.c: New test.
From-SVN: r266280
David Malcolm [Mon, 19 Nov 2018 16:31:03 +0000 (16:31 +0000)]
Eliminate global state from -fsave-optimization-record
As work towards fixing PR tree-optimization/87025, this patch
eliminates global state from optinfo-emit-json.cc in favor
of adding an optional m_json_writer field to dump_context,
replacing the m_forcibly_enable_optinfo flag.
This allows for writing selftests for the interaction of the
JSON-building code with the dumpfile.c code.
In particular, the existing selftest that created optinfo
instances now exercise the JSON-building code (although no
JSON is actually written out).
The patch also simplifies the layering by replacing optinfo::emit ()
with dump_context::emit_optinfo, so that dump_context has
responsibility for keeping track of dump destinations.
gcc/ChangeLog:
PR tree-optimization/87025
* dump-context.h: Include "optinfo.h".
(class optrecord_json_writer): New forward decl.
(dump_context::forcibly_enable_optinfo_p): Delete.
(dump_context::optinfo_enabled_p): New member function.
(dump_context::optimization_records_enabled_p): New member
function.
(dump_context::set_json_writer): New member function.
(dump_context::emit_optinfo): New member function.
(dump_context::m_forcibly_enable_optinfo): Delete.
(dump_context::m_json_writer): New member data.
* dumpfile.c (dump_context::set_json_writer): New member function.
(dump_context::finish_any_json_writer): New member function.
(dump_context::end_scope): Replace call to
optimization_records_maybe_pop_dump_scope with call to
m_json_writer->pop_scope.
(dump_context::optinfo_enabled_p): New member function.
(dump_context::end_any_optinfo): Replace call to optinfo::emit with call
to dump_context::emit_optinfo.
(dump_context::emit_optinfo): New member function.
(temp_dump_context::temp_dump_context): Replace
m_forcibly_enable_optinfo with call to set_json_writer.
(temp_dump_context::~temp_dump_context): Clean up any json writer.
* optinfo-emit-json.cc (class optrecord_json_writer): Move to
optinfo-emit-json.h
(the_json_writer): Delete.
(optimization_records_start): Delete.
(optimization_records_finish): Delete.
(optimization_records_enabled_p): Delete, in favor of
dump_context::optimization_records_enabled_p.
(optimization_records_maybe_record_optinfo): Delete.
(optimization_records_maybe_pop_dump_scope): Delete.
* optinfo-emit-json.h: Include "json.h". Delete forward
decl of opt_pass.
(optimization_records_start): Delete.
(optimization_records_finish): Delete.
(optimization_records_enabled_p): Delete.
(optimization_records_maybe_record_optinfo): Delete.
(optimization_records_maybe_pop_dump_scope): Delete.
(class optrecord_json_writer): Move here from
optinfo-emit-json.cc.
* optinfo.cc (optinfo::emit_for_opt_problem): Replace call
to optinfo::emit with call to dump_context::emit_optinfo.
(optinfo::emit): Delete, in favor of dump_context::emit_optinfo.
(optinfo_enabled_p): Delete, in favor of
dump_context::optinfo_enabled_p.
(optinfo_wants_inlining_info_p): Update for conversion o
optimization_records_enabled_p to a member function of
dump_context.
* optinfo.h (optinfo_enabled_p): Delete, in favor of
dump_context::optinfo_enabled_p.
(optinfo::emit): Delete, in favor of dump_context::emit_optinfo.
* toplev.c: Include "dump-context.h".
(compile_file): Replace call to optimization_records_finish with
dump_context::finish_any_json_writer.
(do_compile): Replace call to optimization_records_start with
conditionally creating a optrecord_json_writer for the
dump_context.
From-SVN: r266279
Ville Voutilainen [Mon, 19 Nov 2018 15:05:18 +0000 (17:05 +0200)]
re PR libstdc++/87855 (std::optional<T> only copy-constructible if T is trivially copy-constructible)
PR libstdc++/87855
Also implement P0602R4 (variant and optional
should propagate copy/move triviality) for std::optional.
* include/std/optional (_Optional_payload): Change
the main constraints to check constructibility in
addition to assignability.
(operator=): Make constexpr.
(_M_reset): Likewise.
(_M_construct): Likewise.
(operator->): Likewise.
* testsuite/20_util/optional/assignment/8.cc: Adjust.
* testsuite/20_util/optional/assignment/9.cc: New.
From-SVN: r266278
Martin Liska [Mon, 19 Nov 2018 15:00:41 +0000 (16:00 +0100)]
Fix condition in lto-symtab.c (PR lto/88077).
2018-11-19 Martin Liska <mliska@suse.cz>
PR lto/88077
* lto-symtab.c (lto_symtab_merge): Transform the
condition before r256989.
2018-11-19 Martin Liska <mliska@suse.cz>
PR lto/88077
* gcc.dg/lto/pr88077_0.c: New test.
* gcc.dg/lto/pr88077_1.c: New test.
From-SVN: r266277
Jakub Jelinek [Mon, 19 Nov 2018 14:44:08 +0000 (15:44 +0100)]
re PR tree-optimization/88071 (ICE: verify_gimple failed (error: dead STMT in EH table))
PR tree-optimization/88071
* tree-vect-loop.c (vectorize_fold_left_reduction): Pass true instead
of false as last argument to gsi_remove.
* tree-vect-stmts.c (vect_finish_replace_stmt): Pass true instead of
false as last argument to gsi_replace.
* gcc.dg/pr88071.c: New test.
From-SVN: r266276
Jakub Jelinek [Mon, 19 Nov 2018 14:01:56 +0000 (15:01 +0100)]
re PR c++/60994 (gcc does not recognize hidden/shadowed enumeration as valid nested-name-specifier)
PR c++/60994
* g++.dg/lookup/pr60994.C: New test.
From-SVN: r266275
Jakub Jelinek [Mon, 19 Nov 2018 13:44:13 +0000 (14:44 +0100)]
re PR debug/87039 (DW_OP_fbreg used without a frame base on a C++ code w/ -fopenmp)
PR debug/87039
* omp-expand.c: Don't include debug.h.
(adjust_context_and_scope): Add REGION argument. Find DECL_CONTEXT
from innermost outer parallel, task, teams or target that has a
child_fn set, or, if there is no such outer region, use
current_function_decl. Do the DECL_CONTEXT adjustment regardless of
whether a suitable BLOCK is found or not.
(expand_parallel_call, expand_teams_call): Don't call
adjust_context_and_scope here.
(grid_expand_target_grid_body): Revert 2017-01-25 changes.
(expand_omp_taskreg, expand_omp_target): Likewise. Call
adjust_context_and_scope.
* dwarf2out.c (dwarf2out_early_global_decl): For
decl_function_context recurse instead of calling dwarf2out_decl.
* g++.dg/gomp/pr78363-4.C: New test.
* g++.dg/gomp/pr78363-5.C: New test.
* g++.dg/gomp/pr78363-6.C: New test.
* g++.dg/gomp/pr78363-7.C: New test.
From-SVN: r266272
Richard Biener [Mon, 19 Nov 2018 11:36:51 +0000 (11:36 +0000)]
re PR c++/87229 (ICE: tree code 'call_expr' is not supported in LTO streams)
2018-11-19 Richard Biener <rguenther@suse.de>
PR lto/87229
* tree.c (free_lang_data_in_one_sizepos): Free non-gimple-val
sizepos values.
* g++.dg/lto/pr87229_0.C: New testcase.
From-SVN: r266271
Martin Liska [Mon, 19 Nov 2018 11:19:15 +0000 (12:19 +0100)]
Fix how we match for count(n*) in gcov tests.
2018-11-19 Martin Liska <mliska@suse.cz>
* g++.dg/gcov/pr84548.C: Remove remove-gcda.
* g++.dg/gcov/ternary.C: Likewise.
* lib/gcov.exp: Support pattern of following form:
count(1*).
From-SVN: r266270
Jonathan Wakely [Mon, 19 Nov 2018 10:53:59 +0000 (10:53 +0000)]
PR libstdc++/88084 - Implement LWG 2777
* include/std/string_view (basic_string_view::copy): Use traits to
copy.
* testsuite/21_strings/basic_string_view/operations/copy/char/2.cc:
New test.
* testsuite/21_strings/basic_string_view/operations/copy/wchar_t/2.cc:
New test.
From-SVN: r266269
Eric Botcazou [Mon, 19 Nov 2018 10:25:35 +0000 (10:25 +0000)]
compare-elim.c (struct comparison): Add not_in_a field.
* compare-elim.c (struct comparison): Add not_in_a field.
(is_not): New static function.
(strip_not): Likewise.
(conforming_compare): Handle a NOT in the first operand.
(can_eliminate_compare): Likewise.
(find_comparison_dom_walker::before_dom_children): Likewise.
(try_eliminate_compare): Likewise.
* config/visium/visium.md (negsi2_insn_set_carry): Turn into...
(neg<mode>2_insn_set_carry): ...this and add missing NEG operation.
From-SVN: r266268
Jonathan Wakely [Mon, 19 Nov 2018 09:52:41 +0000 (09:52 +0000)]
Fix typos in packed attribute documentation
* doc/extend.texi (Common Type Attributes): Fix typos.
From-SVN: r266267
Eric Botcazou [Mon, 19 Nov 2018 09:52:13 +0000 (09:52 +0000)]
Bump copyright year
From-SVN: r266266
Eric Botcazou [Mon, 19 Nov 2018 09:47:36 +0000 (09:47 +0000)]
* gcc-interface/cuintp.c (UI_From_gnu): Remove code for 32-bit hosts.
From-SVN: r266265
Paolo Carlini [Mon, 19 Nov 2018 09:33:18 +0000 (09:33 +0000)]
decl2.c (grokfield): Remove obsolete _vptr check; fix explicit template argument list error location.
/cp
2018-11-18 Paolo Carlini <paolo.carlini@oracle.com>
* decl2.c (grokfield): Remove obsolete _vptr check; fix
explicit template argument list error location.
/testsuite
2018-11-18 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/template/crash91.C: Check location too.
From-SVN: r266264
Martin Liska [Mon, 19 Nov 2018 08:16:17 +0000 (09:16 +0100)]
Strenghten assumption about function start and end line (PR gcov-profile/88045).
2018-11-19 Martin Liska <mliska@suse.cz>
PR gcov-profile/88045
* coverage.c (coverage_begin_function): Add assert.
2018-11-19 Martin Liska <mliska@suse.cz>
PR gcov-profile/88045
* g++.dg/gcov/pr88045.C: New test.
From-SVN: r266262
Martin Liska [Mon, 19 Nov 2018 08:08:28 +0000 (09:08 +0100)]
Detect mixed usage of spaces and tabs.
2018-11-19 Martin Liska <mliska@suse.cz>
* check_GNU_style_lib.py: Detect mixed usage
of spaces and tabs.
From-SVN: r266261
Sandra Loosemore [Mon, 19 Nov 2018 01:04:04 +0000 (20:04 -0500)]
re PR other/40498 (no_instrument_function attribute not documented to prevent -pg instrumentation)
2018-11-18 Sandra Loosemore <sandra@codesourcery.com>
PR other/40498
gcc/
* doc/extend.texi (Common Function Attributes): Document that
no_instrument_function applies to -p and -pg, too.
* doc/invoke.texi (Instrumentation Options): Add cross-references
to docs for -p, -pg, and -finstrument-functions.
From-SVN: r266260
GCC Administrator [Mon, 19 Nov 2018 00:16:45 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266259
Iain Buclaw [Sun, 18 Nov 2018 23:39:16 +0000 (23:39 +0000)]
Remove unused modules from libphobos std.internal package.
libphobos/ChangeLog:
2018-11-19 Iain Buclaw <ibuclaw@gdcproject.org>
* src/Makefile.am: Remove std.internal.digest.sha_SSSE3 and
std.internal.math.biguintx86 modules.
* src/Makefile.in: Rebuild.
* src/std/internal/digest/sha_SSSE3.d: Remove.
* src/std/internal/math/biguintx86.d: Remove.
From-SVN: r266256
Michele Pezzutti [Sun, 18 Nov 2018 18:32:26 +0000 (19:32 +0100)]
PR libstdc++/83566 - cyl_bessel_j returns wrong result for x>1000
2018-11-16 Michele Pezzutti <mpezz@tiscali.it>
Edward Smith-Rowland <3dw4rd@verizon.net>
PR libstdc++/83566 - cyl_bessel_j returns wrong result for x>1000
for high orders.
* include/tr1/bessel_function.tcc: Perform no fewer than nu/2 iterations
of the asymptotic series (nu is the Bessel order).
* testsuite/tr1/5_numerical_facilities/special_functions/
09_cyl_bessel_j/check_value.cc: Add tests at nu=100, 1000<=x<=2000.
* testsuite/tr1/5_numerical_facilities/special_functions/
11_cyl_neumann/check_value.cc: Ditto.
* testsuite/special_functions/08_cyl_bessel_j/check_value.cc: Ditto.
* testsuite/special_functions/10_cyl_neumann/check_value.cc: Ditto.
Co-Authored-By: Edward Smith-Rowland <3dw4rd@verizon.net>
From-SVN: r266252
Thomas Koenig [Sun, 18 Nov 2018 17:40:23 +0000 (17:40 +0000)]
re PR fortran/88073 (Internal compiler error compiling WHERE construct with -O or -O2)
2018-11-18 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/88073
* frontend-passes.c (combine_array_constructor): Do not do
anything if in a WHERE statement.
2018-11-18 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/88073
* gfortran.dg/where_7.f90: New test.
From-SVN: r266251
Alan Modra [Sun, 18 Nov 2018 10:25:24 +0000 (20:55 +1030)]
Allow target to override gnu-user.h crti and crtn
Also give target access to the gnu-user.h LINK_GCC_C_SEQUENCE_SPEC.
* config/gnu-user.h (GNU_USER_TARGET_CRTI): Define.
(GNU_USER_TARGET_STARTFILE_SPEC): Use it here.
(GNU_USER_TARGET_CRTN): Define.
(GNU_USER_TARGET_ENDFILE_SPEC): Use it here.
(GNU_USER_TARGET_LINK_GCC_C_SEQUENCE_SPEC): Define.
From-SVN: r266250
Alan Modra [Sun, 18 Nov 2018 10:22:10 +0000 (20:52 +1030)]
Delete !HAVE_LD_PIE variants of startfile/endfile specs
The HAVE_LD_PIE variant doesn't contain anything that will break
linking when !HAVE_LD_PIE that isn't already broken if you choose to
build PIEs with a linker that doesn't support PIE. All this
HAVE_LD_PIE protects is the choice of different crt files, which is
more about libc capability than linker capability.
* config/gnu-user.h (GNU_USER_TARGET_STARTFILE_SPEC): Delete
!HAVE_LD_PIE variant.
(GNU_USER_TARGET_ENDFILE_SPEC): Likewise.
From-SVN: r266249
Thomas Koenig [Sun, 18 Nov 2018 09:16:19 +0000 (09:16 +0000)]
re PR fortran/70260 (ICE: gimplification failed)
2018-11-18 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/70260
* expr.c (gfc_check_assign): Reject assigning to an external
symbol.
(gfc_check_pointer_assign): Add suppress_type_test
argument. Insert line after if. A non-proc pointer can not point
to a constant. Only check types if suppress_type_test is false.
* gfortran.h (gfc_check_pointer_assign): Add optional
suppress_type_test argument.
* resolve.c (gfc_resolve_code): Move up gfc_check_pointer_assign
and give it the extra argument.
(resolve_fl_procedure): Set error on value for a function with
an inizializer.
2018-11-18 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/70260
* gfortran.dg/proc_ptr_result_5.f90: Add dg-error directive.
* gfortran.dg/protected_4.f90: Split line to allow for extra error.
* gfortran.dg/protected_6.f90: Likewise.
* gfortran.dg/assign_11.f90: New test.
* gfortran.dg/pointer_assign_12.f90: New test.
From-SVN: r266248
Nick Clifton [Sun, 18 Nov 2018 04:12:03 +0000 (23:12 -0500)]
Correct ChangeLog for PR31357 fix
From-SVN: r266247
Nick Clifton [Sun, 18 Nov 2018 04:09:14 +0000 (23:09 -0500)]
re PR driver/31357 (document that --help and --help=<value> options cannot be combined.)
2018-11-17 Eric Gallager <egallager@gcc.gnu.org>
Sandra Loosemore <sandra@codesourcery.com>
PR driver/31357
gcc/
* doc/invoke.texi (Overall Options): Document that --help and
--help=<value> options cannot be combined.
Co-Authored-By: Sandra Loosemore <sandra@codesourcery.com>
From-SVN: r266246
GCC Administrator [Sun, 18 Nov 2018 00:16:39 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266245
Jonathan Wakely [Sat, 17 Nov 2018 23:35:44 +0000 (23:35 +0000)]
Implement std::pmr::synchronized_pool_resource
Define the thread-safe pool resource, using a shared_mutex to allow
multiple threads to concurrently allocate from thread-specific pools.
Define new weak symbols for the pthread_rwlock_t functions, to avoid
making libstdc++.so depend on libpthread.so
When the necessary Gthread support is absent only define the
feature-test macro to 1, rather than 201603. This is intended to imply
incomplete support, because everything except synchronized_pool_resource
works.
Implement std::pmr::synchronized_pool_resource
* config/abi/pre/gnu.ver: Add new symbols.
* include/std/memory_resource [_GLIBCXX_HAS_GTHREADS]
(__cpp_lib_memory_resource): Define to expected value, 201603.
(synchronized_pool_resource): New class.
[!_GLIBCXX_HAS_GTHREADS] (__cpp_lib_memory_resource): Define to 1.
* include/std/shared_mutex (__glibcxx_rwlock_rdlock)
(__glibcxx_rwlock_tryrdlock, __glibcxx_rwlock_wrlock)
(__glibcxx_rwlock_trywrlock, __glibcxx_rwlock_unlock)
(__glibcxx_rwlock_destroy, __glibcxx_rwlock_init)
(__glibcxx_rwlock_timedrdlock, __glibcxx_rwlock_timedwrlock): Define
weak symbols for POSIX rwlock functions.
(__shared_mutex_pthread): Use weak symbols.
* include/std/version (__cpp_lib_memory_resource): Define.
* src/c++17/memory_resource.cc [_GLIBCXX_HAS_GTHREADS]
(synchronized_pool_resource::_TPools): New class.
(destroy_TPools): New function for pthread_key_create destructor.
(synchronized_pool_resource::synchronized_pool_resource)
(synchronized_pool_resource::~synchronized_pool_resource)
(synchronized_pool_resource::release)
(synchronized_pool_resource::do_allocate)
(synchronized_pool_resource::do_deallocate): Define public members.
(synchronized_pool_resource::_M_thread_specific_pools)
(synchronized_pool_resource::_M_alloc_tpools)
(synchronized_pool_resource::_M_alloc_shared_tpools): Define private
members.
* testsuite/20_util/synchronized_pool_resource/allocate.cc: New test.
* testsuite/20_util/synchronized_pool_resource/cons.cc: New test.
* testsuite/20_util/synchronized_pool_resource/is_equal.cc: New test.
* testsuite/20_util/synchronized_pool_resource/multithreaded.cc: New
test.
* testsuite/20_util/synchronized_pool_resource/release.cc: New test.
* testsuite/performance/20_util/memory_resource/pools.cc: Add
multithreaded tests using pmr::synchronized_pool_resource.
From-SVN: r266242
Jim Wilson [Sat, 17 Nov 2018 23:31:01 +0000 (23:31 +0000)]
RISC-V: Fix epilogue unwind info with fp and single sp adjust.
gcc/
* config/riscv/riscv.c (epilogue_cfa_sp_offset): New.
(riscv_restore_reg): If restoring HARD_FRAME_POINTER_REGNUM, and
epilogue_cfa_sp_offset set, then add REG_CFA_DEF_CFA regnote.
(riscv_expand_epilogue): Initialize epilogue_cfa_sp_offset. Set it
to step2 if frame_pointer_needed and step1 is 0.
From-SVN: r266241
Sandra Loosemore [Sat, 17 Nov 2018 16:59:26 +0000 (11:59 -0500)]
re PR c++/4225 (documentation about CPLUS_INCLUDE_PATH vs. system headers incomplete)
2018-11-17 Sandra Loosemore <sandra@codesourcery.com>
PR c++/4225
gcc/
* doc/cpp.texi (System Headers): Add note about implicit
extern "C" block on targets that define SYSTEM_IMPLICIT_EXTERN_C.
From-SVN: r266240
Sandra Loosemore [Sat, 17 Nov 2018 16:05:45 +0000 (11:05 -0500)]
re PR c++/4025 (Document use/non-use of -fno-implicit-templates in bootflags)
2018-11-17 Sandra Loosemore <sandra@codesourcery.com>
PR c++/4025
gcc/
* doc/invoke.texi (C++ Dialect Options): Clarify usage of
-fno-implicit-templates.
From-SVN: r266239
Iain Buclaw [Sat, 17 Nov 2018 15:48:42 +0000 (15:48 +0000)]
libphobos: Add IEEE quadruple support for std.conv
Backport from upstream phobos 2.079 for AArch64.
Reviewed-on: https://github.com/dlang/phobos/pull/5965
From-SVN: r266238
Jakub Jelinek [Sat, 17 Nov 2018 15:10:48 +0000 (16:10 +0100)]
re PR tree-optimization/87546 (Gcc miscompiles at -O3 on valid code)
PR tree-optimization/87546
* tree-vect-patterns.c (vect_look_through_possible_promotion): Add
min_precision variable, initially set it to orig_precision, only does
something if op_type's precision is <= min_precision and update
min_precision whenever calling set_op.
* gcc.dg/vect/O3-pr87546.c: New test.
From-SVN: r266237
Jakub Jelinek [Sat, 17 Nov 2018 15:09:43 +0000 (16:09 +0100)]
re PR rtl-optimization/88018 (ICE in insert_insn_on_edge at cfgrtl.c:1952 since r255066)
PR rtl-optimization/88018
* cfgrtl.c (fixup_abnormal_edges): Guard moving insns to fallthru edge
on the presence of fallthru edge, rather than if it is a USE or not.
* g++.dg/tsan/pr88018.C: New test.
From-SVN: r266236
Jan Hubicka [Sat, 17 Nov 2018 11:35:01 +0000 (12:35 +0100)]
re PR ipa/87957 (ICE tree check: expected tree that contains ‘decl minimal’ structure, have ‘identifier_node’ in warn_odr, at ipa-devirt.c:1051 since r265519)
PR ipa/87957
* ipa-devirt.c (warn_odr): Look for main variant to get TYPE_DECL.
From-SVN: r266235
Iain Buclaw [Sat, 17 Nov 2018 11:01:00 +0000 (11:01 +0000)]
Fix wrong alignment returned by .alignof property.
The D language expects the value to be the minimum alignment required
for the type, not the preferred alignment.
gcc/d/ChangeLog:
2018-11-17 Iain Buclaw <ibuclaw@gdcproject.org>
PR d/87824
* d-target.cc (Target::alignsize): Return min_align_of_type.
From-SVN: r266234
Sandra Loosemore [Sat, 17 Nov 2018 04:52:29 +0000 (23:52 -0500)]
invoke.texi (Option Summary): Fix whitespace and line breaks in @gccoptlist environments.
2018-11-16 Sandra Loosemore <sandra@codesourcery.com>
gcc/
* doc/invoke.texi (Option Summary): Fix whitespace and line
breaks in @gccoptlist environments.
(Warning Options): Likewise.
(Optimize Options): Likewise.
(PowerPC SPE Options): Likewise.
(RS/6000 and PowerPC Options): Likewise.
From-SVN: r266233
Jeff Law [Sat, 17 Nov 2018 04:19:27 +0000 (21:19 -0700)]
mn10300.md (adddi3_degenerate): Remove bogus gcc_assert.
* config/mn10300/mn10300.md (adddi3_degenerate): Remove bogus
gcc_assert.
From-SVN: r266232
Sandra Loosemore [Sat, 17 Nov 2018 00:53:17 +0000 (19:53 -0500)]
re PR middle-end/23197 (Improve documentation on -fprofile-generate, -fprofile-use)
2018-11-16 Sandra Loosemore <sandra@codesourcery.com>
PR middle-end/23197
gcc/
* doc/invoke.texi (Optimize Options): Update options enabled by
fprofile-generate, -fprofile-use, and -fauto-profile.
From-SVN: r266231
Jozef Lawrynowicz [Sat, 17 Nov 2018 00:45:43 +0000 (00:45 +0000)]
re PR middle-end/87854 (gcc.c-torture/compile/pr46534.c ICE for 16-bit size_t)
2018-11-17 Jozef Lawrynowicz <jozef.l@mittosystems.com>
PR middle-end/87854
* g++.dg/parse/concat1.C: Add dg-error for targets with size_t < 32
bits. Update comment.
* gcc.dg/concat2.c: Likewise.
* gcc.c-torture/compile/pr46534.c: Likewise.
From-SVN: r266230
GCC Administrator [Sat, 17 Nov 2018 00:16:29 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266229
Jozef Lawrynowicz [Fri, 16 Nov 2018 23:53:30 +0000 (23:53 +0000)]
re PR target/87927 (ICE: segmentation fault with patchable_function_entry attribute for msp430-elf -mlarge)
2018-11-16 Jozef Lawrynowicz <jozef.l@mittosystems.com>
PR target/87927
* target-def.h: Initialize TARGET_ASM_{,UN}ALIGNED_P{S,D,T}I_OP.
Add them to the TARGET_ASM_{,UN}ALIGNED_INT_OP structs.
* target.def: Enumerate TARGET_ASM_{,UN}ALIGNED_P{S,D,T}I_OP in
the byte_op hook.
* target.h: Add psi, pdi, pti to struct asm_int_op definition.
* targhooks.c (default_print_patchable_function_entry): Assert
asm_int_op does not return a NULL string.
* varasm.c (integer_asm_op): Return the op for a partial int type
when the requested size does not correspond to an integer type.
* config/msp430/msp430.c: Initialize TARGET_ASM_{,UN}ALIGNED_PSI_OP.
* doc/tm.texi: Regenerate.
From-SVN: r266226
Jakub Jelinek [Fri, 16 Nov 2018 23:18:13 +0000 (00:18 +0100)]
re PR c++/87269 (ICE in tsubst_copy, at cp/pt.c:15475 starting from r261802)
PR c++/87269
* g++.dg/lookup/pr87269.C (std::size_t): New typedef.
(operator"" _a) Change unsigned long type to std::size_t.
From-SVN: r266225
Kamlesh Kumar [Fri, 16 Nov 2018 21:55:00 +0000 (21:55 +0000)]
re PR c++/52869 ([DR 1207] "this" not being allowed in noexcept clauses)
PR c++/52869
DR 1207
* parser.c (cp_parser_noexcept_specification_opt): Call
inject_this_parameter.
From-SVN: r266224
Jason Merrill [Fri, 16 Nov 2018 21:49:42 +0000 (16:49 -0500)]
Implement P0479R5, [[likely]] and [[unlikely]].
[[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
except that they can be applied to arbitrary statements as well as labels;
this is most likely to be useful for marking if/else branches as likely or
unlikely. Conveniently, PREDICT_EXPR fits the bill nicely as a
representation.
I also had to fix marking case labels as hot/cold, which didn't work before.
Which then required me to force __attribute ((fallthrough)) to apply to the
statement rather than the label.
gcc/
* gimplify.c (gimplify_case_label_expr): Handle hot/cold attributes.
gcc/c-family/
* c-lex.c (c_common_has_attribute): Handle likely/unlikely.
* c-attribs.c (attr_cold_hot_exclusions): Make public.
gcc/cp/
* tree.c (handle_likeliness_attribute): New.
(std_attribute_table): Add likely/unlikely.
* cp-gimplify.c (lookup_hotness_attribute, remove_hotness_attribute)
(process_stmt_hotness_attribute, first_stmt): New.
(genericize_if_stmt): Check for duplicate predictions.
* parser.c (cp_parser_statement): Call
process_stmt_hotness_attribute.
(cp_parser_label_for_labeled_statement): Apply attributes to case.
* decl.c (finish_case_label): Give label in template type void.
* pt.c (tsubst_expr) [CASE_LABEL_EXPR]: Copy attributes.
[PREDICT_EXPR]: Handle.
From-SVN: r266223
Iain Buclaw [Fri, 16 Nov 2018 21:17:33 +0000 (21:17 +0000)]
libphobos: Add IEEE quadruple support to core.internal.convert
Backport from upstream druntime 2.083 for AArch64.
Reviewed-on: https://github.com/dlang/druntime/pull/2257
From-SVN: r266222
Michael Meissner [Fri, 16 Nov 2018 20:18:13 +0000 (20:18 +0000)]
constraints.md (wF constraint): Remove power9 fusion documentation.
[gcc]
2018-11-16 Michael Meissner <meissner@linux.ibm.com>
* config/rs6000/constraints.md (wF constraint): Remove power9
fusion documentation. Just document wF's use for power8 fusion.
* config/rs6000/predicates.md (p9_fusion_reg_operand): Delete.
(fusion_gpr_addis): Delete power9 fusion support. Change power8
fusion support to require the upper 12 bits to be all 0's or all
1's.
(fusion_gpr_mem_load): Add comment.
(fusion_addis_mem_combo_load): Remove power9 fusion support.
(fusion_addis_mem_combo_store): Delete.
(fusion_offsettable_mem_operand): Delete.
* config/rs6000/rs6000-cpus.def (ISA_2_7_MASKS_SERVER): Do not set
power8 fusion here.
(ISA_3_0_MASKS_SERVER): Delete power9 fusion.
(POWERPC_MASKS): Delete power9 fusion.
* config/rs6000/rs6000-protos.h (emit_fusion_load_store): Delete.
(fusion_p9_p): Delete.
(expand_fusion_p9_load): Delete.
(expand_fusion_p9_store): Delete.
(emit_fusion_p9_load): Delete.
(emit_fusion_p9_store): Delete.
* config/rs6000/rs6000.c (rs6000_debug_reg_global): Delete power9
fusion support.
(rs6000_option_override_internal): Set power8 fusion based on
whether we are tuning for power8. Delete power9 fusion support.
(rs6000_opt_masks): Delete -mpower9-fusion switch.
(emit_fusion_load): Rename emit_fusion_load_store to
emit_fusion_load, and drop fusion store support. Update callers.
(emit_fusion_load_store): Likewise.
(emit_fusion_gpr_load): Likewise.
(fusion_p9_p): Delete.
(expand_fusion_p9_load): Delete.
(expand_fusion_p9_store): Delete.
(emit_fusion_p9_load): Delete.
(emit_fusion_p9_store): Delete.
* config/rs6000/rs6000.md (UNSPEC_FUSION_P9): Delete.
(GPR_FUSION): Delete.
(FPR_FUSION): Delete.
(power9 fusion peephole2s): Delete.
(fusion_gpr_<P:mode>_<GPR_FUSION:mode>_load): Delete.
(fusion_gpr_<P:mode>_<GPR_FUSION:mode>_store): Delete.
(fusion_vsx_<P:mode>_<FPR_FUSION:mode>_load): Delete.
(fusion_vsx_<P:mode>_<FPR_FUSION:mode>_store): Delete.
(fusion_p9_<mode>_constant): Delete.
* config/rs6000/rs6000.opt (-mpower9-fusion): Delete undocumented
power9 fusion switch.
* doc/md.texi (PowerPC constraints): Update wF constraint
documentation for power8 fusion only.
[gcc/testsuite]
2018-11-16 Michael Meissner <meissner@linux.ibm.com>
* gcc.target/powerpc/fusion3.c: Delete.
* gcc.target/powerpc/fusion4.c: Delete.
From-SVN: r266220
Jakub Jelinek [Fri, 16 Nov 2018 16:43:49 +0000 (17:43 +0100)]
re PR rtl-optimization/87475 (ICE in patch_jump_insn, at cfgrtl.c:1275)
PR rtl-optimization/87475
* cfgrtl.c (patch_jump_insn): Allow redirection failure for
CROSSING_JUMP_P insns.
(cfg_layout_redirect_edge_and_branch): Don't ICE if ret is NULL.
* g++.dg/opt/pr87475.C: New test.
From-SVN: r266219
Uros Bizjak [Fri, 16 Nov 2018 16:42:16 +0000 (17:42 +0100)]
re PR target/88051 (internal compiler error: in add_clobbers, at config/i386/sync.md:1762)
PR target/88051
* config/i386/i386.md (floatunsdidf2): Allow only 64bit AVX512F targets.
* config/i386/sse.md (UNSPEC_MOVDI_TO_SSE): New UNSPEC.
(movdi_to_sse): Rewrite using UNSPEC_MOVDI_TO_SSE unspec.
From-SVN: r266218
Jakub Jelinek [Fri, 16 Nov 2018 16:41:54 +0000 (17:41 +0100)]
re PR middle-end/87854 (gcc.c-torture/compile/pr46534.c ICE for 16-bit size_t)
PR middle-end/87854
* c-common.c (fix_string_type): Reject string literals larger than
TYPE_MAX_VALUE (ssizetype) bytes.
From-SVN: r266217
Jakub Jelinek [Fri, 16 Nov 2018 16:40:53 +0000 (17:40 +0100)]
re PR middle-end/88032 (ICE in operand_subword_force, at emit-rtl.c:1793)
PR middle-end/88032
* optabs.c (expand_binop): For op0_mode use GET_MODE (op0), unless it
is VOIDmode, in which case use int_mode. Similarly for op1_mode.
From-SVN: r266216
Matthew Malcomson [Fri, 16 Nov 2018 16:26:44 +0000 (16:26 +0000)]
When running the testsuite on boards that can't report an error status DejaGNU...
When running the testsuite on boards that can't report an error status
DejaGNU uses a special wrapper to print the exit code on stdout and
parses stdout to find whether an execution failed or passed.
In testcases that use "freopen (..., ..., stdout)" this special line is
printed to the alternate location described in the freopen call and
DejaGNU can't find the error code.
This results in DejaGNU using a default return status of 2 and the test
failing.
This patch skips the two testcases that use freopen on stdout when
testing a board that requires this wrapper.
Testing done by running these two tests on arm-none-eabi cross build and
observing that they are unsupported.
gcc/testsuite/ChangeLog:
2018-11-16 Matthew Malcomson <matthew.malcomson@arm.com>
* gcc.c-torture/execute/printf-2.c: Skip on wrapped boards.
* gcc.c-torture/execute/user-printf.c: Likewise.
From-SVN: r266214
Eric Botcazou [Fri, 16 Nov 2018 16:25:12 +0000 (16:25 +0000)]
tree-switch-conversion.h (switch_decision_tree::emit_case_nodes): Add location_t parameter.
* tree-switch-conversion.h (switch_decision_tree::emit_case_nodes): Add
location_t parameter.
(switch_decision_tree::emit_cmp_and_jump_insns): Likewise.
(switch_decision_tree::do_jump_if_equal): Likewise.
* tree-switch-conversion.c (switch_decision_tree::emit): Pass location
of switch statement to emit_case_nodes.
(switch_decision_tree::emit_cmp_and_jump_insns): Add LOC parameter and
set it on the newly built GIMPLE comparison statement.
(switch_decision_tree::do_jump_if_equal): Likewise.
(switch_decision_tree::emit_case_nodes): Add LOC parameter and pass it
in calls to do_jump_if_equal as well as recursive calls.
From-SVN: r266213
Nathan Sidwell [Fri, 16 Nov 2018 16:23:20 +0000 (16:23 +0000)]
Remove ovl_used, it is no longer needed
Remove ovl_used, it is no longer needed
* cp-tree.h (OVL_USED_P): Delete.
(lookup_keep): Delete.
* friend.c (add_friend): Don't call it.
* parser.c (lookup_literal_operator): Likewise.
(cp_parser_primary_expression): Likewise.
* semantics.c (perform_koenig_lookup): Likewise.
* pt.c (tsubst_copy <OVERLOAD>): Don't assert OVL_USED_P.
* tree.c (ovl_copy): Delete.
(ovl_insert): Remove OVL_USED_P checks.
(ovl_iterator::reveal_node): Likewise.
(ovl_iterator::remove__node): Likewise.
(ovl_used, lookup_keep): Delete.
From-SVN: r266212
Andi Kleen [Fri, 16 Nov 2018 15:46:31 +0000 (15:46 +0000)]
Allow memory operands for PTWRITE
The earlier PTWRITE builtin definition was unnecessarily restrictive,
only allowing register input to PTWRITE. The instruction actually
supports memory operands too, so allow that too.
gcc/:
2018-11-16 Andi Kleen <ak@linux.intel.com>
* config/i386/i386.md: Allow memory operands to ptwrite.
From-SVN: r266211
Nathan Sidwell [Fri, 16 Nov 2018 15:01:55 +0000 (15:01 +0000)]
[PR c++/87269] Mark string operator overload in template defn.
https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01458.html
PR c++/87269
* parser.c (lookup_literal_operator): Mark overload for keeping
when inside template. Refactor.
* g++.dg/lookup/pr87269.C: New.
From-SVN: r266210
Renlin Li [Fri, 16 Nov 2018 14:36:40 +0000 (14:36 +0000)]
[Patch][libstdc++.exp] Update the usage of cached result.
This patch replaces the usage of cached results with a global dictionary.
Additionally, check_v3_target_namedlocale is updated to check on every variant.
Originally, it is only checked once.
gcc/libstdc++-v3/:
2018-11-16 Renlin Li <renlin.li@arm.com>
Tejas Belagod <tejas.belagod@arm.com>
testsuite/lib/libstdc++.exp (check_v3_target_prop_cached): New proc.
(check_v3_target): Use check_v3_target_prop_cached.
Co-Authored-By: Tejas Belagod <tejas.belagod@arm.com>
From-SVN: r266209
Michael Matz [Fri, 16 Nov 2018 13:39:18 +0000 (13:39 +0000)]
Don't use %z printf length specifier
* system.h (PRsa): New macro.
(SIZE_AMOUNT): Cast number to uint64_t.
* alloc-pool.h (pool_usage::dump): Don't use %zu but PRsa.
(pool_usage::dump_footer): Likewise and also use PRIu64.
* bitmap.h (bitmap_usage::dump): Likewise.
* ggc-common.c (ggc_usage::dump): Likewise.
* ggc-page.c (ggc_print_statistics): Likewise.
* input.c (dump_line_table_statistics): Likewise.
* mem-stats.h (mem_usage::dump): Likewise.
(mem_usage::dump_footer): Likewise.
* rtl.c (dump_rtx_statistics): Likewise.
* tree-cfg.c (dump_cfg_stats): Likewise.
* tree-dfa.c (dump_dfa_stats): Likewise.
* tree-phinodes.c (phinodes_print_statistics): Likewise.
* tree-ssanames (ssanames_print_statistics): Likewise.
* vec.c (vec_usage::dump): Likewise.
(vec_usage::dump_footer): Likewise.
From-SVN: r266208
Martin Liska [Fri, 16 Nov 2018 12:49:32 +0000 (13:49 +0100)]
Fix ICE in lto_symtab_merge_symbols_1 (PR lto/88004).
2018-11-16 Martin Liska <mliska@suse.cz>
PR lto/88004
* lto-symtab.c (lto_symtab_merge_symbols_1): Do not call
lto_symtab_symbol_p as it does checking of transparent alias.
These needs to be also merged in the function.
From-SVN: r266207
Richard Biener [Fri, 16 Nov 2018 12:22:48 +0000 (12:22 +0000)]
re PR testsuite/88053 (g++.dg/lto/pr54625-1.C fails with r266194)
2018-11-16 Richard Biener <rguenther@suse.de>
PR testsuite/88053
* g++.dg/lto/pr54625-2_0.c: Add -w.
From-SVN: r266206
Richard Biener [Fri, 16 Nov 2018 12:20:05 +0000 (12:20 +0000)]
re PR tree-optimization/88011 (r266028 causes a bunch of go failures)
2018-11-16 Richard Biener <rguenther@suse.de>
PR tree-optimization/88011
* tree-vrp.c (extract_range_from_binary_expr): Fix error in
replacing set_value_range_to_undefined and
set_value_range_to_varying with method calls.
From-SVN: r266205
Ilya Leoshkevich [Fri, 16 Nov 2018 11:47:47 +0000 (11:47 +0000)]
S/390: Add a new pattern for r{o,x}sbg
Fixes rXsbg_mode_sXl test failures.
Combine used to give us
(set (reg:SI 65)
(ior:SI (lshiftrt:SI (reg:SI 3 %r3 [ bD.2238 ])
(const_int 2 [0x2]))
(reg:SI 2 %r2 [ aD.2237 ])))
but now we get
(set (reg:SI 65)
(ior:SI (subreg:SI (zero_extract:DI (reg:DI 69)
(const_int 32 [0x20])
(const_int 30 [0x1e])) 4)
(subreg:SI (reg:DI 68) 4)))
or
(set (reg:SI 65)
(ior:SI (subreg:SI (and:DI (lshiftrt:DI (reg:DI 69)
(const_int 2 [0x2]))
(const_int
4294967295 [0xffffffff])) 4)
(subreg:SI (reg:DI 68) 4)))
with an extra subreg, which appears because pseudos, unlike hard
registers, can be accessed only using their natural mode.
This patch adds a special case for that. Also, it performs r*sbg
bit index computations during gcc run, so that expectations do not
depend on which concrete pattern was matched.
gcc/ChangeLog:
2018-11-16 Ilya Leoshkevich <iii@linux.ibm.com>
* config/s390/s390.md
(*r<noxa>sbg_<mode>_srl_bitmask): Do not delegate arithmetic to
assembler.
(*r<noxa>sbg_<mode>_sll): Likewise.
(*r<noxa>sbg_<mode>_srl): Likewise.
(*r<noxa>sbg_sidi_srl): New pattern.
gcc/testsuite/ChangeLog:
2018-11-16 Ilya Leoshkevich <iii@linux.ibm.com>
* gcc.target/s390/md/rXsbg_mode_sXl.c: Do not use arithmetic in
r{o,x}sbg expectations.
* gcc.target/s390/risbg-ll-2.c: Likewise.
From-SVN: r266203
Richard Biener [Fri, 16 Nov 2018 09:27:36 +0000 (09:27 +0000)]
re PR testsuite/88053 (g++.dg/lto/pr54625-1.C fails with r266194)
2018-11-16 Richard Biener <rguenther@suse.de>
PR testsuite/88053
* g++.dg/lto/pr54625-1_0.c: Add -w.
From-SVN: r266202
Jerome Lambourg [Fri, 16 Nov 2018 09:23:22 +0000 (09:23 +0000)]
Allow target overrides of ctors/dtors support advertisement on VxWorks
2018-11-16 Jerome Lambourg <lambourg@adacore.com>
* config/vxworks.h (TARGET_VXWORKS_HAVE_CTORS_DTORS): New macro.
Default to TARGET_VXWORKS_RTP.
(SUPPORTS_INIT_PRIORITY): Use TARGET_VXWORKS_HAVE_CTORS_DTORS instead
of TARGET_VXWORKS_RTP.
* config/vxworksae.h: Also define TARGET_VXWORKS_HAVE_CTORS_DTORS.
* config/vxworks.c: Use TARGET_VXWORKS_HAVE_CTORS_DTORS instead
of TARGET_VXWORKS_RTP to set targetm.have_ctors_dtors.
From-SVN: r266201
Xianmiao Qu [Fri, 16 Nov 2018 01:26:04 +0000 (01:26 +0000)]
linux-unwind.h (sc_pt_regs): Update for kernel.
2018-11-15 Xianmiao Qu <xianmiao_qu@c-sky.com>
libgcc/
* config/csky/linux-unwind.h (sc_pt_regs): Update for kernel.
(sc_pt_regs_lr): Update for kernel.
(sc_pt_regs_tls): Update for kernel.
From-SVN: r266200
Sandra Loosemore [Fri, 16 Nov 2018 00:50:41 +0000 (19:50 -0500)]
re PR c++/25759 (Documentation not clear, attribute packed on class in C++)
2018-11-15 Sandra Loosemore <sandra@codesourcery.com>
PR c++/25759
gcc/
* doc/extend.texi (Common Type Attributes): Make it explicit
that attribute "packed" can apply to C++ classes.
From-SVN: r266199
GCC Administrator [Fri, 16 Nov 2018 00:16:34 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266198
projects / platform / upstream / gcc.git / log