Andrew Au [Fri, 4 Aug 2023 22:53:05 +0000 (15:53 -0700)]
Make sure all new GCDacVars are reported only for v2 (#90043)
Tom McDonald [Fri, 4 Aug 2023 22:42:51 +0000 (18:42 -0400)]
Delete dangling thread session states (#89955)
* Delete dangling thread session states
Co-Authored-By: Johan Lorensson <lateralusx.github@gmail.com>
* Update ep-session.c
---------
Co-authored-by: David Mason <davmason@microsoft.com>
Co-authored-by: Johan Lorensson <lateralusx.github@gmail.com>
Tarek Mahmoud Sayed [Fri, 4 Aug 2023 22:27:20 +0000 (15:27 -0700)]
Introducing TimeZoneInfo.GetSystemTimeZones(bool skipSorting) (#89985)
Anton Firszov [Fri, 4 Aug 2023 22:03:01 +0000 (00:03 +0200)]
Improve reliability of HttpRequestError.NameResolutionError (#89948)
* map TryAgain to NameResolutionError
* Quic: always resolve DNS in managed code
* oops
* ignore ScopId when comparing ipv6 endpoints in tests
* do not reuse QuicAddr
* Skip NameResolutionError() test on Windows7
Miha Zupan [Fri, 4 Aug 2023 21:52:04 +0000 (23:52 +0200)]
Fix HttpListener path parsing for trailing % (#90028)
Jakob Botsch Nielsen [Fri, 4 Aug 2023 21:42:50 +0000 (23:42 +0200)]
SPMI: Restore CORINFO_CALL_INFO stub lookup correctly (#90016)
SPMI was not restoring the runtimeLookupFlags/runtimeLookupArgs of the
embedded CORINFO_LOOKUP_KIND, leaving them set to garbage. This would
cause misses when replaying getReadyToRunHelper where those members are
used as the key.
Mark Plesko [Fri, 4 Aug 2023 21:32:52 +0000 (14:32 -0700)]
Revert "Disable MonitoringIsEnabled with issue 75302 (#75306)" (#89966)
Appears to have been fixed by #74959
Fixes #75302
This reverts commit
a174882750130433b03afcf8ac30318c2fbc527f
Ankit Jain [Fri, 4 Aug 2023 21:21:07 +0000 (17:21 -0400)]
[wasm] CI: Don't trigger non-wasm runtime tests when wasm-test-runner (#89957)
.. changes. There is a separate subset `wasm_runtimetests` for
triggering wasm runtime tests. So, `runtimetests` subset used by
non-wasm jobs should ignore wasm-test-runner changes.
Ilona Tomkowicz [Fri, 4 Aug 2023 21:18:47 +0000 (23:18 +0200)]
[wasm][wbt] Split WBT classes to speed up CI job execution. (#89926)
IcuSharding and BuildPublish on Blazor always take the longest. I split them more or less into equal test count per class (~20 in icu, ~10 in build publish).
This PR changes the times on wbt linux CI when we split into BuldPublish and BuildPublishDefaultTemplate:
Build time: ~1,5min -> ~1,5min
Run time: ~53min -> ~45min
Original time values taken from build [
20230802.154](https://dev.azure.com/dnceng-public/public/_build/results?buildId=361726) with 495 301 tests.
It's fine but the BuildPublish is the only test that keeps running till the end, around 30th minute all the other wbt are done already, so trying the 3-file split approach:
- BuildPublishTestsFromWasmTemplate,
- BuildPublishTestsFromBlazorTemplate (the same test set as BuildPublishDefaultTemplate, just renamed to better describe the contents) and
- BuildPublish,
each <10 tests.
Build time: ~1,5min -> ~1,5min
Run time: ~53min -> 53 min - it seems 3 files split did not work as expected, @radical, it might be an outliner ~~but in this situation it does not look worthy to merge the changes~~.
[build
20230804.3](https://dev.azure.com/dnceng-public/public/_build/results?buildId=363212&view=logs&jobId=
9c08ee28-c5cd-54b8-6ae3-
9fcb797291cc&j=
0b2e5ab0-105d-5e21-8497-
262338385634)
Okay, on the re-run it's already fine, [35 min as expected](https://dev.azure.com/dnceng-public/public/_build/results?buildId=363553&view=logs&jobId=
10714551-d8dc-5291-8d0a-
07fdfc20529c&j=
1fa93050-f528-55d3-a351-
f8bf9ce5adbf&t=
a9f1a437-3b59-5900-1137-
ec6cae9a530c).
On windows it changed ~60min -> 42 min.
Elinor Fung [Fri, 4 Aug 2023 18:48:56 +0000 (11:48 -0700)]
Use the same tracked contexts for event pipe and ETW in nativeaot (#89902)
- Make tracking for event pipe and ETW enabled/status use the same contexts
- Switch to using the .NET ETW provider GUIDs instead of .NET Native
- Implement ep_rt_providers_validate_all_disabled (uses the contexts)
Stephen Toub [Fri, 4 Aug 2023 18:17:04 +0000 (14:17 -0400)]
Avoid extra console write for clearing on Unix (#89026)
* Avoid extra console write for clearing on Unix
* Fix ordering from original PR
* Add test that the data we defined is expected
Koundinya Veluri [Fri, 4 Aug 2023 17:53:11 +0000 (10:53 -0700)]
Update the event used for the tiered compilation background thread (#89972)
Updated the event to use `ClrEventStatic` instead of `ClrEvent`, as the former is intended for global variables and does not have a destructor. There may be a possibility for races with the destructor in shutdown scenarios.
Fixes https://github.com/dotnet/runtime/issues/89749
Tomas Weinfurt [Fri, 4 Aug 2023 17:38:29 +0000 (10:38 -0700)]
use approved SocketAddress API instead of direct internal access (#89841)
* use approved SocketAddress API instead of internal access
* feedback
* cleanup
Egor Bogatov [Fri, 4 Aug 2023 16:09:20 +0000 (18:09 +0200)]
Fix PermuteVar32x16x2 optimization (#90005)
Steve Pfister [Fri, 4 Aug 2023 16:01:04 +0000 (09:01 -0700)]
[workloads] Use native arm64 aot compilers for iOS, tvOS, maccatalyst, and android where possible (#89961)
As a result of https://github.com/dotnet/runtime/pull/89027 and https://github.com/dotnet/runtime/pull/74715, we can now build native arm64 cross compilers on linux and macos. This change adds the right references to the workload manifest so that they can be installed with maui and the mobile SDK's.
win-arm64 is the only arm64 platform left and that is a work in progress.
Contributes to https://github.com/dotnet/runtime/issues/82495
Fixes https://github.com/dotnet/maui/issues/4476
Thays Grazia [Fri, 4 Aug 2023 15:01:44 +0000 (12:01 -0300)]
Rework on 88919 as suggested by @vitek-karas (#89960)
Pavel Savara [Fri, 4 Aug 2023 14:44:27 +0000 (16:44 +0200)]
[browser] doc feedback (#89951)
Steve Harter [Fri, 4 Aug 2023 14:28:06 +0000 (09:28 -0500)]
Add test for TypeIdentifierAttribute (#89882)
Filip Navara [Fri, 4 Aug 2023 13:41:50 +0000 (15:41 +0200)]
Match IsUnwindable and GetReturnAddressHijackInfo conditions (#89998)
Jan Kotas [Fri, 4 Aug 2023 13:15:47 +0000 (06:15 -0700)]
Revert "For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory (#89573)" (#89992)
This reverts commit
c41696644436d6ba8d7bc6f06b20273d99d8dc70.
Milos Kotlar [Fri, 4 Aug 2023 13:11:20 +0000 (15:11 +0200)]
[mono][ios] Disable failing eventpipe gcdump test on apple mobile platforms (#90002)
* Disable failing eventpipe test on apple mobile platforms
* Add tracking issue
Jan Kotas [Fri, 4 Aug 2023 12:36:56 +0000 (05:36 -0700)]
Light up for newer arm64 hardware capabilities (#89991)
Fixes #89937
Milos Kotlar [Fri, 4 Aug 2023 11:44:05 +0000 (13:44 +0200)]
[nativeaot][ios] Improve Native AOT test coverage on apple mobile platforms (#89301)
* Enable TestLinqExpressions test
* Test maccatalyst job on Native AOT
* Test other smoke runtime tests on Native AOT
* Add tracking issue for disabled tests
Viktor Hofer [Fri, 4 Aug 2023 10:42:53 +0000 (12:42 +0200)]
Move Microsoft.NET.WebAssembly.WebCil into tasks (#89999)
Fixes https://github.com/dotnet/runtime/issues/89987
Repo task projects need to reside under src/tasks as the
TasksConfiguration property applies to these projects. By having a
referenced task project outside of src/tasks, it's easy to get
binclashes because of a project being built for different configurations
(Debug vs Release).
Drew Scoggins [Fri, 4 Aug 2023 09:35:11 +0000 (02:35 -0700)]
Roll Ubuntu 18.04 queue to 22.04 (#89995)
Eric StJohn [Fri, 4 Aug 2023 06:49:30 +0000 (23:49 -0700)]
Exclude NETFramework targets file during source build (#89974)
Jan Kotas [Fri, 4 Aug 2023 05:50:54 +0000 (22:50 -0700)]
Make ImplementsInterfaceOfSelf more precise for canonical subtypes (#89969)
Fixes #89918
Jackson Schuster [Fri, 4 Aug 2023 04:08:23 +0000 (21:08 -0700)]
Make marshaller types specific to each scenario (#89894)
Make the marshaller types for the test interfaces only include the necessary methods for each scenario to catch any generated code that uses a method from another scenario
Larry Ewing [Fri, 4 Aug 2023 03:58:04 +0000 (22:58 -0500)]
Try Vector128 before Vector (#89797)
Michal Strehovský [Fri, 4 Aug 2023 03:35:57 +0000 (12:35 +0900)]
Fix trimming issue in the cpuid test (#89989)
Jackson Schuster [Fri, 4 Aug 2023 03:21:24 +0000 (20:21 -0700)]
Add diagnostic when the size of an array that is marshalled to the callee is an 'out' parameter. (#89827)
Jackson Schuster [Fri, 4 Aug 2023 03:18:35 +0000 (20:18 -0700)]
Move ThrowForHR to start of NotifyForSuccessFulInvoke (#89970)
Michal Strehovský [Fri, 4 Aug 2023 03:13:21 +0000 (12:13 +0900)]
Don't generate symbols if user doesn't want them (#89840)
This has two changes:
* Stop looking at `DebugSymbols` property. It doesn't look like the SDK actually looks at this (anymore?) either. Setting this to false still produces managed symbols. The only thing that works is setting `DebugType`.
* Don't generate DBG file if debugging symbols are not generated. The user expectation when debugging symbols are disabled is that they don't get the extra file on disk. The DBG file would still have debug information for the native runtime. We may or may not run objcopy to strip symbols.
I considered also running objcopy when StripSymbols is set to false but DebugType is set to none like we discussed in #88780 but maybe that goes too far - I'd expect users would only set StripSymbols to a non-default value in case they e.g. don't want to install objcopy and we'd need yet another property to say "no really don't run objcopy". So I made this orthogonal to that.
Miha Zupan [Fri, 4 Aug 2023 02:22:50 +0000 (04:22 +0200)]
Prefer vectorized ProbabilisticMap over Latin1CharSearchValues (#89981)
Anton Firszov [Thu, 3 Aug 2023 23:36:41 +0000 (01:36 +0200)]
forward innerException's error code to retryable HttpRequestException (#89963)
If we are doing a retry because of a protocol error, or some other HttpIOException, we should forward the error code to the retryable HttpRequestException
Anton Firszov [Thu, 3 Aug 2023 23:33:07 +0000 (01:33 +0200)]
[HTTP Metrics] Shorter version tags (#89959)
Addressing https://github.com/dotnet/runtime/pull/89809#discussion_r1283541867
Ankit Jain [Thu, 3 Aug 2023 22:49:59 +0000 (18:49 -0400)]
[wasm] WBT: Use project ids that are safe for use as identifiers (#89945)
* [wasm] WBT: Use project ids that are safe for use as identifiers
For every test project, a random id is used which is
`Path.GetRandomFileName()`. In some cases this `id` gets used in a
generated C/C# source file, and that can cause failures.
For example the following fails with:
```
blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,48): error CS1001: Identifier expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj]
blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,48): error CS1002: ; expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj]
blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,51): error CS1031: Type expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj]
```
because the id, `blz_checkfingerprinting_Release_zqkzgkui.ref`, was used
as a namespace (line 3).
```
using Microsoft.AspNetCore.Components.Web;
using Microsoft.AspNetCore.Components.WebAssembly.Hosting;
using blz_checkfingerprinting_Release_zqkzgkui.ref;
```
Fix up the generated random ids to make them safer. The code is taken
from `WasmAppBuilder/ManagedToNativeGenerator.cs`.
Fixes https://github.com/dotnet/runtime/issues/86533 .
* Apply the same for wasi
Ankit Jain [Thu, 3 Aug 2023 22:49:19 +0000 (18:49 -0400)]
[wasm] Remove hardcoded references to `net8.0` from WasmApp*targets (#89699)
Look for `System.Runtime.dll` to find the runtime pack directory with the assemblies, so we don't need to figure out the tfm for the path.
- Cannot use `System.Private.CoreLib.dll` because that is in `native/` instead of `lib/net8.0`
- Cannot use `RuntimePackAsset` because in many places that item isn't available.
- AOT on helix where we run only the wasm targets on the proxy project.
- Runtime tests which currently dump all the assemblies, and other bits into a single directory, not following the directory structure of a runtime pack. This also means the `RuntimePackAsset` cannot easily be synthesized.
With lots of feedback from @viktorhofer
Fixes https://github.com/dotnet/runtime/issues/79109 .
Andrew Au [Thu, 3 Aug 2023 22:39:57 +0000 (15:39 -0700)]
Dynamic events (#89371)
Sven Boemer [Thu, 3 Aug 2023 22:20:16 +0000 (15:20 -0700)]
Fix build race condition in ILLink.Tasks (#89949)
Avoid copying props/targets to the same output
location for different TFMs. Instead copy them to
the build output in a TFM-specific directory, and
import the targets from that directory when needed.
Manish Godse [Thu, 3 Aug 2023 21:56:33 +0000 (14:56 -0700)]
Remove Runtime composite package from being built. (#89946)
* Remove Runtime composite package from being built.
* delete now unused projects.
Hamish Arblaster [Thu, 3 Aug 2023 21:44:07 +0000 (07:44 +1000)]
Fix `LocalBuilder.IsPinned` always returning `false` on CoreCLR runtime (#89411)
Huo Yaoyuan [Thu, 3 Aug 2023 21:28:25 +0000 (05:28 +0800)]
Hide GetTypeInfo
Michal Strehovský [Thu, 3 Aug 2023 21:19:25 +0000 (06:19 +0900)]
Split off system libraries into a separate ItemGroup (#89916)
Should help with https://github.com/dotnet/runtime/pull/88294#issuecomment-
1663268829.
Jackson Schuster [Thu, 3 Aug 2023 20:19:56 +0000 (13:19 -0700)]
Expect ThrowForHR to throw Exception on nativeAOT (#89939)
Alexander Köplinger [Thu, 3 Aug 2023 19:35:59 +0000 (21:35 +0200)]
Disable objc_msgSend stubs in clang (#89932)
Applies the same fix as https://github.com/xamarin/xamarin-macios/pull/16231.
We recently started seeing the same issue in our runtime builds, see https://github.com/dotnet/runtime/issues/89925. This is because the AzDO build machines use Xcode 14 now but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails.
This happens in e.g. libSystem.Native.a or libSystem.Globalization.Native.a (the two libraries where we're using Objective-C).
Fixes https://github.com/dotnet/runtime/issues/89925
Jeremy Kuhne [Thu, 3 Aug 2023 19:22:53 +0000 (12:22 -0700)]
Pass through ComWrappers based objects to COM type descriptor (#89887)
WinForms hosts the the COM type descriptor. It has been updated to work with ComWrappers based objects- adding the check for them in TypeDescriptor.
There are hard dependencies on Windows in the current implementation. We can potentially update to conditionalize these. https://github.com/dotnet/winforms/issues/9291 tracks.
There is no automated test as it would require adding a dependency upstream to WinForms.
Anton Firszov [Thu, 3 Aug 2023 19:02:33 +0000 (21:02 +0200)]
Adjust DNS metrics (#89813)
Adjust DNS metrics according to https://github.com/lmolkova/semantic-conventions/blob/dotnet8-metrics/docs/dotnet/dotnet-dns-metrics.md
Jeremy Koritzinsky [Thu, 3 Aug 2023 18:50:08 +0000 (11:50 -0700)]
Add the interop tags to the "add to the AppModel project" automation (#89221)
Jan Vorlicek [Thu, 3 Aug 2023 18:36:16 +0000 (20:36 +0200)]
Fix isIPAdjusted setting during exception handling (#89930)
* Fix isIPAdjusted setting during exception handling
The CrawlFrame::isIPAdjusted flag is set to true for all frames
when handling software exceptions. That is not correct, as the IP is not
adjusted in those cases.
I've also cleaned up the values the flag is set to at various places to
use the real type of the member, which is `bool`. It was being set to
TRUE / FALSE or even 0 / 1 at some places.
As a related cleanup, I've removed the FRAME_ATTR_OUT_OF_LINE flag as it
was never set anywhere and still was being tested at few places.
* Add regression test
Tomas Weinfurt [Thu, 3 Aug 2023 18:13:59 +0000 (11:13 -0700)]
preserve TargetHostName even if we do not send it out via SNI (#89289)
* preserve TargetHostName even if we do not send it out via SNI
* Update src/libraries/System.Net.Security/src/System/Net/Security/Pal.OSX/SafeDeleteSslContext.cs
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
* quic
* test
---------
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Parker Bibus [Thu, 3 Aug 2023 17:40:54 +0000 (10:40 -0700)]
Remove any triggers. (#89947)
Eirik Tsarpalis [Thu, 3 Aug 2023 17:07:32 +0000 (20:07 +0300)]
Fix race condition in JsonSerializerOptions initialization. (#89935)
Anton Firszov [Thu, 3 Aug 2023 17:06:55 +0000 (19:06 +0200)]
Adjust System.Net.Http metrics (#89809)
Adjust System.Net.Http metrics naming and semantics according to the outcome of the discussion in lmolkova/semantic-conventions#1
dotnet-maestro[bot] [Thu, 3 Aug 2023 17:04:55 +0000 (19:04 +0200)]
[main] Update dependencies from dotnet/source-build-reference-packages dotnet/arcade dotnet/emsdk (#89858)
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230731.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23266.3 -> To Version 8.0.0-alpha.1.23381.3
* Update SourceBuildPrebuiltBaseline.xml
* Update dependencies from https://github.com/dotnet/arcade build
20230802.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23401.3 -> To Version 8.0.0-beta.23402.2
* Update dependencies from https://github.com/dotnet/emsdk build
20230802.3
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23401.2 -> To Version 8.0.0-rc.1.23402.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Michal Strehovský [Thu, 3 Aug 2023 16:40:02 +0000 (01:40 +0900)]
Trigger a rebuild if ILC command line changes (#89911)
Incremental build wouldn't consider things like `OptimizationPreference` property changing as a thing that should trigger a rebuild. I feel like this is more a MSBuild bug, but it has been like this for a long time.
Turns out we can use `WriteIlcRspFileForCompilation` target as a sentinel:
* Run the target always. We only actually write out the file if it's different (`WriteOnlyWhenDifferent` is already set to `true`).
* ILC execution already specifies the RSP as one of its inputs. So if the RSP is more recent than the output, it will trigger a build.
Fixes #88725.
Pavel Savara [Thu, 3 Aug 2023 16:04:57 +0000 (18:04 +0200)]
[browser] high level documentation of WASM features (#89469)
Co-authored-by: Katelyn Gadd <kg@luminance.org>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
dotnet-maestro[bot] [Thu, 3 Aug 2023 15:39:22 +0000 (10:39 -0500)]
[main] Update dependencies from dotnet/roslyn (#89903)
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23402.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23402.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23403.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ankit Jain [Thu, 3 Aug 2023 15:32:07 +0000 (11:32 -0400)]
[wasm] WBT: Fix up AppTest tests to fix missed testing cases (#89833)
* [wasm] Update WBT AppTests to use the common infrastructure for building, and running apps
* [wasm] WasmApp.targets - add $(WasmAssemblyExtension)
* AppTests should respect UseWebcil
* Fix tests to work for no-webcil case
Tomas Weinfurt [Thu, 3 Aug 2023 14:53:17 +0000 (07:53 -0700)]
fix Accept assert (#89901)
Filip Navara [Thu, 3 Aug 2023 14:50:32 +0000 (16:50 +0200)]
[NativeAOT] macOS/iOS: Emit simple compact unwinding information (#88724)
* Generate compact unwind sequence for methods with frame and no saved registers
* Store prolog length in LSDA data when compact unwinding is used
* Remove prolog length, detect prologs from instruction stream
* Update comments
Matt Mitchell [Thu, 3 Aug 2023 14:00:30 +0000 (07:00 -0700)]
Tie llvm to emsdk's version (#89865)
* Tie llvm to emsdk's version
This avoids incoherency that will cause the .NET build drop to be too large to fit on the staging pipeline disk.
* Update to latest emsdk flow
---------
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Milena Hristova [Thu, 3 Aug 2023 13:41:35 +0000 (15:41 +0200)]
Remove duplicated argument (#89912)
Alexander Köplinger [Thu, 3 Aug 2023 13:25:55 +0000 (15:25 +0200)]
Disable failing outerloop tests and fix a build issue in MonoAOTCompiler (#89922)
See https://github.com/dotnet/runtime/issues/89921 for the test failures.
Additionally, the Android build was failing while compiling an AOT test due to this error:
```
/__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes]
void register_aot_modules ()
^
```
This is because we turned on `-Werror=missing-prototypes` in https://github.com/dotnet/runtime/pull/89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c
Fixes https://github.com/dotnet/runtime/issues/89566
Layomi Akinrinade [Thu, 3 Aug 2023 13:03:49 +0000 (06:03 -0700)]
Fix binder gen nullability issue wrt binding ref type members (#89900)
Steve Harter [Thu, 3 Aug 2023 12:31:31 +0000 (07:31 -0500)]
For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory (#89573)
Johan Lorensson [Thu, 3 Aug 2023 11:06:22 +0000 (13:06 +0200)]
[Mono] Fix deadlock during gcdump when using interp full AOT fallback. (#89726)
GC thread doing gcdump will dump the EventPipe events after world
has restarted but before releasing GC lock. There was one case
where we logged a bulk type during that face where a type didn't
have its finalizer data initialized and at the same time main thread
running interpreter held loader lock and tried to acquire GC lock,
that triggers a deadlock since the GC thread (still holding the GC lock)
would trigger logic to initialize the finalizer data, but that in turn
requires the GC lock.
Fix delays the fire of GC dump events until after we completed GC.
All GC dump events have been cached into a temp file and will be
written into EventPipe, the only potential issue with this is that
we keep vtable pointers in cache that will be resolved when emitting
EventPipe event, after releasing GC lock, but since we currently
won't unload vtables, that is not an issue, but needs to be addressed
if/when we implement ability to unload vtables. We would then need
to root the vtables while stored in temporary cache.
Commit also enable GC dump test on Mono platforms.
Jan Vorlicek [Thu, 3 Aug 2023 07:53:20 +0000 (09:53 +0200)]
Fix handling ThreadAbortException at the end of catch (#89781)
* Fix handling ThreadAbortException at the end of catch
After the catch handler for ThreadAbortException exits, the
exception needs to be rethrown immediatelly. This change
makes that work.
* arm64 stuff
* Enable arm
* Fix macOS x64 and enable one ControlledExecutionTest path for Unix
* Update src/coreclr/vm/amd64/redirectedhandledjitcase.S
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
* Fix macOS x64
The non-local label was preventing unwinding through \stub\()_RspAligned
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Jan Vorlicek [Thu, 3 Aug 2023 07:42:20 +0000 (09:42 +0200)]
Fix IsFixupPrecodeByASM and StubPrecode::IsStubPrecodeByASM (#89899)
These functions use memcmp that can internally be optimized
by vectorization. It can thus read more bytes than necessary
for the purpose of this function. In edge cases it can end up
reading from unmapped memory and crashing with access violation.
The fix is to compare the data byte by byte and early out as soon
as a mismatch is found.
Johan Lorensson [Thu, 3 Aug 2023 07:25:34 +0000 (09:25 +0200)]
Specify callback calling convention for callbacks on Windows x86 causes crashes on Mono. (#89571)
Fixes #88992. Explicit specify callback calling convention on Windows x86.
CoreCLR runtime build uses stdcall while Mono uses cdecl (default). If a native runtime function takes a reverse pivnoke callback, this difference will cause issues for Mono on Windows x86 since reverse pinvoke callbacks have stdcall on Windows x86, but callbacks have been prototyped to use the calling convention setup in build.
Since CoreCLR already uses stdcall on Windows x86 this change won't change anything, while on Mono it will fixes the crashes observed in #8892.
Levi Broderick [Thu, 3 Aug 2023 06:38:13 +0000 (23:38 -0700)]
Improve zlib defenses on mono (#89898)
- Mono defines HOST_WIN32, not CLR_CMAKE_HOST_WIN32
- Follow same pattern from src\native\eventpipe\CMakeLists.txt
Parker Bibus [Thu, 3 Aug 2023 05:48:11 +0000 (22:48 -0700)]
[PERF] Setup scheduled once a day runs rather than constant runs (#89884)
Ankit Jain [Thu, 3 Aug 2023 04:55:20 +0000 (00:55 -0400)]
[wasm] Fix condition to use latest chrome for testing (#89890)
* [wasm] Fix condition to use latest chrome for testing
* [wasm] CI: Trigger WBT on changes in ProvisioningVersions.props
* [wasm] runtime: Fix creating the stack trace for a ManagedError
With the latest chrome (`115.*`) the following code in
`runtime/marshal.ts` fails because `this.superStack.value` is no longer
available:
```js
getSuperStack() {
if (this.superStack) {
return this.superStack.value;
}
return super.stack; // this works on FF
}
```
This causes the final error to not have the original managed error
message, and also have a `"undefined"` at the end of the string.
Truncated error missing the native part of the stack, and the message:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_271731536(JSMarshalerArgument* __arguments_buffer)
undefined
```
With the fix:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_817705034(JSMarshalerArgument* __arguments_buffer)
Error: -t-e-s-t-
at sr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:33284)
at Br (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:42679)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:40825
at Module.catch1stack (http://127.0.0.1:60345/JavaScriptTestHelper.mjs:132:9)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:36627
at mr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:37821)
at do_icall (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[221]:0x19711)
at do_icall_wrapper (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[108]:0x157bc)
at mono_interp_exec_method (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[101]:0x9c92)
at interp_runtime_invoke (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[141]:0x16cd7)
```
Thanks to @kg for the fix.
Michal Strehovský [Thu, 3 Aug 2023 02:32:33 +0000 (11:32 +0900)]
Rebaseline failing pri0 tests (#89835)
* We don't throw PNSE for unguarded HW intrinsic use. We could translate illegal instruction to PNSE but it feels too big of a hammer. We could do something more sophisticated such as disassemble the instruction and compare with "known problematic" ones. But it doesn't feel worth the effort.
* Non-zero lower bounds are not supported.
* Corner case weird enums like `enum Foo : double { }` are not supported.
Michal Strehovský [Thu, 3 Aug 2023 02:10:29 +0000 (11:10 +0900)]
Escape both CR and LF in IL disassembler (#89886)
Noticed this because lines were off with `--ildump`.
Thays Grazia [Thu, 3 Aug 2023 02:02:27 +0000 (23:02 -0300)]
[wasm][debugger] Fix failed to fetch debugger MT tests (#89737)
* Run the tests in debug mode to get more information.
* Adding log messages
* Fix build
* Adding more messages
* Adding more logs
* Removing task.delay.
* Reducing maxParallelDownloads
* Adding more messages
* Fix compilation
* Trying to fix CI.
* Setting the maxParallelDownloads to 10.
Michal Strehovský [Thu, 3 Aug 2023 00:29:40 +0000 (09:29 +0900)]
Fix analysis issue in LDTOKEN dependencies (#89757)
This was found in Pri0 testing. The LDTOKEN data structures didn't have enough information for generic method instantiation arguments. The Pri0 test was around generic virtual methods, but this is a more general issue so adding an extra test for that.
I'm also changing how `NodeFactory.ReflectedMethod` works - it will now require being called with canonical things explicitly (and asserts if it isn't) instead of canonicalizing behind the scenes. This was obscuring the problem.
Mark Plesko [Thu, 3 Aug 2023 00:16:34 +0000 (17:16 -0700)]
Clarifications in botr gc section (#89888)
dotnet-maestro[bot] [Thu, 3 Aug 2023 00:08:17 +0000 (19:08 -0500)]
[main] Update dependencies from dotnet/roslyn (#89860)
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.8
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Jackson Schuster [Wed, 2 Aug 2023 23:48:58 +0000 (16:48 -0700)]
[ComInterfaceGenerator] Guaranteed unmarshal before managed call in unmanaged to managed stubs (#89583)
Move guaranteed unmarshalling to the correct place in unmanaged to managed stucs
Thays Grazia [Wed, 2 Aug 2023 23:36:03 +0000 (20:36 -0300)]
Fixing side effect of 89741 (#89873)
Will Smith [Wed, 2 Aug 2023 22:42:15 +0000 (15:42 -0700)]
Create temp directory for SuperPMI JIT when running crossgen2 collections (#89875)
* Create a temporary directory for crossgen2 SuperPMI collections to hold a JIT binary
* Print superpmi jit path for logging purposes
* Added fallback
* Ignore cleanup errors
* Do not cleanup in handling an the exception
* Using existing temp location
* Feedback
* Remove extra logging
Jan Kotas [Wed, 2 Aug 2023 22:16:44 +0000 (15:16 -0700)]
Fix optimizations for comparers corner cases in native AOT (#89829)
Fixes #89767
Vladimir Sadov [Wed, 2 Aug 2023 22:10:25 +0000 (15:10 -0700)]
[NativeAOT] A few scalability fixes for the fat Lock (#88633)
Adeel Mujahid [Wed, 2 Aug 2023 22:07:56 +0000 (01:07 +0300)]
Add `CompressSymbols` opt-out option in NativeAOT (#85192)
* Add `CompressSymbols` opt-out option in NativeAOT
* Report what went wrong in dwarfdump test
* Update src/tests/nativeaot/SmokeTests/DwarfDump/Program.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Tanner Gooding [Wed, 2 Aug 2023 20:51:36 +0000 (13:51 -0700)]
Utilize the new `ref readonly` language feature (#89736)
* Updating the Roslyn toolset compiler to v4.8.0-1.23378.8
* Changing signatures from `in` to `ref readonly`
* Changing signatures from `ref` to `in`
* Changing signatures from `ref` to `ref readonly`
* Fix case missed for Unix build
* Ensure an xml comment works for .NET or .NET Framework
* Ensure tests properly handle `ref readonly` changes
Mike McLaughlin [Wed, 2 Aug 2023 20:04:48 +0000 (13:04 -0700)]
Fix DAC GetFlags() function for SOS (#89679)
Jackson Schuster [Wed, 2 Aug 2023 19:50:53 +0000 (12:50 -0700)]
Add test types (#89864)
Adds a number of test interfaces to ComInterfaceGenerator tests.
Eirik Tsarpalis [Wed, 2 Aug 2023 18:11:51 +0000 (21:11 +0300)]
Apply mitigations for a recent STJ performance regression (#89856)
Pavel Savara [Wed, 2 Aug 2023 17:17:58 +0000 (19:17 +0200)]
[browser] fix for delayed WS close event on NodeJs (#89847)
Pavel Savara [Wed, 2 Aug 2023 17:07:17 +0000 (19:07 +0200)]
remove active issue https://github.com/dotnet/runtime/issues/77334 (#89676)
Badre BSAILA [Wed, 2 Aug 2023 16:26:52 +0000 (18:26 +0200)]
Improve enum parsing in config binder generator (#89823)
Sven Boemer [Wed, 2 Aug 2023 16:23:16 +0000 (09:23 -0700)]
Update prepare-artifacts.proj (#89803)
* Update prepare-artifacts.proj
Don't pass AssetsTemporaryDirectory
* Remove TmpWorkingDir
And PublishingVersion, per PR feedback
dotnet-maestro[bot] [Wed, 2 Aug 2023 15:58:02 +0000 (17:58 +0200)]
[main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/arcade dotnet/xharness dotnet/runtime-assets dotnet/emsdk (#89810)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tarek Mahmoud Sayed [Wed, 2 Aug 2023 15:55:49 +0000 (08:55 -0700)]
Fix Globalization Invariant string comparisons with ordinal ignore casing (#89660)
dotnet-maestro[bot] [Wed, 2 Aug 2023 14:50:34 +0000 (07:50 -0700)]
[main] Update dependencies from dotnet/roslyn (#89593)
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.1
* Resolving new warnings around InlineArray
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.10
* Suppress the new SizeConst warning for the MetadataLoadContext sample metadata
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Milena Hristova [Wed, 2 Aug 2023 14:13:15 +0000 (16:13 +0200)]
enable binskim scan (#89728)
Pavel Savara [Wed, 2 Aug 2023 09:25:27 +0000 (11:25 +0200)]
[browser] fix loading assets (#89687)
Ilona Tomkowicz [Wed, 2 Aug 2023 09:14:30 +0000 (11:14 +0200)]
[wasm] Assure name starts with `icudt` + fix testing scenario. (#89719)
* Asure name starts with `icudt` + fix full + custom ICU scenario.
* Feedback.
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
---------
Co-authored-by: Ankit Jain <radical@gmail.com>
Dong-Heon Jung [Wed, 2 Aug 2023 09:00:07 +0000 (18:00 +0900)]
[RISC-V][JIT] Fix assetion in System.Threading.LowLevelLifoSemaphore.Wait (#89826)
* [RISC-v][JIT] Update 4 bytes value in JCMP
* Fix some mistakes