robertphillips@google.com [Tue, 5 Jun 2012 16:24:32 +0000 (16:24 +0000)]
Reverting r4162
git-svn-id: http://skia.googlecode.com/svn/trunk@4164
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 5 Jun 2012 16:14:23 +0000 (16:14 +0000)]
add gm (no images yet) for two-point-radial gradients
git-svn-id: http://skia.googlecode.com/svn/trunk@4163
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 15:40:54 +0000 (15:40 +0000)]
Added instance counting system for SkRefCnt-derived objects
http://codereview.appspot.com/6242070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4162
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Jun 2012 15:13:46 +0000 (15:13 +0000)]
Move stuff from protected to private in GrGpuGL
Review URL: http://codereview.appspot.com/6295044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4161
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 5 Jun 2012 14:58:40 +0000 (14:58 +0000)]
Fix an issue where Pipe did not draw correctly
on all platforms.
Since parameters can be evaluated in any order,
we can't call buffer.read() inline for multiple
parameters. The fix is to read the stream (in
the correct order) before we call the function.
Review URL: https://codereview.appspot.com/6277046
git-svn-id: http://skia.googlecode.com/svn/trunk@4160
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 13:22:14 +0000 (13:22 +0000)]
Added missing #include in SkGlobalInitialization_default.cpp for Android build
git-svn-id: http://skia.googlecode.com/svn/trunk@4156
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 13:12:53 +0000 (13:12 +0000)]
Fix for compiler error in r4154
git-svn-id: http://skia.googlecode.com/svn/trunk@4155
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 12:55:05 +0000 (12:55 +0000)]
Fixed flattening of SkStippleMaskFilter
http://codereview.appspot.com/6279052/
git-svn-id: http://skia.googlecode.com/svn/trunk@4154
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Jun 2012 12:50:41 +0000 (12:50 +0000)]
Mac mini lion rebaselines from r4152
git-svn-id: http://skia.googlecode.com/svn/trunk@4153
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 21:44:25 +0000 (21:44 +0000)]
Rebaseline GPU gradient GMs due to r4151.
git-svn-id: http://skia.googlecode.com/svn/trunk@4152
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:21:28 +0000 (20:21 +0000)]
Always filter gradient textures
[GMs could possibly need rebaselining]
Review URL: http://codereview.appspot.com/6286048/
git-svn-id: http://skia.googlecode.com/svn/trunk@4151
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:18:54 +0000 (20:18 +0000)]
Remove cached texture width/height that was used by 4x4 filter
Review URL: http://codereview.appspot.com/6286048
git-svn-id: http://skia.googlecode.com/svn/trunk@4150
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:06:02 +0000 (20:06 +0000)]
remove 4x4 downsample filter mode
Review URL: http://codereview.appspot.com/6267046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4149
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 20:05:28 +0000 (20:05 +0000)]
GrTexture can now create its own cache key
http://codereview.appspot.com/6269047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4148
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 20:00:01 +0000 (20:00 +0000)]
change gm to use concat instead of setMatrix, so we don't trash the caller if
it was recorded into a picture.
git-svn-id: http://skia.googlecode.com/svn/trunk@4147
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 4 Jun 2012 19:58:30 +0000 (19:58 +0000)]
Clean up likely reference leak in Ganesh custom stages.
http://codereview.appspot.com/6286047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4146
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 19:37:36 +0000 (19:37 +0000)]
rebaselined w/ new (high-fidelity-asColorMatrix) colormatrix impl from 4143
git-svn-id: http://skia.googlecode.com/svn/trunk@4145
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 19:31:00 +0000 (19:31 +0000)]
Break up GrGpuGL::flushGLCommonState
Review URL: http://codereview.appspot.com/6270049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4144
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 19:07:41 +0000 (19:07 +0000)]
remove mutable apis on SkColorMatrixFilter, must use constructor.
fix flattening to not write function-ptrs (no go for serialization), so we
store the raw float values now.
Slight change to GM/DRT images for GPU possible. Just rebaseline.
Review URL: https://codereview.appspot.com/6273052
git-svn-id: http://skia.googlecode.com/svn/trunk@4143
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 19:05:11 +0000 (19:05 +0000)]
move texture flush and param update to separate function
Review URL: http://codereview.appspot.com/6266044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4142
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 18:10:33 +0000 (18:10 +0000)]
remove public function-ptr based colorfilter
Review URL: https://codereview.appspot.com/6286046
git-svn-id: http://skia.googlecode.com/svn/trunk@4141
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Jun 2012 17:45:54 +0000 (17:45 +0000)]
Turn off pipe playback in GM by default.
Works for me, but not on all platforms.
Review URL: https://codereview.appspot.com/6293043
git-svn-id: http://skia.googlecode.com/svn/trunk@4140
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Jun 2012 17:17:36 +0000 (17:17 +0000)]
Make the GM tool run GMs through an SkGPipe.
Add pipe to core gyp project.
Do not run samplerstress through the pipe, since its
custom MaskFilter will not draw correctly.
Fix an assert in SkGPipeWrite when writing a typeface.
Review URL: https://codereview.appspot.com/6276044
git-svn-id: http://skia.googlecode.com/svn/trunk@4139
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 4 Jun 2012 14:13:06 +0000 (14:13 +0000)]
change static variable to #define
git-svn-id: http://skia.googlecode.com/svn/trunk@4138
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 4 Jun 2012 13:39:47 +0000 (13:39 +0000)]
Add legacy script to enable skia roll into chromium.
Review URL: https://codereview.appspot.com/6277045
git-svn-id: http://skia.googlecode.com/svn/trunk@4137
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 13:31:48 +0000 (13:31 +0000)]
Revert r4134 due to bot failures
git-svn-id: http://skia.googlecode.com/svn/trunk@4136
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 13:22:14 +0000 (13:22 +0000)]
Fixed Linux compiler complaints
http://codereview.appspot.com/6269045/
git-svn-id: http://skia.googlecode.com/svn/trunk@4135
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 13:03:25 +0000 (13:03 +0000)]
Move GrGpuGL::programUnitTest into its own file
Review URL: http://codereview.appspot.com/6272043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4134
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 12:48:45 +0000 (12:48 +0000)]
Move texture descriptor into GrTexture
http://codereview.appspot.com/6258068/
git-svn-id: http://skia.googlecode.com/svn/trunk@4133
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 12:05:43 +0000 (12:05 +0000)]
--pictureDir foo will load serialized pictures <>.skp from the foo directory
git-svn-id: http://skia.googlecode.com/svn/trunk@4132
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 2 Jun 2012 14:50:13 +0000 (14:50 +0000)]
add -wp option to write serialized pictures to the specified directory
git-svn-id: http://skia.googlecode.com/svn/trunk@4131
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 1 Jun 2012 21:23:07 +0000 (21:23 +0000)]
Adding option to serialize mutable bitmaps in SkPicture
BUG=http://code.google.com/p/chromium/issues/detail?id=115654
REVIEW=http://codereview.appspot.com/6221066/
git-svn-id: http://skia.googlecode.com/svn/trunk@4130
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 1 Jun 2012 20:42:15 +0000 (20:42 +0000)]
Flip the switch to turn on GrCustomStage implementation of gradients;
remove old implementation, including enums & state on various structs.
http://codereview.appspot.com/6245078/
git-svn-id: http://skia.googlecode.com/svn/trunk@4129
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 1 Jun 2012 19:50:02 +0000 (19:50 +0000)]
Fix GrSamplerState::operator=() to take a reference rather than a copy.
Visual review by bsalomon@.
git-svn-id: http://skia.googlecode.com/svn/trunk@4128
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 1 Jun 2012 19:47:51 +0000 (19:47 +0000)]
VC++ allows template parameter shadowing.
git-svn-id: http://skia.googlecode.com/svn/trunk@4127
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 1 Jun 2012 19:38:19 +0000 (19:38 +0000)]
Serialize support for GDI.
http://codereview.appspot.com/6263046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4126
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 1 Jun 2012 19:36:05 +0000 (19:36 +0000)]
read/write sfnt-data length, to match convetion of other fonthosts.
TODO: move that "convention" into shared code (SkTypeface.cpp or SkFontHost.cpp)
and just require each port to support:
1. typeface <--> descriptor
2. typeface_raw_data <--> stream (possibly with algo-style flags)
git-svn-id: http://skia.googlecode.com/svn/trunk@4125
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 19:28:26 +0000 (19:28 +0000)]
Move GrGpuGL::programUnitTest into its own file
Review URL: http://codereview.appspot.com/6272043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4124
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 19:25:00 +0000 (19:25 +0000)]
Move max vertex attributes value to GL Caps
Review URL: http://codereview.appspot.com/6271043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4123
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 19:01:37 +0000 (19:01 +0000)]
Remove dirty flags from GrGpuGL state flush
Review URL: http://codereview.appspot.com/6255073/
git-svn-id: http://skia.googlecode.com/svn/trunk@4122
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 18:50:01 +0000 (18:50 +0000)]
SkBool8 -> bool to suppress warning (verbal LGTM from TomH)
git-svn-id: http://skia.googlecode.com/svn/trunk@4121
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 18:29:37 +0000 (18:29 +0000)]
Suppress dumb warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@4120
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 1 Jun 2012 18:20:10 +0000 (18:20 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4119
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 1 Jun 2012 17:44:28 +0000 (17:44 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4118
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 1 Jun 2012 16:19:32 +0000 (16:19 +0000)]
use SkFontDescriptor on mac
Review URL: https://codereview.appspot.com/6247064
git-svn-id: http://skia.googlecode.com/svn/trunk@4117
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 1 Jun 2012 15:55:50 +0000 (15:55 +0000)]
Clean up duplicate code in Ganesh, moving more function onto GrGLShaderBuilder.
http://codereview.appspot.com/6245082/
git-svn-id: http://skia.googlecode.com/svn/trunk@4116
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 1 Jun 2012 15:53:06 +0000 (15:53 +0000)]
Remove 'legacy' font descriptor methods.
http://codereview.appspot.com/6261059/
git-svn-id: http://skia.googlecode.com/svn/trunk@4115
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 1 Jun 2012 15:36:39 +0000 (15:36 +0000)]
Store font family when serializing android fonts.
Review URL: https://codereview.appspot.com/6259063
git-svn-id: http://skia.googlecode.com/svn/trunk@4114
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 1 Jun 2012 15:08:19 +0000 (15:08 +0000)]
Move GrGpuGL::ProgramCache declaration to header
Review URL: http://codereview.appspot.com/6245083/
git-svn-id: http://skia.googlecode.com/svn/trunk@4113
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 1 Jun 2012 13:15:47 +0000 (13:15 +0000)]
Punctuation cleanup to satisfy idiosyncracies of OpenBSD gcc 4.2.1.
Original patch by landry.breuil.
http://code.google.com/p/skia/issues/detail?id=626
git-svn-id: http://skia.googlecode.com/svn/trunk@4112
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 1 Jun 2012 12:52:26 +0000 (12:52 +0000)]
Update the implementation of SkTypeface_android.h functions.
This CL removes the hardcoded mappings of FallbackScripts to
a particular font file and replaces it with a dynamic mechanism
that takes a style and representative character code for a given
FallbackScript class and returns the most appropriate SkTypeface
that contains that character code.
Review URL: https://codereview.appspot.com/6197074
git-svn-id: http://skia.googlecode.com/svn/trunk@4111
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 31 May 2012 21:16:48 +0000 (21:16 +0000)]
add more names to fontdescriptor
Review URL: https://codereview.appspot.com/6249074
git-svn-id: http://skia.googlecode.com/svn/trunk@4110
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 20:39:48 +0000 (20:39 +0000)]
Stop using deprecated functions in Mac GrGLInterface setup
git-svn-id: http://skia.googlecode.com/svn/trunk@4109
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 31 May 2012 20:35:27 +0000 (20:35 +0000)]
Zero out GrSamplerState in constructor to recover performance loss on Linux from r4102.
(Noise in padding bytes was breaking operator==())
Visual review by bsalomon@.
git-svn-id: http://skia.googlecode.com/svn/trunk@4108
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 31 May 2012 20:17:16 +0000 (20:17 +0000)]
update after dashing change
git-svn-id: http://skia.googlecode.com/svn/trunk@4107
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 31 May 2012 19:55:08 +0000 (19:55 +0000)]
Add SkFontDescriptor for serializing fonts.
Review URL: https://codereview.appspot.com/6250080
git-svn-id: http://skia.googlecode.com/svn/trunk@4106
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 31 May 2012 19:53:37 +0000 (19:53 +0000)]
Fix SK_OVERRIDE error caught by Clang in r4105; wrong params for setData().
git-svn-id: http://skia.googlecode.com/svn/trunk@4105
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 31 May 2012 19:40:13 +0000 (19:40 +0000)]
Add GrGradientEffects files. These implementations will be invoked from
GrGLPrograms in a further change, replacing the current CoordMapping
enums.
http://codereview.appspot.com/6250081/
git-svn-id: http://skia.googlecode.com/svn/trunk@4104
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 31 May 2012 19:10:30 +0000 (19:10 +0000)]
Enable typeface from stream test for Mac.
git-svn-id: http://skia.googlecode.com/svn/trunk@4103
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 18:40:36 +0000 (18:40 +0000)]
Implement morphology as a custom effect
Review URL: http://codereview.appspot.com/6250073/
git-svn-id: http://skia.googlecode.com/svn/trunk@4102
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 31 May 2012 18:28:59 +0000 (18:28 +0000)]
We often rgn-diff an area >= the other rgn. now we detect that and return empty
We do this when we update our devices in SkCanvas.cpp
Review URL: https://codereview.appspot.com/6249073
git-svn-id: http://skia.googlecode.com/svn/trunk@4101
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 18:09:11 +0000 (18:09 +0000)]
Add glTexParameteriv to MESA GrGLInterface (missing from r4099)
git-svn-id: http://skia.googlecode.com/svn/trunk@4100
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 17:59:23 +0000 (17:59 +0000)]
Add glTexParameteriv to GL interface
Comitted on behalf of jin.a.yang@intel.com
Review URL: http://codereview.appspot.com/6213069/
git-svn-id: http://skia.googlecode.com/svn/trunk@4099
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 31 May 2012 15:29:44 +0000 (15:29 +0000)]
Windows compiler complaint cleanup
http://codereview.appspot.com/6262047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4098
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 31 May 2012 15:13:45 +0000 (15:13 +0000)]
skdiff: return nonzero exit value if there are any mismatches
This will allow us to replace "gm -r" in our buildbots with "skdiff". This will speed things up, and work around http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic')
Review URL: https://codereview.appspot.com/6242071
git-svn-id: http://skia.googlecode.com/svn/trunk@4097
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 31 May 2012 15:12:09 +0000 (15:12 +0000)]
skdiff: internally track lists of ALL result types, not just baseMissing and comparisonMissing
This does not change skdiff output at all; verified using tools/tests/run.sh
Review URL: https://codereview.appspot.com/6260057
git-svn-id: http://skia.googlecode.com/svn/trunk@4096
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 15:07:19 +0000 (15:07 +0000)]
Merge GrGpuGLShaders into its parent class, GrGpuGL
Review URL: http://codereview.appspot.com/6245076/
git-svn-id: http://skia.googlecode.com/svn/trunk@4095
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 31 May 2012 14:31:14 +0000 (14:31 +0000)]
Fix typo in r4092.
git-svn-id: http://skia.googlecode.com/svn/trunk@4094
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 31 May 2012 14:23:28 +0000 (14:23 +0000)]
Use element-by-element assignment in GrSamplerState::operator= instead of memcpy
so that we can handle refcounting correctly.
http://codereview.appspot.com/6262049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4092
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 14:12:46 +0000 (14:12 +0000)]
Use a single GrDrawState in GrContext for direct and buffered drawing
Review URL: http://codereview.appspot.com/5933043
git-svn-id: http://skia.googlecode.com/svn/trunk@4091
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 31 May 2012 13:54:51 +0000 (13:54 +0000)]
Disable TLSTest for now, to work around code.google.com/p/skia/issues/detail?id=619
Review URL: https://codereview.appspot.com/6259056
git-svn-id: http://skia.googlecode.com/svn/trunk@4090
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 31 May 2012 13:13:11 +0000 (13:13 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4089
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 31 May 2012 12:52:43 +0000 (12:52 +0000)]
Add a bunch of SK_OVERRIDES and remove and unused function
Review URL: http://codereview.appspot.com/6245072/
git-svn-id: http://skia.googlecode.com/svn/trunk@4088
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 31 May 2012 12:39:18 +0000 (12:39 +0000)]
suppress warning on Mac
http://codereview.appspot.com/6245070/
M gyp/common_conditions.gypi
git-svn-id: http://skia.googlecode.com/svn/trunk@4087
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 30 May 2012 19:12:45 +0000 (19:12 +0000)]
test-only: add test coverage of skdiff over input with identical bits or pixels
Review URL: https://codereview.appspot.com/6260055
git-svn-id: http://skia.googlecode.com/svn/trunk@4084
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Wed, 30 May 2012 18:26:03 +0000 (18:26 +0000)]
Condense setupFSUnis, setupVSUnis, setupVaryings into
GrGLProgramStage::setupVariables().
Rename appendVarying() to addVarying(), matching addUniform().
http://codereview.appspot.com/6262046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4083
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 30 May 2012 18:13:23 +0000 (18:13 +0000)]
Remove a couple things missed when deleting the tessellated path renderer
Review URL: http://codereview.appspot.com/6249070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4082
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Wed, 30 May 2012 17:38:57 +0000 (17:38 +0000)]
Encapsulate code required to create a uniform var into a single function on
GrGLShaderBuilder. This isolates internal dependencies from somebody
writing a CustomStage.
http://codereview.appspot.com/6248050/
git-svn-id: http://skia.googlecode.com/svn/trunk@4081
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 30 May 2012 16:54:13 +0000 (16:54 +0000)]
Refactor dictionaries for use by entities other than just SkPicture
Review URL: https://codereview.appspot.com/6101043
git-svn-id: http://skia.googlecode.com/svn/trunk@4077
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 30 May 2012 16:50:11 +0000 (16:50 +0000)]
Add bench to test the performance of creating a picture.
Review URL: https://codereview.appspot.com/6258062
git-svn-id: http://skia.googlecode.com/svn/trunk@4076
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 15:19:17 +0000 (15:19 +0000)]
Added cast to get MathTest working on Windows
git-svn-id: http://skia.googlecode.com/svn/trunk@4072
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 14:46:10 +0000 (14:46 +0000)]
Added knowledge of GL_RED textures to debugGLReadPixels
http://codereview.appspot.com/6257070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4071
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 14:08:57 +0000 (14:08 +0000)]
apply 10.p+32 -> (float)(1 << 23) fix from MathTest here as well
windows can't eat the former syntax
git-svn-id: http://skia.googlecode.com/svn/trunk@4070
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Wed, 30 May 2012 13:54:41 +0000 (13:54 +0000)]
arm: First step towards dynamic NEON support.
This patch adds minimal support for dynamic ARM NEON support,
i.e. the ability to probe the CPU at runtime for NEON and
provide alternate code paths when it is available.
- Add include/core/SkUtilsArm.h, which declares a few helper
macros (e.g. SK_NEON_ARM_IS_DYNAMIC), plus the handy
function 'sk_cpu_arm_has_neon()' which returns true if
the target CPU supports the ARM NEON instruction set.
Note that the header is in include/core/ because it will
have to be included from NEON-specific code under src/code/
It would probably be more logical to put it under include/opts/
instead, but this would require moving all the NEON-specific
stuff under src/code/ into src/opts/, which is not trivial
due to the way the code is currently architected.
- Add src/core/SkUtilsArm.cpp which implements
'sk_cpu_arm_has_neon' for ARM-based Linux systems, only
when SK_NEON_ARM_IS_DYNAMIC is true.
(For other cases, 'sk_cpu_arm_has_neon' is an inline function
that returns a constant 'true' or 'false' value).
There is no user-level accessible CPUID instruction on ARM,
so do all CPU feature probing by parsing /proc/cpuinfo.
This is Linux-specific.
For Debug build types, the CPU probing result is printed
to the Android log (or Linux command-line) for easier
debugging.
- Create a new 'opts_neon' target (static library) which shall
contain all the NEON-specific code paths for the library.
This is necessary because -mfpu=neon impacts also non-scalar
code. Just like with -mssse3 on x86, we can't build the rest
of the library with this flag.
Note that for now, we only include memset16_neon and
memset32_neon in this library.
- Modify opts_check_arm.cpp to implement SK_ARM_NEON_IS_DYNAMIC
properly.
Compared to a 'xoom' build, the only difference is the use of
NEON-optimized memset16/32 functions. Later patches will move
more NEON-specific code paths to 'opts_neon'.
Review URL: https://codereview.appspot.com/6247058
git-svn-id: http://skia.googlecode.com/svn/trunk@4069
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 13:48:14 +0000 (13:48 +0000)]
use (float)(1 << 23) instead of 1.0p+23 since the latter isn't supported in VS
git-svn-id: http://skia.googlecode.com/svn/trunk@4068
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:43:59 +0000 (12:43 +0000)]
win can't eat 1.0p+23 syntax for floats :(
git-svn-id: http://skia.googlecode.com/svn/trunk@4067
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:30:09 +0000 (12:30 +0000)]
remove debugf
git-svn-id: http://skia.googlecode.com/svn/trunk@4066
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:26:52 +0000 (12:26 +0000)]
add bench for floor variants
git-svn-id: http://skia.googlecode.com/svn/trunk@4065
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 12:26:39 +0000 (12:26 +0000)]
Fixed small bug in shader generation
http://codereview.appspot.com/6259053/
git-svn-id: http://skia.googlecode.com/svn/trunk@4064
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 29 May 2012 21:28:12 +0000 (21:28 +0000)]
svndiff: report added and deleted files, not just modified files
Review URL: https://codereview.appspot.com/6260052
git-svn-id: http://skia.googlecode.com/svn/trunk@4063
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 20:48:50 +0000 (20:48 +0000)]
special-case dashing a single line-segment. We can go much faster since we
can apply the stroke as we go, eliminating the generic stroker.
Review URL: https://codereview.appspot.com/6250070
git-svn-id: http://skia.googlecode.com/svn/trunk@4062
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 19:54:52 +0000 (19:54 +0000)]
addPoly() entry-point, to quickly add MoveTo+N*LineTo (useful in dashing)
Review URL: https://codereview.appspot.com/6256063
git-svn-id: http://skia.googlecode.com/svn/trunk@4061
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 29 May 2012 19:44:14 +0000 (19:44 +0000)]
Fix line ending, mark svn:eol-style LF
git-svn-id: http://skia.googlecode.com/svn/trunk@4060
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 29 May 2012 16:53:04 +0000 (16:53 +0000)]
Fixing a reader size overflow with SkOrderedReadBuffer, when unflattening large bitmaps.
REVIEW=http://codereview.appspot.com/6250054/
git-svn-id: http://skia.googlecode.com/svn/trunk@4059
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 29 May 2012 15:33:30 +0000 (15:33 +0000)]
Update list of trybots used by https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests
TBR=reed
Review URL: https://codereview.appspot.com/6250071
git-svn-id: http://skia.googlecode.com/svn/trunk@4058
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 12:03:46 +0000 (12:03 +0000)]
Detect when the caller was hairline AND strokeandfill, and resolve that into FILL
This fixes the unittests on WIN in the trybot for DEPS roll 4048
Review URL: https://codereview.appspot.com/6242057
git-svn-id: http://skia.googlecode.com/svn/trunk@4057
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 29 May 2012 01:40:15 +0000 (01:40 +0000)]
add SkPoint::isZero(), match the existing method on SkIPoint
git-svn-id: http://skia.googlecode.com/svn/trunk@4055
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 May 2012 14:10:15 +0000 (14:10 +0000)]
Rolling back 4053
git-svn-id: http://skia.googlecode.com/svn/trunk@4054
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 May 2012 13:37:25 +0000 (13:37 +0000)]
Speculative fix for Android Debug only crash in r4049
http://codereview.appspot.com/6251049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4053
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 25 May 2012 19:48:05 +0000 (19:48 +0000)]
Add svndiff tool: runs skdiff over all pending changes in SVN checkout
This is needed for
https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests ,
and will be generally useful beyond that too.
Review URL: https://codereview.appspot.com/6256052
git-svn-id: http://skia.googlecode.com/svn/trunk@4052
2bbb7eff-a529-9590-31e7-
b0007b416f81