Stephen Toub [Sun, 6 Oct 2019 02:33:18 +0000 (22:33 -0400)]
Fix HtmlEncode handling of surrogate pairs (dotnet/corefx#41576)
Due to a regression that came as part of changing the code from using pointers to using spans, when the surrogate pair isn't at the beginning of the the input, it's incorrectly encoded.
Commit migrated from https://github.com/dotnet/corefx/commit/
6de42378223c6cb138d28f812c440092718c7a19
Stephen Toub [Sat, 5 Oct 2019 18:12:52 +0000 (14:12 -0400)]
Expose, test, and use ExceptionDispatchInfo.SetCurrentStackTrace
Commit migrated from https://github.com/dotnet/corefx/commit/
615990343a9400e46122debf48a5fb08ec452787
Stephen Toub [Sat, 5 Oct 2019 11:53:40 +0000 (07:53 -0400)]
Remove System.Linq dependency from System.Net.NetworkInformation (dotnet/corefx#41566)
It was only being used on Unix, and the uses are all easily replaced with more efficient implementations.
Commit migrated from https://github.com/dotnet/corefx/commit/
e3fe1db114a283b8719ed1d02a1e26d57010cb55
Stephen Toub [Sat, 5 Oct 2019 11:34:28 +0000 (07:34 -0400)]
Remove unused usings from System.Security.Cryptography.Xml (dotnet/corefx#41568)
I was looking for uses of "using System.Linq;". One file had it, but it turned out to be unused/unnecessary, so as long as I was removing it, I ran VS' "remove unused usings" on the project.
Commit migrated from https://github.com/dotnet/corefx/commit/
418c2e84dbf159100463f172227fbe7460b36533
Stephen Toub [Sat, 5 Oct 2019 11:20:25 +0000 (07:20 -0400)]
Replace Stack with Stack<T> in XmlDataLoader (dotnet/corefx#41569)
This looks like the only remaining uses of the non-generic Stack in a trimmed web api app.
Commit migrated from https://github.com/dotnet/corefx/commit/
052f4af24c1ccaa9bb42735fbdc2e99cadef1e66
Anirudh Agnihotry [Fri, 4 Oct 2019 23:44:56 +0000 (16:44 -0700)]
Removing Microsoft.bcl* packages (dotnet/corefx#41270)
* removing Microsoft.bcl packages
* targetframework conditions modified
* adding versionless config to avoid binplace
* uap standard conflicts
* remove package configurations
* negation if and remove exclude reference asset property
* adding choosing when statement
* using attribute
* Moveing packages to include to the common
* ChooseWhen -> IF
Commit migrated from https://github.com/dotnet/corefx/commit/
99ea2b5aebf7361a5baa638c978cb6214fca5217
Stephen Toub [Fri, 4 Oct 2019 23:14:30 +0000 (19:14 -0400)]
Remove System.Linq dependency from System.Security.Cryptography.Algorithms (dotnet/corefx#41554)
It's not being used. Remove it.
Commit migrated from https://github.com/dotnet/corefx/commit/
a434a52ae3f1175bc1cad8b1a02b0921ef3b1f55
Stephen Toub [Fri, 4 Oct 2019 20:53:22 +0000 (16:53 -0400)]
Remove unnecessary System.Linq usage from Microsoft.CSharp (dotnet/corefx#41552)
Most of the usage was just as easily (if not more easily) done without LINQ. In some cases the use was entirely superfluous (e.g. MethodReturningNewArray().ToArray()).
Commit migrated from https://github.com/dotnet/corefx/commit/
09698dd91c53e123d3a0f1240b5f611b3c14639c
Adeel Mujahid [Fri, 4 Oct 2019 18:48:15 +0000 (21:48 +0300)]
Replace PrintF with Console.WriteLine and cleanups (dotnet/corefx#41540)
* Replace PrintF with Console.WriteLine and cleanups
* PR feedback: simplify WriteLine arguments
Commit migrated from https://github.com/dotnet/corefx/commit/
c28a9e69902bcbc0d742732630bd6e82ac922d5b
Anirudh Agnihotry [Fri, 4 Oct 2019 15:29:14 +0000 (08:29 -0700)]
updating packageindex with stable versions (dotnet/corefx#41511)
* updating packageindex with stable versions
* disabling harverst stable packages
Commit migrated from https://github.com/dotnet/corefx/commit/
b5ef4ea045bdd3dc8d528e6408360bf812eefd17
Steve Harter [Thu, 3 Oct 2019 22:49:04 +0000 (17:49 -0500)]
Demonstrate converters for Dictionary<TKey, TValue> where TKey is not String (dotnet/corefx#41469)
Commit migrated from https://github.com/dotnet/corefx/commit/
eff9fbf446468ca411bf5e0475916f316eea7223
Hugh Bellamy [Thu, 3 Oct 2019 21:42:42 +0000 (22:42 +0100)]
Consolidate PrintController code and cleanup some interop (dotnet/corefx#36736)
* Consolidate PrintController code and cleanup some interop
* Cleanup access modifiers in PrintDocument
* Add tests and fix debug assert failures
* Remove argument validation from APIs that should be called from internal members only and update tests
Commit migrated from https://github.com/dotnet/corefx/commit/
07262aa6bce06f1e270e6a9b494bfe6eb1260b08
Ben Adams [Thu, 3 Oct 2019 20:25:00 +0000 (21:25 +0100)]
Add CollectionsMarshal ref assemblies (dotnet/corefx#41306)
* Add CollectionsMarshal
* Feedback
* nits
* Feedback
* Update src/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/CollectionsMarshalTests.cs
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Reference collections
Commit migrated from https://github.com/dotnet/corefx/commit/
74cfdadd73fc5bc385727ea9e9d7f368926f29fc
Haresh Ambaliya [Thu, 3 Oct 2019 19:55:51 +0000 (01:25 +0530)]
Update coding-style.md (dotnet/corefx#41506)
* Update coding-style.md
Changed Keyboard shortcut to show white space.
* Update coding-style.md
@gfoidl I have added about how to enable View White Space. I think we are good now.
Commit migrated from https://github.com/dotnet/corefx/commit/
d39276b9d4af15aebd829eaf1fbd7d43212a1f15
Filip Navara [Thu, 3 Oct 2019 17:59:55 +0000 (19:59 +0200)]
[System.Drawing.Common] Fix argument name in exception of Bitmap constructor (dotnet/corefx#41494)
* [System.Drawing.Common] Fix argument name in exception of Bitmap constructor
* Fix test for NetFX
Commit migrated from https://github.com/dotnet/corefx/commit/
78c2b959d814fffd2345d056576fe417a9405751
Santiago Fernandez Madero [Thu, 3 Oct 2019 16:26:07 +0000 (09:26 -0700)]
Update experimental IsShipping and block stable properties (dotnet/corefx#41513)
Commit migrated from https://github.com/dotnet/corefx/commit/
d217998bc5a3dfdc21ae22dd6161ea6c8f71f30c
Filip Navara [Thu, 3 Oct 2019 01:19:22 +0000 (03:19 +0200)]
[System.Drawing.Common] Relax IconTests.CorrectColorDepthExtracted test (dotnet/corefx#41495)
* [System.Drawing.Common] Relax IconTests.CorrectColorDepthExtracted to work on newer libgdiplus on Unix
* Address PR comment
Commit migrated from https://github.com/dotnet/corefx/commit/
a50e056c5a62fb6dfe2e9475be47b93d33661700
dotnet-maestro[bot] [Thu, 3 Oct 2019 00:36:36 +0000 (00:36 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41280)
* Add unit tests for Utf8Span, react to Utf8String changes
* Regenerating the reference sources for System.Runtime.Intrinsics.Experimental
* Update dependencies from https://github.com/dotnet/coreclr build
20191001.3
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19501.3
* Move corefx alpine build containers to 3.9
Commit migrated from https://github.com/dotnet/corefx/commit/
c8c2917540a568869ba761afa6e4dba6edeb433b
Viktor Hofer [Wed, 2 Oct 2019 17:54:42 +0000 (19:54 +0200)]
Increasing arm64 timeout on Linux (dotnet/corefx#41504)
Commit migrated from https://github.com/dotnet/corefx/commit/
fa9b26c9eeaadac927dbec4857c3c4f214d666c9
Nabeel Valley [Wed, 2 Oct 2019 01:07:26 +0000 (03:07 +0200)]
Prevent Setting SmtpClient.UseDefaultCredentials clearing Credentials (dotnet/corefx#41271)
* Ensure setting UseDefaultCredentials to False does not clear Credentials
* Remove reference comments
* Rename tests to align with convention
* Correctly set _transport.Credentials
* Include SmtpClient._transport.Credentials in tests, move tests to own file
* Change filename and refactor UN/PW
Commit migrated from https://github.com/dotnet/corefx/commit/
dcc9f626eeb0751d4ba4499f623aac42d2e95c10
joshudson [Tue, 1 Oct 2019 22:53:50 +0000 (15:53 -0700)]
Don't display any GUI during test run. (dotnet/corefx#38042)
Commit migrated from https://github.com/dotnet/corefx/commit/
6c892a14e4da5e1ec0c5c766c7625c4d2d51ffb6
Justin Kotalik [Tue, 1 Oct 2019 22:36:01 +0000 (07:36 +0900)]
Synchronize Http/2 HPack implementation between CoreFx and ASP.NET Core (dotnet/corefx#41069)
Commit migrated from https://github.com/dotnet/corefx/commit/
547a2936f07203ad7ac03603fa96d443542ee307
Tom Deseyn [Tue, 1 Oct 2019 21:29:33 +0000 (23:29 +0200)]
SmtpClientTest.TestZeroTimeout: FailFast to get CI coredump (dotnet/corefx#41087)
* SmtpClientTest.TestZeroTimeout: FailFast to get CI coredump
* Remove nop else block
Commit migrated from https://github.com/dotnet/corefx/commit/
4a223a0bd4d539dce1b5eea3f7657ada5217baeb
Anirudh Agnihotry [Tue, 1 Oct 2019 21:04:34 +0000 (14:04 -0700)]
freezing the version for the pipes (dotnet/corefx#41473)
Commit migrated from https://github.com/dotnet/corefx/commit/
3619b5d8367ddabcf9945479a98018fab891b486
Stephen Toub [Tue, 1 Oct 2019 19:43:41 +0000 (15:43 -0400)]
Remove unnecessary dependencies from System.Net.Http (dotnet/corefx#41470)
Commit migrated from https://github.com/dotnet/corefx/commit/
e4cfb1761f20b182919db2aeb6ba92b48492c469
Santiago Fernandez Madero [Tue, 1 Oct 2019 19:42:47 +0000 (12:42 -0700)]
Disable Save_SimpleSettings_Ok test in all platforms (dotnet/corefx#41477)
Commit migrated from https://github.com/dotnet/corefx/commit/
39cdcd49b65c642673f3c5eb229f6a1cede6a832
buyaa-n [Tue, 1 Oct 2019 18:52:31 +0000 (11:52 -0700)]
Annotate System.Diagnostics.DiagnosticSource for nullable (dotnet/corefx#41241)
* Annotate System.Diagnostics.DiagnosticSource for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
c5ab5e44f1ea915e45d74e8d3f4fa0af2b645805
Fyers [Tue, 1 Oct 2019 17:04:45 +0000 (19:04 +0200)]
fix broken link (dotnet/corefx#41471)
Commit migrated from https://github.com/dotnet/corefx/commit/
b50cbccbb844fbb05bb36826a51a2824bd5fbaa5
Karel Zikmund [Tue, 1 Oct 2019 16:53:35 +0000 (09:53 -0700)]
Update issue-guide.md
Fixing GH handle of @saurabh500
Commit migrated from https://github.com/dotnet/corefx/commit/
fff161638cc714f66fe06155049afdb01a97949b
Carlos Sanchez Lopez [Tue, 1 Oct 2019 16:10:58 +0000 (09:10 -0700)]
Find zip file end of central directory backwards up to max possible size (resubmit due to build break) (dotnet/corefx#41451)
Issue
Huge zip files without an end of central directory take a long time to throw because we seek to the end then search backwards for the EOCD signature all the way to the end.
Fix
Ensure we only search for the signature from the end within the maximum possible number of bytes where it can be found. If the signature is not found, we fail faster.
Submitting again due to build break caused by a conflict in the files modified by this commit.
Note
This may be a breaking change for the edge case where a zip file contains an EOCD comment with the maximum length + additional trailing garbage.
Commit migrated from https://github.com/dotnet/corefx/commit/
861259bf87d8e4ee2c4f8dab31b73d377faff77d
Eirik Tsarpalis [Mon, 30 Sep 2019 23:32:12 +0000 (16:32 -0700)]
[WIP] Try fixing failing IpPacketInformationTest (dotnet/corefx#41411)
Try fixing failing IpPacketInformationTest
Commit migrated from https://github.com/dotnet/corefx/commit/
969ce665afee70b2d591e5c271525c927a8834d0
dotnet-maestro[bot] [Mon, 30 Sep 2019 22:19:00 +0000 (22:19 +0000)]
[master] Update dependencies from 4 repositories (dotnet/corefx#41424)
* Update dependencies from https://github.com/dotnet/arcade build
20190927.2
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19477.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19477.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19477.2
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19477.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19477.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19477.2
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19477.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19477.2
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19477.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19477.2
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19477.2
* Update dependencies from https://github.com/dotnet/core-setup build
20190927.25
- Microsoft.NETCore.App - 5.0.0-alpha1.19477.25
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19477.25
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19477.25
* Update dependencies from https://github.com/dotnet/corefx build
20190927.7
- runtime.native.System.IO.Ports - 5.0.0-alpha1.19477.7
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19477.7
* Update dependencies from https://github.com/dotnet/standard build
20190927.1
- NETStandard.Library - 2.2.0-prerelease.19477.1
* Update dependencies from https://github.com/dotnet/core-setup build
20190928.4
- Microsoft.NETCore.App - 5.0.0-alpha1.19478.4
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19478.4
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19478.4
* Update dependencies from https://github.com/dotnet/standard build
20190928.2
- NETStandard.Library - 2.2.0-prerelease.19478.2
* Update dependencies from https://github.com/dotnet/core-setup build
20190929.2
- Microsoft.NETCore.App - 5.0.0-alpha1.19479.2
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19479.2
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19479.2
* Enable nullable in source projects that are full facades and generate a
not supported assembly with annotations in it
Commit migrated from https://github.com/dotnet/corefx/commit/
4eece5734d828ee8bf3393a04b71d80d5d5e4828
Eric StJohn [Mon, 30 Sep 2019 20:04:17 +0000 (13:04 -0700)]
Revert "Find zip file end of central directory backwards up to max possible size (dotnet/corefx#41007)" (dotnet/corefx#41449)
This reverts commit dotnet/corefx@
9d9c06f82eb4675a2aa56f07fe55a78039147784.
Commit migrated from https://github.com/dotnet/corefx/commit/
a9ebd33cbaef9b9eba9a0dbae178cc2814d62db4
Santiago Fernandez Madero [Mon, 30 Sep 2019 18:12:29 +0000 (11:12 -0700)]
Update Microsoft.Windows.Compatibility package for WCF and remove S.R.WindowsRuntime* (dotnet/corefx#41419)
Commit migrated from https://github.com/dotnet/corefx/commit/
34c1f84b18034406a6b7b91e8af641d22a3bf6ec
Carlos Sanchez Lopez [Mon, 30 Sep 2019 17:46:27 +0000 (10:46 -0700)]
Find zip file end of central directory backwards up to max possible size (dotnet/corefx#41007)
Issue
Huge zip files without an end of central directory take a long time to throw because we seek to the end then search backwards for the EOCD signature all the way to the end.
Fix
Ensure we only search for the signature from the end within the maximum possible number of bytes where it can be found. If the signature is not found, we fail faster.
Note
This may be a breaking change for the edge case where a zip file contains an EOCD comment with the maximum length + additional trailing garbage.
Commit migrated from https://github.com/dotnet/corefx/commit/
9d9c06f82eb4675a2aa56f07fe55a78039147784
Carlos Sanchez Lopez [Mon, 30 Sep 2019 16:26:20 +0000 (09:26 -0700)]
Update System.Data ownership (dotnet/corefx#41416)
Commit migrated from https://github.com/dotnet/corefx/commit/
9677a1458017796e4f42ae04c73cffce9e99aef2
Santiago Fernandez Madero [Fri, 27 Sep 2019 23:23:20 +0000 (16:23 -0700)]
Make ResolveEventArgs.Name not nullable (dotnet/corefx#41415)
Commit migrated from https://github.com/dotnet/corefx/commit/
7e9a177824cbefaee8985a9b517ebb0ea2e17a81
AntonLandor [Fri, 27 Sep 2019 22:17:59 +0000 (00:17 +0200)]
Added tests to cover all reachable branches when backed by JsonNode (dotnet/corefx#41252)
Commit migrated from https://github.com/dotnet/corefx/commit/
867c317528b0dfcebd608d10968f24320ee316ab
Omair Majid [Fri, 27 Sep 2019 21:58:00 +0000 (17:58 -0400)]
Add CentOS 8 runtime ids (dotnet/corefx#41397)
CentOS 8 has been released:
https://wiki.centos.org/Manuals/ReleaseNotes/CentOSLinux8
$ cat /etc/os-release
NAME="CentOS Linux"
VERSION="8 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="CentOS Linux 8 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:8"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-8"
CENTOS_MANTISBT_PROJECT_VERSION="8"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="8"
Commit migrated from https://github.com/dotnet/corefx/commit/
6f82bd59a05ea9556397596ae9e59f39b904b222
Stephen Toub [Fri, 27 Sep 2019 18:19:52 +0000 (14:19 -0400)]
Add some DebuggerDisplay attributes in System.Linq (dotnet/corefx#41386)
Commit migrated from https://github.com/dotnet/corefx/commit/
e667c29636a622eb4f9493f75232b44e0ae90b29
buyaa-n [Fri, 27 Sep 2019 16:41:52 +0000 (09:41 -0700)]
Annotate System.IO.Compression for nullable (dotnet/corefx#41322)
Nullable annotation for System.IO.Compression
Commit migrated from https://github.com/dotnet/corefx/commit/
967eb3c5cb5fd36c8bb56d06f4c840f6a7a5a754
Stephen Toub [Fri, 27 Sep 2019 03:22:52 +0000 (20:22 -0700)]
Remove a few initialization allocations from Cng (dotnet/corefx#41373)
Save four "startup" allocations in System.Security.Cryptography.Cng.
- Appending the '\0' is better done at the call site, because then the concat is done with two constants at compile time.
- There's no benefit to using ToCharArray instead of just passing in the string.
- Once we get rid of those, we can just inline the construction into the declarations.
Commit migrated from https://github.com/dotnet/corefx/commit/
296c0e71ddcc4885d30af18dea829c1923cfdc5c
Steve Harter [Thu, 26 Sep 2019 21:34:50 +0000 (16:34 -0500)]
Add System.Object converter sample to have semantics similar to Newtonsoft Json.NET (dotnet/corefx#41323)
Commit migrated from https://github.com/dotnet/corefx/commit/
946628c1fe463cc058db5a53723ca3867428de01
Stephen Toub [Thu, 26 Sep 2019 21:31:10 +0000 (14:31 -0700)]
Make Delegate.GetMethodInfo extension return non-nullable (dotnet/corefx#41367)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0338a64488dde44c94c843bb15df8dc21138aa9
Stephen Toub [Thu, 26 Sep 2019 21:30:31 +0000 (14:30 -0700)]
Avoid ToCharArray allocation in JsonCamelCaseNamingPolicy (dotnet/corefx#41363)
Commit migrated from https://github.com/dotnet/corefx/commit/
4cfc7ecdf44fee10b86477c67eb9c7d335cf3269
Viktor Hofer [Thu, 26 Sep 2019 21:04:43 +0000 (23:04 +0200)]
Disable S.N.Security tests on arm64 Windows (dotnet/corefx#41370)
Commit migrated from https://github.com/dotnet/corefx/commit/
4fd8e9f3dcbf7484e3cc4b2d77c649a48f1e29ac
Viktor Hofer [Thu, 26 Sep 2019 19:52:36 +0000 (21:52 +0200)]
Add Alpine 3.10 to CI (dotnet/corefx#41355)
Commit migrated from https://github.com/dotnet/corefx/commit/
ea0ff6679926b6d964347c63db7f3598d53e44f2
Adam Sitnik [Thu, 26 Sep 2019 18:51:36 +0000 (20:51 +0200)]
add more IsSuffix test cases (dotnet/corefx#41353)
Commit migrated from https://github.com/dotnet/corefx/commit/
79eb17cf22dc69ac94f900794468d998254e7bd8
Adam Sitnik [Thu, 26 Sep 2019 13:40:44 +0000 (15:40 +0200)]
StartsWith more edge cases (dotnet/corefx#41350)
* add test case for ICU-20832
* add ""o\u0000\u0308".StartsWith("o") test case
Commit migrated from https://github.com/dotnet/corefx/commit/
933f5ddb717307ea75c939058c23c16e3849176e
Viktor Hofer [Thu, 26 Sep 2019 04:53:38 +0000 (06:53 +0200)]
Update windows.yml (dotnet/corefx#41328)
Commit migrated from https://github.com/dotnet/corefx/commit/
84369a81077db9041d9d542f91b642efc4091b7d
Eric StJohn [Wed, 25 Sep 2019 23:19:34 +0000 (16:19 -0700)]
Fix DeflateStream.CopyTo for concatenated payloads (dotnet/corefx#41190)
* Fix DeflateStream.CopyTo for concatenated payloads
Support for concatenated payloads was added in dotnet/corefx@
55f2293ddda3c972fcc2d94915b03bc8556e8c9b.
With this DeflateStream will continue to attempt to read after it
encounters a payload footer if it has more data left and that data
begins with the proper header format.
This caused a bug in CopyTo where it assumed that if the inflater
returned 0 bytes inflated it was done with that buffer.
This can happen in a couple cases:
1. The footer for a payload occurs on a buffer boundary, such that the
first call to Inflate for that buffer reads only the footer and returns
0 data. This was reported by a customer.
2. One of the concatenated payloads is 0 length.
Previously the CopyTo implementation would skip the remainder of the
buffer in this case, then proceed with a new buffer. This new buffer
would start and an arbitrary offset in the compressed data, which likely
isn't a valid header, and an exception would be thrown:
```
System.IO.InvalidDataException : The archive entry was compressed using an unsupported compression method.
```
Fix this by continuing to copy so long as the we haven't run out of
data, regardless of wether or not the inflater happens to read a 0
length chunk.
* Address feedback
* Fix regression introduced in refactoring
* Apply suggestions from code review
Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
b832f6ccdebd18469e4b6d03c1c9b2c9c6c14374
Tomas Weinfurt [Wed, 25 Sep 2019 21:30:10 +0000 (14:30 -0700)]
improve stability of FileSystemWatcher tests (dotnet/corefx#40543)
* improve stability of watcher tests
* feedback from review
* more feedback
* disable parallelization for dangerous tests
* enable FileSystemWatcher_File_Create_ForceLoopRestart again
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
e8fd8931d488d2e06a25a49c0d722b67f35e10fa
Kevin Jones [Wed, 25 Sep 2019 21:09:27 +0000 (17:09 -0400)]
Implement HashAlgorithmName.FromOid and TryFromOid.
Commit migrated from https://github.com/dotnet/corefx/commit/
eda554cfbcceda02db621ab8233d1b53e653681a
Ricardo Arenas [Wed, 25 Sep 2019 20:47:17 +0000 (13:47 -0700)]
Change dependsOn Parameter when calling post-build tempalte to react to Arcade breaking change (dotnet/corefx#41318)
Commit migrated from https://github.com/dotnet/corefx/commit/
78f27e44cd74b1a6eb66401099645c6871251dfc
Jeremy Barton [Wed, 25 Sep 2019 16:32:27 +0000 (09:32 -0700)]
Exploration: Retry STATUS_UNSUCCESSFUL from CNG (dotnet/corefx#41300)
* Exploration: Retry STATUS_UNSUCCESSFUL from CNG
* Restore Array.Resize to separate changes
Commit migrated from https://github.com/dotnet/corefx/commit/
ac99a1b7168bd32046a954c3f06012c0fa909bed
Steve Harter [Wed, 25 Sep 2019 15:46:41 +0000 (10:46 -0500)]
Serializer perf improvements (dotnet/corefx#41238)
Commit migrated from https://github.com/dotnet/corefx/commit/
527595f14c6b3ee307d301ae42d68c29cad545d0
dotnet-maestro[bot] [Tue, 24 Sep 2019 23:09:05 +0000 (01:09 +0200)]
[master] Update dependencies from 4 repositories (dotnet/corefx#41216)
* Update global.json
* Disable DependentUpon convention for resources
* Update dependencies from https://github.com/dotnet/core-setup build
20190920.7
- Microsoft.NETCore.App - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19470.7
* Update dependencies from https://github.com/dotnet/corefx build
20190921.2
- runtime.native.System.IO.Ports - 5.0.0-alpha1.19471.2
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19471.2
* Cleanup netcoreapp targeting pack restore
For .NETCore2x the SDK implictily references the targeting pack via
a PackageReference so to binplace the assemblies we just need to reset
the PrivateAssets and IsImplicitlyDefined attributes.
For .NETCore >= 3 we don't need to reset any attributes on the
FrameworkReference.
We default to the version that is bundled within the SDK in the
Microsoft.NETCoreSdk.BundledVersions.props file.
* Update dependencies from https://github.com/dotnet/standard build
20190922.1
- NETStandard.Library - 2.2.0-prerelease.19472.1
* Update SDK to 3.0.100 stable
* Simplify code in netcoreapp.depproj
* Update packageIndex inbox matrix for S.R.Emit
* Manual darc update from build '
20190923.5'
Commit migrated from https://github.com/dotnet/corefx/commit/
90f7cc01418c059f496528beeca77c5f5549e6fc
Levi Broderick [Tue, 24 Sep 2019 22:09:53 +0000 (15:09 -0700)]
Add more Unicode validation tests (dotnet/corefx#41265)
* Add more Unicode validation tests
* PR feedback and add more char tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b59265f6dda8e0462f17b96d85e1356245261de9
Viktor Hofer [Tue, 24 Sep 2019 20:45:20 +0000 (22:45 +0200)]
Update windows-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
4515def03be39fe09f20d47059c9e85438d23825
oleggolovkovuss [Tue, 24 Sep 2019 19:54:36 +0000 (22:54 +0300)]
Fixing outdated method name (dotnet/corefx#41285)
.Net Core release notes lead to this sample for JSON serializing, it's using non-existent static `ToString` method though, this changes updates the docs
Commit migrated from https://github.com/dotnet/corefx/commit/
629eea822f258f8d5771b96286eba8ff8c89d997
Stephen Toub [Tue, 24 Sep 2019 19:53:19 +0000 (12:53 -0700)]
Annotate System.Threading.Tasks.Parallel for nullability (dotnet/corefx#41249)
Commit migrated from https://github.com/dotnet/corefx/commit/
0298da07f3252e645d7d9509cfd4f19615043f7a
buyaa-n [Tue, 24 Sep 2019 17:05:58 +0000 (10:05 -0700)]
Annotate System.ComponentModel.Primitives for nullable (dotnet/corefx#41185)
* Annotate System.ComponentModel.Primitives for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
da147ece700c2502b91e57d99213feadcfb9c1f0
Viktor Hofer [Tue, 24 Sep 2019 13:49:41 +0000 (15:49 +0200)]
Replace RS4 with Client19H1 in CI (dotnet/corefx#41277)
Commit migrated from https://github.com/dotnet/corefx/commit/
6549a93fb462f581696af11a3be076d36309dc7e
Viktor Hofer [Tue, 24 Sep 2019 10:46:11 +0000 (12:46 +0200)]
Disable UWP pkg publishing to fix official builds (dotnet/corefx#41279)
Commit migrated from https://github.com/dotnet/corefx/commit/
0a51b2d9b191a12768d4d1410d0c200bba558522
Stephen Toub [Tue, 24 Sep 2019 05:22:44 +0000 (22:22 -0700)]
Remove some unnecessary string concatenation from CertificatePal.AppendPrivateKeyInfo (dotnet/corefx#41274)
Commit migrated from https://github.com/dotnet/corefx/commit/
f2292af3a1794378339d6f5c8adcc0f2019a2cf9
Jeremy Barton [Tue, 24 Sep 2019 02:22:35 +0000 (19:22 -0700)]
Fix validity encoding for cert dates after 2049
During the change from the reflection serializer to asn.xslt generation we lost
the metadata that said that X.509 Time GeneralizedTime values need to ignore
fractional seconds.
That means we're generating fractional seconds when the input DateTimeOffset
has them, which means we violate RFC in our generated certificates.
Commit migrated from https://github.com/dotnet/corefx/commit/
8a65f0b14cb3f29272a18b2f6dbe4bebfd4d4177
Carlos Sanchez Lopez [Tue, 24 Sep 2019 00:10:16 +0000 (17:10 -0700)]
Remove person who left the company (dotnet/corefx#41272)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f3673cbcd0bc161c1d3d8cef531e8e57bcfcbed
Jeremy Koritzinsky [Mon, 23 Sep 2019 23:30:46 +0000 (16:30 -0700)]
Error out clearly when trying to use COM objects with the DLR. (dotnet/corefx#40075)
* Throw an exception in the dynamic binder when trying to dynamically resolve a COM object without an enabled COM binder.
* Add test for exception throw on dynamic usage with COM.
* Update test to validate the change in each binder.
* PR Feedback.
* Add missing using.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ed05b311925509d3cd4b6938d4935ca31cdaf92
Anirudh Agnihotry [Mon, 23 Sep 2019 21:01:49 +0000 (14:01 -0700)]
Removing microsoft.private.corefx.uap (dotnet/corefx#41187)
* removing microsoft.private.corefx.uap
* removing uap specific changes in ,.targets
* add uap-windowsNT
Commit migrated from https://github.com/dotnet/corefx/commit/
49ba6ef9cb8120c87eae636fc41b79e07e88e707
Charles Stoner [Mon, 23 Sep 2019 16:24:45 +0000 (09:24 -0700)]
Additional enum tests for System.Linq.Expressions.Interpreter.CallInstruction (dotnet/corefx#41218)
Commit migrated from https://github.com/dotnet/corefx/commit/
f9919e1ce5ca407f55d078af003af642c1b44d92
Krzysztof Wicher [Sat, 21 Sep 2019 16:39:04 +0000 (09:39 -0700)]
Make Add/Remove UnsignedAttribute work with counter signers
Commit migrated from https://github.com/dotnet/corefx/commit/
4c074ae47660448eae66a362076124177709640a
Stephen Toub [Fri, 20 Sep 2019 20:29:39 +0000 (16:29 -0400)]
Enable better trimming of derived XmlReader/Writer-derived types (dotnet/corefx#41235)
Commit migrated from https://github.com/dotnet/corefx/commit/
b893e604ce832ccf4e9cbcbdfe0b0ae2b23195bf
Eirik Tsarpalis [Fri, 20 Sep 2019 15:32:06 +0000 (18:32 +0300)]
HttpClientHandler functional test: replace remote server dependency (dotnet/corefx#41229)
* HttpClientHandler functional test: replace remote server dependency
Replaces remote server dependency for HttpClientHandler_MaxResponseHeadersLength_Test.SetAfterUse_Throws.
Fixes dotnet/corefx#41148
Commit migrated from https://github.com/dotnet/corefx/commit/
b020d0033ffe755f779c564186fc2d98b0af31cc
Stephen Toub [Fri, 20 Sep 2019 14:28:13 +0000 (10:28 -0400)]
Remove unnused StringExtensions.cs from a couple projects (dotnet/corefx#41211)
Commit migrated from https://github.com/dotnet/corefx/commit/
0286bce5fd360207ca707fe7024248be428cf0e9
Günther Foidl [Fri, 20 Sep 2019 13:13:35 +0000 (15:13 +0200)]
Make CryptoNative_EvpDigestUpdate count parameter int32_t instead of size_t
Shim functions should use sized types, which the size type isn't.
Commit migrated from https://github.com/dotnet/corefx/commit/
ca6add5711542ae513dcd2269146eec3c518c4b5
Maryam Ariyan [Fri, 20 Sep 2019 12:28:52 +0000 (05:28 -0700)]
Enable nullable annotations for System.Drawing.Primitives (dotnet/corefx#41188)
Commit migrated from https://github.com/dotnet/corefx/commit/
aa72982dcb20c4e346e08d72dae5abbaf6bba4f9
Adam Sitnik [Fri, 20 Sep 2019 08:18:20 +0000 (10:18 +0200)]
add StartsWith Surrogates test cases (dotnet/corefx#41227)
Commit migrated from https://github.com/dotnet/corefx/commit/
ce5dfbb9ad62f95885748c7e95ebcd3ca453d1bf
Katarzyna Bułat [Fri, 20 Sep 2019 00:47:40 +0000 (17:47 -0700)]
JsonNode options (dotnet/corefx#41030)
* JsonNodeOptions added
* review comments included
* review comments included
Commit migrated from https://github.com/dotnet/corefx/commit/
5bc2806f33090e78b38fafe4d5b46d5a0a4c1f08
buyaa-n [Fri, 20 Sep 2019 00:19:48 +0000 (17:19 -0700)]
Annotate System.Collections.Specialized for nullable (dotnet/corefx#41092)
Annotate System.Collections.NonGeneric for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
0d6adbc80b1d8262771a4db71931c4383646ff1f
Tomas Weinfurt [Thu, 19 Sep 2019 17:38:41 +0000 (10:38 -0700)]
invalidate state when directory is created (dotnet/corefx#40677)
Commit migrated from https://github.com/dotnet/corefx/commit/
a3bf1eaff8819262e9308a94a59277df95fed6b7
Maryam Ariyan [Thu, 19 Sep 2019 02:50:18 +0000 (19:50 -0700)]
Nullability annotations for System.Console (dotnet/corefx#41161)
Contributes to: dotnet/corefx#40623
Commit migrated from https://github.com/dotnet/corefx/commit/
19b304f7815894b13cb61e87e1c9eac49a474c7e
Stephen Toub [Thu, 19 Sep 2019 02:42:17 +0000 (22:42 -0400)]
Fix trimming of System.Net.NetworkInformation (dotnet/corefx#41191)
Commit migrated from https://github.com/dotnet/corefx/commit/
2f1d199cf19572dc319be344ea0905edbf318ea3
Stephen Toub [Wed, 18 Sep 2019 20:43:25 +0000 (16:43 -0400)]
Remove DEBUG-only TraceSource/Switch usage from corefx (dotnet/corefx#41177)
A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time, but some of it is keeping these types from being trimmed in a default MVC app.
Commit migrated from https://github.com/dotnet/corefx/commit/
80adc8b87163dfe77d5b4262ea7970cc2de87f46
Maryam Ariyan [Wed, 18 Sep 2019 20:35:33 +0000 (13:35 -0700)]
Update unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
2c5f652ea6a883bc032db18a8a2401db9f66f523
Maryam Ariyan [Wed, 18 Sep 2019 20:03:01 +0000 (13:03 -0700)]
Update unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
a18b1ba2cf6fb9377ccd3d4e263ea84d75c23842
Stephen Toub [Wed, 18 Sep 2019 19:29:16 +0000 (15:29 -0400)]
Fix trimming of System.Net.Ping (dotnet/corefx#41180)
It has an ILLinkTrim.xml file that was keeping a type around for testing, but that's apparently keeping the assembly from being trimmed in a published app.
Commit migrated from https://github.com/dotnet/corefx/commit/
64c7228b941d1402009c57441a5a8c634d0e6843
Jeremy Barton [Wed, 18 Sep 2019 16:37:51 +0000 (09:37 -0700)]
Fix the filename used by the VerifyCrlCache test (dotnet/corefx#41173)
The VerifyCrlCache test, which is a manual test, is looking for the old cache key.
This change updates it to the new cache key, and makes the test pass again.
Commit migrated from https://github.com/dotnet/corefx/commit/
395f42ffa645efd067fd790712b48061c0236523
Adam Sitnik [Wed, 18 Sep 2019 15:47:51 +0000 (17:47 +0200)]
improve span.StartsWith(span) test coverage (dotnet/corefx#41169)
Commit migrated from https://github.com/dotnet/corefx/commit/
b8d1e0620e6ed6355d76d118c6fa609e7f7cc049
Zach Read [Wed, 18 Sep 2019 15:31:26 +0000 (10:31 -0500)]
Allow X509Chain to replace the root trust list when building a chain
This enables users of X509Chain to specify a priori a set of trusted root authorities, which is used in place of the default root authorities.
By explicitly specifying the root authorities the caller enables revocation checking for normally untrusted roots, and simplifies the certificate acceptance by having the chain engine tell them if the root matched, vs doing a post-build check (in the case of cross-certified authorities this even tells the chain engine which path to prefer).
Commit migrated from https://github.com/dotnet/corefx/commit/
e70e76159b3f34e4e35d241daf39d4f57f4bd82c
buyaa-n [Wed, 18 Sep 2019 14:31:39 +0000 (07:31 -0700)]
Annotate System.ComponentModel for nullable (dotnet/corefx#41160)
* Annotate System.ComponentModel for nullable
* Applying feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
90870e3120f4998a70546798b02c4c903df2f4df
Santiago Fernandez Madero [Wed, 18 Sep 2019 14:31:20 +0000 (07:31 -0700)]
Remove some ActiveIssueAttributes (dotnet/corefx#41163)
Commit migrated from https://github.com/dotnet/corefx/commit/
9f4fa8c6d1b581676f24af429bc64867cb623c78
Frank Buckley [Wed, 18 Sep 2019 00:59:41 +0000 (01:59 +0100)]
Add missing tag to XML comments (dotnet/corefx#41162)
Commit migrated from https://github.com/dotnet/corefx/commit/
4ca1feeeb484e8a7089ce8a9d377703ad5b8a53e
Tarek Mahmoud Sayed [Tue, 17 Sep 2019 18:19:40 +0000 (11:19 -0700)]
Add Culture Cloning Test (dotnet/corefx#41124)
* Add Culture Cloning Test
This test to validate the calendar instances inside the culture after colning.
* Address the feedback
* More feedback addressing
* More Feedback Addressing
Commit migrated from https://github.com/dotnet/corefx/commit/
65edbb39dd737e8529a343f385d2600e482b7ff3
Stephen Toub [Tue, 17 Sep 2019 14:43:51 +0000 (10:43 -0400)]
Remove System.Net.Requests dependency from System.Private.Xml (dotnet/corefx#41111)
* Remove System.Net.Requests dependency from System.Private.Xml
Anything that uses System.Xml ends up implicitly referencing this .dll, which in a trimmed default MVC app is 97K. The only thing it's used for is as part of XmlResolver to download the specified url. We can instead remove the usage of WebRequest.Create and replace it with usage of HttpClient, which is already brought in because System.Net.Requests uses it to implement HttpWebRequest.
* Address PR feedback
And other minor cleanup. Also fix uap build.
Commit migrated from https://github.com/dotnet/corefx/commit/
f873a33056ab318c02d295f816065a3d2ad3736b
Stephen Toub [Tue, 17 Sep 2019 14:17:49 +0000 (10:17 -0400)]
Remove unused files from System.Net.Http (dotnet/corefx#41155)
Commit migrated from https://github.com/dotnet/corefx/commit/
e9836aa6bdd40d76d8cf3534e491d90421c4bd9a
Matt Galbraith [Tue, 17 Sep 2019 13:26:21 +0000 (06:26 -0700)]
Fix a typo in DictionaryImportsReceiveMetadataFromNestedAdapters test name (dotnet/corefx#41149)
Commit migrated from https://github.com/dotnet/corefx/commit/
9200a1714863e53be53dc4406f493b2ea810c291
Tomas Weinfurt [Tue, 17 Sep 2019 13:16:25 +0000 (06:16 -0700)]
improve socket timout tests (dotnet/corefx#41078)
* improve socket timout tests
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
938b24dc397e11eab8688deca71ecd13ffc6fa4a
Layomi Akinrinade [Tue, 17 Sep 2019 12:38:41 +0000 (08:38 -0400)]
Support nullable values in dictionaries (dotnet/corefx#40991)
* Support nullable values in dictionaries
* Address review feedback
* Address feedback
* Defer dictionary key escaping to writer
Commit migrated from https://github.com/dotnet/corefx/commit/
a308e93b1f1303be7eab5ce2b8ed11e66cc8e01e
Stephen Toub [Tue, 17 Sep 2019 12:20:14 +0000 (08:20 -0400)]
Remove allocations from Dns.* (dotnet/corefx#41061)
This started as an effort to reduce the size of System.Net.NameResolution.dll when publishing a trimmed app. It's not that big to begin with, but it's carrying around a copy of all of the IAsyncResult helper types, because the Get*Async methods are currently wrappers for the Begin/End* methods.
This PR inverts that, wrapping the Begin/End* methods instead around the Get*Async methods, using the same TaskToApm helper we use in other places in corefx for the same purpose. This makes the Get*Async methods faster and lighterweight, but it does increase the number/amount of allocation in the Begin/End* APIs. Since these are considered legacy, I normally would consider that a good trade, however we still use these Begin/End methods in a few places in System.Net.Sockets, and I didn't want to regress those use cases.
So, this also then trims some additional fat, which helps the Get*Async cases even further, and gets the Begin/End* to be even better than before the change. This includes not allocating an IPHostEntry when we're just going to unwrap it and return its addresses, computing the exact IPAddress[] size we need rather than using a List<> to grow it and ToArray to create the actual array, avoiding creating the HostName if we don't need it, and avoiding an unnecessary SafeHandle allocation.
As part of this, I also noticed that we had some bugs in how some of our interop structures on Windows were defined. In particular, fields that in the native types were size_t were defined as int rather than IntPtr in the managed code. It appears we were saved by padding, but I fixed it regardless.
And as long as I was changing pretty much everything else, where I was touching code I also cleaned up some legacy style stuff.
Commit migrated from https://github.com/dotnet/corefx/commit/
a55e95cbd9fca7ce5b3ad34c583642a35f42cd63
Santiago Fernandez Madero [Tue, 17 Sep 2019 05:10:48 +0000 (22:10 -0700)]
Add missing dummy types to reference assemblies (dotnet/corefx#41147)
Commit migrated from https://github.com/dotnet/corefx/commit/
4aea703673e942756c02b222e6b5babaf8612a25