platform/upstream/lapack.git
8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:40:02 +0000 (05:40 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 28/42] Fix lapacke_?gesvj - correct eval of nrows_v

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:39:23 +0000 (05:39 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 27/42] Fix lapacke_?gesvdx* - NS is reference; VU, VL are real; ...

- NS must be passed by ref
- VU and VL shall be real, not integer
- LWORK must be at least 1, even for N=0
- correct allocation of WORK, JOBU/JOBVT cannot be 'A' or 'S'
- nrows/ncols = max(...,0), zero is possible, negatives are not

fixup lapacke_?gesvdx

8 years ago[PATCH 26/42] Fix lapacke_?gejsv* correct computation of lwork.
julie [Tue, 23 Feb 2016 05:37:59 +0000 (05:37 +0000)]
[PATCH 26/42] Fix lapacke_?gejsv* correct computation of lwork.
 ISSUE: gejsv needs LQUERY

- lrwork must be max(7,...) per documentation
- iwork must be at least 3 long, and m+2n/m+3n for c/r kinds
- lwork is computed incorrectly by the init expr.
  ISSUE: ?gejsv shall implement LQUERY
- bug: rwork should be followed by lrwork, not by lwork
- bug r-major case shall compare ldu vs ncols_u, not vs n
- lwork for want_u && want_v must not depend on joba, jobt

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:36:56 +0000 (05:36 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 25/42] Fix lapacke_?gejsv - do not transpose U,V on input

- U,V are [out], so no need to transpose on input

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:35:56 +0000 (05:35 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 24/42] Fix lapacke_?gejsv - remove NaN check of U,V

- U,V are [out] and should not be checked for NaNs

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:33:18 +0000 (05:33 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 23/42] Fix lapacke_zgghd3: Use LAPACK_Z2INT, not C2INT

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:32:46 +0000 (05:32 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 22/42] Fix lapacke_?ggsvp3_work: V is p-by-p

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:31:59 +0000 (05:31 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 21/42] Fix ?GEESX documentation - typo in description of SELECT

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:31:10 +0000 (05:31 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 20/42] Fix ?BBCSD documentation - parameters U1, LDU1, etc

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:30:24 +0000 (05:30 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 19/42] Fix ?GBRFSX - do not proceed if INFO.NE.0 after ?GBCON

- and fix description of B and BERR in ZGBRFSX

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:29:31 +0000 (05:29 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 18/42] Fix ?HGEQZ documentation - use of Q depends on COMPQ, not on COMPZ

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:28:28 +0000 (05:28 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 17/42] Fix {C,Z}LAROR documentation to not corrupt doxygen output

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:27:45 +0000 (05:27 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 15/42] Fix CLA_PORCOND_C documentation: C is REAL vector, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:27:07 +0000 (05:27 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 14/42] Fix CPOTRF2 documentation: A is COMPLEX, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:26:28 +0000 (05:26 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 13/42] Fix {C,S}GBEQUB documentation: AB is {COMPLEX,REAL}, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:24:31 +0000 (05:24 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 12/42] Fix SGBRFSX documentation: AB, AFB are REAL, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:23:49 +0000 (05:23 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 11/42] Fix SLARRC documentation: VL,VU,D,E are REAL, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:21:24 +0000 (05:21 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 09/42] Fix SGGSVP3 documentation - WORK should be REAL, not DOUBLE PRECISION

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:18:01 +0000 (05:18 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

[PATCH 08/42] Fix ?BDSVDX: E is N-1 array; do not access Z when
 JOBZ.EQ.'N'

- Bug setting E(N): E is N-1 array
- Do not access Z when JOBZ.EQ.'n'
- Typos in documentation

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:14:47 +0000 (05:14 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 07/42] Fix ?GESVJ - use DLASCL for SVA, not ZLASCL

- Also list real kind ?LASCL as EXTERNAL

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:12:12 +0000 (05:12 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 06/42] Fix ???CSD2BY1 - workspace query should not pass bad LD to ???GQR/GLQ

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:09:48 +0000 (05:09 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 05/42] Fix ?LASCL2, ?LARSCL, ?LASCL documentation - correctly describe LDX

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:05:07 +0000 (05:05 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 04/42] Fix ?{HE,SY}TRF_ROOK - LQUERY shall return LWORK at least 1

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 05:02:09 +0000 (05:02 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 03/42] Fix ?GGHD3: LQUERY with N=0 shall return 1, not 0

8 years agoAdjust line length on previous commit
julie [Tue, 23 Feb 2016 05:00:21 +0000 (05:00 +0000)]
Adjust line length on previous commit

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 04:54:53 +0000 (04:54 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 02/42] Fix ?DESVDX: do not fill U/VT beyond NS, and other
 changes

- Typos and comments corrupting doxygen output
- LDVT.LT.MINMN may be acceptable when RANGE=='i'
- Bug: do not fill U and VT beyond NS
- Typo in comment: A is COMPLEX*16 for ZGESVDX

8 years agoAPPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry...
julie [Tue, 23 Feb 2016 04:51:38 +0000 (04:51 +0000)]
APPLYING INTEL PATCHES sent to Julie on Feb 19th 2016 by Dima from INTEL (dmitry.g.baksheev@intel.com)

Subject: [PATCH 01/42] Fix ?GEJSV: handle M=N=0 case correctly, amend
 documentation. ISSUE: need LQUERY

- Complex kind functions operate on complex matrices
- JOBA cannot be 'N', and we have no parameter named JOBE
- Typos like CGEJSV uses CUNMQR, not SUNMQR
- Case M=0 N=0 shall zero IWORK(1:3) and WORK(1:7) anyway (F90 syntax!)
- Comments fixed to not corrupt doxygen output
- Missing fill of IWORK(3) = 0
- Math is written from capital letter :-)
- Typos like use ZGELQF, not ZGELQ

8 years agoFix bug 155 reported by lawrence mulholland on Jan 27th 2016 on LAPACK Forum
julie [Thu, 11 Feb 2016 03:43:31 +0000 (03:43 +0000)]
Fix bug 155 reported by lawrence mulholland on Jan 27th 2016 on LAPACK Forum
Link: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?f=13&t=4892
lines 908 and 1129:
OMPQ = AAPQ / ABS(AAPQ)

need to move inside IF( ROTOK ) THEN block
that is, after lines 926 and 1142 respectively.

The variable OMPQ is only used inside these blocks and can, when rotation is unsafe,
overflow when evaluated.

8 years agoApplied patch provided by Dmitry Baksheev from Intel on Feb 9th 2016 on LAPACK Forum
julie [Thu, 11 Feb 2016 03:01:43 +0000 (03:01 +0000)]
Applied patch provided by Dmitry Baksheev from Intel on Feb 9th 2016 on LAPACK Forum
Link: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?f=13&t=4902&p=11774
Issue: ?TGSEN use of array SELECT on workspace query may SEGV
Solution: Skip use of array SELECT on workspace query

Make sense...

8 years agoFollowing post on Forum by Dmitry Baksheev (Intel) improved documentation for ?gejsv
julie [Fri, 5 Feb 2016 03:01:39 +0000 (03:01 +0000)]
Following post on Forum by Dmitry Baksheev (Intel) improved documentation for ?gejsv
Link: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?f=13&t=4896
8 years agoprotect calls with args n-1, a(2,1) against n=1 case
lawrence.mulholland [Wed, 27 Jan 2016 17:24:52 +0000 (17:24 +0000)]
protect calls with args n-1, a(2,1) against n=1 case

8 years agoEmail from Edward Smyth from NAG. (Thanks Ed!)
langou [Tue, 26 Jan 2016 18:29:16 +0000 (18:29 +0000)]
Email from Edward Smyth from NAG. (Thanks Ed!)

In calls to {D,S}BDSVDX in the test programs {d,s}chkbd.f, insufficient space
may be provided for the array Z i.e. WORK(IWBZ). The correction is to change

 IWWORK = IWBZ + MNMIN*(MNMIN*2+1)

to

 IWWORK = IWBZ + 2*MNMIN*(MNMIN+1)

on line 1146 in both files.

8 years agoReplace DFLOAT by DBLE in ZGSVJ0, ZGESVJ, and ZGSVJ1. Thanks to Edward Smyth
langou [Tue, 26 Jan 2016 18:24:57 +0000 (18:24 +0000)]
Replace DFLOAT by DBLE in ZGSVJ0, ZGESVJ, and ZGSVJ1.  Thanks to Edward Smyth
from NAG for fixing this.

Email from Ed: Several LAPACK 3.6.0 routines use the intrinsic DFLOAT which is
non-standard and thus causes problems with some compilers. Could you change
these references to DBLE please?

Julien.

8 years agoUpdating Intel Compiler flag for CMAKE build according to rev 1681
julie [Tue, 26 Jan 2016 04:00:31 +0000 (04:00 +0000)]
Updating Intel Compiler flag for CMAKE build according to rev 1681

8 years agoChange the default compilation flags for the Intel Fortran compiler.
langou [Mon, 25 Jan 2016 16:00:32 +0000 (16:00 +0000)]
Change the default compilation flags for the Intel Fortran compiler.

The LAPACK TESTING should run error free with these settings.

Previously were:
OPTS     = -O3
NOOPT    = -O3 -fltconsistency -fp_port
Now are:
OPTS     = -O3 -fp-model strict
NOOPT    = -O0 -fp-model strict

Thanks to Viswanathan Elumalai the University of Pittsburgh for reporting the
problem, Jason Riedy for suggesting to use the flags "fp-model strict" and Osni
Marques for playing with a lots of flag combinations!

8 years agoAdding support to Compaq Compiler on Windows - Contribution from Davis Vowles sent...
julie [Wed, 20 Jan 2016 15:45:15 +0000 (15:45 +0000)]
Adding support to Compaq Compiler on Windows - Contribution from Davis Vowles sent on jan 20th 2016

8 years agoCommit David fix - sent on Jan 16th 2016 directly
julie [Tue, 19 Jan 2016 05:05:15 +0000 (05:05 +0000)]
Commit David fix - sent on Jan 16th 2016 directly
Confirmed by Julie on Jan 18th 2016
Note: issue (1) was fixed in previous commit

Message from David

(1) Line 147 of SRC/zgetrf2.f contains the following code:

      EXTERNAL           ZGEMM, ZSCAL, ZLASWP, ZTRSM, ZERBLA

Inspection of the zgetrf2.f code suggests that ZERBLA on line 147 should in fact be replaced by XERBLA.

--> [JULIE] This was fixed in our SVN on Dec 7th, 2015, revision 1664

(2) Lines 444 to 447 of  TESTING\EIG\cdrvbd.f contains the following code:

      EXTERNAL           ALASVM, XERBLA, CBDT01, CBDT05, CGESDD, CGESVD,
     $                   CGESVJ, CGEJSV, CGESVDX, CLACPY, CLASET, CLATMS,
     $                   CUNT01, CUNT03

Since the length of line 445 is 73 characters the comma at the end of that line is truncated and a symbol CLATMSCUNT01 is erroneously defined. Then during linking an error is generated because this erroneously defined symbol cannot be found.

** Recommendation ** The developers reformat all code to ensure strict adherence to the standard 72 column formatting of fixed format source files. As is well known violation of this formatting rule can result in subtle undetected errors.

(3) Similar formatting errors to that in (2) have been detected in:
TESTING\EIG\zdrvbd.f (line 445)
TESTING\EIG\dchkbd.f (line 548)
TESTING\EIG\ddrvbd.f (line 407)
TESTING\EIG\derrbd.f (line 92)
TESTING\EIG\schkbd.f (line 548)
TESTING\EIG\sdrvbd.f (line 407)
TESTING\EIG\serrbd.f (line 92)

(4) Lines 103 to 104 of TESTING\EIG\cerred.f contains the following code:

      EXTERNAL           CHKXER, CGEES, CGEESX, CGEEV, CGEEVX, CGEJSV
     $                   CGESDD, CGESVD

There is a comma missing from the end of line 103. This does not result in a compilation error. Rather an invalid symbol CGEJSVCGESDD is defined which ultimately causes an error during linking.

8 years agoOops..Missing ending bracket in last commit..
julie [Tue, 19 Jan 2016 04:42:13 +0000 (04:42 +0000)]
Oops..Missing ending bracket in last commit..

8 years agoCommit interface inconsistencies fix proposed by David Vowles on Jan 18th 2016 -...
julie [Tue, 19 Jan 2016 04:37:26 +0000 (04:37 +0000)]
Commit interface inconsistencies fix proposed by David Vowles on Jan 18th 2016 - sent directly to Julie
Confirmed by Julie on Jan 18th 2016
Routines: [cz]unbdb[1234].f, [SD]ORBDB[1234].f

== First Email from David ==
I have encountered some additional errors when compiling Lapack v3.6.0 with Compaq Visual Fortran. Interestingly, these errors did not occur when compiling with Intel Visual Fortran.

File: “SRC\cunbdb1.f” Lines: 310-312

            C = SQRT( SCNRM2( P-I, X11(I+1,I+1), 1, X11(I+1,I+1),
     $          1 )**2 + SCNRM2( M-P-I, X21(I+1,I+1), 1, X21(I+1,I+1),
     $          1 )**2 )

The interface to the BLAS SCNRM2 function is SCNRM2(N,X,INCR) whereas the interfaces to the SCNRM2 function calls in “SRC\cunbdb1.f” are of the form SCNRM2(N, X1, INC1, X2, INC2).

Similar interface inconsistencies are found in the following files:
File: “SRC\cunbdb2.f” Lines: 299-300
File: “SRC\cunbdb3.f” Lines: 299-300
File: “SRC\cunbdb4.f” Lines: 347-349

The above inconsistencies between the interface of the function definition and the function call causes compilation failure of the test-function  “xeigtstc.exe”

It is unclear if function calls of the form SCNRM2(N, X1, INC1, X2, INC2) should be replaced by SCNRM2(N, X1, INC1) or if some other correction is required.

== Second Email from David: ==

By the way, I found similar interface inconsistencies in the SRC\cunbdb<n>.f subroutines for <n> = 1 to 4;
and in the SRC\<t>ORBDB<n>.f subroutines for <t> = D and S and <n> = 1 to 4.
A total of 16 subroutines are affected – the four mentioned in my previous email and the twelve mentioned here.

After changing the calls in the affected files from *NRM2(N,X1,INC1,X2,INC2) to *NRM2(N,X1,INC1)
my build for Windows x86 with Compaq Visual Fortran (CVF) completed successfully and all tests passed.
But I do await your verdict as to whether the proposed modification to the function calls is correct.

If I understand correctly STDCALL is the default calling mechanism for the CVF compiler whereas for
the (Intel Visual Fortran) IVF compiler it is the C calling convention. I wonder if this difference
in calling convention explains why the affected test programs compile and link with IVF but fail to link with CVF.

8 years agoFix typos reported by Elena
julie [Wed, 13 Jan 2016 03:02:36 +0000 (03:02 +0000)]
Fix typos reported by Elena

8 years agoFix typos reported by Elena
julie [Wed, 13 Jan 2016 03:01:05 +0000 (03:01 +0000)]
Fix typos reported by Elena

8 years agofixing typo reported by Elena Ivanova (Oracle) to Julie on Jan 11th 2016
julie [Wed, 13 Jan 2016 02:48:53 +0000 (02:48 +0000)]
fixing typo reported by Elena Ivanova (Oracle) to Julie on Jan 11th 2016

8 years agoCommitting Christoph Conrads patch sent on Jan 11th on LAPACK Mailing List
julie [Tue, 12 Jan 2016 05:37:08 +0000 (05:37 +0000)]
Committing Christoph Conrads patch sent on Jan 11th on LAPACK Mailing List

From Christoph:
after the changes of the Doxygen config file in SVN revisions 1625
and 1626, routines are grouped together in the documentation, e.g., all
eigenvalue solvers for symmetric matrices in double precision.
Currently, the documentation for all routines in one group is put on
the same HTML page. I find this confusing and it slows my browser.

If every function has its own HTML page, then you can jump to the top
of the page by pressing POS1 to see the function arguments and their
description. Also you can jump to the bottom of the page with END to
see the callgraph of the respective function.

The patch in the attachment enables the SEPARATE_MEMBER_PAGES option
that puts each function documentation on its own HTML page. Please
consider applying this patch.

8 years agoCommitting Sébastien Villemot patches (5) sent on Jan 6th 2016 to LAPACK Mailing...
julie [Fri, 8 Jan 2016 03:07:42 +0000 (03:07 +0000)]
Committing Sébastien Villemot patches (5) sent on Jan 6th 2016 to LAPACK Mailing list

From Sébastien Villemot:
I attach to this message 5 patches that are currently applied to the
Debian package for LAPACK, and that I think could be usefully merged in
the LAPACK SVN tree.

The patches include fixes for old outstanding bugs in the CBLAS test
programs, fixes for the build system, and fixes for various typos.

Each patch file contains a more detailed description of its purpose.

8 years ago( remove unused COMPLEX*16 variable T )
langou [Tue, 5 Jan 2016 02:25:35 +0000 (02:25 +0000)]
( remove unused COMPLEX*16 variable T )
( see email from Berend Hasselman on 01/04/2016 )

8 years agoFrom Eugene Chereshnev, see: http://icl.cs.utk.edu/lapack-forum/posting.php?t=4867
langou [Thu, 17 Dec 2015 16:58:03 +0000 (16:58 +0000)]
From Eugene Chereshnev, see: icl.cs.utk.edu/lapack-forum/posting.php?t=4867

8 years agoPatch from Andreas Noack (MIT).
langou [Thu, 10 Dec 2015 03:08:12 +0000 (03:08 +0000)]
Patch from Andreas Noack (MIT).

The code for DGEEV was checking the INFO parameter returned by DHSEQR as
    IF( INFO.GT.0 )THEN "QUIT"

Andreas proposed to check
    IF( INFO.NE.0 )THEN "QUIT"

I am fine with the modification. Not terribly excited but fine.

There is really no reason for the case ( INFO.LT.0 ) to happen, so we should
not have to deal with this case.  If this happen, it is really a bug and we
should be notified.  But, at this point, why not.

I applied the proposed patch to xGEEV and xGEEVX.

Julien.

8 years agoBug reported by Tracey Brendan. Thanks Tracey.
langou [Thu, 10 Dec 2015 02:52:46 +0000 (02:52 +0000)]
Bug reported by Tracey Brendan. Thanks Tracey.
See: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4863

8 years agoBug reported by Tracey Brendan. Thanks Tracey.
langou [Thu, 10 Dec 2015 02:42:34 +0000 (02:42 +0000)]
Bug reported by Tracey Brendan. Thanks Tracey.
See: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4862

8 years agoFix comment to match the code.
luszczek [Thu, 10 Dec 2015 00:19:18 +0000 (00:19 +0000)]
Fix comment to match the code.

8 years agoMoving variable declaration up...seems to cause problem with certain compilers..Windows
julie [Tue, 8 Dec 2015 06:48:18 +0000 (06:48 +0000)]
Moving variable declaration up...seems to cause problem with certain compilers..Windows

8 years agoFix typos in routine declaration
julie [Tue, 8 Dec 2015 06:40:25 +0000 (06:40 +0000)]
Fix typos in routine declaration

8 years agoQ doesn't need to be set when vect == v, so no need to check for nan
mfaverge [Thu, 3 Dec 2015 18:00:07 +0000 (18:00 +0000)]
Q doesn't need to be set when vect == v, so no need to check for nan

8 years agoZ doesn't need to be set when vect == v, so no need to check for nan
mfaverge [Thu, 3 Dec 2015 17:58:40 +0000 (17:58 +0000)]
Z doesn't need to be set when vect == v, so no need to check for nan

8 years agooops . . .
langou [Mon, 30 Nov 2015 03:25:19 +0000 (03:25 +0000)]
oops . . .

this is related to commit r1654.

In commit r1654, I fixed the error parameter in GESVDX to be 17 when LDVT is
invalid, I should also have changed the test suite.  Both the code and the test
suite were incorrect.

Between r1654 and r1659, LAPACK error testing were returning 4 errors because
of this.

Fixed.

Julien.

8 years agoaddress bug comment from Martin Köhler ( Max Planck Institute for Dynamics of Complex...
langou [Mon, 30 Nov 2015 03:13:55 +0000 (03:13 +0000)]
address bug comment from Martin Köhler ( Max Planck Institute for Dynamics of Complex Technical Systems )
sent to lapack mailing list on Nov 29th at 7:26pm: "Bug in xGETC2"
email of Martin Köhler below

(1) add a quick return for N=0

(2) add a quick return for N=1

(3) no one reviewed this fix, feel free to comment

Dear LAPACK people,

I found a bug concerning the following function:

The xGETC2 is the level-2 BLAS implementation of an LU decomposition
with complete pivoting. Thereby, a "comparison depending on an
uninitialized value" appears if the input is an one-by-one matrix.
Namely the code in line 202 (LAPACK 3.5.0):
    IF( ABS( A( N, N ) ).LT.SMIN ) THEN
accesses SMIN which is set in the previous DO loop. This loop is
only called if N > 1 and so SMIN is not set to a well defined value
if N = 1. But the documentation claims that all matrix N>=0 are
allowed. Furthermore if calling with N = 0 the quick return
statement is missing and the evaluation of ABS(A(N,N)) then yields
an out-of-bound memory violation.

These bug affect the real and the double precision code as well
as their complex counterparts from LAPACK 3.0 up to the current
LAPACK 3.6.

regards,
Martin Köhler

8 years agominor: use of TABS instead of SPACES in one line of these two files
langou [Mon, 30 Nov 2015 02:45:36 +0000 (02:45 +0000)]
minor: use of TABS instead of SPACES in one line of these two files

8 years agoFix bug on [sd]lantr which don't report the result
mfaverge [Wed, 25 Nov 2015 14:37:14 +0000 (14:37 +0000)]
Fix bug on [sd]lantr which don't report the result

8 years agooops, change some C to Z in the Z routines
langou [Sun, 22 Nov 2015 20:36:04 +0000 (20:36 +0000)]
oops, change some C to Z in the Z routines

8 years agoCorrect workspace computation for [CZ]GESVDX when a workspace query is done
langou [Sun, 22 Nov 2015 20:34:02 +0000 (20:34 +0000)]
Correct workspace computation for [CZ]GESVDX when a workspace query is done

This is a bug report and a bug fix from Lawrence Mulholland from NAG.

Thanks Lawrence!

Also add a variable ITEMPR to index the real workspace RWORK as opposed to
using ITEMP. ITEMP is for complex workspace WORK, while ITEMPR is for the real
workspace RWORK. Sounds good.

Thanks Lawrence!

See http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4851

9 years agoCorrect workspace computation for [s/d]gesvdx.f
langou [Sat, 21 Nov 2015 04:55:02 +0000 (04:55 +0000)]
Correct workspace computation for [s/d]gesvdx.f
See thread: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4850
From Lawrence Mulholland (NAG)
Thanks Lawrence!

9 years agoCorrect the INFO parameter value when LVT is not correct. (LDVT is 17th
langou [Fri, 20 Nov 2015 22:26:43 +0000 (22:26 +0000)]
Correct the INFO parameter value when LVT is not correct.  (LDVT is 17th
argument and not 16th.)

Thanks to Lawrence Mulholland from NAG.  See:
http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4851

9 years agoCommit patch submitted by Orion Poplawski on Nov 18th 2015 on LAPACK mailing List
julie [Thu, 19 Nov 2015 05:47:49 +0000 (05:47 +0000)]
Commit patch submitted by Orion Poplawski on Nov 18th 2015 on LAPACK mailing List

Fix: properly avoid setting the install rpath when installing to system directories.

9 years agoFix typo
julie [Wed, 18 Nov 2015 15:37:25 +0000 (15:37 +0000)]
Fix typo

9 years agoFix upper case issue in CMakeLists reported by Julien Shueller on Nov 17th to Julie
julie [Wed, 18 Nov 2015 06:04:24 +0000 (06:04 +0000)]
Fix upper case issue in CMakeLists reported by Julien Shueller on Nov 17th to Julie

In CBLAS/CMakeLists.txt:

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/CMAKE/cblas-config-version.cmake.in
 ${LAPACK_BINARY_DIR}/cblas-config-version.cmake @ONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/CMAKE/cblas-config-build.cmake.in
 ${LAPACK_BINARY_DIR}/cblas-config.cmake @ONLY)

The /CMAKE subdirectory should be lowercase, I guess some work on OSX which (still!) has a case-insensitive file-system.

9 years agoCommit fix proposed by Julien Schueller
julie [Tue, 17 Nov 2015 05:05:55 +0000 (05:05 +0000)]
Commit fix proposed by Julien Schueller
Sent to LAPACK mailing list on Nov 16th 2015

 spotted a minor inconsistency in the lapacke cmake config files install directory location.

in CMakeLists.txt:

install(FILES
 ${LAPACK_BINARY_DIR}/CMakeFiles/lapack-config.cmake
 ${LAPACK_BINARY_DIR}/lapack-config-version.cmake
 DESTINATION ${LIBRARY_DIR}/cmake/lapack-${LAPACK_VERSION}
 )

in LAPACKE/CMakeLists.txt:

install(FILES
 ${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/lapacke-config.cmake
 ${LAPACK_BINARY_DIR}/lapacke-config-version.cmake
 DESTINATION lib/cmake/lapacke-${LAPACK_VERSION}
 )

So lapack-config.cmake and lapacke-config-version.cmake could be installed in different directories in cases where CMAKE_INSTALL_LIBDIR is not set to "lib", eg Fedora or RHEL.

I propose to fix LAPACKE/CMakeLists.txt:
sed -i "s|DESTINATION lib/cmake/lapacke|DESTINATION \${LIBRARY_DIR}/cmake/lapacke|g" LAPACKE/CMakeLists.txt

9 years agoThanks to Lawrence Mulholland from NAG for improving the newly released complex
langou [Mon, 16 Nov 2015 23:48:28 +0000 (23:48 +0000)]
Thanks to Lawrence Mulholland from NAG for improving the newly released complex
Jacobi SVD, and thanks to Zlatko Drmac for following so fast and improving the
code.  See: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4844
for more information about all this. Julien.

9 years agoMistake in computation of workspace for ZGGEV3. When calling ZHGEQZ the
langou [Mon, 16 Nov 2015 15:17:44 +0000 (15:17 +0000)]
Mistake in computation of workspace for ZGGEV3.  When calling ZHGEQZ the
penultimate argument should be RWORK and not WORK.  Easy to fix, not a big big
deal but some compilers might legitimatley complain.

Reported by Pavel Holoborodko on Mon Nov 16 2015. See:
http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4796
Thanks Pavel!

Julien.

9 years agoFix typo
julie [Sun, 15 Nov 2015 21:29:03 +0000 (21:29 +0000)]
Fix typo

9 years agoUpdating Docyfile for manpages
julie [Sun, 15 Nov 2015 21:07:31 +0000 (21:07 +0000)]
Updating Docyfile for manpages

9 years agoMissing parameter definition
julie [Sun, 15 Nov 2015 21:06:49 +0000 (21:06 +0000)]
Missing parameter definition

9 years agoUpdating version number
julie [Sun, 15 Nov 2015 20:33:40 +0000 (20:33 +0000)]
Updating version number

9 years agoadding the GETRF2 and POTRF2 from LAPACKE to CMAKE
langou [Sun, 15 Nov 2015 19:19:56 +0000 (19:19 +0000)]
adding the GETRF2 and POTRF2 from LAPACKE to CMAKE

9 years agoadding xGETRF2 to LAPACKE
langou [Sun, 15 Nov 2015 19:17:09 +0000 (19:17 +0000)]
adding xGETRF2 to LAPACKE

9 years agoadding xPOTRF2 to LAPACKE
langou [Sun, 15 Nov 2015 19:03:17 +0000 (19:03 +0000)]
adding xPOTRF2 to LAPACKE

9 years agoadding end bracket...now looks better
julie [Sun, 15 Nov 2015 18:00:34 +0000 (18:00 +0000)]
adding end bracket...now looks better

9 years agoremoving extra bracket
julie [Sun, 15 Nov 2015 17:56:10 +0000 (17:56 +0000)]
removing extra bracket

9 years agoAdding potrf2 and getrf2 to CMakefile
julie [Sun, 15 Nov 2015 17:43:25 +0000 (17:43 +0000)]
Adding potrf2 and getrf2 to CMakefile

9 years agointegration of xGETRF2
langou [Sun, 15 Nov 2015 17:15:57 +0000 (17:15 +0000)]
integration of xGETRF2

9 years agointegration of xPOTRF2
langou [Sun, 15 Nov 2015 16:49:46 +0000 (16:49 +0000)]
integration of xPOTRF2

9 years agoAdd the missing CONJG ...
julie [Sun, 15 Nov 2015 02:50:39 +0000 (02:50 +0000)]
Add the missing CONJG ...

TESTINGS are all good now!

9 years agoAdding CGESVJ/ZGESVJ and CGEJSV/ZGESVJ to the testing suite
julie [Sun, 15 Nov 2015 02:19:18 +0000 (02:19 +0000)]
Adding CGESVJ/ZGESVJ and CGEJSV/ZGESVJ to the testing suite

Note: TEST 15 and 19 (xBDT01  - | A - U diag(S) VT | / ( |A| max(M,N) ulp )  are not passing the threshold
      TEST 15 and 19 are commented until we find the fix

9 years agoFix cast...
julie [Sat, 14 Nov 2015 06:40:57 +0000 (06:40 +0000)]
Fix cast...

9 years agoAdding *esvdx and *bdsvdx to LAPACKE
julie [Sat, 14 Nov 2015 06:30:55 +0000 (06:30 +0000)]
Adding *esvdx and *bdsvdx to LAPACKE

*** NEED REVIEW ***

9 years agoSee: http://icl.utk.edu/lapack-forum/viewtopic.php?t=4830
langou [Fri, 13 Nov 2015 18:03:21 +0000 (18:03 +0000)]
See: icl.utk.edu/lapack-forum/viewtopic.php?t=4830

The variables NDIV, NITER and NFAIL are INOUT.  These variables have to be
initialized (e.g., in LASQ2) before callin LASQ3.  LASQ3 increments these
counters.  These counters do not play a role in the algorithm; they just give
statistics.) Thanks to Tracey Brendan for the report.

9 years agoAdding *gesvj and *gejsv to LAPACKE
julie [Fri, 13 Nov 2015 07:41:33 +0000 (07:41 +0000)]
Adding *gesvj and *gejsv to LAPACKE

9 years agoUpdate Doxyfile... one more
julie [Thu, 12 Nov 2015 15:15:07 +0000 (15:15 +0000)]
Update Doxyfile... one more

9 years agoUpdate Doxyfile
julie [Thu, 12 Nov 2015 15:09:31 +0000 (15:09 +0000)]
Update Doxyfile

9 years ago Rook with 2 o , not 3...
julie [Wed, 11 Nov 2015 06:28:29 +0000 (06:28 +0000)]
 Rook with 2 o , not 3...

9 years agoCommitting patch submitted by Christopher Conrad on Sept 25th 2015
julie [Wed, 11 Nov 2015 06:20:49 +0000 (06:20 +0000)]
Committing patch submitted by Christopher Conrad on Sept 25th 2015

From Christopher:
I noticed the following errors in the documentation and attached
patches for all of them:
- Sometimes the function name in the docstring \brief does not match the
actual function name (ex: xSYGV*).
- According to the documentation, xLAHRD is obsolete but not deprecated.
- The parameter N in xLA(R)SCL2 is not the number of columns of D.

Also, I updated the Doxyfile (doxygen -u DOCS/Doxyfile) and removed
the missing DOT_FONTNAME to get rid of the Doxygen warnings.

9 years agoAdding xlapmt to LAPACKE ( continue ) .. forgot to save the include file
julie [Wed, 11 Nov 2015 05:52:56 +0000 (05:52 +0000)]
Adding xlapmt to LAPACKE ( continue ) .. forgot to save the include file

9 years agoAdding xlapmt to LAPACKE
julie [Wed, 11 Nov 2015 05:40:19 +0000 (05:40 +0000)]
Adding xlapmt to LAPACKE

9 years agoFix cast for lwork in complex [cz]uncsd2by1 routines
julie [Wed, 11 Nov 2015 05:13:21 +0000 (05:13 +0000)]
Fix cast for lwork in complex [cz]uncsd2by1 routines

9 years agoIncorporating DBDSVDX tests in dchkbd
julie [Wed, 11 Nov 2015 03:35:02 +0000 (03:35 +0000)]
Incorporating DBDSVDX tests in dchkbd

Disabling temporarily some [SD]BDSVDX tests - those generate some numerical errors
See email from Osni on Nov 10th 2015

9 years agoAdding routines to Makefile / CMakefile.txt
julie [Mon, 9 Nov 2015 00:13:42 +0000 (00:13 +0000)]
Adding routines to Makefile / CMakefile.txt

9 years agoCommitting Zlatko Drmac Contribution
julie [Mon, 9 Nov 2015 00:10:27 +0000 (00:10 +0000)]
Committing Zlatko Drmac Contribution

9 years agoFirst commit for Zlatko Drmac Contribution - Fixing z precisions issues + modif sent...
julie [Sun, 8 Nov 2015 23:42:08 +0000 (23:42 +0000)]
First commit for Zlatko Drmac Contribution - Fixing z precisions issues + modif sent by Zlatko

9 years agoFirst commit for Zlatko Drmac Contribution
julie [Sun, 8 Nov 2015 23:24:14 +0000 (23:24 +0000)]
First commit for Zlatko Drmac Contribution

Contains only source code with Doxygen format and Makefile modifications for
CGESVJ (Jacobi SVD) with its dependencies: CGSVJ0 and CGSVJ1.

TO DO:
  - Include Testing
  - LAPACKE interface

9 years agoChange DBLE cast by REAL - confirmed with Osni
julie [Fri, 6 Nov 2015 01:16:19 +0000 (01:16 +0000)]
Change DBLE cast by REAL - confirmed with Osni

9 years agoThanks to Lawrence Mulholland (NAG) for reporting the problem. While the array
langou [Wed, 4 Nov 2015 19:54:31 +0000 (19:54 +0000)]
Thanks to Lawrence Mulholland (NAG) for reporting the problem.  While the array
E should really be of size N-1, xSYCONV() is not ready for this and so, in the
comment at the header level, we now require E to be of size N. Also xSYTRS2()
is using E(N) = ZERO, so if we make E of size N-1 in xSYCONV(), then we need to
see the impact on xSYTRS2().  This is long term cleaning, so for now, we revert
back to requesting an array E of size N. Thanks Lawrence for noticing this.