Alexander Larsson [Mon, 16 Apr 2012 08:16:04 +0000 (10:16 +0200)]
Add GDBusDAaemon, an implementation of a message bus
This is mostly complete, sans support for activation. However, its
not as picky as the libdbus implementation in terms like validation
and limits checking, nor is it as tested.
Its can be useful to test gdbus if dbus-daemon is not availible, but
its main reason for existance is to implement a default session bus
on win32 so that e.g. GApplication is guaranteed to work.
Benjamin Otte [Fri, 20 Apr 2012 12:31:05 +0000 (14:31 +0200)]
resourcefile: Set display name
Fixes resource filenames not being printed in CSS warnings for GTK.
https://bugzilla.gnome.org/show_bug.cgi?id=674345
Matthias Clasen [Thu, 19 Apr 2012 21:13:52 +0000 (17:13 -0400)]
More beautiful fix
A comma on a line by itself is too ugly to stand.
Matthias Clasen [Thu, 19 Apr 2012 21:06:49 +0000 (17:06 -0400)]
Bump version to 2.33.1
This avoids triggering the 'too new' warning from 2.34 API.
Alexander Larsson [Thu, 19 Apr 2012 18:46:08 +0000 (20:46 +0200)]
Fix non-win32 build error in my recent commit
Matthias Clasen [Thu, 19 Apr 2012 17:25:26 +0000 (13:25 -0400)]
Revert "tests: fix test on windows"
This reverts commit
79361eede240e9591891290c22cd072ccddb78a3.
Just commenting out a test without an explanation does not
look right to me. This needs at the minimum a link to a
bug report or an explanation for why the behaviour is platform
dependent. If the test was just wrong, it needs to be removed,
not commented out. If there is a bug in the win32 implementation,
it needs to be fixed.
Alexander Larsson [Thu, 19 Apr 2012 16:12:23 +0000 (18:12 +0200)]
Tests: Move dbus specific tests to if HAVE_DBUS_DAEMON
These used to only be built on unix, but if you have dbus-daemon on
win32 we should really build them there too.
Alexander Larsson [Thu, 19 Apr 2012 16:11:47 +0000 (18:11 +0200)]
Fix test building on win32
Alexander Larsson [Thu, 19 Apr 2012 11:49:52 +0000 (13:49 +0200)]
GTestDBus: Make work on win32
Win32 doesn't have things like fork so the existing code has no way
of working. Instead we swap it all out for a custom implementation
on win32.
Andoni Morales Alastruey [Thu, 19 Apr 2012 13:02:34 +0000 (15:02 +0200)]
tests: fix test on windows
Andoni Morales Alastruey [Thu, 19 Apr 2012 13:12:48 +0000 (15:12 +0200)]
test: only check for defined errors
Alexander Larsson [Wed, 18 Apr 2012 14:24:44 +0000 (16:24 +0200)]
Remove ununsed include
Alexander Larsson [Tue, 17 Apr 2012 13:50:53 +0000 (15:50 +0200)]
gdbus: Escape nonce files in dbus addressess
Otherwise the colon in c:\blah made for trouble
Alexander Larsson [Tue, 17 Apr 2012 13:50:01 +0000 (15:50 +0200)]
Fix build on win32
Some errnos don't exist on win32
Alexander Larsson [Mon, 16 Apr 2012 08:18:44 +0000 (10:18 +0200)]
Fix race in gdbus-connection test
We need to flush the AddMatches before even connecting to the bus, or we
risk missing the NameOwnerChanged from the new connections.
Alexander Larsson [Mon, 16 Apr 2012 07:55:29 +0000 (09:55 +0200)]
Support initial underscores in dbus codegen namespace
Before these were considered lowercase and thus got duplicated.
Xavier Claessens [Wed, 18 Apr 2012 21:28:17 +0000 (23:28 +0200)]
Use GTestDBus in all GDBus unit tests
To make port easier, this rewrites dbus-sessionbus.c using a
GTestDBus singleton internally.
https://bugzilla.gnome.org/show_bug.cgi?id=672985
Xavier Claessens [Wed, 18 Apr 2012 21:21:13 +0000 (23:21 +0200)]
Add GTestDBus object
This is a helper to write unit tests using a private dbus-daemon.
https://bugzilla.gnome.org/show_bug.cgi?id=672985
Xavier Claessens [Fri, 6 Apr 2012 12:51:09 +0000 (14:51 +0200)]
Add private _g_bus_get_singleton_if_exists() function
This is used by g_test_dbus_down() to ensure the GDBusConnection
gets disposed, but not create one if the singleton already got
disposed.
https://bugzilla.gnome.org/show_bug.cgi?id=672985
David Zeuthen [Wed, 18 Apr 2012 17:48:27 +0000 (13:48 -0400)]
Revert "Add a private copy of gio/tests/gdbus-tests.c,h to gio/"
This reverts commit
07bbc87615c6c0d6a525f40c2bffad2c11e400d2.
David Zeuthen [Wed, 18 Apr 2012 17:48:09 +0000 (13:48 -0400)]
Revert "Add private _g_bus_get_singleton_if_exists() function"
This reverts commit
f8a8e9039889c090fb3323e195730b9e460396e4.
David Zeuthen [Wed, 18 Apr 2012 17:47:51 +0000 (13:47 -0400)]
Revert "Add GTestDBus object"
This reverts commit
1b5f70b5b035019ba28da6a5db6eff8122e17ae7.
David Zeuthen [Wed, 18 Apr 2012 17:33:00 +0000 (13:33 -0400)]
GMenuModel: Don't leak GDBusConnection in test
See https://bugzilla.gnome.org/show_bug.cgi?id=672985#c89
Signed-off-by: David Zeuthen <davidz@redhat.com>
Xavier Claessens [Wed, 18 Apr 2012 06:50:07 +0000 (08:50 +0200)]
Add GTestDBus object
This is a helper to write unit tests using a private dbus-daemon.
session_bus_up/down() are now just wrappers around a GTestDBus singleton.
https://bugzilla.gnome.org/show_bug.cgi?id=672985
Xavier Claessens [Fri, 6 Apr 2012 12:51:09 +0000 (14:51 +0200)]
Add private _g_bus_get_singleton_if_exists() function
This is used by g_test_dbus_down() to ensure the GDBusConnection
gets disposed, but not create one if the singleton already got
disposed.
https://bugzilla.gnome.org/show_bug.cgi?id=672985
Xavier Claessens [Tue, 17 Apr 2012 17:33:11 +0000 (19:33 +0200)]
Add a private copy of gio/tests/gdbus-tests.c,h to gio/
https://bugzilla.gnome.org/show_bug.cgi?id=672985
Kjartan Maraas [Wed, 18 Apr 2012 07:27:04 +0000 (09:27 +0200)]
Updated Norwegian bokmål translation
Alexandre Rostovtsev [Mon, 16 Apr 2012 02:57:25 +0000 (22:57 -0400)]
Do not detect GNUstep as Cocoa
GNUstep also installs Foundation/Foundation.h
https://bugzilla.gnome.org/show_bug.cgi?id=674172
Signed-off-by: William Hua <william@attente.ca>
William Hua [Wed, 18 Apr 2012 03:49:47 +0000 (23:49 -0400)]
Use Cocoa header for Cocoa test instead of Foundation.
David Zeuthen [Tue, 17 Apr 2012 21:51:01 +0000 (17:51 -0400)]
gdbus-codegen: Don't leak stuff in tests
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 17 Apr 2012 21:50:40 +0000 (17:50 -0400)]
GDBusObjectProxy: Don't leak connection
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 17 Apr 2012 21:48:08 +0000 (17:48 -0400)]
GDBusObjectManagerClient: Don't leak object proxy when handling D-Bus signal
It's g_object_unref(), not g_object_ref(). Ugh.
Therefore, use g_clear_object().
Signed-off-by: David Zeuthen <davidz@redhat.com>
Piotr Drąg [Tue, 17 Apr 2012 17:48:59 +0000 (19:48 +0200)]
Updated POTFILES.in
Dan Winship [Sat, 4 Feb 2012 21:46:29 +0000 (16:46 -0500)]
gio: use GPollable* to implement fallback read_async/write_async
If a GInputStream does not provide a read_async() implementation, but
does implement GPollableInputStream, then instead of doing
read-synchronously-in-a-thread, just use
g_pollable_input_stream_read_nonblocking() and
g_pollable_input_stream_create_source() to implement an async read in
the same thread. Similarly for GOutputStream.
Remove a bunch of existing read_async()/write_async() implementations
that are basically equivalent to the new fallback method.
https://bugzilla.gnome.org/show_bug.cgi?id=673997
Dan Winship [Mon, 6 Feb 2012 20:08:08 +0000 (15:08 -0500)]
gio: implement GPollableInput/OutputStream in more stream types
Implement GPollableInputStream in GMemoryInputStream and
GConverterInputStream, and likewise implement GPollableOutputStream in
the corresponding output streams.
https://bugzilla.gnome.org/show_bug.cgi?id=673997
Dan Winship [Sat, 11 Feb 2012 22:22:49 +0000 (17:22 -0500)]
gpollableutils: utility functions for pollable stream implementations
Move g_pollable_source_new() here from gpollableinputstream.c, add
g_pollable_source_new_full(), and add some new methods to do either
blocking or nonblocking reads depending on a boolean argument.
https://bugzilla.gnome.org/show_bug.cgi?id=673997
Dan Winship [Sun, 1 Apr 2012 18:47:19 +0000 (14:47 -0400)]
gio: minor GPollableInputStream / GPollableOutputStream fixes
Make g_pollable_input_stream_read() and
g_pollable_output_stream_write() look a little bit more like the
non-pollable versions in terms of error handling, etc. Also, use the
read_fn and write_fn virtual methods directly rather than calling
g_input_stream_read()/g_output_stream_write(), to avoid problems with
re-entrancy involving the "pending" flag.
Also belatedly add single-include guards to the header files.
https://bugzilla.gnome.org/show_bug.cgi?id=673997
Dan Winship [Tue, 17 Apr 2012 15:46:50 +0000 (11:46 -0400)]
GConverterInputStream: fix an infinite loop when fill_buffer returns an error
The loop was using a GConverterResult variable where it meant to use a
gssize, and since GConverterResult was ending up as an unsigned type,
this meant the (res < 0) check always failed.
Hannes Mueller [Sat, 4 Feb 2012 09:06:35 +0000 (10:06 +0100)]
avoid warning in gutils.h when using gcc with -Wconversion
Old solution to avoid warning with gcc flag -Wconversion does not
work with gcc >=4.3 since the behaviour for that flag has been
changed, ref. http://gcc.gnu.org/wiki/NewWconversion. Now cast for
__builtin_clzl is required, which itself is declared to return int.
https://bugzilla.gnome.org/show_bug.cgi?id=619026
Sasi Bhushan [Tue, 17 Apr 2012 10:15:05 +0000 (15:45 +0530)]
Updated Telugu Translation
Alexander Shopov [Tue, 17 Apr 2012 03:28:41 +0000 (06:28 +0300)]
Updated Bulgarian translation
Fran Diéguez [Mon, 16 Apr 2012 23:11:08 +0000 (01:11 +0200)]
Updated Galician translations
Christian Persch [Thu, 17 Nov 2011 14:18:50 +0000 (15:18 +0100)]
gdbus-codegen: Avoid warnings in generated code
Initialising a "gchar *" struct member from a string literal may produce
a warning; add an explicit cast to fix that.
Bug #664275.
Christian Persch [Mon, 9 Apr 2012 13:34:10 +0000 (15:34 +0200)]
resources: compiler: Fix resources on big endian architectures
Resources are always little endian, so the gvdb is byteswapped. When looking
up the value, it would return a new byteswapped variant, making the data
returned from do_lookup() invalid once that variant is unref'd. Since
byteswapping doesn't matter for the "ay" data anyway, just use
gvdb_table_get_raw_value() instead and only byteswap the length and flag
values.
https://bugzilla.gnome.org/show_bug.cgi?id=673409
Wolfgang Stöggl [Mon, 16 Apr 2012 20:37:30 +0000 (22:37 +0200)]
[l10n] Updated German translation
Matej Urbančič [Mon, 16 Apr 2012 20:24:41 +0000 (22:24 +0200)]
Updated Slovenian translation
Piotr Drąg [Mon, 16 Apr 2012 19:19:23 +0000 (21:19 +0200)]
Updated Polish translation
Colin Walters [Mon, 16 Apr 2012 17:55:02 +0000 (13:55 -0400)]
tests: Fix race conditions in mainloop/invoke test
1) The test was using GCond incorrectly (it always needs a
state variable)
2) The state assertion was racing with the thread; just delete it.
All we're really trying to test here is that the invoke runs by the
time the thread is gone, and the function has an assertion that
it runs in the correct thread.
https://bugzilla.gnome.org/show_bug.cgi?id=674213
Colin Walters [Mon, 16 Apr 2012 15:50:05 +0000 (11:50 -0400)]
tests/mainloop: Add a test for recursive child sources
https://bugzilla.gnome.org/show_bug.cgi?id=669260
Dan Winship [Fri, 13 Apr 2012 15:44:34 +0000 (11:44 -0400)]
tests/mainloop: add a test for child sources
https://bugzilla.gnome.org/show_bug.cgi?id=669260
Dan Winship [Wed, 11 Apr 2012 19:21:17 +0000 (15:21 -0400)]
gmain: block child sources when blocking the parent
When blocking a source that has child sources, we need to consider the
children blocked as well. Otherwise they will still trigger repeatedly
in an inner loop started from the parent source's callback.
https://bugzilla.gnome.org/show_bug.cgi?id=669260
Kalev Lember [Sat, 14 Apr 2012 12:48:13 +0000 (15:48 +0300)]
Only build gmenumodel test on unix
It depends on gdbus-sessionbus.c which only builds on unix.
Kalev Lember [Sat, 14 Apr 2012 12:40:17 +0000 (15:40 +0300)]
tests/fileutils: Fix Windows build
Chandan Kumar (ciypro) [Mon, 16 Apr 2012 15:20:21 +0000 (20:50 +0530)]
Updated HINDI translation
Cosimo Cecchi [Mon, 16 Apr 2012 14:45:12 +0000 (10:45 -0400)]
tests/date: force English locale running the GDateTime tests
The parsing test needs to make some assumption about the locale
representation of the string to be parsed, so we need to explicitly
override the locale here.
Daniel Mustieles [Mon, 16 Apr 2012 14:31:29 +0000 (16:31 +0200)]
Updated Spanish translation
Petr Kovar [Mon, 16 Apr 2012 13:57:21 +0000 (15:57 +0200)]
Update Czech translation
Stef Walter [Wed, 4 Apr 2012 15:13:10 +0000 (17:13 +0200)]
Add support for MX, TXT, NS and SOA records to GResolver
* Add resolver functions for looking up DNS records of
various types. Currently implemented: MX, TXT, SOA, SRV, NS
* Return records as GVariant tuples.
* Make the GSrvTarget lookups a wrapper over this new
functionality.
* Rework the resolver test so that it has support for
looking up MX, NS, SOA, TXT records, and uses GOptionContext
https://bugzilla.gnome.org/show_bug.cgi?id=672944
Petr Kovar [Mon, 16 Apr 2012 13:21:17 +0000 (15:21 +0200)]
Update Czech translation
Yinghua Wang [Mon, 16 Apr 2012 06:06:56 +0000 (14:06 +0800)]
update Simplified Chinese (zh_CN) translation
Rafał Mużyło [Sun, 15 Apr 2012 15:17:07 +0000 (11:17 -0400)]
configure: Fix typo in ELF check
Signed-off-by: Colin Walters <walters@verbum.org>
Colin Walters [Thu, 12 Apr 2012 17:54:55 +0000 (13:54 -0400)]
build: When cross compiling, don't require host binaries if tests are not enabled
These binaries are now only used by the test suite. glib-genmarshal
*used* to be required to generate marshallers, but isn't anymore now
that we use libffi (via g_cclosure_marshal_generic).
https://bugzilla.gnome.org/show_bug.cgi?id=667806
Colin Walters [Fri, 13 Jan 2012 15:09:10 +0000 (10:09 -0500)]
build: Add --disable-modular-tests build option
This patch solves two problems:
First, it allows builders to optionally cut the circular dependency
between dbus and glib by disabling the modular tests (just like how
the tests can be disabled in dbus).
Second, the tests are entirely pointless to build if cross-compiling.
It also moves us slightly closer to the long term future we want where
the tests are a separate ./configure invocation and run against the
INSTALLED glib, not the one in the source tree. This would allow us to
run the tests constantly, not just when glib is built.
https://bugzilla.gnome.org/show_bug.cgi?id=667806
Yuri Myasoedov [Sat, 14 Apr 2012 20:27:04 +0000 (00:27 +0400)]
Updated Russian translation
Cosimo Cecchi [Fri, 13 Apr 2012 20:06:16 +0000 (16:06 -0400)]
fileinfo: document the correct type for trash::orig-path
The correct type for this attribute, as set by GVfs, is
G_FILE_ATTRIBUTE_TYPE_BYTE_STRING (which is the correct type for file
paths anyway).
https://bugzilla.gnome.org/show_bug.cgi?id=674074
David Zeuthen [Sat, 14 Apr 2012 16:40:57 +0000 (12:40 -0400)]
GDBusAuth: Handle when no there is no auth observer present
I obviously fucked up when adding the ::allow-mechanism signal, sorry.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 12 Apr 2012 03:34:08 +0000 (23:34 -0400)]
Check that auth methods work and interoperate with libdbus-1
See https://bugzilla.gnome.org/show_bug.cgi?id=673943
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 14 Apr 2012 16:29:30 +0000 (12:29 -0400)]
GSocketControlMessage: Don't warn about unknown messages
If we do this, the tests added in bug 673943 will cause warnings.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 12 Apr 2012 03:30:48 +0000 (23:30 -0400)]
GDBusAuthObserver: Add a way to control what authentication mechanisms to use
This is related to https://bugzilla.gnome.org/show_bug.cgi?id=673943
but also useful in a lot of other contexts.
Giovanni Campagna [Thu, 5 Apr 2012 21:26:12 +0000 (23:26 +0200)]
GDesktopAppInfo: add an accessor for StartupWMClass
Components using GIO to do window to application matching can
use that field to retrieve potential candidates.
https://bugzilla.gnome.org/show_bug.cgi?id=673659
Giovanni Campagna [Mon, 9 Apr 2012 18:27:24 +0000 (20:27 +0200)]
Add version macros for 2.34
This marks the start of the new development cycle, and opens the
window for API additions.
https://bugzilla.gnome.org/show_bug.cgi?id=673659
Matthias Clasen [Fri, 13 Apr 2012 23:54:42 +0000 (19:54 -0400)]
Bump version
Matthias Clasen [Fri, 13 Apr 2012 23:53:42 +0000 (19:53 -0400)]
2.32.1
Matthias Clasen [Fri, 13 Apr 2012 22:51:23 +0000 (18:51 -0400)]
Fix distcheck
I forgot to dist a test script, and forgot to look for it
in srcdir instead of builddir.
Christian Kirbach [Fri, 13 Apr 2012 17:39:19 +0000 (19:39 +0200)]
[l10n] Updated German translation
Dan Winship [Fri, 13 Apr 2012 15:43:09 +0000 (11:43 -0400)]
tests/mainloop: fix a race condition
Rather than depending on the machine's speed/load, just interlock
between the two threads properly.
Dan Winship [Fri, 13 Apr 2012 15:42:39 +0000 (11:42 -0400)]
tests/mainloop: use g_assert_cmpint(), for better error messages
Matthias Clasen [Fri, 13 Apr 2012 13:31:08 +0000 (09:31 -0400)]
Make the markup-parse test independent of the locale
I added a setlocale call, because we need it for Unicode to
come out right; but I forgot to fix the locale, so we now
fail when comparing error messages to the expected (English)
result. Correct this by setting LANG explicitly to en_US.utf-8.
https://bugzilla.gnome.org/show_bug.cgi?id=669285
Bruce Cowan [Fri, 13 Apr 2012 12:27:39 +0000 (13:27 +0100)]
Updated British English translation
Kalev Lember [Fri, 13 Apr 2012 10:22:46 +0000 (13:22 +0300)]
GResource docs: fix typo
Ryan Lortie [Fri, 13 Apr 2012 00:04:32 +0000 (20:04 -0400)]
GSettings docs: clarify what is a good path
Add an explicit note to the docs about choosing paths based on domain
names, not ones like "/apps/", "/desktop/" or "/system/".
Ryan Lortie [Thu, 12 Apr 2012 23:55:34 +0000 (19:55 -0400)]
glib-compile-schemas: warn about bad dconf paths
For quite some time the recommended usage of GSettings and dconf has
been to use paths like /org/gnome/example/. Use of /apps/ has spilled
over from GConf and is continuing to make its way into a number of
applications as they port.
glib-compile-schemas will now warn about these types of paths being
used. This generates a lot of noise, but hopefully it will reduce the
number of ported applications making this mistake.
Alexander Larsson [Thu, 12 Apr 2012 14:50:20 +0000 (16:50 +0200)]
Fall back to SO_PEERCRED if credentials passing fails
Turns out libdbus doesn't send struct ucred credentials on linux, but
just relies on the SO_PEERCRED support. However, gdbus does send, and
expect to recieve a ucred credential. So, when libdbus talks to a
gdbus server the authentication fails to send the credentials.
We fix this by falling back to g_socket_get_credentials() if we don't
get any credential messages.
Alexander Larsson [Thu, 12 Apr 2012 14:43:49 +0000 (16:43 +0200)]
Detect "empty" socket credentials on Linux
Linux uses struct ucred to pass over socket credentials. Historically
this has always worked in recievemsg, if SO_PASSCRED was set on the socket,
even if the remote side didn't pass any credits. But this change broke that:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=
16e5726269611b71c930054ffe9b858c1cea88eb;hp=
a9e9fd7182332d0cf5f3e601df3e71dd431b70d7
However, it doesn't actually fail getting the credentials, it just returns
an "empty" one, as initialized by cred_to_ucred() at:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=net/core/sock.c;h=
b29ab61b029cf7f76fda992ecfcb8dcaa06b0483;#l756
So, we detect this and fail the credentials reading.
This actually happened in real life with gdbus acting as a server, as
gdbus expected an ucred but libdbus didn't send one.
William Hua [Thu, 12 Apr 2012 03:25:09 +0000 (23:25 -0400)]
Be more precise about Carbon v. Cocoa.
OKANO Takayoshi [Thu, 12 Apr 2012 00:30:05 +0000 (09:30 +0900)]
[l10n] Update Japanese translation
Kalev Lember [Wed, 11 Apr 2012 13:41:48 +0000 (16:41 +0300)]
gio-2.0.pc: Avoid full path to executables
Instead of using full path in glib_compile_schemas and
glib_compile_resources variables, rely on having the executables in
PATH.
This fixes the cross-compiling case where we cannot execute the binaries
for target system. Instead of executing the target system's binaries, we
need to use the native versions installed on the build host. The easiest
way to find the native executables is to just pick them up from PATH.
In addition, this brings gio-2.0.pc in line with glib-2.0.pc -- the
latter has historically only listed the executable name and not the full
path.
https://bugzilla.gnome.org/show_bug.cgi?id=673911
Jeremy Huddleston [Wed, 11 Apr 2012 06:05:00 +0000 (02:05 -0400)]
Don't use fast enumeration in old version of Mac OS.
Signed-off-by: William Hua <william@attente.ca>
Jeremy Huddleston [Wed, 11 Apr 2012 05:44:29 +0000 (01:44 -0400)]
Link with Foundation framework on OSX.
Signed-off-by: William Hua <william@attente.ca>
Bruno Brouard [Wed, 11 Apr 2012 12:53:22 +0000 (14:53 +0200)]
Updated French translation
Chandan Kumar (ciypro) [Wed, 11 Apr 2012 10:55:22 +0000 (16:25 +0530)]
Updated HINDI translation
Kjartan Maraas [Wed, 11 Apr 2012 10:41:51 +0000 (12:41 +0200)]
Updated Norwegian bokmål translation
Matthias Clasen [Wed, 11 Apr 2012 03:52:30 +0000 (23:52 -0400)]
Updates
Carles Ferrando [Tue, 10 Apr 2012 21:12:29 +0000 (23:12 +0200)]
[l10n]Updated Catalan (Valencian) translation
Jordi Serratosa [Tue, 10 Apr 2012 21:12:23 +0000 (23:12 +0200)]
[l10n] Fixes on Catalan translation
Will Thompson [Fri, 6 Apr 2012 09:03:29 +0000 (10:03 +0100)]
gdbus: test case for 673612
When presented with an array of empty arrays of 8-byte-aligned types,
GDBus would incorrectly apply the 8-byte alignment when reading back.
https://bugzilla.gnome.org/show_bug.cgi?id=673612
Signed-off-by: David Zeuthen <davidz@redhat.com>
Will Thompson [Tue, 10 Apr 2012 12:20:09 +0000 (13:20 +0100)]
GDBusMessage: do not align for grandchildren of empty arrays.
D-Bus arrays are serialized as follows:
1. align to a 4-byte boundary (for the length)
2. uint32: the length of the serialized body in bytes
3. padding for the alignment of the body type (not included in the length)
4. the body.
Note that 3. is a no-op unless the body type is an 8-byte aligned type
(uint64, int64, double, struct, dict_entry), since you are always on a
4-byte boundary from aligning and writing the length.
So, an empty aax (that is, an array containing zero arrays of int64)
is serialized as follows:
1. align to a 4-byte boundary
2. length of the contents of this (empty) array, in bytes (0)
3. align to a 4-byte boundary (the child array's alignment requirement)
4. there is no body.
But previously, GDBus would recurse in step three to align not just for
the type of the child array, but for the nonexistent child array's
contents. This only affects the algorithm when the grandchild type has
8-byte alignment and the reader happened to not already be on an 8-byte
boundary, in which case 4 bytes were spuriously skipped.
https://bugzilla.gnome.org/show_bug.cgi?id=673612
Signed-off-by: David Zeuthen <davidz@redhat.com>
Will Thompson [Tue, 10 Apr 2012 11:58:52 +0000 (12:58 +0100)]
GDBusMessage: print more debug info about alignment
Signed-off-by: David Zeuthen <davidz@redhat.com>
Yaron Shahrabani [Tue, 10 Apr 2012 17:06:51 +0000 (20:06 +0300)]
Updated Hebrew translation.
Мирослав Николић [Tue, 10 Apr 2012 09:06:03 +0000 (11:06 +0200)]
Updated Serbian translation