Jean-Philippe Andre [Wed, 29 Oct 2014 06:10:03 +0000 (15:10 +0900)]
Evas filters: Fix COW usage.
Thanks cedric for the report.
We'll need a new function (after 1.12) to detect if the current
cow pointer is the default data or not. Maybe eina_cow_default_get()
or maybe something just returning a bool.
Jean-Philippe Andre [Wed, 29 Oct 2014 03:56:00 +0000 (12:56 +0900)]
Evas GL: Fix potential crash
Welp, it looks like this crash actually happened once even though
it should not. glGetString() seems to have returned NULL somehow.
Cedric BAIL [Wed, 29 Oct 2014 05:15:11 +0000 (06:15 +0100)]
evas: fix increased memory usage in Evas.
Eina_Cow does memory comparison during standby time. So in expedite as we don't
have any standby time, we end up allocating some vast amount of memory that
will never be compared. It is way simpler to compare that the data are not
going to change before hand. It should also reduce the CPU consumed during
idle time.
This patch save about 1MB of data at peak time in expedite.
Cedric BAIL [Tue, 28 Oct 2014 23:12:06 +0000 (00:12 +0100)]
autotools: fix build with NEON support.
Tae-Hwan Kim [Tue, 28 Oct 2014 20:22:06 +0000 (21:22 +0100)]
eina: fix overlapped doxygen string output
Summary:
Add top padding to prevent overlapping between "Value:" and below
strings when long macro is used.
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1582
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Tue, 28 Oct 2014 20:20:33 +0000 (21:20 +0100)]
eina: enhance doxygen in eina_error.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1588
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 28 Oct 2014 20:19:10 +0000 (21:19 +0100)]
eina: remove reference to API that never made it to a stable release.
Tae-Hwan Kim [Tue, 28 Oct 2014 20:18:28 +0000 (21:18 +0100)]
eina: enhance doxygen in eina_binshare.h
Summary:
Add @brief for brief description
Add @details for detailed description
Add @warning for important description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1586
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Tue, 28 Oct 2014 20:16:38 +0000 (21:16 +0100)]
eina: enhance doxygen in eina_inarray.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1592
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tom Hacohen [Tue, 28 Oct 2014 16:19:30 +0000 (16:19 +0000)]
Eo composite objs: Add a test for the recent comp obj fix.
This adds a fragile test for cedric's fix from commit
3550c3808085175cf322670b290bf0c4a70a2fa7.
It assumes that all the added 64 functions are in order and that each
eo_op chain is 32 in length. As long as those don't change, this should
be a decent test.
Tom Hacohen [Tue, 28 Oct 2014 15:19:41 +0000 (15:19 +0000)]
Eo comp: Remove dead code following the composite fix.
This removes dead code resulting from Cedric's fix:
3550c3808085175cf322670b290bf0c4a70a2fa7.
Srivardhan Hebbar [Tue, 28 Oct 2014 14:27:31 +0000 (10:27 -0400)]
ecore_wayland: Checking if default wayland socket exists before executing test case.
Summary:
If WAYLAND_DISPLAY is not set or if wayland-0 fd doesn't exist in the XDG_RUNTIME_DIR path, then this test case fails. That should not be the case. So made changes in the test case.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1590
Srivardhan Hebbar [Tue, 28 Oct 2014 14:26:39 +0000 (10:26 -0400)]
ecore_drm: Added test case calling ecore_drm_shutdown before calling ecore_drm_init.
Summary:
_ecore_drm_init_count should not go below zero. So added test case to verify that.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1589
Carsten Haitzler (Rasterman) [Tue, 28 Oct 2014 11:09:33 +0000 (20:09 +0900)]
evas - fix new issue with segv when switching to alpha win with gl
evas gl window was freed before new one was created getting shared ctx
to 0 refcount thus freeing everything there - BAD. fix. new issue in
git, not from release
Jaehwan Kim [Tue, 28 Oct 2014 06:50:38 +0000 (15:50 +0900)]
Edje_calc: set the image set border again after resize.
_edje_real_part_image_set can change the image of part,
if the part use the image that is set by image set.
If the image is changed, the border should be changed.
@fix
Jean-Philippe Andre [Tue, 28 Oct 2014 02:19:24 +0000 (11:19 +0900)]
Evas: Fix lock usage around async_current (gl preload)
Fixes Coverity:
- CID 1039361
Jean-Philippe Andre [Mon, 27 Oct 2014 14:09:18 +0000 (23:09 +0900)]
Evas convert: Remove dead code
Woah coverity...
Fixes CID 1039448
Jean-Philippe Andre [Mon, 27 Oct 2014 13:57:53 +0000 (22:57 +0900)]
inotify: Fix safety after read in 3 places
Fixes Coverity issues:
- CID 1039565
- CID 1039566
Jean-Philippe Andre [Mon, 27 Oct 2014 13:16:53 +0000 (22:16 +0900)]
Evas cserve2: Check message size
Fixes CID 1039570
Jean-Philippe Andre [Mon, 27 Oct 2014 13:07:36 +0000 (22:07 +0900)]
Embryo: Use strncpy instead of strcpy in a few places
There are still lots of unsafe uses of strcpy, strcat, etc...
Dunno if they are relevant though. Also, assert() may be
compiled out at build time (release mode) so don't rely on it
for safety.
Fixes CID 1039593
Jean-Philippe Andre [Mon, 27 Oct 2014 12:48:37 +0000 (21:48 +0900)]
Evas GL: Set umask before calling mkstemp
Fixes Coverity issues:
- CID 1039609
- CID 1039608
Jean-Philippe Andre [Mon, 27 Oct 2014 12:37:39 +0000 (21:37 +0900)]
Evas filters: Prevent division by 0
While it really shouldn't happen, let's just add a quick if()
and make Coverity shut up.
Fixes:
- CID 1191912
- CID 1191911
- CID 1191910
- CID 1191909
Cedric BAIL [Mon, 27 Oct 2014 22:23:45 +0000 (23:23 +0100)]
eo: fix composite to actually work.
So I don't really understand why the code was not there before, but it resulted
in my experiment of making a combobox for elementary just impossible. Now it
work at least.
Bogdan Devichev [Mon, 27 Oct 2014 13:57:22 +0000 (14:57 +0100)]
evas/3d: Fix resource leaks found by coverity
CID: 1244183 - 1244187
Reviewers: cedric, artem.popov, Oleksander
Subscribers: stefan_schmidt, cedric
Differential Revision: https://phab.enlightenment.org/D1585
Srivardhan Hebbar [Mon, 27 Oct 2014 12:09:43 +0000 (08:09 -0400)]
ecore_wayland: Added test case calling ecore_wl_shutdown before calling ecore_wl_init.
Summary:
Added a test case to calling ecore_wl_shutdown before ecore_wl_init. The return value of ecore_wl_shutdown should not go below 0.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1584
Srivardhan Hebbar [Mon, 27 Oct 2014 12:00:38 +0000 (08:00 -0400)]
ecore_drm: Adding test-suite to ecore_drm.
Summary:
Adding test-suite to ecore_drm with one test case.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1583
Stefan Schmidt [Mon, 27 Oct 2014 11:32:01 +0000 (12:32 +0100)]
release: Update NEWS and bump version for 1.12.0-beta1 release
Carsten Haitzler (Rasterman) [Mon, 27 Oct 2014 10:51:10 +0000 (19:51 +0900)]
evas - sw generic - fix osmesa to not use rgb buffers as evas doesnt know
this fixes incorrect sw osmesa rendering when no alpha cannel is used
on evas gl targets.
Vyacheslav Reutskiy [Mon, 27 Oct 2014 10:28:25 +0000 (10:28 +0000)]
edje: edje_edit - fix posible resource leak
Fixes: https://phab.enlightenment.org/T1760
@fix
Vyacheslav Reutskiy [Mon, 27 Oct 2014 09:21:45 +0000 (09:21 +0000)]
edje: edje_edit - don't unlick(NULL)
Summery: fix, posible to delete file by 'NULL' path (T1760)
@fix
Jean Guyomarc'h [Mon, 27 Oct 2014 08:11:19 +0000 (09:11 +0100)]
eina_semaphore: OSX support
Summary:
OSX only support named semaphores. Eina_Semaphore was actually broken on OSX.
Since OSX 10.10 sem_init() and sem_destroy() (were not implemented) are also marked as
"deprecated", which adds huge pollution to the output when compiling.
Reviewers: cedric, raster, stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1576
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:10:16 +0000 (09:10 +0100)]
eina: enhance doxygen in eina_accessor.h
Summary:
Add @brief for brief description
Add @details for detailed description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1580
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:08:42 +0000 (09:08 +0100)]
eina: documentation enhance - add @brief tag
Summary: Add @brief for brief description
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1577
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:06:16 +0000 (09:06 +0100)]
eina: enhance doxygen for eina_counter.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1579
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean-Philippe Andre [Fri, 24 Oct 2014 11:52:09 +0000 (20:52 +0900)]
Evas GL: string_query returns a const char *
Why cast to/from void* in the first place?
Jean-Philippe Andre [Fri, 24 Oct 2014 10:52:21 +0000 (19:52 +0900)]
Evas GL: Fix typo in an extension's name
This could potentially break applications relying on this
typo to check for the extension. The chances are very slim.
Daniel Zaoui [Mon, 27 Oct 2014 06:10:11 +0000 (08:10 +0200)]
dnd/x: fix type set for case there is no type list exists
Summary:
DND does not work in X11 because we cannot set type.
The
f8e036d5af3c99d74c3b0f4dcc612c4e0a949e00 causes this.
Since the xdnd type list does not exists at the beginning,
if we always return without setting new property, we cannot set dnd type.
This patch brings dnd work again by correcting the type set operation.
@fix
Test Plan: Try dnd tests in elementary_test.
Reviewers: raster, woohyun, JackDanielZ
Reviewed By: JackDanielZ
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1578
Carsten Haitzler (Rasterman) [Sat, 25 Oct 2014 11:04:52 +0000 (20:04 +0900)]
evas gl rgba visual/rendering fix try ... again
so this is a re-try at the evas gl destination alpha fix. this is what
cedric tried, but done RIGHT. it required adding an ecore_x call to
create a window with correct visual/colormap. it requires doing
visuals totally correctly all the way from ecore_evas to the evas
gl_x11 core. nvidia drivers are very picky about visuals. i also had
to vid the egl/gles code too to do the same thing. nvidia gles/egl
drivers are also picky, mesa is not. this all requires a lot of code
changes. it's far from trivial
this isn't backported for a few reasons:
1. verify this fix doesn't break for anyone.
i tested:
nvidia glx + egl/gles
intel glx + egl/gles
radeon glx
it needs wider testing. nouveau, fglrx for starters and maybe
some other gles/egl drivers.
2. have some review time
3. time to settle before blasting to stable branches
@fix
Adrien Nader [Sat, 25 Oct 2014 14:35:06 +0000 (16:35 +0200)]
ecore_exe_win32: CreateProcess was called with random flags.
CreateProcess() has a flags parameter which is being passed
"run_pri | CREATE_SUSPENDED".
The issue lies in the value of run_pri. It is best explained by the
following code somewhere else in the file:
switch (run_pri)
{
case IDLE_PRIORITY_CLASS:
return ECORE_EXE_WIN32_PRIORITY_IDLE;
The run_pri variable is supposed to store a value from the win32 API while
it was used to store one from the ecore API.
If I recall correctly, the windows one is equal to 32 and the ecore one to
9999. Meaning 9999 ended up used as flags so let's have a look at what that
actually enabled; the reference is "Process Creation Flags" from MSDN
http://msdn.microsoft.com/en-us/library/ms684863%28v=vs.85%29.aspx .
9999 gives 0x0000270F and this matches
DEBUG_PROCESS | DETACHED_PROCESS | DEBUG_ONLY_THIS_PROCESS
| CREATE_SUSPENDED | CREATE_NEW_PROCESS_GROUP | CREATE_SEPARATE_WOW_VDM
| CREATE_UNICODE_ENVIRONMENT | <0x00002000 matches nothing>
Matches nothing? Weird. Well, maybe. Except that I stumbled upon this define
in the mingw-w64 headers:
#define CREATE_FORCEDOS 0x2000
Mingw-w64 only has a #define, Wine has nothing (they don't do DOS anyway),
but ReactOS has some code about it:
https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/kernel32/client/proc.c;hb=
f60941f8dc775427af04eb0a3c3e4d38160c7641#l3007
Overall the actual set of flags probably made very little sense and wasn't
working very well. :)
I also noticed the following in the mingw-w64 headers:
#define INHERIT_CALLER_PRIORITY 0x20000
This should be a better match for what seemed to be the original intent of
inheriting the priority. I haven't tested it and it's only documented on
MSDN for Windows CE and similar so I'm really not sure about what it does.
MSDN however mentions that the child processes will have at most the
"normal" priority by default (same as its parent if the parent has less
than the default one) but I'm under the impression a process can raise its
own priority level... Anyway, "NORMAL_PRIORITY_CLASS" will do for now.
With this change and a couple others, elementary's theme builds properly
on Windows (_on_ Windows). I'll assess the usefulness of the other changes
in my tree over the next few days.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Stefan Schmidt [Fri, 24 Oct 2014 12:29:35 +0000 (14:29 +0200)]
ecore_evas: Add since tag to new ecore_evas_gl_drm_new() function
Stefan Schmidt [Fri, 24 Oct 2014 12:28:02 +0000 (14:28 +0200)]
ecore-wayland: Add since tag to new ecore_wl_window_xdg_surface_get() function
Chris Michael [Fri, 24 Oct 2014 12:37:51 +0000 (08:37 -0400)]
evas-gl-drm: Fix initialization from incompatible pointer type
Summary: The function prototype for eng_context_create has recently
changed in gl_common, however nobody thought it wise to update all
engines using it, so this commit fixes the function for the gl_drm
engine.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Fri, 24 Oct 2014 11:02:07 +0000 (13:02 +0200)]
eina_cxx: Include newly added header to unbreak make distcheck
Felipe Magno de Almeida [Thu, 23 Oct 2014 20:06:13 +0000 (18:06 -0200)]
[eina-cxx] Fixed EFL_CXX_THROW not defined
Fixed errors of EFL_CXX_THROW not defined when #include'ing specific
eina C++ headers.
Felipe Magno de Almeida [Thu, 23 Oct 2014 19:38:15 +0000 (17:38 -0200)]
[cxx] Fixed eina::value get for string
The get function for string in eina::value wronfully was freeing the
string returned from eina_value_get. Which crashed applications that
used it.
Srivardhan Hebbar [Thu, 23 Oct 2014 14:40:39 +0000 (10:40 -0400)]
ecore_wayland: Making _ecore_wl_shutdown return int instead of EINA_BOOL.
Summary:
_ecore_wl_shutdown should return int instead of EINA_BOOL. So changing the function prototype.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1574
Chris Michael [Thu, 23 Oct 2014 14:33:40 +0000 (10:33 -0400)]
ecore-wayland: Add error message for calling shutdown without calling
init
Summary: If someone calls ecore_wayland_shutdown without first calling
ecore_wl_init, then the init count is wrong. Warn the caller.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 23 Oct 2014 14:32:59 +0000 (10:32 -0400)]
ecore-drm: Add error message for calling shutdown without calling init
first.
Summary: If someone calls ecore_drm_shutdown without first calling
ecore_drm_init, then the init count is wrong. Warn the caller.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Thu, 23 Oct 2014 13:13:20 +0000 (15:13 +0200)]
Revert "tests/eina: Enable eina_condition_timedwait() now that it should work."
This has to work until we really fixed up eina_condition_timedwait()
This reverts commit
5c9024424f7102abd6c7d858628b52da6065cf9a.
Stefan Schmidt [Thu, 23 Oct 2014 13:10:39 +0000 (15:10 +0200)]
Revert "eina: Fix _timedwait to handle the given timeout on top of the absolute time"
Not ready yet as it uses _eina_time_get which is internal only right now. Compiling
works fine for efl alone as the private header is in teh include search part but it
blows up when compiling elementary.
Need to think a bit more about this. Maybe exposing _eina_time_get as API but that
should wait until after the release.
This reverts commit
f0a02a92beff49879eba84b4d4eee265fe156511.
Srivardhan Hebbar [Thu, 23 Oct 2014 13:04:29 +0000 (09:04 -0400)]
ecore_drm: Making _ecore_drm_init_count not to go below zero in _ecore_drm_shutdown.
Summary:
If _ecore_drm_init_count goes below zero, then when next time ecore_drm_init is called, it won't do the initializations which it is supposed to do. So preventing this scenario by not making it go
below zero in _ecore_wl_shutdown function.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1573
Srivardhan Hebbar [Thu, 23 Oct 2014 13:02:11 +0000 (09:02 -0400)]
ecore_wayland: Making _ecore_wl_init_count not to go below zero in shutdown.
Summary:
If _ecore_wl_init_count goes below zero, then there would be problem if someone calls ecore_wl_shutdown 1st and then ecore_wl_init later. So fixing this issue in ecore_wl_shutdown.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1571
vivek [Thu, 23 Oct 2014 12:52:02 +0000 (08:52 -0400)]
ecore-drm: Added documentation for various APIs in ecore_drm_output module
Summary:
Added documentation for ecore_drm_outputs_create, ecore_drm_output_free,
ecore_drm_output_cursor_size_set, ecore_drm_output_size_get functions
@fix
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1572
Stefan Schmidt [Thu, 23 Oct 2014 11:53:40 +0000 (13:53 +0200)]
evas/cserve2_slave: Fix build race with linking to eo but not depending on it.
I have not been able to reproduce this myself but I have seen a build log where
the binary tries to link to libeo and fails due to the missing file.
A similar problem was "fixed" in
0e4b847deb79c957dbc042ea0c6a98282aead6e0, but
this really makes me wonder where the linking against eo comes from for cserve2
which is not using eo as far as I can see.
kabeer khan [Thu, 23 Oct 2014 12:34:14 +0000 (08:34 -0400)]
Eina Test : Added test case for convert float in eina_test_value
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1567
vivek [Thu, 23 Oct 2014 12:31:20 +0000 (08:31 -0400)]
ecore-drm: Added documentation for various APIs in ecore_drm_device module
Summary:
Added documentation for ecore_drm_device_fd_get, ecore_drm_device_window_set
and ecore_drm_device_name_get APIs in ecore_drm_device module.
@fix
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1568
Chris Michael [Thu, 23 Oct 2014 12:28:33 +0000 (08:28 -0400)]
ecore-drm: Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
vivek [Thu, 23 Oct 2014 12:28:14 +0000 (08:28 -0400)]
ecore-drm: Cleanup backlight and drm device in output_free function code
Summary:
Added code to cleanup backlight structure and to close the drm device and
delete it.
@fix
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1566
Stefan Schmidt [Thu, 23 Oct 2014 09:12:00 +0000 (11:12 +0200)]
eina: Add a note about potential use of CLOCK_MONOTONIC
Note it down so we can think about this at some later point.
Stefan Schmidt [Thu, 23 Oct 2014 09:09:55 +0000 (11:09 +0200)]
tests/eina: Enable eina_condition_timedwait() now that it should work.
Stefan Schmidt [Wed, 22 Oct 2014 13:36:57 +0000 (15:36 +0200)]
eina: Fix _timedwait to handle the given timeout on top of the absolute time
The pthread man page clearly states that pthread_cond_timedwait() takes an
absolute time parameter. So far we always passed it epoch plus timeout in
seconds. This would never trigger the timeout.
Making sure we fill out timespec struct with the current time before adding
the timeout as offset now. Also handling the t < 0 error case.
Various version worked up together with Jean-Philippe Andre <jp.andre@samsung.com>
Fixes T1701
Cedric BAIL [Wed, 22 Oct 2014 20:30:29 +0000 (22:30 +0200)]
eet: shutup stupid compiler warning.
Chris Michael [Wed, 22 Oct 2014 13:18:05 +0000 (09:18 -0400)]
evas-gl-drm: Cleanup formatting
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 22 Oct 2014 13:13:44 +0000 (09:13 -0400)]
ecore-drm: Check for valid crtc before calling free
Summary: We cannot call drmModeFreeCrtc with an invalid crtc, so check
that it is set inside the output structure before trying to make this
call
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 22 Oct 2014 13:12:29 +0000 (09:12 -0400)]
ecore-drm: Cleanup/Unify output_free function code
Summary: There is no point in having different code in each output
free function (internal one and API exposed one), so let's unify the
code here.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Wed, 22 Oct 2014 13:11:25 +0000 (15:11 +0200)]
emotion: Add wma as possible playable extension
This allows to preview (listen) a wma file in efm for example.
Fixes T1568
Cedric BAIL [Wed, 22 Oct 2014 12:14:26 +0000 (14:14 +0200)]
evas: tests only for extension compiled in.
vivek [Wed, 22 Oct 2014 12:14:26 +0000 (08:14 -0400)]
ecore_drm: Added internal function to check if drm device is hotplug device
Summary:
Added _ecore_drm_output_device_is_hotplug API to check if the
drm device is hotplug device. It returns EINA_TRUE if device is
hotplug else returns EINA_FALSE
@feature
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1559
Tom Hacohen [Wed, 22 Oct 2014 10:43:45 +0000 (11:43 +0100)]
Eo id: Add regression tests to eo id sanity checks
Relevant commit:
0b86334a858d9ba88a1642ec5671185292e75ce5
Tom Hacohen [Wed, 22 Oct 2014 10:31:06 +0000 (11:31 +0100)]
Eo id: Fix id security checks for invalid objects.
In some cases, invalid object ids (e.g 0x1) would pass validation and
represent completely different objects (0x80...01). This happened because
we weren't properly checking a given object id is actually an object id.
@fix.
Jean-Philippe Andre [Wed, 22 Oct 2014 06:48:11 +0000 (15:48 +0900)]
Eina: Check for errors after eina_tls_new
Fix CID 1248913.
Jean-Philippe Andre [Wed, 22 Oct 2014 05:14:58 +0000 (14:14 +0900)]
Evas filters: Remove useless source_count and cow checks
Jean-Philippe Andre [Wed, 22 Oct 2014 02:27:11 +0000 (11:27 +0900)]
Evas filters: Feed some cow to the image objects
Same as for the text objects.
Fixes T1725.
Cedric, please run again your memory test, please.
Jean-Philippe Andre [Wed, 22 Oct 2014 02:12:33 +0000 (11:12 +0900)]
Evas filters: Move filter COW to evas global stuff
It will be shared between TEXT and IMAGE objects.
Jean-Philippe Andre [Wed, 22 Oct 2014 01:53:45 +0000 (10:53 +0900)]
Evas filters: Use a cow to reduce memory usage of text objects
As pointed out by Cedric, the memory usage of basic evas objects
has increased a lot in recent versions of EFL, in part due
to this excessive use of filters data.
This is a partial fix for ticket 1725.
Jean-Philippe Andre [Wed, 22 Oct 2014 01:44:06 +0000 (10:44 +0900)]
Evas GL: Don't pass shared context for GLX with 1.1 API
Not sure if this is very relevant, since GLX does not support
GL-ES as such, anyways... We should be using the extension
GLX_EXT_create_context_es_profile to create proper contexts.
Note: GLX + OpenGL-ES 1.1 crashes at any function call on my
machine (binary bloc driver), while EGL + GLES1.1 is fine.
Jean-Philippe Andre [Tue, 21 Oct 2014 23:43:28 +0000 (08:43 +0900)]
Evas GL: Remove useless #ifdef/#endif
Jean-Philippe Andre [Tue, 21 Oct 2014 23:20:13 +0000 (08:20 +0900)]
Evas GL: Fix unused variable
CID 1248912
Pierre Le Magourou [Tue, 21 Oct 2014 13:53:49 +0000 (15:53 +0200)]
eldbus: Fix wrong comments.
Cedric BAIL [Tue, 21 Oct 2014 14:47:05 +0000 (16:47 +0200)]
evas: let's handle dds also during tests properly.
Cedric BAIL [Tue, 21 Oct 2014 14:46:12 +0000 (16:46 +0200)]
evas: tests more file format loader.
NOTE: It seems that the xpm one is broken. If somebody could give it
a better look and check if it work for him or not, before opening a bug
in phab.
Cedric BAIL [Tue, 21 Oct 2014 14:18:55 +0000 (16:18 +0200)]
evas: don't redefine macro in tgv saver.
Stefan Schmidt [Tue, 21 Oct 2014 14:24:13 +0000 (16:24 +0200)]
release: Update NEWS and bump version for 1.12.0-alpha1 release
Stefan Schmidt [Tue, 21 Oct 2014 13:10:59 +0000 (15:10 +0200)]
tests/eolian: Move eo to EXTRA_DIST assignment out of the EFL_ENABLE_TESTS case
When running distcheck with release mode enabled these would not end up in the
tarball. Better make sure these always end up at the right place.
Chris Michael [Tue, 21 Oct 2014 13:39:14 +0000 (09:39 -0400)]
evas-wayland-egl: Fix function prototype for eng_context_create
Summary: Apparently, somewhere down the line, the function prototype
for eng_context_create was changed in the EVGL_Interface, but nobody
decided to fix All engines. This commit fixes the function prototype
for evgl_eng_context_create
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Andrii Kroitor [Tue, 21 Oct 2014 12:28:16 +0000 (14:28 +0200)]
evas: Evas_Box - layout_flow_horizontal and layout_flow_vertical fix
Summary:
Now minimum width hint (for horizontal layout) and minimum height hint (for vertical)
are set to largest item size rather than largest row/column.
@fix
Test Plan:
1. Run "elementary_test"
2. Maximize window
3. Unmaximize it
ExR: button boxes should return to start state.
Reviewers: cedric, seoz, Hermet
Subscribers: cedric, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1511
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Tue, 21 Oct 2014 12:34:28 +0000 (08:34 -0400)]
ecore_wayland: Added test case to check ecore_wl_init by passing socket name.
Summary:
Added a test case for ecore_wayland to test ecore_wl_init by passing the socket name. Wayland display is created and a socket is added to the display, then this socket is passed to ecore_wl_init to connect. It should successfully connect. Then
ecore_wl_shutdown is called to verify if it closes.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1560
Chris Michael [Tue, 21 Oct 2014 12:26:25 +0000 (08:26 -0400)]
ecore-drm: Create udev watch for each output, and delete the watch
when we free the output.
Summary: This commit fixes an issue where a hotplug watch was Only
being added for One input, and also deletes any created watch during
output_free.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 21 Oct 2014 12:18:34 +0000 (08:18 -0400)]
ecore-drm: Default output to NULL and add safety check for NULL output
after the device loop.
Summary: If there are no outputs created during the loop, we would end
up crashing here by checking output->watch. This fixes that situation
without leaking resources because we still end up doing our cleanup.
NB: Thanks Cedric for the report !! :)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Tue, 21 Oct 2014 11:37:00 +0000 (12:37 +0100)]
Eo composite: Fix composite object functions to be eo functions.
For some reason, they were normal functions instead of eo functions,
which makes them harder to bind, less safe, and just wrong.
This commit fixes that.
Stefan Schmidt [Tue, 21 Oct 2014 07:57:13 +0000 (09:57 +0200)]
tests/evas: Add missing files to EXTRA_DIST and remove duplicates
Various files form the tgv and 3d tests have been missing in EXTRA_DIST
and thus failing make distcheck. On the other hand we had duplicates in
the list. Clear this all up.
Daniel Zaoui [Tue, 21 Oct 2014 08:08:13 +0000 (11:08 +0300)]
Evas-3D Tests: fix Eo usage.
There are still Valgrind (invalid read) issues but at least, it doesn't
segfault more.
Stefan Schmidt [Tue, 21 Oct 2014 07:22:49 +0000 (09:22 +0200)]
Revert "evas: GL_X11 context need to always be with alpha or it will fail to change."
Need to also revert this in master. Cedric seems busy with other things and this
should not end up in 1.12 alpha1
This reverts commit
4ea75113caeeec6bbc047f2406f8d1c89870360b.
Jean-Philippe Andre [Tue, 21 Oct 2014 06:55:53 +0000 (15:55 +0900)]
Eet: Fix eet jpeg image load
Commit
101dee79b0d75fd15 introduced critical errors, as standard
error callbacks now fail.
Apparently, these error callbacks depend on the installed version
of libjpeg (8 vs. 9).
I couldn't start E without this commit.
Jean-Philippe Andre [Tue, 21 Oct 2014 03:08:42 +0000 (12:08 +0900)]
Evas: Fix some debug output formatting
Remove trailing newline.
Daniel Zaoui [Tue, 21 Oct 2014 05:45:32 +0000 (08:45 +0300)]
Evas-3D: invoke eo_do_super in destructors.
Daniel Zaoui [Tue, 21 Oct 2014 05:45:22 +0000 (08:45 +0300)]
3D Warnings--
Shinwoo Kim [Mon, 20 Oct 2014 17:12:25 +0000 (02:12 +0900)]
[example][evas] add error message, you cannot use this example without the image.
Shinwoo Kim [Mon, 20 Oct 2014 17:00:04 +0000 (02:00 +0900)]
[ecore_input] fix build break - the semicolon
Vincent Torri [Sun, 19 Oct 2014 18:26:25 +0000 (20:26 +0200)]
eet: enhance error messages with libjpeg
@fix