adrianknight89 [Wed, 4 Jan 2017 13:11:09 +0000 (07:11 -0600)]
[iOS] Platform specifics for controlling Picker SelectedIndex change behavior (#540)
* picker selected index could change when picker view is dismissed
* use enum
E.Z. Hart [Tue, 3 Jan 2017 12:02:10 +0000 (05:02 -0700)]
Allow subscriber to be collected if MessagingCenter is the only reference to it (#617)
* Repro
* Make messaging center callbacks weak references
* Preserve attribute
* Fix test method name
* Watch for collection of actual delegate target instead of wrapper delegate
* Preserve the original platform instance when changing main page
* Better tests for lambda situations
* Update tests, make callback target a weakreference if it's the subscriber
* Ensure old Platform MessagingCenter subs are gone before creating new Platform
adrianknight89 [Tue, 3 Jan 2017 11:35:54 +0000 (05:35 -0600)]
[iOS/Android] Move Map camera to correct region on layout change (#548)
* Move to region on layout change
* remove visibility check
adrianknight89 [Tue, 3 Jan 2017 11:34:27 +0000 (05:34 -0600)]
Return group instead of internal class (#461)
Paul DiPietro [Tue, 3 Jan 2017 11:31:48 +0000 (05:31 -0600)]
[WinRT/UWP] Apply BackgroundColor to Stepper buttons (#581)
* [WinRT/UWP] Apply BackgroundColor to Stepper buttons
* Add explanatory text; use nameof
* Move explanatory text to a label
adrianknight89 [Tue, 3 Jan 2017 11:30:35 +0000 (05:30 -0600)]
[iOS] Prevent multiple ListView cells from being swiped simultaneously (#578)
* disable multiple cell swipe
* add sample code
* refactored
* convert to weakreference
* remove null setting
* change weakreference setting place
* remove if
* revert isopen changes
* add instructions
E.Z. Hart [Tue, 3 Jan 2017 11:25:24 +0000 (04:25 -0700)]
Make UWP toolbar display rules consistent with other platforms (#638)
adrianknight89 [Fri, 30 Dec 2016 22:19:31 +0000 (16:19 -0600)]
[Android] Fix NavigationPage dispose crash when it parents a MasterDetailPage (#577)
* fix navigation page dispose crash
* changes after review
adrianknight89 [Fri, 30 Dec 2016 22:14:13 +0000 (16:14 -0600)]
[iOS] Change keyboard type while keyboard is visible (#443)
* Change keyboard while changing text
* add sample code
Stephane Delcroix [Fri, 30 Dec 2016 16:58:48 +0000 (17:58 +0100)]
[XamlC] detect duplicate x:Name at compile time (#655)
* [XamlC] detect duplicate x:Name at compile time
* invoking methods with the right arguments produces better results
E.Z. Hart [Thu, 29 Dec 2016 16:18:35 +0000 (09:18 -0700)]
Make CellsGalleryImageUrlCellList test finish early if possible
Samantha Houts [Tue, 27 Dec 2016 20:46:41 +0000 (12:46 -0800)]
Fix comment typo
E.Z. Hart [Wed, 28 Dec 2016 23:42:17 +0000 (16:42 -0700)]
Update ImageCellListPage to use an image we control;
Update CellsGalleryImageUrlCellList test to wait longer than 1s for images
to load if necessary
E.Z. Hart [Wed, 28 Dec 2016 23:33:24 +0000 (16:33 -0700)]
Adding image to use for CellsGalleryImageUrlCellList UI test
adrianknight89 [Wed, 28 Dec 2016 23:15:45 +0000 (17:15 -0600)]
fix nre when changing content in datepickerselected (#494)
Paul DiPietro [Tue, 27 Dec 2016 18:58:48 +0000 (12:58 -0600)]
[UWP] Fix TextBox style for foreground focus color (#618)
Stephane Delcroix [Fri, 23 Dec 2016 09:21:30 +0000 (10:21 +0100)]
Xamlc compile data triggers (#648)
* [Xaml] DataTrigger and PropertyCondition no longer use a ServiceProvider
* [XamlC] avoid generating ServiceProvider for unused ProvideValue
* fix tests
Stephane Delcroix [Fri, 23 Dec 2016 07:50:19 +0000 (08:50 +0100)]
[Xaml] support short Properties for PropertyCondition (#645)
Stephane Delcroix [Fri, 23 Dec 2016 07:50:02 +0000 (08:50 +0100)]
[XamlC] import members on x:Static and factories (#642)
adrianknight89 [Thu, 22 Dec 2016 18:46:57 +0000 (12:46 -0600)]
[iOS] Entry should not pass a newline to the next responder (#397)
* UITextField should not return so that the next field does not get passed a newline
* Added code sample
Stephane Delcroix [Thu, 22 Dec 2016 08:34:30 +0000 (09:34 +0100)]
Avoid duplicating code in OmPlatform (#591)
Paul DiPietro [Mon, 19 Dec 2016 12:45:15 +0000 (06:45 -0600)]
[UWP] Use toolbar foreground color on primary items (#640)
adrianknight89 [Mon, 19 Dec 2016 12:42:16 +0000 (06:42 -0600)]
Slider should show user-set value on initial load (#378)
Jimmy Garrido [Sat, 17 Dec 2016 01:08:03 +0000 (17:08 -0800)]
[Windows] Fix modal pages being laid out below soft buttons (#395)
Rui Marinho [Fri, 16 Dec 2016 18:05:28 +0000 (18:05 +0000)]
Add sample HanselForms and TwitterDemo to ControlGallery (#651)
* [Controls] Add Hanselforms sample
* Remove extra twitter sample
* [Controls]Add TwitterDemo sample
* [Controls] Fix build
Paul DiPietro [Fri, 16 Dec 2016 15:58:47 +0000 (09:58 -0600)]
[WinRT] Use a queue to prevent multiple MessageDialogs from causing a crash (#347)
* [WinRT] Use a queue to prevent multiple MessageDialogs from causing a crash
* Make change to use Device.IsInvokeRequired
Jason Smith [Thu, 15 Dec 2016 18:48:00 +0000 (10:48 -0800)]
Remove overload causing backwards compatibility issues
E.Z. Hart [Thu, 15 Dec 2016 00:13:17 +0000 (17:13 -0700)]
Fix potential NRE in ConditionalFocusLayout (#587)
Kangho [Wed, 14 Dec 2016 21:24:59 +0000 (06:24 +0900)]
Add Tizen to TargetPlatform (#590)
* Add Tizen to TargetPlatform
* Adds Device.OnPlatform methods having Tizen
E.Z. Hart [Wed, 14 Dec 2016 21:11:39 +0000 (14:11 -0700)]
Removing now non-existent IsiOS8OrNewer check
Jason Smith [Wed, 14 Dec 2016 20:38:46 +0000 (12:38 -0800)]
Deprecate versions of iOS older than 8 (#630)
Stephane Delcroix [Wed, 14 Dec 2016 16:48:27 +0000 (17:48 +0100)]
Revert "Update README.md"
This reverts commit
f2282a7da33045e67075f198f37d7f03549159eb.
Stephane Delcroix [Wed, 14 Dec 2016 16:48:16 +0000 (17:48 +0100)]
Revert "Update README.md"
This reverts commit
51565d7289e322d066f3c54ad0a0d02bc474e5dd.
Stephane Delcroix [Wed, 14 Dec 2016 16:42:54 +0000 (17:42 +0100)]
Update README.md
larger badges
Stephane Delcroix [Wed, 14 Dec 2016 16:40:49 +0000 (17:40 +0100)]
Update README.md
align badges...
Stephane Delcroix [Wed, 14 Dec 2016 12:50:15 +0000 (13:50 +0100)]
Xamlc compiled trigger (#629)
* [XamlC] compiled Trigger
* remove file header
* name bool parameters
Stephane Delcroix [Wed, 14 Dec 2016 12:25:42 +0000 (13:25 +0100)]
[XamlC] Allow compilation of IValueProviders (#622)
* [XamlC] Allow compilation of IValueProviders
`IValueProvider`s tagged with the appropriate attribute will be bypassed
and the compiled version, if found, will be used.
This first version contains a compiled version of Setter's
IValueProvider and it already reduces the amount of generated IL by 39%
in, e.g. StyleTests.
It's a huge gain because XamlC no longer have to generate
ServiceProviders for those, so the methodbody is smaller, takes less
time to jit, less time to execute and nothing is invoked at runtime,
which probably saves a tons of time as well, as most IValueProvider
implementation heavily uses reflection.
* name bool parameters
adrianknight89 [Wed, 14 Dec 2016 11:59:10 +0000 (05:59 -0600)]
Update readme (#644)
* update readme
* change header
E.Z. Hart [Tue, 13 Dec 2016 21:33:49 +0000 (14:33 -0700)]
Disable using EstimatedRowHeight for uneven rows with known heights (#454)
Stephane Delcroix [Tue, 13 Dec 2016 15:41:41 +0000 (16:41 +0100)]
[XamlC] remove unused variables (#620)
E.Z. Hart [Mon, 12 Dec 2016 23:41:44 +0000 (16:41 -0700)]
Add missing interface implementations
E.Z. Hart [Mon, 12 Dec 2016 23:22:44 +0000 (16:22 -0700)]
Updating UITest package to 2.0.3
Stephane Delcroix [Mon, 12 Dec 2016 21:02:37 +0000 (22:02 +0100)]
[XamlC] Compile TypeTypeConverter (#615)
Stephane Delcroix [Mon, 12 Dec 2016 20:49:05 +0000 (21:49 +0100)]
[XamlC] Optimize Stloc/Ldloc (#614)
Stephane Delcroix [Mon, 12 Dec 2016 20:03:30 +0000 (21:03 +0100)]
[XamlC] Box valueTypes on Add() (#624)
This doesn't happen often, and I haven't found any valid XAML file out
there requiring this, but in the case of 49307, it at least generates
valid IL, which then fails with a NRE as this is the nature of callvirt.
Rui Marinho [Mon, 12 Dec 2016 15:56:24 +0000 (15:56 +0000)]
Revert "Remove iOS8 build badge"
This reverts commit
19982b5bd13deb25d1ea4cb4dd157807f4f199db.
Rui Marinho [Mon, 12 Dec 2016 12:28:07 +0000 (12:28 +0000)]
Remove iOS8 build badge
Stephane Delcroix [Mon, 12 Dec 2016 10:13:41 +0000 (11:13 +0100)]
[XamlC] optimize Datatemplate IL as well (#612)
Stephane Delcroix [Mon, 12 Dec 2016 09:57:01 +0000 (10:57 +0100)]
[XamlC] fix loading ulongs, optimize bytecode for ulongs (#611)
Stephane Delcroix [Mon, 12 Dec 2016 09:35:42 +0000 (10:35 +0100)]
[XamlC] compile ThicknessTypeConverter (#603)
Stephane Delcroix [Mon, 12 Dec 2016 09:14:37 +0000 (10:14 +0100)]
[XamlC] support setting values on ValueTypes (#596)
Jason Smith [Fri, 9 Dec 2016 18:17:27 +0000 (10:17 -0800)]
Revert "Deprecate iOS 8 and earlier (#626)"
This reverts commit
c4b1c88f506ebf76a2a40f005b45ec9b24e46e1a.
Paul DiPietro [Fri, 9 Dec 2016 11:29:04 +0000 (03:29 -0800)]
Deprecate iOS 8 and earlier (#626)
E.Z. Hart [Thu, 8 Dec 2016 18:26:16 +0000 (11:26 -0700)]
Add iOS 8 status to readme
E.Z. Hart [Wed, 7 Dec 2016 23:11:14 +0000 (16:11 -0700)]
Fix for 45743 which works with iOS 8 (#616)
* Explicitly set window bounds when presenting alert
* Remove unused methods
E.Z. Hart [Wed, 7 Dec 2016 18:53:16 +0000 (11:53 -0700)]
Fix 41415 test (use rounding)
Rui Marinho [Wed, 7 Dec 2016 12:42:27 +0000 (12:42 +0000)]
[UITest] Only run 41415 test on Android
Stephane Delcroix [Wed, 7 Dec 2016 10:35:32 +0000 (11:35 +0100)]
[Xaml[C]] support op_implicit declared on Target (#585)
Stephane Delcroix [Wed, 7 Dec 2016 09:57:43 +0000 (10:57 +0100)]
[XamlC] Type ref tests, and fixes (#569)
* [XamlC] Add tests for TypeRefExts, fix and enhancements
* [XamlC] more fixes, more tests
* Fix failing test
Stephane Delcroix [Wed, 7 Dec 2016 09:57:21 +0000 (10:57 +0100)]
remove the noise while running nunit from console
E.Z. Hart [Wed, 7 Dec 2016 00:16:35 +0000 (17:16 -0700)]
Put test in the correct namespace
Jason Smith [Tue, 6 Dec 2016 17:47:37 +0000 (09:47 -0800)]
Fix wrong licenses
E.Z. Hart [Tue, 6 Dec 2016 17:23:22 +0000 (10:23 -0700)]
Possible fix for race condition in 21177 UI test
Stephane Delcroix [Tue, 6 Dec 2016 12:15:32 +0000 (13:15 +0100)]
[C] detach Behaviors and Triggers on VE finalization (#555)
* [C] detach Behaviors and Triggers on VE finalization
* update docs
adrianknight89 [Tue, 6 Dec 2016 12:14:38 +0000 (06:14 -0600)]
[Android] Dismiss context menu when view cell is removed (#568)
* close context action when cell is no longer available
* rename method
adrianknight89 [Tue, 6 Dec 2016 12:09:05 +0000 (06:09 -0600)]
[iOS] Fix crash when pushing page on stack on orientation change (#607)
* Fix orientation crash
* remove braces
adrianknight89 [Tue, 6 Dec 2016 12:07:29 +0000 (06:07 -0600)]
[Android] ScrollView should send correct ScrollX and ScrollY (#394)
* Android should show correct ScrollX and ScrollY when scrolling in both directions
* Adding sample code to demonstrate scrolling
* Orientation fix
* ScrollTo should work for horizontal + vertical scrolling
* Get correct scroll x and y values for ScrollOrientation.Both
* Convert positions to pixels
* Adding unit test to watch out for incorrect animation positioning
* automated test
* improvements
* fixed texts
Paul DiPietro [Tue, 6 Dec 2016 12:01:43 +0000 (05:01 -0700)]
[WinRT] Do not store previous page when popping (#565)
Michael Rumpler [Tue, 6 Dec 2016 11:59:43 +0000 (12:59 +0100)]
Don't render empty TextCells for TableSections without Title (bugs 26104 and 42926) (#287)
* Don't render empty TextCells for TableSections without Title (bugs 26104 and 42926)
* Cache the Cells so that GetCellForPosition doesn't have to iterate all Cells every time it is called
Stephane Delcroix [Tue, 6 Dec 2016 07:56:08 +0000 (08:56 +0100)]
ResourceDictionary fixes (#536)
* [C] avoid leaking RDs, remove reflection call, validate arguments
* [C,Xaml] The only way to get merged values are internal
Mike Norman [Mon, 5 Dec 2016 18:12:31 +0000 (12:12 -0600)]
Typos bug sweep. (#613)
Just typos.
Stephane Delcroix [Mon, 5 Dec 2016 12:40:12 +0000 (13:40 +0100)]
[XamlC] Compile ContraintTypeConverters (#592)
* [XamlC] Compile ContraintTypeConverters
* fix error message
Stephane Delcroix [Mon, 5 Dec 2016 12:31:31 +0000 (13:31 +0100)]
[XamlC] drop ICSharpCode.Decompiler (#586)
* [XamlC] drop ICSharpCode.Decompiler
* update nuspec
* fix typo
Paul DiPietro [Mon, 5 Dec 2016 10:43:24 +0000 (03:43 -0700)]
[WinRT/UWP] Adjust margin for centered Slider (#604)
Stephane Delcroix [Mon, 5 Dec 2016 09:32:28 +0000 (10:32 +0100)]
[Xaml] revert namespace change for XmlnsDefAttr (#610)
* [Xaml] revert namespace change for XmlnsDefAttr
* fix
Mike Norman [Mon, 5 Dec 2016 01:29:50 +0000 (19:29 -0600)]
Catch-up in Xamarin.Forms.[Core|Pages|Xaml] (#606)
Stephane Delcroix [Sun, 4 Dec 2016 21:13:54 +0000 (22:13 +0100)]
[Xaml] change namespace for [XmlnsDef] and make it internal (#557)
* [Xaml] change namespace for [XmlnsDef] and make internal
* fix docs
Stephane Delcroix [Sun, 4 Dec 2016 21:08:11 +0000 (22:08 +0100)]
[Xaml] support arrays as x:Arguments (#545)
* [Xaml] port some FactoryMethod tests to XamlC
* [Xaml] support array parameters in factory ctors
* [XamlC] support arrays as x:Arguments
* fix build
adrianknight89 [Sun, 4 Dec 2016 13:44:40 +0000 (07:44 -0600)]
dispose tap gesture (#601)
Rui Marinho [Sat, 3 Dec 2016 00:40:38 +0000 (00:40 +0000)]
Fix iOS10 build lane info
Jimmy Garrido [Sat, 3 Dec 2016 00:17:38 +0000 (16:17 -0800)]
Fix CommandBar overlaying content (#593)
E.Z. Hart [Fri, 2 Dec 2016 23:52:31 +0000 (16:52 -0700)]
Restore old Alert/ActionSheet method for iOS 8 (#595)
* Rename action sheet overload
* Restoring iOS8-compatible alert/actionsheet handling
E.Z. Hart [Fri, 2 Dec 2016 21:47:57 +0000 (14:47 -0700)]
Update NavigationPage Platform Specifics demo with pre-393 compatible color
Stephane Delcroix [Fri, 2 Dec 2016 21:01:57 +0000 (22:01 +0100)]
fix build
E.Z. Hart [Fri, 2 Dec 2016 20:48:42 +0000 (13:48 -0700)]
Allow CommandBar to expand and show command labels (#594)
* Allow CommandBar to expand and show command labels
Consolidate command bar placement code
* Make title text wrapping consistent between NavigationPage and MasterDetailPage
* Align toolbar/navigation bar behavior with other platforms
Stephane Delcroix [Fri, 2 Dec 2016 20:36:10 +0000 (21:36 +0100)]
[XamlC] passing test for 47703
Stephane Delcroix [Thu, 1 Dec 2016 22:39:47 +0000 (23:39 +0100)]
fix the tests
Mike Norman [Thu, 1 Dec 2016 21:55:02 +0000 (15:55 -0600)]
Last of Xamarin.Forms namespace internal items. (#589)
Stephane Delcroix [Thu, 1 Dec 2016 21:54:14 +0000 (22:54 +0100)]
Revert "Jimmgarrido uwp toolbar (#588)"
This reverts commit
1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.
Stephane Delcroix [Thu, 1 Dec 2016 21:40:20 +0000 (22:40 +0100)]
[XamlC] provide backward compat for ProvideValueTarget without Target… (#583)
* [XamlC] provide backward compat for ProvideValueTarget without TargetProperty
* docs
Stephane Delcroix [Thu, 1 Dec 2016 21:39:43 +0000 (22:39 +0100)]
Jimmgarrido uwp toolbar (#588)
* Fixed CommandBar being clipped when expanded by removing explicit Height
* Add UITest
Stephane Delcroix [Thu, 1 Dec 2016 21:34:39 +0000 (22:34 +0100)]
[XamlC] use op_implicit where we should (#580)
* [XamlC] (passing) test for 48242
* [XamlC] (failing) test for 48242
* [XamlC] more op_implicit conversions
* additional test
* fix rebase
Stephane Delcroix [Thu, 1 Dec 2016 21:26:05 +0000 (22:26 +0100)]
[Xaml] support non-int enums (#575)
E.Z. Hart [Thu, 1 Dec 2016 21:15:17 +0000 (14:15 -0700)]
Don't run Command CanExecute on incorrect inherited binding context type (#572)
* Allow Command CanExecute to recover when run on inherited bindingcontext
* Make exception handler more generic
* Checking types in Command delegates to avoid exception in the first place
* Adding type chekc to other Command constructor
* Use nameof for ArgumentNullExceptions
* Add unit tests for null parameters, handle value types and Nullable<T>
Stephane Delcroix [Thu, 1 Dec 2016 21:14:22 +0000 (22:14 +0100)]
[XamlC] assigned derived type to generic BP (#566)
* [XamlC] assigned derived type to generic BP
* [XamlC] fix 48554
* f
Stephane Delcroix [Thu, 1 Dec 2016 21:10:11 +0000 (22:10 +0100)]
[XamlC] support non-generic IMarkup on ABPs (#562)
* [XamlC] support custom markups on ABPs
* [XamlC] test for 47950
adrianknight89 [Thu, 1 Dec 2016 00:29:16 +0000 (18:29 -0600)]
fix NRE in packager dispose (#561)
Rui Marinho [Wed, 30 Nov 2016 20:09:57 +0000 (20:09 +0000)]
[iOS] Avoid using DrawRect on base VisualElementRenderer (#570)
* [Controls] Add retro for Bugzilla 48158
* [iOS] Avoid using DrawRect as this will make some properties not being applied to the layer
* [iOS] Make sure BoxRenderer calls base LayoutSubviews
* [iOS] Better fix for adding the Blur effect and avoid override draw’s
* [Controls] Remove extra nunit category
E.Z. Hart [Wed, 30 Nov 2016 18:08:30 +0000 (11:08 -0700)]
Fix Issue 774 test so it works with wrapped IApp on phone and tablet
Rui Marinho [Wed, 30 Nov 2016 11:21:30 +0000 (11:21 +0000)]
[Win] Update cert (#579)