platform/core/ml/nnfw.git
5 years agoRemove unnecessary headers from arm_compute/core/CL/* (#3371)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 29 Oct 2018 02:13:28 +0000 (07:43 +0530)]
Remove unnecessary headers from arm_compute/core/CL/* (#3371)

This patch will remove unnecessary headers included in the following files:

arm_compute/core/CL/kernels/CLActivationLayerExKernel.h
arm_compute/core/CL/kernels/CLArithmeticSubtractionExKernel.h
arm_compute/core/CL/kernels/CLEqualKernel.h
arm_compute/core/CL/kernels/CLGatherKernel.h
arm_compute/core/CL/kernels/CLNegKernel.h
arm_compute/core/CL/kernels/CLPixelWiseDivisionKernel.h
arm_compute/core/CL/kernels/CLReduceMaxKernel.h
arm_compute/core/CL/kernels/CLReductionMeanKernel.h
arm_compute/core/CL/kernels/CLSquaredDifferenceKernel.h
arm_compute/core/CL/kernels/CLStridedSliceKernel.h

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoUpdating addStage function declaration of Iplanbuilder (#3355)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 29 Oct 2018 02:10:59 +0000 (07:40 +0530)]
Updating addStage function declaration of Iplanbuilder (#3355)

This patch updates the declaration of addStage function of Iplanbuilder and it's associated comments.
Due to ambiguous 's' in doxygen comment, this change is made.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAllign comment to have same formatting (#3369)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 29 Oct 2018 02:08:48 +0000 (07:38 +0530)]
Allign comment to have same formatting (#3369)

This patch will remove tab spaces and align the comment to have same formating style in same_padding function

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoSupport Padding accross all dimensions (#3305)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 29 Oct 2018 01:08:36 +0000 (06:38 +0530)]
Support Padding accross all dimensions (#3305)

This patch will provide support to pad accross all dimensions of input tensor

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoCorrecting and adding arm_compute assertions in CL core/kernel files (#3312)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 26 Oct 2018 08:26:16 +0000 (13:56 +0530)]
Correcting and adding arm_compute assertions in CL core/kernel files (#3312)

This patch will add more asertions required to be tested and corrects the wrong assertions that have been added.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRevise docker_build_cross_arm_ubuntu.sh (#3348)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 26 Oct 2018 00:39:36 +0000 (09:39 +0900)]
Revise docker_build_cross_arm_ubuntu.sh (#3348)

Revise docker_build_cross_arm_ubuntu.sh
- Remove using nnfw_docker file
- Use docker-run and docker-shell command

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoIntroduce ArgMax operation. (#3288)
PRAVEEN DORESWAMY NAIDU/System SW /SRI-Bangalore/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 10:51:14 +0000 (16:21 +0530)]
Introduce ArgMax operation. (#3288)

This patch will introduce the ArgMax operation in NNFW.

Signed-off-by: Praveen D N <praveen.dn@samsung.com>
5 years ago[neurun] Fix Shape4D in LowerInfo order (#3339)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 10:46:32 +0000 (19:46 +0900)]
[neurun] Fix Shape4D in LowerInfo order (#3339)

Fix Shape4D order bug (NHWC)

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix padding bug of EmbeddingLookup (#3184)
장지섭/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 25 Oct 2018 10:42:59 +0000 (19:42 +0900)]
Fix padding bug of EmbeddingLookup (#3184)

This commit fixes padding bug of EmbeddingLookup.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoSupport HashtableLookup greater than 2 dimensions (#3210)
장지섭/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 25 Oct 2018 09:43:05 +0000 (18:43 +0900)]
Support HashtableLookup greater than 2 dimensions (#3210)

This commit supports HashtableLookup greater than 2 dimensions.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoFix docker-shell command bug (#3336)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 08:22:16 +0000 (17:22 +0900)]
Fix docker-shell command bug (#3336)

Need docker option -it for interactive

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove unused headers and functions (#3316)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 25 Oct 2018 07:33:37 +0000 (13:03 +0530)]
Remove unused headers and functions (#3316)

This patch will remove all unused headers and functions from following files:
CLActivationLayerExKernel.cpp
CLBatchToSpaceNDKernel.cpp
CLDepthToSpaceKernel.cpp
CLEqualKernel.cpp
CLGatherKernel.cpp
CLNegKernel.cpp
CLPixelWiseDivisionKernel.cpp
CLReduceMaxKernel.cpp
CLReduceSumKernel.cpp
CLReductionMeanKernel.cpp
CLSpaceToDepthKernel.cpp
CLSquaredDifferenceKernel.cpp
CLStridedSliceKernel.cpp

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoCheck invalid format-checker exit (#3327)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 07:18:43 +0000 (16:18 +0900)]
Check invalid format-checker exit (#3327)

Check invalid format-checker exit and return fail

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUpdate docker-shell and configuration (#3324)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 04:27:07 +0000 (13:27 +0900)]
Update docker-shell and configuration (#3324)

* Update docker-shell and configuration

Update docker-shell

- Use docker.configuration

Update docker.configuration

- Change default docker image name
- Fix tab to space
- Fix setting DOCKER_VOLUMES variable
- Enable using environment file

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Update environment variable setting

Remove unused environment setting and add download server setting

5 years agoSetting missing quantization info (#3330)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 25 Oct 2018 04:25:44 +0000 (09:55 +0530)]
Setting missing quantization info (#3330)

This patch will pass scale and offset so as to set quantization info.
If required, this quantization info can be used by the operations

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove unused shape variables from L2Pool (#3329)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 25 Oct 2018 00:46:21 +0000 (06:16 +0530)]
Remove unused shape variables from L2Pool (#3329)

This patch will remove the unused shape variable from L2Pool.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd Generated Test for Testing broadcast DIV (#3296)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 25 Oct 2018 00:40:38 +0000 (06:10 +0530)]
Add Generated Test for Testing broadcast DIV (#3296)

This patch adds a generated test for testing broadcast DIV.
This consist of testing broadcast div with tensors of shape 4D & 2D.
Added GTest : div_broadcast_float_4D_2D_nnfw

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoFix python syntax error (#3326)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 25 Oct 2018 00:09:52 +0000 (09:09 +0900)]
Fix python syntax error (#3326)

Fix python syntax error in select_operator.py

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoChange misleading FATAL error message from nnapi_delegate (#3307)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 22:19:57 +0000 (03:49 +0530)]
Change misleading FATAL error message from nnapi_delegate (#3307)

This patch changes misleading FATAL error message from nnapi_delegate for ```BatchToSpaceND```

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoRemove unused build script (#3323)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 24 Oct 2018 11:09:21 +0000 (20:09 +0900)]
Remove unused build script (#3323)

Remove unused two build script
- docker_build_cross_arm_neurun.sh (can build neurun using env file)
- docker_build_cross_arm_ubuntu_without_aclbuild.sh

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove passing pad gtest from skiplist (#3320)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 11:05:04 +0000 (16:35 +0530)]
Remove passing pad gtest from skiplist (#3320)

This patch will remove pad gtest from skiplist

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoUpdate `run_benchmark_op.sh` to enable neon properly (#3318)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 24 Oct 2018 11:03:30 +0000 (20:03 +0900)]
Update `run_benchmark_op.sh` to enable neon properly (#3318)

Related Issue: #3262

`run_benchmark_op.sh` was written in the era of legacy runtime.
Currently we uses pure acl runtime as default.
Thus, I updated the way of enabling neon, and the labels.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoUpdate assertions for BatchToSpaceND op in compile time. (#3286)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 11:03:02 +0000 (16:33 +0530)]
Update assertions for BatchToSpaceND op in compile time. (#3286)

This patch updates the assertions required for BatchToSpaceND at compile time in PACL.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoRemoving unused cstdint header from the runtime/CL/functions/CL* (#3311)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 09:51:14 +0000 (15:21 +0530)]
Removing unused cstdint header from the runtime/CL/functions/CL* (#3311)

This patch will remove cstdint header from runtime/CL/functions/CL* since it is not getting used.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdding function call to validate_arg in CLGatherKernel.cpp (#3314)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 09:10:50 +0000 (14:40 +0530)]
Adding function call to validate_arg in CLGatherKernel.cpp (#3314)

This patch will add function call to validate_arg which was defined but was not getting used.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoUtility function to get ACL_PermutationVector from Runtime_PV (#3128)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 08:31:10 +0000 (14:01 +0530)]
Utility function to get ACL_PermutationVector from Runtime_PV (#3128)

For issue #3022
This commit adds a function that converts the Permutation vector of the runtime into the Permutation Vector of ACL

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd CL Kernel Calls for SpaceToDepth from runtime. (#3267)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 07:25:48 +0000 (12:55 +0530)]
Add CL Kernel Calls for SpaceToDepth from runtime. (#3267)

This patch adds CL Kernel Calls for SpaceToDepth from runtime

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemoving TODO comment for reshape (#3309)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 04:21:27 +0000 (09:51 +0530)]
Removing TODO comment for reshape (#3309)

This patch will remove TODO assert comment of reshape since that TODO is already implemented.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoFix typos in Shape.h's comment (#3317)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 24 Oct 2018 04:21:01 +0000 (13:21 +0900)]
Fix typos in Shape.h's comment (#3317)

I've found a lot of typos in Shape.h during reading code for SMP documentation.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoRemoving typo in comment for Squaredifference (#3310)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 01:34:33 +0000 (07:04 +0530)]
Removing typo in comment for Squaredifference (#3310)

This patch will remove the typing error for comment related to #define in SquareDifference op

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove Passing gtest of max_pool and avg_pool from skiplist (#3302)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 01:21:50 +0000 (06:51 +0530)]
Remove Passing gtest of max_pool and avg_pool from skiplist (#3302)

This patch will remove passing gtest of max and avg pool from skiplist

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[tfltool] Op selector for LRN (#3284)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 01:08:34 +0000 (06:38 +0530)]
[tfltool] Op selector for LRN (#3284)

This patch will provide support to select LRN op in select_operator.py

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd if defined block and remove ambiguous comments from BatchToSpaceND CL kernel...
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 24 Oct 2018 01:08:13 +0000 (06:38 +0530)]
Add if defined block and remove ambiguous comments from BatchToSpaceND CL kernel (#3294)

This patch adds if defined block and removes ambiguous comment from BatchToSpaceND CL Kernel.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoAdding assertions block for SpaceToBatch layer (#3269)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Tue, 23 Oct 2018 13:21:42 +0000 (18:51 +0530)]
Adding assertions block for SpaceToBatch layer (#3269)

This patch will add assertions for SpaceToBatch layer in visit function to handle exceptions

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Add default generate method (#3293)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 23 Oct 2018 09:37:28 +0000 (18:37 +0900)]
[neurun] Add default generate method (#3293)

Add default generate method for all IInitalizerGenerator. It returns
an empty list - i.e. no-op. Also this makes `Planner::visit` methods
call the initializer generation so all of them are identical. Later,
Planner implementation will be unified.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoAdd GTests for Equal_Ex (#3030)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Tue, 23 Oct 2018 09:35:16 +0000 (15:05 +0530)]
Add GTests for Equal_Ex (#3030)

equal_ex_1D_float.mod.py for 1D Tensor Inputs.
    equal_ex_4D_float.mod.py for 4D Tensor Inputs.
    equal_ex_quant.mod.py for QUANT8 Inputs.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoFix build command script (#3299)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 23 Oct 2018 08:32:49 +0000 (17:32 +0900)]
Fix build command script (#3299)

Fix build command script
- configure: Add home, binary home option
- build-acl: Fix to build-acl before configure

By this, we can build
"[env-set] ./run build-acl & [env-set] ./run configure & ./run build & ./run install"

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoIntroduce ArgMax_EX in NeuralNetworkEx (#3207)
PRAVEEN DORESWAMY NAIDU/System SW /SRI-Bangalore/Staff Engineer/삼성전자 [Tue, 23 Oct 2018 07:48:20 +0000 (13:18 +0530)]
Introduce ArgMax_EX in NeuralNetworkEx (#3207)

Introducing ArgMax operation in NeuralNetworkEx.

Signed-off-by: Praveen D N <praveen.dn@samsung.com>
5 years ago[neurun] Rename OperandConstraint generators (#3291)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 23 Oct 2018 03:03:43 +0000 (12:03 +0900)]
[neurun] Rename OperandConstraint generators (#3291)

This commit renames OperandConstraint static generator methods to be
natural.

Resolve #3239

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Add missed license to newly added files (#3290)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 23 Oct 2018 01:39:30 +0000 (10:39 +0900)]
[neurun] Add missed license to newly added files (#3290)

This commit adds missed license to newly added files.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoAdd restrictions and comments for several operations applying reducing (#3280)
장지섭/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 23 Oct 2018 00:51:37 +0000 (09:51 +0900)]
Add restrictions and comments for several operations applying reducing (#3280)

This commit adds restrictions and comments for several operations applying reducing.

- Restrictions
  In case of that input rank is 4 and output rank is not 4, supports reducing height and width or reducing depth.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoPAD op in PACL as CPU Fallback (#2857)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Tue, 23 Oct 2018 00:09:55 +0000 (05:39 +0530)]
PAD op in PACL as CPU Fallback (#2857)

This patch will add PAD op in PACL as CPU version

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoSupport scalar type for operand rank larger than 0 (#3281)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 22 Oct 2018 09:16:19 +0000 (18:16 +0900)]
Support scalar type for operand rank larger than 0 (#3281)

Support scalar type for operand rank larger than 0
Operand rank can be changed to 1 ~ 4 for broadcast operation

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove conflict helper comments in FeatureLoggingLayer.h (#3282)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Mon, 22 Oct 2018 08:12:48 +0000 (17:12 +0900)]
Remove conflict helper comments in FeatureLoggingLayer.h (#3282)

This commit removes conflict helper comments in `FeatureLoggingLayer.h`

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoAdd missed comment in asARMComputeCoordinates function (#3268)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 22 Oct 2018 06:34:01 +0000 (12:04 +0530)]
Add missed comment in asARMComputeCoordinates function (#3268)

This patch will add missed comments for asARMComputeCoordinates function in Cast.h

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Change bg color managing and colors in DotDumper (#3257)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Mon, 22 Oct 2018 06:32:14 +0000 (15:32 +0900)]
[neurun] Change bg color managing and colors in DotDumper (#3257)

close : #3241

This commit changes bg color managing and color scheme in DotDumper.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoAdd missing Apache License to PACK op. (#3277)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 22 Oct 2018 05:49:41 +0000 (11:19 +0530)]
Add missing Apache License to PACK op. (#3277)

This patch adds apache license to PACK op.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoPatch to remove unused shape variables (#3271)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Mon, 22 Oct 2018 04:53:27 +0000 (10:23 +0530)]
Patch to remove unused shape variables (#3271)

This patch will remove unused shape variables.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoCheck url for external source download (#3275)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 22 Oct 2018 02:50:51 +0000 (11:50 +0900)]
Check url for external source download (#3275)

Check url for external source download
If download url is not matched, download again

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix line-break automatically in format-checker.sh (#3256)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Mon, 22 Oct 2018 01:12:22 +0000 (10:12 +0900)]
Fix line-break automatically in format-checker.sh (#3256)

- CRLF, CR style line break are fixed automatically.
 : Diff can be found in format.patch

- Missed double-quote is added.
It caused the output string printed in one line without "\n".

- Removed `function` keyword that remained.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoRemove modelgen tool (#3263)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 19 Oct 2018 08:47:38 +0000 (17:47 +0900)]
Remove modelgen tool (#3263)

Remove modelgen tool since it can be done with tflchef from nncc.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[Coverage] Remove codes for CPU from CLStridedSlice (#3238)
장지섭/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 19 Oct 2018 07:21:28 +0000 (16:21 +0900)]
[Coverage] Remove codes for CPU from CLStridedSlice (#3238)

This commit Removes codes for CPU from CLStridedSlice.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoIntroduce install script (#3254)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 19 Oct 2018 07:19:49 +0000 (16:19 +0900)]
Introduce install script (#3254)

* Introduce install script

introduce install script
Howto:  On project root, "./run install" with environment variable setting

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Remove ambiguous comment

5 years agoFix neurun build option (#3253)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 19 Oct 2018 02:26:33 +0000 (11:26 +0900)]
Fix neurun build option (#3253)

Fix neurun build option in cmake option setting: BUILD_NEURUN

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Introduce Add operation (#3246)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 19 Oct 2018 01:33:41 +0000 (10:33 +0900)]
[neurun] Introduce Add operation (#3246)

* [neurun] Introduce Add operation

This commit introduces Add operation. For neurun we avoid adding
operations before we fix the API for the backends, however this is an
exception for testing broadcast Add.

Backend implementations are NYI.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Throw `std::runtime_error`

5 years agoinstall all skiplist file (#3209)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 19 Oct 2018 01:21:10 +0000 (10:21 +0900)]
install all skiplist file (#3209)

* install all skiplist file

install all skiplist file when enable building both runtime
User can change skiplist file by copy or rename

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix unittest script

Fix unittest script ignore *.skip* files

5 years agoAdd CL kernel to provide GPU support for SpaceToDepth op (#3134)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 01:08:32 +0000 (06:38 +0530)]
Add CL kernel to provide GPU support for SpaceToDepth op (#3134)

This patch will provide kernel to execute SpaceToDepth op on GPU

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRevise build script and introduce build-acl script (#3214)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 19 Oct 2018 00:54:42 +0000 (09:54 +0900)]
Revise build script and introduce build-acl script (#3214)

* Revise build script and introduce build-acl script

Revise build script
Introduce build-acl script

Howto : On project root, "./run build-acl" or "./run build" with environment variable setting

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Change all tab to space

* Change all tab to space and remove unnecessary line: build-acl

5 years ago[neurun][dotdumper] Introduce NodeAttr class (#3244)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 19 Oct 2018 00:53:15 +0000 (09:53 +0900)]
[neurun][dotdumper] Introduce NodeAttr class (#3244)

This commit introduces `NodeAttr` class that can be more easier to add attributes of node.

- ASIS
```
_dot << dotinfo.index_str() << " [shape=" << dotinfo.dot_shape() << " "
     << "label=\"" << dotinfo.label() << "\" "
     << "style=\"filled\" "
     << "fillcolor=\"" << dotinfo.bg_color() << "\"];\n";

- TOBE
```
NodeAttr attr;

attr.addAttr("shape", dotinfo.dot_shape())
    .addAttr("label", dotinfo.label())
    .addAttr("style", "filled")
    .addAttr("fillcolor", dotinfo.bg_color());
attr.finish();

_dot << dotinfo.index_str() << attr.attr_stream();
```

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoAdd CL kernel to provide GPU support for DepthToSpace op (#3166)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 00:48:07 +0000 (06:18 +0530)]
Add CL kernel to provide GPU support for DepthToSpace op (#3166)

This patch will provide kernel to execute DepthToSpace op on GPU

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd CL Kernel calls for Equal op from runtime. (#3107)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 00:26:05 +0000 (05:56 +0530)]
Add CL Kernel calls for Equal op from runtime. (#3107)

This patch adds CL Kernel calls for Equal op from runtime.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoInitialize Objects and other variables (#3237)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 00:23:40 +0000 (05:53 +0530)]
Initialize Objects and other variables (#3237)

This patch will initialize Objects and other variables in BatchToSpaceND

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoRemoving LRN gtest from skiplist (#2782)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 00:22:57 +0000 (05:52 +0530)]
Removing LRN gtest from skiplist (#2782)

With #2643 the 3 LRN cases passed. Removing from skiplist.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoSpelling error in comments (#3247)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Fri, 19 Oct 2018 00:22:36 +0000 (05:52 +0530)]
Spelling error in comments (#3247)

This patch will coorect the spelling of the error introduced in comment in Cast.h

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemoving unused variables from layers (#3245)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 22:28:59 +0000 (03:58 +0530)]
Removing unused variables from layers (#3245)

This patch will remove unused buffer variables

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove unused shape variables from visit func (#3221)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 22:28:36 +0000 (03:58 +0530)]
Remove unused shape variables from visit func (#3221)

This patch removes the unused shape variables.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdded assertion in Reshape (#3050)
Vishal Keshav/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 11:44:46 +0000 (17:14 +0530)]
Added assertion in Reshape (#3050)

Assertion verifies if input can be reshaped to output

Signed-off-by: Vishal Keshav <vishal.k1@samsung.com>
5 years agoAdding Node for pack operation (#3193)
Vishal Keshav/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 11:42:09 +0000 (17:12 +0530)]
Adding Node for pack operation (#3193)

Adding operation node for pack operation

Signed-off-by: Vishal keshav <vishal.k1@samsung.com>
5 years ago[neurun] Make DotDumper to show backend info for operands (#3240)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 18 Oct 2018 11:22:38 +0000 (20:22 +0900)]
[neurun] Make DotDumper to show backend info for operands (#3240)

Related : #3236

This commit makes `DotDumper` to show backend info for operands.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[cherry-pick] Add comment for doxygen comment (#3242)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 18 Oct 2018 11:19:28 +0000 (20:19 +0900)]
[cherry-pick] Add comment for doxygen comment (#3242)

Add comment for doxygen comment: cherry-pick and squash
Cherry-pick: 4ea8ef6^...2e50d14 811fe2d 9dc33a9 671e570

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove/Change misleading comments from internal/op (#3223)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 08:29:40 +0000 (13:59 +0530)]
Remove/Change misleading comments from internal/op (#3223)

This patch removes/ changes misleading commments from internal/op directory.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoAdd CL Kernel Calls for BatchToSpaceND from runtime. (#3220)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 08:26:15 +0000 (13:56 +0530)]
Add CL Kernel Calls for BatchToSpaceND from runtime. (#3220)

This patch adds CL Kernel Calls for BatchToSpaceND from runtime.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years ago[neurun] Refine the loop in lower method (#3235)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 18 Oct 2018 07:15:21 +0000 (16:15 +0900)]
[neurun] Refine the loop in lower method (#3235)

Make the loop simpler that assigns backends for model input and outputs.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Fix markTensor implementation (#3233)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 18 Oct 2018 07:12:50 +0000 (16:12 +0900)]
[neurun] Fix markTensor implementation (#3233)

This will fix the issue that operands are set multiple times from
`PlanBuilder::finalize`. Operation based iteration can cause this
problem so this commit changes it to iterate with operands.

Also this commit assigns def backend for constants which were not
assigned.

Fix #3126

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoSuppress `which`'s output from format-checker.sh (#3232)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 18 Oct 2018 06:33:59 +0000 (15:33 +0900)]
Suppress `which`'s output from format-checker.sh (#3232)

- Suppress output from `which` command
- Replace `which` to `command -v` for support builtin command also
- Remove function keywords for better portability

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years ago[neurun][dotdumer] Fix model output naming bug (#3231)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 18 Oct 2018 06:18:42 +0000 (15:18 +0900)]
[neurun][dotdumer] Fix model output naming bug (#3231)

This commit fixes model output naming bug that shows the name with 'obj' prefix.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoIntroduce configure script (#3180)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 18 Oct 2018 06:17:21 +0000 (15:17 +0900)]
Introduce configure script (#3180)

* Introduce configure script

Introduce configure script
- prepare to use this script instead of Makefile
- Howto: On project root, "./run configure" with environment variable setting

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix

- Generate install path and alias
- Change variable name for build/install path alias

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix and remove unused variable

- Remove unused variable
- Fix bug: string compare to substring

* Change all tab to space

5 years agoSeparate Declaration and Definition of SimpleCastLayer. (#3191)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Thu, 18 Oct 2018 06:12:12 +0000 (11:42 +0530)]
Separate Declaration and Definition of SimpleCastLayer. (#3191)

This patch separates the declaration and definition of functions in SimpleCastLayer.
Purpose: Impose uniformity and better organization.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years ago[neurun][dotdumper] Make each backend shows different bg colors (#3217)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 18 Oct 2018 02:56:30 +0000 (11:56 +0900)]
[neurun][dotdumper] Make each backend shows different bg colors (#3217)

This commit makes each backend shows different bg color when dot dumping.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoApply CRLF check for all regular files (#3179)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 18 Oct 2018 02:01:11 +0000 (11:01 +0900)]
Apply CRLF check for all regular files (#3179)

All regular files under git-control are CRLF checked.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoAdd LRN codes to support both odd & even values (#2906)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 10:38:13 +0000 (16:08 +0530)]
Add LRN codes to support both odd & even values (#2906)

This patch contains RS7-RuntimeNTools/ComputeLibrary#47 PR
Updated license contents for CLNormalizationLayerEx

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd CL Kernels for BatchToSpaceND (#3203)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 10:37:09 +0000 (16:07 +0530)]
Add CL Kernels for BatchToSpaceND (#3203)

This patch adds BatchToSpaceND operation's CL Kernel.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoAdd GTest to test for the enabled Broadcast feature in SquaredDifference op (#3185)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 10:36:16 +0000 (16:06 +0530)]
Add GTest to test for the enabled Broadcast feature in SquaredDifference op (#3185)

This patch adds GTest to test for the enabled Broadcast feature in SquaredDifference op.
Added GTests:
```
squared_difference_ex_broadcast
squared_difference_ex_broadcast_4D_2D
```
Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoAdd CL Kernels for Equal op (#3029)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 10:36:03 +0000 (16:06 +0530)]
Add CL Kernels for Equal op (#3029)

This patch adds CL Kernels for Equal op.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years ago[neurun] Make TensorBuilder on CPU have MemoryAllocator (#3215)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 07:06:14 +0000 (16:06 +0900)]
[neurun] Make TensorBuilder on CPU have MemoryAllocator (#3215)

* [neurun] Make TensorBuilder have MemoryAllocator

Makes TensorBuilder have MemoryAllocator as its member. Now there is no
resolution to access MemoryAllocator globally.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
* Fix format-checker fail

5 years agoIntroduce UNPACK_EX in NeuralNetworkEx (#3189)
Vishal Keshav/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 06:53:53 +0000 (12:23 +0530)]
Introduce UNPACK_EX in NeuralNetworkEx (#3189)

Introduced upack_ex in neural network ex

Signed-off-by: Vishal keshav <vishal.k1@samsung.com>
5 years ago[neurun] Remove Source/Sink codes divided to dimensions (#3213)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 06:01:53 +0000 (15:01 +0900)]
[neurun] Remove Source/Sink codes divided to dimensions (#3213)

Related : #2874

Part of : #3178

Because #3208 and #3187 are merged, we can remove `Source`/`Sink` codes divided to dimensions.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoAdd NNAPI_Delegation for SQUEEZE (#3065)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 05:48:33 +0000 (11:18 +0530)]
Add NNAPI_Delegation for SQUEEZE (#3065)

This patch adds NNAPI Delegation for SQUEEZE op.
Related issue: #2891 #2884

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoFix offset bug for BatchToSpace (#3204)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 05:19:14 +0000 (10:49 +0530)]
Fix offset bug for BatchToSpace (#3204)

For issue #3105

This patch will fix offset bug from BatchToSpace

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Get only CPU shape as Input/Output (#3208)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 05:14:31 +0000 (14:14 +0900)]
[neurun] Get only CPU shape as Input/Output (#3208)

This commit gets only CPU shape as Input/Output(it would insert Permute ops).

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoRemove Unsupported Datatype Cases in DepthToSpace (#3202)
Shubham Gupta/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 04:36:37 +0000 (10:06 +0530)]
Remove Unsupported Datatype Cases in DepthToSpace (#3202)

NN api defines only for U8 and F32 dataype for DepthToSpace op.
Hence, leaving code only for supported dataypes.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove passed GTest from Skiplist (#3200)
Prasanna R/System SW /SRI-Bangalore/Engineer/삼성전자 [Wed, 17 Oct 2018 04:04:52 +0000 (09:34 +0530)]
Remove passed GTest from Skiplist (#3200)

This patch removes passed GTests batch_to_space* from skip_list.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years ago[neurun] Introduce OperandConstraint (#3182)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 01:15:24 +0000 (10:15 +0900)]
[neurun] Introduce OperandConstraint (#3182)

Introduce OperandConstraint to simplify implementation of
setInputs/Outputs. They were virtual methods but this commit makes it
non-virtual to make the code simpler. Instead `Node` class now uses
`OperandConstraint` which limits the number of input operands(and
possibly output operands).

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Workaround for operand::Set iteration (#3196)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 01:14:51 +0000 (10:14 +0900)]
[neurun] Workaround for operand::Set iteration (#3196)

`OperandPass` sometimes manipulate the set while iteration, this
workaround forces the `iterate` method to iterate only elements that
has been existed from the beginning of the iteration.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Fix use of static var in BackendResolver (#3195)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 01:14:37 +0000 (10:14 +0900)]
[neurun] Fix use of static var in BackendResolver (#3195)

Using static local variable can cause when compilation multiple times in
a run. This was first known by #3178(Not because of this, but it is
shown with this PR).

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Introduce IMemoryAllocator (#3190)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 01:13:51 +0000 (10:13 +0900)]
[neurun] Introduce IMemoryAllocator (#3190)

Introduces IMemoryAllocator as an interface of memory allocator. Now
BumpAllocator inherits to it.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
5 years ago[neurun] Refine BackendManager ctor (#3206)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 17 Oct 2018 01:13:21 +0000 (10:13 +0900)]
[neurun] Refine BackendManager ctor (#3206)

This commit makes the local variables more readable. The prefix can be
removed since we have two different blocks and fix the wrong name
`backend_initializer to be `config`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove duplicated header inclusion in ARMComputeEx (#3160)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 17 Oct 2018 00:55:26 +0000 (09:55 +0900)]
Remove duplicated header inclusion in ARMComputeEx (#3160)

CLHelpers.h is included twice so it is removed.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years ago[cherry-pick] Build tflite_benchmark on gbs build (#3176)
오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 17 Oct 2018 00:54:51 +0000 (09:54 +0900)]
[cherry-pick] Build tflite_benchmark on gbs build (#3176)

Enable building tflite_benchmark on gbs build
Catch exception in main to remove warning
Change makefile to build tflite_benchmark on testbuild

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove duplicated header inclusion (#3168)
PRAVEEN DORESWAMY NAIDU/System SW /SRI-Bangalore/Staff Engineer/삼성전자 [Tue, 16 Oct 2018 11:04:03 +0000 (16:34 +0530)]
Remove duplicated header inclusion (#3168)

Multiple inclusions in the same file -<memory>
<cassert> present in model.h.

Signed-off-by: Praveen D N <praveen.dn@samsung.com>