tomhudson@google.com [Wed, 30 May 2012 17:38:57 +0000 (17:38 +0000)]
Encapsulate code required to create a uniform var into a single function on
GrGLShaderBuilder. This isolates internal dependencies from somebody
writing a CustomStage.
http://codereview.appspot.com/6248050/
git-svn-id: http://skia.googlecode.com/svn/trunk@4081
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 30 May 2012 16:54:13 +0000 (16:54 +0000)]
Refactor dictionaries for use by entities other than just SkPicture
Review URL: https://codereview.appspot.com/6101043
git-svn-id: http://skia.googlecode.com/svn/trunk@4077
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 30 May 2012 16:50:11 +0000 (16:50 +0000)]
Add bench to test the performance of creating a picture.
Review URL: https://codereview.appspot.com/6258062
git-svn-id: http://skia.googlecode.com/svn/trunk@4076
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 15:19:17 +0000 (15:19 +0000)]
Added cast to get MathTest working on Windows
git-svn-id: http://skia.googlecode.com/svn/trunk@4072
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 14:46:10 +0000 (14:46 +0000)]
Added knowledge of GL_RED textures to debugGLReadPixels
http://codereview.appspot.com/6257070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4071
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 14:08:57 +0000 (14:08 +0000)]
apply 10.p+32 -> (float)(1 << 23) fix from MathTest here as well
windows can't eat the former syntax
git-svn-id: http://skia.googlecode.com/svn/trunk@4070
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Wed, 30 May 2012 13:54:41 +0000 (13:54 +0000)]
arm: First step towards dynamic NEON support.
This patch adds minimal support for dynamic ARM NEON support,
i.e. the ability to probe the CPU at runtime for NEON and
provide alternate code paths when it is available.
- Add include/core/SkUtilsArm.h, which declares a few helper
macros (e.g. SK_NEON_ARM_IS_DYNAMIC), plus the handy
function 'sk_cpu_arm_has_neon()' which returns true if
the target CPU supports the ARM NEON instruction set.
Note that the header is in include/core/ because it will
have to be included from NEON-specific code under src/code/
It would probably be more logical to put it under include/opts/
instead, but this would require moving all the NEON-specific
stuff under src/code/ into src/opts/, which is not trivial
due to the way the code is currently architected.
- Add src/core/SkUtilsArm.cpp which implements
'sk_cpu_arm_has_neon' for ARM-based Linux systems, only
when SK_NEON_ARM_IS_DYNAMIC is true.
(For other cases, 'sk_cpu_arm_has_neon' is an inline function
that returns a constant 'true' or 'false' value).
There is no user-level accessible CPUID instruction on ARM,
so do all CPU feature probing by parsing /proc/cpuinfo.
This is Linux-specific.
For Debug build types, the CPU probing result is printed
to the Android log (or Linux command-line) for easier
debugging.
- Create a new 'opts_neon' target (static library) which shall
contain all the NEON-specific code paths for the library.
This is necessary because -mfpu=neon impacts also non-scalar
code. Just like with -mssse3 on x86, we can't build the rest
of the library with this flag.
Note that for now, we only include memset16_neon and
memset32_neon in this library.
- Modify opts_check_arm.cpp to implement SK_ARM_NEON_IS_DYNAMIC
properly.
Compared to a 'xoom' build, the only difference is the use of
NEON-optimized memset16/32 functions. Later patches will move
more NEON-specific code paths to 'opts_neon'.
Review URL: https://codereview.appspot.com/6247058
git-svn-id: http://skia.googlecode.com/svn/trunk@4069
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 13:48:14 +0000 (13:48 +0000)]
use (float)(1 << 23) instead of 1.0p+23 since the latter isn't supported in VS
git-svn-id: http://skia.googlecode.com/svn/trunk@4068
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:43:59 +0000 (12:43 +0000)]
win can't eat 1.0p+23 syntax for floats :(
git-svn-id: http://skia.googlecode.com/svn/trunk@4067
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:30:09 +0000 (12:30 +0000)]
remove debugf
git-svn-id: http://skia.googlecode.com/svn/trunk@4066
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 30 May 2012 12:26:52 +0000 (12:26 +0000)]
add bench for floor variants
git-svn-id: http://skia.googlecode.com/svn/trunk@4065
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 30 May 2012 12:26:39 +0000 (12:26 +0000)]
Fixed small bug in shader generation
http://codereview.appspot.com/6259053/
git-svn-id: http://skia.googlecode.com/svn/trunk@4064
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 29 May 2012 21:28:12 +0000 (21:28 +0000)]
svndiff: report added and deleted files, not just modified files
Review URL: https://codereview.appspot.com/6260052
git-svn-id: http://skia.googlecode.com/svn/trunk@4063
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 20:48:50 +0000 (20:48 +0000)]
special-case dashing a single line-segment. We can go much faster since we
can apply the stroke as we go, eliminating the generic stroker.
Review URL: https://codereview.appspot.com/6250070
git-svn-id: http://skia.googlecode.com/svn/trunk@4062
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 19:54:52 +0000 (19:54 +0000)]
addPoly() entry-point, to quickly add MoveTo+N*LineTo (useful in dashing)
Review URL: https://codereview.appspot.com/6256063
git-svn-id: http://skia.googlecode.com/svn/trunk@4061
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 29 May 2012 19:44:14 +0000 (19:44 +0000)]
Fix line ending, mark svn:eol-style LF
git-svn-id: http://skia.googlecode.com/svn/trunk@4060
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 29 May 2012 16:53:04 +0000 (16:53 +0000)]
Fixing a reader size overflow with SkOrderedReadBuffer, when unflattening large bitmaps.
REVIEW=http://codereview.appspot.com/6250054/
git-svn-id: http://skia.googlecode.com/svn/trunk@4059
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 29 May 2012 15:33:30 +0000 (15:33 +0000)]
Update list of trybots used by https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests
TBR=reed
Review URL: https://codereview.appspot.com/6250071
git-svn-id: http://skia.googlecode.com/svn/trunk@4058
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 May 2012 12:03:46 +0000 (12:03 +0000)]
Detect when the caller was hairline AND strokeandfill, and resolve that into FILL
This fixes the unittests on WIN in the trybot for DEPS roll 4048
Review URL: https://codereview.appspot.com/6242057
git-svn-id: http://skia.googlecode.com/svn/trunk@4057
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 29 May 2012 01:40:15 +0000 (01:40 +0000)]
add SkPoint::isZero(), match the existing method on SkIPoint
git-svn-id: http://skia.googlecode.com/svn/trunk@4055
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 May 2012 14:10:15 +0000 (14:10 +0000)]
Rolling back 4053
git-svn-id: http://skia.googlecode.com/svn/trunk@4054
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 May 2012 13:37:25 +0000 (13:37 +0000)]
Speculative fix for Android Debug only crash in r4049
http://codereview.appspot.com/6251049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4053
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 25 May 2012 19:48:05 +0000 (19:48 +0000)]
Add svndiff tool: runs skdiff over all pending changes in SVN checkout
This is needed for
https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests ,
and will be generally useful beyond that too.
Review URL: https://codereview.appspot.com/6256052
git-svn-id: http://skia.googlecode.com/svn/trunk@4052
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 25 May 2012 12:46:55 +0000 (12:46 +0000)]
Rolling back r4049
git-svn-id: http://skia.googlecode.com/svn/trunk@4051
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 25 May 2012 12:26:30 +0000 (12:26 +0000)]
Whitespace change - could not reproduce r4049's Debug Android failure locally
git-svn-id: http://skia.googlecode.com/svn/trunk@4050
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 25 May 2012 11:45:40 +0000 (11:45 +0000)]
Altered GrDrawState to always ref textures and render target
http://codereview.appspot.com/6251049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4049
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 25 May 2012 01:04:12 +0000 (01:04 +0000)]
Change patheffect to take a (new) StrokeRec object, which encapsulates the fill
or stroke parameters for a path.
Today, the patheffect only sees if the caller was going to stroke or fill, and
if stroke, it just sees the width. With this change, the effect can see all of the
related parameters (e.g. cap/join/miter). No other change is intended at this
time.
After this change, I hope to use this additional data to allow SkDashPathEffect
to, at times, apply the stroke as part of its effect, which may be much more
efficient than first dashing, and then reading that and stroking it.
Most of these files changed just because of the new parameter to filterPath. The
key changes are in SkPathEffect.[h,cpp], SkPaint.cpp and SkScalerContext.cpp
Review URL: https://codereview.appspot.com/6250051
git-svn-id: http://skia.googlecode.com/svn/trunk@4048
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 20:32:22 +0000 (20:32 +0000)]
revert 4046 -- GM:pathfill failed on one bot, maybe uninitialized memory somewhere?
git-svn-id: http://skia.googlecode.com/svn/trunk@4047
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 20:13:57 +0000 (20:13 +0000)]
Change patheffect to take a (new) StrokeRec object, which encapsulates the fill
or stroke parameters for a path.
Today, the patheffect only sees if the caller was going to stroke or fill, and if
stroke, it just sees the width. With this change, the effect can see all of the
related parameters (e.g. cap/join/miter). No other change is intended at this
time.
After this change, I hope to use this additional data to allow SkDashPathEffect
to, at times, apply the stroke as part of its effect, which may be much more
efficient than first dashing, and then reading that and stroking it.
Most of these files changed just because of the new parameter to filterPath. The
key changes are in SkPathEffect.[h,cpp], SkPaint.cpp and SkScalerContext.cpp
Review URL: https://codereview.appspot.com/6249050
git-svn-id: http://skia.googlecode.com/svn/trunk@4046
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 24 May 2012 17:44:30 +0000 (17:44 +0000)]
Move swizzle & modulation computation, non-virtual functions onto
GrGLShaderBuilder. This lets us access all the default computations
when there's no GrCustomStage specified, and means that GrGLProgramStage
is effectively an interface class, all of whose functions can/should
be overriden.
http://codereview.appspot.com/6242051/
git-svn-id: http://skia.googlecode.com/svn/trunk@4045
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 16:28:11 +0000 (16:28 +0000)]
add baselines for macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4044
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 16:25:13 +0000 (16:25 +0000)]
add baselines for macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4043
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 16:22:53 +0000 (16:22 +0000)]
add baselines for macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4042
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 24 May 2012 15:15:04 +0000 (15:15 +0000)]
add baselines for macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4041
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 24 May 2012 15:10:14 +0000 (15:10 +0000)]
First stage of reworking custom shader infrastructure to allow
radial mappings.
http://codereview.appspot.com/6239043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4040
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 24 May 2012 12:43:36 +0000 (12:43 +0000)]
Fix some EOLs, mark files with the LF property.
Review URL: http://codereview.appspot.com/6230046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4039
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 24 May 2012 12:42:24 +0000 (12:42 +0000)]
Updated useSWOnlyPath method to use path chain instead of raw path renderer methods
http://codereview.appspot.com/6211083/
git-svn-id: http://skia.googlecode.com/svn/trunk@4038
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 23 May 2012 18:09:25 +0000 (18:09 +0000)]
shape ops work in progress (get rid of some warnings)
git-svn-id: http://skia.googlecode.com/svn/trunk@4037
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 23 May 2012 13:19:12 +0000 (13:19 +0000)]
Removed SoftwarePathRenderer from GrContext's path renderer chain
http://codereview.appspot.com/6221065/
git-svn-id: http://skia.googlecode.com/svn/trunk@4036
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 23 May 2012 12:02:21 +0000 (12:02 +0000)]
"fix" for r4034 issues
git-svn-id: http://skia.googlecode.com/svn/trunk@4035
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 23 May 2012 11:44:08 +0000 (11:44 +0000)]
Plumbing to propagate save & restore from SkCanvas down to GrContext & lower
http://codereview.appspot.com/6203067/
git-svn-id: http://skia.googlecode.com/svn/trunk@4034
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 22 May 2012 21:12:00 +0000 (21:12 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4033
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 May 2012 20:28:23 +0000 (20:28 +0000)]
Remove GrClipMaskManager's path renderer chain (in favor of GrContext's)
http://codereview.appspot.com/6211078/
git-svn-id: http://skia.googlecode.com/svn/trunk@4032
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 22 May 2012 19:14:01 +0000 (19:14 +0000)]
download_baselines.py : only set svn properties of files whose content has changed
and while I was at it, sort the filenames before acting on them, to make the output easier to read
BUG=http://code.google.com/p/skia/issues/detail?id=618
Review URL: https://codereview.appspot.com/6223061
git-svn-id: http://skia.googlecode.com/svn/trunk@4031
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 May 2012 18:09:26 +0000 (18:09 +0000)]
Minor tweaks to SW-only clip mask generation logic
http://codereview.appspot.com/6218064/
git-svn-id: http://skia.googlecode.com/svn/trunk@4030
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 22 May 2012 17:01:14 +0000 (17:01 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4029
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 May 2012 15:44:03 +0000 (15:44 +0000)]
Commit comment change that was supposed to go into r4024 but wasn't because I forgot to save.
git-svn-id: http://skia.googlecode.com/svn/trunk@4028
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 22 May 2012 13:45:35 +0000 (13:45 +0000)]
Add to skdiff: test images for bitwise equality before testing for pixel-wise equality
- we now check for bitwise equality of files before bothering with pixel
comparisons (this will help with formats for which we don't have good
decoders, like PDF)
- unparsable files are now reported as differing, unless they are bitwise equal
(before, they were always reported as matching!)
- "largest area mismatch" is now based on same-size image pairs only;
previously, if any image pairs had mismatching size, it was 100%
- removed repetitive "image size mismatch, so no diff to display" messages
- changed format of leftmost table cells to be more readable
BUG=http://code.google.com/p/skia/issues/detail?id=473
Review URL: https://codereview.appspot.com/6208089
git-svn-id: http://skia.googlecode.com/svn/trunk@4027
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 May 2012 12:59:59 +0000 (12:59 +0000)]
White space change
git-svn-id: http://skia.googlecode.com/svn/trunk@4026
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 22 May 2012 12:14:50 +0000 (12:14 +0000)]
Converted AAClips SampleApp slide to GM:simpleaaclip
http://codereview.appspot.com/6220043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4025
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 22:15:46 +0000 (22:15 +0000)]
Kill GrGpuGL::fHWDrawState
Review URL: http://codereview.appspot.com/6227048/
git-svn-id: http://skia.googlecode.com/svn/trunk@4024
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 21:44:59 +0000 (21:44 +0000)]
Changes accidentally omitted from 4022.
git-svn-id: http://skia.googlecode.com/svn/trunk@4023
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 21:40:12 +0000 (21:40 +0000)]
Stop Tracking const vertex attrib color and coverage using GrDrawState
Review URL: http://codereview.appspot.com/6219056/
git-svn-id: http://skia.googlecode.com/svn/trunk@4022
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 21:19:58 +0000 (21:19 +0000)]
Stop using GrDrawState to track stencil state
Review URL: http://codereview.appspot.com/6227047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4021
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 21:18:13 +0000 (21:18 +0000)]
Rename GrProgramStageFactory::stageKey to GrProgramStageFactory::glStageKey since it is GL-specific
Review URL: http://codereview.appspot.com/6218060/
git-svn-id: http://skia.googlecode.com/svn/trunk@4020
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 20:57:59 +0000 (20:57 +0000)]
Tunnel name requests through factory, forcing custom effect and custom prog stage to use same impl
Review URL: http://codereview.appspot.com/6220061/
git-svn-id: http://skia.googlecode.com/svn/trunk@4019
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 20:14:29 +0000 (20:14 +0000)]
When GL context is reset set some desktop-only GL state to values that we assume later.
Review URL: http://codereview.appspot.com/6222052/
git-svn-id: http://skia.googlecode.com/svn/trunk@4018
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 May 2012 20:00:39 +0000 (20:00 +0000)]
update dox for NewFromMalloc() to clarify ownership
git-svn-id: http://skia.googlecode.com/svn/trunk@4017
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 19:17:17 +0000 (19:17 +0000)]
Rebaseline from r4015. Also set PNG mime type on recently added images that were marked octet-stream.
git-svn-id: http://skia.googlecode.com/svn/trunk@4016
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 17:11:44 +0000 (17:11 +0000)]
Use tristate in HW AA tracking, fix msaa disabled for non-smoothed lines bug
Review URL: http://codereview.appspot.com/6222051/
git-svn-id: http://skia.googlecode.com/svn/trunk@4015
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 May 2012 16:47:43 +0000 (16:47 +0000)]
remove bogus nearlyzero checks
Review URL: https://codereview.appspot.com/6213060
git-svn-id: http://skia.googlecode.com/svn/trunk@4014
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 15:33:09 +0000 (15:33 +0000)]
Stop using GrDrawState to track bound textures and render target
Review URL: http://codereview.appspot.com/6208086/
git-svn-id: http://skia.googlecode.com/svn/trunk@4013
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 15:31:00 +0000 (15:31 +0000)]
Make static const var that is only used in an assert be defined in the debug build only to suppress an unused var warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@4012
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 May 2012 15:29:27 +0000 (15:29 +0000)]
~glyphcache_globals needs to actually delete its cache
git-svn-id: http://skia.googlecode.com/svn/trunk@4011
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 May 2012 15:27:23 +0000 (15:27 +0000)]
add
git-svn-id: http://skia.googlecode.com/svn/trunk@4010
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 14:45:49 +0000 (14:45 +0000)]
Stop using GrDrawState to track draw face, dither, and color mask
Review URL: http://codereview.appspot.com/6215071/
git-svn-id: http://skia.googlecode.com/svn/trunk@4009
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 21 May 2012 13:46:13 +0000 (13:46 +0000)]
Fix assignment of non-copyable.
see http://connect.microsoft.com/VisualStudio/feedback/details/552586/inherting-noncopyable-base-allows-equal-sign-initialization
git-svn-id: http://skia.googlecode.com/svn/trunk@4008
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 21 May 2012 13:21:46 +0000 (13:21 +0000)]
Stop using GrDrawState to track GPU's blend state
git-svn-id: http://skia.googlecode.com/svn/trunk@4007
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 18 May 2012 20:50:33 +0000 (20:50 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4006
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 May 2012 20:10:06 +0000 (20:10 +0000)]
Remove chromium mode from skdiff, because it is no longer actively used.
Ran tools/tests/run.sh to validate this change.
TBR=caryclark1
Review URL: https://codereview.appspot.com/6222045
git-svn-id: http://skia.googlecode.com/svn/trunk@4005
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 18 May 2012 20:06:45 +0000 (20:06 +0000)]
fix build?
git-svn-id: http://skia.googlecode.com/svn/trunk@4004
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 18 May 2012 19:54:48 +0000 (19:54 +0000)]
Some refactoring of GrCustomStage and friends
Review URL: http://codereview.appspot.com/6209071/
git-svn-id: http://skia.googlecode.com/svn/trunk@4003
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 18 May 2012 19:12:21 +0000 (19:12 +0000)]
Fix obviously disallowed copy that Visual Studio allows.
git-svn-id: http://skia.googlecode.com/svn/trunk@4002
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 18 May 2012 19:06:41 +0000 (19:06 +0000)]
CreateTypefaceFromStream for GDI.
http://codereview.appspot.com/5616047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4001
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 May 2012 18:32:54 +0000 (18:32 +0000)]
add makedash_ variants to measure applying the dash (not drawing it)
git-svn-id: http://skia.googlecode.com/svn/trunk@4000
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 May 2012 18:25:26 +0000 (18:25 +0000)]
skdiff test-only change: add test of --nodiffs mode, make tests validate return value
Review URL: https://codereview.appspot.com/6206085
git-svn-id: http://skia.googlecode.com/svn/trunk@3999
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 May 2012 18:01:05 +0000 (18:01 +0000)]
add baselines
git-svn-id: http://skia.googlecode.com/svn/trunk@3998
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 18 May 2012 17:59:08 +0000 (17:59 +0000)]
add dashing2 gm to exercise dashing on curves and polygons
git-svn-id: http://skia.googlecode.com/svn/trunk@3997
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 18 May 2012 14:57:40 +0000 (14:57 +0000)]
Move state onto GrGLShaderBuilder, to let us implement mappings
as GrCustomStage objects.
http://codereview.appspot.com/6216057/
git-svn-id: http://skia.googlecode.com/svn/trunk@3996
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 17 May 2012 17:12:38 +0000 (17:12 +0000)]
test-only change: update run.sh and rearrange dirs to ease addition of more tests
Review URL: https://codereview.appspot.com/6220044
git-svn-id: http://skia.googlecode.com/svn/trunk@3995
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 May 2012 15:38:00 +0000 (15:38 +0000)]
Fix type errors and a few warnings for Visual Studio 2010 64-bit build.
We're still far from 64b statically safe, mostly around SkReader32.h
and the address-alignment code in GrTypes.h.
Original code provided by jianliang79.
http://code.google.com/p/skia/issues/detail?id=601
git-svn-id: http://skia.googlecode.com/svn/trunk@3994
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 15:31:43 +0000 (15:31 +0000)]
minor cleanups, in prep for more work on improving precision
git-svn-id: http://skia.googlecode.com/svn/trunk@3993
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 15:28:20 +0000 (15:28 +0000)]
add options to enable/disable "FAILED to read ..." message
--disable-missing-warning
--enable-missing-warning
default is still enabled
git-svn-id: http://skia.googlecode.com/svn/trunk@3992
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 May 2012 15:09:17 +0000 (15:09 +0000)]
Use intrinsics instead of inline assembly for detecting CPU ID & SSE2/3 support
on 64-bit builds in MS Visual Studio 2010.
Original code provided by jianliang79.
http://code.google.com/p/skia/issues/detail?id=600
git-svn-id: http://skia.googlecode.com/svn/trunk@3991
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 14:29:39 +0000 (14:29 +0000)]
reuse() is no longer available, call reset()
git-svn-id: http://skia.googlecode.com/svn/trunk@3990
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 14:28:11 +0000 (14:28 +0000)]
change SkChunkAlloc to grow its allocations geometrically (not linearly)
plus add a bench and unittest for it.
git-svn-id: http://skia.googlecode.com/svn/trunk@3989
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 13:58:26 +0000 (13:58 +0000)]
move Release build to -O3 (from -O2)
git-svn-id: http://skia.googlecode.com/svn/trunk@3988
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 13:50:36 +0000 (13:50 +0000)]
change SetTLSFontCacheLimit to be void, since it doesn't easily know the prev value
git-svn-id: http://skia.googlecode.com/svn/trunk@3987
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 13:38:03 +0000 (13:38 +0000)]
Allow font-cache to use thread_local_storage for a private cache
Review URL: https://codereview.appspot.com/6200051
git-svn-id: http://skia.googlecode.com/svn/trunk@3986
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 May 2012 13:14:52 +0000 (13:14 +0000)]
Mutexes in pixelrefs were done very sloppily initially. The code (a) assumes all
pixelref subclasses want a mutex to guard their lock/unlock virtuals, and (b)
most subclasses use the same mutex for *all* of their instances, even when there
is no explicit need to guard modifying one instances with another.
When we try drawing bitmaps from multiple threads, we are seeing a lot of slow-
down from these mutexes. This CL has two changes to try to speed things up.
1. Add setPreLocked(), for pixelrefs who never need the onLockPixels
virtual to be called. This speeds up those subclasses in multithreaded environs
as it avoids the mutex lock all together (e.g. SkMallocPixelRef).
2. Add setMutex() to allow a subclass to change the mutex choice. ashmem wants
this, since its unflattening constructor cannot pass down the null, it needs
to cleanup afterwards.
Review URL: https://codereview.appspot.com/6199075
git-svn-id: http://skia.googlecode.com/svn/trunk@3985
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 May 2012 12:20:22 +0000 (12:20 +0000)]
First functioning version of SW-only clip mask creator
http://codereview.appspot.com/6208072/
git-svn-id: http://skia.googlecode.com/svn/trunk@3984
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 May 2012 12:01:02 +0000 (12:01 +0000)]
Free cached AA clip mask when create hard/stencil clip mask
http://codereview.appspot.com/6214050/
git-svn-id: http://skia.googlecode.com/svn/trunk@3983
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 16 May 2012 20:37:39 +0000 (20:37 +0000)]
Add 'inline' to suppress unused warnings with Android NDK build.
git-svn-id: http://skia.googlecode.com/svn/trunk@3982
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 May 2012 19:21:12 +0000 (19:21 +0000)]
computeFastStrokeBounds needs to pass kStroke_Style instead of kFill_Style (ya think?)
git-svn-id: http://skia.googlecode.com/svn/trunk@3981
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 May 2012 18:50:40 +0000 (18:50 +0000)]
pass the region-op to the clipstack for SkCanvas::clipRegion.
we were defaulting to intersect all the time (doh).
git-svn-id: http://skia.googlecode.com/svn/trunk@3980
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 16 May 2012 18:37:31 +0000 (18:37 +0000)]
Fix new atomic declarations for Android.
git-svn-id: http://skia.googlecode.com/svn/trunk@3979
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 16 May 2012 18:21:56 +0000 (18:21 +0000)]
WeakRefCnt
http://codereview.appspot.com/5649046/
git-svn-id: http://skia.googlecode.com/svn/trunk@3978
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 May 2012 18:06:54 +0000 (18:06 +0000)]
test-only changes: add more image files to test more skdiff behavior
Tests output order for very vs. slightly different pixels, very vs. slightly different image sizes, etc.
TBR=tomhudson@google.com
Review URL: https://codereview.appspot.com/6213049
git-svn-id: http://skia.googlecode.com/svn/trunk@3977
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 May 2012 17:56:09 +0000 (17:56 +0000)]
remove unused variable (isNaN)
git-svn-id: http://skia.googlecode.com/svn/trunk@3976
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 May 2012 17:40:57 +0000 (17:40 +0000)]
skdiff: only write out diff images that are included in index.html
Not only are those files unnecessary, in some different-image-size cases, their contents are nondeterministic!
Review URL: https://codereview.appspot.com/6208073
git-svn-id: http://skia.googlecode.com/svn/trunk@3975
2bbb7eff-a529-9590-31e7-
b0007b416f81