review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

edisonn@google.com [Fri, 16 Aug 2013 17:01:24 +0000 (17:01 +0000)]

pdfviewer: fix typo in sample app

Review URL: https://codereview.chromium.org/22861007

git-svn-id: http://skia.googlecode.com/svn/trunk@10781 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 16 Aug 2013 16:30:02 +0000 (16:30 +0000)]

pdfviewer: update interface of derived canvas and device, to reflect lastest changes in the interfaces.

Review URL: https://codereview.chromium.org/23048006

git-svn-id: http://skia.googlecode.com/svn/trunk@10780 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 16 Aug 2013 16:13:44 +0000 (16:13 +0000)]

pdfviewer: (cleanup) put the gyp for library code in a separate file

Review URL: https://codereview.chromium.org/23038004

git-svn-id: http://skia.googlecode.com/svn/trunk@10779 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 16:12:23 +0000 (16:12 +0000)]

Always support pack/unpack row length on ES3. Add support for NV_pack_subimage extension.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23003009

git-svn-id: http://skia.googlecode.com/svn/trunk@10778 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:46 +0000 (15:53 +0000)]

Change Atlas recycling to track current flush count and recycle if Atlas not used in current flush.

BUG=
R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23120004

git-svn-id: http://skia.googlecode.com/svn/trunk@10777 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:33 +0000 (15:53 +0000)]

Support VAO when on ES3.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22909015

git-svn-id: http://skia.googlecode.com/svn/trunk@10776 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Fri, 16 Aug 2013 15:44:52 +0000 (15:44 +0000)]

More rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10775 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Fri, 16 Aug 2013 15:32:23 +0000 (15:32 +0000)]

First set of rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10774 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 16 Aug 2013 15:05:08 +0000 (15:05 +0000)]

pdfviewer: code cleanup - remove STL usage

Review URL: https://codereview.chromium.org/23258004

git-svn-id: http://skia.googlecode.com/svn/trunk@10772 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 16 Aug 2013 15:01:03 +0000 (15:01 +0000)]

Ubuntu flaky performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10770 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Fri, 16 Aug 2013 14:51:51 +0000 (14:51 +0000)]

Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10640

Committed: http://code.google.com/p/skia/source/detail?r=10707

R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10769 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 16 Aug 2013 13:16:01 +0000 (13:16 +0000)]

more rebaselines of convexpaths

git-svn-id: http://skia.googlecode.com/svn/trunk@10766 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 10:24:37 +0000 (10:24 +0000)]

This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path.

R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/20806003

git-svn-id: http://skia.googlecode.com/svn/trunk@10765 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 16 Aug 2013 07:01:49 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10764 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 16 Aug 2013 01:01:01 +0000 (01:01 +0000)]

Patch for r10762

git-svn-id: http://skia.googlecode.com/svn/trunk@10763 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 00:53:34 +0000 (00:53 +0000)]

This CL addresses "SkCanvas::save flags are not respected by GPU backend" (https://code.google.com/p/skia/issues/detail?id=1503).

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22947003

git-svn-id: http://skia.googlecode.com/svn/trunk@10762 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 16 Aug 2013 00:40:34 +0000 (00:40 +0000)]

This bench attempts to recreate Chromium's Canvas_putImageData performance test to track down https://code.google.com/p/chromium/issues/detail?id=270649.

Cranking the repitition count up to 500 on a MacPro yields:

WITHOUT 10624:
running bench [640 480]            writepix_rgba_UPM  8888: cmsecs = 748.25   GPU: cmsecs = 225.95 gmsecs = 244.80
running bench [640 480]             writepix_rgba_PM  8888: cmsecs =  54.12   GPU: cmsecs = 225.77 gmsecs = 244.59

WITH 10624:
running bench [640 480]            writepix_rgba_UPM  8888: cmsecs = 747.70   GPU: cmsecs = 230.30 gmsecs = 249.51
running bench [640 480]             writepix_rgba_PM  8888: cmsecs =  55.05   GPU: cmsecs = 230.13 gmsecs = 249.38

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22895012

git-svn-id: http://skia.googlecode.com/svn/trunk@10761 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 15 Aug 2013 23:53:11 +0000 (23:53 +0000)]

Revert "Make SkMatrix44::invert() check for finite 1/det instead of magic value"

This reverts commit f109b4ac6ef21ccb8b76891e50e63dae820af116.

git-svn-id: http://skia.googlecode.com/svn/trunk@10760 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 15 Aug 2013 22:42:54 +0000 (22:42 +0000)]

Revert r10718 to unblock roll

git-svn-id: http://skia.googlecode.com/svn/trunk@10759 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 15 Aug 2013 21:56:38 +0000 (21:56 +0000)]

Make SkMatrix44::invert() check for finite 1/det instead of magic value

Previously we were checking to see if the magnitude of determinant of the
matrix to be inverted was less than 1.0e-8, which is a magic number possibly
plucked from Graphics Gems. After some discussion, it's been determined (ha)
that we can simply check to see if 1/det is finite and if so proceed.

BUG=222926
R=reed@google.com, shawnsingh@chromium.org

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22904003

git-svn-id: http://skia.googlecode.com/svn/trunk@10758 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Thu, 15 Aug 2013 21:20:14 +0000 (21:20 +0000)]

Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it.

I left the dummy value in the flattened paint. I'm hoping to do an overhaul of
the paint serialization format which will need a picture version bump anyway,
so it can all go together. If that doesn't pan out we can remove this on its
own later.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23056005

git-svn-id: http://skia.googlecode.com/svn/trunk@10757 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Thu, 15 Aug 2013 21:14:51 +0000 (21:14 +0000)]

Update how SkPath handles fGenerationID and fSourcePath, and add tests to cover.

BUG=
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/22911002

git-svn-id: http://skia.googlecode.com/svn/trunk@10756 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Thu, 15 Aug 2013 21:12:11 +0000 (21:12 +0000)]

Add homogeneous point mapping to Matrix

Adds mapping of homogeneous points (points with three scalar components,
where the last component is not 1). Includes fix for tests when
running on 32 bit debug builds

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22816005

git-svn-id: http://skia.googlecode.com/svn/trunk@10755 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Thu, 15 Aug 2013 21:01:32 +0000 (21:01 +0000)]

Write NULL as "" so readString() always returns a non-NULL string.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/22862002

git-svn-id: http://skia.googlecode.com/svn/trunk@10754 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 15 Aug 2013 20:57:42 +0000 (20:57 +0000)]

fine-tune tolerance for pinchy quads in stroker

BUG=
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/22947005

git-svn-id: http://skia.googlecode.com/svn/trunk@10753 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 20:34:45 +0000 (20:34 +0000)]

temporarily disable assert in convexpaths GM while it is debugged

git-svn-id: http://skia.googlecode.com/svn/trunk@10752 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 19:51:53 +0000 (19:51 +0000)]

Add missing baselines for convexpaths GM

git-svn-id: http://skia.googlecode.com/svn/trunk@10751 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 19:49:42 +0000 (19:49 +0000)]

rebaseline convex paths after test was changed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10750 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 19:45:26 +0000 (19:45 +0000)]

temporary kES2_GrGLBinding alias to unblock DEPS roll

git-svn-id: http://skia.googlecode.com/svn/trunk@10749 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 18:57:53 +0000 (18:57 +0000)]

missing header from previous commit

git-svn-id: http://skia.googlecode.com/svn/trunk@10748 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 18:54:39 +0000 (18:54 +0000)]

Rename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23185004

git-svn-id: http://skia.googlecode.com/svn/trunk@10747 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 15 Aug 2013 18:24:53 +0000 (18:24 +0000)]

Rebaseline GMs for Galaxy Nexus: looks like updated fonts and some GMs out of date.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10746 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:41 +0000 (18:16 +0000)]

Enable coverage when drawing to the stencil buffer.

Currently, we set kEmitTransBlack_BlendOptFlag when drawing to the stencil buffer - but that
prevents masks from being drawn correctly as they receive full coverage and no fragments get
discarded.

R=bsalomon@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23197003

git-svn-id: http://skia.googlecode.com/svn/trunk@10745 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:27 +0000 (18:16 +0000)]

Fix repeated point quads/cubics in convex pr and update convexpaths GM

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23034003

git-svn-id: http://skia.googlecode.com/svn/trunk@10744 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:07 +0000 (18:16 +0000)]

Add missing fallback blending to SkA8_Shader_Blitter::blitMask()

Similarly to SkA8_Shader_Blitter::blitAntiH() and SkA8_Shader_Blitter::blitH(), blitMask() should handle a missing SkXfermode gracefully.

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22867008

git-svn-id: http://skia.googlecode.com/svn/trunk@10743 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 15 Aug 2013 18:15:20 +0000 (18:15 +0000)]

Rebaseline GMs for Nexus-10: looks like fonts changed due to OS upgrade.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10742 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 17:42:33 +0000 (17:42 +0000)]

one more flakly GL_LINES win7/intel/gpu test to ignore

git-svn-id: http://skia.googlecode.com/svn/trunk@10741 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 17:10:28 +0000 (17:10 +0000)]

Expect to fail on images with GL_LINES snapping issue on win7/intel/gpu

git-svn-id: http://skia.googlecode.com/svn/trunk@10740 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 15:40:31 +0000 (15:40 +0000)]

try one last time for xfermodes3 pdf rebaselines, will delete if this doesn't stick

git-svn-id: http://skia.googlecode.com/svn/trunk@10739 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 15 Aug 2013 14:51:04 +0000 (14:51 +0000)]

Revert "Unpremultiply SkBitmaps for PDF output"

This reverts commit 16a6c9d28c8ef6f827d50ef258005fa5ec971bd9.

Seems to be breaking all of the windows debug bots in GM.

git-svn-id: http://skia.googlecode.com/svn/trunk@10737 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 15 Aug 2013 14:16:52 +0000 (14:16 +0000)]

Rebaseline Ubuntu after revert of r10705 (in r10729)

git-svn-id: http://skia.googlecode.com/svn/trunk@10731 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 15 Aug 2013 13:55:00 +0000 (13:55 +0000)]

Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10730 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 15 Aug 2013 13:43:23 +0000 (13:43 +0000)]

Revert r10705 (ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG) due to 1000+ linux_layout failures (build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/builds/18997/steps/webkit_tests/logs/stdio)

git-svn-id: http://skia.googlecode.com/svn/trunk@10729 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 15 Aug 2013 13:43:01 +0000 (13:43 +0000)]

more xfermodes3 rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10728 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 15 Aug 2013 07:01:06 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10727 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 14 Aug 2013 22:05:06 +0000 (22:05 +0000)]

pdfviewer: workaround gyp issue with multiple files, not being translated into an array in linux (works in mac, as per spec)

Review URL: https://codereview.chromium.org/23157003

git-svn-id: http://skia.googlecode.com/svn/trunk@10726 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 22:02:23 +0000 (22:02 +0000)]

Unpremultiply SkBitmaps for PDF output

BUG=skia:236, chromium:175548
R=vandebo@chromium.org, edisonn@google.com, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22329003

git-svn-id: http://skia.googlecode.com/svn/trunk@10725 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:47 +0000 (21:56 +0000)]

Refactor GM to separate config parsing, attempt 2

R=vandebo@chromium.org, reed@google.com, edisonn@google.com, epoger@google.com, scroggo@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23072014

git-svn-id: http://skia.googlecode.com/svn/trunk@10724 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:37 +0000 (21:56 +0000)]

Add blend optimization helpers and use to convert rect draws to clears.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22558003

git-svn-id: http://skia.googlecode.com/svn/trunk@10723 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 14 Aug 2013 21:55:32 +0000 (21:55 +0000)]

rebaseline xfermodes3 after change to the test.

git-svn-id: http://skia.googlecode.com/svn/trunk@10722 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 14 Aug 2013 21:35:27 +0000 (21:35 +0000)]

pdfviewer: make pdfviewer compile on mac

Review URL: https://codereview.chromium.org/23163007

git-svn-id: http://skia.googlecode.com/svn/trunk@10721 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:45 +0000 (19:20 +0000)]

Make xfermodes3 GM also test stroked rects

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22866002

git-svn-id: http://skia.googlecode.com/svn/trunk@10720 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:35 +0000 (19:20 +0000)]

fix path issues on mac and win for skpdiff_server.py

R=djsollen@google.com, epoger@google.com, jvanverth@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/22650009

git-svn-id: http://skia.googlecode.com/svn/trunk@10719 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 14 Aug 2013 18:59:28 +0000 (18:59 +0000)]

allow both GDI and DW fontmgrs at the same time

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23058002

git-svn-id: http://skia.googlecode.com/svn/trunk@10718 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Wed, 14 Aug 2013 18:37:27 +0000 (18:37 +0000)]

Deletes warning on no graph outputs, since we don't output graphs anymore.
Review URL: https://codereview.chromium.org/23071002

git-svn-id: http://skia.googlecode.com/svn/trunk@10717 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 14 Aug 2013 18:26:20 +0000 (18:26 +0000)]

pdfviewer: 1) debug code for drawText (show magenta background for text, to show text even when we fail to load/show it), 2) some cleanup: refactor and rename classes and files

Review URL: https://codereview.chromium.org/23020003

git-svn-id: http://skia.googlecode.com/svn/trunk@10716 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:37 +0000 (18:14 +0000)]

Fix crash when querying a runtime config that is defined in environment

Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.

Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.

Previous version of the patch failed Windows build due to setenv usage.
On Windows, use _putenv_s instead.

BUG=skia:1494
R=bsalomon@google.com, humper@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/23174002

git-svn-id: http://skia.googlecode.com/svn/trunk@10715 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 14 Aug 2013 18:14:31 +0000 (18:14 +0000)]

Delete compare_baselines.py and download_baselines.py ; we use rebaseline.py now

Review URL: https://codereview.chromium.org/23082002

git-svn-id: http://skia.googlecode.com/svn/trunk@10714 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:19 +0000 (18:14 +0000)]

Refactor GrGLUniformManager::UniformHandle to initialize itself by default

Refactor GrGLUniformManager::UniformHandle to initialize itself to
"invalid" state by default. This simplifies the effect
constructors. In the future, it should also help catch potential
uninitialized uniform variable usage.

Remove unneeded explicit uniform handle validity assertions before the
handle usage. The assertion will always be made when handle is
converted to index.

BUG=skia:1492
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22340010

git-svn-id: http://skia.googlecode.com/svn/trunk@10713 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 14 Aug 2013 16:22:02 +0000 (16:22 +0000)]

update expectations after SkLONGLONG change

BUG=

Review URL: https://codereview.chromium.org/23198003

git-svn-id: http://skia.googlecode.com/svn/trunk@10712 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 14 Aug 2013 15:43:18 +0000 (15:43 +0000)]

Nexus 7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10711 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 14 Aug 2013 15:40:30 +0000 (15:40 +0000)]

Another Win7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10710 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Wed, 14 Aug 2013 14:29:29 +0000 (14:29 +0000)]

Reverting r10707. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10709 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 14 Aug 2013 14:07:09 +0000 (14:07 +0000)]

Revert "Refactor gmmain to separate out config parsing"

This reverts commit 210340a02d7d56890a1630cc307b7263fbe9106f.

git-svn-id: http://skia.googlecode.com/svn/trunk@10708 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 13:02:13 +0000 (13:02 +0000)]

Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10640

R=robertphillips@google.com, egdaniel@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10707 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 12:09:00 +0000 (12:09 +0000)]

effects: Replaces uses of GrAssert with SkASSERT.

This is the first step on migrating from GrAssert to SkASSERT as requested by
Brian.

R=bsalomon@google.com, robertphillips@google.com, scroggo@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22418006

git-svn-id: http://skia.googlecode.com/svn/trunk@10706 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 11:43:52 +0000 (11:43 +0000)]

ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG

It removes SkLONGLONG and uses int64_t to implement the SkFixed
operations for which a SkLONGLONG version existed. It also
removes the 32 bit version that are being replaced.

BUG=
R=djsollen@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18539004

git-svn-id: http://skia.googlecode.com/svn/trunk@10705 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:27 +0000 (11:36 +0000)]

Fix build with SK_SUPPORT_UNITTEST on

Fix build with SK_SUPPORT_UNITTEST on. Parenthesis with && and || is
fixed similarly to r1386.

BUG=skia:1493
R=scroggo@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22732004

git-svn-id: http://skia.googlecode.com/svn/trunk@10704 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:15 +0000 (11:36 +0000)]

Refactor gmmain to separate out config parsing

R=vandebo@chromium.org, reed@google.com, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21715002

git-svn-id: http://skia.googlecode.com/svn/trunk@10703 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 14 Aug 2013 11:35:25 +0000 (11:35 +0000)]

Win7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10702 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 14 Aug 2013 07:01:14 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10701 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Tue, 13 Aug 2013 20:32:22 +0000 (20:32 +0000)]

Add Android config for Intel RHB

Corresponding buildbot change: https://codereview.chromium.org/22840005/

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23046003

git-svn-id: http://skia.googlecode.com/svn/trunk@10699 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 13 Aug 2013 19:11:15 +0000 (19:11 +0000)]

add root files from chrome

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23111002

git-svn-id: http://skia.googlecode.com/svn/trunk@10696 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 13 Aug 2013 17:26:59 +0000 (17:26 +0000)]

Nexus 7 performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10695 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 13 Aug 2013 15:33:17 +0000 (15:33 +0000)]

fix int-to-scalar warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@10693 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 13 Aug 2013 15:12:33 +0000 (15:12 +0000)]

bench_util: allow optional whitespace in CSV format
BUG=https://code.google.com/p/skia/issues/detail?id=1500
R=bensong@google.com

Review URL: https://codereview.chromium.org/23069003

git-svn-id: http://skia.googlecode.com/svn/trunk@10692 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 13 Aug 2013 14:59:17 +0000 (14:59 +0000)]

expose instance methods on SkTypefaceCache

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23067003

git-svn-id: http://skia.googlecode.com/svn/trunk@10691 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 13 Aug 2013 14:48:09 +0000 (14:48 +0000)]

fix mac build errors related to new gm

Review URL: https://codereview.chromium.org/22937005

git-svn-id: http://skia.googlecode.com/svn/trunk@10690 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 13 Aug 2013 14:29:06 +0000 (14:29 +0000)]

Prevent picture recording from over optimizing the culling of clips.

BUG=skia:1496
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/22875008

git-svn-id: http://skia.googlecode.com/svn/trunk@10689 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 13 Aug 2013 13:25:09 +0000 (13:25 +0000)]

remove uncalled local functions

BUG=

Review URL: https://codereview.chromium.org/22924004

git-svn-id: http://skia.googlecode.com/svn/trunk@10688 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 12 Aug 2013 17:21:43 +0000 (17:21 +0000)]

Make android_run_skia exit with the correct code

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22812003

git-svn-id: http://skia.googlecode.com/svn/trunk@10684 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 12 Aug 2013 15:40:11 +0000 (15:40 +0000)]

Revert "Add SkCanvas::drawPosTextBounded."

This reverts commit e158aea941a6202a40b75fcee013d002089854bb.

This was an experimental API change. We will reintroduce this feature
with a different API approach, and support it w/ detailed testing
and performance measurements.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22861002

git-svn-id: http://skia.googlecode.com/svn/trunk@10680 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Mon, 12 Aug 2013 14:57:54 +0000 (14:57 +0000)]

fix malformed gypi file that was missing commas

R=torne@chromium.org

Review URL: https://codereview.chromium.org/22841003

git-svn-id: http://skia.googlecode.com/svn/trunk@10678 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Mon, 12 Aug 2013 14:51:25 +0000 (14:51 +0000)]

SkTDynamicHash
  - add validate()
  - make add() and remove() strict
  - fill in maybeShrink()
  - make grow and shrink thresholds configurable.
  - fix issue where we were getting filled with deleted items - we need to count them as occupied when determining if we should grow

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/22571010

git-svn-id: http://skia.googlecode.com/svn/trunk@10677 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 12 Aug 2013 14:51:20 +0000 (14:51 +0000)]

If any change is made to the public API then make sure there is an LGTM from an owner.

This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Mon, 12 Aug 2013 12:30:04 +0000 (12:30 +0000)]

Update Skia Android tools.

This CL moves the skia_launcher out of the system/bin and into
/data/local/tmp; removes the need to package our shared libs in an
apk; and updates all the scripts to work in the new environment.

R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/22617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10673 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 12 Aug 2013 12:02:28 +0000 (12:02 +0000)]

Revert of r10671 (Experiments on calculating reciprocal of square root) due to bots failures:

Win7: http://108.170.217.252:10117/builders/Build-Win7-VS2010-x86-Debug/builds/715/steps/BuildMost/logs/stdio
Win8: http://108.170.217.252:10117/builders/Build-Win8-VS2012-x86-Debug/builds/383/steps/BuildMost/logs/stdio
Mac10.6: http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/1259/steps/BuildMost/logs/stdio

git-svn-id: http://skia.googlecode.com/svn/trunk@10672 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 12 Aug 2013 08:37:51 +0000 (08:37 +0000)]

Experiments on calculating reciprocal of square root

BUG=
R=reed@google.com, rmistry@chromium.org, bsalomon@google.com, tomhudson@chromium.org, tomhudson@google.com

Author: yang.gu@intel.com

Review URL: https://chromiumcodereview.appspot.com/21755002

git-svn-id: http://skia.googlecode.com/svn/trunk@10671 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Sun, 11 Aug 2013 21:59:01 +0000 (21:59 +0000)]

r10473 introduced a space between bench values; adjusting the corresponding regexp. (SkipBuildbotRuns).
Review URL: https://codereview.chromium.org/22447004

git-svn-id: http://skia.googlecode.com/svn/trunk@10670 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 11 Aug 2013 13:20:18 +0000 (13:20 +0000)]

Reverted r10654 (Fix crash when querying a runtime config that is defined in environment) due to compilation failure on Chromium win_layout bot

git-svn-id: http://skia.googlecode.com/svn/trunk@10669 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 10 Aug 2013 07:01:19 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10668 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Fri, 9 Aug 2013 21:06:38 +0000 (21:06 +0000)]

Revert r10659: Add a map homogenous points to SkMatrix

git-svn-id: http://skia.googlecode.com/svn/trunk@10667 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 9 Aug 2013 19:48:26 +0000 (19:48 +0000)]

All rSomethingTo() immediately following a close() are relative to the point we closed from, not the point we close to. Fix that.

Seems like this has been broken since the stone ages.

BUG=skia:1474, code.google.com/p/android/issues/detail?id=41216
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22681006

git-svn-id: http://skia.googlecode.com/svn/trunk@10666 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 9 Aug 2013 19:22:00 +0000 (19:22 +0000)]

Reland "Make WebP decoding independent of stream length."

This reverts commit 1de924955b103c4f5dc9c46a06527d6a37e6cb70.

When reading the stream, only read as much as will fit in the
allocated buffer.

BUG=skia:1495

Review URL: https://codereview.chromium.org/22629010

git-svn-id: http://skia.googlecode.com/svn/trunk@10665 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 9 Aug 2013 16:11:36 +0000 (16:11 +0000)]

remove include from the header paths

R=robertphillips@google.com, torne@chromium.org

Review URL: https://codereview.chromium.org/22450005

git-svn-id: http://skia.googlecode.com/svn/trunk@10664 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 9 Aug 2013 16:03:05 +0000 (16:03 +0000)]

allow NULL in writeString/readString

BUG=skia:1469, code.google.com/p/android/issues/detail?id=58257
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22359003

git-svn-id: http://skia.googlecode.com/svn/trunk@10662 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 9 Aug 2013 15:45:35 +0000 (15:45 +0000)]

Remove exported headers and add all public headers into dictionary for reference by clients.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22613003

git-svn-id: http://skia.googlecode.com/svn/trunk@10661 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Fri, 9 Aug 2013 15:24:01 +0000 (15:24 +0000)]

Temporarily disable pathinterior_gpu on Nexus-10.

git-svn-id: http://skia.googlecode.com/svn/trunk@10660 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Fri, 9 Aug 2013 15:07:10 +0000 (15:07 +0000)]

Add a map homogenous points to SkMatrix

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22330004

git-svn-id: http://skia.googlecode.com/svn/trunk@10659 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 9 Aug 2013 14:32:46 +0000 (14:32 +0000)]

Add initial baselines for new GM xfermodes3

git-svn-id: http://skia.googlecode.com/svn/trunk@10658 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom