Mathieu Duponchelle [Sat, 17 Jan 2015 21:21:16 +0000 (22:21 +0100)]
validate: let structs_from_filename be exported.
Summary: It is useful for plugins too
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D74
Thibault Saunier [Tue, 3 Mar 2015 14:42:06 +0000 (15:42 +0100)]
validate:scenario: Update Action.repeat field when needed
Summary: And print the current repeat value of the action that have such a field
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D73
Thibault Saunier [Thu, 26 Feb 2015 14:21:01 +0000 (15:21 +0100)]
validate:scenario: Alway execute a 'quit' action on EOS
Summary: Making scenario more usable with LD_PRELOAD
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D72
Thibault Saunier [Fri, 27 Feb 2015 21:39:42 +0000 (22:39 +0100)]
validate:scenario: Set the main action structure in fill_structure
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D71
Thibault Saunier [Fri, 27 Feb 2015 13:18:04 +0000 (13:18 +0000)]
validate:launcher: Use GST_VALIDATE_SCENARIO envvar to set scenarios
Summary:
Instead of concidering all apps will have a --set-scenario argument
which is not going to be the case as soon as we run the tests through
LD_PRELOAD
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D70
Thibault Saunier [Fri, 27 Feb 2015 13:16:01 +0000 (13:16 +0000)]
validate:launcher: Move get_current_position from GstValidatePipelineTest to GstValidateTest
This is where it belongs
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D69
Wonchul Lee [Wed, 8 Apr 2015 05:13:11 +0000 (14:13 +0900)]
validate: fix typo in scenario file format docs
https://bugzilla.gnome.org/show_bug.cgi?id=747487
Guillaume Desmottes [Mon, 30 Mar 2015 14:47:28 +0000 (16:47 +0200)]
validate: scenario: fix caps leak
Guillaume Desmottes [Mon, 30 Mar 2015 14:46:12 +0000 (16:46 +0200)]
validate: media-descriptor: fix filenode->caps leak
Guillaume Desmottes [Fri, 27 Mar 2015 15:00:50 +0000 (16:00 +0100)]
validate: transcoding: don't create a second mainloop
Guillaume Desmottes [Fri, 27 Mar 2015 15:00:19 +0000 (16:00 +0100)]
validate: transcoding: don't leak the requested sinkpad from decodebin
Guillaume Desmottes [Fri, 27 Mar 2015 14:59:42 +0000 (15:59 +0100)]
validate: pad-monitor: fix caps leak
Don't create othercaps when early returning.
Guillaume Desmottes [Fri, 27 Mar 2015 11:16:03 +0000 (12:16 +0100)]
validate: GstValidateMediaCheckTest should inherit from GstValidateTest
Young Han Lee [Tue, 31 Mar 2015 00:20:05 +0000 (09:20 +0900)]
validate:launcher: Install config.py for non-development mode
Running installed gst-validate-launcher aborted with the following error.
File "lib/gst-validate-launcher/python/launcher/baseclasses.py", line 28, in <module>
import config
ImportError: No module named config
This is because config.py is added but not installed
in
ba6d209b3fd062f4e6bd889f81f1213cc12339ec.
https://bugzilla.gnome.org/show_bug.cgi?id=747087
Young Han Lee [Sun, 29 Mar 2015 02:13:01 +0000 (11:13 +0900)]
validate:launcher: Show timeout seconds for timeout result message
Current timeout message doesn't show how many seconds a test took and
it is timeouted by normal timeout or hard timeout.
This patch changes the message like following.
1. normal timeout
old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out: 120 secs)
2. hard timeout
old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Hard timeout reached: 600 secs)
https://bugzilla.gnome.org/show_bug.cgi?id=746957
Young Han Lee [Mon, 30 Mar 2015 07:00:09 +0000 (16:00 +0900)]
validate:launcher: Fix wrong test number with -j option
When '-j n' option is given, first n tests print test number 0.
This is caused by test_num part of
919db986052602dca452f05e284cfc857302d4f0.
https://bugzilla.gnome.org/show_bug.cgi?id=747006
Thibault Saunier [Sat, 28 Mar 2015 22:29:56 +0000 (23:29 +0100)]
validate:launcher: Avoid depending on PyGObject
Summary:
And rely on our knowledge of the configuration to figure out where the
suppression file has been installed
Reviewers: gdesmott
Differential Revision: http://phabricator.freedesktop.org/D61
Guillaume Desmottes [Thu, 26 Mar 2015 14:42:11 +0000 (15:42 +0100)]
validate: media-descriptor-writer: don't leak info and streaminfo
Guillaume Desmottes [Thu, 26 Mar 2015 14:39:12 +0000 (15:39 +0100)]
validate: media-check: don't leak output_file and expected_file
Guillaume Desmottes [Thu, 26 Mar 2015 12:59:30 +0000 (13:59 +0100)]
validate: check VALGRIND_ERROR_CODE in Test as well
We were doing it only in GstValidateTest which was overriding the default
implementation.
Guillaume Desmottes [Thu, 26 Mar 2015 12:57:34 +0000 (13:57 +0100)]
validate: don't increase hard_timeout is if it's None
Some tests, like the media check ones, have None as hard_timeout.
Guillaume Desmottes [Thu, 26 Mar 2015 10:29:26 +0000 (11:29 +0100)]
validate: increase VALGRIND_TIMEOUT_FACTOR
5 wasn't enough for my poor laptop.
Guillaume Desmottes [Thu, 26 Mar 2015 10:29:06 +0000 (11:29 +0100)]
validate: increase the normal timeout as well when using valgrind
Guillaume Desmottes [Thu, 26 Mar 2015 09:32:09 +0000 (10:32 +0100)]
validate: media-descriptor: fix caps leak
gst_pad_get_current_caps() returns a reffed caps.
Guillaume Desmottes [Mon, 23 Mar 2015 12:36:45 +0000 (13:36 +0100)]
also call gst_deinit() in media-check and transcoding
More valgrind friendly.
Guillaume Desmottes [Mon, 23 Mar 2015 15:19:49 +0000 (16:19 +0100)]
validate: raise an error if valgrind detected issues
Differential Revision: http://phabricator.freedesktop.org/D53
Guillaume Desmottes [Mon, 23 Mar 2015 12:36:45 +0000 (13:36 +0100)]
call gst_deinit() when we are done
More valgrind friendly.
Guillaume Desmottes [Mon, 23 Mar 2015 12:35:41 +0000 (13:35 +0100)]
validate: call gst_bus_remove_signal_watch()
We are supposed to call gst_bus_remove_signal_watch() for each gst_bus_add_signal_watch() call to prevent leaks.
Guillaume Desmottes [Mon, 23 Mar 2015 09:24:21 +0000 (10:24 +0100)]
validate: media-descriptor-parser: fix string leak
_set_content() doesn't actually consume @content so the caller is responsible
freeing it.
Guillaume Desmottes [Mon, 23 Mar 2015 09:23:02 +0000 (10:23 +0100)]
validate: pad-monitor: fix buffers list leak
Guillaume Desmottes [Mon, 23 Mar 2015 09:22:47 +0000 (10:22 +0100)]
validate: pad-monitor: fix caps leak
Guillaume Desmottes [Fri, 20 Mar 2015 14:22:32 +0000 (15:22 +0100)]
validate: fix a bunch of GstBus leaks
Guillaume Desmottes [Mon, 23 Mar 2015 08:39:30 +0000 (09:39 +0100)]
validate: store valgrind logs to its own file
Guillaume Desmottes [Fri, 20 Mar 2015 14:00:28 +0000 (15:00 +0100)]
validate: report: fix invalid read when destroying Report
Summary:
@report was invalid when we were trying to clear the mutex.
validate: scenario: remove weak pointer when destroying action
Free an invalid read when the scenario is destroyed after the action.
Differential Revision: http://phabricator.freedesktop.org/D44
Guillaume Desmottes [Fri, 20 Mar 2015 13:49:24 +0000 (14:49 +0100)]
validate: report: fix invalid read when destroying Report
@report was invalid when we were trying to clear the mutex.
Guillaume Desmottes [Fri, 20 Mar 2015 11:15:03 +0000 (12:15 +0100)]
validate: fix string arguments leaks
We are responsible of freeing the string arguments parsed by GOptionContext.
Guillaume Desmottes [Fri, 20 Mar 2015 10:39:32 +0000 (11:39 +0100)]
validate: scenario: don't borrow @structure in _fill_action()
@structure was borrowed in some code path and wasn't in some other. Make it
clearer, and fix a leak, by always copying it.
Guillaume Desmottes [Fri, 20 Mar 2015 10:33:01 +0000 (11:33 +0100)]
validate: override-registry: fix structs list leak
The list returned by _lines_get_strutures() needs to be deeply freed.
Guillaume Desmottes [Fri, 20 Mar 2015 10:27:29 +0000 (11:27 +0100)]
validate: scenario: fix scenarios leak
Guillaume Desmottes [Fri, 20 Mar 2015 10:25:39 +0000 (11:25 +0100)]
validate: reporter: fix message leak
Guillaume Desmottes [Fri, 20 Mar 2015 10:24:27 +0000 (11:24 +0100)]
validate: report: don't shadow the GString variable
We were leaking the GString as it's freed outside of the block.
Guillaume Desmottes [Fri, 20 Mar 2015 10:24:04 +0000 (11:24 +0100)]
validate: report: fix GStrv leak
Guillaume Desmottes [Fri, 20 Mar 2015 10:23:29 +0000 (11:23 +0100)]
validate: report: fix GStrv leak
We borrow the content of the GStrv but were leaking the array itself.
Guillaume Desmottes [Thu, 19 Mar 2015 16:22:26 +0000 (17:22 +0100)]
launcher: try using gst.supp as valgrind suppressions file
https://bugzilla.gnome.org/show_bug.cgi?id=746465
Guillaume Desmottes [Thu, 19 Mar 2015 16:44:19 +0000 (17:44 +0100)]
validate: install gst.supp
Will be used when running tests inside Valgrind.
https://bugzilla.gnome.org/show_bug.cgi?id=746465
Guillaume Desmottes [Thu, 19 Mar 2015 15:06:54 +0000 (16:06 +0100)]
launcher: add valgrind support
Add a --valgrind option to gst-validate-launcher to run the tests inside
Valgrind and tune GLib's memory allocator accordingly.
Fix https://bugzilla.gnome.org/show_bug.cgi?id=746465
Guillaume Desmottes [Fri, 20 Mar 2015 09:06:35 +0000 (10:06 +0100)]
validate: move scenarios to validate/scenarios/
https://bugzilla.gnome.org/show_bug.cgi?id=746465
Guillaume Desmottes [Thu, 19 Mar 2015 11:22:39 +0000 (12:22 +0100)]
validate:launcher: Fix small typo
Thibault Saunier [Wed, 18 Mar 2015 16:05:19 +0000 (17:05 +0100)]
validate:launcher: Make sure to show apps specific options in the help
Thibault Saunier [Wed, 18 Mar 2015 10:05:08 +0000 (11:05 +0100)]
validate:launcher: Fix test number printing
Thibault Saunier [Sat, 14 Mar 2015 15:40:17 +0000 (15:40 +0000)]
validate:launcher Rename _other_testsuite_for_tester
To _check_tester_has_other_testsuite
Thibault Saunier [Sat, 14 Mar 2015 15:08:12 +0000 (15:08 +0000)]
validate:launcher: Cache all the tests in the runner
This way we do not have to re ask all the test managers
what tests should be run.
Thibault Saunier [Fri, 13 Mar 2015 17:09:08 +0000 (17:09 +0000)]
validate:launcher: Add a way to simply run validate default tests on uris
Summary:
This allows us to easily run all the scenarios on a particular file doing:
$ gst-validate-launcher validate --validate-check-uri file:///some/media/file.webm
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D36
Thibault Saunier [Fri, 13 Mar 2015 17:07:00 +0000 (17:07 +0000)]
validate: keep executing actions even after linking up following execution
When linking actions execution without waiting on execution context, then
idle callback should keep being called so following action keep being
executed.
Thibault Saunier [Tue, 10 Mar 2015 09:29:28 +0000 (10:29 +0100)]
validate: Add more files to .gitignore
Differential Revision: http://phabricator.freedesktop.org/D34
Thibault Saunier [Tue, 10 Mar 2015 09:25:23 +0000 (10:25 +0100)]
validate:scenario: Rename get_position to execute_next_action
That function was wrongly called and did not correspond to what it
actually does.
Vincent Penquerc'h [Mon, 9 Mar 2015 18:26:37 +0000 (18:26 +0000)]
Revert "validate: add non flushing seek support"
This reverts commit
3ff55dcc3119b39e7c86044159db8bce49a2dc3a.
Regressions on the test server, apparently linked to this patchset.
Vincent Penquerc'h [Mon, 9 Mar 2015 18:26:33 +0000 (18:26 +0000)]
Revert "validate: use segments to detect success of flushing seeks too"
This reverts commit
c47cc7ba90e96ffaefe201087428ef448670f3be.
Regressions on the test server, apparently linked to this patchset.
Vincent Penquerc'h [Mon, 9 Mar 2015 18:26:06 +0000 (18:26 +0000)]
Revert "validate: expect a buffer with discontinuity after a seek"
This reverts commit
87064b6994e36203b6976d436feda809068f1497.
Regressions on the test server, apparently linked to this patchset.
Thibault Saunier [Mon, 9 Mar 2015 17:41:54 +0000 (18:41 +0100)]
validate:launcher: Make sure TIMEOUTs do not get converted to ERROR
This was a regression introduced in
c0e3d2e4f190fc9627897cc3d3d016448cb5dbe9
Vincent Penquerc'h [Fri, 27 Feb 2015 16:56:06 +0000 (16:56 +0000)]
validate: expect a buffer with discontinuity after a seek
https://bugzilla.gnome.org/show_bug.cgi?id=744783
Vincent Penquerc'h [Fri, 27 Feb 2015 14:40:09 +0000 (14:40 +0000)]
validate: use segments to detect success of flushing seeks too
https://bugzilla.gnome.org/show_bug.cgi?id=744783
Vincent Penquerc'h [Thu, 19 Feb 2015 13:12:50 +0000 (13:12 +0000)]
validate: add non flushing seek support
and a couple scenarios using them
https://bugzilla.gnome.org/show_bug.cgi?id=744783
Thibault Saunier [Fri, 6 Mar 2015 08:39:10 +0000 (09:39 +0100)]
validate:launcher: Do not forget to install apps/__init__.py
It is a python module that should be usable by external apps/testsuites
Thibault Saunier [Thu, 5 Mar 2015 12:33:27 +0000 (13:33 +0100)]
validate:scenario: Handle not mandatory action types
Summary:
There is currently no way to handle the fact that action types
might be handled only by a specific application but not handling
this action types would not cause any difference for the good execution
of the scenario as a whole
Differential Revision: http://phabricator.freedesktop.org/D33
Thibault Saunier [Mon, 2 Mar 2015 16:32:56 +0000 (17:32 +0100)]
validate:launcher: Better handle GST debug log outputs redirection
Thibault Saunier [Wed, 4 Mar 2015 16:30:41 +0000 (17:30 +0100)]
validate:launcher: First rely on the presence of criticals to set tests result
In the case of external applications they might not set their exist
code bases on the result of validate so we should rely on what
validates as to say first.
Thibault Saunier [Wed, 4 Mar 2015 16:26:55 +0000 (17:26 +0100)]
validate:report: Allow registering of issue types through the introspection
Fixing annotations and make GstValidateIssue refcounted
We break the ABI in that commit but I do not expect anyone to register
issue type outside GstValidate yet.
Add padding in the structures so we can avoid breaking the ABI again later.
Thibault Saunier [Wed, 4 Mar 2015 16:24:52 +0000 (17:24 +0100)]
validate:monitor: Do not requiere a GstObject as target
We can work with any GObject and that allows applications to write
monitors for other aspects too
Thibault Saunier [Tue, 3 Mar 2015 11:26:52 +0000 (12:26 +0100)]
validate:scenario: Alway execute sub action on action running SYNC
Move methods around to avoid needing on top prototypes
Wonchul Lee [Tue, 3 Mar 2015 10:26:33 +0000 (19:26 +0900)]
validate:docs: Rename gst-validate-launch to gst-validate-launcher
https://bugzilla.gnome.org/show_bug.cgi?id=745510
Thibault Saunier [Tue, 3 Mar 2015 10:33:06 +0000 (11:33 +0100)]
validate:scenario: Do not execute last sub action twice when ASYNC
Thibault Saunier [Tue, 3 Mar 2015 09:39:52 +0000 (10:39 +0100)]
validate:scenario: Properly print sub action as if they were main actions
Emanuele Aina [Mon, 2 Mar 2015 13:38:16 +0000 (14:38 +0100)]
validate:docs: Fix typos in Scenario File Format
https://bugzilla.gnome.org/show_bug.cgi?id=736160
Thibault Saunier [Thu, 26 Feb 2015 17:51:57 +0000 (18:51 +0100)]
validate:launcher Do not use git -C as it is relatively recent
https://bugzilla.gnome.org/show_bug.cgi?id=736160
Thibault Saunier [Thu, 26 Feb 2015 10:09:23 +0000 (11:09 +0100)]
validate: Build the preload so when possible
Thibault Saunier [Tue, 24 Feb 2015 18:32:37 +0000 (19:32 +0100)]
validate:launcher: Print the long help in less when possible
Thibault Saunier [Tue, 24 Feb 2015 18:08:12 +0000 (19:08 +0100)]
validate:launcher: Mention testsuite implementation in the help
Thibault Saunier [Mon, 23 Feb 2015 11:24:39 +0000 (12:24 +0100)]
validate: Define GST_PLUGIN_LDFLAGS as needed
Young Han Lee [Thu, 19 Feb 2015 11:53:16 +0000 (20:53 +0900)]
validate: Determine development mode using git hash value
Development mode has been determined by whether the launcher is in git
repo
or not. This could be wrong when the launcher is installed to
subdirectory of other project's git repo, such as jhbuild. It is normal
to install compiled output to subdirectory of your jhbuild.
Changed logic gets the first commit hash of current git repo and
compares it with gst-devtools' the first commit hash.
https://bugzilla.gnome.org/show_bug.cgi?id=744781
Thibault Saunier [Thu, 19 Feb 2015 10:32:05 +0000 (11:32 +0100)]
validate:launcher: Fix typo s/FILE_EXTENDION/FILE_EXTENSION/g
Thibault Saunier [Wed, 18 Feb 2015 13:23:16 +0000 (14:23 +0100)]
validate:scenario: Fix GstValidateAction ABI adding a private structure
This way we can easily extend the structure and avoid needing using
a union and such
Mathieu Duponchelle [Thu, 22 Jan 2015 21:29:10 +0000 (22:29 +0100)]
validate: Test buffer outside of received range.
Summary: As part of the preparation for a port to tracer.
Test Plan: This is a test, we won't test tests
Reviewers: tsaunier
Differential Revision: http://internal.opencreed.com:8888/D19
Tim-Philipp Müller [Wed, 18 Feb 2015 11:36:59 +0000 (11:36 +0000)]
codecanalyzer: fix codec detection with git master
The names might be 'MPEG-2 (Simple Profile)' now.
Shouldn't really rely on codec name strings here
in the first place, but use caps instead.
Thibault Saunier [Wed, 18 Feb 2015 09:05:55 +0000 (10:05 +0100)]
validate: Properly notify user about missing plugins
This way it is clear in gst-validate-launcher that the failure is due
to a missing plugin
Thibault Saunier [Tue, 17 Feb 2015 17:18:56 +0000 (18:18 +0100)]
validate: Fix wrong sizeof usage
sizeof(int) is always <= sizeof(gpointer)
Ramiro Polla [Wed, 21 Jan 2015 12:13:02 +0000 (13:13 +0100)]
validate: launcher: Use cElementTree for XML parsing
Using cElementTree instead of ElementTree speeds up parsing of media
descriptor files.
The total time spent parsing XML files drops from ~0.64 s to ~0.24 s,
leading to faster initialisation times for gst-validate-launcher.
https://bugzilla.gnome.org/show_bug.cgi?id=743293
Thibault Saunier [Tue, 17 Feb 2015 13:56:47 +0000 (14:56 +0100)]
validate: Print actions directly from the scenario
Avoiding user to have to print them in each and every action type
implementation.
This requires adding some API to prepare actions before printing them.
Preparing action in that case mean parsing the values contained in the
GstStructure parsing equations and setting back the actual value
afterward
API:
* GstValidatePrepateAction
* gst_validate_action_type_set_prepare_function
Thibault Saunier [Mon, 16 Feb 2015 21:12:54 +0000 (22:12 +0100)]
validate: Fix build on windows
Check where libgstvalidate.dll is installed and use that base folder to
figure out where GstValidate plugins are installed
Thibault Saunier [Mon, 16 Feb 2015 19:52:54 +0000 (20:52 +0100)]
validate: Do not forget to dist _full variant of scrubing scenarios
Thibault Saunier [Mon, 16 Feb 2015 18:49:50 +0000 (19:49 +0100)]
validate: Create a gst-validate-types.h header where we define types
And include it from validate.h.
This way we avoid to need to typedef GstValidateAction twice, which is
a C11 feature
Edward Hervey [Mon, 16 Feb 2015 18:24:23 +0000 (19:24 +0100)]
validate-report: Fix valist usage
a va_list always 'exists' (it's a struct). It therefore can't be NULL
(and can't be tested)
Just use the regular print variant where appropriate.
Thibault Saunier [Mon, 16 Feb 2015 15:47:37 +0000 (16:47 +0100)]
validate:scenario: Document locking
Thibault Saunier [Fri, 13 Feb 2015 11:17:37 +0000 (12:17 +0100)]
validate:scenario: Make get_position happen on idle
Summary:
- Add a way to force action to be executed in their own GSource dispatch, disabling chain action execution
API:
GstValidateScenario::execute-on-idle property
Thibault Saunier [Thu, 12 Feb 2015 15:23:49 +0000 (16:23 +0100)]
validate:scenario: Add a method to retrieve all remaining actions
Not only the next one as it was not making much sense!
API:
- gst_validate_scenario_get_next_action
+ gst_validate_scenario_get_actions
Thibault Saunier [Thu, 12 Feb 2015 15:13:09 +0000 (16:13 +0100)]
validate:utils: Fix some annotations
Thibault Saunier [Thu, 12 Feb 2015 15:10:00 +0000 (16:10 +0100)]
validate:scenario: Allow link up of action executions for overriden types
Exposing a GstValidateActionType.overriden_type field
And properly expose gst_validate_execute_action
Thibault Saunier [Thu, 12 Feb 2015 15:09:11 +0000 (16:09 +0100)]
validate:reporter: Always print reports in the Gst debug system
Thibault Saunier [Wed, 11 Feb 2015 17:27:10 +0000 (18:27 +0100)]
validate: Misc fixes
Thibault Saunier [Wed, 11 Feb 2015 16:06:06 +0000 (17:06 +0100)]
validate: Properly annotate gst_validate_register_action_type*
It does not return any reference to the type