Kyungwoo Lee [Thu, 15 Jun 2017 22:55:34 +0000 (15:55 -0700)]
Remove static for function pointer
qsort with static compare functions crashes with ALTJIT.
It appears due to _guard_check_icall_fptr in Windows 10.
Simply dropping static keyword works.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d12221cbca178280c2f5d576a6fdc538bed35e8
Stephen Toub [Thu, 15 Jun 2017 22:49:56 +0000 (18:49 -0400)]
Merge pull request dotnet/coreclr#12307 from stephentoub/iswhitespace
Small cleanup to Char.IsWhiteSpaceLatin1
Commit migrated from https://github.com/dotnet/coreclr/commit/
e70c1bd377040ff49ea9a044556debedee1da959
Jarret Shook [Thu, 15 Jun 2017 22:01:00 +0000 (15:01 -0700)]
Merge pull request dotnet/coreclr#12311 from jashook/arm64_unix_ci
Add the arm64 unix CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
b73a9d93c9aa8c2c3ca105e235a3d7869484b201
Jarret Shook [Thu, 15 Jun 2017 21:36:22 +0000 (14:36 -0700)]
Merge branch 'master' into arm64_unix_ci
Commit migrated from https://github.com/dotnet/coreclr/commit/
894ddb42988a1c0d9dcfbf924ded7d7747e4f6ba
jashook [Mon, 17 Apr 2017 22:53:12 +0000 (15:53 -0700)]
Add the arm64 unix CI
This will enable unix arm64 testing in CI. Currently there are no
default tirggers; however, anyone will be able to request the jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f75b7093f12137364f1a296545dc6defb528fd10
Jarret Shook [Thu, 15 Jun 2017 21:31:55 +0000 (14:31 -0700)]
Merge pull request dotnet/coreclr#12310 from dotnet/revert-11743-arm64_unix_ci
Revert "Add the arm64 unix CI"
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c4dfb133c7a4d162fdd1030c6316397ab6b892d
Jarret Shook [Thu, 15 Jun 2017 21:31:30 +0000 (14:31 -0700)]
Revert "Add the arm64 unix CI"
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c64ce59afa1d028ee5098166b2030b8a7ed278c
Jarret Shook [Thu, 15 Jun 2017 21:20:11 +0000 (14:20 -0700)]
Merge pull request dotnet/coreclr#11743 from jashook/arm64_unix_ci
Add the arm64 unix CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
35ab28fd818de8933f6e02472ea34196b52df40e
Stephen Toub [Thu, 15 Jun 2017 20:22:10 +0000 (16:22 -0400)]
Merge pull request dotnet/coreclr#12297 from stephentoub/getdatepart
Avoid duplicated computations with DateTime.GetDatePart
Commit migrated from https://github.com/dotnet/coreclr/commit/
d5d64fe951e939512eea2bb944691dd427976cc6
Stephen Toub [Thu, 15 Jun 2017 20:14:32 +0000 (16:14 -0400)]
Small cleanup to Char.IsWhiteSpaceLatin1
For some reason this is resulting in measurably better throughput, in particular for non-whitespace chars, so much so that it's visible in microbenchmarks against string.IsNullOrWhiteSpace.
If nothing else, it's cleaner.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f05efea2ea9e9c9e1ee9772a9da5fae4ca76ad7
Jan Kotas [Thu, 15 Jun 2017 14:32:54 +0000 (07:32 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3890 from jkotas/nmirror-merge
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
dcd16e7fd27fd01309a5e85a20c2d98e0f97a944
Roman Artemev [Thu, 15 Jun 2017 19:51:28 +0000 (12:51 -0700)]
Merge pull request dotnet/coreclr#12047 from rartemev/issue_4122_2
Fixed determintaion of need to make code that contains tail.call loop fully interuptible
Commit migrated from https://github.com/dotnet/coreclr/commit/
110eebb91dae1a7d2765803be02491802603ef31
Sean Gillespie [Thu, 15 Jun 2017 19:45:12 +0000 (12:45 -0700)]
[Local GC] Fix a number of handle table interface violations (dotnet/coreclr#12277)
* Fix a smattering of GC handle table interface violations
Stub out a few other handle violations
* [Local GC] Add SetExtraInfoForHandle onto GC handle manager interface
* [Local GC] Changes uses of HndGetHandleADIndex to GetHandleContext
* Add HandleGetType to GC handle table interface
1) Change IGCHandleManager methods that take "int" to represent the type of a handle to HandleType, and fix callers to cast to HandleType
2) Add HandleFetchType to IGCHandleManager, returning a HandleType
3) Fix uses of handtablepriv's HandleFetchType and remove the GC directory from the include path
* 9 -> HNDTYPE_WEAK_WINRT, 0 -> HNDTYPE_WEAK_SHORT in assert
Commit migrated from https://github.com/dotnet/coreclr/commit/
dda6b6136e21901842758970d831f31687913a35
Jarret Shook [Thu, 15 Jun 2017 18:28:54 +0000 (11:28 -0700)]
Merge branch 'master' into arm64_unix_ci
Commit migrated from https://github.com/dotnet/coreclr/commit/
308c352f07b4e3e0c4069ac1d403900381a0afd5
Brian Sullivan [Thu, 15 Jun 2017 18:16:42 +0000 (11:16 -0700)]
Merge pull request dotnet/coreclr#12287 from briansull/nowarn-SIMD
Crossgen - Disable the Target-dependent SIMD vector types warning
Commit migrated from https://github.com/dotnet/coreclr/commit/
d734877cd86016296fc6c6e884a2b119339545ec
Bruce Forstall [Thu, 15 Jun 2017 17:15:47 +0000 (10:15 -0700)]
Merge pull request dotnet/coreclr#12251 from kyulee1/override
Missing override keyword to DoPhase
Commit migrated from https://github.com/dotnet/coreclr/commit/
dd2181cde582168752335d7859c92b3274028f77
Steve MacLean [Thu, 15 Jun 2017 15:52:15 +0000 (15:52 +0000)]
Add sdmaclea to arm64Users
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d73bbd8c3b26ce311ee4cf8d933bc453de84a0b
dotnet-maestro-bot [Thu, 15 Jun 2017 15:42:52 +0000 (08:42 -0700)]
Update CoreClr, CoreFx to preview1-25415-03, preview1-25415-01, respectively (dotnet/coreclr#12284)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c0214b5a3c22e4134b720f32e72582904b4a11d7
Stephen Toub [Thu, 15 Jun 2017 15:31:12 +0000 (11:31 -0400)]
Avoid duplicated compuations with DateTime.GetDatePart
- Remove duplicate code in GregorianCalendar. GetDatePart is identical to the implementation in DateTime. Just reuse it via the Year/Month/Day properties. Also avoids an unnecessary virtual call.
- Then copy GetDatePart into a version that returns year/month/day rather than just one of them.
- And use that in several places throughout corelib where all three are retrieved, avoiding redoing all of the calculations three times.
Commit migrated from https://github.com/dotnet/coreclr/commit/
17c23bed6395f3e12dc0b4471b2bb566c3aa136c
Steve MacLean [Thu, 15 Jun 2017 06:35:49 +0000 (02:35 -0400)]
[Arm64] JIT_WriteBarrier optimization (dotnet/coreclr#12227)
* [Arm64] JIT_WriteBarrier optimization
Add skipEphemeralCheck if gcServer=1
Copy all gc parameters into a literal pool which
fits in single cache line
Add dmb ishst on gcHeap changes
Reduce unpredictable branches
Remove unneeded instructiuons
Fixes dotnet/coreclr#11374
Fixes dotnet/coreclr#12197
* [Arm64] fix typo in asm
* Fixup asm
* [Arm64] Revise per comments
Nits - Whitespace, Labels to PascalCase
Fix state change order
Add Suspend/Resume to fix race
Fix errors in Windows arm64 assembly
* [Arm64] Remove SuspendEE/RestartEE in StompWriteBarrierResize
* Use Volatile<> for g_highest_address
* Revise synchronization per comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5914c8d1b20be898b8982a4dfcf9d8e9046b2ec
Jonghyun Park [Thu, 15 Jun 2017 06:06:41 +0000 (15:06 +0900)]
Remove unused forward declaration (dotnet/coreclr#12288)
Commit migrated from https://github.com/dotnet/coreclr/commit/
34320b9242f4e16eedcb9adc2f0901702b19deac
chcosta [Thu, 15 Jun 2017 06:05:46 +0000 (23:05 -0700)]
Fix build break
Download from Azure task does not retain blob prefix when downloading blobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ac5484c841eb5ecab69526aeb6400be45308383f
Brian Sullivan [Thu, 15 Jun 2017 01:44:12 +0000 (18:44 -0700)]
Crossgen - Disable the Target-dependent SIMD vector types warning
When a SIMD type is referenced during CEEPreloader instead of loading it
we throw a type load exception with a unique resource ID and message.
This commit changed the ICorCompileDataStore interface to allow us to pass
the unique resource ID over to the zapper from the VM.
The Zapper can then demote certain resource ID warnings down to the
lowest informational level, so that they aren't printed out during crossgen.
With this commit we currently are demoting IDS_EE_SIMD_NGEN_DISALLOWED
Commit migrated from https://github.com/dotnet/coreclr/commit/
f79d7e81f70739ab9ae266382aecdfd8c750d06d
dotnet-maestro-bot [Thu, 15 Jun 2017 00:29:45 +0000 (17:29 -0700)]
Update CoreClr to preview1-25414-05 (dotnet/coreclr#12282)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5f2e55f67c098d326988aff1f7616fd34ccdf56
chcosta [Thu, 15 Jun 2017 00:28:10 +0000 (17:28 -0700)]
Update buildtools to 2.0.0-prerelease-01714-04 (dotnet/coreclr#12280)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d83f176fdc71dc321eb33a7ea8e20150c5e62e9d
Tarek Mahmoud Sayed [Wed, 14 Jun 2017 23:36:24 +0000 (16:36 -0700)]
Fix NullReferenceException thrown when using CurrentCulture (dotnet/coreclr#12281)
CurrentCulture used the static field s_userDefaultCulture which used to store the current culture. We always ensure this field is initialized all the time. When we introduced the v2.0 added APIs, we have added ClearCachedData(). This method was setting s_userDefaultCulture to null which can cause any other thread to throw this NullReferenceException if it is using s_userDefaultCulture. Here is example of such stack
System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace :
at System.Globalization.NumberFormatInfo.get_CurrentInfo()
at System.Double.ToString(String format, IFormatProvider provider)
Commit migrated from https://github.com/dotnet/coreclr/commit/
018e5252ed8427aeffea43a2935114149e10bc1b
Viktor Hofer [Wed, 14 Jun 2017 19:57:36 +0000 (21:57 +0200)]
Renaming serializable field (dotnet/coreclr#12273)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f00fec141ca1b222b1c113d2de055e80728bb99
Brian Sullivan [Wed, 14 Jun 2017 19:57:20 +0000 (12:57 -0700)]
Remove the warning about Implicit boxing during crossgen (dotnet/coreclr#12274)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ffe2ba52989a224a524027227509acf1735ca96
Jarret Shook [Wed, 14 Jun 2017 19:47:55 +0000 (12:47 -0700)]
Merge pull request dotnet/coreclr#12272 from jashook/add_documentation_for_building_tests_on_unix
Add documentation for building test(s) on Unix
Commit migrated from https://github.com/dotnet/coreclr/commit/
5db60d53a783e1d4a04ec7289b2571a7bcc27d18
jashook [Wed, 14 Jun 2017 17:01:58 +0000 (10:01 -0700)]
Add documentation for building test(s) on Unix
This also includes steps on how to build individual tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ba2acbdfe136cb5ab1b875368ed2768193d59b5e
Han Lee [Wed, 14 Jun 2017 16:14:18 +0000 (09:14 -0700)]
Fix a COMDouble::Round() issue (dotnet/coreclr#12210)
* Fix a COMDouble::Round() issue
fixes https://github.com/dotnet/coreclr/issues/12137
* Add a couple tests for Math.Round(double)
based on https://github.com/dotnet/coreclr/issues/12137
* Use G17 format specifier for printing double values
Commit migrated from https://github.com/dotnet/coreclr/commit/
395f145ba0c220afb1d85ff8c26f34909d8ea424
dotnet-maestro-bot [Wed, 14 Jun 2017 16:09:10 +0000 (09:09 -0700)]
Update CoreClr to preview1-25414-04 (dotnet/coreclr#12270)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7b051348604398af834713af786ac7d6ee3e5bc7
Jiyoung Giuliana Yun [Wed, 14 Jun 2017 14:50:51 +0000 (23:50 +0900)]
Add `-PortableBuild=false` option in Tizen CI build (dotnet/coreclr#12241)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2ecf158bf2618e46510ea67352b08fd66ed854b
sergey ignatov [Wed, 14 Jun 2017 14:28:12 +0000 (17:28 +0300)]
Additional to fix dotnet/coreclr#12104 for CoreRT issue dotnet/coreclr#3672 (armel tizen) (dotnet/coreclr#12244)
* Additional to fix dotnet/coreclr#12104 for CoreRT issue dotnet/coreclr#3672 (armel tizen)
* Fix for unregistered info.compLvFrameListRoot
Commit migrated from https://github.com/dotnet/coreclr/commit/
9255b5ea1acac68f62207f03dab509de97da93a9
Viktor Hofer [Wed, 14 Jun 2017 11:34:45 +0000 (13:34 +0200)]
Fix gethashcode for ordinal comparer (dotnet/coreclr#12267)
Fix GetHashCode for ordinal comparer
Commit migrated from https://github.com/dotnet/coreclr/commit/
905efa9828b0b02fcbfd339d155982aa4b36f8be
Jacek Blaszczynski [Wed, 14 Jun 2017 06:16:26 +0000 (08:16 +0200)]
Rewrite of OpCodeGen.pl script to generate correctly IL OpCodes (dotnet/coreclr#12040)
* Rewrite of OpCodeGen.pl script to generate correctly IL OpCodes related C# code: FlowControl.cs, OpCodes.cs, OpCodeTypes.cs, OperandType.cs, StackBehaviour.cs from opcode.def file
* Update OpcodeType.cs to OpCodeType.cs in System.Private.CorLib.csproj
Commit migrated from https://github.com/dotnet/coreclr/commit/
116a6cc7dd0ff0912251f7d1febed36460ea11cd
Bruce Forstall [Wed, 14 Jun 2017 06:16:05 +0000 (23:16 -0700)]
Improve the packing of RefPosition (dotnet/coreclr#12263)
The LSRA RefPosition type was not packing well. In particular,
bitfields don't pack unless they have the same base type.
Move all the data member declarations to the top, and make them adjacent,
so it is easier to see them all together. Also, change all bitfields
to "unsigned char" base type.
This reduces the size from 36 to 28 bytes for x86, and 48 to 40 bytes
for x64 (release, on Windows).
Commit migrated from https://github.com/dotnet/coreclr/commit/
d7e2ca54816f6a8bda589fde91a5e395f0896d29
Steve MacLean [Wed, 14 Jun 2017 06:04:01 +0000 (02:04 -0400)]
[Arn64/Unix] Revise Volatile.T barriers (dotnet/coreclr#12156)
* [Arm64] Revise Volatile<T> barriers
* Remove VolateStore from CopyValueClassUnchecked
* Replace MemoryBarrier() in CopyValueClassUnchecked
Commit migrated from https://github.com/dotnet/coreclr/commit/
d23a2bc131eae32c473e39fcb3b640af1a95d244
Omair Majid [Wed, 14 Jun 2017 05:39:08 +0000 (01:39 -0400)]
Keep previous cmake arguments when using buildstandalonegc (dotnet/coreclr#12108)
Currently, using buildstandalonegc makes ./build.sh discard any
previous values of __cmakearg set explicitly or implicitly. Preserve
those arguments.
Without this fix, the following invocations behave differently:
$ ./build.sh ignorewarnings buildstandalonegc verbose
$ ./build.sh buildstandalonegc ignorewarnings verbose
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2f9e21c69e70f1d0edac2392ff95d4670edff6e
dotnet-maestro-bot [Wed, 14 Jun 2017 05:29:42 +0000 (22:29 -0700)]
Update CoreClr, CoreFx to preview1-25414-02, preview1-25414-01, respectively (dotnet/coreclr#12258)
Commit migrated from https://github.com/dotnet/coreclr/commit/
40228489c1340b02567a23a263378872fcc45fba
Viktor Hofer [Wed, 14 Jun 2017 01:49:02 +0000 (03:49 +0200)]
Remove serializable attribute from OrdinalIgnoreCaseComparer (dotnet/coreclr#12215)
* Remove serializable attribute from OrdinalIgnoreCaseComparer
* Introducing OrdinalCaseSensitiveComparer to serialize correctly with netfx
* Updated PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe22770b9fe8f665679bde1c08d1372fb9f78e0e
Brian Sullivan [Wed, 14 Jun 2017 00:55:05 +0000 (17:55 -0700)]
Merge pull request dotnet/coreclr#12255 from briansull/concat-fix
Removed the unused vararg version of String Concat
Commit migrated from https://github.com/dotnet/coreclr/commit/
9def2055bab6e154806a800816a05ab811f056f6
Brian Sullivan [Tue, 13 Jun 2017 21:19:30 +0000 (14:19 -0700)]
Removed the unused vararg version of String Concat
The __arglist version of varargs is not supported on CoreCLR
Fixes issue dotnet/coreclr#12146 - crossgen warning - Vararg calling convention not supported.
Added a new test case for String Concat
Added <DebugType>None
Fixed src\JIT\Directed\Misc\gettype csproj as well
Commit migrated from https://github.com/dotnet/coreclr/commit/
91c8ecf830d0d336bff3337019d6501f6efafc12
Daniel Podder [Tue, 13 Jun 2017 21:51:55 +0000 (14:51 -0700)]
Skip PGO if clang is too old, and add warnings for skipped PGO (dotnet/coreclr#12248)
Clang/LLVM cannot merge profile data generated by a newer version of
itself. Training currently requires 3.6, but we don't want to completely
break the build for 3.5. I'm adding a version check to allow non-PGO
release builds on 3.5, along with a warning message. I'm also updating
the LTO detection to print a warning message if it causes PGO to be
disabled.
Commit migrated from https://github.com/dotnet/coreclr/commit/
94788b256bc2aaa930341e27dc5ae3baf3bbf8b5
Brian Sullivan [Tue, 13 Jun 2017 20:57:33 +0000 (13:57 -0700)]
Added the checked CORE_ROOT path to this
Commit migrated from https://github.com/dotnet/coreclr/commit/
25bc371325b21a4bed9e0337192dd04ad7051b54
William Godbe [Tue, 13 Jun 2017 20:55:54 +0000 (13:55 -0700)]
Merge pull request dotnet/coreclr#12092 from wtgodbe/CoreDisTools
Explicitly download correct version of CoreDisTools package
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e8cb3efb7556eea02ad43292b8baa8651e14e79
Brian Sullivan [Tue, 13 Jun 2017 20:08:43 +0000 (13:08 -0700)]
Specified where the failing tests are listed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
000343606a00124501cec18badc9ca551a636dc1
Brian Sullivan [Tue, 13 Jun 2017 20:04:12 +0000 (13:04 -0700)]
Updated the path for the test results html file
Commit migrated from https://github.com/dotnet/coreclr/commit/
33908992423ac89e7e2fa5af903ce2a3d81d3623
Brian Sullivan [Tue, 13 Jun 2017 19:59:42 +0000 (12:59 -0700)]
Fixed typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
6708d2db1b51bc2695c7fef2e62eed04701dc598
Brian Sullivan [Tue, 13 Jun 2017 19:58:37 +0000 (12:58 -0700)]
Updated for checked build testing and corrected some paths
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c02f85f175f3c96b0c77b3683f5132e6dccaacf
Kyungwoo Lee [Tue, 13 Jun 2017 18:37:14 +0000 (11:37 -0700)]
Missing override keyword to DoPhase
Commit migrated from https://github.com/dotnet/coreclr/commit/
a075b765d3ce3707c50f0a87c5c6a8a7e4c65f68
Bruce Forstall [Tue, 13 Jun 2017 17:35:43 +0000 (10:35 -0700)]
Merge pull request dotnet/coreclr#12105 from alpencolt/ryu-arm-softfp-pass-ret
[RyuJIT/armel] Fix for correct passing and returning float values.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d122b4cdb7beaf8fcae466e14134d1706b3e4c1
Sujin Kim [Tue, 13 Jun 2017 17:31:50 +0000 (02:31 +0900)]
[RyuJIT/ARM32] Fix assertion when using invalid imm for INS_add (dotnet/coreclr#12162)
* [RyuJIT/ARM32] Fix assertion when using invalid imm for INS_add
`JIT/Regression/CLR-x86-JIT/V1-M12-Beta2/b54611/b54611/b54611.sh`
Assertion failed '!"Instruction cannot be encoded" has been occurred.
INS_add couldn't process with the invalid imm of -273 on this test.
So in this PR, If it got the value that cannot be processed, moving to register that after changing status would be ran so that it can be processed.
* Modify 'Lowering::IsContainableImmed' to work normally.
insFlags when the function is called was always INS_FLAGS_DONT_CARE.
In this case, if the imm is such as -273, the result would be false.
The correct flags have to be set.
* add ifdef for the flags variable
Commit migrated from https://github.com/dotnet/coreclr/commit/
92fab181d26b47bc564add2c547e01cb1fa4bd95
Bruce Forstall [Tue, 13 Jun 2017 17:16:30 +0000 (10:16 -0700)]
Merge pull request dotnet/coreclr#12243 from hqueue/arm/ryujit/issue_11842
[RyuJIT/ARM32] Enable HasMultiRegRetVal() for struct
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2d31ca29b32be3ee227539c6fd696f485d184c1
Vance Morrison [Tue, 13 Jun 2017 16:56:20 +0000 (09:56 -0700)]
Make ActivityID guids process specific. (dotnet/coreclr#11726)
This is a port a change from the Nuget version of this library.
Bascially it hashs in the process ID into the activity ID GUID. This make collisions across processes unlikely.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ab98b752fc8a9db28586a418448f5a7e1b577e3
Bruce Forstall [Tue, 13 Jun 2017 16:50:40 +0000 (09:50 -0700)]
Merge pull request dotnet/coreclr#12235 from BruceForstall/FixSuperPmiCollect
Fix SuperPMI collection script to allow passing arch/flavor args
Commit migrated from https://github.com/dotnet/coreclr/commit/
845d2597c1bae425c735ee3b86c921ae0be49327
Michelle McDaniel [Tue, 13 Jun 2017 16:27:39 +0000 (09:27 -0700)]
Merge pull request dotnet/coreclr#12245 from adiaaida/throughputJobChanges
Replace System.Private.CoreLib with new version in TP jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
24fe4185b30e283fb64a88745d9d06de85912253
Daniel Podder [Tue, 13 Jun 2017 16:22:29 +0000 (09:22 -0700)]
Pull CoreCLR build from RHEL7.2 in perf runs (dotnet/coreclr#12238)
Our Ubuntu perf testing has been creating Linux CoreCLR builds by
creating the build locally. This fits the local developer scenario, but
doesn't actually test the bits that ship; the 'official' product
configuration is generated by building on RHEL 7.2 and packaging those
bits for various distros, including Ubuntu.
In order to more accurately measure end-user-perceived performance, we
should do the same thing official builds do: build on RHEL7.2, then copy
those bits onto other OSes to test perf on those OSes.
This PR makes that happen by structuring Linux perf and throughput jobs
as flow jobs, with builds up front on a RHEL VM, before the bits are
dropped onto Ubuntu perf test machines.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d133544362e7bed58c4cbff4aa58d927764320d0
dotnet bot [Tue, 13 Jun 2017 15:28:51 +0000 (08:28 -0700)]
Update CoreClr, CoreFx to preview1-25413-01, preview1-25413-02, respectively (dotnet/coreclr#12242)
Commit migrated from https://github.com/dotnet/coreclr/commit/
02fbd334c4d2b7b654fcc58b64d9bef5df55f74c
Michelle McDaniel [Tue, 13 Jun 2017 15:03:18 +0000 (08:03 -0700)]
Replace System.Private.CoreLib with new version in TP jobs
SPC and the jit/coreclr are tightly coupled. With the changes to
crossgen into the dll, rather than the ni.dll, the throughput jobs are
now using the non-crossgen'd version of SPC on TP runs, which led to a
regression in TP on Linux because our comparison was not the same. This
change updates testing to replace the System.Private.CoreLib in the
throughput directory with the System.Private.CoreLib built by the
coreclr build.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6de9e94f4896c541eaa7711a204436f03e0549b4
Ruben Ayrapetyan [Tue, 13 Jun 2017 13:58:41 +0000 (16:58 +0300)]
Partially remove relocations for ModuleSection (ZapVirtualSectionType). (dotnet/coreclr#11853)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b258792e59b09060f54e0c9bbd31edc3e67d1ae8
Davis Goodin [Tue, 13 Jun 2017 13:55:25 +0000 (08:55 -0500)]
Use NuGetPush target from BuildTools (dotnet/coreclr#12221)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8115d8bdaa208f100897c30d9016c77259adb762
Hyung-Kyu Choi [Tue, 13 Jun 2017 13:04:23 +0000 (22:04 +0900)]
[RyuJIT/ARM32] Enable HasMultiRegRetVal() for struct
This will pass some tests and will trigger NYI assertions as expected.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5782d53e52ecbbce25b182c8b8b50da0d18f243
Daniel Podder [Tue, 13 Jun 2017 08:14:34 +0000 (01:14 -0700)]
Fix Linux PGO optdata consumption + PGO count update (dotnet/coreclr#12239)
* Update PGO package version to
20170612-1411
* Fix PGO optdata path issue on Linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
a3ebe55ad325b1a68c5418a5e163ddbf71168a73
dotnet bot [Tue, 13 Jun 2017 04:01:29 +0000 (21:01 -0700)]
Update CoreClr, CoreFx to preview1-25412-03, preview1-25413-01, respectively (dotnet/coreclr#12234)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e977dde4c5f5210447564ca8779d3c6c00eaf7c1
Jarret Shook [Tue, 13 Jun 2017 02:34:48 +0000 (19:34 -0700)]
Fix legacy backend build when FEATURE_READYTORUN_COMPILER is undefined (dotnet/coreclr#12232)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9a249583f3d5c581dc13eeaca784a2bc50e08eca
William Godbe [Tue, 13 Jun 2017 00:56:29 +0000 (17:56 -0700)]
Merge pull request dotnet/coreclr#12175 from wtgodbe/VS2017
Use roslyn common props in test build
Commit migrated from https://github.com/dotnet/coreclr/commit/
b14ac34a328831c1a34fb78a8ecc7dc1a495813b
Drew Scoggins [Tue, 13 Jun 2017 00:16:24 +0000 (17:16 -0700)]
Merge pull request dotnet/coreclr#12223 from DrewScoggins/AddHelpToPerf
Add help statement for perf.groovy
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f118db246205f40dd2a96eb5bff88f531fd0fdc
Steve MacLean [Mon, 12 Jun 2017 23:49:39 +0000 (19:49 -0400)]
[Arm64/Unix] Implement YieldProcessor() (dotnet/coreclr#12229)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3adf9c1baadbb90136cbcc7b8e1833ac422a6f6
Bruce Forstall [Mon, 12 Jun 2017 23:26:23 +0000 (16:26 -0700)]
Fix SuperPMI collection script to allow passing arch/flavor args
Previously, runtest would always be invoked with the default
args, meaning x64 debug.
This script is not used in the coreclr test run.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ef197c877c61a567dc9ee940e04064c5cfca07a
Steve MacLean [Mon, 12 Jun 2017 21:14:12 +0000 (17:14 -0400)]
[Arm64/Unix] Add 64K page support (dotnet/coreclr#10981)
* [Arm64/Unix] Support 64K pages
* GC move GCToOSInterface::Initialize() into InitializeGarbageCollector()
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ee3b5e64a98dc71aefed2304fe4bcf7f66ca9f5
Bruce Forstall [Mon, 12 Jun 2017 20:33:13 +0000 (13:33 -0700)]
Merge pull request dotnet/coreclr#12163 from hseok-oh/ryujit/fix_11850_2
[RyuJIT/ARM32] Fix comment and ifdef condition
Commit migrated from https://github.com/dotnet/coreclr/commit/
c655981474be1d3aa0165408e5c3914c5cfc35a1
Sergey Andreenko [Mon, 12 Jun 2017 20:16:08 +0000 (13:16 -0700)]
make REG_VIRTUAL_STUB_PARAM depended on Abi. (dotnet/coreclr#12209)
* make REG_VIRTUAL_STUB_PARAM depended on Abi.
Add VirtualStubParamInfo that is part of compiler and must be init in
compCompile.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f8c5e8f3596c7e1607356894473db75b4353503
Wes Haggard [Mon, 12 Jun 2017 19:55:53 +0000 (12:55 -0700)]
Disable some test cases to workaround compiler bug
Need to workaround compiler bug https://github.com/dotnet/roslyn/issues/14785
so disabling some test cases in the JIT isisnt tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a0033795f551053cb199d85c77926f0840f5b583
wtgodbe [Mon, 12 Jun 2017 18:58:04 +0000 (11:58 -0700)]
Disable some GC tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ed2befa1c142cb4310fd0bbd028225d04a0fa82
Drew Scoggins [Mon, 12 Jun 2017 17:15:55 +0000 (10:15 -0700)]
Add help statement for perf.groovy
When you use the help from dotnet bot you do not get any of the
performance runs in the help. This should add those in.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b236624a1d867c94f918356f324c38785f1018e0
jashook [Mon, 17 Apr 2017 22:53:12 +0000 (15:53 -0700)]
Add the arm64 unix CI
This will enable unix arm64 testing in CI. Currently there are no
default tirggers; however, anyone will be able to request the jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c99cee8178a7833df4f6b22fb4cda25069624aed
dotnet bot [Mon, 12 Jun 2017 17:00:13 +0000 (10:00 -0700)]
Update CoreClr, CoreFx to preview1-25412-01, preview1-25412-02, respectively (dotnet/coreclr#12214)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1ee1145a37f355715160cb0895d8f5e57dc2d8b
Jonghyun Park [Mon, 12 Jun 2017 15:40:24 +0000 (00:40 +0900)]
[x86/Linux] Port 'ThrowControlForThread' (dotnet/coreclr#11641)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b386a62a3b191d01723fa9a5c65fa4914dcb4854
Daniel Podder [Sat, 10 Jun 2017 19:06:34 +0000 (12:06 -0700)]
Update PGO counts to version
20170609-1125 (dotnet/coreclr#12201)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c19fef3ed9dc3674ce761972e27a9c5f00ddfa9
Yi Zhang (CLR) [Sat, 10 Jun 2017 16:08:41 +0000 (09:08 -0700)]
Disable IEnumerable.GetEnumerator on RCW through IDispatch (dotnet/coreclr#11865)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d4a4144b622e4304ca04d450807a18807027ab38
dotnet bot [Sat, 10 Jun 2017 04:51:16 +0000 (21:51 -0700)]
Update CoreClr, CoreFx to preview1-25409-02, preview1-25410-01, respectively (dotnet/coreclr#12212)
Commit migrated from https://github.com/dotnet/coreclr/commit/
073d54b96f8577f7a14c03877fb84b8ce757cede
Swaroop Sridhar [Fri, 9 Jun 2017 03:30:02 +0000 (20:30 -0700)]
Move ILLink Perf to a separate job
This changes ILLink performance testing to its own leg.
With this change, ILLink perf test will not be run for every PR by default.
It can be requested explicitly on a PR, and will run on the rolling builds.
JitBench build breaks have broken the PR builds a few times, so this change
moves ILLink perf tests out of the PR job, so that MusicStore testing can be
enabled again.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef0fcc8b6f28d380cd193ca393557dc10aa0fb96
Santiago Fernandez Madero [Sat, 10 Jun 2017 00:18:01 +0000 (17:18 -0700)]
Revert ResourceManager change to unblock uap tests (dotnet/coreclr#12179)
Commit migrated from https://github.com/dotnet/coreclr/commit/
daed7e573ae715a3b7991fc63ea0c91c38d870f5
Sean Gillespie [Fri, 9 Jun 2017 23:08:10 +0000 (16:08 -0700)]
[Local GC] No longer need to initialize SVR dacvars separately (dotnet/coreclr#12173)
* [Local GC] No longer need to initialize SVR dacvars separately
* Remove rest of uses of DEFINE_DACVAR_SVR
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e11b32ca720f886adfa0cc2a6a46829feba78d0
Roman Artemev [Fri, 9 Jun 2017 23:06:53 +0000 (16:06 -0700)]
Merge pull request dotnet/coreclr#12208 from rartemev/fix_encoding_1
Fixed files encoding to utf8 (issue dotnet/coreclr#12182)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d15b1253b773080543d7e5b656e42d6e4b994688
Eugene Rozenfeld [Fri, 9 Jun 2017 22:24:26 +0000 (15:24 -0700)]
Merge pull request dotnet/coreclr#12200 from erozenfeld/FastTailCallLoweringFix
Fix fast tail call lowering bug.
Commit migrated from https://github.com/dotnet/coreclr/commit/
da86bd58e4781077733b4dc1815a87092855912d
William Godbe [Fri, 9 Jun 2017 21:25:47 +0000 (14:25 -0700)]
Merge pull request dotnet/coreclr#12206 from wtgodbe/OverlayOnly
Add documentation for build-overlay-only
Commit migrated from https://github.com/dotnet/coreclr/commit/
d70747230545129a275dfff3a6f5fc1817acb912
wtgodbe [Fri, 9 Jun 2017 21:20:54 +0000 (14:20 -0700)]
Add documentation for build-overlay-only
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f595e2370b1dd29c147c573d72efcd87a5c2191
Roman Artemev [Fri, 9 Jun 2017 20:12:51 +0000 (20:12 +0000)]
Fix files encoding to utf8
Commit migrated from https://github.com/dotnet/coreclr/commit/
37b9167187ee454908c60319c5b126386c73c68b
Roman Artemev [Fri, 9 Jun 2017 19:42:00 +0000 (12:42 -0700)]
Merge pull request dotnet/coreclr#12184 from rartemev/legacy_jit_1
Fix and enable legacy jit for x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
979cb251801d5a53286d3172a36815569e3da9a4
Eugene Rozenfeld [Fri, 9 Jun 2017 18:05:48 +0000 (11:05 -0700)]
Fix fast tail call lowering bug.
Lowering::LowerFastTailCall has code that handles the case when the caller and the callee both have parameters
passed on the stack and the callee has register arguments that are computed from the caller's stack-passed arguments.
In that case the stack arguments of the callee are set up in the caller's incoming argument area so they override
the caller's arguments. Lowering::LowerFastTailCall creates temps for any caller's arguments passed on the stack that are
used to compute callee's register arguments. That code had a bug where it was converting GT_LCL_FLD nodes into
GT_LCL_VAR nodes. That's problematic both for the case of a single-field struct with a double field and for multi-field structs.
In the former case we were getting LSRA asserts in checked builds and SBCG in release builds. In the latter case we were getting SBCG
both in checked and release builds.
The fix is not to convert GT_LCL_FLD nodes into GT_LCL_VAR nodes and mark the new temps as not-enregisterable if the
local is not-enregisterable.
An alternative fix would be to create multiple register temps for each GT_LCL_FLD or GT_LCL_VAR targeting the local but that
would complicate the code and I decided to go with a simlper solution for this uncommon case.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1bac92bcba5f3c9af08ba5088aa27c264d23f37
Carol Eidt [Fri, 9 Jun 2017 18:40:22 +0000 (11:40 -0700)]
Merge pull request dotnet/coreclr#12189 from mskvortsov/FixExplicitContainedness
[RyuJIT/ARM32] Fix failures related to explicit containedness
Commit migrated from https://github.com/dotnet/coreclr/commit/
c8c9f6d1ce72aa2ffcced312ce818779fc9aed0b
Pat Gavlin [Fri, 9 Jun 2017 16:51:06 +0000 (09:51 -0700)]
Merge pull request dotnet/coreclr#10996 from mikedn/magic-udiv
Do unsigned magic division
Commit migrated from https://github.com/dotnet/coreclr/commit/
e3c4bd2a8768e405b00e7d807d7f2cb1a64c66e8
Alexander Soldatov [Tue, 6 Jun 2017 14:10:12 +0000 (17:10 +0300)]
[RyuJIT/armel] Correct returning float values.
Returned from function float pointing value in softfp mode should be
stored into r0 (r0-r1 for TYP_DOUBLE).
Commit migrated from https://github.com/dotnet/coreclr/commit/
be4f1fa51ca71b542aa104c74f8c4771babd670a
Jonghyun Park [Fri, 9 Jun 2017 15:47:07 +0000 (00:47 +0900)]
Allow users to set the number of build processes (dotnet/coreclr#12188)
* Allow users to set the number of build processes
* Add a command-line option
* Use common initialization style (use __NumProc and extract initialization from build_native)
* Set __NumProc before argument parsing (and replace NumProc with __NumProc)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2235dcc5711bde70f16a846ce88c622d18ae63d
dotnet bot [Fri, 9 Jun 2017 15:10:58 +0000 (08:10 -0700)]
Update CoreClr, CoreFx to preview1-25409-01, preview1-25409-03, respectively (dotnet/coreclr#12187)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c5977560b5124680c3b1032a0702fd72fadb3fc
Viktor Hofer [Fri, 9 Jun 2017 15:08:13 +0000 (17:08 +0200)]
DateTime serialization fixed, added attention labels to serialized fields (dotnet/coreclr#12181)
* DateTime serialization fixed, added attention labels to serialized fields
* CultureAwareComparer serialization fix
* Order or property fixed
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdb827b6cf72bdb8b4d0dbdaec160c32de7c185f
Jonghyun Park [Fri, 9 Jun 2017 10:48:49 +0000 (19:48 +0900)]
[ARM/Linux] Validate memory using ldrb instead of ldr (dotnet/coreclr#12191)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c6ed7fedb868885660cd656c763e04464a9a284
Mikhail Skvortcov [Fri, 9 Jun 2017 07:55:19 +0000 (10:55 +0300)]
RyuJIT/ARM32: Fix failures related to explicit containedness
Commit migrated from https://github.com/dotnet/coreclr/commit/
712eefbd2c75d94eacbe97192ca0414fdd3c337b