Tarek Mahmoud Sayed [Sat, 25 Mar 2017 17:41:39 +0000 (10:41 -0700)]
Enable global invariant on OSX (dotnet/coreclr#10470)
* Enable Globalization Invariant on OSX
* Fix typo
* Fix small typo
* Remove static link to ICU lib
* Addressing the feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
094f808f2b4587c4409d5d7ac5ed5b992d41864e
Ofer Zelig [Sat, 25 Mar 2017 15:31:45 +0000 (02:31 +1100)]
Typo correction (dotnet/coreclr#10482)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab849639db83ee65e51838ef147cee8d21b813c7
Jan Kotas [Sat, 25 Mar 2017 15:30:40 +0000 (08:30 -0700)]
Delete pointless <internalonly/> comments (dotnet/coreclr#10479)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d4a6cf7bc9d1b5ccbf671f1c8fae1b4f83027cbd
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 15:04:23 +0000 (20:34 +0530)]
Issue dotnet/coreclr#7061 Remove private _Prop from StreamReader, StreamWriter (dotnet/coreclr#10480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9ec6e2cf0c921da14e90c4a07afc72239db1969
mikedn [Sat, 25 Mar 2017 14:45:10 +0000 (16:45 +0200)]
Some BitVecOps improvements (dotnet/coreclr#10437)
* Avoid virtual calls when allocating bitvectors
* Use specialized BitVecOps when possible
* Avoid unnecessary bitvector copying
* Cleanup CSE_DataFlow
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d5ce09e13a3ff43d592cc67c04e026a12cce008
Jan Kotas [Sat, 25 Mar 2017 07:42:49 +0000 (00:42 -0700)]
Add Interlocked.MemoryBarrierProcessWide (dotnet/coreclr#10476)
Contributes to dotnet/coreclr#16799
Commit migrated from https://github.com/dotnet/coreclr/commit/
76b7d89f6e32ff51ae4809827163864c40a6a76f
Ahson Ahmed Khan [Sat, 25 Mar 2017 05:50:14 +0000 (22:50 -0700)]
Remove return statement and throwing directly for obselete methods. (dotnet/coreclr#10477)
Commit migrated from https://github.com/dotnet/coreclr/commit/
082fd6e07823b7418820708641b1640376e7bfc6
Brian Sullivan [Sat, 25 Mar 2017 04:45:50 +0000 (21:45 -0700)]
Merge pull request dotnet/coreclr#10469 from briansull/ibc-dump
Change the Jit Disasm message when we have profile data
Commit migrated from https://github.com/dotnet/coreclr/commit/
41ac197533a80943a313b15660ab311d36a72e40
Brian Sullivan [Sat, 25 Mar 2017 04:44:51 +0000 (21:44 -0700)]
Merge pull request dotnet/coreclr#10466 from briansull/stress-fix
Fix for JitStress test failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9772e89c3126185b8b319954de9dcc93256fab1
Alex Perovich [Sat, 25 Mar 2017 04:10:49 +0000 (23:10 -0500)]
Move DateTime to shared partition (dotnet/coreclr#10460)
* Move DateTime to shared partition
Depends on dotnet/corefxdotnet/coreclr#17484
* Use CoreCLR specific impl of UtcNow on windows
* Use the internal call on unix as well
* Port good corert changes
Commit migrated from https://github.com/dotnet/coreclr/commit/
92b6ab81670b3e284a58dd282098ce782aed7617
Alex Perovich [Sat, 25 Mar 2017 03:13:09 +0000 (22:13 -0500)]
Cleanup unnecessary import (dotnet/coreclr#10472)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a5355996742034c88a4c5da592e56627d753b40
Dan Moseley [Sat, 25 Mar 2017 03:02:35 +0000 (20:02 -0700)]
Rename resource strings to match resx (dotnet/coreclr#10475)
Commit migrated from https://github.com/dotnet/coreclr/commit/
67ab2b3b406731712c80d37b6b23f0445bf96632
Jan Kotas [Sat, 25 Mar 2017 02:31:22 +0000 (19:31 -0700)]
Fixed m_ prefixes in a few files from shared partition (dotnet/coreclr#10473)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9851f95cd3d4cefe824b8ad90c61f05ff2fddbf1
Brian Sullivan [Fri, 24 Mar 2017 23:29:27 +0000 (16:29 -0700)]
Change the Jit Disasm message when we have profile date to include
information about the edge weights and the value of fgCalledCount.
Example:
; with IBC profile data, edge weights are valid, and fgCalledCount is 145
Commit migrated from https://github.com/dotnet/coreclr/commit/
99e2889af4e7ff9bba4fb8cd920a5bcba9407370
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 01:21:56 +0000 (06:51 +0530)]
CoreFx 14486 Remove argument validation in DangerousCreate (dotnet/coreclr#10462)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e5aef990eb4c8d7b34fc5f8a9a1fd5ed326410d
Brian Sullivan [Sat, 25 Mar 2017 00:51:47 +0000 (17:51 -0700)]
CR feedback
Removed assert about BB_NONE
Commit migrated from https://github.com/dotnet/coreclr/commit/
794c465391dfea71d493889ccd0c0123179720d1
Dan Moseley [Sat, 25 Mar 2017 00:42:44 +0000 (17:42 -0700)]
Remove dead strings (dotnet/coreclr#10445)
Removed 436 dead strings from .resx, kept 1034
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f1f3d52a9c25e8dab75516a913ca00ea2ba2332
Alex Perovich [Sat, 25 Mar 2017 00:18:37 +0000 (19:18 -0500)]
Sort entries in shared project (dotnet/coreclr#10465)
Commit migrated from https://github.com/dotnet/coreclr/commit/
15d79636cc00503c4ca66e5f3921153ed12789e9
Brian Sullivan [Fri, 24 Mar 2017 22:42:04 +0000 (15:42 -0700)]
Fix for JitStress test failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ef7c0bdfaad3c5e46e47922341b390a52b8dc79
Jan Kotas [Fri, 24 Mar 2017 21:59:25 +0000 (14:59 -0700)]
Merge pull request dotnet/coreclr#10459 from dotnet/mirror-merge-9061692
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b74dc44b28c8afa2e5b79051891b30708da9010
Jan Kotas [Fri, 24 Mar 2017 20:16:39 +0000 (13:16 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
40c4c3c866fd08842710f38ddc3998e8d214aa1c
Alex Perovich [Fri, 24 Mar 2017 18:40:21 +0000 (11:40 -0700)]
Use Array.Copy with index and remove coreclr specific function
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e9f1b4a2b98a6a268a69816d80f80063686b7b2
Atsushi Kanamori [Thu, 23 Mar 2017 22:34:07 +0000 (15:34 -0700)]
NS2.0 Complete DBNull's surface area. (dotnet/coreclr#3085)
* Copy over CoreCLRs' DBNull.cs
* Make it presentable, then move it into the shared partition.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a4cffe635dad862249899f0a181a72b791c6fafd
dotnet bot [Fri, 24 Mar 2017 17:39:37 +0000 (10:39 -0700)]
Update CoreClr to beta-25123-08 (dotnet/coreclr#10435)
Commit migrated from https://github.com/dotnet/coreclr/commit/
249902311a4f15712cb8e2553920948eaa21e87a
Joseph Tremoulet [Fri, 24 Mar 2017 16:55:01 +0000 (12:55 -0400)]
Merge pull request dotnet/coreclr#10149 from JosephTremoulet/DestSingleField
Scalarize single-field-to-lclVar block copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
4388703f3e25f9290d37da9d4d1de844a3a6154a
Bruce Forstall [Fri, 24 Mar 2017 15:57:23 +0000 (08:57 -0700)]
Merge pull request dotnet/coreclr#10451 from ionuttamas/patch-1
Update ryujit-overview.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
d0b09418c5033e1d9f646460c59f38e467649d36
Igor Kulaychuk [Fri, 24 Mar 2017 15:52:47 +0000 (18:52 +0300)]
[Linux][GDB-JIT] Add lexical scopes info for local variables (dotnet/coreclr#10307)
* Fix memory leak when getting local variable names
* Pass locals from SymbolReader using new LocalVarInfo struct
* Map IL to native addresses for variable scopes
* Dump variables with scopes
* Add scope info to VarDebugInfo
* Remove unnecessary usage of lines info in BuildDebugInfo
* Use holders for scopes and local var names
* Move array of FunctionMember from global scope to local scope
* Move SymbolNames from global scope to local scope
Commit migrated from https://github.com/dotnet/coreclr/commit/
a50348830471e9d821da525ed862e72e061b0766
Ilya [Fri, 24 Mar 2017 15:48:02 +0000 (18:48 +0300)]
Copy-paste errors found by PVS-Studio. (dotnet/coreclr#10450)
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the copy-paste errors, detected with the help of V778 diagnostic. Description of the diagnostic: https://www.viva64.com/en/w/V778/
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c61ffd676603bb14d4e815e1e249f816d4cbc74
Ionut Tamas [Fri, 24 Mar 2017 11:58:53 +0000 (13:58 +0200)]
Update ryujit-overview.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
02ae52f495edae9ec40fdee088524a922197ce72
Hyeongseok Oh [Fri, 24 Mar 2017 07:16:47 +0000 (16:16 +0900)]
Update ci-trigger-phrases.md (dotnet/coreclr#10444)
- Add Linux arm/x86 CI trigger phrases
- Add Ubuntu16.10 x64 pri0 trigger phrase
- Remove Ubuntu15.10 x64 pri0 trigger phrase
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1b0f8a1d353d41de515c4cc219339b220714777
Dan Moseley [Fri, 24 Mar 2017 06:47:38 +0000 (23:47 -0700)]
Add PNSE messages (dotnet/coreclr#10440)
* PNSE messages
* threading
* marshal
* interop svc
* More
* more
* Remove env var special casing for UWP
* Pending question
* remove pinvoke
Commit migrated from https://github.com/dotnet/coreclr/commit/
ad746a9b698c3cd5f603db8974a196dfcbc10267
Jan Kotas [Fri, 24 Mar 2017 04:02:52 +0000 (21:02 -0700)]
Merge pull request dotnet/coreclr#10426 from BruceForstall/FixIlasmRoundtrip
Enable FEATURE_METADATA_EMIT_ALL for non-crossgen compiles
Commit migrated from https://github.com/dotnet/coreclr/commit/
14b09e8777615f57fc1e78c0c7775962ee5b44a0
Sean Gillespie [Fri, 24 Mar 2017 01:40:56 +0000 (18:40 -0700)]
[Local GC] Redirect fatal errors to the EE (dotnet/coreclr#10436)
* [Local GC] Redirect fatal errors to the EE
* Address code review feedback: don't fetch the IP when reporting a fatal error
Commit migrated from https://github.com/dotnet/coreclr/commit/
b04644c55ae003bd1c6c8fefe33d5dfe6ef240f0
Maoni Stephens [Fri, 24 Mar 2017 01:24:55 +0000 (18:24 -0700)]
GetContainingObject is inconsistent with the lowest address it chooses. (dotnet/coreclr#10438)
For profiling purpose it only cares about condemned ranges; for byref
validation it cares about any object on the heap.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5bfdd98204d7cb265f633534d593ca9c008ca6b
Brian Sullivan [Fri, 24 Mar 2017 01:24:40 +0000 (18:24 -0700)]
Merge pull request dotnet/coreclr#10400 from briansull/ibc-counts
Change setBBProfileWeight so that we no longer multiply a profile counts by 100
Commit migrated from https://github.com/dotnet/coreclr/commit/
799473b93db0405bee78d5bbe2aadb23313efb01
Jan Kotas [Fri, 24 Mar 2017 00:39:59 +0000 (17:39 -0700)]
Merge pull request dotnet/coreclr#10434 from dotnet/mirror-merge-9060302
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
e6c2d88ef3ec9811f032087e710c3a7ef6181ffa
Alex Perovich [Thu, 23 Mar 2017 23:33:46 +0000 (18:33 -0500)]
Move StringBuilder to shared partition (dotnet/coreclr#10357)
* Move StringBuilder to shared partition
* Fix PR comments
* s/CoreClr/CoreCLR
* Remove unused ThreadSafeCopy overload
* Actually rename the file
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e2d938881cd9193614c245760ab49efaecb100c
Jan Kotas [Thu, 23 Mar 2017 18:55:26 +0000 (11:55 -0700)]
Delete NewMerger
This was only used as part of C++ link.exe for IJW
Commit migrated from https://github.com/dotnet/coreclr/commit/
5c8cb3f135289edba7d79d121e6861fd611e3404
Bruce Forstall [Thu, 23 Mar 2017 16:31:35 +0000 (09:31 -0700)]
Enable FEATURE_METADATA_EMIT_ALL for non-crossgen compiles
This allows ilasm roundtrip test to work with NetStandard 2.0
changes where C# compiler emits a ".permissionset" attribute
into the assembly that ildasm emits. This define enables the
APIs that ilasm uses to process this attribute.
Re-enable ilasm roundtrip test.
Fixes dotnet/coreclr#8418
Commit migrated from https://github.com/dotnet/coreclr/commit/
e4849aae67375a2dfbe73bf2bf94e4abc17464d4
Aditya Mandaleeka [Thu, 23 Mar 2017 22:14:48 +0000 (15:14 -0700)]
Merge pull request dotnet/coreclr#10417 from viva64/master
Missing comma
Commit migrated from https://github.com/dotnet/coreclr/commit/
c6ce2171adf92137e7f256200a8a46dc2337de33
Alex Perovich [Thu, 23 Mar 2017 22:08:35 +0000 (15:08 -0700)]
Add missing
Commit migrated from https://github.com/dotnet/coreclr/commit/
1060c55c8126085fe36628a814aad0d266907a8b
Alex Perovich [Thu, 23 Mar 2017 21:49:30 +0000 (14:49 -0700)]
Remove moved files
Commit migrated from https://github.com/dotnet/coreclr/commit/
c03502b1064f5df5126e0a5a4f28e9a03443c7ac
Maoni Stephens [Thu, 23 Mar 2017 21:37:47 +0000 (14:37 -0700)]
porting desktop changes to enable up to 1024 CPUs (dotnet/coreclr#10404)
porting desktop changes to enable up to 1024 CPUs
Commit migrated from https://github.com/dotnet/coreclr/commit/
41c47b8555d7d471547cfb641112cd31e37cb7ae
Atsushi Kanamori [Thu, 23 Mar 2017 13:54:08 +0000 (06:54 -0700)]
Move IReflect.cs to shared partition. (dotnet/coreclr#3074)
Split AssemblyAttributes.cs into properly named files.
Commit migrated from https://github.com/dotnet/coreclr/commit/
08f09d185cdd213ef60702f9d9be1a2a7a123ad8
Atsushi Kanamori [Wed, 22 Mar 2017 18:16:35 +0000 (11:16 -0700)]
Move the easy files in System\Reflection to the shared partition. (dotnet/coreclr#3060)
* Prepare the "easy" System\Reflection .cs files for move to shared partition
Files to be moved the shared partition (after https://github.com/dotnet/coreclr/pull/10387 side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
* Prepare the "easy" System\Reflection .cs files for move to shared partition
Files to be moved the shared partition (after https://github.com/dotnet/coreclr/pull/10387 side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
* Move to shared.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd6048c74e97caf3c46429992854074ecaccecf7
Noah Falk [Thu, 23 Mar 2017 20:21:48 +0000 (13:21 -0700)]
Merge pull request dotnet/coreclr#10336 from noahfalk/wer_resource
Support Windows Minidump
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6fe0910c7dd3aabc469623102d0771ddb47ace0
Steve MacLean [Thu, 23 Mar 2017 20:05:55 +0000 (16:05 -0400)]
Mark b425314 Incompatible (dotnet/coreclr#10431)
b425314 has internal logic to determine if it making forward progress
If test takes too long, test self check fails and test aborts with a
failure. This makes this test difficult in GCStress/HeapVerify situations
where run time is substantially longer.
This test was already marked incompatible for x86. Remove x86 condition
to mark incompatible on al platforms.
Commit migrated from https://github.com/dotnet/coreclr/commit/
713ca23d1888e4122fc9bbfa8251e999697d1855
Andy Ayers [Thu, 23 Mar 2017 20:03:07 +0000 (13:03 -0700)]
Merge pull request dotnet/coreclr#10432 from AndyAyersMS/ImproveTypes3
Jit: track ref types for inlinee locals and args
Commit migrated from https://github.com/dotnet/coreclr/commit/
e3510e183f1858b9cc6d89947d1e54fdc8c3b65d
dotnet bot [Thu, 23 Mar 2017 19:34:59 +0000 (12:34 -0700)]
Update CoreClr to beta-25123-07 (dotnet/coreclr#10428)
Commit migrated from https://github.com/dotnet/coreclr/commit/
77e183000b7fbe33531cf9e3dbacb8f74b481c90
chcosta [Thu, 23 Mar 2017 18:56:52 +0000 (11:56 -0700)]
Use roslyn common props (dotnet/coreclr#10430)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1976320a1a56afb23f3049fb91d93a85cb4fb1d4
Jonghyun Park [Thu, 23 Mar 2017 18:51:13 +0000 (03:51 +0900)]
[PAL] Do NOT check execute bit in INIT_FindEXEPath (dotnet/coreclr#10342)
* Do NOT check execute bit in INIT_FindEXEPath
* Do NOT lookup path during PAL_Initialize
This commmit removes path lookup inside INIT_FindEXEPath, and renames
INIT_FindEXEPath as INIT_EXEPath.
Commit migrated from https://github.com/dotnet/coreclr/commit/
63319760a8ae80a397fd7fdc80bbb64cebab310e
Atsushi Kanamori [Thu, 23 Mar 2017 18:49:42 +0000 (11:49 -0700)]
Migrate the Reflection serialization holders to the shared partition. (dotnet/coreclr#10429)
* String => string, SR.GetResourceString() => SR.
* Copy over CoreRT files verbatim.
* Get things building and running again.
* Don't bring CoreRT's visibility sins into CoreCLR
* String => string, Object => object
* De-"m_" the field names.
* Move the files to the shared directory.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b9b922e7a4197e478adb354189eab508a475410
Rahul Kumar [Thu, 23 Mar 2017 18:35:12 +0000 (11:35 -0700)]
Merge pull request dotnet/coreclr#10411 from rahku/fix10197
Re-enable tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
af0eb06dd6f5f27067371d0141199704f1d2f778
Brian Sullivan [Thu, 23 Mar 2017 18:30:05 +0000 (11:30 -0700)]
Merge pull request dotnet/coreclr#10397 from briansull/ibc-dump
Improve the dumping of BasicBlock weights and edge counts in the JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
abe18069c56aec42b5d8bfa83c322994f232c7ee
Bruce Forstall [Thu, 23 Mar 2017 17:57:49 +0000 (10:57 -0700)]
Merge pull request dotnet/coreclr#10402 from BruceForstall/FixMulCseBug
Fix CSE bug with GT_MUL and GTF_MUL_64RSLT
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6c36706c174e0cbd280dca5ec0a829171aaafe0
Andy Ayers [Mon, 20 Mar 2017 18:12:05 +0000 (11:12 -0700)]
Jit: track ref types for inlinee locals and args
The jit may use new temporaries for inline locals and args. For temps
representing ref type locals and args, propagate the class handle from
the appropriate signature. This makes more types to be available for
devirtualization.
Also in addition to capturing arg ref types, cleanup `impInlineFetchArg`
by commoning out the table lookups and adding a header comment.
Commit migrated from https://github.com/dotnet/coreclr/commit/
22668cc8a71140f8c8fa467e70d735cb0a00035e
Steve MacLean [Thu, 23 Mar 2017 17:38:50 +0000 (13:38 -0400)]
[Unix] runtest.sh crossgen should exit on failure (dotnet/coreclr#9907)
* Fix crossgen segfault
* Check crossgen in runtests.sh
* Do not use test -v
CI showed bash 4.2 feature test -v is not present on
OSX CI systems. Fall back to more standard bash test
Commit migrated from https://github.com/dotnet/coreclr/commit/
087a2eeb4c1384113fe68da1257b98fa99bd0484
Ilya Ivanov [Thu, 23 Mar 2017 14:46:08 +0000 (17:46 +0300)]
We have found and fixed a security weakness (CWE-188) using PVS-Studio tool: Analyzer warning: V557 Array overrun is possible. The value of 'dwCode - 1' index could reach 8.
PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/
Commit migrated from https://github.com/dotnet/coreclr/commit/
baaff75f0c3c1f8439c201afe33eafd964e4475d
Joseph Tremoulet [Mon, 13 Mar 2017 18:49:16 +0000 (11:49 -0700)]
Scalarize single-field-to-lclVar block copy
Morph has some logic to scalarize struct copies where the RHS is a scalar
and the LHS is a single-field struct. This change adds the symmetric
logic where the LHS is a scalar and the RHS is a single-field struct.
This pattern shows up in Span<T> methods that initialize the data pointer
field, due to the way scalar replacement operates on spans.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9fbca32b572413dcccfe0314766edaed9c8934a
Atsushi Kanamori [Thu, 23 Mar 2017 14:02:28 +0000 (07:02 -0700)]
Move IReflect.cs to shared partition. (dotnet/coreclr#10415)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f485224cd9a5899e5f8e991f2db87cef5566b1b
Ilya [Thu, 23 Mar 2017 13:58:18 +0000 (16:58 +0300)]
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://viva64.com/en/examples/v534/ (dotnet/coreclr#10414)
Incorrect variable 'i' from the outer loop is used in condition of the inner loop.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5bcd08108f522524741805d97989e5f227a6bd6b
Stephen Toub [Thu, 23 Mar 2017 13:41:12 +0000 (09:41 -0400)]
Merge pull request dotnet/coreclr#10412 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25123-03, beta-25122-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0bafd7833fc46378971398db518de4f6aa4f8cb
ragmani [Thu, 23 Mar 2017 09:09:09 +0000 (18:09 +0900)]
[x86/Linux] fix broken stack in DelayLoad_Helper when converting to AT&T syntax assembly. (dotnet/coreclr#10383)
* fix broken stack in DelayLoad_Helper when converting to AT&T syntax assembly.
"push \frameFlags" was changed to "pushw $0x0" by converting to AT&T syntax assembly.
Signed-off-by: ragmani <ragmani0216@gmail.com>
* [x86/Linux] modify pushing frameFlags stack from Intel syntax to AT&T syntax.
Signed-off-by: ragmani <ragmani0216@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
9784b493f3c85dd0967e8c2d936416e625f9cd0f
dotnet-bot [Thu, 23 Mar 2017 08:57:36 +0000 (08:57 +0000)]
Update CoreClr, CoreFx to beta-25123-03, beta-25122-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
400ae726d96e408016e4459a4a002e44d2165cc0
Rahul Kumar [Thu, 23 Mar 2017 08:13:54 +0000 (01:13 -0700)]
Merge pull request dotnet/coreclr#10064 from rahku/cgroup
memory limit in containers on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
b511095cb37ce2e363ab55740960e7f610a9220d
Rahul Kumar [Thu, 23 Mar 2017 07:51:55 +0000 (00:51 -0700)]
Re-enable tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
8bdf8c50e641d1f838f62f7bfae2863cd7f6e395
rahul [Thu, 9 Mar 2017 02:55:24 +0000 (18:55 -0800)]
memory limit in containers on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2b4ea22fcf71ef61ff84aa9669da2419c7541a5
Gaurav Khanna [Thu, 23 Mar 2017 06:25:57 +0000 (23:25 -0700)]
Various fixes for generating portable RID packages (dotnet/coreclr#10409)
Commit migrated from https://github.com/dotnet/coreclr/commit/
90f74b3963073c3671da1b4b95a6c205b7fa0411
Luis G [Thu, 23 Mar 2017 05:51:45 +0000 (02:51 -0300)]
Add handling of multiple CMake installations in probe-win (dotnet/coreclr#9980)
* Add handling of multiple CMake installations in probe-win
Check if multiple CMake versions are installed, and use by default the first path available
Fixes dotnet/coreclr#8221
* Fix typo in value accessor
* Restore previous null check in probe_win
* Remove redundant assignment
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c73fd9440a68f064f4767347a4401155ee88899
Tanner Gooding [Thu, 23 Mar 2017 05:44:40 +0000 (22:44 -0700)]
Removing the special handling in classlibnative for atan2(±∞, ±∞) and pow(-1.0, ±∞). (dotnet/coreclr#10295)
* Removing the special handling in classlibnative for atan2(±∞, ±∞) and pow(-1.0, ±∞).
* Fixing up the logic for HAVE_COMPATIBLE_POW in the PAL layer.
Commit migrated from https://github.com/dotnet/coreclr/commit/
72c57d9d9fd2d4cd8c96f124d132d316c8ef6013
Jan Kotas [Thu, 23 Mar 2017 05:43:36 +0000 (22:43 -0700)]
Fix fallout from switching corelib to use resx (dotnet/coreclr#10407)
Fixes #https://github.com/dotnet/corefx/issues/17413
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab0fbce6b629d081c1102d353abab0d8febd4487
Gaurav Khanna [Thu, 23 Mar 2017 04:35:24 +0000 (21:35 -0700)]
Unify command line arg for portable RID build (dotnet/coreclr#10408)
Commit migrated from https://github.com/dotnet/coreclr/commit/
14792ccacd1209380ba642431fe22f703b9f4060
Jon Hanna [Thu, 23 Mar 2017 04:25:58 +0000 (04:25 +0000)]
Named Multiply and Divide methods on TimeSpan (dotnet/coreclr#10366)
dotnet/corefxdotnet/coreclr#16476
Commit migrated from https://github.com/dotnet/coreclr/commit/
741ce0d615bdae442cb3ee184a5a36b30d1a152a
Swaroop Sridhar [Wed, 22 Mar 2017 22:22:46 +0000 (15:22 -0700)]
Add reflect.xml for a abstract* tests
For the abstract* tests in question:
The tests check for TypeLoad exception from a derived class that doesn't implement an abstract method in base class.
However, the Linker removed the abstract method from base, so there is no exception.
Therefore, add reflect.xml to override the linker's behavior and enable testing for TypeLoadException.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f36d5b00cadd97983a917f130fd7da875e6f2c83
Swaroop Sridhar [Wed, 22 Mar 2017 22:22:04 +0000 (15:22 -0700)]
Exclude some tests from Linker testing.
Exclude some tests while testing via ILLINK.
The reasons are mentioned in issues.targets.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ba4f04e851174f96b3049eb5277d111669c59ac
Swaroop Sridhar [Mon, 20 Mar 2017 18:20:12 +0000 (11:20 -0700)]
Linker Testing: Use a central target for copying reflection roots.
Copy the test.refect.xml file (if one exists) as part of the
AfterBuild job -- so that individual tests need not identify
the CopyReflectionRoots explicitly as a default target.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d532bfced676ac0e3051d2468ad01f793ab2fb84
Drew Scoggins [Thu, 23 Mar 2017 00:21:13 +0000 (17:21 -0700)]
Merge pull request dotnet/coreclr#9947 from DrewScoggins/xunitApi
Update CoreCLR to use xunit perf api
Commit migrated from https://github.com/dotnet/coreclr/commit/
69ad56379c0612489ec9467f7216501bd448b881
Sean Gillespie [Wed, 22 Mar 2017 23:39:14 +0000 (16:39 -0700)]
Opt-out of GC Stress for FEATURE_STANDALONE_GC (dotnet/coreclr#10391)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecdf277ce50f29cccb494157cdbbfda86517feac
Bruce Forstall [Wed, 22 Mar 2017 23:36:53 +0000 (16:36 -0700)]
Jump stubs (dotnet/coreclr#10398)
Add document on CLR Jump Stubs
Commit migrated from https://github.com/dotnet/coreclr/commit/
56d550d4f8aec2dd40b72a182205d0a2463a1bc9
Bruce Forstall [Wed, 22 Mar 2017 23:21:04 +0000 (16:21 -0700)]
Fix CSE bug with GT_MUL and GTF_MUL_64RSLT
Unconditionally set op1 and op2 as GTF_DONT_CSE.
Previously, this was only done if the cast was not
a GT_NOP. It is possible for it already to come in
as GT_NOP, thus leading to the possibility to CSE
the operand, and leading to this assert firing:
```
assert(tree->gtIsValid64RsltMul());
```
Commit migrated from https://github.com/dotnet/coreclr/commit/
f401bfc49f96c12d90ec63bd4d4ef74d0cd998e6
Atsushi Kanamori [Wed, 22 Mar 2017 22:28:14 +0000 (15:28 -0700)]
Move Type.IsSerializable and Type.DefaultBinder to shared file. (dotnet/coreclr#10395)
This will pave the way for the mirrorbot to fix
https://github.com/dotnet/corert/issues/3061.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f10955c88f0f82bb3eae7966390979f49dcb47ae
Jonghyun Park [Wed, 22 Mar 2017 22:25:19 +0000 (07:25 +0900)]
[x86/Linux] 16-byte aligned TheUMEntryPrestub (dotnet/coreclr#10376)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e79eb43b9ce606a10a8815e4858b377fa94c979
Brian Sullivan [Wed, 22 Mar 2017 21:53:51 +0000 (14:53 -0700)]
Change setBBProfileWeight so that we no longer multiply the profile count by 100
Fix fgAddSyncMethodEnterExit to properly set the IBC profile weight when we have profile data
In fgComputeEdgeWeights properly set fgCalledCount when we inserted a new first block using fgFirstBBisScratch
Fix fgOptimizeUncondBranchToSimpleCond to properly set the new BasicBlock's weight and flags
Commit migrated from https://github.com/dotnet/coreclr/commit/
753dbbb780fc215413e61dfd6adcf2786505cd54
Brian Sullivan [Wed, 22 Mar 2017 18:23:19 +0000 (11:23 -0700)]
Improve the dumping of BasicBlock weights and edge counts in the JIT
Weights are now printed to fit into a 6 character field in one of three forms:
standard (ddd or ddd.dd), large (ddddd.) or very large (dddddk)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3dd1518ca4e71e290e914becfa9ebcfd9a27042a
Gaurav Khanna [Wed, 22 Mar 2017 20:54:41 +0000 (13:54 -0700)]
Switch tests to use OSX.10.12 RID (dotnet/coreclr#10394)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecf644fd125a7fd4699c346d44dff4edb9b578e1
Gaurav Khanna [Wed, 22 Mar 2017 20:30:49 +0000 (13:30 -0700)]
Enable Portable Windows RID (dotnet/coreclr#10365)
* Enable Portable RID support for Windows and OSX.
Commit migrated from https://github.com/dotnet/coreclr/commit/
da1d8cd17a8ec2a78e8139d03be358d26acb503c
Drew Scoggins [Tue, 21 Mar 2017 21:01:03 +0000 (14:01 -0700)]
Add updated timeout
Commit migrated from https://github.com/dotnet/coreclr/commit/
5d362a30a372849f5cf7ac3a283dab40c146e19b
Drew Scoggins [Fri, 3 Mar 2017 22:51:37 +0000 (14:51 -0800)]
Update CoreCLR to use xunit perf api
This updates the CoreCLR performance runs to use the new xunit
performance api. This will unblock several people who were wanting to
move tests forward from netstandard1.4 which is were we have been locked
because of using the old desktop runner.
Commit migrated from https://github.com/dotnet/coreclr/commit/
02749bf56c408d62e2687a8f208b8b2e674df7eb
Atsushi Kanamori [Wed, 22 Mar 2017 17:51:46 +0000 (10:51 -0700)]
Reconcile the "easy" System\Reflection .cs files with their CoreRT versions. (dotnet/coreclr#10387)
Files to be moved the shared partition (after CoreRT side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e970d8c53b4750c46ea00ea4c044af57e6b53df
Hyeongseok Oh [Wed, 22 Mar 2017 17:32:11 +0000 (02:32 +0900)]
Change default CI job for ARM and clean-up (dotnet/coreclr#10370)
- Change ARM CI job triggered by PR: ubuntu16.04 debug, ubuntu release, tizen debug/release
- Clean-up: remove emulator build/test
- Change ubuntu16.04 x64 default job name and trigger phrase: conflict triggerring with arm
Commit migrated from https://github.com/dotnet/coreclr/commit/
b94328c2428ce27aa4b813faf6c4a2ebd25822f1
Sean Gillespie [Wed, 22 Mar 2017 17:25:08 +0000 (10:25 -0700)]
Fix an issue where GCStress allocated objects using the Gen 0 alloc context (dotnet/coreclr#10322)
* Fix an issue where GCStress allocated objects using the Gen 0 alloc context
* Remove a GCStress MaybeTrigger on LOH allocations that attempted to use the gen 0 alloc context
Commit migrated from https://github.com/dotnet/coreclr/commit/
992d37064fa76ea7633734607381545e228806a5
Andy Ayers [Wed, 22 Mar 2017 17:23:56 +0000 (10:23 -0700)]
Merge pull request dotnet/coreclr#10371 from AndyAyersMS/FixDevirt
Fix several devirtualization issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
c2ba64de40e5e28c56b9734521c5f6ead20bdea9
Gaurav Khanna [Wed, 22 Mar 2017 15:55:53 +0000 (08:55 -0700)]
Move OSX packages to use 10.12 as the RID (dotnet/coreclr#10354)
Commit migrated from https://github.com/dotnet/coreclr/commit/
66384321b7fb53a57163e3d895407800a37ca44e
Jan Kotas [Wed, 22 Mar 2017 15:03:09 +0000 (08:03 -0700)]
Merge pull request dotnet/coreclr#10374 from dotnet/mirror-merge-9057970
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
0976a5d3383e0aaed8895b09af9b12db4392df91
Atsushi Kanamori [Wed, 22 Mar 2017 11:37:12 +0000 (04:37 -0700)]
Move DefaultBinder.cs to the shared partition. (dotnet/coreclr#10355)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d10eede76ecf94ec63b51d94dadf1e1c5b339c71
Jeremy Kuhne [Tue, 21 Mar 2017 23:07:53 +0000 (16:07 -0700)]
FileStream redirection got changed. Add ThreadPoolBoundHandle redirect.
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=398142&_a=edit
[tfs-changeset: 1651640]
Commit migrated from https://github.com/dotnet/coreclr/commit/
37eeb4ca174c25396949dcbada8698a7827c0d7e
Stephen Toub [Wed, 22 Mar 2017 06:09:22 +0000 (02:09 -0400)]
Fix leak in Task.WaitAny(..., int) (dotnet/coreclr#10331)
WaitAny is effectively built on top of WhenAny, creating a continuation from the supplied tasks and then blocking on that continuation. When a timeout is provided, it blocks with that timeout. But if it doesn't complete within the timeout, it ends up leaking the continuations it created into the constituent tasks. The fix is simply to force the returned continuation to complete, such that its continuation logic does all of the appropriate cleanup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6e9a08a70dab11ddc845fb0ccf36aa436e9ebec
dotnet bot [Wed, 22 Mar 2017 05:04:42 +0000 (22:04 -0700)]
Update CoreClr, CoreFx to beta-25121-02, beta-25122-01, respectively (dotnet/coreclr#10310)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8390d5464b2f0f0ce360fc8b92869bfe8ad5d172
Alex Perovich [Wed, 22 Mar 2017 05:02:47 +0000 (00:02 -0500)]
Switch coreclr corelib to use resx (dotnet/coreclr#10372)
* Revert "Revert "Switch coreclr corelib to use resx (dotnet/coreclr#10268)""
* Add resources.target override
This fixes the GenerateResource task running on the arm emulator runs.
* Fix run.sh to have a working Tools-Override
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdff8b0babe5d82737058ccdae8b14d8ae90160d
Sean Gillespie [Wed, 22 Mar 2017 05:00:12 +0000 (22:00 -0700)]
[Local GC] Forbid inclusion of gcscan.h from VM and DAC directories (dotnet/coreclr#10332)
* Forbid inclusion of gcscan.h from VM and DAC directories
* Address code review feedback - hoist IsGCHeapInitialized check to an assert, since the heap should definitely be initialized if we are validating objects that ostensibly came from it
Commit migrated from https://github.com/dotnet/coreclr/commit/
d5906ff3e0d0f864c1432f1f39d586ca3d79fbb6