Daniel Stenberg [Tue, 22 Feb 2011 12:28:27 +0000 (13:28 +0100)]
runtests.pl/stopserver: space separate pids
The stopserver function would append pids to kill and could append them
without separating them with space properly. The result would be a very
large number that by (some implementations of) kill would be interpreted
as a negative number and that process group would be wiped...
Bug: http://curl.haxx.se/bug/view.cgi?id=3188836
Reported by: Greg Pratt
Kamil Dudka [Tue, 22 Feb 2011 12:13:53 +0000 (13:13 +0100)]
nss: do not ignore failure of SSL handshake
Flaw introduced in fc77790 and present in curl-7.21.4.
Bug: https://bugzilla.redhat.com/669702#c16
Daniel Stenberg [Mon, 21 Feb 2011 12:51:26 +0000 (13:51 +0100)]
CURLOPT_SSH_KEYFUNCTION: requires *SSH_KNOWNHOSTS
Extend the docs to clarify that CURLOPT_SSH_KEYFUNCTION is only called
if the known hosts option is also correctly set!
Julien Chaffraix [Mon, 21 Feb 2011 05:13:19 +0000 (21:13 -0800)]
curl_easy_setopt.3: Removed wrong reference to CURLOPT_USERPASSWORD.
CURLOPT_HTTPAUTH was mentioning CURLOPT_USERPASSWORD instead of
CURLOPT_PASSWORD.
Reported by: Mike Henshaw
Julien Chaffraix [Mon, 21 Feb 2011 05:10:45 +0000 (21:10 -0800)]
netrc: Removed _NETRC_DEBUG code.
This is not needed anymore as we have unit testing running on it.
Julien Chaffraix [Mon, 21 Feb 2011 05:10:36 +0000 (21:10 -0800)]
tests: Cleaned up netrc testing.
Removed the "netrc_debug" keyword replaced with --netrc-file additions.
Removed the debug code from Curl_parsenetrc as it is superseeded by
--netrc-file.
Julien Chaffraix [Mon, 21 Feb 2011 05:10:03 +0000 (21:10 -0800)]
curl: Added --netrc-file.
This enables people to specify a path to the netrc file to use.
The new option override --netrc if both are present. However it
does follow --netrc-optional if specified.
Mike Crowe [Fri, 18 Feb 2011 22:19:14 +0000 (23:19 +0100)]
multi: close connection on timeout
After a request times out, the connection wasn't properly closed and
prevented to get re-used, so subsequent transfers could still mistakenly
get to use the previously aborted connection.
Daniel Stenberg [Thu, 17 Feb 2011 22:51:43 +0000 (23:51 +0100)]
multi: better failed connect treatment
When failing to connect the protocol during the CURLM_STATE_PROTOCONNECT
state, Curl_done() has to be called with the premature flag set TRUE as
for the pingpong protocols this can be important.
When Curl_done() is called with premature == TRUE, it needs to call
Curl_disconnect() with its 'dead_connection' argument set to TRUE as
well so that any protocol handler's disconnect function won't attempt to
use the (control) connection for anything.
This problem caused the pingpong protocols to fail to disconnect when
STARTTLS failed.
Reported by: Alona Rossen
Bug: http://curl.haxx.se/mail/lib-2011-02/0195.html
Hoi-Ho Chan [Fri, 18 Feb 2011 05:46:59 +0000 (21:46 -0800)]
PolarSSL: Return 0 on receiving TLS CLOSE_NOTIFY alert
Signed-off-by: Hoi-Ho Chan <hoiho.chan@gmail.com>
Daniel Stenberg [Thu, 17 Feb 2011 22:22:11 +0000 (23:22 +0100)]
symbols-in-versions: sorted
I forgot to sort it when I added the CURL_SOCKOPT_* symbols
Daniel Stenberg [Thu, 17 Feb 2011 22:03:34 +0000 (23:03 +0100)]
TODO-RELEASE: refresh
Daniel Stenberg [Thu, 17 Feb 2011 21:34:18 +0000 (22:34 +0100)]
SOCKOPTFUNCTION: documented new return codes
Daniel Stenberg [Wed, 9 Feb 2011 14:46:41 +0000 (15:46 +0100)]
SOCKOPTFUNCTION: callback can say already-connected
Introducing a few CURL_SOCKOPT* defines for conveniance. The new
CURL_SOCKOPT_ALREADY_CONNECTED signals to libcurl that the socket is to
be treated as already connected and thus it will skip the connect()
call.
Kamil Dudka [Thu, 17 Feb 2011 16:37:24 +0000 (17:37 +0100)]
nss: avoid memory leak on SSL connection failure
Daniel Stenberg [Thu, 17 Feb 2011 13:00:25 +0000 (14:00 +0100)]
RELEASE-NOTES: fresh start towards 7.21.5
Daniel Stenberg [Thu, 17 Feb 2011 12:59:27 +0000 (13:59 +0100)]
curlver.h: bump to 7.21.5
Daniel Stenberg [Thu, 17 Feb 2011 12:58:24 +0000 (13:58 +0100)]
THANKS: add contributors from 7.21.4
Guenter Knauf [Thu, 17 Feb 2011 10:46:41 +0000 (11:46 +0100)]
Set -fpcc-struct-return only for gcc compiler.
Daniel Stenberg [Thu, 17 Feb 2011 08:40:53 +0000 (09:40 +0100)]
RELEASE-NOTES: credits since 7.21.3
I went through all the names mentioned as authors and in commit messages
since 7.21.3, and this list inserted now is sorted on first name.
Daniel Stenberg [Wed, 16 Feb 2011 18:33:22 +0000 (19:33 +0100)]
nss_load_key: fix unused variable warning
Daniel Stenberg [Mon, 14 Feb 2011 12:42:01 +0000 (13:42 +0100)]
gmtime: remove define
It turns out some systems rely on the gmtime or gmtime_r to be defined
already in the system headers and thus my "precaution" redefining of
them only caused trouble. They are now removed.
Guenter Knauf [Sun, 13 Feb 2011 13:31:22 +0000 (14:31 +0100)]
Added -m32 to CFLAGS to compile with x86_64 gcc.
Guenter Knauf [Sun, 13 Feb 2011 11:13:21 +0000 (12:13 +0100)]
Updated OpenSSL version, added links to docu.
Daniel Stenberg [Thu, 10 Feb 2011 21:33:12 +0000 (22:33 +0100)]
RELEASE-NOTES: synced with
3bb1291fbd4
Daniel Stenberg [Thu, 10 Feb 2011 21:21:57 +0000 (22:21 +0100)]
--keepalive-time: warn if not supported properly
Since the feature requires support for TCP_KEEPIDLE and TCP_KEEPINTVL to
function as documented, it now warns if that support is missing when the
option is used.
Dan Fandrich [Thu, 10 Feb 2011 20:29:34 +0000 (12:29 -0800)]
Call ERR_peek_error instead of ERR_peek_last_error
The latter isn't available in older OpenSSL versions, and is
less useful since it returns the most recent error instead of
the first one encountered.
Julien Chaffraix [Tue, 8 Feb 2011 16:39:44 +0000 (08:39 -0800)]
netrc: Enable setting up the filename in unit tests.
Unset the environment variable so that we can specify different
filenames in the unit test.
Julien Chaffraix [Tue, 8 Feb 2011 06:12:37 +0000 (22:12 -0800)]
test1304: Added some unit tests for Curl_parsenetrc.
Moved some definitons into the header file so that we can reuse them.
Quinn Slack [Wed, 9 Feb 2011 22:34:30 +0000 (23:34 +0100)]
CURLE_TLSAUTH_FAILED: removed
On second thought, I think CURLE_TLSAUTH_FAILED should be eliminated. It
was only being raised when an internal error occurred while allocating
or setting the GnuTLS SRP client credentials struct. For TLS
authentication failures, the general CURLE_SSL_CONNECT_ERROR seems
appropriate; its error string already includes "passwords" as a possible
cause. Having a separate TLS auth error code might also cause people to
think that a TLS auth failure means the wrong username or password was
entered, when it could also be a sign of a man-in-the-middle attack.
Quinn Slack [Wed, 9 Feb 2011 22:33:06 +0000 (23:33 +0100)]
TLS-SRP: new options documented
Daniel Stenberg [Wed, 9 Feb 2011 14:36:36 +0000 (15:36 +0100)]
CURLOPT_SOCKOPTFUNCTION: return proper error code
When the callback returns an error, this function must make sure to return
CURLE_ABORTED_BY_CALLBACK properly and not CURLE_OK as before to allow the
callback to properly abort the operation.
Daniel Stenberg [Tue, 8 Feb 2011 21:39:04 +0000 (22:39 +0100)]
curl.1: typo in -v description
Reported by: Ian D Allen
Bug: https://bugs.launchpad.net/ubuntu/+source/curl/+bug/714895
Forwarded to us by:
Reported by: Andreas Olsson
Bug: http://curl.haxx.se/bug/view.cgi?id=3175422
Julien Chaffraix [Fri, 28 Jan 2011 16:34:17 +0000 (08:34 -0800)]
netrc: Removed dead code.
The main has not been updated from some time and is out of sync with
the code. The code is now tested by several test cases so no need for
a seperate code path.
Julien Chaffraix [Fri, 28 Jan 2011 16:20:37 +0000 (08:20 -0800)]
netrc: Tightened up the type checks.
The state should not be anonymous so that we can check if the values
are fine. Added 2 unreachables states to the switch as a result of this
change.
Julien Chaffraix [Thu, 27 Jan 2011 15:48:19 +0000 (07:48 -0800)]
imap: Fixed typo in a comment.
Daniel Stenberg [Mon, 7 Feb 2011 14:09:24 +0000 (15:09 +0100)]
Curl_gmtime: avoid future mistakes
Document Curl_gmtime() and define away the old functions so that they
won't be used internally again by mistake.
Daniel Stenberg [Mon, 7 Feb 2011 14:00:48 +0000 (15:00 +0100)]
Curl_gmtime: added a portable gmtime
Instead of polluting many places with #ifdefs, we create a single place
for this function, and also check return code properly so that a NULL
pointer returned won't cause problems.
Guenter Knauf [Thu, 3 Feb 2011 08:59:00 +0000 (09:59 +0100)]
mk-ca-bundle.vbs: use new cacert url
The official Mozilla page at http://www.mozilla.org/projects/security/certs/
points out a new place as the "proper" place to get Mozilla's CA certs from
so this script is now updated to use that instead.
Reported by: Daniel Mentz
Daniel Stenberg [Wed, 2 Feb 2011 21:22:15 +0000 (22:22 +0100)]
mk-ca-bundle.pl: use new cacert url
The official Mozilla page at
http://www.mozilla.org/projects/security/certs/ points out a new place
as the "proper" place to get Mozilla's CA certs from so this script is
now updated to use that instead.
Reported by: Daniel Mentz
Bjoern Sikora [Wed, 2 Feb 2011 17:25:57 +0000 (18:25 +0100)]
ssluse: improved error message on SSL_CTX_new failures
"SSL: couldn't create a context" really isn't that helpful, now it'll
also extract an explanation from OpenSSL and append to the right.
Nicholas Maniscalco [Wed, 2 Feb 2011 12:41:22 +0000 (13:41 +0100)]
multi: fix CURLM_STATE_TOOFAST for multi_socket
The code in the toofast state needs to first recalculate the values
before it uses them again since it may have been a while since it last
did it when it reaches this point.
Daniel Stenberg [Wed, 2 Feb 2011 12:35:55 +0000 (13:35 +0100)]
unit1300: code style cleanup
Amr Shahin [Sat, 29 Jan 2011 15:33:02 +0000 (17:33 +0200)]
adding unit tests for Curl_llist_remove
Patrick Monnerat [Mon, 31 Jan 2011 16:07:18 +0000 (17:07 +0100)]
Include TLSAUTH options in ILE/RPG binding.
Dave Reisner [Sun, 30 Jan 2011 03:41:07 +0000 (22:41 -0500)]
file: add support for CURLOPT_TIMECONDITION
Dave Reisner [Sun, 30 Jan 2011 03:12:33 +0000 (22:12 -0500)]
transfer: add Curl_meets_timecondition()
This will be used by file_do() and Curl_readwrite() as a unified method
of checking to see if a remote document meets the supplied
CURLOPT_TIMEVAL and CURLOPT_TIMECONDITION.
Signed-off-by: Dave Reisner <d@falconindy.com>
Daniel Stenberg [Sat, 29 Jan 2011 22:52:40 +0000 (23:52 +0100)]
FAQ: clarified/expanded 6.7 a bit
"6.7 What are my obligations when using libcurl in my commercial apps?"
got the piece about what exactly "in all copies" mean to a user of the
code.
This interpretation is based on what other MIT-like licenses have made
more explicit.
Daniel Stenberg [Sat, 29 Jan 2011 22:41:15 +0000 (23:41 +0100)]
COPYING: update the year to 2011
The generic copyright year range now includes 2011
Pierre Joye [Fri, 28 Jan 2011 21:19:44 +0000 (22:19 +0100)]
Windows build: alternative makefile
This is a separate makefile for MSVC builds. It is deliberately put in
another dir than src/ and lib/ to allow a different build experience
than the previous - at least during a period. Eventually we should
unify.
Daniel Stenberg [Thu, 27 Jan 2011 23:23:48 +0000 (00:23 +0100)]
test: add test 580 to the dist
Dan Fandrich [Thu, 27 Jan 2011 22:37:16 +0000 (14:37 -0800)]
Some minor edits including updates to function names
Daniel Stenberg [Thu, 27 Jan 2011 13:37:25 +0000 (14:37 +0100)]
ares: memory leak fix
The double name resolve trick used with c-ares could leave allocated
memory in 'temp_ai' if the operation was aborted in the middle.
Daniel Stenberg [Thu, 27 Jan 2011 12:59:11 +0000 (13:59 +0100)]
ares_query_completed_cb: don't touch invalid data
When this callback is called due to the destruction of the ares handle,
the connection pointer passed in as an argument may no longer pointing
to valid data and this function doesn't need to do anything with it
anyway so we make sure it doesn't.
Bug: http://curl.haxx.se/mail/lib-2011-01/0333.html
Reported by: Vsevolod Novikov
Kamil Dudka [Thu, 27 Jan 2011 09:55:02 +0000 (10:55 +0100)]
nss: avoid memory leaks and failure of NSS shutdown
... in case more than one CA is loaded.
Bug: https://bugzilla.redhat.com/670802
Dan Fandrich [Thu, 27 Jan 2011 01:02:33 +0000 (17:02 -0800)]
Mention that sftp quote commands can be quoted
Daniel Stenberg [Tue, 25 Jan 2011 17:09:54 +0000 (18:09 +0100)]
tests: more multiple headers checks
Daniel Stenberg [Tue, 25 Jan 2011 11:06:50 +0000 (12:06 +0100)]
HTTP: memory leak on multiple Location:
The HTTP parser allocated memory on each received Location: header
without properly freeing old data. Starting now, the code only considers
the first Location: header and will blissfully ignore subsequent ones.
Bug: http://curl.haxx.se/bug/view.cgi?id=3165129
Reported by: Martin Lemke
Daniel Stenberg [Mon, 24 Jan 2011 21:18:43 +0000 (22:18 +0100)]
FAQ: clarify 5.13 how to stop a transfer
Guenter Knauf [Sat, 22 Jan 2011 08:52:09 +0000 (09:52 +0100)]
Fixed C++ style comment not allowed in ISO C90.
Dan Fandrich [Fri, 21 Jan 2011 22:27:10 +0000 (14:27 -0800)]
Mention axTLS in some more documentation
Daniel Stenberg [Thu, 20 Jan 2011 22:17:22 +0000 (23:17 +0100)]
runtests.pl: make -s not show skipped tests
Amr Shahin [Tue, 18 Jan 2011 22:39:47 +0000 (00:39 +0200)]
unittest: add 3 tests to test1300
Testing Curl_llist_insert_next
Darshan Mody [Thu, 20 Jan 2011 20:11:22 +0000 (12:11 -0800)]
Fixed compile using OpenSSL versions < 0.9.4a
Daniel Stenberg [Wed, 19 Jan 2011 22:14:55 +0000 (23:14 +0100)]
main: make the tlsauth options always present
... to not make the connection between the tool and the libcurl used
tighter than necessary, the tlsauth options are now always present but
if the used libcurl doesn't have TLSAUTH support it will return failure.
Also, replaced strncmp() with strequal to get case insensitive matching.
Daniel Stenberg [Wed, 19 Jan 2011 21:45:02 +0000 (22:45 +0100)]
symbols-in-versions: add the new TLSAUTH-SRP symbols
Daniel Stenberg [Wed, 19 Jan 2011 20:27:06 +0000 (21:27 +0100)]
configure: TLS-SRP wasn't added as a feature
Test case 1014 failed since TLS-SRP was correctly set to the features
variable so curl-config --features didn't output it.
Daniel Stenberg [Wed, 19 Jan 2011 20:02:54 +0000 (21:02 +0100)]
dist: add new certs to tarball
Quinn Slack [Wed, 19 Jan 2011 19:35:02 +0000 (20:35 +0100)]
TLS-SRP: support added when using GnuTLS
Daniel Stenberg [Wed, 19 Jan 2011 12:19:44 +0000 (13:19 +0100)]
CURLOPT_SSL_VERIFYPEER: more clarifications
The default value is 1.
curl _uses_ a default CA bundle, it doesn't install one.
Drop the references to 7.10 as that is now >8 years old!
Daniel Stenberg [Wed, 19 Jan 2011 12:06:36 +0000 (13:06 +0100)]
TheArtOfHttpScripting: extended
Extended the intial HTTP protcol part and added a mention of --trace and
--trace-ascii.
Replaced most URLs in the text to use example.com instead of all the
made up strange names.
Shortened a bunch of lines.
Daniel Stenberg [Wed, 19 Jan 2011 11:54:17 +0000 (12:54 +0100)]
curl_easy_setopt.3: clarify VERIFYHOST/PEER
Extended the descriptions somewhat and made the options get listed next
to each other.
Daniel Stenberg [Tue, 18 Jan 2011 22:41:57 +0000 (23:41 +0100)]
RELEASE-NOTES: mention contributors
Daniel Stenberg [Tue, 18 Jan 2011 22:40:48 +0000 (23:40 +0100)]
RELEASE-NOTES: synced with
7fcbdd68b9e
Guenter Knauf [Tue, 18 Jan 2011 14:02:45 +0000 (15:02 +0100)]
Fixed configure define for Win32.
Submitted by Vincent Torri.
Kamil Dudka [Tue, 18 Jan 2011 12:53:43 +0000 (13:53 +0100)]
nss: fix a bug in handling of CURLOPT_CAPATH
... and update the curl.1 and curl_easy_setopt.3 man pages such that
they do not suggest to use an OpenSSL utility if curl is not built
against OpenSSL.
Bug: https://bugzilla.redhat.com/669702
Guenter Knauf [Mon, 17 Jan 2011 00:27:57 +0000 (01:27 +0100)]
Avoid redefines.
Daniel Stenberg [Sat, 15 Jan 2011 21:46:03 +0000 (22:46 +0100)]
curl.1: fix spelling
Bug: http://curl.haxx.se/bug/view.cgi?id=3157232
Reported by: John Bradshaw
Guenter Knauf [Fri, 14 Jan 2011 11:39:54 +0000 (12:39 +0100)]
Added casts to silent gcc warnings.
Yang Tse [Thu, 13 Jan 2011 14:54:14 +0000 (15:54 +0100)]
build: BCC - makefile.b32 tweak
Get rid of stdout redirection to NUL and move stderr redirection
into RM and RMDIR macros.
Yang Tse [Thu, 13 Jan 2011 14:33:34 +0000 (15:33 +0100)]
build: BCC - makefile.b32 tweak
Check for BCCDIR environment var done now as other checks.
Guenter Knauf [Thu, 13 Jan 2011 04:55:09 +0000 (05:55 +0100)]
Use env var for PSDK instead of hardcoded path.
Guenter Knauf [Thu, 13 Jan 2011 01:55:26 +0000 (02:55 +0100)]
Enabled SSPI support by default.
Guenter Knauf [Thu, 13 Jan 2011 01:48:11 +0000 (02:48 +0100)]
Use MAKE macro with BCC targets.
Yang Tse [Wed, 12 Jan 2011 22:28:19 +0000 (23:28 +0100)]
docs - update BCC INSTALL section
Yang Tse [Wed, 12 Jan 2011 19:53:28 +0000 (20:53 +0100)]
build: BCC - require Borlands's MAKE for Makefile.b32 processing.
Yang Tse [Wed, 12 Jan 2011 17:07:04 +0000 (18:07 +0100)]
build: BCC - recover lost functionality from commit
3d813204260b37289411
Borland's $(MAKEDIR) expands to the path where make.exe is located,
use this feature to define BCCDIR when user has not defined BCCDIR.
Yang Tse [Wed, 12 Jan 2011 01:35:14 +0000 (02:35 +0100)]
build: use external preprocessor cpp32 when building with Borland C
Yang Tse [Wed, 12 Jan 2011 01:33:39 +0000 (02:33 +0100)]
build: allow usage of Borland 5.5.1 external preprocessor cpp32
Guenter Knauf [Tue, 11 Jan 2011 17:32:38 +0000 (18:32 +0100)]
Disable LDAP support since BCC headers are insufficient.
Guenter Knauf [Tue, 11 Jan 2011 17:22:42 +0000 (18:22 +0100)]
Instead of exiting with error lets set BCCDIR self.
Guenter Knauf [Tue, 11 Jan 2011 16:51:14 +0000 (17:51 +0100)]
Some Borland C++ makefile tweaks.
Guenter Knauf [Tue, 11 Jan 2011 16:40:13 +0000 (17:40 +0100)]
Borland C++ doesnt have struct sockaddr_storage.
Daniel Stenberg [Mon, 10 Jan 2011 23:14:36 +0000 (00:14 +0100)]
connect: use UDP correctly
The idea that the protocol and socktype is part of name resolving in the
libc functions is nuts. We keep the name resolver functions assume
TCP/STREAM and we make sure that when we want to connect to a UDP
service we use the correct UDP/DGRAM set instead. This bug was because
the ->protocol field was not always set correctly.
This bug was only affecting ipv6-disabled non-cares non-threaded builds.
Bug: http://curl.haxx.se/bug/view.cgi?id=3154436
Reported by: "dperham"
Quinn Slack [Mon, 10 Jan 2011 12:53:01 +0000 (13:53 +0100)]
SSL: fix memory leak
In OOM situation. Follow-up fix to commit
a9cd4f4ed49e1a0.
Daniel Stenberg [Wed, 5 Jan 2011 23:47:37 +0000 (00:47 +0100)]
gtls: fix memory leak
Bug: http://curl.haxx.se/mail/lib-2011-01/0079.html
Reported by: Quinn Slack
Marcel Roelofs [Wed, 5 Jan 2011 16:01:07 +0000 (17:01 +0100)]
HTTP: HTTP Negotiate authentication using SSPI
Only under Windows
Daniel Stenberg [Thu, 6 Jan 2011 22:41:01 +0000 (23:41 +0100)]
cmake: removed two files
CMake/CheckTypeSize.c.in and CMake/CheckTypeSize.cmake were removed in
the previous cmake commit
Dan Fandrich [Thu, 6 Jan 2011 07:53:24 +0000 (23:53 -0800)]
Made unit_setup() return an error code to abort the test early
This makes it possible to skip the call to unit_stop() in such
cases. Also use Curl_safefree() in unit test 1302 so it will
pass the memory torture test.
Daniel Stenberg [Wed, 5 Jan 2011 23:19:17 +0000 (00:19 +0100)]
SSH: speedcheck clobbered existing error
The just added speedcheck must not ruin the error code if already set
due to a problem.