Yitzhak Mandelbaum [Wed, 19 Feb 2020 16:04:51 +0000 (11:04 -0500)]
[AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.
Summary:
This revision adds matchers that match calls to the gtest EXPECT and ASSERT
macros almost like function calls. The matchers are placed in separate files
(GtestMatchers...), because they are specific to the gtest library.
Reviewers: gribozavr2
Subscribers: mgorny, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74840
Florian Hahn [Fri, 21 Feb 2020 16:55:18 +0000 (16:55 +0000)]
[DSE,MSSA] Add debug counter.
Can be used like
-debug-counter=dse-memoryssa-skip=10,dse-memoryssa-counter-count=20
Reviewers: dmgreen, rnk, efriedma, bryant, asbirlea
Reviewed By: asbirlea
Differential Revision: https://reviews.llvm.org/D72147
Cameron McInally [Fri, 21 Feb 2020 16:55:25 +0000 (10:55 -0600)]
[AArch64][SVE] Add +fullfp16 to sve-vector-splat.ll
Add +fullfp16 to sve-vector-splat.ll so we can test folding of immediates into moves.
This attribute can go away later when SVE has a full set of fp16 patterns in place.
Differential Revision: https://reviews.llvm.org/D74965
Jay Foad [Thu, 20 Feb 2020 20:21:30 +0000 (20:21 +0000)]
GlobalISel: Fix narrowing of (G_ASHR i64:x, 32)
Reviewers: arsenm
Subscribers: jvesely, wdng, nhaehnle, rovka, hiraditya, volkan, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74950
Matt Arsenault [Thu, 20 Feb 2020 14:58:03 +0000 (09:58 -0500)]
AMDGPU/GlobalISel: Commit test changes I forgot to squash
These should have been in
ac7abe0ba9ae4c6a2248cc3ef4e4fe7e6d270105
Matt Arsenault [Fri, 21 Feb 2020 02:12:04 +0000 (21:12 -0500)]
AMDGPU/GlobalISel: Fix xnor matching
We should try the generated matchers before the manual selection. This
means the patterns are now handling the common cases, but the manual
selection code is not yet dead. It's still handling the non-s32/s64
cases (like v2s16 and v2s32). Currently tablegen doesn't have a nice
way to have a single pattern that covers multiple types.
Simon Pilgrim [Fri, 21 Feb 2020 15:30:56 +0000 (15:30 +0000)]
[TargetLowering] Apply basic shift combines before recursive SimplifyDemandedBits calls.
Minor refactor/cleanup before we begin adding non-uniform support.
Fangrui Song [Thu, 20 Feb 2020 07:14:49 +0000 (23:14 -0800)]
[ELF] Shuffle .init_array/.fini_array with --shuffle-sections=
Useful for detecting static initialization order fiasco.
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D74887
Ivan Hernandez [Fri, 21 Feb 2020 16:13:05 +0000 (08:13 -0800)]
[lldb-vscode] Use libOption with tablegen to parse command line options.
This change will bring lldb-vscode in line with how several other llvm
tools process command line arguments and make it easier to add future
options.
Differential revision: https://reviews.llvm.org/D74798
Fangrui Song [Mon, 17 Feb 2020 21:56:01 +0000 (13:56 -0800)]
[ELF] Warn changed output section address
When the output section address (addrExpr) is specified, GNU ld warns if
sh_addr is different. This patch implements the warning.
Note, LinkerScript::assignAddresses can be called more than once. We
need to record the changed section addresses, and only report the
warnings after the addresses are finalized.
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D74741
Fangrui Song [Mon, 17 Feb 2020 18:21:31 +0000 (10:21 -0800)]
[ELF] Ignore the maximum of input section alignments for two cases
Follow-up for D74286.
Notations:
* alignExpr: the computed ALIGN value
* max_input_align: the maximum of input section alignments
This patch changes the following two cases to match GNU ld:
* When ALIGN is present, GNU ld sets output sh_addr to alignExpr, while lld use max(alignExpr, max_input_align)
* When addrExpr is specified but alignExpr is not, GNU ld sets output sh_addr to addrExpr, while lld uses `advance(0, max_input_align)`
Note, sh_addralign is still set to max(alignExpr, max_input_align).
lma-align.test is enhanced a bit to check we don't overalign sh_addr.
fixSectionAlignments() sets addrExpr but not alignExpr for the `!hasSectionsCommand` case.
This patch sets alignExpr as well so that max_input_align will be respected.
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D74736
Matt Arsenault [Fri, 21 Feb 2020 16:09:20 +0000 (11:09 -0500)]
AMDGPU/GlobalISel: Precommit xnor matching test
David Green [Fri, 21 Feb 2020 16:07:09 +0000 (16:07 +0000)]
[ARM] Correct Formatting. NFC
Also removed an unnecessary TODO that I don't believe is relevant for
the instruction in question.
Matt Arsenault [Sat, 15 Feb 2020 22:14:17 +0000 (17:14 -0500)]
AMDGPU/GlobalISel: Manually select G_BUILD_VECTOR_TRUNC
We have patterns for s_pack* selection, but they assume the inputs are
a build_vector with 16-bit inputs, not a truncating build
vector. Since there's still outstanding work for how to handle
mismatched result and source element vector operations, and since I'm
trying a different packed vector strategy than SelectionDAG, just
manually select this for now.
Matt Arsenault [Thu, 20 Feb 2020 23:59:08 +0000 (18:59 -0500)]
AMDGPU/GlobalISel: Legalize G_FPOW
There are few differences from the DAG handling. First, the DAG
handling uses a primitive selection pattern instead of custom
legalizing it. Because of this, this makes use of source modifiers
while the DAG does not.
Also instead of promoting f16, try to use the f16 log/exp. There's no
f16 fmul_legacy, so widen just for the multiply, although I'm not sure
that's the best solution.
Matt Arsenault [Thu, 20 Feb 2020 22:40:43 +0000 (17:40 -0500)]
AMDGPU/GlobalISel: Select llvm.amdgcn.fmul.legacy
Matt Arsenault [Thu, 20 Feb 2020 20:34:51 +0000 (15:34 -0500)]
AMDGPU/GlobalISel: Fix constant bus violation with source modifiers
This looked through copies to find the source modifiers, which may
have been SGPR->VGPR copies added to avoid potential constant bus
violations. Re-insert a copy to a VGPR if this happens.
Alexandre Ganea [Fri, 21 Feb 2020 15:05:07 +0000 (10:05 -0500)]
[mlir] Silence error: call to constructor of 'llvm::APInt' is ambiguous
I was getting this error when using Clang 9.0.1 for compiling.
F:\llvm-project\mlir\lib\IR\Builders.cpp(119,27): error: call to constructor of 'llvm::APInt' is ambiguous
APInt(32, value, /*isSigned=*/false));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
F:\llvm-project\llvm\include\llvm/ADT/APInt.h(277,3): note: candidate constructor
APInt(unsigned numBits, uint64_t val, bool isSigned = false)
^
F:\llvm-project\llvm\include\llvm/ADT/APInt.h(304,3): note: candidate constructor
APInt(unsigned numBits, unsigned numWords, const uint64_t bigVal[]);
^
1 error generated.
Eric Astor [Thu, 20 Feb 2020 14:43:02 +0000 (09:43 -0500)]
Remove unused functions in llvm-ml
On review, these functions will likely not be needed even in the final MasmParser.
Pavel Labath [Fri, 21 Feb 2020 14:42:07 +0000 (15:42 +0100)]
[lldb/DWARF] Add support for type units in dwp files
all that was needed was to teach lldb's DWARF context about the
debug_tu_index section.
Sean Fertile [Thu, 20 Feb 2020 14:18:10 +0000 (09:18 -0500)]
[PowerPC][NFC] Add a test for vrsave usage iinline asm.
Add a lit test that that uses vrsave register in the clobber list, and
tests the extended mnemonics mtvrsave and mfvrsave.
Gabor Marton [Fri, 21 Feb 2020 14:54:58 +0000 (15:54 +0100)]
[AST][NFC] Update outdated comments in ASTStructuralEquivalence.cpp
Sean Fertile [Thu, 20 Feb 2020 20:33:18 +0000 (15:33 -0500)]
[PowerPC][NFC] Remove Darwin specific logic in frame finalization.
Remove some cumbersome Darwin specific logic for updating the frame
offsets of the condition-register spill slots. The containing function has an
early return if the subtarget is not ELF based which makes the Darwin logic
dead.
Pavel Labath [Thu, 20 Feb 2020 14:06:01 +0000 (15:06 +0100)]
[Error/unittests] Add a FailedWithMessage gtest matcher
Summary:
We already have a "Failed" matcher, which can be used to check any
property of the Error object. However, most frequently one just wants to
check the error message, and while this is possible with the "Failed"
matcher, it is also very convoluted
(Failed<ErrorInfoBase>(testing::Property(&ErrorInfoBase::message, "the
message"))).
Now, one can just write: FailedWithMessage("the message"). I expect that
most of the usages will remain this simple, but the argument of the
matcher is not limited to simple strings -- the argument of the matcher
can be any other matcher, so one can write more complicated assertions
if needed (FailedWithMessage(ContainsRegex("foo|bar"))). If one wants to
match multiple error messages, he can pass multiple arguments to the
matcher.
If one wants to match the message list as a whole (perhaps to check the
message count), I've also included a FailedWithMessageArray matcher,
which takes a single matcher receiving a vector of error message
strings.
Reviewers: sammccall, dblaikie, jhenderson
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74898
Simon Pilgrim [Fri, 21 Feb 2020 14:23:38 +0000 (14:23 +0000)]
[X86] Regenerate hi reg tests
Simon Pilgrim [Fri, 21 Feb 2020 13:29:40 +0000 (13:29 +0000)]
[TargetLowering] SimplifyDemandedBits - use getValidShiftAmountConstant helper.
Use the SelectionDAG::getValidShiftAmountConstant helper to get const/constsplat shift amounts, which allows us to drop the out of range shift amount early-out.
First step towards better non-uniform shift amount support in SimplifyDemandedBits.
Lei Zhang [Fri, 10 Jan 2020 19:48:24 +0000 (14:48 -0500)]
[mlir] Add a signedness semantics bit to IntegerType
Thus far IntegerType has been signless: a value of IntegerType does
not have a sign intrinsically and it's up to the specific operation
to decide how to interpret those bits. For example, std.addi does
two's complement arithmetic, and std.divis/std.diviu treats the first
bit as a sign.
This design choice was made some time ago when we did't have lots
of dialects and dialects were more rigid. Today we have much more
extensible infrastructure and different dialect may want different
modelling over integer signedness. So while we can say we want
signless integers in the standard dialect, we cannot dictate for
others. Requiring each dialect to model the signedness semantics
with another set of custom types is duplicating the functionality
everywhere, considering the fundamental role integer types play.
This CL extends the IntegerType with a signedness semantics bit.
This gives each dialect an option to opt in signedness semantics
if that's what they want and helps code sharing. The parser is
modified to recognize `si[1-9][0-9]*` and `ui[1-9][0-9]*` as
signed and unsigned integer types, respectively, leaving the
original `i[1-9][0-9]*` to continue to mean no indication over
signedness semantics. All existing dialects are not affected (yet)
as this is a feature to opt in.
More discussions can be found at:
https://groups.google.com/a/tensorflow.org/d/msg/mlir/XmkV8HOPWpo/7O4X0Nb_AQAJ
Differential Revision: https://reviews.llvm.org/D72533
Krzysztof Parzyszek [Thu, 20 Feb 2020 22:42:02 +0000 (16:42 -0600)]
[Hexagon] Introduce noop intrinsic to cast between vector predicate types
The (overloaded) intrinsic is llvm.hexagon.V6.pred.typecast[.128B]. The
types of the operand and the return value are HVX boolean vector types.
For each cast, there needs to be a corresponding intrinsic declared,
with different suffixes appended to the name, e.g.
; cast <128 x i1> to <32 x i1>
declare <32 x i1> @llvm.hexagon.V6.pred.typecast.128B.s1(<128 x i1>)
; cast <32 x i1> to <64 x i1>
declare <64 x i1> @llvm.hexagon.V6.pred.typecast.128B.s2(<32 x i1>)
etc.
Evgeniy Brevnov [Mon, 20 Jan 2020 12:35:39 +0000 (19:35 +0700)]
[DependenceAnalysis] Memory dependence analysis internal caching mechanism is broken in presence of TBAA (PR42733).
Summary:
There is a flaw in memory dependence analysis caching mechanism when memory accesses with TBAA are involved. Assume we first analysed and cached results for access with TBAA. Later we request dependence for the same memory but without TBAA (or different TBAA). By design these two queries should share one entry in the internal cache which corresponds to a general access (without TBAA). Thus upon second request internal cached is cleared and we continue analysis for access as if there is no TBAA.
The problem is that even though internal cache is cleared the set of visited nodes is not. That means we won't traverse visited nodes again and populate internal cache with the corresponding dependence results. So we end up with internal cache in an incomplete state. Current implementation tries to signal that situation by resetting CacheInfo->Pair at line 1104. But that doesn't actually help since later code ignores this invalidation and relies on 'Cache->empty()' property to decide on cache completeness.
Reviewers: reames, hfinkel, chandlerc, fedor.sergeev, asbirlea, fhahn, john.brawn, Prazek, sunfish
Reviewed By: john.brawn
Subscribers: DaniilSuchkov, kosarev, jfb, dantrushin, hiraditya, bmahjour, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73032
Sanjay Patel [Fri, 21 Feb 2020 12:58:36 +0000 (07:58 -0500)]
[ConstantFold] fold fsub -0.0, undef to undef rather than NaN
A question about this behavior came up on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2020-February/139003.html
...and as part of backend improvements in D73978, but this is an IR
change first because we already have fairly thorough tests in place
here.
We decided not to implement a more general change that would have
folded any FP binop with nearly arbitrary constant + undef operand
to undef because that is not theoretically correct (even if it is
practically correct).
Differential Revision: https://reviews.llvm.org/D74713
serge-sans-paille [Fri, 21 Feb 2020 08:48:27 +0000 (09:48 +0100)]
Detect and disable openmp tests that require multiple hardware processor to run
Team tests seem to require at least two physical cores, and using the same trick
as in https://reviews.llvm.org/D55598 doesn't work (why?) .
Using lit configuration instead.
Differential Revision: https://reviews.llvm.org/D74921
Swiftfuchs [Fri, 21 Feb 2020 12:55:43 +0000 (13:55 +0100)]
[NFC] Corrected a minor typo in a comment
Nicolai Hähnle [Fri, 21 Feb 2020 12:10:18 +0000 (13:10 +0100)]
test/CodeGen/AMDGPU: Add a test case that shows a miscompilation
Related to https://reviews.llvm.org/D74908
Change-Id: I6ebf3b5c7a32493016994f30d6796c41e95aecde
Kern Handa [Fri, 21 Feb 2020 12:25:24 +0000 (13:25 +0100)]
[NFC][mlir] Adding more operators to EDSC TemplatedIndexedValue
This change adds some missing arithmetic and logical operators to
`TemplatedIndexedValue` for EDSC usage.
Differential Revision: https://reviews.llvm.org/D74686
Sebastian Neubauer [Fri, 24 Jan 2020 11:17:08 +0000 (12:17 +0100)]
Make unittests include path relative
This change is relevant when embedding the llvm cmake project into
another project. It should not change the build behavior of a normal
llvm build.
In the case where llvm is embedded as a cmake subproject,
CMAKE_SOURCE_DIR does not point to the expected directory and building
the tests fails.
Using CMAKE_CURRENT_SOURCE_DIR fixes this problem, as it will always
point to the same directory.
Differential Revision: https://reviews.llvm.org/D73466
Haojian Wu [Fri, 21 Feb 2020 08:57:05 +0000 (09:57 +0100)]
[clangd] Allow renaming class templates in cross-file rename.
Summary:
It was disabled because we don't handle explicit template
specialization well (due to the index limitation).
renaming templates is normal in practic, rather than disabling it, this patch
allows to rename them though it is not perfect (just a known limitation).
Context: https://github.com/clangd/clangd/issues/280
Reviewers: kbobyrev
Reviewed By: kbobyrev
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74709
Raphael Isemann [Thu, 20 Feb 2020 12:23:39 +0000 (13:23 +0100)]
[lldb][NFC] Split up ClangASTSource::FindExternalVisibleDecls
This function has two functions hidden inside it. Let's make
them proper functions.
Haojian Wu [Thu, 20 Feb 2020 14:22:07 +0000 (15:22 +0100)]
[clangd] Fix the incomplete template specialization in findTarget.
Summary:
FindTarget doesn't report the TemplatePattern for incomplete
specialization.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74900
Craig Topper [Fri, 21 Feb 2020 08:29:18 +0000 (00:29 -0800)]
[X86] Don't bother avoiding illegal FCMOVs if we don't have the cmov subtarget feature.
We'll be forced to emit branches so we might as well use the most
direct condition.
Craig Topper [Fri, 21 Feb 2020 07:53:00 +0000 (23:53 -0800)]
[X86] Make combineCMov not create unsupported FCMOVs when f32/f64 are using X87.
This makes the behavior consistent with what's in LowerSELECT.
Craig Topper [Fri, 21 Feb 2020 07:49:44 +0000 (23:49 -0800)]
[X86] Autogenerate complete checks. NFC
Sam Clegg [Thu, 13 Feb 2020 16:38:18 +0000 (08:38 -0800)]
[WebAssembly] Remove unneeded getWasmKindForNamedSection function
I believe this was carried over from getELFKindForNamedSection since
the wasm backend originally used ELF object writing as a template.
Differential Revision: https://reviews.llvm.org/D74565
Craig Topper [Fri, 21 Feb 2020 05:38:49 +0000 (21:38 -0800)]
[X86] Remove unnecessary isNullConstant in LowerSelect. NFC
At this point in the code we know that Op1 or Op2 is
all ones. Y points to the other operand. In the case that
Op2 is zero, Op1 must be all ones and Y is Op2. The OR
ORs Y into Res. But if Y is 0 the OR will be folded away by
getNode so we don't need to check for it.
Jan Vesely [Tue, 4 Feb 2020 21:13:17 +0000 (16:13 -0500)]
libclc: Use acos implementation from amd_builtins
Fixes acos CTS (1 thread, scalar) on AMD Turks.
Reviewer: tstellar
Differential Revision: https://reviews.llvm.org/D74011
Craig Topper [Fri, 21 Feb 2020 03:56:44 +0000 (19:56 -0800)]
[X86] Add CMOV_VR64 pseudo instruction for MMX. Remove mmx handling from combineSelect.
The combineSelect code was casting to i64 without any check that
i64 was legal. This can break after type legalization.
It also required splitting the mmx register on 32-bit targets.
It's not clear that this makes sense. Instead switch to using
a cmov pseudo like we do for XMM/YMM/ZMM.
Martijn Vels [Wed, 19 Feb 2020 21:27:50 +0000 (16:27 -0500)]
Split _LIBCPP_STRING_EXTERN_TEMPLATE_LIST up into a V1 and UNSTABLE version.
This change splits the _LIBCPP_STRING_EXTERN_TEMPLATE_LIST up into a _LIBCPP_STRING_V1_EXTERN_TEMPLATE_LIST containing the stable ABI, and a _LIBCPP_STRING_UNSTABLE_EXTERN_TEMPLATE_LIST containing the unstable ABI.
The purpose is to explicitly define and maintain the two lists, where the unstable ABI allows for ABI breaking changes for purposes such as optimization while offering a strong guarantee that any change inside the unstable ABI does not affect the stable ABI.
As per the comment in the __string header, we do still allow etries to be added to the stable ABI list as the c++ versions and corresponding c++ std API changes.
River Riddle [Fri, 21 Feb 2020 04:08:33 +0000 (20:08 -0800)]
[mlir] Use getOperation()->setAttr when generating attribute set
methods.
This avoids the need to resolve overloads when the current operation
also defines a 'setAttr' method.
Johannes Doerfert [Thu, 20 Feb 2020 22:43:03 +0000 (16:43 -0600)]
[OpenMP][NFC] Remove leftover debug messages
Jim Lin [Fri, 21 Feb 2020 01:28:49 +0000 (09:28 +0800)]
[XCore] Add instruction pattern for bitrev
Summary:
Add support for lowering bitreverse to the bitrev instruction.
Fix https://bugs.llvm.org/show_bug.cgi?id=34628.
Reviewers: RKSimon, rtrieu, robertlytton
Reviewed By: RKSimon
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74748
Vedant Kumar [Thu, 20 Feb 2020 22:16:25 +0000 (14:16 -0800)]
[Dominators] Use Instruction::comesBefore for block-local queries, NFC
Use the lazy instruction ordering facility for block-local dominance
queries.
Differential Revision: https://reviews.llvm.org/D74931
Bill Wendling [Fri, 21 Feb 2020 00:22:35 +0000 (16:22 -0800)]
Filter callbr insts from critical edge splitting
Similarly to how splitting predecessors with an indirectbr isn't handled
in the generic way, we also shouldn't split callbrs, for similar
reasons.
Michael Spencer [Thu, 20 Feb 2020 23:25:36 +0000 (15:25 -0800)]
[libunwind][CMake] Treat S files as C to work around CMake bug.
The OSX_ARCHITECTURES property is supposed to add the -arch flag when
targeting Apple platforms. However, due to a bug in CMake
(https://github.com/Kitware/CMake/blob/master/Source/cmLocalGenerator.cxx#L1780),
this does not apply to assembly files. This results in a linker error
when trying to build libunwind for i386 on MacOS.
rdar://
59642189
Mark de Wever [Thu, 20 Feb 2020 23:13:38 +0000 (18:13 -0500)]
[libc++][regex] Validate backreferences in the constructor.
This patch enables throwing exceptions for invalid backreferences
in the constructor when using the basic, extended, grep, or egrep grammar.
This fixes bug 34297.
Differential Revision: https://reviews.llvm.org/D62453
Craig Topper [Thu, 20 Feb 2020 22:00:17 +0000 (14:00 -0800)]
[X86] Add CMOV_VK1 pseudo so we don't crash on v1i1 ISD::SELECT
Craig Topper [Thu, 20 Feb 2020 21:46:56 +0000 (13:46 -0800)]
[X86] Expand vselect of v1i1 under avx512.
We already do this for v2i1, v4i1, etc.
Craig Topper [Thu, 20 Feb 2020 21:37:09 +0000 (13:37 -0800)]
[X86] Custom legalize v1i1 UADDSAT/USUBSAT/SADDSAT/UADDSAT to match v2i1/v4i1/v8i1 etc.
Craig Topper [Thu, 20 Feb 2020 21:28:12 +0000 (13:28 -0800)]
[X86] Fix a couple copy mistakes in v4i1 or/and/xor isel patterns.
VK1 was being used as the output of the copy to regclass, but it
should be VK2/VK4. Shouldn't matter in practice though since
VK1/VK2/VK4/VK8/VK16 are all identicaly and just have different VTs.
Craig Topper [Thu, 20 Feb 2020 21:22:38 +0000 (13:22 -0800)]
[X86] Custom legalize v1i1 add/sub/mul to xor/xor/and with avx512.
We already did this for v2i1, v4i1, v8i1, etc.
Louis Dionne [Thu, 20 Feb 2020 23:03:10 +0000 (18:03 -0500)]
[libc++] Explain XFAILs with std::uncaught_exceptions test
Jonas Devlieghere [Thu, 20 Feb 2020 22:51:57 +0000 (14:51 -0800)]
[lldb/Test] Remove stale README in test/API
Now that the test live in the same directory the README is no longer
relevant.
River Riddle [Thu, 20 Feb 2020 22:37:25 +0000 (14:37 -0800)]
[mlir][Parser] Update DenseElementsAttr to print in hex when the number of elements is over a certain threshold.
Summary: DenseElementsAttr is used to store tensor data, which in some cases can become extremely large(100s of mb). In these cases it is much more efficient to format the data as a string of hex values instead.
Differential Revision: https://reviews.llvm.org/D74922
Scott Linder [Thu, 20 Feb 2020 22:36:56 +0000 (17:36 -0500)]
Revert "[Driver] Escape the program path for -frecord-command-line"
This reverts commit
6123074d0c0de3614f1552f2f2d6b9db7b32cebe.
Quoting/escaping rules seem host specific, so the test is failing on
some bots.
Jonas Devlieghere [Thu, 20 Feb 2020 22:34:49 +0000 (14:34 -0800)]
[lldb/Plugin] Don't mark ProcessNetBSD as a plugin
ProcessNetBSD has no initializers so it's just a regular library and
shouldn't have the PLUGIN argument in add_lldb_library.
River Riddle [Thu, 20 Feb 2020 22:16:20 +0000 (14:16 -0800)]
[mlir] Use LLJIT::getMainJITDylib instead of hardcoding '<main>'
This fixes test failures caused by a change to the name of the main
dylib, now called 'main'. It also hardens the engine against potential
future changes to the name.
aartbik [Thu, 20 Feb 2020 21:57:54 +0000 (13:57 -0800)]
[mlir] [VectorOps] Multi-dim reductions for lowering vector.contract
Summary:
This implements the last step for lowering vector.contract progressively
to LLVM IR (except for masks). Multi-dimensional reductions that remain
after expanding all parallel dimensions are lowered into into simpler
vector.contract operations until a trivial 1-dim reduction remains.
Reviewers: nicolasvasilache, andydavis1
Reviewed By: andydavis1
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74880
Florian Hahn [Thu, 20 Feb 2020 18:46:29 +0000 (19:46 +0100)]
[SCCP] Do not mark unknown loads as overdefined.
For tracked globals that are unknown after solving, we expect all
non-store uses to be replaced.
This is a follow-up to
f8045b250d80, which removed forcedconstant.
We should not mark unknown loads as overdefined, as they either load
from an unknown pointer or an undef global. Restore the original logic
for loads.
Eli Friedman [Wed, 29 Jan 2020 03:17:30 +0000 (19:17 -0800)]
[SVE] Add support for lowering GEPs involving scalable vectors.
This includes both GEPs where the indexed type is a scalable vector, and
GEPs where the result type is a scalable vector.
Differential Revision: https://reviews.llvm.org/D73602
Scott Linder [Thu, 20 Feb 2020 21:31:17 +0000 (16:31 -0500)]
[Driver] Escape the program path for -frecord-command-line
Similar to the rest of the command line that is recorded, the program
path must also have spaces and backslashes escaped. Without this
parsing the recorded command line becomes hard on platforms like
Windows where spaces and backslashes are common.
Patch By: Ravi Ramaseshan
Differential Revision: https://reviews.llvm.org/D74811
shafik [Thu, 20 Feb 2020 20:28:46 +0000 (12:28 -0800)]
[ASTImporter] Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage
This fixed is based on the assert in LinkageComputer::getLVForDecl(...) which assumes that all the decls in a redecl chain have the same linkage.
Differential Revision: https://reviews.llvm.org/D74639
David Tenty [Thu, 20 Feb 2020 20:39:16 +0000 (15:39 -0500)]
[AIX] Improve 32/64-bit build configuration
Summary:
AIX supports both 32-bit and 64-bit environments (with 32-bit being the default). This patch improves support for building LLVM on AIX in both 32-bit and 64-bit mode.
- Change host detection to return correct 32/64-bit triple as config_guess does not return the correct version on 64-bit. This can confuse JIT tests and other things that care about what the host triple is.
- Remove manual setting of 64-bit flags on AIX. AIX provides OBJECT_MODE environment variable to enable the user to obtain a 64-bit development environment. CMake will properly set these flags provided the user sets the correct OBJECT_MODE before configuring and setting them manually will interfere with 32-bit builds.
- Don't present the LLVM_BUILD_32_BITS option on AIX, users should use OBJECT_MODE when running CMake instead.
Reviewers: hubert.reinterpretcast, DiggerLin, stevewan
Reviewed By: DiggerLin, stevewan
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74256
Craig Topper [Thu, 20 Feb 2020 20:28:54 +0000 (12:28 -0800)]
Recommit "[X86] Replace a bad use of MVT::getVectorVT with EVT::getVectorVT""
With the correct author this time
Craig Topper [Thu, 20 Feb 2020 20:28:01 +0000 (12:28 -0800)]
Revert
714265dabb606bfef2f85694234f152edbfa91ac "[X86] Replace a bad use of MVT::getVectorVT with EVT::getVectorVT"
I accidentally messed up the author on the previous commit somehow.
Quentin Colombet [Thu, 20 Feb 2020 19:27:36 +0000 (11:27 -0800)]
[X86] Replace a bad use of MVT::getVectorVT with EVT::getVectorVT
The type here isn't guaranteed to be a simple type.
Fixes PR44976
Nico Weber [Thu, 20 Feb 2020 20:15:54 +0000 (15:15 -0500)]
Revert "libclang: Add static build support for Windows" and
follow-up "libclang: Make shared object symbol exporting by default"
This reverts commit
7a7c753b0cca6abb61f054842fb087dfc30dc563.
This reverts commit
7ff1f55a1219719f57a6f7905c26ce41d1767e4c.
They broke building libclang.dll on Windows, see
https://reviews.llvm.org/D74564
Nico Weber [Thu, 20 Feb 2020 20:11:13 +0000 (15:11 -0500)]
Revert "[AArch64][SVE] Add intrinsics for SVE2 bitwise ternary operations"
This reverts commit
ce70e2899879e092b153a4078b993833b6696713.
It broke MC/AArch64/SVE2/bsl-diagnostics.s everywhere.
Sanjay Patel [Thu, 20 Feb 2020 18:41:56 +0000 (13:41 -0500)]
[ConstantFold] add/move tests for FP with undef operand; NFC
Sourabh Singh Tomar [Thu, 20 Feb 2020 19:42:52 +0000 (01:12 +0530)]
Revert "[NFCI][DebugInfo]: Corrected a Typo."
This reverts commit
3e1090922a0b808f424ff424b744752b0d53a3ee
as per Paul Robinson's suggestion.
Francesco Petrogalli [Thu, 20 Feb 2020 19:37:02 +0000 (19:37 +0000)]
[llvm][build] Fix shared lib builds. [NFC]
The code at https://reviews.llvm.org/D74808 has broken builds that are
configured with -DBUILD_SHARED_LIBS=On.
This patch adds the correct library dependencies.
Richard Smith [Thu, 20 Feb 2020 19:40:09 +0000 (11:40 -0800)]
[cxx_status] Update -std= instructions for C++20.
We merged support for -std=c++20 to the Clang 10 branch, so -std=c++2a
is only needed in Clang 9 and earlier.
Quentin Colombet [Thu, 20 Feb 2020 19:27:36 +0000 (11:27 -0800)]
[GISel][KnownBits] Give up on PHI analysis as soon as we don't know anything
When analyzing PHIs, we gather the known bits for every operand and
merge them together to get the known bits of the result of the PHI.
It is not unusual that merging the information leads to know nothing
on the result (e.g., phi a: i8 3, b: i8 unknown, ..., after looking at the
second argument we know we will know nothing on the result), thus, as
soon as we reach that state, stop analyzing the following operand (i.e.,
on the previous example, we won't process anything after looking at `b`).
This improves compile time in particular with PHIs with a large number
of operands.
NFC.
Jan Korous [Mon, 17 Feb 2020 22:55:49 +0000 (14:55 -0800)]
[clang][doxygen] Fix false -Wdocumentation warning for tag typedefs
For tag typedefs like this one:
/*!
@class Foo
*/
typedef class { } Foo;
clang -Wdocumentation gives:
warning: '@class' command should not be used in a comment attached to a
non-struct declaration [-Wdocumentation]
... while doxygen seems fine with it.
Differential Revision: https://reviews.llvm.org/D74746
David Tenty [Thu, 20 Feb 2020 19:22:16 +0000 (14:22 -0500)]
[AIX] Pack BasicBlockBits
Summary:
D51664 introduces a new structure BasicBlockBits which it expects to be
packed a certain way. This change is very similar to D60164, and we apply the
same fix:
"On AIX, the canonical layout of bit-fields would cause
these ... to span four bytes. Applying the pack pragma for compilers that
employ the AIX canonical layout allows these ... to fit within the expected
two bytes. In the future, the pragma would also likely need to be applied when
building with Clang on AIX."
Reviewers: jasonliu, hubert.reinterpretcast, sfertile, xingxue
Reviewed By: sfertile
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74911
Cristian Adam [Thu, 20 Feb 2020 19:24:52 +0000 (14:24 -0500)]
libclang: Make shared object symbol exporting by default
https://reviews.llvm.org/D74564 enabled static building for libclang,
and for non CMake consumers they had to set the `CMAKE_EXPORTS` define
when consuming libclang.
This commit makes the non CMake users of the static building have to define `CMAKE_NO_EXPORTS`.
Differential Revision: https://reviews.llvm.org/D74907
Jonathan Coe [Thu, 20 Feb 2020 19:23:38 +0000 (19:23 +0000)]
[clang-format] Merge name and colon into a single token for C# named arguments
Summary:
Merge 'argumentName' and ':' into a single token in foo(argumentName: bar).
Add C# named argument as a token type.
Reviewers: krasimir, MyDeveloperDay
Reviewed By: krasimir
Tags: #clang-format
Differential Revision: https://reviews.llvm.org/D74894
Simon Pilgrim [Thu, 20 Feb 2020 19:22:37 +0000 (19:22 +0000)]
[X86] Fix NSW/NUW typo in avg test (PR44973)
The not_avg_v16i8_wide_constants test shouldn't assume NSW/NUW for the addition of -1 - copy + paste typo from other avg tests
Lang Hames [Thu, 20 Feb 2020 19:04:35 +0000 (11:04 -0800)]
[ORC] Add a convenience method for setting the ExecutionSession to LLJITBuilder.
Can be used to set a custom pre-configured ExecutionSession for the LLJIT or
LLLazyJIT instance being constructed.
Lang Hames [Thu, 20 Feb 2020 18:41:07 +0000 (10:41 -0800)]
[ORC][examples] Fix ThinLtoJIT example after changes in
85fb997659b.
Matthias Kramm [Thu, 20 Feb 2020 19:08:59 +0000 (11:08 -0800)]
Fix some typos in the MLIR documentation.
Summary: Fix minor typos in the tutorial and the "writing a pass" page.
Differential Revision: https://reviews.llvm.org/D74905
Alex Brachet [Thu, 20 Feb 2020 19:05:34 +0000 (14:05 -0500)]
[libc] Add Initial Support for Signals
Summary:
This patch adds signal support on Linux. The current implementation gets the SIG* macros and types like `sigset_t` from <linux/signals.h>
This patch also adds raise(3), and internal routines `block_all_signals` and `restore_signals`
Reviewers: sivachandra, MaskRay, gchatelet
Reviewed By: sivachandra
Subscribers: libc-commits, mgorny, tschuett
Differential Revision: https://reviews.llvm.org/D74528
Sanjay Patel [Thu, 20 Feb 2020 18:41:56 +0000 (13:41 -0500)]
[x86] allow peeking through an extract_subvector to find a splatted operand
The motivating case is seen in "splat4_v8f32_load_store" and based on code in PR42024:
https://bugs.llvm.org/show_bug.cgi?id=42024
(I haven't stepped through the v8i32 sibling test yet to see why that diverged.)
There are other potential improvements visible like allowing scalarization or vector
narrowing.
Differential Revision: https://reviews.llvm.org/D74909
Sean Fertile [Thu, 20 Feb 2020 18:22:23 +0000 (13:22 -0500)]
[PowerPC][NFC] Cleanup some of the Darwin mentions in the README.txt.
Francis Visoiu Mistrih [Thu, 20 Feb 2020 18:51:25 +0000 (10:51 -0800)]
Revert "[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject"
This reverts commit
726c342ce27ada28efe90cb04ffb69c75065710a.
This breaks the windows bots with linker errors.
River Riddle [Thu, 20 Feb 2020 18:31:44 +0000 (10:31 -0800)]
[mlir] Refactor the structure of the 'verifyConstructionInvariants' methods.
Summary:
The current structure suffers from several problems, but the main one is that a construction failure is impossible to debug when using the 'get' methods. This is because we only optionally emit errors, so there is no context given to the user about the problem. This revision restructures this so that errors are always emitted, and the 'get' methods simply pass in an UnknownLoc to emit to. This allows for removing usages of the more constrained "emitOptionalLoc", as well as removing the need for the context parameter.
Fixes [PR#44964](https://bugs.llvm.org/show_bug.cgi?id=44964)
Differential Revision: https://reviews.llvm.org/D74876
Francis Visoiu Mistrih [Wed, 19 Feb 2020 00:39:05 +0000 (16:39 -0800)]
[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject
This moves all the logic of converting LLVM Triples to
MachO::CPU_(SUB_)TYPE from the specific target (Target)AsmBackend to
more convenient functions in libObject.
This also gets rid of the separate two X86AsmBackend classes.
Differential Revision: https://reviews.llvm.org/D74808
Simon Pilgrim [Thu, 20 Feb 2020 18:22:45 +0000 (18:22 +0000)]
[DAGCombiner] Use SDValue::getConstantOperandAPInt helper where possible. NFC.
Jordan Rupprecht [Wed, 19 Feb 2020 20:01:09 +0000 (12:01 -0800)]
[lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY
Summary:
lldb's format string (line one) is:
`lldb version $clang_version ($lldb_repo revision $lldb_revision)`
When only using $lldb_revision and not $lldb_repo, this might look like:
`lldb version 11 ( revision 12345)`
which looks pretty ugly.
Aside: I'm not sure we really need all the different versions since we've moved to the monorepo layout -- I don't think anyone is using different llvm/clang/lldb revisions, are they? We could likely tidy this up further if we knew how people consumed the output of lldb --version.
Reviewers: labath, JDevlieghere, friss
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74859
Muhammad Omair Javaid [Thu, 20 Feb 2020 17:15:37 +0000 (22:15 +0500)]
Add target.xml support for qXfer request.
Summary:
Requesting registers one by one takes a while in our project.
We want to get rid of it by using target.xml.
Reviewers: jarin, labath, omjavaid
Reviewed By: labath, omjavaid
Subscribers: omjavaid, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74217
Louis Dionne [Thu, 20 Feb 2020 17:33:17 +0000 (12:33 -0500)]
[clang] Fix search path logic for C_INCLUDE_DIRS
For each absolute path given to C_INCLUDE_DIRS, we want it to be added
as-is to the include search path. Relative paths should be prefixed
with the sysroot.
Thanks to Marco Hinz for the patch.
Differential Revision: https://reviews.llvm.org/D69221
Craig Topper [Thu, 20 Feb 2020 17:27:18 +0000 (09:27 -0800)]
[X86] Fix a -Wparentheses warning. NFC
Eugene Zelenko [Thu, 20 Feb 2020 17:30:11 +0000 (17:30 +0000)]
[clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section
Summary:
Also use //check// in add_new_check.py for terminology consistency.
PS
My GitHub ID is [[ https://github.com/EugeneZelenko | EugeneZelenko ]], if it's necessary for attribution.
Reviewers: alexfh, hokein, aaron.ballman, njames93, MyDeveloperDay
Reviewed By: njames93
Subscribers: Andi, xazax.hun, cfe-commits
Tags: #clang-tools-extra, #clang
Differential Revision: https://reviews.llvm.org/D73580