platform/upstream/llvm.git
7 years agouse range-for-loops; NFCI
Sanjay Patel [Mon, 2 Oct 2017 15:02:06 +0000 (15:02 +0000)]
use range-for-loops; NFCI

llvm-svn: 314676

7 years ago[MIPS] Fix PLT entries generation in case of linking regular and microMIPS code
Simon Atanasyan [Mon, 2 Oct 2017 14:56:41 +0000 (14:56 +0000)]
[MIPS] Fix PLT entries generation in case of linking regular and microMIPS code

Currently LLD calls the `isMicroMips` routine to determine type of PLT entries
needs to be generated: regular or microMIPS. This routine checks ELF
header flags in the `FirstObj` to retrieve type of linked object files.
So if the first file does not contain microMIPS code, LLD will generate
PLT entries with regular (non-microMIPS) code only.

Ideally, if a PLT entry is referenced by microMIPS code only this entry
should contain microMIPS code, if a PLT entry is referenced by regular
code this entry should contain regular code. In a "mixed" case the PLT
entry can be either microMIPS or regular, but each "cross-mode-call" has
additional cost.

It's rather difficult to implement this ideal solution. But we can
assume that if there is an input object file with microMIPS code, the
most part of the code is microMIPS too. So we need to deduce type of PLT
entries based on finally calculated ELF header flags and do not check
only the first input object file.

This change implements this.
  - The `getMipsEFlags` renamed to the `calcMipsEFlags`. The function
    called from the `LinkerDriver::link`. Result is stored in
    the Configuration::MipsEFlags field.
  - The `isMicroMips` and `isMipsR6` routines access the `MipsEFlags`
    field to get and check calculated ELF flags.
  - New types of PLT records created when necessary.

Differential revision: https://reviews.llvm.org/D37747

llvm-svn: 314675

7 years ago[AsmParser] Support GAS's .print directive
Coby Tayree [Mon, 2 Oct 2017 14:36:31 +0000 (14:36 +0000)]
[AsmParser] Support GAS's .print directive

Differential Revision: https://reviews.llvm.org/D38448

llvm-svn: 314674

7 years ago[OPENMP] Fix test, NFC.
Alexey Bataev [Mon, 2 Oct 2017 14:35:31 +0000 (14:35 +0000)]
[OPENMP] Fix test, NFC.

llvm-svn: 314673

7 years agoImprove FreeBSD kernel debugging
Ed Maste [Mon, 2 Oct 2017 14:35:07 +0000 (14:35 +0000)]
Improve FreeBSD kernel debugging

FreeBSD kernel modules are actually relocatable (.o) ELF files and this
previously caused some issues for LLDB. This change addresses these when
using lldb to symbolicate FreeBSD kernel backtraces.

The major problems:

- Relocations were not being applied to the DWARF debug info despite
  there being code to do this. Several issues prevented it from working:

  - Relocations are computed at the same time as the symbol table, but
    in the case of split debug files, symbol table parsing always
    redirects to the primary object file, meaning that relocations would
    never be applied in the debug file.

  - There's actually no guarantee that the symbol table has been parsed
    yet when trying to parse debug information.

  - When actually applying relocations, it will segfault because the
    object files are not mapped with MAP_PRIVATE and PROT_WRITE.

- LLDB returned invalid results when performing ordinary address-to-
  symbol resolution. It turned out that the addresses specified in the
  section headers were all 0, so LLDB believed all the sections had
  overlapping "file addresses" and would sometimes return a symbol from
  the wrong section.

Patch by Brian Koropoff

Differential Revision: https://reviews.llvm.org/D38142

llvm-svn: 314672

7 years agoAdd support for custom loaders to the sanitizer symbolizer
Francis Ricci [Mon, 2 Oct 2017 14:30:58 +0000 (14:30 +0000)]
Add support for custom loaders to the sanitizer symbolizer

Summary:
Adds a fallback mode to procmaps when the symbolizer
fails to locate a module for a given address by using
dl_iterate_phdr.

Reviewers: kubamracek, rnk, vitalybuka, eugenis

Reviewed By: eugenis

Subscribers: srhines, llvm-commits

Differential Revision: https://reviews.llvm.org/D37269

llvm-svn: 314671

7 years ago[OPENMP] Simplify codegen for non-offloading code.
Alexey Bataev [Mon, 2 Oct 2017 14:20:58 +0000 (14:20 +0000)]
[OPENMP] Simplify codegen for non-offloading code.

Simplified and generalized codegen for non-offloading part that works if
offloading is failed or condition of the `if` clause is `false`.

llvm-svn: 314670

7 years agoremove duplicate comments, reposition related functions; NFC
Sanjay Patel [Mon, 2 Oct 2017 14:03:17 +0000 (14:03 +0000)]
remove duplicate comments, reposition related functions; NFC

llvm-svn: 314669

7 years agoDependent Address Space Support Test Fix
Andrew Gozillon [Mon, 2 Oct 2017 13:32:59 +0000 (13:32 +0000)]
Dependent Address Space Support Test Fix

Modifying a non-type template integer arguement that is causing errors
in some builds as it's too large for 32-bit longs. This hopefully (and
seems to when testing) should fix all of the build bot errors relating
to this test. I also modified the name of the function call to be more
apt.

Differential Revision: https://reviews.llvm.org/D33666

llvm-svn: 314668

7 years ago[X86][SSE] Fix -Wsign-compare problems introduced in r314658
Bjorn Pettersson [Mon, 2 Oct 2017 12:46:38 +0000 (12:46 +0000)]
[X86][SSE] Fix -Wsign-compare problems introduced in r314658

The refactoring in
"[X86][SSE] Add createPackShuffleMask helper function. NFCI."
resulted in warning when compiling the code (seen in build bots).

This patch restores some types from int to unsigned to avoid
those warnings.

llvm-svn: 314667

7 years ago[Debug info] Handle endianness when moving debug info for split integer values
Bjorn Pettersson [Mon, 2 Oct 2017 12:46:32 +0000 (12:46 +0000)]
[Debug info] Handle endianness when moving debug info for split integer values

Summary:
Take the target's endianness into account when splitting the
debug information in DAGTypeLegalizer::SetExpandedInteger.

This patch fixes so that, for big-endian targets, the fragment
expression corresponding to the high part of a split integer
value is placed at offset 0, in order to correctly represent
the memory address order.

I have attached a PPC32 reproducer where the resulting DWARF
pieces for a 64-bit integer were incorrectly reversed.

Patch by: dstenb

Reviewers: JDevlieghere, aprantl, dblaikie

Reviewed By: JDevlieghere, aprantl, dblaikie

Subscribers: nemanjai

Differential Revision: https://reviews.llvm.org/D38172

llvm-svn: 314666

7 years ago[ScopBuilder] Iterate over statement instructions. NFC.
Michael Kruse [Mon, 2 Oct 2017 11:41:33 +0000 (11:41 +0000)]
[ScopBuilder] Iterate over statement instructions. NFC.

Iterate over statement instructions instead over basic block
instructions when creating MemoryAccesses. It allows making the creation
of MemoryAccesses independent of how the basic blocks are split into
multiple ScopStmts.

llvm-svn: 314665

7 years ago[ScopBuilder] Build invariant loads separately.
Michael Kruse [Mon, 2 Oct 2017 11:41:27 +0000 (11:41 +0000)]
[ScopBuilder] Build invariant loads separately.

Create the MemoryAccesses of invariant loads separately and before
all other MemoryAccesses.

Invariant loads are classified as synthesizable and therefore are not
contained in any statement. When iterating over all instructions of all
statements, the invariant loads are consequently not processed and
iterating over them separately becomes necessary.

This patch can change the order in which MemoryAccesses are created, but
otherwise has no functional change.

Some temporary code is introduced to ensure correctness, but will be
removed in the next commit.

llvm-svn: 314664

7 years ago[ScopBuilder] Build escaping dependencies separately.
Michael Kruse [Mon, 2 Oct 2017 11:41:19 +0000 (11:41 +0000)]
[ScopBuilder] Build escaping dependencies separately.

Instructions that compute escaping values might be synthesizable and
therefore not contained in any ScopStmt. When buildAccessFunctions is
changed to only iterate over the instruction list of statement,
"free" instructions still need to be written. We do this after the
main MemoryAccesses have been created.

This can change the order in which MemoryAccesses are created, but has
otherwise no functional change.

llvm-svn: 314663

7 years ago[ScopBuilder] Specialize exit block handling. NFC.
Michael Kruse [Mon, 2 Oct 2017 11:41:12 +0000 (11:41 +0000)]
[ScopBuilder] Specialize exit block handling. NFC.

Decouple handling of exit block PHIs and other MemoryAccesses. Exit PHIs
only need the PHI handling part of buildAccessFunctions but requires
code for skipping them in while creating other MemoryAcesses.

This change will make it easier to modify how statement MemoryAccesses
are created without considering the exit block special case.

llvm-svn: 314662

7 years ago[ForwardOpTree] Fix out-of-quota in assertion.
Michael Kruse [Mon, 2 Oct 2017 11:41:06 +0000 (11:41 +0000)]
[ForwardOpTree] Fix out-of-quota in assertion.

llvm-svn: 314661

7 years ago[CodeGen] Have a special function to get TBAA info for may-alias accesses
Ivan A. Kosarev [Mon, 2 Oct 2017 11:10:04 +0000 (11:10 +0000)]
[CodeGen] Have a special function to get TBAA info for may-alias accesses

This is part of D37826 reworked to be a separate patch to
simplify review.

Differential Revision: https://reviews.llvm.org/D38408

llvm-svn: 314660

7 years agoUse %run for running CFI tests
Filipe Cabecinhas [Mon, 2 Oct 2017 10:21:26 +0000 (10:21 +0000)]
Use %run for running CFI tests

Reviewers: pcc, krasin, eugenis

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D38412

llvm-svn: 314659

7 years ago[X86][SSE] Add createPackShuffleMask helper function. NFCI.
Simon Pilgrim [Mon, 2 Oct 2017 10:12:51 +0000 (10:12 +0000)]
[X86][SSE] Add createPackShuffleMask helper function. NFCI.

llvm-svn: 314658

7 years ago[CodeGen] Do not refer to complete TBAA info where we actually deal with just TBAA...
Ivan A. Kosarev [Mon, 2 Oct 2017 09:54:47 +0000 (09:54 +0000)]
[CodeGen] Do not refer to complete TBAA info where we actually deal with just TBAA access types

This patch fixes misleading names of entities related to getting,
setting and generation of TBAA access type descriptors.

This is effectively an attempt to provide a review for D37826 by
breaking it into smaller pieces.

Differential Revision: https://reviews.llvm.org/D38404

llvm-svn: 314657

7 years ago[X86][SSE] matchBinaryVectorShuffle - add support for different src/dst value shuffle...
Simon Pilgrim [Mon, 2 Oct 2017 09:45:08 +0000 (09:45 +0000)]
[X86][SSE] matchBinaryVectorShuffle - add support for different src/dst value shuffle types

Preparation for support for combining to PACKSS/PACKUS

llvm-svn: 314656

7 years ago[PowerPC] support ZERO_EXTEND in tryBitPermutation
Hiroshi Inoue [Mon, 2 Oct 2017 09:24:00 +0000 (09:24 +0000)]
[PowerPC] support ZERO_EXTEND in tryBitPermutation

This patch add a support of ISD::ZERO_EXTEND in PPCDAGToDAGISel::tryBitPermutation to increase the opportunity to use rotate-and-mask by reordering ZEXT and ANDI.
Since tryBitPermutation stops analyzing nodes if it hits a ZEXT node while traversing SDNodes, we want to avoid ZEXT between two nodes that can be folded into a rotate-and-mask instruction.

For example, we allow these nodes

      t9: i32 = add t7, Constant:i32<1>
    t11: i32 = and t9, Constant:i32<255>
  t12: i64 = zero_extend t11
t14: i64 = shl t12, Constant:i64<2>

to be folded into a rotate-and-mask instruction.
Such case often happens in array accesses with logical AND operation in the index, e.g. array[i & 0xFF];

Differential Revision: https://reviews.llvm.org/D37514

llvm-svn: 314655

7 years ago[ELF] - Stop removing sections in removeUnusedSyntheticSections().
George Rimar [Mon, 2 Oct 2017 09:11:13 +0000 (09:11 +0000)]
[ELF] - Stop removing sections in removeUnusedSyntheticSections().

That makes code a bit more consistent. Instead of removing sections there
we can just mark them as dead. So that removeEmptyCommands() will
handle the rest.

Differential revision: https://reviews.llvm.org/D38393

llvm-svn: 314654

7 years agoFix typo in comment. NFCI.
Simon Pilgrim [Mon, 2 Oct 2017 09:10:50 +0000 (09:10 +0000)]
Fix typo in comment. NFCI.

llvm-svn: 314653

7 years ago[X86] Cleanup uses of computeKnownBits by using MaskedValueIsZero helper instead...
Simon Pilgrim [Mon, 2 Oct 2017 09:08:45 +0000 (09:08 +0000)]
[X86] Cleanup uses of computeKnownBits by using MaskedValueIsZero helper instead. NFCI.

llvm-svn: 314652

7 years ago[X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess...
Michael Zuckerman [Mon, 2 Oct 2017 07:35:25 +0000 (07:35 +0000)]
[X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3-4)
I continue to support different VF interleaved and in this pass for this patch,
I added the vf64 stride3 support for both load and store.
I also added support fot the stride4 store.

Reviewers:
1. zvi
2. dorit
3. igorb
4. guyblank

Differential Revision: https://reviews.llvm.org/D37687

Change-Id: I3d238efedf217d1768b348d710de1efa2f19d27b
llvm-svn: 314651

7 years agoDependent Address Space Support Test File
Andrew Gozillon [Mon, 2 Oct 2017 06:31:25 +0000 (06:31 +0000)]
Dependent Address Space Support Test File

Adding regression test for Dependent Address Spaces in relation to
https://reviews.llvm.org/D33666 I forgot to svn add the test file
before commiting the prior changes. I appologies.

llvm-svn: 314650

7 years agoDependent Address Space Support
Andrew Gozillon [Mon, 2 Oct 2017 06:25:51 +0000 (06:25 +0000)]
Dependent Address Space Support

This patch relates to: https://reviews.llvm.org/D33666 This adds support
for template parameters to be passed to the address_space attribute.
The main goal is to add further flexibility to the attribute and allow
for it to be used easily with templates.

The main additions are a new type (DependentAddressSpaceType) alongside
its TypeLoc and its mangling. As well as the logic required to support
dependent address spaces which mainly resides in TreeTransform.h and
SemaType.cpp.

llvm-svn: 314649

7 years ago[X86] Fix copy pasto in X86FastISel::fastEmitInst_rrrr.
Craig Topper [Mon, 2 Oct 2017 05:46:53 +0000 (05:46 +0000)]
[X86] Fix copy pasto in X86FastISel::fastEmitInst_rrrr.

The 4th operand was not being constrained and the third operand was being constrained twice.

llvm-svn: 314648

7 years ago[X86] Use a bool flag instead of assigning an unsigned to two different values that...
Craig Topper [Mon, 2 Oct 2017 05:46:52 +0000 (05:46 +0000)]
[X86] Use a bool flag instead of assigning an unsigned to two different values that we only use in an equality comparison.

llvm-svn: 314647

7 years ago[cmake] Add a separate CMake var to control profile runtime
Michal Gorny [Mon, 2 Oct 2017 05:03:55 +0000 (05:03 +0000)]
[cmake] Add a separate CMake var to control profile runtime

Make it possible to control building profile runtime separately from
other options. Before r313549, the profile runtime building was
controlled along with sanitizers. However, since that commit it is built
unconditionally which results in multiple builds for people building
different runtimes separately.

Differential Revision: https://reviews.llvm.org/D38441

llvm-svn: 314646

7 years agoUpdate for LLVM change.
Rui Ueyama [Mon, 2 Oct 2017 02:09:58 +0000 (02:09 +0000)]
Update for LLVM change.

r314639 ([X86] Change register&memory TEST instructions from MRMSrcMem
to MRMDstMem) broke the test.

llvm-svn: 314645

7 years ago[ICF] Include section contents in section hash values.
Rui Ueyama [Mon, 2 Oct 2017 01:21:07 +0000 (01:21 +0000)]
[ICF] Include section contents in section hash values.

Computing section content hashes early seems like a win in terms of
performance. It increases a chance that two different sections will get
different class IDs from the beginning.

Without threads, this patch improves Chromium link time by about 0.3
seconds. With threads, by 0.1 seconds. That's less than 1% time saving
but not bad for a small patch.

llvm-svn: 314644

7 years ago[X86] Use _NOREX MOVZX instructions for some patterns even in 32-bit mode.
Craig Topper [Mon, 2 Oct 2017 00:44:50 +0000 (00:44 +0000)]
[X86] Use _NOREX MOVZX instructions for some patterns even in 32-bit mode.

This unifies the patterns between both modes. This should be effectively NFC since all the available registers in 32-bit mode statisfy this constraint.

llvm-svn: 314643

7 years ago[Hexagon] Check vector elements for equivalence in the HexagonVectorLoopCarriedReuse...
Ron Lieberman [Mon, 2 Oct 2017 00:34:07 +0000 (00:34 +0000)]
[Hexagon] Check vector elements for equivalence in the HexagonVectorLoopCarriedReuse pass

    If the two instructions being compared for equivalence have corresponding operands
    that are integer constants, then check their values to determine equivalence.

    Patch by Suyog Sarda!

llvm-svn: 314642

7 years ago[Hexagon] Patch to Extract i1 element from vector of i1
Ron Lieberman [Mon, 2 Oct 2017 00:16:15 +0000 (00:16 +0000)]
[Hexagon] Patch to Extract i1 element from vector of i1

This patch extracts 1 element from vector consisting
of elements of size 1 bit at given index.

llvm-svn: 314641

7 years ago[InstCombine] Use APInt for all the math in foldICmpDivConstant
Craig Topper [Sun, 1 Oct 2017 23:53:54 +0000 (23:53 +0000)]
[InstCombine] Use APInt for all the math in foldICmpDivConstant

Summary: This currently uses ConstantExpr to do its math, but as noted in a TODO it can all be done directly on APInt.

Reviewers: spatel, majnemer

Reviewed By: majnemer

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D38440

llvm-svn: 314640

7 years ago[X86] Change register&memory TEST instructions from MRMSrcMem to MRMDstMem
Craig Topper [Sun, 1 Oct 2017 23:53:53 +0000 (23:53 +0000)]
[X86] Change register&memory TEST instructions from MRMSrcMem to MRMDstMem

Summary:
Intel documentation shows the memory operand as the first operand. But we currently treat it as the second operand. Conceptually the order doesn't matter since it doesn't write memory. We have aliases to parse with the operands in either order and the isel matching is commutable.

For the register&register form order does matter for the assembly parser. PR22995 was previously filed and fixed by changing the register&register form from MRMSrcReg to MRMDestReg to match gas. Ideally the memory form should match by using MRMDestMem.

I believe this supercedes D38025 which was trying to switch the register&register form back to pre-PR22995.

Reviewers: aymanmus, RKSimon, zvi

Reviewed By: aymanmus

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D38120

llvm-svn: 314639

7 years ago[X86] Remove a couple unnecessary COPY_TO_REGCLASS from some output patterns where...
Craig Topper [Sun, 1 Oct 2017 23:53:50 +0000 (23:53 +0000)]
[X86] Remove a couple unnecessary COPY_TO_REGCLASS from some output patterns where the instruction already produces the correct register class.

llvm-svn: 314638

7 years agoInline hot functions.
Rui Ueyama [Sun, 1 Oct 2017 23:46:31 +0000 (23:46 +0000)]
Inline hot functions.

llvm-svn: 314637

7 years ago[ScopDetect] Do not add loads out of the SCoP to required invariant loads.
Michael Kruse [Sun, 1 Oct 2017 22:19:28 +0000 (22:19 +0000)]
[ScopDetect] Do not add loads out of the SCoP to required invariant loads.

Loads before the SCoP are always invariant within the SCoP and
therefore are no "required invariant loads". An assertion failes in
ScopBuilder when it finds such an invariant load.

Fix by not adding such loads to the required invariant load list. This
likely will cause the region to be not considered a valid SCoP.
We may want to unconditionally accept instructions defined before
the region as valid invariant conditions instead of rejecting them.

This fixes a compilation crash of SPEC CPU2006 453.povray's
render.cpp.

llvm-svn: 314636

7 years agoSjLj: Fix building after SVN r314632
Martin Storsjo [Sun, 1 Oct 2017 20:22:40 +0000 (20:22 +0000)]
SjLj: Fix building after SVN r314632

The code moved from Unwind_AppleExtras.cpp to Unwind-sjlj.c needed
a few minor modifications to build as C instead of C++.

llvm-svn: 314635

7 years agoLet get_work_dim take exactly 0 arguments
Jeroen Ketema [Sun, 1 Oct 2017 20:11:46 +0000 (20:11 +0000)]
Let get_work_dim take exactly 0 arguments

Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
llvm-svn: 314634

7 years agoDo no circularly define NULL
Jeroen Ketema [Sun, 1 Oct 2017 20:10:14 +0000 (20:10 +0000)]
Do no circularly define NULL

Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
llvm-svn: 314633

7 years agoSjLj: make the SjLj implementation more portable
Saleem Abdulrasool [Sun, 1 Oct 2017 20:06:48 +0000 (20:06 +0000)]
SjLj: make the SjLj implementation more portable

This moves the definition of the internal helpers
`__Unwind_SjLj_GetTopOfFunctionStack` and
`__Unwind_SjLj_SetTopOfFunctionStack` into `Unwind-sjlj.c`.  These are
not extra functions specific to Apple, but rather are internal
implementation details of SjLj support in the LLVM libunwind
implementation.

This allows us to remove the internal header unwind_ext.h, as these
functions are not meant to be used as SPI either.  Because they are
static, they will be given implicit hidden visibility, but due to the
simplicity should get fully inlined into the actual use.

Use the C11 standard static TLS annotation (`_Thread_local`) if
possible, otherwise, use the Windows specific `__declspec(thread)` when
targeting Windows or the GNU `__thread` extension.  In theory, it should
be possible for this implementation to use a `pthread_setspecific` and
`pthread_getspecific` on platforms with pthreads or `SetFlsValue` and
`GetFlsValue` on Windows for non-static TLS.  However, static TLS tends
to be significantly faster, so we really should prefer that over the
dynamic TLS approach.  On Apple environments, when not building for the
loader (dyld), use the pre-allocated TLS slot in the loader rather than
the local static TLS variable.

Note that the un-threaded support of libunwind is still present as
before, however, it is unsafe to use in a threaded environment as the
cleanup stack may be mutated incorrectly due to lack of locking across
threads.  In the static TLS model, the lock is unneeded as each thread
of execution retains its own copy of the cleanup stack.

Take the opportunity to clean up the comment block, removing the iOS
specific note as the SjLj implementation can be used outside of the
context of iOS.  Convert the rest of the explanation to a doxygen style
comment block.

llvm-svn: 314632

7 years ago[X86][SSE] Add faux shuffle combining support for PACKUS
Simon Pilgrim [Sun, 1 Oct 2017 18:43:48 +0000 (18:43 +0000)]
[X86][SSE] Add faux shuffle combining support for PACKUS

llvm-svn: 314631

7 years ago[X86][AVX2] Simplify PACKUS combine test
Simon Pilgrim [Sun, 1 Oct 2017 18:17:39 +0000 (18:17 +0000)]
[X86][AVX2] Simplify PACKUS combine test

Trying to use a AND mask is tricky as after legalization its nigh impossible for computeKnownBits to do anything with it

llvm-svn: 314630

7 years ago[X86][SSE] Improve shuffle combining of PACKSS instructions.
Simon Pilgrim [Sun, 1 Oct 2017 17:54:55 +0000 (17:54 +0000)]
[X86][SSE] Improve shuffle combining of PACKSS instructions.

Support unary packing and fix the faux shuffle mask for vectors larger than 128 bits.

llvm-svn: 314629

7 years ago[X86][SSE] Add shuffle combining tests with PACKSS/PACKUS
Simon Pilgrim [Sun, 1 Oct 2017 17:30:44 +0000 (17:30 +0000)]
[X86][SSE] Add shuffle combining tests with PACKSS/PACKUS

llvm-svn: 314628

7 years ago[x86] formatting; NFC
Sanjay Patel [Sun, 1 Oct 2017 14:39:10 +0000 (14:39 +0000)]
[x86] formatting; NFC

llvm-svn: 314627

7 years agopre-commit adding test for broadcastm pattern
Jina Nahias [Sun, 1 Oct 2017 14:25:21 +0000 (14:25 +0000)]
pre-commit adding test for broadcastm pattern

Differential Revision: https://reviews.llvm.org/D38312

Change-Id: Ifbc4189549f2f59995019a86f85f989c04e4d37d
llvm-svn: 314626

7 years agoAdd missing REQUIRES line
Tobias Grosser [Sun, 1 Oct 2017 13:14:40 +0000 (13:14 +0000)]
Add missing REQUIRES line

llvm-svn: 314625

7 years ago[GPGPU] Set Polly's RTC to false in case invariant load hoisting fails
Tobias Grosser [Sun, 1 Oct 2017 12:39:14 +0000 (12:39 +0000)]
[GPGPU] Set Polly's RTC to false in case invariant load hoisting fails

This matches the behavior we already have in lib/Codegen/CodeGeneration.cpp and
makes sure that we fall back to the original code. It seems when invariant load
hoisting was introduced to the GPGPU backend we missed to reset the RTC flag,
such that kernels where invariant load hoisting failed executed the 'optimized'
SCoP, which however is set to a simple 'unreachable'. Unsurprisingly, this
results in hard to debug issues that are a lot of fun to debug.

llvm-svn: 314624

7 years agoTest Commit.
Andrew Gozillon [Sun, 1 Oct 2017 12:16:24 +0000 (12:16 +0000)]
Test Commit.

llvm-svn: 314623

7 years agoRevert r314579: "Recommi r314561 after fixing over-debug assertion".
Daniel Jasper [Sun, 1 Oct 2017 09:53:53 +0000 (09:53 +0000)]
Revert r314579: "Recommi r314561 after fixing over-debug assertion".

And follow-up r314585.
Leads to segfaults. I'll forward reproduction instructions to the patch
author.

Also, for a recommit, still add the original patch description.
Otherwise, it becomes really tedious to find out what a patch actually
does. The fact that it is a recommit with a fix is somewhat secondary.

llvm-svn: 314622

7 years agoAdding test for interleved, case stride 4 vf64 store<NFC>.
Michael Zuckerman [Sun, 1 Oct 2017 09:37:38 +0000 (09:37 +0000)]
Adding test for interleved, case stride 4 vf64 store<NFC>.

Change-Id: I9ea62aac81b763c83d26613dca6fcd846997a017
llvm-svn: 314621

7 years ago[lit] Fix running lit tests in unconfigured source dir
Michal Gorny [Sun, 1 Oct 2017 07:13:25 +0000 (07:13 +0000)]
[lit] Fix running lit tests in unconfigured source dir

Fix llvm_tools_dir attribute access not to fail when the variable is not
present. This directory is not really necessary to run lit tests,
and the code already accounts for it being None.

The reference was added in r313407, and it breaks the stand-alone lit
package in Gentoo.

Differential Revision: https://reviews.llvm.org/D38442

llvm-svn: 314620

7 years agoSeparate the logic when handling indirect calls in SamplePGO ThinLTO compile phase...
Dehao Chen [Sun, 1 Oct 2017 05:24:51 +0000 (05:24 +0000)]
Separate the logic when handling indirect calls in SamplePGO ThinLTO compile phase and other phases.

Summary: In SamplePGO ThinLTO compile phase, we will not invoke ICP as it may introduce confusion to the 2nd annotation. This patch extracted that logic and makes it clearer before profile annotation. In the mean time, we need to make function importing process both inlined callsites as well as not promoted indirect callsites.

Reviewers: tejohnson

Reviewed By: tejohnson

Subscribers: sanjoy, mehdi_amini, llvm-commits, inglorion

Differential Revision: https://reviews.llvm.org/D38094

llvm-svn: 314619

7 years agoFix .rst formatting error.
Rui Ueyama [Sun, 1 Oct 2017 03:50:48 +0000 (03:50 +0000)]
Fix .rst formatting error.

llvm-svn: 314618

7 years agoUpdate benchmark numbers.
Rui Ueyama [Sun, 1 Oct 2017 03:47:02 +0000 (03:47 +0000)]
Update benchmark numbers.

llvm-svn: 314617

7 years agoRun writeTo() concurrently.
Rui Ueyama [Sun, 1 Oct 2017 02:25:34 +0000 (02:25 +0000)]
Run writeTo() concurrently.

I don't know why we didn't use parallelForEach to call writeTo,
but there should be no reason to not do that, as most writeTo
functions are safe to run concurrently.

llvm-svn: 314616

7 years agoFix typo. NFC
Xin Tong [Sun, 1 Oct 2017 00:10:52 +0000 (00:10 +0000)]
Fix typo. NFC

llvm-svn: 314615

7 years agoRevert "Fix typo [NFC]"
Xin Tong [Sun, 1 Oct 2017 00:09:53 +0000 (00:09 +0000)]
Revert "Fix typo [NFC]"

This reverts commit e60b5028619be1c81bd039d63a0627dac32d38f9.

Incorrectly include changes that are not typo fix.

llvm-svn: 314614

7 years agoFix typo [NFC]
Xin Tong [Sun, 1 Oct 2017 00:07:24 +0000 (00:07 +0000)]
Fix typo [NFC]

llvm-svn: 314613

7 years agoNewGVN: Fix PR 34473, by not using ExactlyEqualsExpression for finding
Daniel Berlin [Sat, 30 Sep 2017 23:51:55 +0000 (23:51 +0000)]
NewGVN: Fix PR 34473, by not using ExactlyEqualsExpression for finding
phi of ops users.

llvm-svn: 314612

7 years agoNewGVN: Evaluate phi of ops expressions before creating phi node
Daniel Berlin [Sat, 30 Sep 2017 23:51:54 +0000 (23:51 +0000)]
NewGVN: Evaluate phi of ops expressions before creating phi node

llvm-svn: 314611

7 years agoNewGVN: Allow dependent PHI of ops
Daniel Berlin [Sat, 30 Sep 2017 23:51:53 +0000 (23:51 +0000)]
NewGVN: Allow dependent PHI of ops

llvm-svn: 314610

7 years agoNewGVN: Make OpIsSafeForPhiOfOps non-recursive
Daniel Berlin [Sat, 30 Sep 2017 23:51:04 +0000 (23:51 +0000)]
NewGVN: Make OpIsSafeForPhiOfOps non-recursive

llvm-svn: 314609

7 years ago[test] Allow other implementations to strengthen noexcept on deque's move constructor
Casey Carter [Sat, 30 Sep 2017 23:15:22 +0000 (23:15 +0000)]
[test] Allow other implementations to strengthen noexcept on deque's move constructor

llvm-svn: 314608

7 years agoRegenerate mul combine tests to update broadcast comment.
Simon Pilgrim [Sat, 30 Sep 2017 22:27:46 +0000 (22:27 +0000)]
Regenerate mul combine tests to update broadcast comment.

llvm-svn: 314607

7 years ago[lldb-mi] Fix a thinko in my previous commit.
Davide Italiano [Sat, 30 Sep 2017 21:52:31 +0000 (21:52 +0000)]
[lldb-mi] Fix a thinko in my previous commit.

Hopefully this should unbreak the Android buildbot.

llvm-svn: 314606

7 years ago[Analysis] Remove unused makeLvalueToRValue variant.
Davide Italiano [Sat, 30 Sep 2017 21:49:15 +0000 (21:49 +0000)]
[Analysis] Remove unused makeLvalueToRValue variant.

llvm-svn: 314605

7 years ago[lldb-mi] Add a default case to placate GCC with -Werror.
Davide Italiano [Sat, 30 Sep 2017 21:30:41 +0000 (21:30 +0000)]
[lldb-mi] Add a default case to placate GCC with -Werror.

llvm-svn: 314604

7 years agoFix 32-bit buildbots.
Rui Ueyama [Sat, 30 Sep 2017 21:28:49 +0000 (21:28 +0000)]
Fix 32-bit buildbots.

The result of hash_value(StringRef) depends on sizeof(size_t).
That causes lld to create different mergeable table contents on
32-bit machines.

This patch is to use xxHash64 so that we get the same hash values
on 32-bit machines.

llvm-svn: 314603

7 years ago[ExpressionParser] Prefer isa<> to dyn_cast<>. NFCI.
Davide Italiano [Sat, 30 Sep 2017 21:16:56 +0000 (21:16 +0000)]
[ExpressionParser] Prefer isa<> to dyn_cast<>. NFCI.

The result type is unused anyway.

llvm-svn: 314602

7 years agoRefactor the SamplePGO profile annotation logic to extract inlineCallInstruction...
Dehao Chen [Sat, 30 Sep 2017 20:46:15 +0000 (20:46 +0000)]
Refactor the SamplePGO profile annotation logic to extract inlineCallInstruction. (NFC)

llvm-svn: 314601

7 years ago[NFC] Add assertion that we assume a valid macro argument index.
Faisal Vali [Sat, 30 Sep 2017 19:34:27 +0000 (19:34 +0000)]
[NFC] Add assertion that we assume a valid macro argument index.

llvm-svn: 314600

7 years ago[X86][SSE] Fold (VSRAI (VSHLI X, C1), C1) --> X iff NumSignBits(X) > C1
Simon Pilgrim [Sat, 30 Sep 2017 17:57:34 +0000 (17:57 +0000)]
[X86][SSE] Fold (VSRAI (VSHLI X, C1), C1) --> X iff NumSignBits(X) > C1

Remove sign extend in register style pattern if the sign is already extended enough

llvm-svn: 314599

7 years ago[AVX-512] Add patterns to make fp compare instructions commutable during isel.
Craig Topper [Sat, 30 Sep 2017 17:02:39 +0000 (17:02 +0000)]
[AVX-512] Add patterns to make fp compare instructions commutable during isel.

llvm-svn: 314598

7 years ago[X86][SSE] Add vector truncation cases inspired by PR34773
Simon Pilgrim [Sat, 30 Sep 2017 16:14:59 +0000 (16:14 +0000)]
[X86][SSE] Add vector truncation cases inspired by PR34773

We should be using PACKSS/PACKUS more aggressively when we know the state of the upper bits

llvm-svn: 314597

7 years agoCode refactoring for the interleaved code <NFC>
Michael Zuckerman [Sat, 30 Sep 2017 14:55:03 +0000 (14:55 +0000)]
Code refactoring for the interleaved code <NFC>

Change-Id: I7831c9febad8e14278a5bc87584a0053dc837be1
llvm-svn: 314596

7 years ago[NFC] Sync function call with changes to interface made in r314593.
Faisal Vali [Sat, 30 Sep 2017 14:36:00 +0000 (14:36 +0000)]
[NFC] Sync function call with changes to interface made in r314593.

llvm-svn: 314595

7 years ago[X86][SKX] Added codegen regression test for avx512 instructions scheduling.NFC.
Gadi Haber [Sat, 30 Sep 2017 14:30:23 +0000 (14:30 +0000)]
[X86][SKX] Added codegen regression test for avx512 instructions scheduling.NFC.

NFC.
 Added code gen regression tests for avx512 instructions scheduling called avx512-schedule.ll and
 avx512-shuffle-schedule.ll.
 This patch is in preparation of a larger patch of adding all SKX instruction scheduling and therefore
 the scheduling for the avx512 instructions are still missing.

Reviewers: zvi, delena, RKSimon, igorb
Differential Revision: https://reviews.llvm.org/D38035

Change-Id: I792762763127a921b9e13684b58af03646536533
llvm-svn: 314594

7 years ago[NFC] Remove superfluous parameter
Faisal Vali [Sat, 30 Sep 2017 13:58:38 +0000 (13:58 +0000)]
[NFC] Remove superfluous parameter
 - MacroArgs already knows the maximum number of arguments that can be supplied to the macro.  No need to pass MacroInfo (information about the macro definition) to the call to getPreExpArgument (which by the way might benefit from being called getExpandedArgument() ?) for it to compute the number of arguments.

llvm-svn: 314593

7 years agoSyntheticSections.cpp: Appease g++-4.8, s/const/constexpr/
NAKAMURA Takumi [Sat, 30 Sep 2017 13:40:22 +0000 (13:40 +0000)]
SyntheticSections.cpp: Appease g++-4.8, s/const/constexpr/

llvm-svn: 314592

7 years agoMake parameter lists of SymbolTable::add* functions more consistent. NFC.
Rui Ueyama [Sat, 30 Sep 2017 12:41:34 +0000 (12:41 +0000)]
Make parameter lists of SymbolTable::add* functions more consistent. NFC.

llvm-svn: 314591

7 years agoFix buildbots.
Rui Ueyama [Sat, 30 Sep 2017 12:19:08 +0000 (12:19 +0000)]
Fix buildbots.

llvm-svn: 314590

7 years agoRevert r314435: "[JumpThreading] Preserve DT and LVI across the pass"
Daniel Jasper [Sat, 30 Sep 2017 11:57:19 +0000 (11:57 +0000)]
Revert r314435: "[JumpThreading] Preserve DT and LVI across the pass"

Causes a segfault on a builtbot (and in our internal bootstrapping of
Clang). See Eli's response on the commit thread.

llvm-svn: 314589

7 years agoParallelize string merging.
Rui Ueyama [Sat, 30 Sep 2017 11:46:26 +0000 (11:46 +0000)]
Parallelize string merging.

String merging is one of the most time-consuming functions in lld.
This patch parallelize it to speed it up. On my 2-socket 20-core
40-threads Xeon E5-2680 @ 2.8 GHz machine, this patch shorten the
clang debug build link time from 7.11s to 5.16s. It's a 27%
improvement and actually pretty noticeable. In this test condition,
lld is now 4x faster than gold.

Differential Revision: https://reviews.llvm.org/D38266

llvm-svn: 314588

7 years ago[clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC
Sam McCall [Sat, 30 Sep 2017 10:08:52 +0000 (10:08 +0000)]
[clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

Summary:
There doesn't seem to be any real separation between the current three objects.
Feel free to reject this if you find the current style valuable, though.

(Mostly I'm just looking around for cleanups to help me understand the code).

Reviewers: ilya-biryukov

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D38414

llvm-svn: 314587

7 years agoclang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting *-win32.
NAKAMURA Takumi [Sat, 30 Sep 2017 09:16:41 +0000 (09:16 +0000)]
clang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting *-win32.

This expects the warning;

  File clang/test/SemaCXX/ms-iunknown-template-function.cpp Line 19: __declspec attribute 'novtable' is not supported

But for targeting *-win32, the warning is not seen.

  error: 'warning' diagnostics expected but not seen:
    File clang\test\SemaCXX\ms-iunknown-template-function.cpp Line 19 (directive at clang\test\SemaCXX\ms-iunknown-template-function.cpp:18): __declspec attribute 'novtable'

llvm-svn: 314586

7 years agoFix buildbot failure -- tighten type check for matching phi
Xinliang David Li [Sat, 30 Sep 2017 05:27:46 +0000 (05:27 +0000)]
Fix buildbot failure -- tighten type check for matching phi

llvm-svn: 314585

7 years ago[X86] Support v64i8 mulhu/mulhs
Craig Topper [Sat, 30 Sep 2017 04:21:46 +0000 (04:21 +0000)]
[X86] Support v64i8 mulhu/mulhs

Implemented by splitting into two v32i8 mulhu/mulhs and concatenating the results.

Differential Revision: https://reviews.llvm.org/D38307

llvm-svn: 314584

7 years ago[ODRHash] Add base classes to hashing CXXRecordDecl.
Richard Trieu [Sat, 30 Sep 2017 02:19:17 +0000 (02:19 +0000)]
[ODRHash] Add base classes to hashing CXXRecordDecl.

llvm-svn: 314581

7 years ago[Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests.
George Karpenkov [Sat, 30 Sep 2017 01:15:35 +0000 (01:15 +0000)]
[Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests.

llvm-svn: 314580

7 years agoRecommi r314561 after fixing over-debug assertion
Xinliang David Li [Sat, 30 Sep 2017 00:46:32 +0000 (00:46 +0000)]
Recommi r314561 after fixing over-debug assertion

llvm-svn: 314579

7 years ago[llvm-rc] Serialize DIALOG(EX) to .res files (serialization, pt 4).
Marek Sokolowski [Sat, 30 Sep 2017 00:38:52 +0000 (00:38 +0000)]
[llvm-rc] Serialize DIALOG(EX) to .res files (serialization, pt 4).

This is now able to serialize DIALOG and DIALOGEX resources to .res
files. It still can't parse dialog-specific CAPTION, FONT, and STYLE
optional statement - these will be added in the following patch.

A limited set of controls is included. However, more can be easily added
by extending SupportedCtls map defined in ResourceScriptStmt.cpp.

Differential Revision: https://reviews.llvm.org/D37862

llvm-svn: 314578

7 years agotypos
Adrian Prantl [Sat, 30 Sep 2017 00:31:15 +0000 (00:31 +0000)]
typos

llvm-svn: 314577

7 years agollvm-dwarfdump: implement the --name lookup option.
Adrian Prantl [Sat, 30 Sep 2017 00:22:25 +0000 (00:22 +0000)]
llvm-dwarfdump: implement the --name lookup option.

llvm-svn: 314576

7 years agoFix 80 column violations
Adrian Prantl [Sat, 30 Sep 2017 00:22:24 +0000 (00:22 +0000)]
Fix 80 column violations

llvm-svn: 314575