박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 21 Sep 2018 01:27:10 +0000 (10:27 +0900)]
Introduce list_subdirectories (#1611)
This commit extracts list_subdirectories function from
add_subdirectories, and re-implements add_subdirectories using
list_subdirectories.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 21 Sep 2018 01:26:56 +0000 (10:26 +0900)]
[enco] Do NOT use GenericFeatureLayout in NNAPI backend (#1612)
This commit replaces all the use of GenericFeatureLayout inside NNAPI
backend implementation with optimized BHWC layout.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 23:57:37 +0000 (08:57 +0900)]
[coco] Introduce BHWC Feature Layout (#1601)
This commit implements BHWC Feature Layout class, which may speed up
some model import/codegen phase.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 23:51:58 +0000 (08:51 +0900)]
[coco] Instr::Visitor as abstract class (instead of interface) (#1605)
This commit introduces pure virtual Instr::IVisitor interface, and
revises Instr::Vistor as abstract class.
This change aims to minimize changes upon Instr extension.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 23:51:50 +0000 (08:51 +0900)]
[enco] Throw an exception on unknown operand type (#1606)
The current implementation assumes that operand is either scalar or
tensor and validates it through assert.
This commit explicitly validates dynamic casted pointer, which allows us
to detect such an abnormal case even for release build.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 23:51:26 +0000 (08:51 +0900)]
[enco] Catch std::exception instead of std::runtime_error (#1607)
The current implementation catches std::runtime_error, and thus failed
to catch other exceptions such as std::invalid_argument.
This commit revises catch statement to catch std::exception which is a
base class for a wide range of exceptions including
std::invalid_argument.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Fix build for install target (#1609)
* Fix build for install target
Signed-off-by: Roman Rusyaev <r.rusyaev@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 10:08:17 +0000 (19:08 +0900)]
Add OptionalTargetTools module (#1590)
This commit introduces OptionalTargetTools module which provides
optional_target_link_libraries macro, and revises
nncc_target_link_libraries to use this macro.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 08:30:00 +0000 (17:30 +0900)]
[nncc.core] Return a uint32_t value on num_elements call (#1604)
Now, num_elements functions return a uint32_t value instead of a uint64_t
value.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 08:29:52 +0000 (17:29 +0900)]
[nnop] Explicit cast to int64_t (#1603)
This commit inserts explicit cast to int64_t (from uint32_t) before
using it.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 08:04:51 +0000 (17:04 +0900)]
[enco] Catch internal exceptions in main (#1600)
With this commit, enco-cli now catches internal exceptions from
top-level main, and shows error message.
Note that this change is applied only to Release build. Debug build
remains unchanged to make it easy to check the stack trace on failure.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 06:35:49 +0000 (15:35 +0900)]
[stdex] Add license notice (#1602)
All the headers and sources in stdex now have license notice at the top.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 05:49:34 +0000 (14:49 +0900)]
[stdex] File naming convention (#1598)
This commit changes set as Set.h for consistency.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 05:48:47 +0000 (14:48 +0900)]
[enco] Replace Generic with BCHW layout in Caffe frontend (#1597)
This commit replaces all the use of GenericFeatureLayout with BCHW
layout.
This change eliminates the need for reorder call, which speeds up IR
build.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 04:07:46 +0000 (13:07 +0900)]
[coco] Fix possible memory leak in DLinkedListTest (#1593)
With the current implementation, allocated objects will be leaked on
assert failure.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 04:04:14 +0000 (13:04 +0900)]
[caffegen] Add license notice (#1596)
This commit adds license notice to all the headers and sources under
contrib/caffegen.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 04:04:02 +0000 (13:04 +0900)]
[coco] Introduce BCHW Feature Layout (#1595)
This commit introduces BCHW feature layout class as a mean to speed up
model import/transformation phases.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 02:51:48 +0000 (11:51 +0900)]
[cli] Add LICENSE notice (#1568)
This commit adds LICENSE notice for all the sources under cli.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 02:25:22 +0000 (11:25 +0900)]
[coco] Introduce FeatureLayout interface (#1592)
This commit introduces FeatureLayout interface, and revises
FeatureObject to depend on this new interface instead of
GenericFeatureLayout.
Besides, this commit also revises GenericFeatureLayout to inherit
FeatureLayout interface, which removes the need for external code
update.
This change allows us to impliment and use optimized FeatureLayouts to
speed up compilation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 01:43:46 +0000 (10:43 +0900)]
[coco] Update Index-to-Element link only via GenericFeatureLayout (#1591)
This commit adjusts the role of FeatureObject and GenericFeatureLayout
classes. Now, GenericFeatureLayout (not FeatureObject) is not responsible
for Index-to-Element link update.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 01:09:18 +0000 (10:09 +0900)]
[enco] Do NOT use reorder (in NNAPI backend) (#1589)
This commit eliminates the use of reorder method (in FeatureObject) from
NNAPI backend implementation.
This change is prerequisite for coco IR design revision.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Sep 2018 01:09:10 +0000 (10:09 +0900)]
[enco] Do NOT use reorder inside Caffe frontend (#1588)
This commit eliminates the use of reorder method (in FeatureObject) from
caffe frontend implementation.
This change is prerequisite for coco IR design revision.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
The first commit in the set of incremental commits for PRs adding the new ACL C++ soft backend (#1583)
This commit adds the command line option for the new backend invokation and add the new backend library stub
Signed-off-by: Timur Ablyazimov <t.ablyazimov@samsung.com>
Refactor nnc build system (#1584)
* implement function to add nnc library
Signed-off-by: Roman Rusyaev <r.rusyaev@samsung.com>
Support pooling border type in soft backend (#1582)
Support two border types in avg pooling: ZEROFILLED and EMPTY
Only EMPTY type supported in max pooling
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
Vladimir Plazun/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 19 Sep 2018 15:19:44 +0000 (18:19 +0300)]
[nnc] Fix interpreter tests (#1581)
Force borderType to be set to `ZEROFILLED` in pooling operator creation
Fix check for gtest availability( previosly was `getst` instead of `gtest` )
Add status message instead silent fail if tests cannot be build
Signed-off-by: Vladimir Plazun <v.plazun@partner.samsung.com>
Vladimir Plazun/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 19 Sep 2018 13:57:07 +0000 (16:57 +0300)]
Add interpreter support of different pooling types (#1580)
Add support of `zero filled` and `empty` padding fill in interpreter pooling
Signed-off-by: Vladimir Plazun <v.plazun@partner.samsung.com>
Add border type in pooling operation (#1579)
* Add border type that describes content of pool input outside of it's shape
* Support this property in importers
* Fix warning in tflite_op_creator.cpp
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
Add custom target to build unit tests from only nnc (#1576)
* add custom target to build all tests from only nnc
* add custom target to run all tests from only nnc
Signed-off-by: Roman Rusyaev <r.rusyaev@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 10:34:27 +0000 (19:34 +0900)]
[coco] Externally Configurable GenericFeatureLayout (#1578)
This commit allows users to replace the layout in FeatureObject with
their own (externally allocated) GenericFeatureLayout.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 10:34:19 +0000 (19:34 +0900)]
[coco] Implement reorder in GenericFeatureLayout (#1577)
This commit moves the actual implementation of reorder method from
FeaturObject into GenericFeatureLayout.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 10:12:57 +0000 (19:12 +0900)]
[coco] Rename mock-up Bag::Updater (#1575)
Currently, its name is "Update" although it inherits "Bag::Updater".
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 08:50:05 +0000 (17:50 +0900)]
[coco] Generate reader/accessor per request (#1573)
This commit revises PlainWeightContext to generate kernel
reader/accessor per request.
This allows PlainWeightContext to generate Object-specific reader and
accessor.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 08:48:52 +0000 (17:48 +0900)]
[coco] Remove ObjectInfo (#1569)
This commit removes all the reference of ObjectInfo from coco IR code
base as ObjectInfo is no longer used.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 08:48:41 +0000 (17:48 +0900)]
[caffegen] Remove deprecated Fill command (#1567)
* [caffegen] Remove deprecated Fill command
This commit removes deprecated Fill command and related implementations
from caffegen.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Fix build error
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 08:47:58 +0000 (17:47 +0900)]
[coco] Introduce GenericFeatureLayout (#1565)
This commit introduces GenericFeatureLayout which is extracted from
FeatureObject. GenericFeatureLayout includes code related with mapping
from index to each Bag element.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Rename target of system test for soft backend (#1574)
* Rename target of system test for soft backend
* replace target name `system_test_soft_backend_cpp_compile` with `nnc_system_test_soft_backend_cpp_compile`
Signed-off-by: Roman Rusyaev <r.rusyaev@samsung.com>
* rename target of test executable
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 07:50:53 +0000 (16:50 +0900)]
[nnc] Initialize modelPacked field in TfliteImporter (#1566)
This commit add an initializer for modelPacked filed in TfliteImporter.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 07:12:55 +0000 (16:12 +0900)]
Remove unused empty directories (#1571)
This commit removes the following empty directories under libs:
- frontend
- caffe
- tflite
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 06:44:54 +0000 (15:44 +0900)]
[refNN] Fix possible memory leak (#1563)
In the current implementation, allocated event object will be leaked
if startCompute failed.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 06:29:33 +0000 (15:29 +0900)]
[coco] UseSet in Object (#1564)
With this commit, Object (instead of ObjectInfo) is responsible for
its UseSet management.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:21:18 +0000 (13:21 +0900)]
[enco] Do NOT use deprecated Window2D methods in Caffe frontend (#1558)
This commit eliminates the use of deprecated methods in Window2D from
Caffe frontend implementation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:21:05 +0000 (13:21 +0900)]
[enco] Do NOT use deprecated Window2D methods in NNAPI backend (#1557)
This commit eliminates the use of deprecated methods in Window2D from
NNAPI backend implementation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:20:55 +0000 (13:20 +0900)]
[coco] Remove deprecated users method (#1556)
This commit removes deprecated users method from Object, and revises
related implementations.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:20:46 +0000 (13:20 +0900)]
[RefNN] Add missing break in Executor (#1561)
'break' is missing at the end of "ADD" case currently.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:20:12 +0000 (13:20 +0900)]
[coco] Mark mutable fields as private (#1560)
This commit marks deps, reads, and updates methods in Bag as private
after renaming.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 04:16:14 +0000 (13:16 +0900)]
[enco] Add caffe 016 test (#1554)
This commit adds caffe 016 test which includes a group convolution layer
(which simulates depthwise convolution).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Sep 2018 02:19:08 +0000 (11:19 +0900)]
Add top-level LICENSE file (#1550)
The purpose of LICENSE is to provide full text of license that the
corresponding source contains only partial and/or link to full text.
LICENSE currently contains Apache License 2.0 which our own sources
and imported reference android NN runtime use.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Import pads from caffe model directly (#1545)
Do not inference paddings in ShapeInference, instead use numbers from model
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 11:26:12 +0000 (20:26 +0900)]
[enco] Android NN DCONV2D operation generation (#1553)
* [enco] Android NN DCONV2D operation generation
With this commit, Android NN IR builder in enco NNAPI backend is now
able to build DCONV2D operation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Fix build error
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 10:33:55 +0000 (19:33 +0900)]
[enco] Configure convolution group parameter (#1552)
This commit revises enco caffe frontend to update coco IR's group
parameter according to caffe model.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 10:28:45 +0000 (19:28 +0900)]
[coco] Manage Def in Object (#1532)
* [coco] Manage Def in Object
This commit moves Def field and related methods from ObjectInfo into
Object.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Update comment
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 09:47:29 +0000 (18:47 +0900)]
[coco] Remove BagInfo (#1536)
This commit removes all the reference of deprecated BagInfo from coco IR
codebase.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 09:42:29 +0000 (18:42 +0900)]
[coco] Introduce Shuffle::size method (#1539)
* [coco] Introduce Shuffle::size method
This commit introduces Shuffle::size method which allows us to get the
number of element-wise transfers without using heavy range method.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Check invariant over size() and range()
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 08:18:07 +0000 (17:18 +0900)]
[coco] Use InstrManagerTest fixture for create_UnitF (#1529)
This commit rewrites create_UnitF test using InstrManagerTest
fixture.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 08:17:59 +0000 (17:17 +0900)]
[coco] UseSet for Object (#1528)
This commit revises ObjectInfo to maintain a set of Use(s) for each
object along with a set of Consumer(s).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 08:01:52 +0000 (17:01 +0900)]
[caffegen] Do NOT depend on nncc_foundation (#1548)
This commit replaces all the use of nncc::foundation::make_unique with
stdex::make_unique in order to eliminate nncc_foundation dependency.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 08:01:37 +0000 (17:01 +0900)]
[enco] ANN Op CodeGen (#1547)
This commit extends opcode implementation for DEPTHWISE_CONV_2D op.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 08:01:29 +0000 (17:01 +0900)]
[coco] IR entities-to-Module link (#1546)
With this commit, each IR entity allocated via EntityManager will have a correct
link to a module that it belongs to.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Tue, 18 Sep 2018 06:41:57 +0000 (15:41 +0900)]
[enco] Unify Compatiblity Check and ANN IR Builder (#1534)
This commit revises ANNOpBuilder to return Appender for a given
instruction instead of appending it.
This change allows us to unify independent CompatibilityCheck into
ANNOpBuilder.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
feature: add multiple interpreter outputs (#1543)
--res-filename removed redundant
--output-dir used for outputs
--output-node can take multiple values
Signed-off-by: Vitaliy Cherepanov <v.cherepanov@samsung.com>
Implement batch norm as scale and bias (#1542)
Replace batch norm with scale and bias operations in caffe importer
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
Fix naming of soft backend files (#1477)
Replace old_c_style with CamelCase style in pure soft backend file names
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
Fix Importer bug (#1541)
Found when testing 1 op models: `Im2Col` Layer uses the convolution parameter, as does
the `Deconvolution` (or `TransposedConvolution` layer). This resolves the issue.
Signed-off-by: Andrei Shedko <a.shedko@partner.samsung.com>
Support new type of option value (#1504)
* support `std::vector<std::string>` type for option
* support multiple values for option in command line parser
* write unit test for new functionality
Signed-off-by: Roman Rusyaev <r.rusyaev@samsung.com>
Add shape correctness check (#1485)
Check that shapes of input tensors are correct in artifact setters
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 10:02:07 +0000 (19:02 +0900)]
[coco] Store size in Bag (#1531)
This commit revises Bag to store its size in it. This is a step toward
Bag/BagInfo unification.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 09:56:25 +0000 (18:56 +0900)]
[coco] Explicit Input/Output link from Bag (#1526)
This commit revises Bag class to maintain explicit Input/Output link (to
make it easy to manipulate).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 09:29:12 +0000 (18:29 +0900)]
[enco] Declare ANNOpBuilder before ANNGroupBuilder (#1524)
As stated in the title, this commit declares (and implements) ANNOpBuilder
before ANNGroupBuilder (to use ANNOpBuilder inside ANNGroupBuilder
later).
This commit includes no change over implementation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 08:13:02 +0000 (17:13 +0900)]
[coco] Do NOT use Object-to-ObjectInfo link (#1527)
Def and Use classes are now able to access the internals of Object
without using Object-to-ObjectInfo link.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 07:38:44 +0000 (16:38 +0900)]
[coco] Do NOT use Op-to-Instr link (#1525)
coco no longer uses Op-to-Instr link as a mean to manage Op-to-Instr
relations.
This commit removes all the use of Op-to-Instr link in coco IR codebase.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 07:35:44 +0000 (16:35 +0900)]
[coco] Use as a friend class of Object (#1523)
This commit declares Use as a friend class of Object, and simplifies the
internal implementation of Use.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 07:16:24 +0000 (16:16 +0900)]
[coco] Return Def instead Producer (#1521)
This commit revises Object::def method to return a pointer to Def
instead of a pointer to its Producer.
This commit also revises all the related implementations and tests.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 07:04:53 +0000 (16:04 +0900)]
[enco] Introduce DEPTHWISE_CONV_2D (#1520)
This commit extends Android NN IR with DEPTHWISE_CONV_2D operation.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 07:04:23 +0000 (16:04 +0900)]
[coco] Manage DepSet/ReadSet/UpdateSet in Bag (#1518)
This commit moves DepSet/ReadSet/UpdateSet in BagInto into Bag. This is
the first step to unify Bag and BagInfo class.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 06:50:44 +0000 (15:50 +0900)]
[coco] Remove links for child-parent relation update (#1522)
This commit eliminates all the use of PtrLink as a mean to update
child-parent relation between DLinkedList::Head and DLinkedList::Node.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 06:36:18 +0000 (15:36 +0900)]
[enco] Use 'Appender' in Split pass (#1516)
* [enco] Use 'Appender' in Split pass
This commit introduces the concept of 'Appender' in Split pass.
Conceptually, each Appender encapsulates the update over ANN IR for
each coco IR instruction.
This change is a step to unify ANNGroupBuilder and ANNOpBuilder.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Remove unused variable avgpool
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 06:17:02 +0000 (15:17 +0900)]
[coco] Introduce Step class (#1517)
This commit introduces Step class which denotes the edge between Op and
Instr.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 05:50:37 +0000 (14:50 +0900)]
[coco] Remove Bag-to-BagInfo link (#1519)
This commit removes all the use of Bag-to-BagInfo link from coco IR
codebase.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 04:25:09 +0000 (13:25 +0900)]
[coco] Allow Def to access the internals of Object (#1515)
This commit declares Def as a friend of Object class, which allows Def
to access Object's internal fields.
This change allows us to simplify the implementation of Def.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 04:24:30 +0000 (13:24 +0900)]
[coco] Detach Node from List on destruction (#1514)
This commit revises DLinkedList::Node's destructor to detach itself on
destruction.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 04:24:17 +0000 (13:24 +0900)]
[coco] Introduce producer and consumers helpers (#1513)
This commit introduces producer and consumers helpers for Object values.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 04:15:19 +0000 (13:15 +0900)]
[coco] Direct updates Input/Ouput mask (#1512)
This commit declares Input and Ouput class as a friend of Bag, and
revises these classes to update Bag's make without using Bag-to-BagInfo
link.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 02:13:53 +0000 (11:13 +0900)]
[coco] Rename UseSlot as Use (#1511)
This commit renames UseSlot as Use (to be consistent with Def).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 02:05:15 +0000 (11:05 +0900)]
[coco] Prepare Window2D method renaming (#1509)
Window2D currently has 'vertical' and 'horizontal' methods, but
it would be better to use 'height' and 'width' to make it clear that
Window2D represents the shape of receptive fields.
As the first step to method renaming, this commit introduces 'height'
and 'width' methods to allow clients (such as enco) to prepare
themselves for future changes.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 02:04:42 +0000 (11:04 +0900)]
[coco] Change object destruction order (#1508)
This commit changes the order of object destruction in coco::Module
implementation to allow each block to detach itself from the
corresponding BlockList.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 02:03:28 +0000 (11:03 +0900)]
[enco] Infer Output Shape of Convolution with group (#1501)
This commit extends ConvolutionSpec to handle non-default group parameter.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 00:43:42 +0000 (09:43 +0900)]
[coco] Direct update on UpdateSet (#1510)
This commit declares Update as a friend class of Bag, and revises Update
to update UpdateSet in a Bag without using Bag-to-BagInfo link.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Mon, 17 Sep 2018 00:21:50 +0000 (09:21 +0900)]
[coco] Direct update on ReadSet (#1496)
This commit declares Read as a friend class of Bag, and updates ReadSet
in it without using Bag-to-BagInfo link.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 10:57:09 +0000 (19:57 +0900)]
[coco] Class static head (#1498)
This commit replaces pure virtual head method with class static version
in order to support detach from destructor.
Note that destructor SHOULD NOT invoke virtual method.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 10:33:51 +0000 (19:33 +0900)]
[coco] Remove deprecated get (#1499)
This commit removes deprecated get method in DLinkedList Node.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 09:40:38 +0000 (18:40 +0900)]
[coco] Introduce 'group' parameter to Conv2D op (#1495)
This commit introduces 'group' parameter to Conv2D op in order to
support depthwise (or grouped in general) convolution.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 09:40:30 +0000 (18:40 +0900)]
[stdex] Introduce Memory.h (#1494)
This commit introduces Memory.h to stdex library, which includes
make_unique implementation (not present in C++ 11).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 09:24:26 +0000 (18:24 +0900)]
[coco] Remove unnecessary methods for bag link update (#1497)
This commit removes all of unnecessary methods introduced to deliver bag
link to each Dep.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 07:52:08 +0000 (16:52 +0900)]
[coco] Simplify Bag-Dep relation update (#1492)
This commit simplifies Bag-Dep relation updates via friend declaration.
Now, Dep does not use Bag-to-BagInfo link for relation update.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 07:48:31 +0000 (16:48 +0900)]
[coco] Direct Parent-Child relation update in DLinkedList (#1491)
This commit revises DLinkedLists to directly updates parent-child
relations instead of using PtrLink.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 07:48:18 +0000 (16:48 +0900)]
[coco] Remove UseHook (#1493)
This commit removes UseHook and implements its functionalities in
UseSlot as in Def.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 07:47:50 +0000 (16:47 +0900)]
[enco] Hoist objects across multiple shuffle(s) (#1489)
* [enco] Hoist objects across multiple shuffle(s)
This commit extends object hoist optimization pass to support object
hoist across multiple shuffle(s).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Add 'Case 1' section
* Fix a typo (followinc --> following)
박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 [Fri, 14 Sep 2018 04:15:34 +0000 (13:15 +0900)]
[coco] Link to Def instead of Producer (#1487)
This commit revises ObjectInfo class to maintain a link(= pointer) to
Def instead of Producer.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Support new caffe operations in soft backend (#1476)
Support new operations:
+ Scale (works on channel axis only)
+ Dropout (passes tensor without changes)
+ BatchNorm (passes tensor without changes)
Signed-off-by: Efimov Alexander <a.efimov@samsung.com>