Owen W. Taylor [Tue, 18 Aug 2015 18:41:24 +0000 (14:41 -0400)]
logind: use open_terminal() instead of open()
The open_terminal() function adds retries in case a terminal
is in the process of being closed when we open it, and should
generally be used to open a terminal. We especially need it
for code that a subsequent commit adds that reopens the terminal
at session shut-down time; such races would be more likely in
that case.
Found by Ray Strode.
Lennart Poettering [Tue, 18 Aug 2015 08:17:17 +0000 (10:17 +0200)]
Merge pull request #984 from whot/hwdb-updates
hwdb: fix capitalization of product version for the Macbooks
Lennart Poettering [Tue, 18 Aug 2015 08:16:10 +0000 (10:16 +0200)]
Merge pull request #983 from phomes/journal_dead_check
journal: remove error check that never happens
Peter Hutterer [Thu, 30 Jul 2015 23:56:25 +0000 (09:56 +1000)]
hwdb: fix capitalization of product version for the Macbooks
We need uppercase hex here.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Thomas Hindoe Paaboel Andersen [Fri, 14 Aug 2015 21:40:27 +0000 (23:40 +0200)]
journal: remove error check that never happens
remove_directory will always return 0 so this can never happen.
Besides that, d->path and d are freed so we would end up with
a null pointer dereference anyway.
Daniel Mack [Mon, 17 Aug 2015 20:38:30 +0000 (22:38 +0200)]
Merge pull request #982 from evverx/add-systemd-cgls
man: add systemd-cgls as tool that shows the cgroup hierarchy
Evgeny Vereshchagin [Mon, 17 Aug 2015 19:16:04 +0000 (19:16 +0000)]
man: add systemd-cgls as tool that shows the cgroup hierarchy
Lennart Poettering [Mon, 17 Aug 2015 13:12:15 +0000 (15:12 +0200)]
Merge pull request #977 from richardmaw-codethink/machinectl-userns-login-v2
Fix machinectl login with containers in user namespaces (v2)
Lennart Poettering [Mon, 17 Aug 2015 09:30:31 +0000 (11:30 +0200)]
Merge pull request #976 from elfring/Remove_unnecessary_checks2
Delete unnecessary checks before some function calls
Lennart Poettering [Mon, 17 Aug 2015 09:19:14 +0000 (11:19 +0200)]
Merge pull request #958 from stefwalter/fix-journalctl-f-regression
Regression: 'journalctl -f -t unmatched' doesn't block properly
Richard Maw [Mon, 17 Aug 2015 08:52:13 +0000 (08:52 +0000)]
namespace helpers: Allow entering a UID namespace
To be able to use `systemd-run` or `machinectl login` on a container
that is in a private user namespace, the sub-process must have entered
the user namespace before connecting to the container's D-Bus, otherwise
the UID and GID in the peer credentials are garbage.
So we extend namespace_open and namespace_enter to support UID namespaces,
and we enter the UID namespace in bus_container_connect_{socket,kernel}.
namespace_open will degrade to a no-op if user namespaces are not enabled
in the kernel.
Special handling is required for the setns call in namespace_enter with
a user namespace, since transitioning to your own namespace is forbidden,
as it would result in re-entering your user namespace as root.
Arguably it may be valid to check this at the call site, rather than
inside namespace_enter, but it is less code to do it inside, and if the
intention of calling namespace_enter is to *be* in the target namespace,
rather than to transition to the target namespace, it is a reasonable
approach.
The check for whether the user namespace is the same must happen before
entering namespaces, as we may not be able to access /proc during the
intermediate transition stage.
We can't instead attempt to enter the user namespace and then ignore
the failure from it being the same namespace, since the error code is
not distinct, and we can't compare namespaces while mid-transition.
Markus Elfring [Mon, 17 Aug 2015 08:45:30 +0000 (10:45 +0200)]
Bug #944: Deletion of unnecessary checks before a few calls of systemd functions
The following functions return immediately if a null pointer was passed.
* calendar_spec_free
* link_address_free
* manager_free
* sd_bus_unref
* sd_journal_close
* udev_monitor_unref
* udev_unref
It is therefore not needed that a function caller repeats a corresponding check.
This issue was fixed by using the software Coccinelle 1.0.1.
Daniel Mack [Mon, 17 Aug 2015 08:10:04 +0000 (10:10 +0200)]
Merge pull request #953 from poettering/ebadf
tree-wide: generate EBADF when we get invalid fds
Daniel Mack [Mon, 17 Aug 2015 08:09:16 +0000 (10:09 +0200)]
Merge pull request #970 from poettering/timedatectl-set-netp
man: extend documentation for timedatectl's set-ntp command
Daniel Mack [Mon, 17 Aug 2015 08:07:27 +0000 (10:07 +0200)]
Merge pull request #973 from poettering/sd-bus-error-ret
sd-bus: always fill in sd_bus_error paramters, on error
Daniel Mack [Mon, 17 Aug 2015 08:04:31 +0000 (10:04 +0200)]
Merge pull request #974 from teg/resolved-fixes-2
resolved: debugging improvements
Stef Walter [Fri, 14 Aug 2015 14:38:41 +0000 (16:38 +0200)]
journalctl: make sure 'journalctl -f -t unmatched' blocks
Previously the following command:
$ journalctl -f -t unmatchedtag12345
... would block when called with criteria that did not match any
journal lines. Once log lines appeared that matched the criteria
they were displayed.
Commit
02ab86c732576a71179ce12e97d44c289833236d broke this
behavior and the journal was not followed, but the command
exits with '-- No entries --' displayed.
This commit fixes the issue.
More information downstream:
https://bugzilla.redhat.com/show_bug.cgi?id=1253649
Markus Elfring [Mon, 17 Aug 2015 07:30:49 +0000 (09:30 +0200)]
Bug #944: Deletion of unnecessary checks before calls of the function "free"
The function "free" is documented in the way that no action shall occur for
a passed null pointer. It is therefore not needed that a function caller
repeats a corresponding check.
http://stackoverflow.com/questions/
18775608/free-a-null-pointer-anyway-or-check-first
This issue was fixed by using the software Coccinelle 1.0.1.
Markus Elfring [Mon, 17 Aug 2015 07:10:56 +0000 (09:10 +0200)]
Bug #944: Replacement of a free() call by mfree()
The function "mfree" should be called instead of "free" at a specific
source code place.
Tom Gundersen [Wed, 12 Aug 2015 16:18:31 +0000 (18:18 +0200)]
resolved: cache - add more detailed cache debug logging
Lennart Poettering [Sun, 16 Aug 2015 20:13:34 +0000 (22:13 +0200)]
sd-bus: always fill in sd_bus_error paramters, on error
Whenever one of our calls is invoked with a non-NULL, writable
sd_bus_error parameter, let's fill in some valid error on failure. We
previously only filled in remote errors, but never local errors, which is
hard to handle by users. Hence, let's clean this up to always fill in
the error.
This introduces a new bus_assert_return() macro that works like
assert_return() but optionally also initializes a bus_error struct.
Fixes #224.
Based on a patch by Umut Tezduyar.
Lennart Poettering [Sun, 16 Aug 2015 19:59:58 +0000 (21:59 +0200)]
update TODO
Lennart Poettering [Sun, 16 Aug 2015 19:32:03 +0000 (21:32 +0200)]
Merge pull request #908 from richardmaw-codethink/nspawn-path-escapes-v3
Allow arbitrary file paths to be passed to nspawn (v3)
Lennart Poettering [Sun, 16 Aug 2015 19:05:33 +0000 (21:05 +0200)]
README: drop reference to Endocode
Chris Kühl does not work at Endocode anymore, the contact data is no
longer valid.
Tom Gundersen [Wed, 12 Aug 2015 15:29:53 +0000 (17:29 +0200)]
TODO
Tom Gundersen [Tue, 11 Aug 2015 20:37:23 +0000 (22:37 +0200)]
resolve-host: print RTT
Tom Gundersen [Tue, 11 Aug 2015 18:05:53 +0000 (20:05 +0200)]
resolved: packet - fix typo in read_rr()
Tom Gundersen [Sun, 16 Aug 2015 18:46:11 +0000 (20:46 +0200)]
Merge pull request #955 from poettering/resolved-localhost-xyz
resolved: enable synthesizing of A, AAAA and PTR records for "localhost"
Tom Gundersen [Sun, 16 Aug 2015 18:38:32 +0000 (20:38 +0200)]
Merge pull request #954 from poettering/nss-myhostname-loopback
nss-myhostname: use LOOPBACK_IFINDEX instead of if_nametoindex("lo")
Tom Gundersen [Sun, 16 Aug 2015 18:37:52 +0000 (20:37 +0200)]
Merge pull request #972 from poettering/resolve-host-auto-start
resolve-host: enable auto start of resolved
Lennart Poettering [Sun, 16 Aug 2015 18:29:21 +0000 (20:29 +0200)]
resolve-host: enable auto start of resolved
There's no reason to explicitly turn off bus activation for resolved
here. The reason this was done before was that the code was copied from
nss-resolve, which has a fallback to glibc's nss-dns if resolved is not
reachable. However, such a logic makes no sense for resolve-host since
such a fallback doesn't make sense here, which means we can actually
turn on activation. Let's do it hence.
Lennart Poettering [Sun, 16 Aug 2015 18:24:25 +0000 (20:24 +0200)]
Merge pull request #971 from evverx/news-fix
NEWS: fix the "indirect" state description
Evgeny Vereshchagin [Sun, 16 Aug 2015 18:10:23 +0000 (18:10 +0000)]
NEWS: fix the "indirect" state description
Lennart Poettering [Sun, 16 Aug 2015 17:58:49 +0000 (19:58 +0200)]
Merge pull request #931 from spartacus06/update-completion-machinectl
Update shell completion for machinectl
Lennart Poettering [Sun, 16 Aug 2015 16:26:03 +0000 (18:26 +0200)]
man: extend documentation for timedatectl's set-ntp command
This extends on the relationship between timedatectl's set-ntp command
and its effect on the systemd-timesyncd.service unit. This also links
that unit back to the timedatectl man page.
Closes #798.
Lennart Poettering [Sun, 16 Aug 2015 16:25:24 +0000 (18:25 +0200)]
update TODO
Seth Jennings [Tue, 11 Aug 2015 16:40:17 +0000 (11:40 -0500)]
shell-completion: use list-images rather than list
"machinectl list" only lists running machines while many of the MACHINES
commands use names of images; both running and non-running.
List machines from both "list" and "list-images" and use sort -u to
avoid duplicates.
Seth Jennings [Tue, 11 Aug 2015 16:43:56 +0000 (11:43 -0500)]
shell-completion: update machinectl bash completion
Many new subcommands have been added since the bash completion was last
updated. Bring it up to speed.
Lennart Poettering [Sun, 16 Aug 2015 16:11:18 +0000 (18:11 +0200)]
Merge pull request #930 from richardmaw-codethink/man-when-exec-start-post
man: Describe when ExecStartFoo= commands are run in more detail
Lennart Poettering [Sun, 16 Aug 2015 15:07:28 +0000 (17:07 +0200)]
Merge pull request #918 from thomasmey/uml-fix
UML: Fix block device setup
Lennart Poettering [Sun, 16 Aug 2015 15:04:57 +0000 (17:04 +0200)]
Merge pull request #947 from evverx/bash-completion
Update bash-completion: generate all unit types
Evgeny Vereshchagin [Thu, 13 Aug 2015 21:54:58 +0000 (21:54 +0000)]
bash-completion: generate unit type list from systemctl -t help option
Lennart Poettering [Sun, 16 Aug 2015 12:34:36 +0000 (14:34 +0200)]
Merge pull request #932 from kaysievers/bus
sd-bus: do not connect to dbus-1 socket when kdbus is available
Ronny Chevalier [Sat, 15 Aug 2015 12:21:42 +0000 (14:21 +0200)]
Merge pull request #968 from alkino/master
zsh completion: update busctl
Nicolas Cornu [Sat, 15 Aug 2015 11:58:05 +0000 (13:58 +0200)]
zsh completion: update busctl
Lennart Poettering [Fri, 14 Aug 2015 10:45:06 +0000 (12:45 +0200)]
tree-wide: generate EBADF when we get invalid fds
This is a follow-up to #907, and makes the same change for all our other
public APIs.
Daniel Mack [Fri, 14 Aug 2015 11:31:36 +0000 (13:31 +0200)]
Merge pull request #948 from phomes/master
logind: actually fail on OOM
Lennart Poettering [Fri, 14 Aug 2015 11:21:28 +0000 (13:21 +0200)]
resolved: never allow routing of "localhost" queries to DNS or LLMNR
We should never allow leaking of "localhost" queries onto the network,
even if there's an explicit domain rotue set for this.
Lennart Poettering [Fri, 14 Aug 2015 11:17:05 +0000 (13:17 +0200)]
resolved: locally synthesize replies for "localhost"
Let's make sure that clients querying resolved via the bus for A, AAAA
or PTR records for "localhost" get a synthesized, local reply, so that
we do not hit the network.
This makes part of nss-myhostname redundant, if used in conjunction.
However, given that nss-resolve shall be optional we need to keep this
code in both places for now.
Lennart Poettering [Fri, 14 Aug 2015 11:11:04 +0000 (13:11 +0200)]
nss-myhostname: use LOOPBACK_IFINDEX instead of if_nametoindex("lo")
Given that we already hardocde the loopback ifindex, following the
kernel's own logic, we can replace the invocation of
if_nametoindex("lo") with LOOPBACK_IFINDEX.
Lennart Poettering [Fri, 14 Aug 2015 10:44:13 +0000 (12:44 +0200)]
update TODO
Thomas Hindoe Paaboel Andersen [Thu, 13 Aug 2015 21:36:08 +0000 (23:36 +0200)]
logind: actually fail on OOM
Since
dacd6cee76a08331b8c8616c5f30f70ee49aa2f9 the two OOM's are
ignored as the value of r will be overwritten and we only log in
the fail section anyway.
This patch jumps to fail on OOM.
Note that this is different behavior compared to both the current
code and previous to
dacd6cee76a08331b8c8616c5f30f70ee49aa2f9. Before
that commit we would log that saving the inhibit data failed, but
still write the file, though without the WHO/WHY section.
CID# 1313545
Lennart Poettering [Thu, 13 Aug 2015 18:54:56 +0000 (21:54 +0300)]
Merge pull request #907 from keszybz/sd-daemon-badf
sd-daemon: return EBADF for invalid fd numbers
Daniel Mack [Thu, 13 Aug 2015 15:57:09 +0000 (17:57 +0200)]
Merge pull request #941 from phomes/master
hwdb: add DPI for a few more mice
Thomas Hindoe Paaboel Andersen [Wed, 12 Aug 2015 20:25:10 +0000 (22:25 +0200)]
hwdb: add DPI for a few more mice
Kay Sievers [Wed, 12 Aug 2015 14:08:18 +0000 (16:08 +0200)]
Merge pull request #938 from tblume/fix-kexec-force-reboot
support reboot -f for kexec kernel
Tom Gundersen [Wed, 12 Aug 2015 13:19:23 +0000 (15:19 +0200)]
Merge pull request #939 from karelzak/smatch
treewide: trivial issues detected by smatch
Kay Sievers [Wed, 12 Aug 2015 12:37:42 +0000 (14:37 +0200)]
Merge pull request #935 from teg/gpt-fixes
gpt-auto-generator: minor fixes
Thomas Blume [Wed, 12 Aug 2015 06:11:15 +0000 (08:11 +0200)]
support reboot -f for kexec kernel
Fix error message:
-->--
Code should not be reached 'Unknown action.' at
src/systemctl/systemctl.c:6382, function halt_now(). Aborting.
Aborted
--<--
when executing 'reboot -f' from a system running a kexec kernel.
Tom Gundersen [Tue, 11 Aug 2015 16:22:59 +0000 (18:22 +0200)]
gpt-auto-generator: warn on ambiguous blkid probe
Tom Gundersen [Tue, 11 Aug 2015 14:29:10 +0000 (16:29 +0200)]
gpt-auto-generator: don't warn on !ENABLE_EFI
add_automount() was only used on EFI systems, compile it conditionally
to avoid the warning.
Kay Sievers [Tue, 11 Aug 2015 18:46:05 +0000 (20:46 +0200)]
sd-bus: do not connect to dbus-1 socket when kdbus is available
We should not fall back to dbus-1 and connect to the proxy when kdbus
returns an error that indicates that kdbus is running but just does not
accept new connections because of quota limits or something similar.
Using is_kdbus_available() in libsystemd/ requires it to move from
shared/ to libsystemd/.
Based on a patch from David Herrmann:
https://github.com/systemd/systemd/pull/886
Richard Maw [Tue, 11 Aug 2015 12:29:45 +0000 (12:29 +0000)]
man: Describe when ExecStartFoo= commands are run in more detail
Previously it was just descibed that ExecStartPost= commands were
started "after" the ExecStart= command(s).
This hasn't specified after which event, which varies from after it has
been started, after it has exited, after it has sent READY=1 or after it
has taken the bus name, depending on Type=.
This now describes that it happens after the *service* has "started",
as defined by the Type=, and provides some clarification about precisely
when this is.
This may be unnecessary duplication, but it removes the ambiguity as to
whether RemainAfterExit=no means that ExecStartPost= shouldn't be
started because it means the service has stopped when the ExecStart=
command terminates, not "started".
Daniel Mack [Tue, 11 Aug 2015 11:39:27 +0000 (13:39 +0200)]
Merge pull request #929 from kaysievers/gpt
gpt-auto-generator: apply partition-type flags only to specific parti…
Kay Sievers [Tue, 11 Aug 2015 11:07:25 +0000 (13:07 +0200)]
gpt-auto-generator: apply partition-type flags only to specific partition-types
The partition-type flags are defined independently for every partition-type. Apply
them only to the types where they are defined, and not to the ESP, which does not
appear to share the same set of flags.
https://github.com/systemd/systemd/issues/920
Thomas Meyer [Sun, 9 Aug 2015 16:07:55 +0000 (18:07 +0200)]
UML: Fix block device setup
User mode linux block devices start with ubd, e.g. ubda, ubdb, etc..
Daniel Mack [Sat, 8 Aug 2015 11:34:32 +0000 (13:34 +0200)]
Merge pull request #916 from reverendhomer/patch-3
libsystemd-network: fix memory leak
reverendhomer [Sat, 8 Aug 2015 11:24:11 +0000 (14:24 +0300)]
libsystemd-network: fix memory leak
Daniel Mack [Sat, 8 Aug 2015 09:07:05 +0000 (11:07 +0200)]
Merge pull request #914 from reverendhomer/patch-2
Coverity #1299013
Daniel Mack [Sat, 8 Aug 2015 09:05:20 +0000 (11:05 +0200)]
Merge pull request #913 from reverendhomer/patch-1
Coverity #1299015
reverendhomer [Sat, 8 Aug 2015 06:54:10 +0000 (09:54 +0300)]
Coverity #1299013
event cannot be NULL due to assert
reverendhomer [Sat, 8 Aug 2015 06:49:39 +0000 (09:49 +0300)]
Coverity #1299015
bus can never be NULL due to assert
Richard Maw [Fri, 19 Jun 2015 15:24:40 +0000 (15:24 +0000)]
man: Document \: escapes in nspawn's --overlay option
Richard Maw [Fri, 19 Jun 2015 15:24:38 +0000 (15:24 +0000)]
nspawn: Allow : characters in overlay paths
: characters can be entered with the \: escape sequence.
Richard Maw [Fri, 19 Jun 2015 15:24:37 +0000 (15:24 +0000)]
nspawn: escape paths in overlay mount options
Overlayfs uses , as an option separator and : as a list separator. These
characters are both valid in file paths, so overlayfs allows file paths
which contain these characters to backslash escape these values.
Richard Maw [Tue, 23 Jun 2015 10:57:41 +0000 (10:57 +0000)]
strv: Add strv_shell_escape
This modifies the strv in-place, replacing strings with their escaped
version. It's mostly just a convenience function for when you need to
join a strv together because it's passed as a string to something, and
the separator needs escaping.
Richard Maw [Tue, 23 Jun 2015 10:32:02 +0000 (10:32 +0000)]
util: Add shell_escape
This is for shell-style \ escaping rather than quoting, which while it
has the same effect in produced shell commands, is not exclusively
useful for shell commands.
shell_escape would be useful for producing sed commands, as you would be
able to \ escape the normal special characters, plus whichever argument
separator was chosen; or it could be used to escape arguments passed to
the overlayfs mount command.
Richard Maw [Fri, 19 Jun 2015 15:24:36 +0000 (15:24 +0000)]
man: Document \: escapes in nspawn's --bind option
Richard Maw [Fri, 19 Jun 2015 15:24:35 +0000 (15:24 +0000)]
nspawn: Allow : characters in nspawn --bind paths
: characters in bind paths can be entered as the \: escape sequence.
Richard Maw [Fri, 19 Jun 2015 15:24:34 +0000 (15:24 +0000)]
strv: convert strv_split_quotes into a generic strv_split_extract
strv_split_extract is to strv_split_quotes as extract_first_word was to
unquote_first_word.
Now there's extract_first_word for extracting a single argument,
extract_many_words for extracting a bounded number of arguments,
and strv_split_extract for extracting an arbitrary number of arguments.
Richard Maw [Fri, 19 Jun 2015 15:24:33 +0000 (15:24 +0000)]
man: Document \: escapes in nspawn's --tmpfs option
Richard Maw [Fri, 19 Jun 2015 15:24:31 +0000 (15:24 +0000)]
nspawn: Allow : characters in --tmpfs path
This now accepts : characters with the \: escape sequence.
Other escape sequences are also interpreted, but having a \ in your file
path is less likely than :, so this shouldn't break anyone's existing
tools.
Richard Maw [Tue, 23 Jun 2015 17:00:40 +0000 (17:00 +0000)]
util: Allow non-separator coalescing parsing in extract_first_word
If EXTRACT_DONT_COALESCE_SEPARATORS is passed, then leading separators,
trailing separators and spans of multiple separators aren't skipped, and
empty arguments from before, after or between separators may be extracted.
Richard Maw [Tue, 23 Jun 2015 16:26:49 +0000 (16:26 +0000)]
util: Don't interpret quotes by default in extract_first_word
This adds an EXTRACT_QUOTES option to allow the previous behaviour, of
not interpreting any character inside ' or " quotes as separators.
Richard Maw [Tue, 23 Jun 2015 16:20:53 +0000 (16:20 +0000)]
util: change unquote_*_word to extract_*_word
It now takes a separators argument, which defaults to WHITESPACE if NULL
is passed.
Richard Maw [Fri, 19 Jun 2015 16:38:06 +0000 (16:38 +0000)]
unquote_first_word: set *p=NULL on termination
To add a flag to allow an empty string to be parsed as an argument, we
need to be able to distinguish between the end of the string, and after
the end of the string, so when we *do* reach the end, let's set *p to
this state.
Richard Maw [Fri, 19 Jun 2015 15:24:29 +0000 (15:24 +0000)]
Convert unquote_*_word users to expect isempty(p) after the last entry
This is so that, when called in a loop, unquote_first_word can
distinguish between reaching the end of a string because it has consumed
all the input before the end, and consuming all the input.
This is important because we later add a flag that allows
char *in = "";
char *out;
unquote_first_word(&in, &out, flags);
To put "" in out, and set in = NULL, so the trailing empty string of the
input can be consumed, and mark that the input has been consumed.
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 15:30:18 +0000 (11:30 -0400)]
sd-daemon: return EBADF for invalid fd numbers
This matches what open(2) and other system functions do.
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 15:20:18 +0000 (11:20 -0400)]
Merge pull request #906 from jnpkrn/core-typo-fix
core: s/reexection/reexecution/ typo fix
Jan Pokorný [Fri, 7 Aug 2015 15:13:15 +0000 (17:13 +0200)]
core: s/reexection/reexecution/ typo fix
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
Daniel Mack [Fri, 7 Aug 2015 05:32:19 +0000 (07:32 +0200)]
Merge pull request #904 from keszybz/load-fragment-fix
Load fragment fix
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 04:06:15 +0000 (00:06 -0400)]
man: clarify that unknown escapes must be escaped
https://bugzilla.redhat.com/show_bug.cgi?id=1251334
is about a unit file which has
Environment=TERM=linux PS1=system-upgrade:\w\$\x20
We used to allow that, but after recent tightening of parsing
rules, we barf. Make it clear that this is intentional.
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 03:47:46 +0000 (23:47 -0400)]
load-fragment: fix segv on parse error
https://bugzilla.redhat.com/show_bug.cgi?id=1251334
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 00:16:23 +0000 (20:16 -0400)]
build-sys: line-wrap message about google servers
This way it is more readable in a wall of configure output.
Daniel Mack [Thu, 6 Aug 2015 14:13:22 +0000 (16:13 +0200)]
Merge pull request #898 from poettering/machined-fix-reload
Fix for #376, plus some other fixes
Lennart Poettering [Thu, 6 Aug 2015 13:50:54 +0000 (16:50 +0300)]
machined: rework state tracking logic for machines
This splits up the stopping logic for machines into two steps: first on
machine_stop() we begin with the shutdown of a machine by queuing the
stop method call for it. Then, in machine_finalize() we actually remove
the rest of its runtime context. This mimics closely how sessions are
handled in logind.
This also reworks the GC logic to strictly check the current state of
the machine unit, rather than shortcutting a few cases, like for example
assuming that UnitRemoved really means a machine is gone (which it isn't
since Reloading might trigger it, see #376).
Fixes #376.
Lennart Poettering [Thu, 6 Aug 2015 13:50:02 +0000 (16:50 +0300)]
machine: drop state variable from Machine object
We never made use of it, let's get rid of it.
Lennart Poettering [Thu, 6 Aug 2015 13:48:17 +0000 (16:48 +0300)]
logind,machined: various smaller cleanups
Use mfree() where we can.
Drop unnecessary {}.
Drop unnecessary variable declarations.
Cast syscall invocations where explicitly don't care for the return
value to (void).
Reword a comment.
Lennart Poettering [Thu, 6 Aug 2015 13:46:16 +0000 (16:46 +0300)]
machined,logind: don't generate errors on signal match functions
If we get a weird signal, then we should log about it, but not return an
error, since sd-bus will not call us again then anymore, but for these
signals we match here we actually do want to be called on the next
invocation.
Tom Gundersen [Thu, 6 Aug 2015 12:56:47 +0000 (14:56 +0200)]
Merge pull request #897 from poettering/sd-bus-ignore-bloom-filter
sd-bus: ignore BLOOM_FILTER kdbus items