Remove build warning realted MQ in android JNI.

There is a redefined proprocessor in JniOnMQSubscribeListener.h
since octypes.h has it. it should be removed

------------------------------warning---------------------------------------
jni/JniOnMQSubscribeListener.h:26:0: warning: "MAX_SEQUENCE_NUMBER" redefined
 #define MAX_SEQUENCE_NUMBER 0xFFFFFF
----------------------------------------------------------------------------

Change-Id: If57b79b963d700459a59d2fb8704a60ad019e838
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

tizen: Add iotivity namespace for headers

Currently symlink to parent folder,
 this way it's aligned to yocto recipe.

In longer term it would be nice to rely on scons install rules.

Change-Id: Ie8067c13302ccf92936d599bb4f6b3740d3cf009
Bug: https://jira.iotivity.org/browse/IOT-524
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 5a494b98d65b2950a9331ec77b03ce429ba64cde)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12485

Add ECDSA to cipher suite selection menu

Change-Id: I74efcab80da86123540e5355378ab3b1bb343718
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12889
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13031

RC3 svace fix (cloudClient + crlresource.c)

Change-Id: Ic6093286d89daf6de10ed617c445fbc53d8a3bd1
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12829
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13029

[IOT-1352] SampleApp(CloudClient) goes into infinite loop while testing some features

Change-Id: Ib173abc1968051e2a8ef3dc70e1bbff14bc4d732
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13027
Reviewed-by: Kevin Kane <kkane@microsoft.com>

[IOT-1347] OCCloudAclIdCreate or OCCloudAclIdGetByDevice API doesn't provide the ACL ID Directly

Print aclId, gid, gp in external callbacks (application level, provisioning/sample module)
Print acl, crl, group id list, invite response too.

Change-Id: Ifb9f4ee996030894a31b4317c98a8159e345218b
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12563
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13023

Split cloudClient to Client & Server part

1) Server part creates LED resource
2) Only Client part supports d2d requests

Change-Id: I335f7556a1ef247526886175ebcf400cd9e19b99
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12057
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11781

Update a response representation according to requested interface in easy setup

Referred jira ticket:
[IOT-1408] -
  [ES] Common properties are not exist
[IOT-1410] -
  [ES] /ProvisioningResURI does not support properly for Retrieve
       with interface query

Change-Id: Icb2c8bb5e3c9d796e7f09a7bdd23e895c1f2352d
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

add logic for invalid char

this patch include,
add logic for invalid char in notificationprovider example only.
sometimes, input variable has an incorrect value.

Change-Id: Id8fa6152a7a7f15ef5d54425daf896680d6c9447
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add curl license file

CURL license file is attached so that an example is used the licensed code.

Change-Id: I65e5e136e042329fa6350a7660a24bc5cd3b22ba
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13009
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1383] Update media server to use device and platform info

Change-Id: I4aa4952b658f9202de3790a4424fea4e7e78f4c3
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12835
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

parseChain() fix

parseChain() from ca_adapter_net_tls.c that parse chain of X509 certificates
in DER or PEM format bug fixed. Line endings for PEM certificates corrected.

Change-Id: Ieed09114fea10eb5adb6ff88d59ca58074ea19bb
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12045
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 55072b35a3aac687471a16c99a438e5fa6a02fc8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11687

Add more descriptive log messages in easy setup

This patch is for removing mis-used log messages and
adding one for more convenient debugging.

Change-Id: I354292210a18e16e74d8ae3c0d66b91a90f31ab9
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12963
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update easysetup's security-provisioning logic.

 - This patch indicates the method to reduce security-provisioning time
   by improving the secured-resource search process.

Change-Id: I7cb1a9be272dc92451cf5099afb55c15adeb27ec
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12939
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add DeviceID Parameter on SingleDeviceDiscovery function
this Parameter for discover a specified deviceID
If specify the deviceID, It can discover a specified device
when there is one or more device on the network

Change-Id: I99bff0620ee339a42e22e434099772e4175d73d9
Signed-off-by: Sijae Kim <sijae.kim@samsung.com>
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12065
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Update build scons for notificaiton android sample.

When building notification service on android,
was built just aar file but sample apk.
In this patch building android will be built aar file and sample apk.

Change-Id: I32b9e06600e9063bc8115cd7302c73c938d14e8f
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12817
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add logic for checking the null

Add logic about malloc failed.

Change-Id: I8ac6169f65b00200f9d64fa1572217e53c05435f
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

IOT-1398 Remove CheckFunc() on Win32 API

CheckFunc() is dangerous on Win32 APIs because SCons is not capable
of compensating for __stdcall name mangling on x86 systems using the
Visual Studio compiler.

Change-Id: Iaec49e4d246c02ecfebc5bf70ee0c0620cdde51d
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Fix compilation issue in the security stack

- Some variable were left unused.
- ifdef was
- size_t being print with %d

Change-Id: I22524cd67a9cc4e1b8cd7844c2d81903b8084985
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12885
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit a875cebd84216a1f4e3320e67c432e0cb8914be2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12883

Update the OTM module to guarantee uniqueness of OwnerPSK on the PT side.

Change-Id: I22c9e7c2e81b49bb14c90d5c89744ee478ab108d
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12813
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 03adc4fa8aaf36f5de585be00efc6198b38ded14)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12945

[IOT-1366] coaps request for secure resource

with this patch, all the request coming over insecure channel for secured resource will be rejected

Change-Id: I5b24c4095d99f6b6f6080b1f46f1fd4d9f0d8e20
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12621
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 811d62de05664975cc2b36585ba719167d1bc1ea)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12875

Revert "Update easysetup's security-provisioning logic."

This reverts commit d4ba3134a1178396c0bcc049645081c4a7dc814e.

Change-Id: I4214de42969dfee194a1278a1a68c77446909e9f
Reviewed-on: https://gerrit.iotivity.org/gerrit/12933
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add logic for sending responses according to the interface of requests.

This patch include,
Generate response for each of interface
and Add handling about exception cases.

Second patch include,
1. change NS_DEFAULT_INTERFACE to NS_INTERFACE_BASELINE
2. Add first patch logic into Topic case.

Change-Id: I7aa5868fc9a4b4537964c8bdf92b1f15d058d892
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12787
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update easysetup's security-provisioning logic.

 - This patch indicates the method to reduce security-provisioning time
   by improving the secured-resource search process.

   https://gerrit.iotivity.org/gerrit/#/c/12065/7

Conflicts:
        service/easy-setup/mediator/richsdk/src/EnrolleeSecurity.cpp

Change-Id: Ib2f60d6524b2cf068922c4ddfb17f4bd12b435d1
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12795
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[Hotfix] Modify the incorrect DTLS handshake callback registration for OTM.

Change-Id: I60679e8283e252236c9093bcdb3ab9f355f27881
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12881
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Added implementation for getDeviceId and setDeviceId

code formatted

Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Change-Id: Ic0d640638bd0c1a258db6c21bbecbd73e2c6dd3f
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10621
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>

Change the property of topic resource

The resource property of topic is changed from DISCOVERABLE to NONE.

Change-Id: I670dbd26725171b7639061062bdb412e0ace7a81
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12863
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for invalid access variable.

when access consumer main thread but  initialized, service will crash.
So this patch prevent invalid access to not initialized thread handle.

Change-Id: I77d86a712e0efe6bbec17780426df4a5ba98decc
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12815
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for multiple extras of message.

When the receive multiple extras in the message from notification provider,
consuemr service misparse as parsing just one extras for incorrect operation of pointers.
In this patch, incorrect operation of pointers is fixed.

Change-Id: Ifacaf247ca836d81031ffe93b0b72d2b46db65f3
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12745
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add more provisioning status and error code in provisioning resource

To describe more specific provisioning status and error in easy setup,
some status and error codes are added.

Change-Id: Ibd37d207b55d6d6274380d2fd9aff0771c7c9911
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

RD updates

- [Server] Includes a new functionality to store RD details in the database.
- [Server] Use SQLite to store details Published details in the database.
- [UnitTest] Added rdtest to be built as a unittest
- [Service] Moved Client code from resource/csdk/stack/src to
  resource/csdk.
- [Build] Updated auto_build to use RD_MODE flag instead of WITH_RD flag.
- [Cleaning] Removed all RD types in the octypes.h
- [PayloadHandling] rdpayload handling is removed from ocpayload.
- [PayloadHandling] All payload is created in services/resource-directory.
- [PayloadHandling] Uses OCRepPayload to create RD Payload.

Change-Id: I0a32c01ca6b5db1ad36141667e1ee94e545be290
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Enable AclVerifyResource line added

Change-Id: Idbc16ae7893ce57eb4f5b0e7473693dab2a05288
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12717
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 76286f9dae19891813b0bba9af33b646415ec86b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12801

added cloud provisioning android application

Change-Id: I4f544c2b665543c4a8f3bec422598f5e7cb8e958
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12175
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix the incorrect credential access in SRPProvisionTrustCertChain.

SRPProvisionTrustCertChain deletes credential list.
But this credential list is read from global credential list through GetCredResourceDataByCredId API.
So credential list should not be deleted in SRPProvisionTrustCertChain.

Change-Id: I8c143d320ead4aea99daaa7d6882c11cfddf26e2
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12377
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit d1e4e09eafc15211e0b0a83d6aa8fb1dad8f979f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12793

exclude unnecessary jave file related cloud provisioning

Change-Id: I7a2e3d5c1e5662d20734dd70a8adcbbe6f60ed3e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12767
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Correct observe callback function in occlient.

1. For observe register request, Sequence number received
in client response falls in range 0 - MAX_SEQUENCE_NUMBER.
2. For observe deregister request and or any failed requests,
the client sequence number value is MAX_SEQUENCE_NUMBER + 1.

Change-Id: Idcc0775179e17ce6df85fb93f127336fede9a42a
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11695
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1389]Release netlink socket event in Android ip adapter

Netlink socket event is never released in Android ip adapter.
The reason is the function "CAFindInterfaceChange" should listen event
from netlink socket for release socket event, but it didn`t.
So, we should listen and release netlink event from netlink socket.

Change-Id: I221682d4f0dde5a902670ce54eba797c30c09911
https://jira.iotivity.org/browse/IOT-1389
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12749
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Change DevOwner access policy to address JIRA 1369

This changes the Policy Engine to grant requests from DevOwner
without checking ACLs ONLY if the device is not in Ready for Normal
Operation state, AND the request is for a SVR.

Change-Id: I9aa4314cc2beb9fdb4629c1e63ea6971f7cc8909
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix build fail of notification android.

Android building execute on notification SConscript.
And bug for build fail is fixed.

Change-Id: I6fad802576f34c32f5b2a36e3af23e2a89af2d65
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12627
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tizen: Display verbose log

Split args line to enhance readability.

Bug: https://jira.iotivity.org/browse/IOT-1260
Change-Id: I4c1cdd41dfef7120c336df8e6c6c027f80126909
Origin: https://gerrit.iotivity.org/gerrit/#/c/11509/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11509
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

IOT-1378 Fix windows\CAIPNWMonitor.c

* Allow IPv4 and IPv6 to coexist. Previously, these two
  modes were mutually exclusive.

Change-Id: I5c04289590b0edd58dc854722c0288a99b4c70c9
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12577
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1330] Fixed build error caused by calling tinydtls build script twice

When building android build with SECURED=1 there is no need to call the tinydtls
build script it is build as part of the csdk.

See: resource/csdk/connectivity/src/SConscript line 60

Change-Id: Idf140944f81ca33369a42f2986e526b38882a3f5
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12675
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Make iotivity compile in a way usable by windows store apps

Replace GetTickCount with GetTickCount64
Replace CryptGenRandom with BCryptGenRandom

Change-Id: I867f1325d576e52c10466abd7620802351b743c5
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12701
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>

Dynamically generate coap_config.h

Change-Id: If9b8199df71940f5b8a860f03292ca81dcd8e6ca
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12351
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Refactor unit test linking

* Build an octbstack_test static library.
* Link test executables against aforementioned static library.
* Remove octbstack_test.def file.
* Light cleanup of various SCons scripts

Note: This patch also fixes an issue where the build would fail
when TEST=0 was specified on Windows.

Change-Id: Ied7457fd5857396f4ce32bff37380998d66adeff
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12115
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

build: Format SConscript as consistant python source

Use 4 spaces for tabulation

Bug: https://gerrit.iotivity.org/gerrit/#/c/9783/4
Change-Id: I5b27d4c573e43d1c7b069ec417133340f8c36a44
Origin: https://gerrit.iotivity.org/gerrit/#/c/11265/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Fix build order of iotivity_config.h

We should run the c_common SConscript to generate iotivity_config.h
before liblogger is built. This is because logger.c will include
"iotivity_config.h".

Change-Id: I6332e403a5ce457e682ff764b9d20899cf26aea3
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

MAX_URI_LENGTH was being redefined at multiple places

MAX_URI_LENGTH was redefined at multiple places. It is defined in
ocstackconfig.h and should not be redefined at other places. Please
note this was only done in the sample code.

https://jira.iotivity.org/browse/IOT-1218

Change-Id: I334f028779f202a4371a1409d4e3ce69cd40d121
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11153
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Ignore tmp folder as used for local building

This temporary folder is used to build out of sources.

Change-Id: I88dedd1f019cb67196d1980a6171f513c82b19cb
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

svace fix

Change-Id: Ibcc7b545bfefb6861bdfecf954ca24b158229150
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12179
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 09b36dbf20ce323a95c97101c7d068cf24138731)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12639

Prevent duplication of aclid with same di

Prevents duplication of aclid linked to the same di

Patch #1: Initial upload

Change-Id: I586f494877aa57ad3fa51c3acbcb53442da5c363
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12551
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4f299105fbd7572a12aa4fb4647aa952c1013345)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12633

Update the CADtlsClose API to remove the DTLS peer when closing temporary DTLS session.

Change-Id: I5b04178ff5bb291a08961066a2f44b35522849c8
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12617
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>

Fix for request to secure resource server.

When send to discovered secure resource server,
client should change port to secure channel port.
But, it is not apply at notification consumer service.
In this patch, when discover secure notification resource
consumer service will send request with changed port for secure.

Change-Id: Ib8101753be76996fa4978d7714e8cf474278f771
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12561
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Throw OcException for invalid (null) parameters in Java Layer of android_api

[IOT-1323] -- [RI][Android] observe(with QualityOfService) API does not throw OcException while passing parameter-observeType as Null value

Change-Id: If0d7acb0f5bbfda75e2fd774b6cccc8ce21e5650
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Andorid(JNI) Implementation for Cloud Provisioning.

Patch #1: Add JNI interface for getAclByDeviceID API.
Patch #2: Fixes.

Change-Id: I0e8b09f9f1be66d202834e56f3d535604f6a766b
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>

Fix for Jira issue: IOT-1252

Simulator error codes compatible with OC stack error codes

Change-Id: If03fff46fae4144db4318c5e5d95c97c9ae377fd
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12335
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Svace fixes for Notification service C++ changes for formatting

Change-Id: I58404514f8f5112fa7897dc3771595ba84a8c8f9
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12435
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1363] Fix from C++ changes

patch 2 : resolved merge conflict

Change-Id: I535084c3e1c9fcf302038ccbf98aaff02cd97167
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12343
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Modify generating notification consumer id.

generating consumer id is replaced with device id generated by base layer.

Change-Id: I4e8157b938c0e9ea524c838d7d355443f9bb0c41
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify coding idiom and unittest, Add function declaration.

this patch include
1. modify coding idiom.
2. modify unittest about delay time.
3. add function declaration about NSSetResourceSecurity.

Change-Id: Id992c731f057580c060ccf08daee54ba6656250d
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12517
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Delete NSStorageAdapter header file.

NSStorageAdapter.h file is used by both of provider and consumer.
For the above reason, when import both library, app will crash or build fail.
So in this patch,
NSStorageAdapter.h file is deleted, and related function was renamed.

Change-Id: Iaa243334e644014ea16eefd7338e90b112c0b633
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12535
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for parse payload on notification service.

When the parsing payload on introspection of notification resource,
finding mandatory logic is incorrect on a payload.
In this patch, finding mandatory logic is fixed.
And incorrect typing is fixed,
enable running of consumer test on building with TEST option.

Change-Id: I707ebe06eed49c00f5d7c850dd82a93424fc8ce1
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12513
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

annotate OIC_LOG_BUFFER when looking for client callback and observer

Printing all token info while looking for client callback or observer
is burden and makes it hard to see entire log message
even though it is needless.

Change-Id: I25e0c3f1922f207a9d6652017495270db34e6bbc
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12375
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1324] Fix crash issue which call getPlatformInfo with QoS.

The Listener for getPlatformInfo with QoS used DeviceInfoListener.
So, it replace with PlatformInfoListener.
(it was occurred in Android Platform)

Change-Id: Ia9f0530465267a6f338dc67ba42a8c5b396271ef
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12293
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit c4dbbd77989f236ab1ae900b45a764cf2eb5d024)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12507

disable fragmentaton file when BLE is not included

Change-Id: I77105748503fcffe8c815b09db5295dc9dc292cf
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12341
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 790ac8a8fc696c4fcfc134a32d20629475f580a2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12509

Clean up handling argument of the gbsbuild script for Tizen.

Change-Id: Idb7925a3b83bfe31b66139af72597310c9bb3b1e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12253
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add gnustl_shared library.

For support Android API earlier than level 18 (Android 4.3)

Change-Id: I7b1eefd05a9ff1c8b7f93fadc7596920531725e7
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11483
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1346] Enable network status monitoring for tcp network

In case a connected wifi ap is changed, we have to close
the connected session previously. Otherwise we will use the
invalid session. If network status is down, we try to close
the session. and If network status is up, we create new socket
for listening.

Change-Id: I662df1a9a28d0ca629a8b23f83f94833787c5312
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1351] CloudClient App crashed while Signing Out

[Patch #2] Resolve possible crash reason on 32-bit arch
[Patch #3] Implement correct Sign Up/In/Out flow according to spec

Change-Id: I566dcedee363ab91ecec883e531cdb8ad6fa1f42
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit ae968b32534707581ed0926a5ced00168e63e6c9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12545

Added Cloud provisioning java class

Change-Id: I57a37af84f2202051d99627cfbc18bad6de5d8e4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11339
Reviewed-by: sandeep sharma <sandeep.s9@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removed svace defects

Change-Id: I63cfad7d1b507c4bcb3d6714880e14971bd231cc
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12199
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
(cherry picked from commit 6e9a85dffe9e363a6f44dc2a75fc29be7023dbac)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12541

Modify AddCredential API to prevent invalid CredID generation

Three patches combined together
1. Add checking credential uniqueness
- Prevent credential duplication by checking when saving credential
http://suprem.sec.samsung.net/gerrit/#/c/92486/
2. Update the CompareCredential API
- Update CompareCredential API to improve readability
http://suprem.sec.samsung.net/gerrit/#/c/93190/
2. Modify AddCredential API to prevent invalid CredID generation
- Prevent invalid CredID generation
http://suprem.sec.samsung.net/gerrit/#/c/93042/

Patch #3-4: Build error fixed
Patch #5: Old comment removed

Change-Id: I14c16ade352c2011d6b124c374a6b1cece1a0d4d
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2c2788972e68024300ec2bcbd9a0aa1f440f72ee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12539

[IOT-1350] Multiple APIs Return OC_STACK_OK if callback is absent

Add appropriate comments to public API

Change-Id: I08178de15e047234e470e157c5c2b07a9f956cba
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 64829896fb9d59e5caaea4a17a85cef2b16f65a7)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12537

ACL fix for supporting few ACEs

Verified using 41 request
(read user input, convert it to OCpayload, parse it and save to db)

[Patch #5] Correctly clean-up single-linked list in 41 request

Change-Id: Id2da459f776ae756cff4408688143946c7085de9
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12041
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 552951a50ee2264ebf6723c0c08cdd7c356fd14d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11707

To build static libarary from CSDK

Change-Id: I8e1e7a3ca76780cbedefdcfd2c84fbf316ed3058
Signed-off-by: daeken.kwon <daeken.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11611
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

IOT-1302 Thread-unsafe code in oicgroup.c

Remove potential thread safety bugs in oicgroup
Make RD mutex implementation work on Windows
Remove duplicate mutex implementations

Change-Id: Ie47b24619a10ab3d9cab2d421f3a7d8be7ac7b55
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>

Throw OcException for invalid (null) parameters in Java Layer of android_api.

[IOT-1254] -- OcPlatform.notifyListOfObservers() ocObservationIdList is null.
[IOT-1255] -- OcResource.observe() observeType is null.
[IOT-1256] -- OcPlatform.bindResources() ocResourceHandleList is null.
[IOT-1257] -- OcPlatform.unbindResources() ocResourceHandleList is null.

Change-Id: Ib1c20dba6d0e85a05e8099ba1276d65334560c9d
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11877
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Fix a wrong variable name in enrolleesecurity.cpp

In cert provisioning callback, certResult variable should be used.

Change-Id: I0ab9b7d0c688c8c819240231529ba7975eec869f
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12419
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fix the bug in RemoveDeviceInfoFromLocal API

Fix the bug in RemoveDeviceInfoFromLocal API
in case of remove the single linked device
http://suprem.sec.samsung.net/gerrit/#/c/93085/

Change-Id: I88f025cb589a7893323197aa321d312d62f9be52
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Remove unnecessary resource properties for ACL

Observable and Explicit discoverable flags removed for ACL

Change-Id: Iec22c29acfdc1da087a3d999889da74a47779210
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12171
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit e34781eab632c8af1f6c4c12a5e666cb4dfaaf75)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12409

Update icv and dmv version to 1.1.0.

Bug: https://jira.iotivity.org/browse/IOT-1360
Change-Id: Icc3065f285481f443f3028db01d0ec3f67e47646
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12305
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>

Added ExtraInfo representation to the Notification Service Message

1. Modified the required changes for ExtraInfo in C++ layer
2. Modified the JNI for extraInfo conversions
3. Added a feature to create NonSecure resources while building with Secured option

Patch 2 : updated the review comments

Change-Id: I54f13ec9de564b52dbe86f2b2731a32350175223
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fix warning codes in Easysetup

Change-Id: I98657cf28e67db3956540a7a27eb4a7fc28d79ac
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12309
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix to apply Coding convention on services.

Change-Id: I9bdb0e8147bcbbad6a28a6635cd7c4c3c16d9359
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

modify results of static analyzer.

this patch include
almost check the null about malloc case.

Change-Id: I873362768d6010b63039d7c6d3d9f10912344953
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12393
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update resource type and attribute

Implementation of resource has a gap with requirement.
Resource type and attribute are changed.

Change-Id: I80a22ab92fa5c0a8d01425e242569624ba35c105
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12311
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fix bug with unittest about topic.

this patch include,
1. fix bug about topic API lock.
2. modify unittest for related topic.

second patch inlcude,
rename variables name.

Change-Id: I7f6768e367b016cc58e14c14e1e94c27e08289ad
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12273
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for topic is changed to empty.

When the provider delete topic, consumer never callback changed when topic is empty.
In this patch, consumer will callback changed topic to upper layer
when topic is empty from not empty.

Change-Id: I41d0ad42f19298ce2773ab4c17d37cd7c1aa6b5e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for invaild parse mediaContents.

When consumer service receive message and parse mediaContents,
sometime app crashed cause by mediaContents consist in the payload but this value is invalid.
In this patch, added logic for check to consist and correct mediaContents.

Change-Id: Iff2be18efce2697843ea5c73074ada72d2eb751b
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tinydtls: fix some compile warnings

This fixes multiple compiler warnings.

Change-Id: I403fb09b6b8ffc4bc1ca2cc03c90605d9005f8d5
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4823
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fixed JIRA tickets:
For [IOT-1314,1315,1316]
Fixed null pointer dereference.

Change-Id: I3d824b8c585b818a9c376b6e8466941c3044a1c8
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12211
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[IOT-1354] Multiple APIs crashed instead of returning OC_STACK_INVALID_PARAM while endpoint is kept NULL

Change-Id: Ie04acb860f5c06d298940db9944086eb929baf05
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12337
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6dfe30611bfe104aed8aeedcd0bf85b23d820263)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12385

Replace gets function

gets() function does not check for buffer length
and always results in a vulnerability.

Change-Id: I74abbe3f8a746513bb955455891ab1ca4746f1a7
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12395
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1332] add unregister network state changed callback in APIs

As apply multi network state changed callback,
Unregister API is added.
https://gerrit.iotivity.org/eventIndexgerrit/#/c/11505/

Change-Id: I417f6f7cfebd92c9dc120386d0146666df8ffa30
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11969
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Remove OC_REST_CANCEL_OBSERVE from OCMethod.

OC_REST_CANCEL_OBSERVE was created for internal uses but
has not been used. Since it is defined as one of OCMethod,
Users attemp to call it in OCDoResrouce(...). OCDoResrouce(...)
is to discover or Perform requests on a specified resource and
OCCancel(...) should be used to cancel the operation supported in
OCDoResource(...).

Bug: https://jira.iotivity.org/browse/IOT-1240
Change-Id: Ie40d8961949f1fa3f0c2c04899c58d6ae62241af
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11703
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

RM fix for JIRA issue [1342]

https://jira.iotivity.org/browse/IOT-1342

Change-Id: I80a8d442f93ac0f197029f32bc0918b668c2d708
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12325
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1335] Add check connectivityType when cancelObserve.

If adapter is IP and QoS is Low, delete observe list.

Change-Id: I232321d82ec2991da791587e0275c20fcc91c912
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11971
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Close tls session with tcp session

[Patch #2] Move it before socket close

Change-Id: I5bede5ab75b4e67faff932e77c30565062916c95
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 27cec1f345003807cf719fe69c46660b5363b527)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11951

Print Acl Id & minor updates

Change-Id: Ib6b48be6e9f5da3dafb27632b2b93a986b6da2ab
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12323
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1331] Arduino with SECURED=1 prints build failure

Arduino does not support security at all. The crypto
stack is not avalible. If the SECURED=1 option is
provided the build will instantly fail.

Change-Id: I2fd72b5debf05d214b606a1ff95da1161b6da4a9
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12227
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>