Peter Hutterer [Wed, 11 Jul 2018 06:34:22 +0000 (16:34 +1000)]
quirks: append "Touchpad" to the various dell touchpad quirks
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 11 Jul 2018 05:04:25 +0000 (15:04 +1000)]
quirks: remove the leftovers of the trackpoint range attribute
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 11 Jul 2018 05:01:18 +0000 (15:01 +1000)]
quirks: remove the trackpoint range quirks entries
The only trackpoint where I have a rough idea what we need is the ALPS v8 one.
All other ones we'll have to re-do.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 9 Jul 2018 06:04:50 +0000 (16:04 +1000)]
filter: add a trackpoint multiplier factor
Measuring the trackpoint range has not shown to be sufficient or precise
enough to be used as an ingredient for trackpoint acceleration. So let's just
switch back to a generic multiplier that we can apply to the input deltas do
undo any device-specific lack of scaling.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 9 Jul 2018 06:00:45 +0000 (16:00 +1000)]
quirks: add quirks_get_double()
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 29 Jun 2018 05:09:47 +0000 (15:09 +1000)]
tools: make-ptraccel-graphs: drop an unnecessary outfile
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 05:54:55 +0000 (15:54 +1000)]
tools: drop the special handling for trackpoint accel, not needed anymore
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 29 Jun 2018 05:15:20 +0000 (15:15 +1000)]
tools: reduce the trackpoint gnuplot range to 0..1 units/ms
Anything above 1 unit/ms is high pressure. Though that depends on the
trackpoint range, so...
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 05:54:04 +0000 (15:54 +1000)]
tools: fix units for trackpoint accel graph
We use speed now and trackpoints are in units/ms
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 05:53:23 +0000 (15:53 +1000)]
filter: make the trackpoint accel profile func the same prototype as the others
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 5 Jun 2018 04:54:50 +0000 (14:54 +1000)]
filter: replace the trackpoint accel with a velocity-based one
This gets rid of the trackpoint range propery that we've been parsing until
now and instead just opts for a basic curve with some deceleration for low
pressure. The speed range is taken from the touchpad and should be wide enough
for most trackpoints that fall within the expected range.
Trackpoints like the new ALPS ones need to be configured through a hwdb (this
part is currently missing).
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 10 Jul 2018 08:00:07 +0000 (18:00 +1000)]
doc: add a subsection on how to use libinput record --autorestart
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 10 Jul 2018 07:45:58 +0000 (17:45 +1000)]
doc: libinput-measure is a section, not a subsection
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 04:24:54 +0000 (14:24 +1000)]
tools: don't add the debug behavior for release builds
When the meson build type is something other than the debug types, we don't
need the special behavior where we adjust executable paths and data dir
lookup for tools run directly from the builddir.
This avoids leaking the build dir into the final executables.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 04:01:25 +0000 (14:01 +1000)]
tools: fake-build the other tools the same way as measure touchpad-tap
Doesn't actually do anything but this way they end up in the builddir and can
be picked up by ./builddir/libinput measure fuzz, etc.
And rename the source files to .py to signal that they are not supposed to be
directly executed.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 03:44:18 +0000 (13:44 +1000)]
tools: rely on the libinput and quirks tool to pick the right directories
Don't use a custom hack here, just make sure the tool ends up in the builddir
so it's picked up by the libinput main tool.
This means the PATH isn't set up correctly when called directly
(./builddir/libinput-measure-touchpad-pressure) but the workaround is to
always use the libinput tool - just as we expect from users.
To make it more obvious that we're not supposed to run this directly, rename
the source file to .py
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 03:36:52 +0000 (13:36 +1000)]
tools: quirks: if we're executing from the builddir, use the git datadir
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 03:26:51 +0000 (13:26 +1000)]
tools: if the execdir is the builddir, add it to the path
When running libinput tools from the builddir, look up the subtools in the
builddir as well. Otherwise, add the install prefix to the list of lookup
locations.
This ensures that a) we're running builddir stuff against builddir stuff, but
also b) that we're not running builddir stuff against installed stuff because
that may give us false positives.
The test was squashed in from a separate patch and was
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 02:17:26 +0000 (12:17 +1000)]
doc: drop the git version into the documentation
The libinput/doc/latest is now built automatically from git, so it's good to
have a reference to show which commit it was being built from. Add a section
to the readme with git commit information that is replaced by meson.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 03:34:22 +0000 (13:34 +1000)]
Switch to using files() for the doxygen input sources
Using files() over a list of hand-constructed paths is the recommended way.
But unfortunately doxygen needs its input files as a string list, so we still
have to build that list anyway. Still, this way we don't need to hardcode
every file with the source root, we just assemble it as we go.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 6 Jul 2018 00:12:32 +0000 (10:12 +1000)]
GitLab CI: only rebuild the website when pushing to libinput proper
We don't want to try build when someone pushes to <username>/libinput
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 04:13:33 +0000 (14:13 +1000)]
Gitlab CI: trigger the wayland web rebuild on pushes to master
This requires that WAYLAND_WEB_TOKEN is set up in the libinput settings on
gitlab.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 23:35:53 +0000 (09:35 +1000)]
GitLab CI: move the scan-build job up in the file
This is by far the slowest job, move it up so it gets started earlier and we
have more parallelization going on.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 03:55:21 +0000 (13:55 +1000)]
test: misc: up the time limit on the ratelimit tests
I keep hitting this in the gitlab runner, 100ms is clearly not enough here for
slow containers.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 02:00:31 +0000 (12:00 +1000)]
doc: add the switches page to a "other devices" category
It felt a bit lost at the bottom of the "pages" list.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 3 Jul 2018 03:40:45 +0000 (13:40 +1000)]
doc: build doxygen output into "Documentation"
Slightly more obvious than just "html". Main motivation here is that we want
to provide the documentation as artifact from GitLab's CI, so having it unzip
to something slightly more meaningful makes sense.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 5 Jul 2018 00:28:56 +0000 (10:28 +1000)]
GitLab CI: rename MESON_PARAMS to MESON_ARGS
More correct, and we use NINJA_ARGS too
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 4 Jul 2018 04:38:33 +0000 (14:38 +1000)]
Gitlab CI: run the tests through valgrind on the f28 box
We don't run it on all machines, valgrind fails right now on arch because of a
memleak in bash itself. To avoid having CI failures that aren't our fault,
only run on F28 because that's the one I'm tracking.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 3 Jul 2018 06:03:51 +0000 (16:03 +1000)]
GitLab CI: always run ninja test unless otherwise specified
Now that the test suite has been cleaned up to be useful even when we can't
run the main runner, let's always run ninja test. Except in the targets where
we want something different.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 26 Jun 2018 03:15:13 +0000 (13:15 +1000)]
tools: rename list-quirks to the more generic "quirks list"
Enables us to easily add more tools where needed and it is
more consistent with the existing tools.
The commands are now:
libinput quirks list
libinput quirks validate
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/66
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 3 Jul 2018 03:06:13 +0000 (13:06 +1000)]
GitLab CI: don't use spaces in artifact names
Apparently that doesn't work anymore
Related to https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/41
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 29 Jun 2018 03:43:15 +0000 (13:43 +1000)]
fallback: cancel the debounce timers during device remove, not destroy
destroy isn't called until the last libinput_device_unref(), so we may trigger
a debounce timer after the device was removed. The same fix is neded for the
touchpad interface.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/72
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Hans de Goede [Fri, 22 Jun 2018 16:40:27 +0000 (18:40 +0200)]
system-quirks: Add AttrTrackpointRange for Lenovo X270
The trackpoint on the Lenovo X270 sends delta events with a value
of up to 40.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 11:13:30 +0000 (21:13 +1000)]
gitlab CI: build a release with -Werror
Any compiler warnings in the default build are likely caught by developers
anyway. Let's build one with -Werror and the release buildtype to catch
anything triggered by optimization or somesuch.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 11:03:50 +0000 (21:03 +1000)]
doc: fix typo in pointer acceleration docs
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/69
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 27 Jun 2018 04:10:57 +0000 (14:10 +1000)]
tools: add record/replay to --help output
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 06:39:01 +0000 (16:39 +1000)]
tools: libinput-record: print the list of quirks
Now that all device quirks are in the quirks subsystem we have to print those
instead of just the udev devices.
Since libinput-record is there to record system devices, the system-installed
quirk list is used (without any commandline overrides right now). This is
useful to capture misconfigurations or missing quirks on the host system.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/58
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 06:37:16 +0000 (16:37 +1000)]
tools: move printing device quirks to the shared tools lib
This way we can re-use this from libinput-record instead of having to
duplicate all this. Since the two tools use different printfs, just make the
actual printing a simple callback.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 25 Jun 2018 06:06:34 +0000 (16:06 +1000)]
test: parse arguments before any other stuff
If the args are bad, we don't need to check for root and whatnot.
Only exception here is the debugger check because it changes defaults that we
may want to override with commandline arguments later.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 25 Jun 2018 04:50:22 +0000 (14:50 +1000)]
touchpad: don't disable tapping on MT_TOOL_PALM
The tapping code can handle palm states now, so there is no need to disable
tapping altogether when a tool-based palm is detected.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/65
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 04:38:55 +0000 (14:38 +1000)]
tools: fake-build the measure touch-pressure/size sources
This way we can make them execute the list-quirks from the builddir. And it
makes it easier to run these tools from the git directory on machines where we
have libinput without the quirks.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 07:05:30 +0000 (17:05 +1000)]
test: add a libinput-test runner for 'deviceless' tests
These are tests that don't need *any* uinput devices at all. Mark them
accordingly and create a new binary that only runs those tests. This way we
can run some of the test suite even in containers where we're restricted.
Better have 10% tested than none, I guess.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 06:57:51 +0000 (16:57 +1000)]
test: switch the global device list to a struct list
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 06:49:56 +0000 (16:49 +1000)]
test: fix indentation in litest-int.h
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 06:13:35 +0000 (16:13 +1000)]
test: quirks: init value to avoid valgrind errors
value isn't touched where the quirk doesn't exist, so we're accessing an
uninitialized variable here.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 05:47:18 +0000 (15:47 +1000)]
test: if we never installed any udev files, we don't need to reload
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 07:03:31 +0000 (17:03 +1000)]
test: init test quirks in /tmp, not /run
We don't need to be root to write to tmp
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 07:18:48 +0000 (17:18 +1000)]
quirks: free the dt string
Not sure how that got through the valgind test before...
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 03:34:59 +0000 (13:34 +1000)]
gitlab CI: add Arch to the list of built images
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 22 Jun 2018 03:29:09 +0000 (13:29 +1000)]
gitlab CI: add pkgconfig to the list
It's pulled in by some dependency anyway, but for the sake of being explicit,
pull it in.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 23:36:20 +0000 (09:36 +1000)]
util: use assert() instead of abort() for testing for size limits
This way we can send a message to the user, a simple abort() isn't informative
enough.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/54
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 06:16:08 +0000 (16:16 +1000)]
test: don't require a device for quirks parsing tests
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Konstantin Kharlamov [Wed, 20 Jun 2018 11:09:58 +0000 (14:09 +0300)]
libinput-private: constify inline helpers
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Peter Hutterer [Thu, 21 Jun 2018 05:03:49 +0000 (15:03 +1000)]
gitlab CI: run ninja test too
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/62
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 05:32:02 +0000 (15:32 +1000)]
test: skip the test-suite runner based on SKIP_LIBINPUT_TEST_SUITE_RUNNER
The current /dev/input/* check isn't reliable enough. So rather than adding
extra heuristics prone to fail add an environment variable that says "do not
run the test suite runner". All other tests are run since they do not
require/modify any specific system setup.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/62
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 04:07:02 +0000 (14:07 +1000)]
tools: libinput-replay: set INPUT_PROP_* properties on the device
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/60
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 03:49:41 +0000 (13:49 +1000)]
doc: update docs to use a .yml suffix for libinput recorded files
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 03:48:26 +0000 (13:48 +1000)]
tools: libinput-record: use .yml suffix in the man page
Makes things easier when users save it as yml file
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 04:59:58 +0000 (14:59 +1000)]
test: fix zalloc max size tests
Missing from
9873d68bf1f93b424f920a8c095e3d3ee7d3fdf5
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 01:43:52 +0000 (11:43 +1000)]
tools: touch-size: update to use the device quirks
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/57
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 01:41:25 +0000 (11:41 +1000)]
tools: touchpad-pressure: update man page for device quirks
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/48
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 01:34:11 +0000 (11:34 +1000)]
Merge branch 'wip/measure-thumb-pressure'
Peter Hutterer [Thu, 21 Jun 2018 01:08:17 +0000 (11:08 +1000)]
doc: use @verbatim, not @code for shell commands
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 21 Jun 2018 00:58:34 +0000 (10:58 +1000)]
doc: update docs to drop hwdb references
In favour of the device quirks system.
Fixes #55
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Sergiusz Michalik [Wed, 20 Jun 2018 17:34:28 +0000 (19:34 +0200)]
zalloc limit fix for libinput-record
Peter Hutterer [Tue, 19 Jun 2018 07:33:01 +0000 (17:33 +1000)]
tools: touchpad-pressure: add thumb pressure handling
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/49
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 07:17:31 +0000 (17:17 +1000)]
tools: touchpad-pressure: switch to using quirks for pre-loading thresholds
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/48
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 06:35:44 +0000 (16:35 +1000)]
tools: list-quirks: make the output easier to parse
Print the "has no quirks" to stderr to keep stdout tidy.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 05:48:54 +0000 (15:48 +1000)]
tools: list-quirks: print the value of the quirk too
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 20 Jun 2018 03:07:38 +0000 (13:07 +1000)]
data: lenovo: fix device name for the X1 Carbon 6th
Possibly a typo, who knows.
https://gitlab.freedesktop.org/libinput/libinput/issues/46
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 06:47:45 +0000 (16:47 +1000)]
tools: list-quirks: add the thumb pressure threshold property
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 06:43:52 +0000 (16:43 +1000)]
tools: list-quirks: fix usage to read "libinput list-quirks"
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 05:45:35 +0000 (15:45 +1000)]
tools: list-quirks: compress a condition
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 06:48:58 +0000 (16:48 +1000)]
quirks: drop the JUMPING_SEMI_MT model
Removed from the udev properties in
a55693f87c58c24b6866ed0f38c5470124be3df7
but survived here while the branch was in process.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 20 Jun 2018 00:13:47 +0000 (10:13 +1000)]
meson.build: add more overrides for coverity
"/usr/include/math.h", line 381: error #20: identifier "_Float32" is undefined
# define _Mdouble_ _Float32
Same for a few others. Since we don't actually need those anyway, we can just
cast those to the some close-enough sizes. We don't have stdint.h in config.h
and meson cannot have a custom #include line in the config object. So let's go
with what does the job for now.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Matheus Santana <embs@cin.ufpe.br>
Peter Hutterer [Tue, 19 Jun 2018 23:34:30 +0000 (09:34 +1000)]
util: abort if we try to allocate more than a MB
The ssize_t cast upsets coverity for some reason but we can be a lot more
restrictive here anyway. Quick analysis of the zalloc calls in the test suite
show the largest allocation is 9204 bytes.
Let's put a cap on for one MB, anything above that is likely some memory
corruption and should be caught early.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Matheus Santana <embs@cin.ufpe.br>
Peter Hutterer [Tue, 19 Jun 2018 22:15:14 +0000 (08:15 +1000)]
meson.build: add a libinput list-devices run to the test suite
This will only catch a segfault or some other bug since we don't actually look
at the output. But that's still better than not running it at all.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 23:54:25 +0000 (09:54 +1000)]
tools: list-devices: unref the udev device
Fixes a memory leak that prevents us from running list-devices in valgrind.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 21:56:05 +0000 (07:56 +1000)]
tools: pass a valid grab parameter to list-devices
My kingdome for a compiler warning. Or a scan-build warning. Or a coverity
warning. Or anything... But no, nothing.
Also make the open_restricted() more robust to a NULL userdata, because
effectively that's what we were passing here.
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/50
Introduced in
0a13223c39fdf0f079715bf83d498c0dcd9cf4f8
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Benjamin Tissoires [Mon, 18 Jun 2018 13:13:17 +0000 (15:13 +0200)]
CI: WIP: attempt to clean up the registry before leaving
According to multiple sources, referenced in
https://engineering.facile.it/blog/eng/continuous-deployment-from-gitlab-ci-to-k8s-using-docker-in-docker/
The garbage collector of the registry won't clean up docker images that
still have blob references. We should clean up the manifests instead
of simply overwriting the tag.
Note: this requires to set up a personal token with api access from the
maintainers in the form of (for instance): "PERSONAL_TOKEN_bentiss"
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Benjamin Tissoires [Mon, 18 Jun 2018 07:34:10 +0000 (09:34 +0200)]
CI: speed up the docker_check stage
There is no point in login in to the registry if there is no need to
create a new docker image.
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Benjamin Tissoires [Fri, 15 Jun 2018 20:15:40 +0000 (22:15 +0200)]
CI: do not pull images when checking for the creation date
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Peter Hutterer [Tue, 19 Jun 2018 03:27:42 +0000 (13:27 +1000)]
doc: point to the gitlab ci file for a list of required packages
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 03:13:24 +0000 (13:13 +1000)]
test: remove a compiler warning
Leftover from a previous iteration of this code - having a static but
unnecessarily large size for dirname results in:
../test/litest.c:1251:38: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
snprintf(dest, sizeof(dest), "%s/%s", dirname, filename);
^
../test/litest.c:1251:3: note: ‘snprintf’ output 2 or more bytes (assuming 4097) into a destination of size 4096
snprintf(dest, sizeof(dest), "%s/%s", dirname, filename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 19 Jun 2018 03:07:12 +0000 (13:07 +1000)]
quirks: add more assertion to avoid API misusage (v2)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 10:55:03 +0000 (20:55 +1000)]
Revert "quirks: add more assertion to avoid API misusage"
Ooops, this clearly didn't get tested and now aborts libinput list-quirks
Fixes https://gitlab.freedesktop.org/libinput/libinput/issues/47
This reverts commit
2c4f963b18ff7f36cc14994c8b18bc4e4754ddde.
Peter Hutterer [Mon, 18 Jun 2018 03:41:18 +0000 (13:41 +1000)]
test: pass the open mode to open(O_CREAT)
Found by coverity
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 03:35:34 +0000 (13:35 +1000)]
quirks: add more assertion to avoid API misusage
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 03:27:57 +0000 (13:27 +1000)]
quirks: explicitly cast the log priority
The values are the same and this is ABI so they will never change. Make the
cast explicit for coverity's benefit.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 03:25:02 +0000 (13:25 +1000)]
quirk: remove unused variable
Also fixes a coverity complaint about incrementing an uninitialized variable.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 02:35:42 +0000 (12:35 +1000)]
gitlab ci: use GIT_DEPTH of 1
We don't need the full repo
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 01:04:43 +0000 (11:04 +1000)]
Drop the udev hwdb model quirks
Replaced with the quirks files in merge commit
000ac14c27f1920fc84c0ecb1512eb7495e67634
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 01:00:23 +0000 (11:00 +1000)]
Remove circle.yml
This has been replaced with the GitLab CI in the repository proper. Circle CI
was ony ever run on a private github repo.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 18 Jun 2018 00:55:27 +0000 (10:55 +1000)]
Merge branch 'wip/quirks-fixes'
Peter Hutterer [Thu, 14 Jun 2018 01:33:41 +0000 (11:33 +1000)]
data: don't disable the keyboard on any Thinkpad Yoga models
These (probably) all disable the mechanical keyboard anyway, so let's keep it
enabled to be able to access the screen keys, if any.
https://gitlab.freedesktop.org/libinput/libinput/issues/39
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 14 Jun 2018 01:57:42 +0000 (11:57 +1000)]
data: add the alps firmware version LUT
Just in case we need it
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 14 Jun 2018 01:54:52 +0000 (11:54 +1000)]
data: put a 'do not edit' warning into all data files
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 14 Jun 2018 01:48:33 +0000 (11:48 +1000)]
data: add ALPS v8 trackpoint range
Got lost in the hwdb to quirks conversion
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 14 Jun 2018 01:47:50 +0000 (11:47 +1000)]
data: re-add the ALPS v8 size hint
Got lost in the udev to quirks file conversion
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 14 Jun 2018 01:44:48 +0000 (11:44 +1000)]
data: switch alps touchpad matching to the bus/vid/pid matching
PSMOUSE_ALPS is 0x8
https://gitlab.freedesktop.org/libinput/libinput/issues/30
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>