platform/upstream/efl.git
4 years agodoxygen docs: Fix some more invalid commands
Xavi Artigas [Thu, 12 Mar 2020 10:02:11 +0000 (11:02 +0100)]
doxygen docs: Fix some more invalid commands

4 years agoefl_canvas_vg_shape: fix the wrong parameter order in the wrapper of evas_vg_shape_ap...
Taehyub Kim [Thu, 12 Mar 2020 16:16:39 +0000 (12:16 -0400)]
efl_canvas_vg_shape: fix the wrong parameter order in the wrapper of evas_vg_shape_append_cubic_to()

Summary: The x, y parameter order should be the end of efl_gfx_path_append_cubic_to()

Reviewers: Hermet, jsuya

Reviewed By: jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11491

4 years agoefl/exe: don't err on del if exe has been killed
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:37 +0000 (12:16 -0400)]
efl/exe: don't err on del if exe has been killed

Summary:
the point of this err is to inform the user that their exe is (possibly) dangling,
but if the user just wants to ignore the exit callback this isn't a problem
Depends on D11496

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11497

4 years agoefl/wl: define opaque wl/xkb types to native types when those headers are included
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:31 +0000 (12:16 -0400)]
efl/wl: define opaque wl/xkb types to native types when those headers are included

Summary:
simplify a lot of casting when we're in a native wl env
Depends on D11495

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11496

4 years agoefl/wl: add 'extracted' property for surfaces
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:25 +0000 (12:16 -0400)]
efl/wl: add 'extracted' property for surfaces

Summary:
useful to be able to know whether a surface has been extracted
Depends on D11476

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11495

4 years agoadd EFL_VERSION_1_24 define
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:20 +0000 (12:16 -0400)]
add EFL_VERSION_1_24 define

Summary: this needs to go in right after every release

Reviewers: stefan_schmidt, devilhorns

Reviewed By: stefan_schmidt, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11477

4 years agoefl-wl: rename to efl.canvas.wl
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:14 +0000 (12:16 -0400)]
efl-wl: rename to efl.canvas.wl

Summary:
this is a canvas object so it needs to be in the canvas namespace

Depends on D11475

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11476

4 years agoefl-wl: move flags_run to exec_flags property
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:10 +0000 (12:16 -0400)]
efl-wl: move flags_run to exec_flags property

Summary:
typically the compositor wants to run all exes with the same flags so this
makes more sense
Depends on D11470

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11475

4 years agoefl-wl: add active_surface property
Mike Blumenkrantz [Thu, 12 Mar 2020 16:16:04 +0000 (12:16 -0400)]
efl-wl: add active_surface property

Summary:
this is probably useful?

Depends on D11469

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11470

4 years agoefl-wl: make surface restacking functions return the current surface
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:57 +0000 (12:15 -0400)]
efl-wl: make surface restacking functions return the current surface

Summary:
seems more useful

Depends on D11468

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11469

4 years agoefl-wl: move keymap functions to eo
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:50 +0000 (12:15 -0400)]
efl-wl: move keymap functions to eo

Summary:
more 1:1 changes

Depends on D11467

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11468

4 years agoefl-wl: rework parent surface getter to a more useful property
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:43 +0000 (12:15 -0400)]
efl-wl: rework parent surface getter to a more useful property

Summary:
getting any parent is probably fine

Depends on D11466

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11467

4 years agoefl-wl: convert comp surface object to eo
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:40 +0000 (12:15 -0400)]
efl-wl: convert comp surface object to eo

Summary:
this is a 1:1 conversion

Depends on D11454

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11466

4 years agoefl/exe: add term_with_parent flag
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:34 +0000 (12:15 -0400)]
efl/exe: add term_with_parent flag

Summary:
same as ecore_exe

Depends on D11451

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11465

4 years agoefl-wl: start conversion to eo
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:27 +0000 (12:15 -0400)]
efl-wl: start conversion to eo

Summary:
this converts the main efl-wl object to an eo-based canvas group object

Depends on D11465

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11454

4 years agoefl/exe: add 'pid' property
Mike Blumenkrantz [Thu, 12 Mar 2020 16:15:20 +0000 (12:15 -0400)]
efl/exe: add 'pid' property

Reviewers: bu5hm4n, segfaultxavi

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, vtorri, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11451

4 years agoexactness: factor out duplicated code for debug session handling
Stefan Schmidt [Mon, 9 Mar 2020 16:25:03 +0000 (17:25 +0100)]
exactness: factor out duplicated code for debug session handling

No need to have these macros ducplicated in two file, we can just share
them and reduce maintenance.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11459

4 years agoexactness: hamonize use of PATH_MAX as maximal path length allowed
Stefan Schmidt [Tue, 3 Mar 2020 16:36:15 +0000 (17:36 +0100)]
exactness: hamonize use of PATH_MAX as maximal path length allowed

There have been to many different defines for this in exactness.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11457

4 years agoexactness: factor out _printf() handling into common part
Stefan Schmidt [Tue, 3 Mar 2020 16:03:41 +0000 (17:03 +0100)]
exactness: factor out _printf() handling into common part

First step to do some re-factoring of the exactness binaries. We will
share common parts from the different binaries in common.{c,h} to reduce
the code duplication. The start makes _printf() used in various places.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11456

4 years agoeina log bt - on by default always if unwind found
Carsten Haitzler (Rasterman) [Thu, 12 Mar 2020 13:35:50 +0000 (13:35 +0000)]
eina log bt - on by default always if unwind found

i'm tried of telling people how to turn this on. enough. on by
default. if you dont want bt's and its just some helpful log output
then just printf it or use WRN, INF and set log levels...

4 years agoedje_cc - provide better error info log on part id out of range
Carsten Haitzler (Rasterman) [Thu, 12 Mar 2020 13:13:35 +0000 (13:13 +0000)]
edje_cc - provide better error info log on part id out of range

4 years agocanvas proxy: fix a missing case that proxy not updated properly.
Hermet Park [Thu, 12 Mar 2020 11:39:12 +0000 (20:39 +0900)]
canvas proxy: fix a missing case that proxy not updated properly.

Very complex to say, if its source object is remained as chaged state in pending object
in rendering stage, the proxy object could miss to update in the next frame because
source object won't be changed again in evas_object_change().

Thus we need to double-check if the proxy missed update or not just in the rendering.
Not clean but this is a compromised solution to not be burden for finding/checking proxies
in object trees every time.

@fix

4 years agoedje_textblock: style font size override size_range max
Ali Alzyod [Thu, 12 Mar 2020 11:07:12 +0000 (20:07 +0900)]
edje_textblock: style font size override size_range max

Summary: style font size (also text_class) will change size_range max value, regardless of what user specifed in textblock description

Reviewers: woohyun

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11493

4 years agoedje_util: Prevent null pointer access
JunsuChoi [Thu, 12 Mar 2020 05:43:37 +0000 (14:43 +0900)]
edje_util: Prevent null pointer access

Summary: locale can be null. so add null check.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11490

4 years agoRevert "ecore_con: fix a improper condition"
Wonki Kim [Wed, 11 Mar 2020 07:03:11 +0000 (16:03 +0900)]
Revert "ecore_con: fix a improper condition"

This reverts commit ecf18c0064a58603cc1916cc9493b27d02f53847.

Change-Id: Ic2ff63d5a1fc8d0f697228ae7599bce0cf975c28

4 years agoecore_con: fix a improper condition
Wonki Kim [Thu, 20 Feb 2020 01:11:07 +0000 (10:11 +0900)]
ecore_con: fix a improper condition

there is a imporper condition on if statement.
this patch fixes it.

Change-Id: I0e9ef161d569ebdc900e13036c20db2ce70e724a

4 years agoevas_gl_shader: check lock_path length to avoid truncation by snprintf
Yeongjong Lee [Tue, 25 Feb 2020 03:43:51 +0000 (12:43 +0900)]
evas_gl_shader: check lock_path length to avoid truncation by snprintf

@tizen_fix

Change-Id: I4c981fc719b5911b8feac1469fdc242932bac257

4 years agoefl_gesture_manager: Fix incorrect override system config value.
Woochanlee [Tue, 10 Mar 2020 05:05:10 +0000 (14:05 +0900)]
efl_gesture_manager: Fix incorrect override system config value.

Change-Id: I973778100de960892c785aa10dbc4533ab2bc43f

4 years agoefl_ui/layout: skip versioning checks for legacy widgets
Mike Blumenkrantz [Wed, 11 Mar 2020 13:37:42 +0000 (09:37 -0400)]
efl_ui/layout: skip versioning checks for legacy widgets

Summary:
legacy widgets are always stable

fix T8630

Reviewers: eagleeye

Reviewed By: eagleeye

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8630

Differential Revision: https://phab.enlightenment.org/D11481

4 years agoevas_textblock: replace evil tabs with spaces
Ali Alzyod [Wed, 11 Mar 2020 11:37:47 +0000 (12:37 +0100)]
evas_textblock: replace evil tabs with spaces

Reviewers: devilhorns, ali.alzyod

Reviewed By: devilhorns

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11482

4 years agodoxygen docs: Fix tons of invalid Doxygen commands
Xavi Artigas [Tue, 10 Mar 2020 09:20:24 +0000 (10:20 +0100)]
doxygen docs: Fix tons of invalid Doxygen commands

Mostly typos

4 years agodoxygen docs: Adapt to Doxygen syntax
Xavi Artigas [Tue, 10 Mar 2020 08:41:14 +0000 (09:41 +0100)]
doxygen docs: Adapt to Doxygen syntax

I don't know where did these comments come from, but it was not Doxygen.

4 years agoevas.image: add evas_object_image_animated_frame_get
Shinwoo Kim [Tue, 10 Mar 2020 13:27:30 +0000 (09:27 -0400)]
evas.image: add evas_object_image_animated_frame_get

this adds an api for getting the current frame of an animation

Differential Revision: https://phab.enlightenment.org/D11455

4 years agoevas_object_text: Fix unused parameter
Christopher Michael [Tue, 10 Mar 2020 15:02:18 +0000 (11:02 -0400)]
evas_object_text: Fix unused parameter

When we do Not build with BIDI_SUPPORT, then "const Eo *eo_obj" is
never used and thus spits out an unused parameter warning during
compile. This has been bugging me for quite some time now, so put in a
small patch to silence this warning.

4 years agoeina_abstract_content: Fix resource leak
Christopher Michael [Tue, 10 Mar 2020 14:34:07 +0000 (10:34 -0400)]
eina_abstract_content: Fix resource leak

If we error out in this function, then we should be freeing 'content'
also as it was previously calloc'd above

Fixes CID1420317

4 years agoecore-evas-wayland: Check for valid 'fd' before passing to write()
Christopher Michael [Tue, 10 Mar 2020 14:31:46 +0000 (10:31 -0400)]
ecore-evas-wayland: Check for valid 'fd' before passing to write()

write() cannot be passed a negative value. If
ecore_main_fd_handler_fd_get returns -1, then this is an issue. Check
for valid fd being returned from fd_handler_fd_get and if it is
negative, then cleanup and get out.

Fixes CID1420318

4 years agoecore-evas-wayland: Fix resource leak
Christopher Michael [Tue, 10 Mar 2020 14:28:01 +0000 (10:28 -0400)]
ecore-evas-wayland: Fix resource leak

If we are going to be exiting this function without setting up the
ecore_main_fd_handler (and thus passing forign_slice), then we should
free forign_slice as it was previously calloc'd above.

Fixes CID1420322

4 years agoeina_abstract_content: Fix dereference before null check
Christopher Michael [Tue, 10 Mar 2020 14:25:10 +0000 (10:25 -0400)]
eina_abstract_content: Fix dereference before null check

Fixes Coverity CID1420337

4 years agovg_common_json: register shape name as it's designed.
JunsuChoi [Tue, 10 Mar 2020 12:12:52 +0000 (21:12 +0900)]
vg_common_json: register shape name as it's designed.

Summary: Caller could find/access a specific node with the name.

Test Plan: N/A

Reviewers: Hermet, herb, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11480

4 years agoedje: Rename Json to Lottie in edj supporting
JunsuChoi [Tue, 10 Mar 2020 06:42:12 +0000 (15:42 +0900)]
edje: Rename Json to Lottie in edj supporting

Summary:
The json file used by edje is for lottie output.
json can be used in many ways. So the purpose is clear.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11478

4 years agoevas_gl_font: free data paths if alloca fails
Ali Alzyod [Tue, 10 Mar 2020 02:41:57 +0000 (11:41 +0900)]
evas_gl_font: free data paths if alloca fails

Reviewers: Hermet, woohyun, bu5hm4n, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11473

4 years agoecore_evas: do not leak allocated memory in error case
Marcel Hollerbach [Mon, 9 Mar 2020 16:07:35 +0000 (17:07 +0100)]
ecore_evas: do not leak allocated memory in error case

4 years agoecore_evas: only free content when content is != NULL
Marcel Hollerbach [Mon, 9 Mar 2020 16:05:17 +0000 (17:05 +0100)]
ecore_evas: only free content when content is != NULL

otherwise we might run into issues with that.

4 years agoecore_evas_x: fix memory leak when enter drag and drop, without a ee
Marcel Hollerbach [Mon, 9 Mar 2020 16:00:29 +0000 (17:00 +0100)]
ecore_evas_x: fix memory leak when enter drag and drop, without a ee

this is something that can *never* happen otherwise we would have never
got this call. But lets make coverity happy.

4 years agoefl_ui_textbox: dont leak a array when no type is available
Marcel Hollerbach [Mon, 9 Mar 2020 15:59:33 +0000 (16:59 +0100)]
efl_ui_textbox: dont leak a array when no type is available

this fixes a possible leak.

4 years agoecore_evas_x: correctly handle images in X11
Marcel Hollerbach [Mon, 9 Mar 2020 15:47:16 +0000 (16:47 +0100)]
ecore_evas_x: correctly handle images in X11

I thought that i explicitly tested this. However, it seems i was wrong,
this way now this is handled correctly, and the image is stored and
coverted to a path.

With this you can now copy images from chromium and firefox to elm apps.

The change in elm_entry reverts parts of the rewrite of the elm
handling, as initially every path came *without* "file://" in front, so
we have to maintain that.

fixes T8625

4 years agoelm_cnp: move free call after the last usage
Marcel Hollerbach [Mon, 9 Mar 2020 15:46:01 +0000 (16:46 +0100)]
elm_cnp: move free call after the last usage

this is however pretty much irrelevant as only the pointer is used.

4 years agoelm_cnp: free array when going out of scope
Marcel Hollerbach [Mon, 9 Mar 2020 15:45:36 +0000 (16:45 +0100)]
elm_cnp: free array when going out of scope

this was missing and indeed a memory leak.

4 years agoefl_ui_win: Fix null pointer dereference
Christopher Michael [Mon, 9 Mar 2020 13:07:48 +0000 (09:07 -0400)]
efl_ui_win: Fix null pointer dereference

Fixes Coverity CID1420321

4 years agoefl_ui_win: Fix null pointer dereference
Christopher Michael [Mon, 9 Mar 2020 13:03:58 +0000 (09:03 -0400)]
efl_ui_win: Fix null pointer dereference

Fixes Coverity CID1420329 and CID1420328

4 years agoefl_ui_win: Fix horrible formatting
Christopher Michael [Mon, 9 Mar 2020 13:02:21 +0000 (09:02 -0400)]
efl_ui_win: Fix horrible formatting

NB: No functional changes

4 years agoeina_content: fix use after free in test code
Marcel Hollerbach [Mon, 9 Mar 2020 12:05:38 +0000 (13:05 +0100)]
eina_content: fix use after free in test code

4 years agoeina_content: free memory in error paths
Marcel Hollerbach [Mon, 9 Mar 2020 12:04:35 +0000 (13:04 +0100)]
eina_content: free memory in error paths

4 years agoeina: fix define of Eina_Content
Marcel Hollerbach [Mon, 9 Mar 2020 09:03:37 +0000 (10:03 +0100)]
eina: fix define of Eina_Content

there is no need to declare that const.

4 years agodoxygen docs: remove @ender_group and organize eina vectors
Xavi Artigas [Mon, 9 Mar 2020 12:01:11 +0000 (13:01 +0100)]
doxygen docs: remove @ender_group and organize eina vectors

Mysterious @ender_group is an invalid doxygen command and I could not find
it defined anywhere. I could not infer its purpose either so... removed.
Put the Eina Vector 2D and 3D groups in their proper place so they appear
with the rest of the Eina basic types.

4 years agodoxygen docs: Remove invalid comments
Xavi Artigas [Mon, 9 Mar 2020 10:55:22 +0000 (11:55 +0100)]
doxygen docs: Remove invalid comments

They contain no information whatsoever and they contain invalid doxygen commands.
This was probably copied over from some other documentation format.

4 years agodoxygen docs: Move smart object methods to proper group
Xavi Artigas [Mon, 9 Mar 2020 10:43:33 +0000 (11:43 +0100)]
doxygen docs: Move smart object methods to proper group

Move smart object methods from @ingroup Evas_Canvas to Evas_Smart_Object_Group
Also, remove lots of redundant @ingroup Evas_Smart_Object_Group

4 years agodoxygen docs: remove doubly-defined @examples
Xavi Artigas [Mon, 9 Mar 2020 09:24:22 +0000 (10:24 +0100)]
doxygen docs: remove doubly-defined @examples

This index page only contains references (@ref), the actual
examples (@example) are defined elsewhere and the double
definition was throwing warnings.

4 years agoRevert "ci: travis: stop osx builds until build failures are solved on Travis"
Stefan Schmidt [Mon, 9 Mar 2020 08:28:12 +0000 (09:28 +0100)]
Revert "ci: travis: stop osx builds until build failures are solved on Travis"

This was actually a problem we could solve on our side. Marcel has done
so in commit: 32597e7e7784049927291e6d8ad131a2b8227d0e

This reverts commit b554b25c4cfd5b49d7ea8b9daf9c52977a68805e.

4 years agoeina: Docs/Comments: eina_safety_checks: Correct grammar, spelling mistakes and be...
Xavi Artigas [Mon, 9 Mar 2020 08:58:19 +0000 (09:58 +0100)]
eina: Docs/Comments: eina_safety_checks: Correct grammar, spelling mistakes and be more clearer

Summary: This just corrects the comments grammar, spelling mistakes and is a little bit clearer.

Reviewers: segfaultxavi, barbieri

Reviewed By: segfaultxavi

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11472

4 years agodoxygen docs: Miscellaneous typos
Xavi Artigas [Thu, 5 Mar 2020 08:35:05 +0000 (09:35 +0100)]
doxygen docs: Miscellaneous typos

4 years agoreadme - adapt for removal of xine/vlc support
Carsten Haitzler (Rasterman) [Sun, 8 Mar 2020 12:38:58 +0000 (12:38 +0000)]
readme - adapt for removal of xine/vlc support

4 years agoecore_evas_x: honor forign dnd implementations
Marcel Hollerbach [Sun, 8 Mar 2020 11:25:35 +0000 (12:25 +0100)]
ecore_evas_x: honor forign dnd implementations

enlightenment does not use the elm dnd operation implementations.
Therefore we have to ensure that we only handle these operations here,
when ecore_evas dnd API is used.

4 years agoecore_evas: Use EFL naming convention in cnp & dnd methods
Xavi Artigas [Tue, 3 Mar 2020 12:10:49 +0000 (13:10 +0100)]
ecore_evas: Use EFL naming convention in cnp & dnd methods

Some methods were missing the "Drag" or "Selection" namespaces or the _Cb suffix.
Depends on D11219

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11426

4 years agomono-tests: Fix build after DnD changes
Xavi Artigas [Tue, 28 Jan 2020 17:33:42 +0000 (17:33 +0000)]
mono-tests: Fix build after DnD changes

The test struct used to check mono bindings struct pack/unpack
is no longer available. Used a different one, and checked the same things.

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11219

4 years agodocs: Strengthen docs for Copy&Paste and Drag&Drop
Xavi Artigas [Tue, 3 Mar 2020 10:12:08 +0000 (11:12 +0100)]
docs: Strengthen docs for Copy&Paste and Drag&Drop

Including Eina.Content

And a typo/bugfix in ecore_evas_x.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11204

4 years agoport cnp on Windows
Marcel Hollerbach [Sun, 8 Mar 2020 09:46:09 +0000 (10:46 +0100)]
port cnp on Windows

Test Plan: Ctrl-c and Ctrl-Vworking

Reviewers: raster, zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11439

4 years agoecore_evas: Introduce cnp support for cocoa
Marcel Hollerbach [Fri, 14 Feb 2020 13:10:44 +0000 (14:10 +0100)]
ecore_evas: Introduce cnp support for cocoa

with this commit you can do limited cnp for cocoa. You still cannot copy
and paste pictures or markup arround, only text is supported so far.
However, text on its own works quite stable and good.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11351

Change-Id: Iec8d57633832d5a213565237f603e3c7f1b1efb2

4 years agoecore_cocoa: change clipboard API
Marcel Hollerbach [Fri, 14 Feb 2020 13:09:21 +0000 (14:09 +0100)]
ecore_cocoa: change clipboard API

the new API works with mimetypes, so we can remove the cnp types from
Ecore_Cocoa.h and just forward the types from ecore_evas directly

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11350

4 years agorewrite efl cnp and dnd handling
Marcel Hollerbach [Sun, 19 Jan 2020 12:58:26 +0000 (13:58 +0100)]
rewrite efl cnp and dnd handling

the previous commits introduced a abstraction for drag in drop which can
be now used for this here. With this commit all the direct protocol
handling in efl.ui is removed, and only the ecore evas API is used.

Additionally, this lead to a giant refactor of how APIs do work. All
Efl.Ui. interfaces have been removed except Efl.Ui.Selection and
Efl.Ui.Dnd, these two have been restructored.
A small list of what is new:
- In general no function pointers are used anymore. They feel very
  uncompftable in bindings and in C. For us its a lot easier to just
listen to a event when a drop enters or leaves, there is no need to
register custom functions for that.
- Asynchronous data transphere is handled via futures, which proved to
  be more error safe.
- Formats and actions are handled as mime types / strings.
- 0 is the default seat if you do not know what else to take.
- Content is in general passes as a content container from eina, this
  also allows applications to pass custom types

The legacy dnd and cnp API is implemented based on that.
All cnp related things are in elm_cnp.c the dnd parts are in elm_dnd.c

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11190

4 years agoecore_evas: introduce wayland support for cnp & dnd
Marcel Hollerbach [Mon, 10 Feb 2020 08:20:18 +0000 (09:20 +0100)]
ecore_evas: introduce wayland support for cnp & dnd

This adds cnp support, actions are right now only mapped to "ask",
further support can be added there, and synchronization can be added to
register more available actions. However, i did not find *any* wayland
implementation in gtk qt nor chromiumos that even use the action to
indicate anything. This here also has a slightly different behaviour to
X11 in terms of coordinates for motion,leave,enter. They can contain
negative coordinates (which is due to the fact that wl is CSD and X11 is
SSD. However, I did not want to fix this in any regard, as you might
want to use that, and it would be a none trivial amount of code to fix
that.

Reviewed-by: Chris Michael <cp.michael@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11329

4 years agoecore_evas: introduce initial selection & dnd support for x.
Marcel Hollerbach [Sun, 12 Jan 2020 16:38:05 +0000 (17:38 +0100)]
ecore_evas: introduce initial selection & dnd support for x.

Seats are not implemented, if there is a type mismatch promises are
going to be rejected. Most of this code is copied over from
selection_manager.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11195

4 years agoecore_x_selection: do not skip any any atoms
Marcel Hollerbach [Tue, 21 Jan 2020 13:50:23 +0000 (14:50 +0100)]
ecore_x_selection: do not skip any any atoms

i dont know why we skipped the first two atoms, but right now, if a
application is only providing one single target, we would crash.
With this we might copy a few atoms more. However, these atoms do not
matter, as we skip those, that we cannot understand

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11194

4 years agoecore_x: add API to request selection changed events for diff. wins
Marcel Hollerbach [Sun, 12 Jan 2020 16:36:48 +0000 (17:36 +0100)]
ecore_x: add API to request selection changed events for diff. wins

we need that in order to get seleciton per window events, which is
required to get a nice mapping onto the ecore_evas object.

Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com>
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11193

4 years agoecore_evas: Introduce cnp / dnd API for ecore evas
Marcel Hollerbach [Sun, 5 Jan 2020 14:05:36 +0000 (15:05 +0100)]
ecore_evas: Introduce cnp / dnd API for ecore evas

The idea of copy and paste here is:
- The user specifies the content he wants to have in the selection
  buffer with a Eina_Content, these content pointer ownerships are
  passed to the called. Internally ecore_evas code will memorieze the
  pointer, and pass on function callbacks to the modules, which then do
  not have to deal with the ownership.

- In case the module does not specify these APIs, the callback
  implementation will be called, which only works for cnp *not* dnd.

- Action and mime types are handled as strings, which allows way better
  custom organisations.

(The docs needs improvement)

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11192

4 years agoeina: introduce Eina_Abstract_Content
Marcel Hollerbach [Sat, 4 Jan 2020 14:08:08 +0000 (15:08 +0100)]
eina: introduce Eina_Abstract_Content

A little abstraction to have abstract data content bound to a type.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11018

4 years agoevas_pbject_intercept: add missing parenthesis
Daniel Kolesa [Fri, 6 Mar 2020 22:30:50 +0000 (23:30 +0100)]
evas_pbject_intercept: add missing parenthesis

Broken in 7c99e0a444d81cc545181682f1a4ae00f76d0873.

*spanks*

4 years agoefl_ui_win: Fix dereference before NULL check
Christopher Michael [Fri, 6 Mar 2020 21:12:15 +0000 (16:12 -0500)]
efl_ui_win: Fix dereference before NULL check

This patch fixes an issue detected by Coverity in that 'sdp' is
already being dereferenced before we check it. ELM_WIN_DATA_GET can
return NULL, so we should check it's return Before trying to use the
variable.

Fixes CID1419871

4 years agoevas_object_intercept: Add check for NULL 'obj' variable inside macros
Christopher Michael [Fri, 6 Mar 2020 18:04:57 +0000 (13:04 -0500)]
evas_object_intercept: Add check for NULL 'obj' variable inside macros

This patch adds a small check for a valid 'obj' variable inside the
object_intercept macros, which fixes several Coverity reported issues
of NULL pointer dereference.

Fixes CID1420239 through CID1420258

4 years agoefl-wl: properly send surface enter event in smart show
Mike Blumenkrantz [Fri, 6 Mar 2020 17:16:45 +0000 (12:16 -0500)]
efl-wl: properly send surface enter event in smart show

Summary:
confusing...
Depends on D11452

Reviewers: segfaultxavi, bu5hm4n, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11453

4 years agoelm: undef EAPI_WEAK in header before defining
Mike Blumenkrantz [Fri, 6 Mar 2020 17:16:40 +0000 (12:16 -0500)]
elm: undef EAPI_WEAK in header before defining

Summary: avoid double define warnings

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11452

4 years agoevas_gl_drm: Fix incorrect define statement.
Christopher Michael [Fri, 6 Mar 2020 16:45:44 +0000 (11:45 -0500)]
evas_gl_drm: Fix incorrect define statement.

This actually should be #ifndef so that if it's not defined in the
system, then we can still compile properly.

4 years agoci: make ci work again
Marcel Hollerbach [Fri, 6 Mar 2020 12:32:53 +0000 (13:32 +0100)]
ci: make ci work again

because of some reasons, python now hides in a different PATH, which is
not *always* added to the PATH env variable.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11461

4 years agoefl_canvas_layout_part: remove debugging content set / get impl
Marcel Hollerbach [Fri, 6 Mar 2020 13:52:54 +0000 (14:52 +0100)]
efl_canvas_layout_part: remove debugging content set / get impl

this is now handled when eo is erroring.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11464

4 years agoefl_canvas_layout_part: add part name, type and group name to debug info
Marcel Hollerbach [Fri, 6 Mar 2020 13:47:52 +0000 (14:47 +0100)]
efl_canvas_layout_part: add part name, type and group name to debug info

this is usefull, as we now know which type of part we have, if a API
call does not succeed.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11463

4 years agoeo: print debug information when a call cannot be resolved
Marcel Hollerbach [Fri, 6 Mar 2020 13:40:04 +0000 (14:40 +0100)]
eo: print debug information when a call cannot be resolved

that is usefull esp. on parts.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11462

4 years agotests/evas: verify loading and mmap values for efl.file are correct with skip_head
Mike Blumenkrantz [Wed, 26 Feb 2020 14:42:44 +0000 (09:42 -0500)]
tests/evas: verify loading and mmap values for efl.file are correct with skip_head

ensure that these functions are still usable with async load

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11424

4 years agoevas/image: implement efl.file loading and mmap getters to correctly handle skip_head
Mike Blumenkrantz [Wed, 26 Feb 2020 14:41:14 +0000 (09:41 -0500)]
evas/image: implement efl.file loading and mmap getters to correctly handle skip_head

when this property is set, the mixin implementation of efl_file_load() is
never called, which means the internal loaded flag (and related data) is
not set, and so the values for these properties must instead be returned
directly from the image data

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11423

4 years agoevas: set mmap data to image data after preload with skip_head enabled
Mike Blumenkrantz [Wed, 26 Feb 2020 14:38:13 +0000 (09:38 -0500)]
evas: set mmap data to image data after preload with skip_head enabled

this is a bit ugly, but in the case where skip_head is used it's important
to propagate the resulting Eina_File back up to the image object's data
for use in other api functions

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11422

4 years agoefl_ui/widget: add inheritance for efl.gfx.entity to widget part
Mike Blumenkrantz [Wed, 4 Mar 2020 14:47:20 +0000 (09:47 -0500)]
efl_ui/widget: add inheritance for efl.gfx.entity to widget part

most of these are empty

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11448

4 years agoevas_object_intercept: Use efl_data_scope_safe_get
Christopher Michael [Thu, 5 Mar 2020 13:28:05 +0000 (08:28 -0500)]
evas_object_intercept: Use efl_data_scope_safe_get

As per mailing list discussion, This macro is apparently a forward
facing API so we should be using efl_data_scope_safe_get in the event
that the API receives an object of the wrong type (which would have
caused a crash previously).

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11450

4 years agoevas_object_intercept: Reduce calls to efl_data_scope_get
Christopher Michael [Thu, 5 Mar 2020 13:24:46 +0000 (08:24 -0500)]
evas_object_intercept: Reduce calls to efl_data_scope_get

Small patch to reduce the number of calls to efl_data_scope_get as per
mailing list discussion. Since the
EVAS_OBJECT_INTERCEPT_CALLBACK_DEFINE macro already retrieves the
protected data via efl_data_scope_get, we can just pass that
protected data directly to evas_object_intercept_init/deinit functions
without the need to refetch it.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11449

4 years agoelm_label: add EFL_ACCESS_WIDGET_ACTION_MIXIN
Marcel Hollerbach [Wed, 4 Mar 2020 14:03:20 +0000 (15:03 +0100)]
elm_label: add EFL_ACCESS_WIDGET_ACTION_MIXIN

we implement the API from it, so we should have that as a type here.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11447

4 years agoelm_code_syntax: Add c-sharp syntax highlighting.
Alastair Poole [Fri, 6 Mar 2020 11:03:33 +0000 (11:03 +0000)]
elm_code_syntax: Add c-sharp syntax highlighting.

4 years agoci: travis: stop osx builds until build failures are solved on Travis
Stefan Schmidt [Fri, 6 Mar 2020 11:01:46 +0000 (12:01 +0100)]
ci: travis: stop osx builds until build failures are solved on Travis

This looks like problems on the TravisCI side, but this is going on for
to long. Stop osx builds to have our on CI in a sane state again.

4 years agoelc_naviframe: fix to delete item once by elm_object_item_del in pop_cb
Jaehyun Cho [Fri, 6 Mar 2020 04:25:04 +0000 (13:25 +0900)]
elc_naviframe: fix to delete item once by elm_object_item_del in pop_cb

If elm_object_item_del is called in pop_cb and pop_cb returns
EINA_FALSE, then the given item is destructed by _item_noref when
efl_unref is called after pop_cb.

After the above destruction, efl_del is called after the above efl_unref
and it deletes the item again.

Not to delete item after the item is destructed, efl_del after pop_cb is
removed.

4 years agoelm_code: Avoid moving to non-existent line.
Alastair Poole [Fri, 6 Mar 2020 01:23:35 +0000 (01:23 +0000)]
elm_code: Avoid moving to non-existent line.

Check for line existence before moving cursor.

4 years agoevas: Fix dereferenceing null pointer
Christopher Michael [Wed, 4 Mar 2020 19:20:47 +0000 (14:20 -0500)]
evas: Fix dereferenceing null pointer

Coverity reports a forward null here. If we do not get obj from
efl_data_scope_get then we should return. Also fixes some formatting

Fixes CID1420216

4 years agoevas: Fix mouse event info for legacy events.
Hosang Kim [Wed, 4 Mar 2020 14:35:30 +0000 (09:35 -0500)]
evas: Fix mouse event info for legacy events.

Summary:
Legacy event info have canvas and output coordinates.
Output coordinates have information of original position.
Canvas coordinates have information of transformed position.
So keep backward compatibility, fix filling legacy information.

This reverts commit 7f724f6c5db1127a6dd5786791f495b58910e9a9

Reviewers: Hermet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11445

4 years agoelm_code: Improve efficiency of the widget.
Alastair Poole [Wed, 4 Mar 2020 01:41:43 +0000 (01:41 +0000)]
elm_code: Improve efficiency of the widget.

For now, only create textgrids when needed. Also improve other
regions of the widget. This will improve large file support and
also some rendering of the widget.

This improves performance 1-2 times. However, there must be a
reasonable redesign regarding the current use of textgrids.