Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: Id857ed995a1e8cbf7ef706095407eb84f5d1d34b

Refactor: Compatible compute and graphics VerifyIO

Refactoring:
 * Compatibilize VerifyIO function declaration
 * Add isCoreFeatureSupported
 * Graphic shader can run over whole area

Affects tests:
 * dEQP-VK.spirv_assembly.*

Components: Vulkan

VK-GL-CTS issue: 1095

Change-Id: Id20f06771622e1debba6b3078f5fbcef97f0cbb5

Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master

Change-Id: I9a83f25ba7ad9bf007cd9b6778893a6f90587533

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2

Change-Id: Ib1bfbe439ce0b734de4328d9d9577bc0a3793288

Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1

Change-Id: Ie5d1d301b96c8eff6a7d974de13c1d35195d7b26

Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0

Change-Id: I5b4bdc020c0dda7ec55aafd498cd1f1193b9c77b

Update Vulkan CTS mustpass

Components: Vulkan

Change-Id: I419768f938469473196797dc0d68f7776a9affb1

Add cases for structs as inout and out parameters.

Structs with lowp, mediump and highp (when supported in fragment
shaders) members are tested as inout and out parameters in both ES 2.0
and 3.0 shaders.

The highp variant of this test catches a bug which was found by the
Three.js community in https://github.com/mrdoob/three.js/issues/14137 .
Similar tests were integrated into the WebGL conformance suite in
https://github.com/KhronosGroup/WebGL/pull/2663 .

Verified on:
  Qualcomm Adreno 308 (LG Aristo) - bug reproduces in both ES2 and ES3
                                    highp fragment shaders
  Qualcomm Adreno 540 (Pixel 2),
  NVIDIA Tegra (SHIELD Tablet) - all tests pass

New tests:

dEQP-GLES[23].functional.shaders.struct.local.parameter_inout_*
dEQP-GLES[23].functional.shaders.struct.local.parameter_out_*

VK-GL-CTS Issue 1280

Change-Id: Ie332aede0ad52453815d9e123145ec035009430b

Fix invalid combinations for texture/copy on ES2 driver

The OES_rgb8_rgba8 extension specification only specifies
RenderbufferStorageOES for additional GL_RGB8/GL_RGBA8 tokens.  ES3 spec
made these mandatory formats for texturing/copying.

Affects:

KHR-GLES2.core.internalformat.texture2d.rgb_unsigned_byte_rgb8
KHR-GLES2.core.internalformat.texture2d.rgba_unsigned_byte_rgb8
KHR-GLES2.core.internalformat.copy_tex_image.rgba8
KHR-GLES2.core.internalformat.copy_tex_image.rgb8

Components: OpenGL
VK-GL-CTS issue: 1260

Change-Id: Icbbd8882c5e623f5ac4725eebf977f535cfbfa31

Vulkan AHB - fix incorrect structure definition

Fix a missing VkComponentMapping field of the VkAndroidHardwareBufferFormatPropertiesANDROID
structure. This is causing incorrect values to be populated to the
structure, as well as, a stack overwrite of other stack-located locals.

Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r8g8b8a8_unorm
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r5g6b5_unorm_pack16
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r16g16b16a16_sfloat
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.a2b10g10r10_unorm_pack32

Components: Vulkan
VK-GL-CTS issue: 1305
VK-GL-CTS issue: 1316

Change-Id: I81eb1cc605912bf0adebe67b65d7ccdd31236ec9

Fix copy/paste errors in opundef assembly tests

The tests were using %is_nan_0 repeatedly instead of %is_nan_<i>

Affects: dEQP-VK.spirv_assembly.instruction.graphics.opundef.*
(likely only the vec4float32 and matrix subsets)
Component: Vulkan
VK-GL-CTS: 1315

Change-Id: I2bed6e94f6867c424c5102ef3eeab8ac32021dcd
(cherry picked from commit a46089154137e0939c02bdcabc74f5daa303ffb2)

Test push descriptors

Added uniform and storage buffer push descriptor tests. Tests for other
descriptor types should be added later.

New tests:

dEQP-VK.pipeline.push_descriptor.*

Components: Vulkan

VK-GL-CTS issue: 1187

Change-Id: I6c8a2ae96f23cff3da1cdeed1659da61e3aa347c

Refactor: Compatible compute and graphics VerifyIO

Refactoring:
 * Compatibilize VerifyIO function declaration
 * Add isCoreFeatureSupported
 * Graphic shader can run over whole area

Affects tests:
 * dEQP-VK.spirv_assembly.*

Components: Vulkan

VK-GL-CTS issue: 1095

Change-Id: Iba9bab9d40a06f1eba90572cc60f1c334c4b8474

Split subgroups tests into test groups

Subgroup test hierarchy was a bit too flat, with many test variants
added by permutating test case names.

This change splits the test into compute, graphic, framebuffer..
groups.

Components: Vulkan

VK-GL-CTS Issue: 1276

Affects: dEQP-VK.subgroups.*

Change-Id: I2a3c3a4ad8c5a8116d0c58b41d030b36eccc80e5

Fix copy/paste errors in opundef assembly tests

The tests were using %is_nan_0 repeatedly instead of %is_nan_<i>

Affects: dEQP-VK.spirv_assembly.instruction.graphics.opundef.*
(likely only the vec4float32 and matrix subsets)
Component: Vulkan
VK-GL-CTS: 1315

Change-Id: I2bed6e94f6867c424c5102ef3eeab8ac32021dcd

Avoid spurious failures in create_context when desktop GL 3.x is unsupported.

On a driver advertising GLES 3.0 and GL 2.1, the test was failing with:

  Creating OpenGL context with config ID 29
      Fail, context: 0x00000000, error: EGL_BAD_MATCH

This was because b60ae978ad04 ("Handle unsupported no_config
contexts") added a requirement for GL 3.x, even though EGL doesn't
require that.

Affects: dEQP-EGL.functional.create_context.*
Components: AOSP
VK-GL-CTS issue: 1283
Change-Id: Id99ad51c1d0dca2c68e42a7bffe282f12a101027

x11: Keep the window from stealing input.

When debugging on an X11 desktop and doing repeated runs, it's
unpleasant to have input focus stolen by a series of transient windows
being created.

Components: Framework
Affects: *
VK-GL-CTS issue: 1282
Change-Id: I7bc8e9587e71ac9ebfab726c3926c432b2f04f01

Remove broken/redundant barrier for multiview depth/stencil readback

This barrier was set up for color writes, not depth/stencil. It was also
unnecessary, so just remove it.

Change-Id: Ieeec7320f40b273f12f669934298f85702a5985b
Components: Vulkan
VK-GL-CTS: 1288
Affects: dEQP-VK.multiview.*
(cherry picked from commit 9a5be0a660ea73f6c57efd77dff1219ec4e35bf3)

Remove broken/redundant barrier for multiview depth/stencil readback

This barrier was set up for color writes, not depth/stencil. It was also
unnecessary, so just remove it.

Change-Id: Ieeec7320f40b273f12f669934298f85702a5985b
Components: Vulkan
VK-GL-CTS: 1288
Affects: dEQP-VK.multiview.*

Fixes geometry shader invocation dependency

dEQP-VK.tessellation.invariance.* updates a SSBO
expecting the implementation to execute the GS
once per primitive. Changes the test to allow
multiple invocations.

Components: Vulkan
VK-GL-CTS Issue: 1281

Affects:
dEQP-VK.tessellation.invariance.*

Change-Id: I6ed17a8afb413587bb38487ec9952f569a250193

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I26eb5a69c61ce1ff13c592caa5b166ffe03b5810

Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master

Change-Id: Iab57269d692164943d9ff03cc598dd21a8fd3f8e

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2

Change-Id: I87551c21c18956e49aaef393a1f700ad72686912

Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1

Change-Id: I3ebd996d37e078d937fe79ccc93718b51672e1c4

Removed cache info from logged shaderstrings

This fix removes the additional information shader cache includes in the
shader string before logging. Logging change only, does not affect tests
themselves.

Affects: none

Components: Vulkan

VK-GL-CTS issue: 1289

Change-Id: I49f8730816ce28584d9601306ec40be052cee341

Remove unconditional depth_clamping for 1.1.1

Changed depthClampEnable from VK_TRUE to VK_FALSE where it is not needed.
Depth clamp specific tests in builtin_var.fragdepth set as not supported for incompatible systems.

NB: Carries the same changes as 1.1.0 patch for depth_clamping, along with changes that are specific for 1.1.1.

Affects:
dEQP-VK.device_group.*
dEQP-VK.api.object_management.*.graphics_pipeline
dEQP-VK.binding_model.shader_access.*
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.renderpass.*
dEQP-VK.spirv_assembly.*
dEQP-VK.api.smoke.unused_resolve_attachment
dEQP-VK.wsi.android.incremental_present.*
dEQP-VK.memory.pipeline_barrier.*

Components: Vulkan

VK-GL-CTS issue: 1286

Change-Id: I0e322c65561c25339fe56e3122401d92df7623a6

Remove unconditional depth_clamping for 1.1.0

Changed depthClampEnable from VK_TRUE to VK_FALSE where it is not needed.
Depth clamp specific tests in builtin_var.fragdepth set as not supported for incompatible systems.

Affects:
dEQP-VK.device_group.*
dEQP-VK.api.object_management.*.graphics_pipeline
dEQP-VK.binding_model.shader_access.*
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.renderpass.*
dEQP-VK.spirv_assembly.*
dEQP-VK.api.smoke.unused_resolve_attachment
dEQP-VK.wsi.android.incremental_present.*
dEQP-VK.memory.pipeline_barrier.*

Components: Vulkan

VK-GL-CTS issue: 1286

Change-Id: Ia869da75a74800543afb4f8fddd8bf5e8f7f4a7f

Incorrect pipeline barrier in multiview.multisample.*

The barrier between the render and the cmdResolveImage()
in the multiview tests is currently src=COLOR_ATTACHMENT_OUTPUT,
dst=COLOR_ATTACHMENT_OUTPUT. The explicit resolve that follows
is a transfer operation so the destination stage needs to be
TRANSFER_READ to express the correct dependency.

Affects:

dEQP-VK.multiview.multisample.*

Components: Vulkan

VK-GL-CTS issue : 1291

Change-Id: I362c6f2e9f57b140c078b8d326caf042d472a4b3

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I385d3416a8bd1bf73d1a0b45a4b6a5877da930ec

Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master

Change-Id: I3903536de72b661991919bbd783928792b8f9591

Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master

Change-Id: Icd986e028cf19310c0cded2462640b68d0b6d4e7

Merge vk-gl-cts/opengl-es-cts-3.2.4 into vk-gl-cts/opengl-es-cts-3.2.5

Change-Id: I02ed0b86e13f8210020fbfd8baaca74b60a1551f

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: Ibee86ab6339aefce94bd27190d57cf1c5552bd29

Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master

Change-Id: Id793ef1b34ec89095cd6071dda6252ff32d37f36

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2

Change-Id: I7d44b39c208f999dcc86793250fecdb69258a165

Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1

Change-Id: I2b3ff32206b0408c16dd93bc643bdc9bf928dcda

Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0

Change-Id: I178311e0fa4f5276ab325b65460074f60e42c222

Don't used a fragment output in the shader storage buffer object test

This test doesn't require a fragment shader output, and if we are
on a system which has only 8 combined shader output resources,
this stops the test from executing.

Components: OpenGL
VK-GL-CTS Issue: 985
Affects:
KHR-GL45.shader_storage_buffer_object.advanced-unsizedArrayLength-fs-std430-vec

Change-Id: Ib0883e09d84022c1dac5bc2f22787c0e91efba1c

Fix build when SPIRV-Tools is not present

This function does not require SPIRV-Tools, and is still used when it
is not present.

Components: Framework
VK-GL-CTS: 1293

Change-Id: I9ce49db2e6e55e8d379c713c9fe39d15fb7ecbd6

Invalidate memory in draw tests

The test group writes to non-coherent device memory with device,
but fails to call the required invalidate on the region before
reading mapped memory with host.

Components: Vulkan

VK-GL-CTS issue: 529

Affects: dEQP-VK.draw.*

Change-Id: Icf4aa6ea80c8c046e41b37402457b7f094d7ae50
(cherry picked from commit 1ce6e233a6245a1cf81a2a4e88b87c5d381a119a)

Whitelist VK_KHR_swapchain_mutable_format extension

Affected tests:
dEQP-VK.api.info.device.extensions

Components: Vulkan
VK-GL-CTS issue: 1014

Change-Id: Ic9dbf7161534765af624e5925bb9f6ea0ad16be8

Update CTS version of gl.xml

Pulls in fix for getGraphicsResetStatusEXT

Components: OpenGL
VK-GL-CTS issue: 1247

Affects:
dEQP-EGL.functional.robustness.create_context.no_reset_notification

Change-Id: I3081d0b6dbfa4436e29cb7b4d52840575f9d40a0

Update Vulkan mustpass

Components: Vulkan

Change-Id: Idd0cb00dd39c82d5604fde918e742f49fa1e14b9

New tests for pointers as function parameters

These new tests fill a coverage hole for passing multiple pointers
to functions and using these pointers to modify data. Alias decoration
is used where needed.

New tests:

dEQP-VK.spirv_assembly.instruction.*.pointer_parameter.*

Components: Vulkan

VK-GL-CTS issue: 1174

Change-Id: I5fc6b0f1b1b5a706acd671b9ecc4e928f988d6c3
(cherry picked from commit ecccf1c61e853a3bef40df45eb3f488c7a0493ae)

New tests for pointers as function parameters

These new tests fill a coverage hole for passing multiple pointers
to functions and using these pointers to modify data. Alias decoration
is used where needed.

New tests:

dEQP-VK.spirv_assembly.instruction.*.pointer_parameter.*

Components: Vulkan

VK-GL-CTS issue: 1174

Change-Id: I5fc6b0f1b1b5a706acd671b9ecc4e928f988d6c3

Update GLES mustpass

Components: OpenGL

Change-Id: Id6a3d2dd92e70b7b9729bda74f8caaa2b8e91527

Start 1.1.3 mustpass

Components: Vulkan

Change-Id: I0c325c93380dc8553e832728cf6ac95282fbea0d

Add tests for VK_KHR_swapchain_mutable_format

New tests:
dEQP-VK.image.swapchain_mutable.*

Affected tests:
dEQP-VK.image.mutable.*

Components: Vulkan

VK-GL-CTS issue: 1014

Change-Id: I01ad8a374a53fb21c4f2d0bb413970808e23e784

Add tests for vkCmdClearColorImage on linear images

New Tests:
dEQP-VK.api.image_clearing.*.clear_color_image.*.linear.*

Renamed Tests:
dEQP-VK.api.image_clearing.*.clear_color_image.*

Components: Vulkan

Change-Id: If0be7b57f7a779fda88b1dd64d15113d115eced2

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I99fc1b60c1415b4718eeafb7737d895b748396ee

Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master

Change-Id: I46b6332876af27cea732a67613759229f7028f7a

Add 1.1.1.2 to known conformance versions

This allows for 1.1.1.2 as value returned in
VkPhysicalDeviceDriverPropertiesKHR.conformanceVersion

Components: Vulkan

VK-GL-CTS Issue: 1287

Affects:
dEQP-VK.api.driver_properties.properties

Change-Id: Iae3c2aa76af750150ed66ec5be4971b71ec2bc06

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I837ad0e47212620530fb951cf47306c60507fd05

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/master

Change-Id: Ifacca1cc17b596f770f07b1e497342f23bc4cf61

Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master

Change-Id: I8f337795a44a35d1058412c49c09702b297203ca

Update transform feedback tests

GLES3.2 spec made a change in 2018/5/14 version, that The
TRANSFORM_FEEDBACK_BUFFER_BINDING generic buffer binding point has now
been moved to context state, rather than per-object state, and should
be unaffected by glBindTransformFeedback command.

Some tests follow the old standard that they use glBindTransformFeedback
function to change the binding point status.

Components: OpenGL

Affects: KHR-GLES31.core.vertex_attrib_binding.advanced-iterations

VK-GL-CTS issue: 1275

Change-Id: I9a0296ef273321ef8b039986b92baf2353838a99

Merge vk-gl-cts/github-master into vk-gl-cts/master

Change-Id: I4a1a3f2e84c071dc18b3a8247fb0679d6c2d84e3

Ensure that SPIR-V Headers are always present

Components: Vulkan, OpenGL, Framework

VK-GL-CTS public issue: 108

Change-Id: I6172080e4c025b6ad671ca9c33e08f6fdf8ded6a

Call eglSwapBuffers() to ensure wayland surface is attached

Resize surface tests initially create a window and a surface, ensure
that both has the same size, then perform a window resize, and ensure
that both windows and the surface has the same size.

When using a Wayland target, checking the window size is done calling
wl_egl_window_get_attached_size(). This actually returns the size of the
attached buffer, which is done calling wl_surface_attach().

But wl_surface_attach() is only guaranteed to be done when calling
eglSwapBuffers(); if wl_egl_window_get_attached_size() is invoked
before, it can return 0, as no buffer is attached yet.

To avoid this problem, ensure a buffer is attached before getting the
window size.

Affects:
dEQP-EGL.functional.resize.surface_size.*

Components: OpenGL

VK-GL-CTS issue: 594

Change-Id: I74fb9a10b269ea1e1f7a63457fb0df76f8604547

Merge pull request #119 from karolherbst/fix_51

Properly handle edge case in GL FP64 tests

Request queue with sparse support only when needed

Commit a598fe87 added tests for sparse D/S/DS images and
at the same time turned many texture tests into NotSupported
on implementations what do not support sparse.

Components: Vulkan

Affects:
dEQP-VK.texture.compressed.*
dEQP-VK.glsl.texture_functions.texture.sparse*shadow*
dEQP-VK.glsl.texture_gather.*depth32f*sparse*
dEQP-VK.texture.shadow.*sparse*

VK-GL-CTS issue: 1277

Change-Id: I83392d4f1060efbe0b1eebb0dfa8c8d5306113db

Merge remote-tracking branch 'khronos/master' into deqp-dev

Change-Id: Id3c4bfc8862ff4d36b40ea9fc91fd5441b0e6ba9

Don't fail DisplayPlaneProperties2 with no display

Instead, we should mark this test as not supported. The Vulkan spec
states that:
    Devices must support at least one plane on each display

If there are no displays connected, the driver is allowed to return 0
planes.

VK-GL-CTS issue: 1271
Components: Vulkan

Change-Id: I097224fbdf3e25c921ac9b96d16954caab1bb895
Affects: dEQP-VK.wsi.display.get_display_plane_properties2

Add tests for max fragment input component limit

New tests for fragment shader using input components
near device's maximum advertised limits. Also added
a new file for upcoming shader tests operating at
device's limits.

New tests:

dEQP-VK.glsl.limits.near_max.fragment_input.components_*

Components: Vulkan

VK-GL-CTS Issue 1128

Change-Id: Ib64d2f85016d8d552632d6a7d3f9a69ebe87a5c5

Add AHardwareBuffer external memory test for format/usage flags.

Added tests:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r8g8b8a8_unorm
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r5g6b5_unorm_pack16
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r16g16b16a16_sfloat
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.a2b10g10r10_unorm_pack32

Components: Vulkan
VK-GL-CTS issue: 738

Change-Id: I59726b742aee3a74a98615745bb6da1bfdf46c0b

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: Ibecbe98edbcd537ecafd9c11434fa4da2da399f0

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/master

Change-Id: I3795395ebc46986139592bd622500863be77d8fd

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I98aa8fd172cc42e79e22e0caedd4691b19e2f675

Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master

Change-Id: I007b37f5ae9318d15dc1134f7865081aa40cf5de

Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master

Change-Id: I393e8dfab66e2b4b1d5ccdb2684a92e6c0581999

Fix 8bit uniform buffers arrays strides

Affects:
dEQP-VK.spirv_assembly.instruction.*.8bit_storage.*

Components: Vulkan

VK-GL-CTS issue: 1269

Change-Id: I3f761efbe6a7e5edc66bc6846eaf90ac4453bd78

Fix dEQP-GLES3.functional.fbo.multiview.*

When the width of render target is an odd value, these tests failed.

The reason is these tests set default sample parameters and sample from
a 512x512 surface, where the left/right views have different colors.
When the width of render target is an odd value, the color of central
line is undefined.

As these tests' purpose is mainly want to verify whether the left/right
views have the different color, but not exactly care what the central
line is, a simple solution is just skip the check of central line.

Components: OpenGL

VK-GL-CTS issue: 1256

Affects: dEQP-GLES3.functional.fbo.multiview.*

Change-Id: I62c86dc7269864a3919b11a331178bfc54d65ab0

Loosen threshold in Texture3D tests

The verification function should consider both src and dst formats
when computing allowed error threshold.

Components: OpenGL

Affects:
KHR-GLES2.texture_3d.sub_image.*

VK-GL-CTS issue: 1243

Change-Id: Ie53aed63724aa75a0da697e30e7625a309acf76b

Some glCopyTexSubImage3D related tests conflict with GLES3.2 spec

According to the GLES3.2 spec,  An INVALID_OPERATION error is generated if the
component sizes of internalformat do not exactly match the corresponding
component sizes of the source buffer's effective internal format when call the
glCopyTExSubImage3D function.

The test format is GL_RGBA8, while different config ID will result in different
format in the render buffer. The number of channel bits of some format are not
equal to GL_RGBA8. So we should add a new FBO to restrict the test behavior.

Components: OpenGL

Affects: KHR-GLES2.texture_3d.copy_sub_image.*

VK-GL-CTS issue: 1240

Change-Id: I35c066fce990038e95da1e04197d659929fd8e86

Fix swap_buffers_with_damage.resize* hang on X11

In SwapBuffersWithDamageTest, the second time setSurfaceSize() was
called, because the size values were the same as the first call, the
test would hang with XNextEvent() in XlibWindow::setDimensions() waiting
for a ConfigureNotify event that Xserver would not deliver in
ConfigureWindow() if size was not changed.

Changing the if conditions causes size values to change for neighboring
setSurfaceSize calls and resolves the hang.

Affects:
dEQP-EGL.functional.swap_buffers_with_damage.resize*

Components: egl

VK-GL-CTS issue: 1238

Change-Id: I78177ffbef4f7f380d850ad43d83317f82401c7b

Merge remote-tracking branch 'khronos/master' into deqp-dev

Change-Id: I40b59c801207ce6fa52450ba83f719a56b153b0f

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: I84f31c35fbc322d5ff08cd2483c37f1354b7d5aa

Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/master

Change-Id: I8e4654033220a53f244768f319fb054026b30509

Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1

Change-Id: I92ddc3da6a7d67e926eb54beeaf1c190fcf7e87a

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: Ia0780339c58f56d142fec36e50954df190efdf81

Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master

Change-Id: I1e3e296b56699e97e9d536332fd6c4405b6f8cf2

Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master

Change-Id: I1864199105595d697561bcb6641692edbe75aa79

Update KC CTS reference

Components: Framework

Change-Id: Ie0085e80530c859cbd8f5da72e24e1e4450ce365

Fix memory allocation tests

Use deviceMemoryAllocationGranularity to determine if some number
of allocations of a particular size will succeed.
This is useful on when platform specific alignment restrictions are
present.

Components: Vulkan

Affects: dEQP-VK.memory.allocation.basic.size_*

VK-GL-CTS issue: 1259

Change-Id: Iac4f2e7842a826bebf7c641fad1950f6c3d48946

Allow two images worth of alignment slop in protected heap

We previously backed off by one image worth, but it's not enough in some
cases.

Components: Vulkan
VK-GL-CTS: 1262
Bug: b/109757443
Test: dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create#min_image_count
Change-Id: I01b3a72986e9f35b4ec15a146e4dc576758c02ce
(cherry picked from Android commit 0fd6d1afa4d00ffd3da1d2d1898f32d4e879209d)

Add option to embed validation layers in Android package

Based on https://github.com/KhronosGroup/VK-GL-CTS/pull/103 but reworked
a bit to allow setting the path directly. This allows easy codevelopment
of layers and tests.

Components: Framework
VK-GL-CTS: 1253

Change-Id: I232e48b82119f6bc358985d39be0def3c5a75766

Correct getProcAddress() handling in robustness tests

The below robustness tests don't use the OpenGL ES extension name when
calling getProcAddress() in an OpenGL ES environment. This change fixes
it by removing the getProcAddress() calls and use gl.XXX() to call these
functions. gl.XXX() takes care of the context it is running in.

Affects:
KHR-NoContext.*.robustness.no_reset_notification
KHR-NoContext.*.robustness.getnuniform
KHR-NoContext.*.robustness.readnpixels

Components: OpenGL
VK-GL-CTS issue: 1267

Change-Id: I4ed18990626f1dd744eebf6b99c18a60a29dad5f

Protected memory image access tests not flushing staging buffer

Affected tests:
dEQP-VK.protected_memory.image.access.*

Components: Vulkan

VK-GL-CTS issue: 1264

Change-Id: I30a6e3b0118b6874b9bfdf625aadec9c0fe54710

Remove an unneded type qualifier

This fixes check_build_sanity.py

Components: Vulkan

Change-Id: I0631c5ef2ede20a68a5853e497acc5e1106ab127

Add tests for packed vertex formats

Added tests for selected packed vertex formats to verify that vertex
attribute values are handled correctly in vertex shader.

New tests:

dEQP-VK.pipeline.vertex_input.single_attribute.*

Components: Vulkan

VK-GL-CTS issue: 1162

Change-Id: Ib20142c33d385e2c95dce1b3c6f547588cf59b2f

TextureBarrier required for texture_view.coherency

The third paragraph in section 9.3.1 gives conditions when
texture/framebuffer texture reads/writes are undefined. I
think that this test requires a TextureBarrier as described
in the last bullet point.

Affects:

KHR-GL46.texture_view.coherency

Components: OpenGL

VK-GL-CTS issue: 1183

Change-Id: I231ffd5acd089ebc1a9e0265c2f4a97f2a5c525c

Remove shaders.negative.unused_uniform_precision_matching

The GLSL spec was updated to "the types, precisions and any location
specifiers of all statically used uniform variables with the same name
must match across shaders that are linked into a single program."

which makes the unused_uniform_precision_matching test invalid.

Updating this test to use statically used uniforms would be
redundant to used_uniform_precision_matching.

Components: OpenGL
VK-GL-CTS issue: 1249

Affects:
KHR-GLES32.shaders.negative.unused_uniform_precision_matching

Change-Id: I6a60c9355144f1d539a6463d913844129e6dfc8d

Allow glFramebufferTexture2D with level!=0 in ES2 tests with ES3

These ES2 tests were expecting GL errors when attaching non-zero
levels to a framebuffer where GL_OES_fbo_render_mipmap is not
supported. This functionality is core in ES3 contexts, so the tests
much assume support for mippmapped rendering in this case.

Affects:
dEQP-GLES2.functional.negative_api.buffer.framebuffer_texture2d
dEQP-GLES2.functional.fbo.api.texture_levels

Components:
dEQP

VK-GL-CTS issue: 1263

Change-Id: I3dc7c8f1f2cc7efb5c227a0aec11983b185be03c

Shaders Derivate Tests: fix threshold

Derivate tests are calculating the threshold used for validating results
by taking in account a scale. Apparently this is incorrect, and is
causing some tests to fail.

A similar situation happened in Vulkan, and the proper fix was to do not
take in account the scale for the threshold calculation. Hence, applying
the same fix here fixes all the failing tests.

Affects:
dEQP-GLES3.functional.shaders.derivate.*
dEQP-GLES31.functional.shaders.derivate.*

Components: OpenGL

VK-GL-CTS issue: 1237

Change-Id: I106e36a708a6f75768c15ccdb4b064eb562cb28f

Exclude tests causing OOM

Components: OpenGL

Affects:
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_separate_grid_1000x1000_drawcount_5000
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_combined_grid_1000x1000_drawcount_5000
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawelements_separate_grid_1000x1000_drawcount_5000
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawelements_combined_grid_1000x1000_drawcount_5000

VK-GL-CTS issue: 1241

Change-Id: I3bc753391e2739387879ca117e9da29c98286cec

Allow glReadPixels() differences due precision errors

When comparing the results from glReadPixels() passing user-space memory
and using a PBO, there could be differences due drivers implementation
following different paths, and thus generating differences because of
precision errors.

Like in dEQP-GLES3.functional.read_pixels.* tests, add a threshold under
which the differences are acceptable.

Affects:
dEQP-GLES3.functional.pbo.*

Components: OpenGL

VK-GL-CTS issue: 1228

Change-Id: I7c9ac5de359cff8deba039b010357eae0da3eaaf

Fix a merge error after adding VK_KHR_driver_properties

Components: Vulkan

Affects:
dEQP-VK.api.info.get_physical_device_properties2.features

Change-Id: Ibeddf2320603661fdfbb68f246aeb2d7c570e890

Add test for VK_KHR_driver_properties

New tests:
dEQP-VK.api.driver_properties.properties

Components: Vulkan
VK-GL-CTS issue: 1098

Change-Id: Ifcb774700c45f76e48a03b147472a506d274c192

Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev

Change-Id: Ie5e8212fa6ee21ac3b1ffd7763be2026971539ab

Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master

Change-Id: I8280652b4a92e212649f1f7cf998b2be57f5ef9c