Ricardo Garcia [Mon, 14 Mar 2022 16:11:04 +0000 (17:11 +0100)]
Increase tolerance in mat3 determinant compute test
The determinant operation does not have strict precision requirements
and a recent change in Mesa broke this test for RADV. A slight increase
in tolerance fixes it.
Affected tests:
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3
VK-GL-CTS issue: 3571
Components: Vulkan
Change-Id: I5185bc4d45d848cbad11798f743ae65fbb798657
Matthew Netsch [Thu, 24 Mar 2022 20:40:15 +0000 (20:40 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ie55187998eab0ae965e731fc98511b86c842704e
Matthew Netsch [Thu, 24 Mar 2022 20:13:05 +0000 (20:13 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I81f233780e77ccfb79e9b1b9d982c9406a9ca268
Matthew Netsch [Thu, 24 Mar 2022 19:49:07 +0000 (19:49 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I8a313ea2aebdd5163a689b2cc31161e5963172a2
Michael Chock [Wed, 2 Mar 2022 17:16:34 +0000 (09:16 -0800)]
Check for visibility in external_memory_host test
The external_memory_host synchronization test uses mapMemory when
validating the contents of the external memory, but does not ensure that
the memory is host-visible. When choosing a memory type for the
host-visible memory, additionally check the HOST_VISIBLE flag.
Affects:
dEQP-VK.memory.external_memory_host.synchronization.synchronization
Components: Vulkan
VK-GL-CTS issue: 3547
Change-Id: I0cff8f42debedd01db1760881a6f5f9481ea39bf
Matthew Netsch [Thu, 10 Mar 2022 17:47:08 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I2280d6ce320738b91994d4603600c38d5d1ba4ee
Matthew Netsch [Thu, 10 Mar 2022 17:20:41 +0000 (17:20 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: If390df3efc02bff47f240c62e35d23e78c537b4c
Matthew Netsch [Thu, 10 Mar 2022 16:57:32 +0000 (16:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I31b3e7ec830aa10aa3c06ef61972a4e9c48dffc2
Matthew Netsch [Thu, 10 Mar 2022 16:34:26 +0000 (16:34 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I010f996f4b726f1f79e9bbe9b9f3e96131021f00
Boris Zanin [Tue, 1 Mar 2022 15:16:12 +0000 (16:16 +0100)]
Disable BC7 mode 8 pattern generation
Due to BC7 is underspecified for mode 8 (LSB=0x00) tests
should avoid testing it. This commit avoids generation
mode 8 BC7 compressed blocks.
Affects tests:
* dEQP-VK.*bc7*
Components: Framework, Vulkan
VK-GL-CTS issue: 3501
Change-Id: I222046f703fbead2bf5c64376defc6481989be24
Antto Mäkinen [Wed, 23 Feb 2022 12:18:08 +0000 (14:18 +0200)]
Fix checkSupport in compressed texture sampling tests
Compressed texture sampling tests didn't properly check that images
using a compressed format can be created with the extended usage
flags. This commit fixes the check.
VK-GL-CTS issue: 3225
Affected Tests:
dEQP-VK.image.sample_texture.*
Components: Vulkan
Change-Id: I1c077d29befac3d1b22c5ac2072518296f721f47
Matthew Netsch [Thu, 3 Mar 2022 18:00:13 +0000 (18:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib6194cc5034a2dada976ef494cf4c23fe997555f
Slawomir Cygan [Wed, 19 Jan 2022 11:51:01 +0000 (12:51 +0100)]
Don't adjust vertext buffer pointer in AS for indirect AS build.
Indirect build test programs offsets into the vertex buffer in the wr-asb
shader. This shader mimics vertex buffer pointer adjustment that is done in
AS build util.
Doing both adjustments (in shader and in AS) would cause out of bounds
accesses.
Authored-by: German, Leonid <leonid.german@intel.com>
Components: Vulkan
VK-GL-CTS Issue: 3540
Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure
Change-Id: Iace6cf96d478641f412de3a3d0ec7ab001860f29
Ricardo Garcia [Thu, 17 Feb 2022 10:09:07 +0000 (11:09 +0100)]
Do not require full subgroups when requiring a work group size
Most subgroup tests that require a particular work group size use the
VK_PIPELINE_SHADER_STAGE_CREATE_REQUIRE_FULL_SUBGROUPS_BIT_EXT flag when
creating the shader stage, but that in turn forces the local size in the
X dimension to have certain values as required by the following VUID:
VUID-VkPipelineShaderStageCreateInfo-pNext-02757
There are specific tests to check full subgroups. The flag can be safely
omitted and these other tests should still work.
Affected tests:
dEQP-VK.subgroups.*compute*
Components: Vulkan
VK-GL-CTS issue: 3520
Change-Id: Ic20d07d3a875156f817066d040ddf5813aef311f
Matthew Netsch [Thu, 3 Mar 2022 17:34:09 +0000 (17:34 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I589df8409840b42f6c683dda57616b3ee8359128
Matthew Netsch [Thu, 3 Mar 2022 17:11:01 +0000 (17:11 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I3cf7433d510e0966f4f4d96971519aa849cecda0
Matthew Netsch [Thu, 3 Mar 2022 16:47:59 +0000 (16:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I8e72cdeaa8eed150a5548dd30871eccb09f31d5c
Max Andersson [Mon, 7 Feb 2022 11:31:13 +0000 (12:31 +0100)]
Mark gl_Position as invariant in invariance tests
Always marks gl_Position as invariant. The reason
for this is that there is no guarantee that it
will be computed in an invariant way otherwise,
which may cause test failures.
Affects:
dEQP-VK.glsl.invariance.*user_defined*
VK-GL-CTS issue: 3493
Change-Id: Ia172664b454182458dbd13146c2d1688ecf4161f
Matthew Netsch [Thu, 24 Feb 2022 21:09:39 +0000 (21:09 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I37050cfb18cd34bd869b26531623f3b881973a3b
James Fitzpatrick [Wed, 16 Feb 2022 15:23:21 +0000 (15:23 +0000)]
Increase tolerance in multiple interpolation tests
These tests test that if a shader has multiple varyings with different
interpolation modes each varying is interpolated using the correct
interpolation mode.
The test runs a shader with multiple varyings with different
interpolation modes and expects this to be an exact match with an image
produced by a similar shader with a single varying of the same
interpolation mode.
Due to floating point inaccuracies and different rounding, allow a 1
bit tolerance when comparing the images.
Affects: dEQP-VK.draw.*multiple_interpolation.*
Components: vulkan
VK-GL-CTS issue: 3522
Change-Id: Ib4a8ab527644de5e1c36ecd3e627afe5384cc6f6
Matthew Netsch [Thu, 24 Feb 2022 20:13:47 +0000 (12:13 -0800)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I3e993e882a340347eea3582c1ba4feb3393b58fc
Matthew Netsch [Thu, 24 Feb 2022 19:07:22 +0000 (19:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I3ae2bc92916e5c4e2b525a085ba763d4c4b124d1
Ricardo Garcia [Fri, 11 Feb 2022 09:30:05 +0000 (10:30 +0100)]
Ray tracing: avoid skipping triangles and AABBs at the same time
This is illegal according to the spec.
Removed tests:
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*pipelineskipboth*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskiptriangles.pipelineskipaabbs*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipaabbs.pipelineskiptriangles*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipboth*
Components: Vulkan
VK-GL-CTS issue: 3508
Change-Id: Iebc50b4b546abc36b2607eeb7c5cbb900de35fcb
Connor Abbott [Fri, 21 Jan 2022 17:28:59 +0000 (18:28 +0100)]
Always use workaround for blitting to/from BC6H
Qualcomm's implementation of cubic filtering can give large inaccuracies
when texel values within the 4x4 grid are very big and very small,
especially if the values around the "edge" are much bigger then the
values at the center. This can happen with randomly-generated blocks for
floating-point compressed formats like BC6H. There was already a
workaround for similar issues seen blitting to e5b9g9r9, extend it to
all formats to fix this.
Components: Vulkan
VK-GL-CTS Issue: 3450
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.bc6h_ufloat_block.*
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.*.bc6h_ufloat_block.*
Change-Id: I3445ecba2ebc9e4e52e26111a109eaf79f611bd8
Will Lueking [Wed, 9 Feb 2022 20:34:10 +0000 (12:34 -0800)]
Fix build error on gcc 4.8
Changes a copy initializtion to a direct initialization.
GCC 4.8 complains about the copy initialization of
const tcu::StringTemplate meshTemplate = meshTemplateStr.str();
but not the direct initialization of
const tcu::StringTemplate taskDataDecl(taskDataDeclTemplate);
Replacing the copy initialization with the direct initialization fixes
the build issue.
Components: Vulkan
Affects: dEQP-VK.mesh_shader.nv.*
VK-GL-CTS issue: 3511
Change-Id: I9de57bc28e56da8288894e32c938fea0cd165927
Ricardo Garcia [Wed, 9 Feb 2022 10:09:33 +0000 (11:09 +0100)]
Fix load_store_op_none dynamic rendering validation error
The test case below was using a multisample color attachment with
integer format and specified VK_RESOLVE_MODE_AVERAGE_BIT as the resolve
mode, which is illegal. The purpose of the test is different, and the
resolve mode is not relevant, so it can be switched to one of the legal
values.
Affected tests:
dEQP-VK.dynamic_rendering.suballocation.load_store_op_none.color_load_op_none_store_op_none_resolve
Components: Vulkan
VK-GL-CTS issue: 3509
Change-Id: I42cf959f67d80694aee37c19c966ab037609d44f
Lionel Landwerlin [Sun, 30 Jan 2022 22:29:43 +0000 (00:29 +0200)]
Fix dynamic rendering multisampling test layout transition operation
Those tests are failing on Intel/Mesa because they're not
transitioning the right mip level from COLOR_ATTACHMENT to TRANFER_DST
layouts.
Component: Vulkan
Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*resolve_level*
VK-GL-CTS issue: 3482
Change-Id: I6dcdf6a9a72d96c559acd28f0114b308267d3cb8
Jason Ekstrand [Fri, 11 Feb 2022 00:20:08 +0000 (18:20 -0600)]
Use the correct stencilInitialLayout for unused resolve targets with separate stencil
The initial stencil layout was always being specified as UNDEFINED even
though, in the unused resolve target case, we clear it with
vkCmdClearDepthStencilImage() and need an initial layout of
TRANSFER_SRC_OPTIMAL.
Components: Vulkan
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*
Change-Id: Id0e0dcd2066d02758875a786c5634b23c893f7a2
Matthew Netsch [Thu, 17 Feb 2022 19:22:09 +0000 (19:22 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If3af09eda7b56dbfa484de49f06401ff53fda906
Ricardo Garcia [Thu, 10 Feb 2022 11:22:55 +0000 (12:22 +0100)]
Avoid invalid reportIntersectionEXT hit kinds in subroup tests
Some subgroup ray tracing tests were using invalid values when calling the
reportIntersectionEXT function.
Affected tests:
dEQP-VK.subgroups.*ray_tracing*
Components: Vulkan
VK-GL-CTS issue: 3513
Change-Id: I96310c32e1e5b4fde157570f0a3131d61f5a125c
Matthew Netsch [Thu, 17 Feb 2022 18:55:27 +0000 (18:55 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Iba2783e1e1e2bcb839c075dcf4d2b1dbcfbdf43f
Mika Väinölä [Thu, 3 Feb 2022 08:15:19 +0000 (10:15 +0200)]
Replace bitwise or with logical
This fixes a Clang 14 bitwise-instead-of-logical warning.
Affects:
dEQP-VK.robustness.robustness2.*
dEQP-VK.robustness.image_robustness.*
Components: Vulkan
VK-GL-CTS issue: 3492
Change-Id: I803ed494ed218b404a2285ed891d41170d66abfe
Matthew Netsch [Thu, 17 Feb 2022 18:32:10 +0000 (18:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I4adbb2e30086c26c8ad3312a6086e267c2840d42
Ricardo Garcia [Thu, 10 Feb 2022 10:49:21 +0000 (11:49 +0100)]
Avoid invalid reportIntersectionEXT hit kinds in mem guarantee tests
Only values in the [0, 127] range are allowed with reportIntersectionEXT.
Affected tests:
dEQP-VK.ray_tracing_pipeline.memguarantee.*
Components: Vulkan
VK-GL-CTS issue: 3513
Change-Id: I54669b5b7e2c0f696bbbf3e5a477b1533e4f4488
Matthew Netsch [Thu, 17 Feb 2022 18:08:53 +0000 (18:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Ib8646342ae0c6c9df3c7f2fa78c24643c10d5e96
Ilkka Saarelainen [Wed, 2 Feb 2022 13:37:18 +0000 (15:37 +0200)]
Fix validation errors in compute tests
This CL fixes various validation errors in compute tests.
Affects:
dEQP-VK.compute.basic.image_barrier*
dEQP-VK.compute.cooperative_matrix.*
Components: Vulkan
VK-GL-CTS Issue: 3451
Change-Id: I33037a50d10a5cf8098c33b55ba42900f97f0019
Sean Risser [Thu, 20 Jan 2022 08:35:37 +0000 (03:35 -0500)]
Delay initializing fragment_shading_rate tests
When the shading rate tests were renamed, they turned a delayed call
to createChildren into an immediate call. For partial test-suite runs,
this can significantly impact run times.
Components: Vulkan
VK-GL_CTS Issue: 3460
Affects:
dEQP-VK.fragment_shading_rate.*
Change-Id: Ie2bb7a7690b2650006da888433397dae9a5ff7cf
Ari Suonpaa [Wed, 2 Feb 2022 11:37:52 +0000 (13:37 +0200)]
Fix rounding issues with texture generation shader
VK-GL-CTS Issue: 3250
Affects:
dEQP-VK.graphicsfuzz.cov-global-loop-counter-texture-sample-loop-condition-set-array-element
dEQP-VK.graphicsfuzz.cov-multiple-fragcoord-conditions-false-never-return-sample-texture
dEQP-VK.graphicsfuzz.cov-nested-loops-sample-opposite-corners
Components: Vulkan
Change-Id: Ifba30c4dbf17f51c790ce66819da3785049bec6b
Matthew Netsch [Thu, 3 Feb 2022 21:55:20 +0000 (16:55 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I064e8e9c25536c26df4b575da647443cc753e542
Mika Väinölä [Tue, 11 Jan 2022 08:59:09 +0000 (10:59 +0200)]
Re-enable GCC warning for Amber
The Amber version used by vulkan-cts-1.2.7 and later includes aa69a0
which should fix all uninitialized variable warnings.
Components: Framework, Vulkan
VK-GL-CTS issue: 3361
Change-Id: I95bab777232216dad1c1c02bd57f21c8bd2a1528
Ari Suonpaa [Wed, 2 Feb 2022 11:27:03 +0000 (13:27 +0200)]
Fix rounding issues with texture generation shader
VK-GL-CTS Issue: 3250
Affects:
dEQP-VK.graphicsfuzz.cov-min-nested-loop-same-value-for-variables
dEQP-VK.graphicsfuzz.cov-sample-texture-hundred-iterations
dEQP-VK.graphicsfuzz.cov-sampler-as-function-argument
dEQP-VK.graphicsfuzz.cov-texel-double-negation
dEQP-VK.graphicsfuzz.cov-variable-copy-in-function-tex-sample
dEQP-VK.graphicsfuzz.spv-stable-sampler-loop-extra-instructions
dEQP-VK.graphicsfuzz.spv-stable-sampler-polar-simple-O-access-chain
Components: Vulkan
Change-Id: I1758bd50da844b2835c858ee5d78af4e7c4bd69a
Matthew Netsch [Thu, 3 Feb 2022 20:01:05 +0000 (15:01 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Ib1155d0946f8c94eed1395127c6441c6a1a54174
Matthew Netsch [Thu, 3 Feb 2022 19:07:05 +0000 (14:07 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I96cce7d1a37d9ab836f098aecf1f5895a9e0185d
Iulian Milas [Wed, 5 Jan 2022 11:35:03 +0000 (12:35 +0100)]
Fix Set/WaitEvent2KHR dependency flags setup
Vulkan specifies that the dependencyFlags member of pDependencyInfo
must be 0 in case of vkCmdSetEvent2KHR and vkCmdWaitEvents2KHR.
The conformance tests use a non zero default flag.
Components: Vulkan
Affects:
dEQP-VK.synchronization2.basic.event.*
dEQP-VK.synchronization2.op.single_queue.event.*
VK-GL-CTS Issue: 3462
Change-Id: Ic67fb77bcddf198fc77bbc9b3a25979d3e43678b
Matthew Netsch [Thu, 3 Feb 2022 16:56:37 +0000 (16:56 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Ic3ea84ef67493d7b596c4f4a9547b7841170a9a9
Peter Kohaut [Fri, 21 Jan 2022 08:55:35 +0000 (09:55 +0100)]
Fix compilation on Android
Function testSemaphoreImportSyncFdSignaled is not used and the build process
for Android fails because of it.
Fix just removes this unused function.
Components: Vulkan, AOSP
Affects:
None
VK-GL-CTS Issue: 3465
Change-Id: I82ad0e8df8196ac08d0003f30b7e624461239f84
Ricardo Garcia [Tue, 18 Jan 2022 15:22:48 +0000 (16:22 +0100)]
Fix issues in load_store_op_none tests
This commit fixes several issues from the load_store_op_none tests:
- Checking depth/stencil image format support in a checkSupport() method
instead of at iteration time.
- Validation error regarding mismatched attachment counts in dynamic
rendering variants.
- Validation error regarding image layout in dynamic rendering variants.
- Wrong barriers after clearing color and depth/stencil images.
- Make the code not assume depth/stencil formats have both aspects,
paving the way to testing more formats in the near future.
Affected tests:
dEQP-VK.*.load_store_op_none.*
Components: Vulkan
VK-GL-CTS issue: 3413
Change-Id: Iec237547f5762f299f1225eb4dda010e4256b367
Matthew Netsch [Fri, 28 Jan 2022 04:41:52 +0000 (04:41 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Idb8b94c0b0e0052ff4bafffcdf473b1e9aa468e1
Matthew Netsch [Fri, 28 Jan 2022 01:06:25 +0000 (01:06 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I078d372dbbcb1886aa13f37995bfcf50cd97413a
Matthew Netsch [Thu, 27 Jan 2022 23:10:08 +0000 (23:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I60ad45aaeeb84782bde80829cb1e731fb8e76b01
Matthew Netsch [Thu, 27 Jan 2022 19:12:43 +0000 (19:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Iff22de3540519a435bbb7874188bbcadec977b05
Nishit Shah [Thu, 20 Jan 2022 17:23:14 +0000 (11:23 -0600)]
Fix bug in calcFloatDiff
bsign variable in function calcFloatDiff is wrongly declared. Fixing.
VK-GL-CTS issue: 3472
Affects:
dEQP-VK.api.image_clearing.core.clear_depth_stencil_image*
and all the tests from the vktApiImageClearingTests.cpp file.
Components: Vulkan
Signed-off-by: Nishit Shah <nishit.shah@samsung.com>
Change-Id: I654920c9de460eb04caaca988552f65da3aa2687
James Fitzpatrick [Wed, 19 Jan 2022 11:46:20 +0000 (11:46 +0000)]
Relax precision for matrix precision tests
The Vulkan spec does not specify the precision for inverse and
determinant built in functions, however newly added tests effecitively
adds a precision requirement for them.
The precision required in these tests is too high for some valid
implementations of these builtin functions.
Relax the precision required in the tests to allow valid
implementations to pass.
Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*
Compontents: vulkan
VK-GL-CTS issue: 3182
Change-Id: Ib4c5b9d04578732456b8f981bc82a2c86ad877fa
Shih-hsin Li [Mon, 17 Jan 2022 04:33:09 +0000 (04:33 +0000)]
Skip the "two_draw" variants of zero_stride_with_offset tests
There's only one vertex in vertex array for singleVertex config.
Non-zero stride can cause out of bound memory access error since
vkd.cmdDraw draws 6(singleVertexDrawCount) vertices in singleVertex
config.
Affects:
dEQP-VK.pipeline.extended_dynamic_state.*.zero_stride_with_offset
Components: Vulkan
VK-GL-CTS issue: 3463
Change-Id: I77baa395c40f74f518bc9c7e8daf32c87686868a
Matthew Netsch [Sat, 22 Jan 2022 16:26:06 +0000 (11:26 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I4e8734003d9e689045fd25601bc521a4fb119f0b
Matthew Netsch [Fri, 21 Jan 2022 21:36:09 +0000 (16:36 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Iab61e615b3f7d5b108d925150255a73171e3d438
Matthew Netsch [Fri, 21 Jan 2022 17:33:04 +0000 (12:33 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: If56557dcb21ca8bfd90acbb2fffbd3f8ceed16f2
Mika Väinölä [Tue, 11 Jan 2022 07:45:02 +0000 (09:45 +0200)]
Re-enable Clang warning for Amber
The Amber version used by vulkan-cts-1.2.5 and later includes 4d0115c
which should fix all suggest-destructor-override warnings.
Components: Framework, Vulkan
VK-GL-CTS issue: 3361
Change-Id: I36437c797c067521e1444d20cfece33babfe435a
Mika Väinölä [Thu, 13 Jan 2022 08:00:09 +0000 (10:00 +0200)]
GCC 11 build fixes
Some files used std::numeric_limits without including <limits> and
failed to compile.
VK-GL-CTS issue: 2842
Change-Id: I21e37ce38db08c7c7041f4628ac852588a788852
Matthew Netsch [Thu, 20 Jan 2022 21:10:44 +0000 (21:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I790e54266657e91c84b9e40f6eb7385914d569c6
Ilkka Saarelainen [Wed, 17 Feb 2021 11:33:22 +0000 (13:33 +0200)]
Decrease required subgroup size
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point
test assumed that the subgroupSize is >= 8. The test failed if the
supported subgroupSize is less than 8.
This CL lowers the required subgroup size to 4.
Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point
Components: Vulkan
VK-GL-CTS issue: 2698
Change-Id: I9931dab7a57c0b6b73530e72bca0c0d9cc90f87d
(cherry picked from commit
8f9b9137470ed5b0cd0b38edd9e9c28ccf565731)
Jari Komppa [Tue, 11 Jan 2022 14:58:31 +0000 (16:58 +0200)]
Fix for potentially uninitialized variables
This change adds a constructor for a struct which sets the members that
do not have a constructor of their own to known values.
This potentially affects anything that uses the reference rasterizer,
but should not change any test results.
Affects:
*
Components: Framework
VK-GL-CTS issue: 3434
Change-Id: Ie874b4baa4d2ff5a8aa66f9ea2c3cd11b37edb64
Matthew Netsch [Thu, 20 Jan 2022 17:01:38 +0000 (17:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I3080cbdc60602f0faea714502bbc5461cac257e0
Mika Väinölä [Fri, 17 Dec 2021 07:10:19 +0000 (09:10 +0200)]
Fix NULL/False to std::string conversion errors
Newer versions of GCC reject std::string(DE_NULL). Previously this
didn't cause any errors or warnings when compiling, but should produce
an error at runtime. This change replaces invalid values with empty
string literals and adds deFatalStr for cases that potentially
relied on the string constructor throwing an exception.
Components: Framework, OpenGL, Vulkan
VK-GL-CTS issue: 3419
Change-Id: I68ec7d1447d1e96f5d7841e0684687cdd294fe39
Sean Risser [Fri, 30 Apr 2021 17:02:57 +0000 (13:02 -0400)]
Require geometry shaders for adjacency topologies
Clipping tests would use adjacency topologies with drivers that didn't
support geometry shaders.
Components: Vulkan
Affects: dEQP-VK.clipping.clip_volume.depth_clip.*
VK-GL-CTS Issue: 2906
Change-Id: I7a41e62dcbcdcab46ce4f8b04bfe322c688fbcac
Ari Suonpaa [Tue, 4 Jan 2022 13:04:12 +0000 (15:04 +0200)]
Remove redundant load/store op none tests
Load/store op none tests had originally a hard coded
depth stencil format, but was later changed to iterate
on multiple formats. The depth tests were accidentally
left there (as a duplicate) outside a format loop, and
the depth format parameter was uninitialized in these
tests.
This change removes these old tests and also fixes
the dynamic rendering tests to use correct depth
stencil formats.
VK-GL-CTS Issue: 3426
Affects:
dEQP-VK.*.suballocation.load_store_op_none.*
Components: Vulkan
Change-Id: I5c1e0a6d95bb1dbc88364f6e99f84e47619c285d
Mohankumar Nekkarakalaya [Tue, 11 Jan 2022 00:27:09 +0000 (16:27 -0800)]
Fix vktFragmentShadingRateBasic tests
Many graphics pipelines are used in dynamic render pass which uses
fragment shading attachment, but these pipelines don't have
VK_PIPELINE_CREATE_RENDERING_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR
flags when they are created. Adding those flags.
Affects: dEQP-VK.fragment_shading_rate.dynamic_rendering.*
Components: Vulkan
VK-GL-CTS issue: 3440
Change-Id: I3dd0aae9d6e9f2fc0bb5266f4f4ba442ebc0317b
Matthew Netsch [Fri, 14 Jan 2022 22:52:07 +0000 (17:52 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ic1cf8fed8e0713c216ff31212334cb53acbbf72d
Slawomir Cygan [Fri, 10 Dec 2021 10:34:37 +0000 (11:34 +0100)]
Fix getting capture address in RT capture replay tests
Use vkGetBufferOpaqueCaptureAddress to retreive address
used in opaqueCaptureAddress
Components: Vulkan
VK-GL-CTS Issue: 3420
Affects: dEQP-VK.ray_tracing_pipeline.capture_replay.shader_binding_tables
Change-Id: Ifaa2fe92d6517fa75a29ad21c06365efd7857de4
Sławomir Cygan [Mon, 10 Jan 2022 15:16:38 +0000 (16:16 +0100)]
Remove time measurement on deferred host build tests
The time measurement is wrongly implemented in this test
- it measures also thread creation, allocations and VK setup time, additionally
to AS build. It is not easily fixable.
Moreover, the spec says that offloading the work to background threads
is 'desirable', however it never says it is faster.
VK-GL-CTS Issue: 3435
Components: vulkan
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
dEQP-VK.ray_query.acceleration_structures.*
Change-Id: I41d836e2e454b9fb9bb46109edddd4eda19370e9
Matthew Netsch [Fri, 14 Jan 2022 17:36:58 +0000 (17:36 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I1d7510b4e0626392ff35aa1f38c1bd193b8ce319
Arkadiusz Sarwa [Tue, 7 Dec 2021 17:22:32 +0000 (18:22 +0100)]
Remove api.tooling_info.validate_instance_layers
Remove:
dEQP-VK.api.tooling_info.validate_instance_layers
Components: Vulkan
VK-GL-CTS issue: 3395
This reverts commit
7628909f404f665eb54c6a5019386747fb631134.
Change-Id: I68de938e73c10fed80d4e9bb3698b513a1b44315
Matthew Netsch [Fri, 14 Jan 2022 06:54:19 +0000 (06:54 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: Ic336acbf09ed630cc1b20ea82796f20369b1a5dc
Matthew Netsch [Fri, 14 Jan 2022 05:19:30 +0000 (05:19 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I7ec0667baf95d997230a8befced3ca4f2cda4876
Mohankumar Nekkarakalaya [Wed, 12 Jan 2022 21:23:25 +0000 (13:23 -0800)]
Fix sType Tooling Info tests
Tooling Info tests were not setting the sType correctly. This goes
against spec
where "sType must be
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TOOL_PROPERTIES_EXT". These
tests also check this sType to validate functionality.
Components: Vulkan
Affects:
dEQP-VK.api.tooling_info.*
VK-GL-CTS issue: 3444
Change-Id: Ic72104261a577d7d767742d4b2828296eba3922c
Paul Thomson [Fri, 3 Dec 2021 16:48:36 +0000 (16:48 +0000)]
DeqpTestRunner: fix deqpLogFilename
Fix capitalization of shell argument "deqpLogFilename" in
DeqpTestRunner.java. The code still worked fine in most cases because
the default filename matches the filename passed in DeqpTestRunner.java.
Components: Android
Google bug: b/
206657494
Change-Id: I857fa3994ada72aa96d199569704a46034255309
(cherry picked from commit
42017ff7072dcc7e7a7d51dd5611be05abf5460f)
Mikolaj Chadzynski [Thu, 23 Dec 2021 08:38:54 +0000 (09:38 +0100)]
Add format check to SharedPresentableImageTest
The SharedPresentableImageTest does not follow Vulkan spec.
The SurfaceFormats got by getPhysicalDeviceSurfaceFormats ->
getPhysicalDeviceSurfaceFormatsKHR should be checked by
vkGetPhysicalDeviceImageFormatProperties. This is according to:
www.khronos.org/registry/vulkan/specs/1.2-extensions/html/chap33.html
"33.5. Surface Queries
In addition to the surface capabilities as obtained by surface queries
below, swapchain images are also subject to ordinary image creation
limits as reported by vkGetPhysicalDeviceImageFormatProperties. As an
application is instructed by the appropriate Valid Usage sections, both
the surface capabilities and the image creation limits have to be
satisfied whenever swapchain images are created."
Unsupported format can lead to non-deterministic behavior e.g.
a segmentation fault, a null pointer dereference in a test or a driver.
VK-GL-CTS issue: 3422
Affects:
dEQP-VK.wsi.android.shared_presentable_image.*
Components: Vulkan
Change-Id: Id4bb4d1c81e090ed1d7f34a76f3cfafc464d8cf8
Matthew Netsch [Thu, 13 Jan 2022 21:38:03 +0000 (16:38 -0500)]
Fix inl files
Change-Id: I6468dff8d75e73dbd23a0a1b1b1314ea80ef954b
Components: Vulkan, Framework
Jari Komppa [Wed, 1 Dec 2021 15:00:14 +0000 (17:00 +0200)]
Fix stencil layout transitions in samplemask tests
This change fixes the validation layer errors for the _samplemask cases.
affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*_samplemask
Components: Vulkan
VK-GL-CTS issue: 3362
Change-Id: I0e1d9a44c3ed127fbde3765725243fae722ad938
Vidar Lilleboe [Tue, 30 Nov 2021 13:31:36 +0000 (14:31 +0100)]
Fix RGBA10x6 feature check
Verify that the extension is available before quering for support.
Affects:
dEQP-VK.api.info.format_properties.r10x6g10x6b10x6a10x6_unorm_4pack16
Components: Vulkan
VK-GL-CTS issue: 3370
Change-Id: Ib8cbbbe1f8c36b5022de1c04e623d49f5fb2b4c4
Graeme Leese [Tue, 4 Jan 2022 14:20:13 +0000 (14:20 +0000)]
Rename some waived tests for dynamic rendering
These tests were renamed in commit 90835b7 "Rename dynamic_rendering
tests", but the waivers file was not updated. (The Android waiver file
was updated, so is not changed here).
Component: Vulkan
VK-GL-CTS issue: 757
Change-Id: I0beae9cd0e6b4e33e8c8f717b0eae44797104844
Sławomir Cygan [Thu, 9 Dec 2021 15:50:53 +0000 (16:50 +0100)]
Fix barrier for initializing resolve attachment image to use proper level
This changes the level in the barrier to match level used by image view
used as resolve attachment in renderpass.
VK-GL-CTS Issue: 3407
Components: Vulkan
Change-Id: I500dfdbf15c4b7cd9943d3b063122107e1890688
Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*_resolve_level_*
Matthew Netsch [Fri, 7 Jan 2022 19:26:26 +0000 (14:26 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib63fd21efc3a2a3e4896a212d51e3ab1f12e56d4
Piotr Byszewski [Mon, 13 Dec 2021 14:08:09 +0000 (15:08 +0100)]
Checked .inl files back into the repo
By default .inl files won't be generated at build time but
this functionality is still present and to activate it
value of DEQP_VULKAN_INL_GEN_OUTPUTS_DIR should be changed
to point to PROJECT_BINARY_DIR.
VK-GL-CTS issue: 3197
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I6ba5932aa51740048c8dcc0c0222e8f7553ac4b3
Piotr Byszewski [Fri, 10 Dec 2021 12:32:27 +0000 (13:32 +0100)]
Pass force to fetch_sources
Switching vulkan-docs folders between gitlab and github branches
results in errors on the server (clobbering the tags). Using
fetch sources with --force param resolves the issue.
Components: Vulkan
VK-GL-CTS issue: 3197
Change-Id: I913d5803836e9f7a59494e5ebf6e6261ede52948
Ricardo Garcia [Thu, 11 Nov 2021 17:18:38 +0000 (18:18 +0100)]
Fix strided device address regions in RT misc tests
Some strided device address regions in ray tracing misc tests were being
created with the wrong size, not taking into account some tests were
storing several shader group handles in the binding tables.
In addition, this commit also fixes several validation errors in these
tests, related to bad sizes when flusing allocations and unaligned
strides in strided device address regions, which needed to be rounded
up.
Affected tests:
dEQP-VK.ray_tracing_pipeline.misc.*
Components: Vulkan
VK-GL-CTS issue: 3280
Change-Id: I7d20c347ff44b455547115d1a6b94c5d69a46c2c
Ricardo Garcia [Tue, 9 Nov 2021 16:26:37 +0000 (17:26 +0100)]
Fix ray tracing closedFan2 tests
The watertightness tests for ray tracing include a closedFan2 variant
that had several issues.
These tests create a circle made of a variable number of triangles, all
of them sharing a central vertex and all of them sharing two edges with
neighboring triangles.
With that composition, closedFan2 variants created one geometry, BLAS
and instance per triangle, and tried to verify certain rules regarding
closed fans and watertightness. This had several problems:
- By having each triangle belong to a different instance, the set up
does not meet the requirements for watertight geometry as laid out in
the spec.
- Ray tracing shaders were increasing atomic counters, indexing them per
ray and primitive id, in the any-hit shader. If a counter was
increased more than once, this was considered a failure. However, in
the closedFan2 variants all triangles have primitive id zero due to
all of them belonging to different geometries. If a ray was found to
hit two geometries/BLAS, it would result in a failure because the same
counter would be increased twice, but that result is legal according
to the spec.
This commit fixes closedFan2 tests by addressing both issues:
- The tests now create one geometry per triangle, but groups all
geometries in a single BLAS and instance, meeting the spec
requirements regarding closed fans.
- When increasing atomic counters, they are indexed per ray and per
geometry index, so it is illegal to hit the same geometry twice with
the same ray, following the rules of
VK_GEOMETRY_NO_DUPLICATE_ANY_HIT_INVOCATION_BIT_KHR, but they allow
the same ray to hit two triangles (geometries) as the spec allows.
In addition, it also removes some dead code and fixes angle calculation
so they fall in the [-pi, pi] range.
Affected tests:
dEQP-VK.ray_tracing_pipeline.watertightness.*
Components: Vulkan
VK-GL-CTS issue: 3150
Change-Id: I430be3a1830592d37b75031b8506a194c862a0d7
Jörg Wagner [Mon, 6 Dec 2021 08:57:51 +0000 (09:57 +0100)]
Reduce framebuffer size of dEQP-VK.graphicsfuzz.spv-stable-pillars-volatile-nontemporal-store
Reduce the size to 32x16 to avoid avoid timeouts on low-end platforms.
This shouldn't affect the ability to find compiler bugs because the
shader itself is the same.
Affects: dEQP-VK.graphicsfuzz.spv-stable-pillars-volatile-nontemporal-store
Components: Vulkan
VK-GL-CTS Issue: 3411
Change-Id: If4fac83d04723ab16e987a2f7d1495bf1a8f055f
Ilkka Saarelainen [Fri, 17 Dec 2021 05:36:16 +0000 (07:36 +0200)]
Fix validation errors in renderpass tests
This CL fixes the validation errors in some of the renderpass
tests. The tests incorrectly defined subpass dependency access
scopes for depth/stencil attachments in some cases.
Affects:
dEQP-VK.renderpass*.attachment_allocation.*
Components: Vulkan
VK-GL-CTS Issue: 3385
Change-Id: Ia9cc78bd28dde5b9cdbf4e28ba759e3bde44a9d0
Shih-Hsin Li [Wed, 24 Nov 2021 00:32:38 +0000 (16:32 -0800)]
Pick correct memoryTypeIndex for AHB
Pick the right memoryTypeIndex for protected allocations so that
protected memory is allocated when createFlag has protected bit
set. This fixed some bindImageMemory failure caused by binding
non-protected memory in testAndroidHardwareBufferImageFormat.
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.*
Components: Vulkan
Change-Id: Ib50a97d248930b6cc6538d1c7b84e84cddfde40e
Iago Toral Quiroga [Mon, 22 Nov 2021 07:29:50 +0000 (08:29 +0100)]
Allow rounding error when reading back Z buffer
The early fragment test produces Z values <= 0.5 and uses a shader
to write 0.75 that it expects to be ignored due to early fragment
tests, which it verifies by reading back the Z buffer and testing
that all values are <= 0.5.
On our platform, we observe that on storing 0.5 we retrieve
0.500008, which makes us fail the test incorrectly. Fix this
by adding a small room for rounding error, like we do for
other verification paths in these tests.
While we are doing this, lower the tolerance admited for
the late fragment test case as well.
Components: Vulkan
VK-GL-CTS Issue: 3340
Affects:
dEQP-VK.fragment_operations.early_fragment.discard_early_fragment_tests_depth
dEQP-VK.fragment_operations.early_fragment.discard_no_early_fragment_tests_depth
Change-Id: I8e1782b81d0e74a4a5af3e3cac40c9679f543ac6
Jari Komppa [Mon, 15 Nov 2021 08:25:36 +0000 (10:25 +0200)]
Fix amber vs cts device feature requirements
This change unifies the device requirements between cts and amber for
the affected tests.
Affects:
dEQP-VK.glsl.builtin.precision_fp16_storage16b.*
Components: Vulkan
VK-GL-CTS issue: 3304
Change-Id: I93f840751b40d145f89f847612e36733a18ac971
Piotr Byszewski [Mon, 22 Nov 2021 14:38:35 +0000 (15:38 +0100)]
Fix extended_dynamic_state tests
On vulkan-cts-1.2.8 branch extended_dynamic_state tests were
extended compared to the same group but in vulkan-cts-1.2.6 branch
(new tests were added). After updates to vulkan-cts-1.2.6 were
merged back to vulkan-cts-1.2.8 some of those new tests started
to fail as they did not have required changes.
This change makes sure that triangle strips are used in
the new tests to.
Components: Vulkan
VK-GL-CTS issue: 3327
Affects:
dEQP-VK.pipeline.extended_dynamic_state.*
Change-Id: I4fc19e40f6938d39be4428e8d9d98db4a74c0a5d
Matthew Netsch [Fri, 7 Jan 2022 17:55:19 +0000 (12:55 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts-1.2.7
Change-Id: I05420f73334f6aee2729ea2e8f76a079de896617
Piotr Byszewski [Wed, 8 Dec 2021 16:07:35 +0000 (17:07 +0100)]
Update kc-cts version
Version of kc-cts was updated to include fix for inl dependency.
Components: OpenGL
VK-GL-CTS issue: 3400
Change-Id: Ic28275604849506de4139c0bbda20278a2431ca1
Mohankumar Nekkarakalaya [Tue, 9 Nov 2021 17:56:08 +0000 (09:56 -0800)]
Create command pool with command buffer reset in RT tests
-When command pool was created either command buffer reset
bit should have been set or command buffer should have
reset pool before using for VU.
-Fix is to create command pool with reset bit set.
Components: Vulkan
VK-GL-CTS Issue: 3288
Affected tests: dEQP-VK.ray_tracing_pipeline.acceleration_structures.device_compability_khr.*
Change-Id: Ie21926cd53c505e46da0d03a6082e689d45d5d2a
Mika Väinölä [Tue, 30 Nov 2021 11:13:52 +0000 (13:13 +0200)]
Suppress GCC 11 conversion warning
On GCC 11 with UBSan enabled deHalfIsIEEENaN produces warnings due to
right shift promoting the result of an expression to an int, which is
then assigned to a deUint16.
Components: Framework
VK-GL-CTS issue: 3371
Change-Id: I48526b61ead69ee14b3253fa29737499253e62bc
Arkadiusz Sarwa [Wed, 17 Nov 2021 15:43:24 +0000 (16:43 +0100)]
Fix allocation of system memory.
Allocation of system memory which have been used as reference data can fail.
VK-GL-CTS issue: 3319
Components: Vulkan
Affects:
dEQP-VK.reconvergence.*
Change-Id: Icf9e6a2ad15912109aee2b6ea693a17650579087
Piotr Byszewski [Wed, 13 Oct 2021 12:17:14 +0000 (14:17 +0200)]
Generate inl files at build time
Inl files are no longer checked into the repo instead they are
generation at build time.
VK-GL-CTS issue: 3197
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I526ed3d8dc8cc54860e44937a5048e499248a3c6
Piotr Byszewski [Tue, 19 Oct 2021 09:19:58 +0000 (11:19 +0200)]
Add Vulkan-Docs to fetch sources
Header files that are used to generate inl files are no longer
checked into the repo. Headers are now generated in Vulkan-Docs
which are now fetched from the gitlab. Generation is done
by gen_framework.py.
VK-GL-CTS issue: 3197
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I4291848910b03180d4dc5514f8d8e5943c36e9b2