platform/upstream/VK-GL-CTS.git
19 months agoFix errors in dynamic rendering suballocation tests
ziga-lunarg [Sun, 13 Nov 2022 15:41:10 +0000 (16:41 +0100)]
Fix errors in dynamic rendering suballocation tests

attachmentCount in vkCmdClearAttachments must be greater than 0
depth aspect must only be cleared if depth attachment is set
stencil aspect must only be clear if stencil attachment is set

Components: Vulkan

VK-GL-CTS issue: 4102

Affected tests:
dEQP-VK.dynamic_rendering.*.suballocation.*

Change-Id: Id7cc51794883863aa9add62adee55ef30c0f6a28

19 months agoFixes for VK_EXT_image_compression_control swapchain tests
Marc Alcala Prieto [Fri, 18 Nov 2022 15:24:34 +0000 (16:24 +0100)]
Fixes for VK_EXT_image_compression_control swapchain tests

Ensure VK_KHR_get_surface_capabilities2 is requested when creating
Vulkan instances for the swapchain tests. This is required by
functions:
- vkGetPhysicalDeviceSurfaceCapabilities2KHR
- vkGetPhysicalDeviceSurfaceFormats2KHR

Enable imageCompressionControlSwapchain when creating devices for the
swapchain tests.

Properly set compressionControlPlaneCount depending on compression
flags.

Components: Vulkan

VK-GL-CTS issue: 4105

Affects:
dEQP-VK.api.image_compression_control.swapchain.*

Change-Id: I6b1ac25724ac605b91824e784a018f3e4fd717b7

19 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Thu, 1 Dec 2022 22:00:51 +0000 (22:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I4d3f1c8018aa246031409d52a6aa6716a95a67c7

19 months agoFixes for VK_EXT_image_compression_control tests
Marc Alcala Prieto [Fri, 18 Nov 2022 15:10:41 +0000 (16:10 +0100)]
Fixes for VK_EXT_image_compression_control tests

Fix the validation logic to check planes depending on format, not
compressionControlPlaneCount.

Properly set compressionControlPlaneCount and
pFixedRateFlags depending on compression flags.

Components: Vulkan

VK-GL-CTS issue: 4105

Affects:
dEQP-VK.api.image_compression_control.*

Change-Id: I492febb4163867ee722cd49e75cc8646aa8376f5

19 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Thu, 1 Dec 2022 20:14:56 +0000 (20:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ibbddec7b6ff3801fef7d359eb08935808a7cfe65

19 months agoUse pipeline layout alongside with fragment shader stage
Slawomir Cygan [Thu, 10 Nov 2022 16:12:05 +0000 (17:12 +0100)]
Use pipeline layout alongside with fragment shader stage

In pipeline libraries, pipeline layout is requried if fragment
shader is present in the pipeline.

Affects: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*

VK-GL-CTS Issue: 4096

Components: Vulkan
Change-Id: Ia70b0f18f497e2e9102e7748c87ea5e5092098bc

19 months agoFix color blend state color attachments in depth tests
ziga-lunarg [Sat, 12 Nov 2022 00:13:43 +0000 (01:13 +0100)]
Fix color blend state color attachments in depth tests

The number of color attachment in pColorBLendState must match the number
of color attachment in the subpass when creating the pipeline

Components: Vulkan

VK-GL-CTS issue: 4058

Affected tests:
dEQP-VK.pipeline.*.depth.*

Change-Id: Ibce5ff044c0804218d56d452eea7973c4c3a2990

19 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Thu, 1 Dec 2022 18:29:04 +0000 (18:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I699095999ad69b1ce79e50c3db6a06410005bdb5

19 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Thu, 1 Dec 2022 17:33:11 +0000 (17:33 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Iacdc3192254c41c569dbad94d8025b936f93cc25

19 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Thu, 1 Dec 2022 17:05:02 +0000 (17:05 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I7a7605b2dffeaedac543e32d97f13f552d6ab68f

19 months agoRe-add texture filtering tests with rgba10x6 format
ziga-lunarg [Fri, 4 Nov 2022 22:56:17 +0000 (23:56 +0100)]
Re-add texture filtering tests with rgba10x6 format

These tests were removed when only the check for
formatRgba10x6WithoutYCbCrSampler feature was missing

Components: Vulkan

VK-GL-CTS issue: 3646

New tests:
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear

Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3

19 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Thu, 1 Dec 2022 16:37:27 +0000 (16:37 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8

19 months agoFix invalid usage of descriptorCount for inline uniform
Hyunjun Ko [Wed, 23 Nov 2022 08:46:24 +0000 (17:46 +0900)]
Fix invalid usage of descriptorCount for inline uniform
 blocks.

Affects:
dEQP-VK.binding_model.descriptorset_random.*.iublimit*

VK-GL-CTS Issue: 4115

Components: Vulkan

Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898

19 months agoFix for 16 to 8-bit storage spirv_assembly tests
Gary Sweet [Thu, 24 Nov 2022 09:16:09 +0000 (09:16 +0000)]
Fix for 16 to 8-bit storage spirv_assembly tests

The output buffer was being made smaller than it was required to
hold all the results. Robust buffer accesss prevented the writes
from trampling memory after the buffer, but could mean that the
data in the valid part of the buffer was incorrectly written instead.

This change makes the output buffer large enough to prevent the
out-of-bounds writes.

Components: Vulkan

VK-GL-CTS issue: 4126

Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.storagebuffer_int_16_to_8.*

Change-Id: I59145be8012f7a31037ee3fee4d7ac96a198bc00

20 months agoFix barriers in dynamic rendering fragment density tests
Mike Byrne [Wed, 19 Oct 2022 11:16:55 +0000 (12:16 +0100)]
Fix barriers in dynamic rendering fragment density tests

Added additional barrier to ensure work on subsampled image is
complete before copy to output image.

Manual cherry-pick from vulkan-cts-1.3.1

Affects: dEQP-VK.dynamic_rendering.primary_cmd_buff.fragment_density_map*
 dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.fragment_density_map*
 dEQP-VK.dynamic_rendering.partial_secondary_cmd_buff.fragment_density_map*

Components: Vulkan

VK-GL-CTS Issue: 3796

Change-Id: I8d2276f6517cea7cd173a8f9b3bd7d40cebf3e6d

20 months agoFix to use the correct vulkan device
Mohd Faisal [Thu, 3 Nov 2022 13:41:42 +0000 (13:41 +0000)]
Fix to use the correct vulkan device

Wrong device used to create secondary command buffer with
command pool created with different vulkan device.

Affected tests:
dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.
fragment_density_map.*

Components: Vulkan
VK-GL-CTS issue: 4084

Change-Id: I878a3d43eb48cf033379da92d06c212f7a70ec29

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Thu, 17 Nov 2022 22:26:17 +0000 (22:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I3aae4026dd68350cf7f4e402e94f315498dfe4d8

20 months agoFixes barycentric test float64 support check
Matthew Netsch [Wed, 16 Nov 2022 21:01:09 +0000 (13:01 -0800)]
Fixes barycentric test float64 support check

Barycentric tests were not checking shaderFloat64 check

Components: Vulkan
VK-GL-CTS Issue: 4112

Affects:
dEQP-VK.fragment_shading_barycentric.*double*

Change-Id: Ie31ab9998e6bd9a8f551d4906f7cbda7417ea94b

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Thu, 17 Nov 2022 20:32:24 +0000 (20:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ib92b3d3b2282186df729d4694083ccaec6e3c525

20 months agoFix color blend state color attachments in depth tests
Lionel Landwerlin [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests

The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline

Components: Vulkan

VK-GL-CTS issue: 4058

Affected tests:
dEQP-VK.pipeline.*.depth.*
dEQP-VK.pipeline.*.stencil.*

Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec91234

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Thu, 17 Nov 2022 18:32:21 +0000 (18:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I2550c13c4df05f75c68a39aef76c1b9a032cfb94

20 months agoEnable VK_*_global_priority before using it
James Fitzpatrick [Mon, 14 Nov 2022 09:51:50 +0000 (09:51 +0000)]
Enable VK_*_global_priority before using it

A number of tests were testing functionality from
VK_EXT_global_priority and VK_KHR_global_priority without first
enabling the extension.

Affects: dEQP-VK.api.device_init.create_device_global_priority*

Components: vulkan

VK-GL-CTS issue: 4107

Change-Id: Ib6fc36a8602f544b945fad2f5bfec3c2f8bcd72c

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Thu, 17 Nov 2022 18:07:49 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I7cc1f00c66d75b85505ee76301f437ba878e5683

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Thu, 17 Nov 2022 17:39:42 +0000 (17:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ifffbd3aecc8e2d066ed988ed8fc5af4210aa88da

20 months agoAdd missing check for rgba10x6 features
ziga-lunarg [Fri, 4 Nov 2022 20:22:22 +0000 (21:22 +0100)]
Add missing check for rgba10x6 features

Feature formatRgba10x6WithoutYCbCrSampler must be supported if image is
created with format VK_FORMAT_R10x6G10X6B10X6A10X6_UNORM_4PACK16 and
level count is greater than 1

Components: Vulkan

VK-GL-CTS issue: 3992

Affected tests:
dEQP-VK.pipeline.image_view.view_type.*.format.*

Change-Id: I63f7d2083ea85d9f6232540d72178bd8172b13d5

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Thu, 17 Nov 2022 17:12:03 +0000 (17:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I571894bfd5fc1ab88a09272d7452522bce76165d

20 months agoFix failed memory map check for reconvergence tests
Christopher Hambacher [Fri, 11 Nov 2022 20:17:58 +0000 (14:17 -0600)]
Fix failed memory map check for reconvergence tests

Tests are checking for ResourceError, when a failed memory map will return TestError.

Components: Vulkan

VK-GL-CTS issue: 4100

Affected tests:
dEQP-VK.reconvergence.*

Change-Id: I61fcc9f29fe19ff592b74986ac39a7e3958f06e8

20 months agoLimit number of concurrent query pools
Ricardo Garcia [Tue, 15 Nov 2022 15:07:16 +0000 (16:07 +0100)]
Limit number of concurrent query pools

The max concurrency tests use a heuristic to try to estimate a safe
number of objects of different types that the implementation would be
able to create, with an upper limit of 16384 objects.

However, in some implementations the creation of these objects have
external limitations that make the safe value hard to guess by only
looking at system and device memory usage. For example, the kernel
driver may impose further limits on the total number of certain objects.

This is reflected in the current tests with some lower hardcoded limits
for some types of objects, like instances, devices, synchronization
primitives and pipeline caches.

This commit halves the limit of concurrent query pools being tested to a
value that doesn't trigger any issue in the Mesa RPi drivers.

Affects:
dEQP-VK.api.object_management.max_concurrent.query_pool

VK-GL-CTS issue: 4106
Components: Vulkan

Change-Id: If88c6aa1ecd3d9c18892b38cb55907a82eee6cf8

20 months agoFix reference value in YCbCr storage image tests
Graeme Leese [Mon, 31 Oct 2022 16:26:41 +0000 (16:26 +0000)]
Fix reference value in YCbCr storage image tests

This was just wrong.

Components: Vulkan
VK-GL-CTS issue: 4079
Affects: dEQP-VK.ycbcr.storage_image_write.*

Change-Id: Ib149247c58cf56ef49879954960ed8a65451c10e

20 months agoUpdate known conformance version for 1.3.4.1
Matthew Netsch [Fri, 11 Nov 2022 17:21:54 +0000 (09:21 -0800)]
Update known conformance version for 1.3.4.1

Components: Vulkan, Framework

Affects:
dEQP-VK.api.driver_properties.conformance_version

Change-Id: Ibc081172636f077194b4aa5521a1490309428338

20 months agoFix calling vkCmdClearAttachments with attachmentCount 0
ziga-lunarg [Fri, 14 Oct 2022 21:56:22 +0000 (23:56 +0200)]
Fix calling vkCmdClearAttachments with attachmentCount 0

attachmentCount in vkCmdClearAttachment must be greater than 0

Components: Vulkan

VK-GL-CTS issue: 4041

Affected tests:
dEQP-VK.dynamic_rendering.primary_cmd_buff.suballocation.unused_clear_attachments.*

Change-Id: I86a8fc834863581e05a05ebb17c558a803a05c14

20 months agoFix premature unmap of output buffer in dEQP-VK.ycbcr.storage_image_write.*
Ella Stanforth [Fri, 23 Sep 2022 13:35:47 +0000 (13:35 +0000)]
Fix premature unmap of output buffer in dEQP-VK.ycbcr.storage_image_write.*

Components: Vulkan

VK-GL-CTS issue: 4068

Affects:
dEQP-VK.ycbcr.storage_image_write.*

Change-Id: I7ee2da0802ee16b14f00776cbb4e750935223900

20 months agogetExportImportCompatibleModifiers: Test If Formats Support Blitting
Austin Shafer [Thu, 3 Nov 2022 20:10:06 +0000 (13:10 -0700)]
getExportImportCompatibleModifiers: Test If Formats Support Blitting

In the dEQP-VK.drm_format_modifiers.export_import* tests the
getExportImportCompatibleModifiers function verifies that the DRM
format modifiers and their corresponding VkFormats support transfer
operations, but these tests also perform blitting on images
created/imported with modifiers. This causes test failures in scenarios
where a modifier doesn't support blitting, such as
`DRM_FORMAT_MOD_LINEAR` on Nvidia hardware.

This change adds the VK_FORMAT_FEATURE_BLIT_*_BIT flags to
getExportImportCompatibleModifiers, properly limiting the modifiers
tested to ones that have reported the proper features.

VK-GL-CTS issue: 4086

Affects:
dEQP-VK.drm_format_modifiers.export_import*

Change-Id: If7adcaff730b150a0aa9afedb43737380a23fe55

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Fri, 11 Nov 2022 15:58:21 +0000 (15:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I5380a0c1ee46d052c86131d54fce2835cff9b9fc

20 months agoReintroduce tests for acceleration structure size query
Matthew Netsch [Wed, 17 Aug 2022 19:35:23 +0000 (19:35 +0000)]
Reintroduce tests for acceleration structure size query

VK-GL-CTS Issue: 3836

Components: Vulkan

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*.*.*.structure_size

Change-Id: Ie6d5bb49ef25f8066c83606d8307ebadb195f1a9

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Thu, 10 Nov 2022 22:07:01 +0000 (22:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: If6c415f4dddeb997b23aba4075f9608b2c99ddb8

20 months agoFix color blend state color attachments in depth tests
ziga-lunarg [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests

The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline

Components: Vulkan

VK-GL-CTS issue: 4058

Affected tests:
dEQP-VK.pipeline.*.depth.*

Change-Id: I1b566bd4aec80873631fe1edbb2ced47441c877a

20 months agoAdd missing image memory barrier in ray tracing pipeline tests
ziga-lunarg [Sun, 16 Oct 2022 22:08:53 +0000 (00:08 +0200)]
Add missing image memory barrier in ray tracing pipeline tests

Image layout transition from VK_IMAGE_LAYOUT_UNDEFINED to
VK_IMAGE_LAYOUT_GENERAL is missing

Components: Vulkan

VK-GL-CTS issue: 4056

Affected test:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*

Change-Id: I6c969985061b1c3e165148da24f899d5a7607e2a

20 months agoFix compressed texture tests always returning Pass
Sławomir Cygan [Fri, 14 Oct 2022 10:55:48 +0000 (12:55 +0200)]
Fix compressed texture tests always returning Pass

The test, if supported, was always returning Pass
disregarding the texture comparison result.

Affects: dEQP-VK.texture.compressed.*

VK-GL-CTS Issue: 4040

Components: Vulkan

Authored-by: Dorian R Apanel <dorian.r.apanel@intel.com>
Change-Id: I1da7204d248af3f6122f3acbe412980a86f6a403

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Thu, 10 Nov 2022 19:32:44 +0000 (19:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ide448246c50fedae41f37859022c20fffa764a1c

20 months agoEnable minLod feature when used
ziga-lunarg [Sun, 16 Oct 2022 17:34:09 +0000 (19:34 +0200)]
Enable minLod feature when used

The tests use VkImageViewMinLoadCreateInfoEXT::minLod, but do not enable
the minLod feature

Components: Vulkan

VK-GL-CTS issue: 4052

Affected tests:
dEQP-VK.texture.mipmap.3d.image_view_min_lod.min_lod.*

Change-Id: I2bf99e7543d3ebb799d50ac5f644cc2e12d535e2

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Thu, 10 Nov 2022 19:08:10 +0000 (19:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I1e2379907371708b4f3fb556938acb39f3f2f5bc

20 months agoFix wrong format in unused clear attachment tests
ziga-lunarg [Fri, 14 Oct 2022 21:03:32 +0000 (23:03 +0200)]
Fix wrong format in unused clear attachment tests

VkPipelineRenderingCreateInfo::depthAttachmentFormat must be a format
that includes a depth aspect or VK_FORMAT_UNDEFINED
VkPipelineRenderingCreateInfo::stencilAttachmentFormat must be a format
that includes a stencil aspect or VK_FORMAT_UNDEFINED

Components: Vulkan

VK-GL-CTS issue: 4041

Affected tests: dEQP-VK.dynamic_rendering.*.unused_clear_attachments.*

Change-Id: I8b003dd2a831e9205f6f91ea00c3ddf2541b512a

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Thu, 10 Nov 2022 18:39:54 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I9f9902ca38ce71e194a12f5aacff73afaaa37972

20 months agoAdd missing checks for geometry shader support
Ricardo Garcia [Fri, 21 Oct 2022 14:19:52 +0000 (16:19 +0200)]
Add missing checks for geometry shader support

Affects:
dEQP-VK.multiview.*geometry*
dEQP-VK.subgroups.*geometry*
dEQP-VK.fragment_shading_rate.*.gs*

VK-GL-CTS issue: 4064
Components: Vulkan

Change-Id: I64a3b6d7adc8da7671817710c4a4882db2c27035

20 months agoAdd missing read without format bit check in robustness tests
ziga-lunarg [Sat, 15 Oct 2022 00:03:25 +0000 (02:03 +0200)]
Add missing read without format bit check in robustness tests

If buffer view is being read as storage texel buffer with image format
of OpTypeImage being Unknown then the view's buffer features must
contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT

Components: Vulkan

VK-GL-CTS issue: 4047

Affected tests:
dEQP-VK.robustness.robustness2.bind.*

Change-Id: I46e5482fbfea3a945b133dbca0e020159049516f

20 months agoFix stencilAttachmentFormat in inverted depth ranges tests
ziga-lunarg [Fri, 14 Oct 2022 23:24:43 +0000 (01:24 +0200)]
Fix stencilAttachmentFormat in inverted depth ranges tests

If format is not VK_FORMAT_UNDEFINED in
VKPipelineRenderingCreateInfo::stencilAttachmentFormat then it must be a
format that includes a stencil aspect

Components: Vulkan

VK-GL-CTS issue: 4046

Affected tests:
dEQP-VK.draw.dynamic_rendering.inverted_depth_ranges.*

Change-Id: Ia0dcb1989b8ace78632d26dd0a1e3c1101f5f547

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Thu, 10 Nov 2022 18:12:22 +0000 (18:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I46781852d8da0c1c3d65c9435cf93cd05ce1781b

20 months agoFix viewport width in FSR with multiviewport tests
ziga-lunarg [Sun, 16 Oct 2022 22:42:52 +0000 (00:42 +0200)]
Fix viewport width in FSR with multiviewport tests

Tests with extent 1x1 create viewport with width equal to 0.0f

Components: Vulkan

VK-GL-CTS issue: 4057

Affected tests:
dEQP-VK.fragment_shading_rate.*

Change-Id: I99a050348de83d1790320bd5d6d711722dd1fbaf

20 months agoFix image barrier oldLayout in timeline semaphore tests
ziga-lunarg [Sat, 15 Oct 2022 19:51:22 +0000 (21:51 +0200)]
Fix image barrier oldLayout in timeline semaphore tests

Image layout in image barrier must be updated after first transition

Components: Vulkan

VK-GL-CTS issue: 4049

Affected tests:
dEQP-VK.synchronization.timeline_semaphore.one_to_n.*

Change-Id: I7fde2342007a3ec9c2562375fd634539e186acdc

20 months agoFix barrier in ray tracing pipeline build tests
ziga-lunarg [Sun, 16 Oct 2022 19:45:02 +0000 (21:45 +0200)]
Fix barrier in ray tracing pipeline build tests

If access mask is VK_ACCEDSS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR then
stage must be VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR

Components: Vulkan

VK-GL-CTS issue: 4053

Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*

Change-Id: I0a8080881f944319aae2417e5f9fe3297b933dd7

20 months agoFix pMutableDescriptorTypeLists in mutable descriptor tests
ziga-lunarg [Sun, 16 Oct 2022 01:50:25 +0000 (03:50 +0200)]
Fix pMutableDescriptorTypeLists in mutable descriptor tests

pMutableDescriptorTypeLists between srcBinding and dstBinding must match
exactly for copying descriptor sets

Components: Vulkan

VK-GL-CTS issue: 4051

Affected tests:
dEQP-VK.binding_model.mutable_descriptor.*

Change-Id: I64445e84ccd4872789a3db8b15e005d36c08d8a4

20 months agoFix to reset dynamicDenstiyMap after dynamic subsampled tets done.
Hyunjun Ko [Fri, 21 Oct 2022 00:27:05 +0000 (09:27 +0900)]
Fix to reset dynamicDenstiyMap after dynamic subsampled tets done.

Affects:
dEQP-VK.*.fragment_density_map.*.static_nonsubsampled*
dEQP-VK.*.fragment_density_map.*.deferred_nonsubsampled*

VK-GL-CTS Issue: 4062

Components: Vulkan
Change-Id: Ib347bd6e4734b2928ccacfa17dd01dfc134301bb

20 months agoFix flush memory range in ssbo corner case tests
ziga-lunarg [Fri, 14 Oct 2022 22:53:12 +0000 (00:53 +0200)]
Fix flush memory range in ssbo corner case tests

The size in VKMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory

Components: Vulkan

VK-GL-CTS issue: 4044

Affected tests:
dEQP-VK.ssbo.corner_case.*

Change-Id: I9ea2ee1e055b55ec39988a6ec0539cd3219937f4

20 months agoFix flush memory range in robustness vertex access tests
ziga-lunarg [Fri, 14 Oct 2022 23:11:59 +0000 (01:11 +0200)]
Fix flush memory range in robustness vertex access tests

The size in VkMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory

Components: Vulkan

VK-GL-CTS issue: 4045

Affected tests:
dEQP-VK.robustness.vertex_access.r32_sint.draw.*

Change-Id: I3d0944b6c6808dc66de0c9dc25f6c4e99578a1cf

20 months agoAdd shader image atomic int64 extension if used when creating device
ziga-lunarg [Sat, 15 Oct 2022 22:05:50 +0000 (00:05 +0200)]
Add shader image atomic int64 extension if used when creating device

Add VK_EXT_shader_image_atomic_int64 extension and enabled the features
when creating the device in sparse resources tests if the extension
is used

Components: Vulkan

VK-GL-CTS issue: 4050

Affected tests:
dEQP-VK.sparse_resources.*

Change-Id: If3de1d1e30a57db076802e2933392081c7c3069c

20 months agoFix attachment description in explicit vertex parameter tests
ziga-lunarg [Fri, 14 Oct 2022 22:30:38 +0000 (00:30 +0200)]
Fix attachment description in explicit vertex parameter tests

If initialLayout is VK_IMAGE_LAYOUT_UNDEFINED then loadOp must not be
VK_ATTACHMENT_LOAD_OP_LOAD

Components: Vulkan

VK-GL-CTS issue: 4043

Affected tests:
dEQP-VK.draw.explicit_vertex_parameter.*

Change-Id: I94cd72967798d424081f13033d1afbb3e11d993b

20 months agoPGQ tests overwrite gl_Position output from vs
Marcin Kańtoch [Thu, 13 Oct 2022 14:11:14 +0000 (16:11 +0200)]
PGQ tests overwrite gl_Position output from vs

dEQP-VK.transform_feedback.primitives_generated_query.* tests after the change
https://gerrit.khronos.org/c/vk-gl-cts/+/9450
overwrite the gl_Position output from vertex shader.
This is incorrect and causes failures.
Removed the gl_Position = vec4(1.0f); line from vs.

Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*

Components: Vulkan

VK-GL-CTS issue: 4039

Change-Id: Ib48d3f5d22a0ce41d9c4a52ebf3d8666f1b08c0e

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Fri, 28 Oct 2022 20:12:44 +0000 (20:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: Id9f7f82a7a889bc2c668afa13d65883e506634f8

20 months agoAdd missing flag in ray tracing with queries tests
ziga-lunarg [Tue, 11 Oct 2022 15:38:01 +0000 (17:38 +0200)]
Add missing flag in ray tracing with queries tests

Command buffer is reused but it is allocated from a command pool that
did not have VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT flag

Components: Vulkan

VK-GL-CTS issue: 4033

Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*

Change-Id: I68888c2a08647e9d77122e5888aba8f66d849f11

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Thu, 27 Oct 2022 19:04:07 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Iaf15595051e9e11e259a92c75d74f45881131dd7

20 months agoFix using NULL for the default color blend state
Iván Briano [Tue, 18 Oct 2022 21:50:40 +0000 (14:50 -0700)]
Fix using NULL for the default color blend state

Since graphics pipeline libraries was merged, we need to explicitly ask
for NULL to mean the default state when creating a pipeline.

Components: Vulkan

VK-GL-CTS issue: 4061

Affected tests:
dEQP-VK.pipeline.*stencil.*

Change-Id: If09ad15322cbc7e39ba4ae9c4cf9825ff131cd46

20 months agoFix independent_pipeline_layout_sets tests
ziga-lunarg [Tue, 11 Oct 2022 22:12:04 +0000 (00:12 +0200)]
Fix independent_pipeline_layout_sets tests

These bugs are already fixed in the main branch, but not in others

Invalid pipeline stages are used in pipeline barriers and wrong vertex
binding and description counts

Components: Vulkan

VK-GL-CTS issue: 4035

Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.independent_pipeline_layout_sets.*

Change-Id: I4c68ac57bd616cdbc2147d725d5b6ea1d6874d90

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Thu, 27 Oct 2022 18:31:37 +0000 (18:31 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I175ea10a0a7a64890834267adfc74ec62fee48d3

20 months agoFix VK_KHR_global_priority tests
ziga-lunarg [Wed, 21 Sep 2022 01:38:41 +0000 (03:38 +0200)]
Fix VK_KHR_global_priority tests

Support for priorities must be queries and if a priority is used but not
reported by VkQueueFamilyGlobalPriorityPropertiesKHR the driver must
fail with VK_ERROR_INITIALIZATION_FAILED

Components: Vulkan

VK-GL-CTS issue: 3898

Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*

Change-Id: I5570006758e73522968a2399a2a4294588b2dde5

20 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Thu, 27 Oct 2022 18:07:00 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I96317661558490598f309c45bc9a6d040b937d13

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Thu, 27 Oct 2022 17:38:34 +0000 (17:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I4b3c2c0c9e8185a634b8917faa9b67cd97469fe7

20 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Thu, 27 Oct 2022 17:10:48 +0000 (17:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I398ca9776ea24153af3f5cc4bd4db4812333d76a

20 months agoFix loadOp in imageless framebuffer test
ziga-lunarg [Mon, 10 Oct 2022 22:39:37 +0000 (00:39 +0200)]
Fix loadOp in imageless framebuffer test

If initial layout in attachment descriptions is
VK_IMAGE_LAYOUT_UNDEFINED, then the load op must not be
VK_ATTACHMENT_LOAD_OP_LOAD

Components: Vulkan

VK-GL-CTS issue: 4030

Affected tests:
dEQP-VK.imageless_framebuffer.*

Change-Id: I5e7f3f5e440dd380a05cf82127af4bea2538fdd2

20 months agoChoose optimal tiling with dmabuf in synchronization tests.
Tapani Pälli [Wed, 5 Oct 2022 16:59:48 +0000 (19:59 +0300)]
Choose optimal tiling with dmabuf in synchronization tests.

This is revert of commit 55027ea63. Problem is that while that change
caused coverage to raise on some drivers it decreased coverage on
others. Ideally this will be written in more dynamic way as a
follow-up work so that everyone could have coverage with these
tests.

Component: Vulkan

Affects: dEQP-VK.synchronization.cross_instance*

VK-GL-CTS issue: 2887

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I252c87ccd1870067417166bf1a4ba769a153105f

21 months agoFix memory binding tests
ziga-lunarg [Sun, 16 Oct 2022 21:07:41 +0000 (23:07 +0200)]
Fix memory binding tests

Wrong size is used in results verification

Components: Vulkan

VK-GL-CTS issue: 4055

Affected tests:
dEQP-VK.memory.binding.*

Change-Id: I3325070d5173dfcc469b2d836616f79a0777d8e4

21 months agoFix cull distance tests without fragment shader read
ziga-lunarg [Sun, 2 Oct 2022 19:45:08 +0000 (21:45 +0200)]
Fix cull distance tests without fragment shader read

These tests were supposed to test using gl_cullDistance but removing
those writes from shaders did not affect the tests passing

If fragment shader does not read cull distances the tests will now set a
cull plane and check the number of fragments culled

Components: Vulkan

VK-GL-CTS issue: 3502

Affected tests:
dEQP-VK.clipping.user_defined.clip_cull_distance.*

Change-Id: I5ea3d95cc14da934994db2b41aa22fa386570d70

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Fri, 14 Oct 2022 17:47:48 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: If76ee400b7f0be63031b08e25aacde0c900954ab

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Fri, 14 Oct 2022 17:47:41 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ie7b88a8cc79fcca867ba4d2d16005f88e848c981

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Fri, 14 Oct 2022 17:47:32 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I4e09eb19ac33ab340c6b7b0369f98b6b25257231

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Fri, 14 Oct 2022 17:47:16 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec9b74e

21 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Fri, 14 Oct 2022 17:47:09 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I2ea5abbe68202c09a290fad282bba0152514691b

21 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 14 Oct 2022 17:47:03 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Id224a630047cd512b36da121961684a9350ff731

21 months agoFixes zlib dependency
Matthew Netsch [Fri, 14 Oct 2022 16:22:49 +0000 (16:22 +0000)]
Fixes zlib dependency

Components: Framework

Change-Id: I70c130a367afa7d3eb2cbd81dd1662331c6723b8
(cherry picked from commit 188db4918e48556a330814d9e09ec305e4497227)

21 months agoPipeline creation feedback clear per iteration
marz [Tue, 4 Oct 2022 20:17:03 +0000 (22:17 +0200)]
Pipeline creation feedback clear per iteration

Considering pipelineStageCreationFeedbackCount = 0 case
memory that hold feedback information have to be memset to 0
every round of test to prevent false readings

Part two of the https://gerrit.khronos.org/c/vk-gl-cts/+/9765

Components: Vulkan

VK-GL-CTS issue: 3736

Affects:

dEQP-VK.pipeline.*.creation_feedback.*

Change-Id: I1dce88369b70dcff78baa9c18285d1a76c9ac71d

21 months agoFix rendering info flag in secondary command buffer
Sławomir Cygan [Fri, 7 Oct 2022 13:21:40 +0000 (15:21 +0200)]
Fix rendering info flag in secondary command buffer

According to spec, the rendering info flag cannot be
VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT
when calling vkCmdBeginRendering on secondary command
buffer.

Components: Vulkan

Affects:  dEQP-VK.draw.dynamic_rendering.complete_secondary_cmd_buff.differing_interpolation.*

VK-GL-CTS Issue: 4026

x

Change-Id: Ib34d810979bb3eef80f85f58cc8ed3e95b0ef32c

21 months agoFix dEQP-VK.dynamic_state.monolithic.discard to check if stencil format is supported
Sławomir Cygan [Thu, 6 Oct 2022 16:04:28 +0000 (18:04 +0200)]
Fix dEQP-VK.dynamic_state.monolithic.discard to check if stencil format is supported

Fix the test to pick stencil format from a list, instead of assuming that S8 format is supported

Components: Vulkan

Issues: 4024

Affects: dEQP-VK.dynamic_state.monolithic.discard.stencil

Change-Id: I5708fc6523369c5b72f04e1a4fcb1a9f3d5df3aa

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Matthew Netsch [Fri, 14 Oct 2022 14:21:04 +0000 (14:21 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: Ieddcbfb470587bd3263c22b78276d210355fb59c

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Matthew Netsch [Thu, 13 Oct 2022 21:38:44 +0000 (21:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I6f074d5b4611da1efe18afcee1707a3a2c3b4e03

21 months agoFix out-of-bounds vertex buffer writes in PrimitiveGeneratedQuery tests
Ricardo Garcia [Wed, 21 Sep 2022 15:01:14 +0000 (17:01 +0200)]
Fix out-of-bounds vertex buffer writes in PrimitiveGeneratedQuery tests

Wrong index usage was leaving a gap in the vertex buffer and writing out
of bounds.

Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*

Components: Vulkan
VK-GL-CTS issue: 3965
VK-GL-CTS issue: 3966

Change-Id: I2d656797506031713187a867902c05b1a363b450

21 months agoUpdate IMG waiver #229
James Fitzpatrick [Mon, 10 Oct 2022 17:23:16 +0000 (18:23 +0100)]
Update IMG waiver #229

Update waiver #229 after test names were changed to add tests for
VK_EXT_graphics_pipeline_libraries

Components: vulkan

VK-GL-CTS issue: 229

Change-Id: I33bd7a44631c8ddb95eff3a95db04033e2773983

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Matthew Netsch [Thu, 13 Oct 2022 21:07:11 +0000 (21:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I5350055731e9c6ef9cab81fc347f102681555570

21 months agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Thu, 13 Oct 2022 19:04:21 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I9a1dfa4f5801789b9ef062699bd6cadbfb1ddd20

21 months agoAdd missing barrier after cmdFillBuffer.
Arkadiusz Sarwa [Tue, 11 Oct 2022 14:29:06 +0000 (16:29 +0200)]
Add missing barrier after cmdFillBuffer.

Components: Vulkan

VK-GL-CTS issue: 4036

Affected tests:
dEQP-VK.api.image_clearing.*

Change-Id: Ieddaa85461311e1b39de4aeee69a192d01c6c92c

21 months agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Thu, 13 Oct 2022 16:45:19 +0000 (16:45 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I0146109f64a3a011ba56b33e1c498dcc0f2bae56

21 months agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Thu, 13 Oct 2022 16:16:54 +0000 (16:16 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I867eda5f06e1a9df38b95d604b1d98ee5691e552

21 months agoFix winding issue in watertightness tests
Alex Shi [Fri, 30 Sep 2022 04:29:53 +0000 (12:29 +0800)]
Fix winding issue in watertightness tests

The winding order of shared edge vertices wasn't consistent.
Add a check to ensure all triangles have same winding order.

Affects:
dEQP-VK.ray_tracing_pipeline.watertightness*
Components: Vulkan
VK-GL-CTS issue: 4009

Change-Id: I24607720fedcae2e903707dcd8f2d2d8b6ec12c0

21 months agoRemove tests using invalid sType
ziga-lunarg [Sat, 8 Oct 2022 18:32:44 +0000 (20:32 +0200)]
Remove tests using invalid sType

This test creates a structure with sType VK_STRUCTURE_TYPE_MAX_ENUM and
passes it to other create info structs through pNext, but this sType is
not allowed in the pNext of those create info structs

Components: Vulkan

VK-GL-CTS issue: 4023

Removed tests:
dEQP-VK.api.smoke-triangle_ext_structs

Change-Id: Iccfbcebb2bf9b43e93871bfc74aecea921bc31b8

21 months agoFix synchronization.cross_instance TEMPORARY permanence
Russell Chou [Tue, 4 Oct 2022 21:07:52 +0000 (14:07 -0700)]
Fix synchronization.cross_instance TEMPORARY permanence

VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT only supports TEMPORARY permanence, so check for that.

Affects:
dEQP-VK.synchronization.cross_instance.*_binary_semaphore_fence_fd
dEQP-VK.synchronization2.cross_instance.*_binary_semaphore_fence_fd

Components: Vulkan Framework
VK-GL-CTS issue: 4021

Change-Id: I6f663cbc35fcd7f81927878f31f78a6aaadf1a74

21 months agoFix subpass dependency in geometry layered tests
ziga-lunarg [Sun, 25 Sep 2022 15:39:29 +0000 (17:39 +0200)]
Fix subpass dependency in geometry layered tests

If both stages include a framebuffer-space stage in a self dependency,
then flags must include VK_DEPENDENCY_BY_REGION_BIT

Components: Vulkan

VK-GL-CTS issue: 3997

Affected tests:
dEQP-VK.geometry.layered.*

Change-Id: Id9941c16488a4c3bfbf569490d9e146437c4ae40

21 months agoFix color blend state in pipeline stencil tests
ziga-lunarg [Fri, 23 Sep 2022 23:31:28 +0000 (01:31 +0200)]
Fix color blend state in pipeline stencil tests

attachmentCount of pColorBlendState in pipeline create info must match
the colorAttachmentCount of the subpass used in creating the pipeline

Components: Vulkan

VK-GL-CTS issue: 3990

Affected tests:
dEQP-VK.pipeline.*stencil.*

Change-Id: Ic9bbcd9e14fc98e13e02698d7a138662a28782ae

21 months agoCheck if buffer size is multiple of nonCoherentAtomSize
ziga-lunarg [Mon, 19 Sep 2022 23:15:07 +0000 (01:15 +0200)]
Check if buffer size is multiple of nonCoherentAtomSize

When flushing memory range, if VK_WHOLE_SIZE is used, size must be a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize

Components: Vulkan

VK-GL-CTS issue: 3972

Affected tests:
dEQP-VK.memory.binding.*

Change-Id: If66e593f88af00450a55dfacc988df93ef6991eb

21 months agoFix enum values in pipeline robustness tests
Ricardo Garcia [Wed, 28 Sep 2022 11:32:48 +0000 (13:32 +0200)]
Fix enum values in pipeline robustness tests

Pipeline robustness tests fill out VkPipelineRobustnessCreateInfoEXT
structures using robustness2 values when robustness2 is not activated,
and vice versa.

Affected tests:
dEQP-VK.robustness.pipeline_robustness.*

Components: Vulkan
VK-GL-CTS issue: 4004

Change-Id: Ic3abe5fda40cc999a7ee288aa5df35ee407743f2

21 months agoFix missing multisample info in PrimitivesGeneratedQuery tests
Ricardo Garcia [Wed, 21 Sep 2022 15:06:48 +0000 (17:06 +0200)]
Fix missing multisample info in PrimitivesGeneratedQuery tests

The layers were complaining about the multisample state not being
passed.

Also see:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/4583

Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*

Components: Vulkan
VK-GL-CTS issue: 3965
VK-GL-CTS issue: 3966
Vulkan issue: 3240

Change-Id: I2b27992acd0882757ef758a69faa5378b56802e7

21 months agoPass fragment shading rate info to pre rasterization shader state
Ricardo Garcia [Thu, 29 Sep 2022 12:34:49 +0000 (14:34 +0200)]
Pass fragment shading rate info to pre rasterization shader state

Fragment shading rate info needs to be passed both as part of the
pre-rasterization shader state and as part of the fragment shader state
when creating pipelines, and it needs to be consistent in both cases.

The graphics pipeline library utilities were only passing that
information as part of the fragment shader state.

Affects:
dEQP-VK.fragment_shading_rate.*.misc_tests.*
dEQP-VK.fragment_shading_rate.*.basic.*
dEQP-VK.pipeline.*.mixed_attachment_samples.*
dEQP-VK.*.sample_locations_ext.*
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*

Components: Vulkan
VK-GL-CTS issue: 4006

Change-Id: Idebba54be2fe0a34a68aab1c5c9ba3d07affe47b