platform/upstream/mesa.git
15 months agoci/freedreno: a530 behaves stable in 6.3
David Heidelberg [Sat, 15 Apr 2023 13:12:35 +0000 (15:12 +0200)]
ci/freedreno: a530 behaves stable in 6.3

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>

15 months agoci: drop overriding new a530 firmware due to preemption issues with older kernel
David Heidelberg [Wed, 12 Apr 2023 15:46:33 +0000 (17:46 +0200)]
ci: drop overriding new a530 firmware due to preemption issues with older kernel

Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8825

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>

15 months agoci/freedreno: do not restrict to 2 cpus on a530
David Heidelberg [Thu, 13 Apr 2023 23:12:45 +0000 (01:12 +0200)]
ci/freedreno: do not restrict to 2 cpus on a530

Not needed for modern kernels (6.3+ for sure).

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>

15 months agoci: bump kernel to the 6.3, support HDK 888 based on sm8350
David Heidelberg [Sun, 2 Apr 2023 13:32:26 +0000 (15:32 +0200)]
ci: bump kernel to the 6.3, support HDK 888 based on sm8350

 - uprev to kernel 6.3-rc6
 - add sm8350 support (needed for HDK 888)
 - add missing patch for Asurada functionality
 - enable CONFIG_ARM_SMMU_QCOM, since we dropped specific patch
   worarounding need for it

Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>

15 months agotu/perfetto: s/MRTs/attachment_count/ in traces.
Emma Anholt [Mon, 3 Apr 2023 23:06:13 +0000 (16:06 -0700)]
tu/perfetto: s/MRTs/attachment_count/ in traces.

MRTs usually means >1 color buffers, so seeing "2" is surprising when
you're expecing just color and depth.  Makes the output look more Vulkan.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>

15 months agotu/perfetto: Drop unused arg to send_descriptors().
Emma Anholt [Wed, 5 Apr 2023 22:52:04 +0000 (15:52 -0700)]
tu/perfetto: Drop unused arg to send_descriptors().

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>

15 months agotu/perfetto: Use tu_CmdBeginDebugUtilsLabelEXT as a stage event in perfetto.
Emma Anholt [Wed, 8 Mar 2023 20:30:24 +0000 (12:30 -0800)]
tu/perfetto: Use tu_CmdBeginDebugUtilsLabelEXT as a stage event in perfetto.

This lets zink mark points of interest (particularly its barriers and
blits) with some useful data, for presenting in perfetto traces.

Closes: #8487
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>

15 months agotu/perfetto: Clean up an extra token paste to just use the arg being passed.
Emma Anholt [Wed, 29 Mar 2023 21:26:56 +0000 (14:26 -0700)]
tu/perfetto: Clean up an extra token paste to just use the arg being passed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>

15 months agotu/perfetto: Refactor code out of the macro, to stage_end.
Emma Anholt [Wed, 29 Mar 2023 21:25:24 +0000 (14:25 -0700)]
tu/perfetto: Refactor code out of the macro, to stage_end.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>

15 months agorusticl/event: drop work item before updating status
Karol Herbst [Sat, 15 Apr 2023 01:48:16 +0000 (03:48 +0200)]
rusticl/event: drop work item before updating status

This fixes some CTS compiler tests where they relied on the cl_kernel
object to be released in time so it can recompile a program without
throwing CL_INVALID_OPERATION due to still having active kernel objects.

Fixes: 47a80d7ff4f ("rusticl/event: proper eventing support")
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22510>

15 months agosymbol_table: Prehash the key on insert, and reuse the entry on shadowing.
Emma Anholt [Wed, 12 Apr 2023 19:13:24 +0000 (12:13 -0700)]
symbol_table: Prehash the key on insert, and reuse the entry on shadowing.

Mostly saves computing the hash twice, but while we're here there's no
need for shadowing to walk the table again.

Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive -4.19869%
+/- 3.20231%

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>

15 months agosymbol_table: Don't bother resetting the key on popping scope.
Emma Anholt [Wed, 12 Apr 2023 19:07:10 +0000 (12:07 -0700)]
symbol_table: Don't bother resetting the key on popping scope.

If you made a same-name symbol, then its name was just the name from the
parent scope anyway.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>

15 months agosymbol_table: Don't maintain the HT as we're destroying the table.
Emma Anholt [Wed, 12 Apr 2023 18:55:13 +0000 (11:55 -0700)]
symbol_table: Don't maintain the HT as we're destroying the table.

Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive -5.05801%
+/- 3.41206% (n=12)

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>

15 months agosymbol_table: Store the symbol name in the same allocation as the symbol entry.
Emma Anholt [Wed, 12 Apr 2023 18:30:24 +0000 (11:30 -0700)]
symbol_table: Store the symbol name in the same allocation as the symbol entry.

Saves an extra malloc.  Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive (which is a
lot of GLSL 4.60 builtin vars symbol table setup) -5.15821% +/- 3.19636%
(n=13).

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>

15 months agoci/amd: update checksums after DXVK 2.1 update
David Heidelberg [Fri, 14 Apr 2023 01:52:03 +0000 (03:52 +0200)]
ci/amd: update checksums after DXVK 2.1 update

Heaven got fixed with DXVK 2.1.

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>

15 months agoci/dxvk: uprev to 2.1
David Heidelberg [Sat, 28 Jan 2023 08:15:13 +0000 (09:15 +0100)]
ci/dxvk: uprev to 2.1

Major uprev, requires VK 1.3 now.

Acked-by: Martin Roukala <martin.roukala@mupuf.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>

15 months agoci/amd: 4/5 runners TPad-C13 runners are online, restore most of the tests
David Heidelberg [Thu, 13 Apr 2023 22:17:13 +0000 (00:17 +0200)]
ci/amd: 4/5 runners TPad-C13 runners are online, restore most of the tests

Partial revert of 590959057c2b ("ci/amd: raven is currently downgraded
to 2 machines only, adapt")

Test which remains disabled: radeonsi-raven-va:amd64 (VAAPI testing).

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>

15 months agoanv: enable blorp query reset for performance queries
Lionel Landwerlin [Thu, 13 Apr 2023 18:29:36 +0000 (21:29 +0300)]
anv: enable blorp query reset for performance queries

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Felix DeGrood <felix.j.degrood@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22480>

15 months agoci: Drop executable permissions from backend compiler wrapper script
Michel Dänzer [Wed, 12 Apr 2023 16:21:22 +0000 (18:21 +0200)]
ci: Drop executable permissions from backend compiler wrapper script

Not needed anymore, since the frontend scripts just source the backend
script now.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>

15 months agoci: Remove shebang from backend compiler wrapper script
Michel Dänzer [Wed, 12 Apr 2023 09:27:56 +0000 (11:27 +0200)]
ci: Remove shebang from backend compiler wrapper script

Not needed anymore, since the frontend scripts just source the backend
script now.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>

15 months agoci: Use set -e in frontend compiler wrapper scripts.
Michel Dänzer [Wed, 12 Apr 2023 09:26:07 +0000 (11:26 +0200)]
ci: Use set -e in frontend compiler wrapper scripts.

I doubt the shebang line in the backend script has any effect now,
since the frontend scripts just source it directly.

v2:
* Use "set -e" instead of adding -e to shebang (Eric Engestrom)

v3:
* Apply to the clang wrapper scripts as well (Eric Engestrom)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>

15 months agoci: Explicitly test for meson feature checks in compiler wrapper
Michel Dänzer [Wed, 12 Apr 2023 09:24:13 +0000 (11:24 +0200)]
ci: Explicitly test for meson feature checks in compiler wrapper

The previous indirect method was more complicated and still error prone.

v2:
* Use "grep -E" (Eric Engestrom)
* Exclude spaces and slashes in the grep pattern, to avoid accidentally
  matching across unrelated compiler arguments.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>

15 months agoutil: Delete Offset() macro from u_memory.h
Jesse Natalie [Thu, 13 Apr 2023 21:02:58 +0000 (14:02 -0700)]
util: Delete Offset() macro from u_memory.h

Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22494>

15 months agospirv/tests: Add test for single-block loop
Caio Oliveira [Wed, 15 Mar 2023 16:50:16 +0000 (09:50 -0700)]
spirv/tests: Add test for single-block loop

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22509>

15 months agodzn: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Jesse Natalie [Fri, 14 Apr 2023 16:21:26 +0000 (09:21 -0700)]
dzn: Remove #if D3D12_SDK_VERSION blocks now that 610 is required

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>

15 months agomicrosoft/clc: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Jesse Natalie [Fri, 14 Apr 2023 16:21:21 +0000 (09:21 -0700)]
microsoft/clc: Remove #if D3D12_SDK_VERSION blocks now that 610 is required

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>

15 months agod3d12: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Jesse Natalie [Fri, 14 Apr 2023 16:21:04 +0000 (09:21 -0700)]
d3d12: Remove #if D3D12_SDK_VERSION blocks now that 610 is required

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>

15 months agomeson: keep Mako version checking in accord with build msg
Luc Ma [Fri, 14 Apr 2023 10:53:57 +0000 (18:53 +0800)]
meson: keep Mako version checking in accord with build msg

Fixes: 52194ae4df1 ("meson: Ensure that mako is >= 0.8.0")
Signed-off-by: Luc Ma <luc@sietium.com>
Reported-by: Terry Zhang <terry@sietium.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22499>

15 months agoradeonsi/vcn: engage all jpeg engines on gfx940 for mjpeg decode
Sathishkumar S [Wed, 29 Mar 2023 10:58:50 +0000 (05:58 -0500)]
radeonsi/vcn: engage all jpeg engines on gfx940 for mjpeg decode

engage all available jpeg engines to decode mjpeg video frames

Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>

15 months agoradeonsi/vcn: enable RGBP format on gfx940 jpeg
Sathishkumar S [Thu, 6 Apr 2023 07:46:46 +0000 (02:46 -0500)]
radeonsi/vcn: enable RGBP format on gfx940 jpeg

decode output format conversion to RGBP is supported on gfx940 jpeg.

Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>

15 months agofrontends/va: add support for RGBP rt_format
Sathishkumar S [Wed, 29 Mar 2023 07:08:14 +0000 (02:08 -0500)]
frontends/va: add support for RGBP rt_format

check and enable RGBP rt_format and support VaImage creation for the RGBP/ARGB.

Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>

15 months agoutil/format: add planar3 r8_g8_b8_unorm pipe format
Sathishkumar S [Wed, 29 Mar 2023 07:03:38 +0000 (02:03 -0500)]
util/format: add planar3 r8_g8_b8_unorm pipe format

add pipe format to represent three plane 8bit RGB format

Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>

15 months agodocs: add INTEL_MEASURE=cpu
Felix DeGrood [Mon, 20 Mar 2023 16:30:26 +0000 (16:30 +0000)]
docs: add INTEL_MEASURE=cpu

Update documentation about INTEL_MEASURE=cpu

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoiris: Enable INTEL_MEASURE=cpu
Felix DeGrood [Thu, 23 Feb 2023 16:09:16 +0000 (16:09 +0000)]
iris: Enable INTEL_MEASURE=cpu

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoanv: Enable INTEL_MEASURE=cpu
Felix DeGrood [Wed, 22 Feb 2023 19:29:28 +0000 (19:29 +0000)]
anv: Enable INTEL_MEASURE=cpu

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agointel: INTEL_MEASURE cpu mode
Felix DeGrood [Wed, 22 Feb 2023 01:40:19 +0000 (01:40 +0000)]
intel: INTEL_MEASURE cpu mode

INTEL_MEASURE normally measures timing of GPU events. However, it
is sometimes useful to instead measure when these gfx API calls
were requested of the driver. INTEL_MEASURE cpu can be used in
in conjunction with other driver debug capabilities, like
INTEL_DEBUG=pc for analyzing stalls/flushes or when debugger is
attached, to track which frame you're currently on or where in
the frame you're at.

Initial commit, without plumbing into anv/iris.

"INTEL_MEASURE=cpu" will collect a cpu timestamp for each
INTEL_MEASURE event instead of GPU timestamps.

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoanv: split INTEL_MEASURE multi events
Felix DeGrood [Wed, 22 Feb 2023 00:53:37 +0000 (00:53 +0000)]
anv: split INTEL_MEASURE multi events

Measure performance of each draw separately in multi_draw event.
Previously, we measured duration of the sum of all draws launched
per multi_draw. This should provide more detailed data for
multi_draws.

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoanv: Add flush reason to NEEDS_END_OF_PIPE_SYNC
Felix DeGrood [Thu, 23 Feb 2023 18:28:49 +0000 (18:28 +0000)]
anv: Add flush reason to NEEDS_END_OF_PIPE_SYNC

cs_stall gets inserted if both flushes and invalidates are required.
This cs_stall reason was not called out explicitly, until now.

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoanv: Add flush reasons to raytracing flushes
Felix DeGrood [Wed, 22 Feb 2023 21:33:13 +0000 (21:33 +0000)]
anv: Add flush reasons to raytracing flushes

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoanv: Add END_OF_PIPE_SYNC reporting to INTEL_DEBUG=pc
Felix DeGrood [Wed, 22 Feb 2023 21:32:08 +0000 (21:32 +0000)]
anv: Add END_OF_PIPE_SYNC reporting to INTEL_DEBUG=pc

Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>

15 months agoradeonsi/vcn: add an exception of field case for h264 decoding
David (Ming Qiang) Wu [Thu, 13 Apr 2023 18:29:35 +0000 (14:29 -0400)]
radeonsi/vcn: add an exception of field case for h264 decoding

This is an error case where the I field has no reference, however
the reference list contains some reference, which resulting in
not be able to find its reference, and it is a correct behavior,
should not enter the correction code. Just add this exception to
prevent such a case, if more exceptions found, they will
be treated indiviually in the future.

Cc: mesa-stable
closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8740

Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Signed-off-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22485>

15 months agollvmpipe: fix some corner cases with line rendering
Roland Scheidegger [Thu, 13 Apr 2023 18:06:36 +0000 (20:06 +0200)]
llvmpipe: fix some corner cases with line rendering

Some comparisons were wrong depending on swapped endpoints and
the bottom_edge_rule (if the endpoint was exactly touching
pixel center), hence the code assuming a line endpoint which
should be drawn according to diamond exit rules would already be
drawn (so not adjusting the endpoint) when in reality it was not,
in which case the line would end up one pixel too short.

Note that this is still not fully correct - the logic as such
should be correct now, however these comparisons can give wrong
results due to float math vs. fixed point planes (an endpoint very
close to a pixel center might be exactly at pixel center in fixed
point), but this should do for now. (Also, the logic is still
completely wrong for state trackers not using half_pixel_center
setting, but this is only really a concern for dx9 state tracker.)

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22481>

15 months agollvmpipe: minor cleanups in line rendering code
Roland Scheidegger [Thu, 30 Mar 2023 16:31:52 +0000 (18:31 +0200)]
llvmpipe: minor cleanups in line rendering code

Use float constants, some code deduplication, no functional change.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22481>

15 months agov3d: set depth compare function correctly
Juan A. Suarez Romero [Thu, 13 Apr 2023 11:21:31 +0000 (13:21 +0200)]
v3d: set depth compare function correctly

Depth compare function must be set to the configured one only when
compare mode is enabled; otherwise it must be configured to never.

v2 (Eric):
- Handle V3D < 4.0 case

CC: mesa-stable
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22470>

15 months agozink: use correct primitives for passthrough gs with tess
antonino [Fri, 14 Apr 2023 10:47:17 +0000 (12:47 +0200)]
zink: use correct primitives for passthrough gs with tess

When tessellation is used the geometry shader needs to take the
tessellator output primitive as input.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Fixes: 90a8525d703 ("zink: handle edgeflags")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22498>

15 months agozink: don't emulate edgeflags for patches
antonino [Fri, 14 Apr 2023 10:03:06 +0000 (12:03 +0200)]
zink: don't emulate edgeflags for patches

Patches are used for tessellation, edgeflags don't work with
tessellation.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Fixes: 90a8525d703 ("zink: handle edgeflags")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22498>

15 months agoradv: tidy up dirtying RBPLUS state in radv_bind_dynamic_state()
Samuel Pitoiset [Thu, 13 Apr 2023 15:43:43 +0000 (17:43 +0200)]
radv: tidy up dirtying RBPLUS state in radv_bind_dynamic_state()

To dirty driver specific states at the same place.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22472>

15 months agoradv: re-emit the guardband state when related PSO are bound
Samuel Pitoiset [Thu, 13 Apr 2023 15:40:50 +0000 (17:40 +0200)]
radv: re-emit the guardband state when related PSO are bound

If one of the related states is static, the guardband state needs to be
re-emitted when a graphics pipeline is bound.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8828
Fixes: 40d8df72808 ("radv: emit the guardband state separately from the scissor state")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22472>

15 months agor600: fix refcnt imbalance related to r600_set_vertex_buffers()
Patrick Lerda [Sun, 2 Apr 2023 16:30:20 +0000 (18:30 +0200)]
r600: fix refcnt imbalance related to r600_set_vertex_buffers()

For instance, this issue is triggered with: "piglit/bin/useprogram-flushverts-2 -auto -fbo" or
"piglit/bin/primitive-restart-draw-mode line_loop -auto"
while setting GALLIUM_REFCNT_LOG=refcnt.log.

Fixes: 27dcb466293f ("gallium: add take_ownership param into set_vertex_buffers to eliminate atomics")

Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22395>

15 months agomeson: ensure i915 Gallium driver includes Intel sources
James Knight [Thu, 13 Apr 2023 20:38:51 +0000 (16:38 -0400)]
meson: ensure i915 Gallium driver includes Intel sources

Ensure builds flag the use of Intel sources when the i915 Gallium driver
is configured (`-Dgallium-drivers=i915`). Otherwise, a build may fail if
other Intel-based configuration options are not enabled:

    ./src/gallium/winsys/i915/drm/meson.build:21:0: ERROR: Unknown variable "libintel_common".

Signed-off-by: James Knight <james.d.knight@live.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22490>

15 months agointel: split URB space between task and mesh proportionally to entry sizes
Marcin Ślusarz [Wed, 12 Apr 2023 14:17:52 +0000 (16:17 +0200)]
intel: split URB space between task and mesh proportionally to entry sizes

Improves performance by 0.5-2.5% in vk_meshlet_cadscene
depending on the model.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22445>

15 months agoradv: try to keep HTILE compressed for READ_ONLY_OPTIMAL layout
Samuel Pitoiset [Thu, 13 Apr 2023 14:07:16 +0000 (16:07 +0200)]
radv: try to keep HTILE compressed for READ_ONLY_OPTIMAL layout

It should be handled like DEPTH_STENCIL_READ_ONLY_OPTIMAL.

This fixes an issue with VRS attachment because HTILE was considered
disabled for READ_ONLY_OPTIMAL but there is no reasons to disable it
as long as the image is only used as a depth/stencil attachment.

Otherwise, when HTILE is disabled, VRS rates are ignored.

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8675
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22468>

15 months agobroadcom/ci: deduplicate script definition
Eric Engestrom [Wed, 12 Apr 2023 21:10:12 +0000 (22:10 +0100)]
broadcom/ci: deduplicate script definition

It's always going to be the same for all the jobs in our farm.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Juan A. Suarez <igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22457>

15 months agovulkan: ignore rasterizationSamples when the state is dynamic
Samuel Pitoiset [Wed, 12 Apr 2023 13:26:24 +0000 (15:26 +0200)]
vulkan: ignore rasterizationSamples when the state is dynamic

Fixes: 1deb83fb86d ("vulkan: Add more dynamic multisample states")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22444>

15 months agoci: update shebang to make it more portable
Eric Engestrom [Wed, 12 Apr 2023 19:29:51 +0000 (20:29 +0100)]
ci: update shebang to make it more portable

Doesn't matter for now, but it doesn't cost anything to make it portable :)

Suggested-by: David Heidelberg <david.heidelberg@collabora.com>
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agoci: bump tags
Eric Engestrom [Wed, 12 Apr 2023 13:47:31 +0000 (14:47 +0100)]
ci: bump tags

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agoci: start documenting which image tags need to be bumped
Eric Engestrom [Wed, 12 Apr 2023 13:46:36 +0000 (14:46 +0100)]
ci: start documenting which image tags need to be bumped

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agoci: move deqp-egl instead of copying it
Eric Engestrom [Wed, 12 Apr 2023 10:10:19 +0000 (11:10 +0100)]
ci: move deqp-egl instead of copying it

To make sure we can't accidentally run a random leftover platform.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agoci: add -android suffix for android build of deqp-egl
Eric Engestrom [Wed, 12 Apr 2023 10:07:04 +0000 (11:07 +0100)]
ci: add -android suffix for android build of deqp-egl

Makes it clearer which platform is being run.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agoci: stop removing -x11 suffix for x11 build of deqp-egl
Eric Engestrom [Wed, 12 Apr 2023 10:06:02 +0000 (11:06 +0100)]
ci: stop removing -x11 suffix for x11 build of deqp-egl

Makes it clearer which platform is being run.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450>

15 months agointel/vec4: force exec_all on float control instruction
Lionel Landwerlin [Thu, 13 Apr 2023 16:34:15 +0000 (19:34 +0300)]
intel/vec4: force exec_all on float control instruction

Applying the same rule as the fs backend so that generation code
doesn't assert.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: daa8003e45 ("intel/fs: use nomask for setting cr0 for float controls")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22473>

15 months agoglthread: disable by default with fewer than 4 (big) CPUs
Mike Blumenkrantz [Wed, 5 Apr 2023 12:06:27 +0000 (08:06 -0400)]
glthread: disable by default with fewer than 4 (big) CPUs

with a low CPU count or low count of "big" CPUs, glthread hurts perf
much more than it helps, so it should be disabled

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21926>

15 months agodriconf: rework glthread enablement
Mike Blumenkrantz [Wed, 5 Apr 2023 11:51:36 +0000 (07:51 -0400)]
driconf: rework glthread enablement

this splits out glthread enablement into 3 settings:
- driver
- app
- user

which can then be modified with more granularity

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21926>

15 months agoutil/cpu: add big.LITTLE cpu detection
Mike Blumenkrantz [Wed, 15 Mar 2023 14:26:13 +0000 (10:26 -0400)]
util/cpu: add big.LITTLE cpu detection

it's useful for drivers to be able to detect big.LITTLE topology in
order to make decisions about how to handle workloads (specifically as
it relates to threading)

Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21926>

15 months agodocs/asahi: Add hardware glossary
i509VCB [Thu, 30 Mar 2023 01:55:27 +0000 (20:55 -0500)]
docs/asahi: Add hardware glossary

Explains some of hardware units referenced throughout the driver.

Signed-off-by: i509VCB <git@i509.me>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22200>

15 months agonouveau: nouveau_copy_buffer can deal with user_ptrs just fine
Karol Herbst [Sun, 13 Nov 2022 21:06:30 +0000 (22:06 +0100)]
nouveau: nouveau_copy_buffer can deal with user_ptrs just fine

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agonouveau: allow to enable SVM without having to enable CL
Karol Herbst [Sat, 5 Nov 2022 12:33:29 +0000 (13:33 +0100)]
nouveau: allow to enable SVM without having to enable CL

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agonv50/ir: ignore CL system values
Karol Herbst [Sat, 5 Nov 2022 12:20:33 +0000 (13:20 +0100)]
nv50/ir: ignore CL system values

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agorusticl: add support for fine-grained system SVM
Karol Herbst [Sat, 5 Nov 2022 12:33:45 +0000 (13:33 +0100)]
rusticl: add support for fine-grained system SVM

At the moment it's an all or nothing. A driver supporting fine-grained
system SVM can enable it in order to get full SVM support.

Lower levels could be emulated by userptrs and placing the bo at the same
locations in the GPU's VM as well, but that would require reworking quite
a bit on the drivers side.

For now supporting mmu_notifiers on the kernel side is the only way of
getting SVM support with Rusticl.

The only driver having the gallium bits wired up atm is Nouveau, but I
suspect it shouldn't be all to hard for iris and radeonsi as well.

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agorusticl/mem: add get_parent helper
Karol Herbst [Thu, 13 Apr 2023 13:53:17 +0000 (15:53 +0200)]
rusticl/mem: add get_parent helper

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agorusticl/memory: Rework mapping of memory located in system RAM
Karol Herbst [Sun, 13 Nov 2022 21:04:24 +0000 (22:04 +0100)]
rusticl/memory: Rework mapping of memory located in system RAM

The old code didn't consider a few cases where we could just map resources
located in system RAM.

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agorusticl/context: add helper to get the max mem alloc size for all devices
Karol Herbst [Sun, 6 Nov 2022 18:14:07 +0000 (19:14 +0100)]
rusticl/context: add helper to get the max mem alloc size for all devices

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agogallium: correctly name the flags of svm_migrate
Karol Herbst [Sun, 13 Nov 2022 13:17:00 +0000 (14:17 +0100)]
gallium: correctly name the flags of svm_migrate

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19712>

15 months agozink: remove screen param from zink_prune_query()
Mike Blumenkrantz [Thu, 13 Apr 2023 21:20:47 +0000 (17:20 -0400)]
zink: remove screen param from zink_prune_query()

no longer used

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22493>

15 months agozink: always defer query pool deletion
Mike Blumenkrantz [Thu, 13 Apr 2023 21:06:35 +0000 (17:06 -0400)]
zink: always defer query pool deletion

this feels dumb, but I can't think of a simpler way to do it that
would more accurately handle deletion while also guaranteeing
pool longevity

Fixes: 7da78ffb697 ("zink: create/use query pools dynamically")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22493>

15 months agozink: pass ctx through query destroy paths
Mike Blumenkrantz [Thu, 13 Apr 2023 21:22:20 +0000 (17:22 -0400)]
zink: pass ctx through query destroy paths

no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22493>

15 months agozink: remove atomics from zink_query
Mike Blumenkrantz [Thu, 13 Apr 2023 20:54:38 +0000 (16:54 -0400)]
zink: remove atomics from zink_query

this is never accessed from threads anymore and
hasn't been for a long time

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22493>

15 months agofrontends/va: report min width and min height values if available
Thong Thai [Thu, 13 Apr 2023 14:22:21 +0000 (10:22 -0400)]
frontends/va: report min width and min height values if available

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8756
Signed-off-by: Thong Thai <thong.thai@amd.com>
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22422>

15 months agoradeonsi: return min width and min height video cap values
Thong Thai [Thu, 13 Apr 2023 14:19:43 +0000 (10:19 -0400)]
radeonsi: return min width and min height video cap values

Signed-off-by: Thong Thai <thong.thai@amd.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22422>

15 months agogallium/pipe: add min width and min height video cap enums
Thong Thai [Thu, 13 Apr 2023 14:18:13 +0000 (10:18 -0400)]
gallium/pipe: add min width and min height video cap enums

Signed-off-by: Thong Thai <thong.thai@amd.com>
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22422>

15 months agov3d: add flake spec@ext_framebuffer_blit@fbo-sys-sub-blit
Eric Engestrom [Thu, 13 Apr 2023 19:21:08 +0000 (20:21 +0100)]
v3d: add flake spec@ext_framebuffer_blit@fbo-sys-sub-blit

https://gitlab.freedesktop.org/mesa/mesa/-/jobs/39905522

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22486>

15 months agod3d12: Support separate front/back stencils
Giancarlo Devich [Tue, 11 Apr 2023 23:47:40 +0000 (16:47 -0700)]
d3d12: Support separate front/back stencils

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3833
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22454>

15 months agod3d12: Add ID3D12GraphicsCommandList8 to the context
Giancarlo Devich [Wed, 12 Apr 2023 17:56:35 +0000 (10:56 -0700)]
d3d12: Add ID3D12GraphicsCommandList8 to the context

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22454>

15 months agod3d12: Update PSO creation to use CreatePipelineState
Giancarlo Devich [Tue, 11 Apr 2023 23:41:17 +0000 (16:41 -0700)]
d3d12: Update PSO creation to use CreatePipelineState

This uses CD3DX12_PIPELINE_STATE_STREAM3 from
d3dx12_pipeline_state_stream.h and gives us access to newer D3D12
features.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22454>

15 months agod3d12: Query device for D3D12_FEATURE_D3D12_OPTIONS14
Giancarlo Devich [Tue, 11 Apr 2023 23:39:42 +0000 (16:39 -0700)]
d3d12: Query device for D3D12_FEATURE_D3D12_OPTIONS14

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22454>

15 months agod3d12: Update and require DirectX-Headers 1.610.0
Giancarlo Devich [Tue, 11 Apr 2023 23:38:41 +0000 (16:38 -0700)]
d3d12: Update and require DirectX-Headers 1.610.0

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22454>

15 months agovulkan/runtime: discard unused graphics stages in libraries
Lionel Landwerlin [Thu, 13 Apr 2023 07:52:15 +0000 (10:52 +0300)]
vulkan/runtime: discard unused graphics stages in libraries

Anv is trying to rely on the stages put into the library graphics
state.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22460>

15 months agomesa/st/program: don't init xfb info if there are no outputs
Mike Blumenkrantz [Wed, 12 Apr 2023 16:57:13 +0000 (12:57 -0400)]
mesa/st/program: don't init xfb info if there are no outputs

this is almost certainly a failure case, but drivers still shouldn't
get xfb info if there are no outputs

affects:
spec@glsl-1.50@execution@interface-blocks-api-access-members

cc: mesa-stable

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22448>

15 months agollvmpipe: code clean-ups in llvmpipe_get_query_result_resource()
Brian Paul [Wed, 5 Apr 2023 15:42:04 +0000 (09:42 -0600)]
llvmpipe: code clean-ups in llvmpipe_get_query_result_resource()

Replace 'unsignalled' with 'ready' to simplify logic.
Remove needless !! in !!(a > b) expressions.
Remove some casting.  Use MIN2() macro.  Add const qualifiers.
Declare loop vars in loops.

Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22464>

15 months agollvmpipe: remove lp_setup_alloc_triangle()'s unneeded tri_size param
Brian Paul [Fri, 7 Apr 2023 20:04:53 +0000 (14:04 -0600)]
llvmpipe: remove lp_setup_alloc_triangle()'s unneeded tri_size param

This returned size was never used by the callers.

Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22464>

15 months agodocs: add missing MESA_VK_WSI_HEADLESS_SWAPCHAIN variable
Lionel Landwerlin [Thu, 13 Apr 2023 17:20:22 +0000 (20:20 +0300)]
docs: add missing MESA_VK_WSI_HEADLESS_SWAPCHAIN variable

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22478>

15 months agoamd: Rename INDIRECT_BUFFER_CIK to just INDIRECT_BUFFER.
Timur Kristóf [Thu, 13 Apr 2023 15:23:40 +0000 (17:23 +0200)]
amd: Rename INDIRECT_BUFFER_CIK to just INDIRECT_BUFFER.

This packet is supported on GFX6 too, its name should relect that.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22406>

15 months agoradv: Chain command buffers on GFX6 in radv_queue.
Timur Kristóf [Tue, 11 Apr 2023 00:31:28 +0000 (02:31 +0200)]
radv: Chain command buffers on GFX6 in radv_queue.

Also don't check whether chaining is enabled in radv_queue, the
winsys will take care of that anyway.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22406>

15 months agoradv: Use IB BOs (chaining) by default on GFX6.
Timur Kristóf [Tue, 11 Apr 2023 00:30:10 +0000 (02:30 +0200)]
radv: Use IB BOs (chaining) by default on GFX6.

GFX6 supports IB chaining since the PFP firmware version 20.
Note that the very first amdgpu firmware for GFX6 already had
version 29, so we can assume that all GPUs supported by RADV
have this feature.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22406>

15 months agoradv: Disallow IB2 on GFX6 when using draw_indirect_multi.
Timur Kristóf [Tue, 11 Apr 2023 00:29:38 +0000 (02:29 +0200)]
radv: Disallow IB2 on GFX6 when using draw_indirect_multi.

GFX6 has the same problem as GFX7 here.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22406>

15 months agoradv/amdgpu: Remove unnecessary assertions from chaining.
Timur Kristóf [Tue, 11 Apr 2023 11:59:49 +0000 (13:59 +0200)]
radv/amdgpu: Remove unnecessary assertions from chaining.

These used to guard against chaining on GFX6 and on HW IP types
that don't support chaining, but these things are now guarded
elsewhere and these assertions are no longer necessary.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22406>

15 months agor600/sfn: fix typos in code
Harri Nieminen [Tue, 11 Apr 2023 21:18:38 +0000 (00:18 +0300)]
r600/sfn: fix typos in code

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22432>

15 months agor600/sfn: fix typos
Harri Nieminen [Thu, 13 Apr 2023 11:09:00 +0000 (14:09 +0300)]
r600/sfn: fix typos

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22432>

15 months agor600/sb: fix typo
Harri Nieminen [Thu, 13 Apr 2023 11:08:22 +0000 (14:08 +0300)]
r600/sb: fix typo

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22432>

15 months agor600: fix typos
Harri Nieminen [Thu, 13 Apr 2023 11:07:09 +0000 (14:07 +0300)]
r600: fix typos

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22432>