platform/upstream/ofono.git
13 years agounit: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:57 +0000 (17:38 -0200)]
unit: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agoisi: Get rid of a pointless check in cf driver
Denis Kenzior [Mon, 29 Nov 2010 17:47:47 +0000 (11:47 -0600)]
isi: Get rid of a pointless check in cf driver

13 years agodrivers: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:56 +0000 (17:38 -0200)]
drivers: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agocoding-style: add rule about checking NULL pointer
Lucas De Marchi [Sat, 27 Nov 2010 19:38:55 +0000 (17:38 -0200)]
coding-style: add rule about checking NULL pointer

13 years agoTODO: Mark CTM task as done
Lucas De Marchi [Sat, 27 Nov 2010 19:22:55 +0000 (17:22 -0200)]
TODO: Mark CTM task as done

13 years agophonesim: implement ctm atom
Lucas De Marchi [Sat, 27 Nov 2010 19:22:54 +0000 (17:22 -0200)]
phonesim: implement ctm atom

13 years agoisi: Update radio-settings to use new API
Denis Kenzior [Mon, 29 Nov 2010 13:51:53 +0000 (07:51 -0600)]
isi: Update radio-settings to use new API

13 years agoradio-settings: Update API to use ofono_bool_t
Denis Kenzior [Mon, 29 Nov 2010 13:51:41 +0000 (07:51 -0600)]
radio-settings: Update API to use ofono_bool_t

13 years agoatmodem: Forgot to reset sms data on remove
Denis Kenzior [Sat, 27 Nov 2010 17:57:50 +0000 (11:57 -0600)]
atmodem: Forgot to reset sms data on remove

13 years agoconfigure: do not hard-code the C run-time library name
Rémi Denis-Courmont [Mon, 29 Nov 2010 08:29:02 +0000 (10:29 +0200)]
configure: do not hard-code the C run-time library name

Since oFono does (obviously) not use -nostdlib, this only broke support
for alternative C run-times.

13 years agosimutil: Add EFcfis and EFcphs-cff file Ids
Jeevaka Badrappan [Fri, 26 Nov 2010 06:23:31 +0000 (22:23 -0800)]
simutil: Add EFcfis and EFcphs-cff file Ids

13 years agocall-volume: Minor coding style fix
Jeevaka Badrappan [Fri, 26 Nov 2010 21:21:06 +0000 (13:21 -0800)]
call-volume: Minor coding style fix

13 years agoaudio-settings: Remove unwanted check
Jeevaka Badrappan [Fri, 26 Nov 2010 12:27:42 +0000 (04:27 -0800)]
audio-settings: Remove unwanted check

13 years agocall-volume: Remove extra line at EOF
Jeevaka Badrappan [Fri, 26 Nov 2010 20:59:38 +0000 (12:59 -0800)]
call-volume: Remove extra line at EOF

13 years agodoc: update cdma-voicecall-manager-api.txt
Arun Ravindran [Fri, 26 Nov 2010 09:54:02 +0000 (11:54 +0200)]
doc: update cdma-voicecall-manager-api.txt

13 years agonetwork: Use bit as size instead of byte
Yang Gu [Thu, 25 Nov 2010 12:29:00 +0000 (20:29 +0800)]
network: Use bit as size instead of byte

13 years agocore: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
core: Remove stray newlines in messages sent to log

13 years agoisigen: Remove stray newlines in DBG
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isigen: Remove stray newlines in DBG

13 years agoste: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
ste: Remove stray newlines in messages sent to log

13 years agoisi: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isi: Remove stray newlines in messages sent to log

13 years agocall-volume: Fix dbus error message type
Jeevaka Badrappan [Fri, 26 Nov 2010 14:59:32 +0000 (06:59 -0800)]
call-volume: Fix dbus error message type

13 years agobuild: Add forgotten test/test-tty
Denis Kenzior [Fri, 26 Nov 2010 19:22:55 +0000 (13:22 -0600)]
build: Add forgotten test/test-tty

13 years agotest: add test/set-tty script
Lucas De Marchi [Thu, 25 Nov 2010 17:42:00 +0000 (15:42 -0200)]
test: add test/set-tty script

To enable/disable text-telephony support

13 years agoctm: Tweak documentation to reflect implementation
Denis Kenzior [Fri, 26 Nov 2010 18:56:43 +0000 (12:56 -0600)]
ctm: Tweak documentation to reflect implementation

13 years agoctm: fix minor style issues
Denis Kenzior [Fri, 26 Nov 2010 18:55:50 +0000 (12:55 -0600)]
ctm: fix minor style issues

13 years agoctm: add documentation for TextTelephony interface
Lucas De Marchi [Thu, 25 Nov 2010 17:41:58 +0000 (15:41 -0200)]
ctm: add documentation for TextTelephony interface

13 years agoctm: Add initial CTM atom implementation
Lucas De Marchi [Thu, 25 Nov 2010 17:41:57 +0000 (15:41 -0200)]
ctm: Add initial CTM atom implementation

13 years agoctm: add public header
Lucas De Marchi [Thu, 25 Nov 2010 17:41:56 +0000 (15:41 -0200)]
ctm: add public header

13 years agostkutil: Minor style fixes
Denis Kenzior [Thu, 25 Nov 2010 23:58:37 +0000 (17:58 -0600)]
stkutil: Minor style fixes

13 years agostkutil: Use sms_dcs_decode in decode_text
Guillaume Lucas [Thu, 25 Nov 2010 16:15:04 +0000 (16:15 +0000)]
stkutil: Use sms_dcs_decode in decode_text

This is a much more pedantic version that can be used to
retrieve the text character set.

13 years agostk: use bigger timeout in DisplayText
Andrzej Zaborowski [Tue, 23 Nov 2010 13:35:41 +0000 (14:35 +0100)]
stk: use bigger timeout in DisplayText

When the wait for user confirmation bit is set.

13 years agocall-forwarding: skip property change data and fax
Jeevaka Badrappan [Wed, 24 Nov 2010 09:57:33 +0000 (01:57 -0800)]
call-forwarding: skip property change data and fax

13 years agodoc: Add PropertyChanged signal to voicecall api
Denis Kenzior [Wed, 24 Nov 2010 21:43:31 +0000 (15:43 -0600)]
doc: Add PropertyChanged signal to voicecall api

13 years agodoc: Add GetProperties to CDMA voicecall api
Denis Kenzior [Wed, 24 Nov 2010 21:43:17 +0000 (15:43 -0600)]
doc: Add GetProperties to CDMA voicecall api

13 years agodoc: Update voicecallmanager-api.txt
Arun Ravindran [Wed, 24 Nov 2010 14:56:11 +0000 (16:56 +0200)]
doc: Update voicecallmanager-api.txt

13 years agotext-telephony: add new interface to feature map
Lucas De Marchi [Tue, 23 Nov 2010 18:04:14 +0000 (16:04 -0200)]
text-telephony: add new interface to feature map

13 years agotext-telephony: define new dbus interface
Lucas De Marchi [Tue, 23 Nov 2010 18:04:13 +0000 (16:04 -0200)]
text-telephony: define new dbus interface

13 years agoTODO: Take ownership of neighbor cell atom task
Aki Niemi [Wed, 24 Nov 2010 12:39:20 +0000 (14:39 +0200)]
TODO: Take ownership of neighbor cell atom task

13 years agodoc: update radio-settings-api with possible errors
Lucas De Marchi [Tue, 23 Nov 2010 18:08:35 +0000 (16:08 -0200)]
doc: update radio-settings-api with possible errors

When GetProperties() and SetProperty() are called, there are more errors
that might be returned. Add them in documentation.

13 years agoRelease 0.36 0.36
Marcel Holtmann [Tue, 23 Nov 2010 13:55:57 +0000 (14:55 +0100)]
Release 0.36

13 years agodoc: Add initial CDMA D-Bus API proposal
Denis Kenzior [Tue, 23 Nov 2010 12:59:39 +0000 (06:59 -0600)]
doc: Add initial CDMA D-Bus API proposal

13 years agocommon: remove redundant predicate
Rémi Denis-Courmont [Tue, 23 Nov 2010 12:40:38 +0000 (14:40 +0200)]
common: remove redundant predicate

If the first character is a plus sign, then it is not a nul, then
the string length is true anyway.

13 years agodbus: Add __ofono_error_access_denied
Gustavo F. Padovan [Fri, 19 Nov 2010 21:37:08 +0000 (19:37 -0200)]
dbus: Add __ofono_error_access_denied

13 years agoTODO: Add owner to implement the Lockdown property
Gustavo F. Padovan [Fri, 19 Nov 2010 21:37:07 +0000 (19:37 -0200)]
TODO: Add owner to implement the Lockdown property

13 years agoTODO: add owner to Frequency Band Selection task
Lucas De Marchi [Fri, 19 Nov 2010 14:46:00 +0000 (12:46 -0200)]
TODO: add owner to Frequency Band Selection task

13 years agogatchat: remove write watcher on a disconnect
Denis Kenzior [Tue, 23 Nov 2010 09:21:22 +0000 (03:21 -0600)]
gatchat: remove write watcher on a disconnect

There's a small probability that we call chat_wakeup_writer
just before the channel disonnects.  When this happens the write
watcher still fires causing a potential crash.

13 years agostk: Minor style fix
Denis Kenzior [Tue, 23 Nov 2010 09:08:56 +0000 (03:08 -0600)]
stk: Minor style fix

13 years agostk: Handle null Text field
Andrzej Zaborowski [Mon, 22 Nov 2010 04:43:01 +0000 (05:43 +0100)]
stk: Handle null Text field

Add a NULL check in dbus_apply_text_attributes because in some places
(like DisplayText handler) we call it without checking and we just check
the return value once.

13 years agostemodem: Change use of types
Sjur Brændeland [Sun, 21 Nov 2010 20:55:15 +0000 (21:55 +0100)]
stemodem: Change use of types

Use the type __u32 for sequence counting rather than guint32,
and "void *" instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024,
as this should be sufficient to hold the NEWLINK message.

13 years agocall-settings: Add support for +COLR in atmodem
Denis Kenzior [Mon, 22 Nov 2010 22:48:45 +0000 (16:48 -0600)]
call-settings: Add support for +COLR in atmodem

13 years agocall-settings: Fix style issues
Denis Kenzior [Mon, 22 Nov 2010 22:32:27 +0000 (16:32 -0600)]
call-settings: Fix style issues

13 years agocall-settings: fix CLIR Invocation and Suppression
Denis Kenzior [Mon, 22 Nov 2010 22:29:46 +0000 (16:29 -0600)]
call-settings: fix CLIR Invocation and Suppression

According to 22.030 the *31# version is used to suppress CLIR
and #31# version is used to invoke CLIR.

13 years agocoding-style: Use stronger wording for rule M11
Denis Kenzior [Mon, 22 Nov 2010 16:13:34 +0000 (10:13 -0600)]
coding-style: Use stronger wording for rule M11

13 years agomodem: Don't notify online watches the first time
Denis Kenzior [Mon, 22 Nov 2010 15:56:22 +0000 (09:56 -0600)]
modem: Don't notify online watches the first time

We should not notify the online watches when we enter the OFFLINE state
for the first time.  We should only do so when we go from ONLINE state
into the OFFLINE state.

13 years agomodem: Miscellaneous style fixes
Denis Kenzior [Mon, 22 Nov 2010 10:29:06 +0000 (04:29 -0600)]
modem: Miscellaneous style fixes

13 years agomodem: add modem online-offline watch
Andras Domokos [Mon, 15 Nov 2010 16:57:55 +0000 (18:57 +0200)]
modem: add modem online-offline watch

13 years agoisi/voicecall: release COMING calls with BUSY cause
Pekka Pessi [Tue, 16 Nov 2010 17:05:23 +0000 (19:05 +0200)]
isi/voicecall: release COMING calls with BUSY cause

Very early incoming calls were not released with BUSY cause.

13 years agodoc: Fixup the use of read-write to readwrite
Denis Kenzior [Mon, 22 Nov 2010 11:20:28 +0000 (05:20 -0600)]
doc: Fixup the use of read-write to readwrite

13 years agoAUTHORS: Mention George's contributions
Denis Kenzior [Mon, 22 Nov 2010 11:12:49 +0000 (05:12 -0600)]
AUTHORS: Mention George's contributions

13 years agobuild: Update glib version in configure.ac
George Matveev [Fri, 19 Nov 2010 09:18:05 +0000 (10:18 +0100)]
build: Update glib version in configure.ac

function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher

13 years agosrc: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
src: coding style fixes - rule M6

13 years agosimutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
simutil: coding style fixes - rule M6

13 years agosimfs: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
simfs: coding style fixes - rule M6

13 years agostkutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
stkutil: coding style fixes - rule M6

13 years agosmsutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
smsutil: coding style fixes - rule M6

13 years agoutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
util: coding style fixes - rule M6

13 years agodoc: fix typos
Rémi Denis-Courmont [Thu, 18 Nov 2010 15:11:45 +0000 (17:11 +0200)]
doc: fix typos

13 years agomodem: Fix small coding style issue
Marcel Holtmann [Fri, 19 Nov 2010 10:40:31 +0000 (11:40 +0100)]
modem: Fix small coding style issue

13 years agoutil: Remove extra tab
Jeevaka Badrappan [Wed, 17 Nov 2010 15:32:43 +0000 (07:32 -0800)]
util: Remove extra tab

13 years agomodem: Fix up doc typo
Denis Kenzior [Wed, 17 Nov 2010 14:26:26 +0000 (08:26 -0600)]
modem: Fix up doc typo

13 years agoTODO: Add Location Service (AGPS) task.
Sjur Brændeland [Wed, 17 Nov 2010 07:09:13 +0000 (08:09 +0100)]
TODO: Add Location Service (AGPS) task.

13 years agocoding-style: Add exception to rule M12
Sjur Brændeland [Wed, 17 Nov 2010 07:09:12 +0000 (08:09 +0100)]
coding-style: Add exception to rule M12

For external enums

13 years agoSimplify ofono_modem_set_powered() logic
Gustavo F. Padovan [Fri, 12 Nov 2010 19:56:10 +0000 (17:56 -0200)]
Simplify ofono_modem_set_powered() logic

13 years agostemodem: Fix for error handling, memleak and changed some defines
Sjur Brændeland [Fri, 12 Nov 2010 15:02:38 +0000 (16:02 +0100)]
stemodem: Fix for error handling, memleak and changed some defines

* renamed MAX_LEN to IP_ADDR_LEN
* removed memory leak from unneeded strdup when parsing xml response.
* better handling of AT error responses
* reduced number of caif interfaces to 4

13 years agostemodem: Fix various coding style and logic issues with RTNL support
Marcel Holtmann [Sat, 13 Nov 2010 01:26:07 +0000 (10:26 +0900)]
stemodem: Fix various coding style and logic issues with RTNL support

13 years agostemodem: Add RTNL functionality managing CAIF Network Interfaces.
Sjur Brændeland [Fri, 12 Nov 2010 10:41:30 +0000 (11:41 +0100)]
stemodem: Add RTNL functionality managing CAIF Network Interfaces.

13 years agoisigen: create four gprs contexts
Mika Liljeberg [Thu, 11 Nov 2010 15:50:00 +0000 (17:50 +0200)]
isigen: create four gprs contexts

13 years agoisimodem: Get rid of whitespace corruption
Denis Kenzior [Thu, 11 Nov 2010 15:08:09 +0000 (09:08 -0600)]
isimodem: Get rid of whitespace corruption

13 years agomonitor-ofono: monitor DisconnectReason
Pekka Pessi [Thu, 11 Nov 2010 12:54:24 +0000 (14:54 +0200)]
monitor-ofono: monitor DisconnectReason

13 years agoisimodem: Fix style issues in gprs-context.c
Aki Niemi [Thu, 11 Nov 2010 08:11:24 +0000 (10:11 +0200)]
isimodem: Fix style issues in gprs-context.c

13 years agoisimodem: revector GPRS context driver
Mika Liljeberg [Wed, 10 Nov 2010 12:22:30 +0000 (14:22 +0200)]
isimodem: revector GPRS context driver

13 years agogisi: return NULL instead of asserting
Mika Liljeberg [Wed, 10 Nov 2010 12:22:29 +0000 (14:22 +0200)]
gisi: return NULL instead of asserting

13 years agogisi: fix crash bug in g_isi_remove_subscription
Mika Liljeberg [Wed, 10 Nov 2010 12:22:28 +0000 (14:22 +0200)]
gisi: fix crash bug in g_isi_remove_subscription

13 years agoTODO: Assign Voicecall emergency property task
John Mathew [Wed, 10 Nov 2010 16:09:49 +0000 (11:09 -0500)]
TODO: Assign Voicecall emergency property task

13 years agosms: Fix up comment style and wording
Denis Kenzior [Wed, 10 Nov 2010 15:17:19 +0000 (09:17 -0600)]
sms: Fix up comment style and wording

13 years agocbs: Minor style fixes
Denis Kenzior [Wed, 10 Nov 2010 15:15:51 +0000 (09:15 -0600)]
cbs: Minor style fixes

13 years agocbs: CBS-PP download must be enabled in sst / est
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:52 +0000 (04:27 +0100)]
cbs: CBS-PP download must be enabled in sst / est

13 years agosms: SMS-PP download must be enabled in sst / est
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:51 +0000 (04:27 +0100)]
sms: SMS-PP download must be enabled in sst / est

13 years agosim: Add sim_service_available()
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:50 +0000 (04:27 +0100)]
sim: Add sim_service_available()

This is meant to query EFsst or EFust.

The function is not public api because the service constants are in
src/simutil.h.

13 years agoTODO: Check SIM pin status if sim_change_pin fails
Marit Henriksen [Wed, 10 Nov 2010 11:35:45 +0000 (12:35 +0100)]
TODO: Check SIM pin status if sim_change_pin fails

13 years agobuild: Add reset-pin script
Denis Kenzior [Tue, 9 Nov 2010 16:18:14 +0000 (10:18 -0600)]
build: Add reset-pin script

13 years agoAdd test/reset-pin
Pekka Pessi [Mon, 8 Nov 2010 20:28:33 +0000 (22:28 +0200)]
Add test/reset-pin

13 years agoTODO: Add async SMS acknowledgement task
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:20 +0000 (18:42 +0100)]
TODO: Add async SMS acknowledgement task

13 years agoTODO: Mark SMS-PP download task as done
Denis Kenzior [Mon, 8 Nov 2010 19:43:22 +0000 (13:43 -0600)]
TODO: Mark SMS-PP download task as done

13 years agosms: Handle "USIM Download" SMS type.
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:19 +0000 (18:42 +0100)]
sms: Handle "USIM Download" SMS type.

13 years agostk: API for SMS Point-to-Point download to UICC
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:18 +0000 (18:42 +0100)]
stk: API for SMS Point-to-Point download to UICC

The callback returns the TP-User-Data element content of the RP-ACK or
RP-ERROR message, returned by the UICC.

13 years agoTODO: add owner to TTY support
Lucas De Marchi [Mon, 8 Nov 2010 19:07:05 +0000 (17:07 -0200)]
TODO: add owner to TTY support

13 years agoTODO: Add owner to silent modem reset
Gustavo F. Padovan [Mon, 8 Nov 2010 18:58:39 +0000 (16:58 -0200)]
TODO: Add owner to silent modem reset

13 years agoudev: do not use weird serial with zte
Pekka Pessi [Mon, 8 Nov 2010 18:41:24 +0000 (20:41 +0200)]
udev: do not use weird serial with zte

13 years agogprs: NULL-safe ofono_gprs_context_remove()
Pekka Pessi [Mon, 8 Nov 2010 18:41:07 +0000 (20:41 +0200)]
gprs: NULL-safe ofono_gprs_context_remove()

Check for NULL in one place.