platform/upstream/dotnet/runtime.git
6 years agoAdd more comments to StringBuilder.EnumerateChunks()
Vance Morrison [Wed, 23 May 2018 21:03:16 +0000 (14:03 -0700)]
Add more comments to StringBuilder.EnumerateChunks()

This does not change execution of the code (only comments, placement)

Added a warning about modifying the stringbuilder while enumerating.

Commit migrated from https://github.com/dotnet/coreclr/commit/c6409334f6fc56884bb7df91489293d52efaabd1

6 years agoRefactor fgDebugCheckBBlist (dotnet/coreclr#18082)
Sergey Andreenko [Wed, 23 May 2018 20:52:15 +0000 (13:52 -0700)]
Refactor fgDebugCheckBBlist (dotnet/coreclr#18082)

create BBPredsChecker

Commit migrated from https://github.com/dotnet/coreclr/commit/bc931bfa7dcfb3151c962916584b9531dc3d71f0

6 years agoSOS Fixes for windows arm32 (dotnet/coreclr#18090)
Chris Sienkiewicz [Wed, 23 May 2018 17:39:56 +0000 (10:39 -0700)]
SOS Fixes for windows arm32 (dotnet/coreclr#18090)

Commit migrated from https://github.com/dotnet/coreclr/commit/6185b9af8591283c5dbf1711d6064a23602f9760

6 years agoMerge pull request dotnet/coreclr#18079 from dotnet-maestro-bot/master-UpdateDependencies
Wes Haggard [Wed, 23 May 2018 17:29:28 +0000 (10:29 -0700)]
Merge pull request dotnet/coreclr#18079 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02823-01, preview1-26523-04, preview1-26523-05, master-20180523-0040, respectively (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/0c24aa0d3d81da5067f3f1d155174e46472985df

6 years agoFix parallel spmi return code. (dotnet/coreclr#18093)
Sergey Andreenko [Wed, 23 May 2018 17:23:18 +0000 (10:23 -0700)]
Fix parallel spmi return code. (dotnet/coreclr#18093)

Commit migrated from https://github.com/dotnet/coreclr/commit/d7be1d0f72a1b5367a4cb504ea7234f7b49e08c9

6 years agoMerge pull request dotnet/coreclr#18099 from CarolEidt/FixEliminNodeInfo
Carol Eidt [Wed, 23 May 2018 16:58:49 +0000 (09:58 -0700)]
Merge pull request dotnet/coreclr#18099 from CarolEidt/FixEliminNodeInfo

Fix desktop build break

Commit migrated from https://github.com/dotnet/coreclr/commit/7e517ed6b6a210c820a7336f199008f31c19d52f

6 years agoFix desktop build break
Carol Eidt [Wed, 23 May 2018 15:02:59 +0000 (08:02 -0700)]
Fix desktop build break

Commit migrated from https://github.com/dotnet/coreclr/commit/3fa689df0e56da296c2819c991c4bcfd7195f846

6 years agoMerge pull request dotnet/coreclr#18086 from sdmaclea/PR-delete_next_card_table
Bruce Forstall [Wed, 23 May 2018 14:53:12 +0000 (07:53 -0700)]
Merge pull request dotnet/coreclr#18086 from sdmaclea/PR-delete_next_card_table

Mark delete_next_card_table

Commit migrated from https://github.com/dotnet/coreclr/commit/f233b2a4d444aea570f409a413d3922d4c9a0cb7

6 years agoCreate RefPositions without TreeNodeInfo (dotnet/coreclr#16517)
Carol Eidt [Wed, 23 May 2018 14:39:43 +0000 (07:39 -0700)]
Create RefPositions without TreeNodeInfo (dotnet/coreclr#16517)

* Create RefPositions without TreeNodeInfo

* Remove all references to TreeNodeInfo

* Fix function header comments

Commit migrated from https://github.com/dotnet/coreclr/commit/b39a5b2cfad4620ae23cda84186a36ffb463cd5a

6 years agoMerge pull request dotnet/coreclr#18087 from BruceForstall/RemoveMoreLEGACY_BACKEND
Bruce Forstall [Wed, 23 May 2018 14:33:57 +0000 (07:33 -0700)]
Merge pull request dotnet/coreclr#18087 from BruceForstall/RemoveMoreLEGACY_BACKEND

Remove more JIT LEGACY_BACKEND tendrils

Commit migrated from https://github.com/dotnet/coreclr/commit/74d0196fe5b36bf04848f2cf84d20c8b6e999b62

6 years agoUpdate BuildTools, CoreClr, CoreFx, PgoData to preview1-02823-01, preview1-26523...
dotnet-maestro-bot [Wed, 23 May 2018 14:14:08 +0000 (07:14 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02823-01, preview1-26523-04, preview1-26523-05, master-20180523-0040, respectively

Commit migrated from https://github.com/dotnet/coreclr/commit/5138819d85d7e900c33faba39081d3e897e4f824

6 years agoFix race in test waitone1 (dotnet/coreclr#18085)
Steve MacLean [Wed, 23 May 2018 08:57:42 +0000 (04:57 -0400)]
Fix race in test waitone1 (dotnet/coreclr#18085)

Commit migrated from https://github.com/dotnet/coreclr/commit/fa3e66ea4225de823e7996e4d1a54d3f8cc68603

6 years agoRemove more JIT LEGACY_BACKEND tendrils
Bruce Forstall [Tue, 22 May 2018 21:25:34 +0000 (14:25 -0700)]
Remove more JIT LEGACY_BACKEND tendrils

1. Remove armlb testing from netci.groovy
2. Remove legacy jit exclusions from tests.lst
3. Remove some unused `LEGACY_BACKEND` build definitions
4. Remove regpair.h

Commit migrated from https://github.com/dotnet/coreclr/commit/6716e0ce0794f0139c8c15e3ca52d4bb5ebbce0b

6 years agofix desktop (dotnet/coreclr#18092)
Sergey Andreenko [Wed, 23 May 2018 02:38:44 +0000 (19:38 -0700)]
fix desktop (dotnet/coreclr#18092)

Commit migrated from https://github.com/dotnet/coreclr/commit/9c5e3d5d86901bd6bc0bd2d56e81cc0edec7eb13

6 years agoRemove -Rebuild option from build scripts (dotnet/coreclr#18089)
Brian Robbins [Wed, 23 May 2018 02:13:20 +0000 (19:13 -0700)]
Remove -Rebuild option from build scripts (dotnet/coreclr#18089)

Commit migrated from https://github.com/dotnet/coreclr/commit/7d930115ebd1a170af6b41caab3bb3906c476685

6 years agoadd treeLifeUpdater (dotnet/coreclr#18021)
dotnet bot [Wed, 23 May 2018 00:47:42 +0000 (17:47 -0700)]
add treeLifeUpdater (dotnet/coreclr#18021)

[tfs-changeset: 1700288]

Commit migrated from https://github.com/dotnet/coreclr/commit/d629c9967bd401c21123873c7d5175e721d40feb

6 years agoMerge pull request dotnet/coreclr#17530 from vancem/StringBuilderEnumerator
Vance Morrison [Tue, 22 May 2018 23:07:45 +0000 (16:07 -0700)]
Merge pull request dotnet/coreclr#17530 from vancem/StringBuilderEnumerator

Adding EnumerateChunks which allow efficient scanning of a StringBuilder

Commit migrated from https://github.com/dotnet/coreclr/commit/f9bb9e1d95bffecf42965ab6b13496fa51c5b412

6 years agoRemove JIT LEGACY_BACKEND code (dotnet/coreclr#18064)
Bruce Forstall [Tue, 22 May 2018 20:50:38 +0000 (13:50 -0700)]
Remove JIT LEGACY_BACKEND code (dotnet/coreclr#18064)

Remove JIT LEGACY_BACKEND code

All code related to the LEGACY_BACKEND JIT is removed. This includes all code related to x87 floating-point code generation. Almost 50,000 lines of code have been removed.

Remove legacyjit/legacynonjit directories

Remove reg pairs

Remove tiny instruction descriptors

Remove compCanUseSSE2 (it's always true)

Remove unused FEATURE_FP_REGALLOC

Commit migrated from https://github.com/dotnet/coreclr/commit/7153e441ef21e9bb5e022229c0808b964b9199e0

6 years agoMark delete_next_card_table
Steve MacLean [Tue, 22 May 2018 19:29:51 +0000 (15:29 -0400)]
Mark delete_next_card_table

GCStressIncompatible=true
IsLongRunningGCTest=true

Commit migrated from https://github.com/dotnet/coreclr/commit/85e4d78e33294dd1b25171f9e961d89ec7339513

6 years agoMove InsufficientMemory, OutOfMemory and ThreadInterrupted exceptions (dotnet/coreclr...
Maryam Ariyan [Tue, 22 May 2018 18:26:07 +0000 (11:26 -0700)]
Move InsufficientMemory, OutOfMemory and ThreadInterrupted exceptions (dotnet/coreclr#18049)

* Move following exceptions to shared:

    - InsufficientMemory,
    - OutOfMemory
    - ThreadInterrupted

Related to: dotnet/coreclrdotnet/coreclr#17904

Reduced diff in RegistryKey visible between coreclr and corert

Commit migrated from https://github.com/dotnet/coreclr/commit/32ab54d345a4ab2eb572fe3ba061b6e0d1b31088

6 years agoFixe whitespace
Vance Morrison [Tue, 22 May 2018 18:25:01 +0000 (11:25 -0700)]
Fixe whitespace

Commit migrated from https://github.com/dotnet/coreclr/commit/0ba7f8d3a974382a214820330408f20389317306

6 years agoFix whitespace
Vance Morrison [Tue, 22 May 2018 18:18:36 +0000 (11:18 -0700)]
Fix whitespace

Commit migrated from https://github.com/dotnet/coreclr/commit/79cbf2e17f6cdd1095671c6ab9fa8b9c48bba0f5

6 years agoFix attribute placement
Vance Morrison [Tue, 22 May 2018 18:16:05 +0000 (11:16 -0700)]
Fix attribute placement

Commit migrated from https://github.com/dotnet/coreclr/commit/57055f17d50e275e9c904b3f8975065e3d7af526

6 years agoCollapse ChunkEnumerable and ChunkEnumerator.
Vance Morrison [Tue, 22 May 2018 17:55:16 +0000 (10:55 -0700)]
Collapse ChunkEnumerable and ChunkEnumerator.

Commit migrated from https://github.com/dotnet/coreclr/commit/1028e3801f8eb72680d4d35b68dc734be5f84785

6 years agoFix compareexchangetstring thread safety (dotnet/coreclr#18075)
Steve MacLean [Tue, 22 May 2018 14:05:57 +0000 (10:05 -0400)]
Fix compareexchangetstring thread safety (dotnet/coreclr#18075)

Commit migrated from https://github.com/dotnet/coreclr/commit/0e70f69206b9797523855308e1b4c1edfb83ebdf

6 years agoadd stackLevelSetter to the VS header list. (dotnet/coreclr#18077)
Sergey Andreenko [Tue, 22 May 2018 04:09:28 +0000 (21:09 -0700)]
add stackLevelSetter to the VS header list. (dotnet/coreclr#18077)

Commit migrated from https://github.com/dotnet/coreclr/commit/9b29e823c0aa503fc077e6a6ca885c1160f35a2e

6 years agoadd repro for dotnet/coreclr#18056 (dotnet/coreclr#18057)
Sergey Andreenko [Tue, 22 May 2018 04:08:58 +0000 (21:08 -0700)]
add repro for dotnet/coreclr#18056  (dotnet/coreclr#18057)

* add repro

* add the exclusion

* fix comments

Commit migrated from https://github.com/dotnet/coreclr/commit/a525181a7c485b49fa7f18b469ecc1271e7f21a3

6 years agoCode cleanup and formatting for System.Memory files. (dotnet/coreclr#17451)
Ahson Khan [Tue, 22 May 2018 01:03:55 +0000 (18:03 -0700)]
Code cleanup and formatting for System.Memory files. (dotnet/coreclr#17451)

* Fix IDE0034 C# expression can be simplified (use of default)

* Remove unnecessary using statements

* IDE0012 C# Name can be simplified. String -> string

* IDE0041  C# Null check can be simplified

* Fix code formatting (limited to Span/System.Memory files).

* Address PR feedback - IDE0012 Name can be simplified (String -> string)

* Add back the necessary using statements and fix typo

* Fix comment typo and add necessary using statements

Commit migrated from https://github.com/dotnet/coreclr/commit/f31097f14560b193e76a7b2e1e61af9870b5356b

6 years agosmall fixes to build CoreCLR on FreeBSD again (dotnet/coreclr#18072)
Tomas Weinfurt [Tue, 22 May 2018 00:38:50 +0000 (17:38 -0700)]
small fixes to build CoreCLR on FreeBSD again (dotnet/coreclr#18072)

* small fixes to build CoreCLR on FreeBSD again

* feedback from review

* update genLttngProvider.py as jan suggested

* remove extra comment

* add missing extra space

Commit migrated from https://github.com/dotnet/coreclr/commit/49f6249abc44269b437064e850ad22eb9f74a446

6 years agoUpdate BuildTools, PgoData to preview1-02821-03, master-20180521-0051, respectively...
dotnet-maestro-bot [Mon, 21 May 2018 23:31:29 +0000 (16:31 -0700)]
Update BuildTools, PgoData to preview1-02821-03, master-20180521-0051, respectively (dotnet/coreclr#18066)

Commit migrated from https://github.com/dotnet/coreclr/commit/3910feed29faffb67a0cacf9470461219539e632

6 years agoOnly include DotNETRuntimeEventSource.cs if it exists. (dotnet/coreclr#18074)
Brian Robbins [Mon, 21 May 2018 21:51:43 +0000 (14:51 -0700)]
Only include DotNETRuntimeEventSource.cs if it exists. (dotnet/coreclr#18074)

Commit migrated from https://github.com/dotnet/coreclr/commit/821317f109635cc591c976e6921429fc7f673b68

6 years agoMerge pull request dotnet/coreclr#18032 from sdmaclea/PR-ARM64-LSE-ATOMICS
Bruce Forstall [Mon, 21 May 2018 21:37:54 +0000 (14:37 -0700)]
Merge pull request dotnet/coreclr#18032 from sdmaclea/PR-ARM64-LSE-ATOMICS

[Arm64] Add basic ARMv8.1 Atomics

Commit migrated from https://github.com/dotnet/coreclr/commit/d73a35065ec05a8179c8b812986bd9708001782c

6 years agoReduce the number of days to keep artifacts for perf (dotnet/coreclr#18073)
Michelle McDaniel [Mon, 21 May 2018 20:17:18 +0000 (13:17 -0700)]
Reduce the number of days to keep artifacts for perf (dotnet/coreclr#18073)

We are still seeing issues with running out of space on the archive
machines due to the size of the perf archives. This change reduces the
number of days we store the archives to 14 and the number of archives to
keep to 100.

Commit migrated from https://github.com/dotnet/coreclr/commit/c07b73a30558a47768329dfbc479b9c8bdb3c08a

6 years ago Implement ICorDebugILFrame3::GetReturnValueForILOffset on arm32 (dotnet/coreclr...
Chris Sienkiewicz [Mon, 21 May 2018 19:24:06 +0000 (12:24 -0700)]
 Implement ICorDebugILFrame3::GetReturnValueForILOffset on arm32 (dotnet/coreclr#18050)

*Implements CorDebugILFrame3::GetReturnValueForILOffset for arm32 on both windows and linux
*Fixes CordbNativeCode::GetCallInstructionLength to ensure it accounts for both 32/16 bit instructions
*Adds some asm to do float conversion
*Adds some logic to the cmake files to ensure the respective asm files get assembled correctly for both platforms

Commit migrated from https://github.com/dotnet/coreclr/commit/78d858b048b460bd399d537487949f74c708e159

6 years agoMerge pull request dotnet/coreclr#18058 from dotnetrt/gh18041
Carol Eidt [Mon, 21 May 2018 18:37:57 +0000 (11:37 -0700)]
Merge pull request dotnet/coreclr#18058 from dotnetrt/gh18041

Fix codegen for HW intrinsic Sse2.ConvertToInt32WithTruncation

Commit migrated from https://github.com/dotnet/coreclr/commit/402eab2b5d7acd0f6d6ece9b6e2c1c6f910c4eab

6 years agoUpdate Tizen CI docker image (dotnet/coreclr#17814)
Gleb Balykov [Mon, 21 May 2018 15:33:40 +0000 (18:33 +0300)]
Update Tizen CI docker image (dotnet/coreclr#17814)

* Update Tizen CI docker image

* Revert "Remove Tizen armel automatic PR triggered jobs"

This reverts commit dotnet/coreclr@462e2b59c67b0b6d25985a7284616539f348cbfc.

* Update Tizen CI docker image in netci

* Update links required for generation of Tizen rootfs

* Remove -rebuild from arm32 CI docker build

Commit migrated from https://github.com/dotnet/coreclr/commit/338474d63adf4a896e39b96fb0a4a2c7dd7a7985

6 years agoFix ConvertToInt32WithTruncation tests
Jacek Blaszczynski [Fri, 18 May 2018 23:15:50 +0000 (01:15 +0200)]
Fix ConvertToInt32WithTruncation tests

Commit migrated from https://github.com/dotnet/coreclr/commit/54eae6ff423017b613105f1c7f1878e780100a22

6 years agoUpdate PgoData to master-20180520-0038 (dotnet/coreclr#18065)
dotnet-maestro-bot [Sun, 20 May 2018 19:44:47 +0000 (12:44 -0700)]
Update PgoData to master-20180520-0038 (dotnet/coreclr#18065)

Commit migrated from https://github.com/dotnet/coreclr/commit/34c7dcfd2a8ae616d19bb7657463b990f5a7ff1f

6 years agoUpdate PgoData to master-20180519-0051 (dotnet/coreclr#18062)
dotnet-maestro-bot [Sat, 19 May 2018 19:01:44 +0000 (12:01 -0700)]
Update PgoData to master-20180519-0051 (dotnet/coreclr#18062)

Commit migrated from https://github.com/dotnet/coreclr/commit/cce4ad55e22e49edf417a6a967d58a4a345335a0

6 years agoFix CoreRT build break
Jan Kotas [Tue, 8 May 2018 17:23:11 +0000 (10:23 -0700)]
Fix CoreRT build break

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/68275d2e24118165bffb5d2e4850fc86cb8f4030

6 years agoRemove bogus NoInlining uses (dotnet/coreclr#18061)
mikedn [Sat, 19 May 2018 15:05:17 +0000 (18:05 +0300)]
Remove bogus NoInlining uses (dotnet/coreclr#18061)

The JIT knows not to inline throw helper methods. Manually blocking inlining prevents the JIT from detecting that these methods do not return and that may negatively impact the quality of the caller method code.

Commit migrated from https://github.com/dotnet/coreclr/commit/4f100f944cd108918a8920a8a22e12b6711fdc84

6 years agoMerge pull request dotnet/coreclr#15348 from mikedn/ssa-indir
Carol Eidt [Sat, 19 May 2018 13:45:49 +0000 (06:45 -0700)]
Merge pull request dotnet/coreclr#15348 from mikedn/ssa-indir

Remove useless IndirectAssignmentAnnotation

Commit migrated from https://github.com/dotnet/coreclr/commit/9352f69ffbf25762d0c631b7e84389f0d111bcd4

6 years agoAvoid freezing ConcurrentQueue segments in Count (dotnet/coreclr#18035)
Stephen Toub [Sat, 19 May 2018 02:07:02 +0000 (22:07 -0400)]
Avoid freezing ConcurrentQueue segments in Count (dotnet/coreclr#18035)

* Avoid freezing ConcurrentQueue segments in Count

In .NET Core 2.0, we changed the implementation of ConcurrentQueue to allow segment reuse, making enqueues ammoritzed allocation-free, whereas previously every enqueue had some allocation cost (even if it was batched as part of allocating a segment).  However, some operations mark segments as being frozen, which then prevents subsequent enqueues into those segments; this is necessary for enumeration, but Count also caused this.  Ideally Count isn't used on hot paths, but if it is, this can end up in degenerate situations where, for example, if Count is called after every enqueue, we'll end up creating a new segment for every enqueued item, which is incredibly inefficient both for the enqueues and for Count, which is O(N) in the number of segments.

It turns out, though, that we were overly cautious in implementing Count, and we don't actually need it to freeze the segments.  Instead, when there are more than two segments (the case where we previously froze), we can take the cross-segment lock, which is the same lock that's held any time we update the head and tail segment pointers.  Once that lock is held, we know that the internal segments won't change, because code can only enqueue/dequeue from the head and tail segments, so any segment that's not head and tail while the lock is held is effectively immutable.  That means that we can simply walk those segments and add up their counts, safe in knowing they won't change while we're enumerating.

* Remove stale comment

Commit migrated from https://github.com/dotnet/coreclr/commit/6e8232059e563d4e3d877f7020db17ee14e285f0

6 years agoFix codegen for HW intrinsic Sse2.ConvertToInt32WithTruncation
Jacek Blaszczynski [Fri, 18 May 2018 23:11:49 +0000 (01:11 +0200)]
Fix codegen for HW intrinsic Sse2.ConvertToInt32WithTruncation

Fixes dotnet/coreclr#18041

Commit migrated from https://github.com/dotnet/coreclr/commit/c0cddf9d826184a20506a94a9bd448fae85104b2

6 years agoRemove useless IndirectAssignmentAnnotation
Mike Danes [Thu, 30 Nov 2017 21:47:03 +0000 (23:47 +0200)]
Remove useless IndirectAssignmentAnnotation

This annotation is supposed to be used by SSA and VN but that does not actually happen because fgMorphCopyBlock also marks the destination local as address exposed.

Also, even if the local wasn't address exposed there are other parts of the JIT that should probably use this annotation but currently they do not:
* Copy propagation attempts to mirror SSA renaming but it ignores IndirectAssignmentAnnotation.
* Liveness also doesn't pay attention to IndirectAssignmentAnnotation. A comment in fgMorphCopyBlock even gives liveness as the reason why the destination local is address exposed.

Commit migrated from https://github.com/dotnet/coreclr/commit/026abe216b39550ab6acb80ecb8927904e194886

6 years agoAdd another readonly attribute
Vance Morrison [Fri, 18 May 2018 20:40:11 +0000 (13:40 -0700)]
Add another readonly attribute

Commit migrated from https://github.com/dotnet/coreclr/commit/6198c7443b08a719edb17e2467625b35301b6b7c

6 years agoadd readonly attributes
Vance Morrison [Fri, 18 May 2018 20:38:06 +0000 (13:38 -0700)]
add readonly attributes

Commit migrated from https://github.com/dotnet/coreclr/commit/6eeb7b6b315d0561dd46707f42c95caa8e34295f

6 years agoJIT: treat SIMD types as structs in box optimizations (dotnet/coreclr#18046)
Andy Ayers [Fri, 18 May 2018 20:00:29 +0000 (13:00 -0700)]
JIT: treat SIMD types as structs in box optimizations (dotnet/coreclr#18046)

Otherwise we may leave unconsumed GT_OBJs around, which is problematic for the
jit later on.

Fixes dotnet/coreclr#18043.

Commit migrated from https://github.com/dotnet/coreclr/commit/3c28c423053f30adedc034c5e2c912bd2adaad10

6 years agoJIT: clear up some no-op casts in the importer (dotnet/coreclr#17996)
Andy Ayers [Fri, 18 May 2018 19:58:59 +0000 (12:58 -0700)]
JIT: clear up some no-op casts in the importer (dotnet/coreclr#17996)

If we see a no-op cast (say converting long to ulong) where the operand
to be cast already has the right stack type, don't generate a GT_CAST,
just use the operand.

This comes up in some cases with unsafe operations where the pointer type
is cast. Interposing a cast between an GT_IND and GT_ADDR results in poor
codegen as the jit thinks the addressed local is address taken.

Commit migrated from https://github.com/dotnet/coreclr/commit/5bd38293ed527413950ef03bded1a12ca20af5b1

6 years agoMerge pull request dotnet/coreclr#17991 from sdmaclea/PR-ARM64-STACK-PACKING
Carol Eidt [Fri, 18 May 2018 18:11:50 +0000 (11:11 -0700)]
Merge pull request dotnet/coreclr#17991 from sdmaclea/PR-ARM64-STACK-PACKING

[Arm64] Fix stack struct arg packing

Commit migrated from https://github.com/dotnet/coreclr/commit/55461ca277e43e04a9197d981d10852aa0719316

6 years agoUpdate BuildTools, PgoData to preview1-02817-01, master-20180518-0039, respectively...
dotnet-maestro-bot [Fri, 18 May 2018 15:56:48 +0000 (08:56 -0700)]
Update BuildTools, PgoData to preview1-02817-01, master-20180518-0039, respectively (dotnet/coreclr#18038)

Commit migrated from https://github.com/dotnet/coreclr/commit/f02f59f658a52bd1aaf6082918cfd96bd601daeb

6 years agoImprove comments, review feedback.
Vance Morrison [Fri, 18 May 2018 15:18:48 +0000 (08:18 -0700)]
Improve comments, review feedback.

Commit migrated from https://github.com/dotnet/coreclr/commit/014c623435e97e80adcd8ae7f6b8021e6087ddad

6 years agoUpdate osx-instructions.md (dotnet/coreclr#18000)
Artem Koval [Fri, 18 May 2018 05:28:37 +0000 (08:28 +0300)]
Update osx-instructions.md (dotnet/coreclr#18000)

When following this instruction CoreFX build won't happen until we change the folder to the CoreFX's one. In essence ./build.sh will trigger CoreCLR build once again. It may be a minor thing for an experienced user but can become a significant blocker for someone who's not that experienced with the command line and needs to compile CoreCLR. And it will diminish the awesomeness of .NET Core which we can't allow!

The proposed change is just a directory change when inside the CoreCLR folder.

Commit migrated from https://github.com/dotnet/coreclr/commit/b12c344020ba4cc5bccff377c8922f5434aa293e

6 years agoRevert PR 17881 to unblock integration into CoreFx (dotnet/coreclr#18036)
Atsushi Kanamori [Fri, 18 May 2018 03:09:39 +0000 (20:09 -0700)]
Revert PR 17881 to unblock integration into CoreFx (dotnet/coreclr#18036)

Commit migrated from https://github.com/dotnet/coreclr/commit/2fb587937b1926d59f2fd8396196571e356fc596

6 years agoR2RDump - Runtime function RVAs and method signatures (dotnet/coreclr#17994)
acmyu [Fri, 18 May 2018 01:58:24 +0000 (18:58 -0700)]
R2RDump - Runtime function RVAs and method signatures (dotnet/coreclr#17994)

* R2RDump - Runtime function RVAs and sizes

* Change hard error to warning, GetInt64,32,16 helper functions

* Method signatures from metadata, GetUnsigned functions, arbitrary sections for GetOffset

* Use methodDefEntryPoints to match method metadata to native code, make runtime function endAddress conditional on machine type

* Get object arg and return types of method signature from TypeDef, use ReadUInt

* Iterate all rids, added NativeArray class

* Handle multiple runtime functions in a method, use ReadByte, make rid unsigned

* Use MethodDefinitionHandle(rid) instead of dictionary, make ReadByte signature similar to other Read methods

* Changes to getting runtime functions, increment the start index in ReadByte, added comments

* Use List for R2RMethods instead of array, fixed nits

Commit migrated from https://github.com/dotnet/coreclr/commit/656432d8d73f0c13469abefb0d6abe556fc78e76

6 years ago[Arm64] Add basic ARMv8.1 Atomics
Steve MacLean [Wed, 16 May 2018 23:45:57 +0000 (19:45 -0400)]
[Arm64] Add basic ARMv8.1 Atomics

Add cas*, ldadd*, stadd*, and swp*
Add atomic emitters
Add atomic emitter tests

Commit migrated from https://github.com/dotnet/coreclr/commit/be5d8384812d906e851d6ab51bfda2feb7147ec0

6 years agoMerge pull request dotnet/coreclr#17764 from sdmaclea/PR-ARM64-CI-Match-Arm32
Bruce Forstall [Thu, 17 May 2018 21:45:15 +0000 (14:45 -0700)]
Merge pull request dotnet/coreclr#17764 from sdmaclea/PR-ARM64-CI-Match-Arm32

[Arm64/Ubuntu] CI match arm32 except triggers

Commit migrated from https://github.com/dotnet/coreclr/commit/cd6ae96f0b8c3d5268079f138c5e7134deb057f2

6 years ago[Arm64/Ubuntu] match arm32 except triggers
Steve MacLean [Tue, 24 Apr 2018 21:47:35 +0000 (17:47 -0400)]
[Arm64/Ubuntu] match arm32 except triggers

Commit migrated from https://github.com/dotnet/coreclr/commit/55635f9d042b5dfd3c338eca051117b1d0e5bbbf

6 years agoBetter comments
Vance Morrison [Thu, 17 May 2018 17:46:57 +0000 (10:46 -0700)]
Better comments

Commit migrated from https://github.com/dotnet/coreclr/commit/009a54961064a7df648a80071f3f267e626f16fc

6 years agoFix typo
Vance Morrison [Thu, 17 May 2018 17:41:29 +0000 (10:41 -0700)]
Fix typo

Commit migrated from https://github.com/dotnet/coreclr/commit/31590489ad0cca06094a82268ed542619962db4b

6 years agoUpdate PgoData to master-20180517-0042 (dotnet/coreclr#18029)
dotnet-maestro-bot [Thu, 17 May 2018 15:07:30 +0000 (10:07 -0500)]
Update PgoData to master-20180517-0042 (dotnet/coreclr#18029)

Commit migrated from https://github.com/dotnet/coreclr/commit/3c01252879f2d2223f63d5b222b6584c28fc07f4

6 years agoUpdate CoreClr, CoreFx, PgoData to preview1-26517-01, preview1-26517-01, master-20180...
dotnet-maestro-bot [Thu, 17 May 2018 03:23:24 +0000 (22:23 -0500)]
Update CoreClr, CoreFx, PgoData to preview1-26517-01, preview1-26517-01, master-20180516-1546, respectively (dotnet/coreclr#18027)

Commit migrated from https://github.com/dotnet/coreclr/commit/404eba4d9d18310f5764c6b932265c29a235ebed

6 years agoReplace sizeof(TADDR) with TARGET_POINTER_SIZE in Zap (dotnet/coreclr#18028)
Egor Chesakov [Thu, 17 May 2018 02:49:18 +0000 (19:49 -0700)]
Replace sizeof(TADDR) with TARGET_POINTER_SIZE in Zap (dotnet/coreclr#18028)

Commit migrated from https://github.com/dotnet/coreclr/commit/7c128ae89c062236ec5437bc3ed11aefcc52c360

6 years agoGenerate EventSources Representing DotNETRuntime Eventing Providers (dotnet/coreclr...
Brian Robbins [Thu, 17 May 2018 01:59:51 +0000 (18:59 -0700)]
Generate EventSources Representing DotNETRuntime Eventing Providers (dotnet/coreclr#18007)

Commit migrated from https://github.com/dotnet/coreclr/commit/0fbd0f535e566bcde591701adc2de51ee0f020af

6 years agoAdd Asserts. Fix bug found in testing.
Vance Morrison [Thu, 17 May 2018 01:55:41 +0000 (18:55 -0700)]
Add Asserts.  Fix bug found in testing.

Commit migrated from https://github.com/dotnet/coreclr/commit/e646dd23b33935cd206539111828714babbeb1d8

6 years agoAdd some more documentation for ValueTask (dotnet/corefxdotnet/coreclr#29726)
Stephen Toub [Wed, 16 May 2018 20:21:02 +0000 (16:21 -0400)]
Add some more documentation for ValueTask (dotnet/corefxdotnet/coreclr#29726)

* Add some more documentation for ValueTask

* Address PR feedback

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/a8d40ac8362bacd98f7fa422190fe66916e040e8

6 years agoSystem.Reflection: Replicate custom modifiers of method parameters in MemberRef signa...
stakx [Wed, 16 May 2018 22:48:40 +0000 (00:48 +0200)]
System.Reflection: Replicate custom modifiers of method parameters in MemberRef signatures (dotnet/coreclr#17881)

* Include cmods in `ModuleBuilder.GetMemberRefToken`

This method reproduces a method's signature for use in a MethodRef
metadata entry, but currently ignores custom modifiers placed in the
method's parameters. Add additional parameters for those.

* Add parameter cmod params for other code paths

This lets the change from the previous commit "bubble up" towards the
public API by adding support for parameter cmods in more places.

* Reduce code duplication

In several places, `ParameterInfo[]` is converted to three matching
arrays for parameter types and their modreqs and modpts, because that
is what `SignatureHelper` requires. Extract this duplicated logic
into a single method. Also, optimize it to reduce array allocations.

Commit migrated from https://github.com/dotnet/coreclr/commit/466599a90a9f404d7e5dd03987359c5bdc1d1826

6 years agoUpdate CoreClr to preview1-26516-05 (dotnet/coreclr#18018)
dotnet-maestro-bot [Wed, 16 May 2018 21:30:52 +0000 (16:30 -0500)]
Update CoreClr to preview1-26516-05 (dotnet/coreclr#18018)

Commit migrated from https://github.com/dotnet/coreclr/commit/890dfcf2769fb280f4cce11080225053f00a9162

6 years agoMoving ConcurrentQueue to shared (dotnet/coreclr#18024)
Maryam Ariyan [Wed, 16 May 2018 21:02:10 +0000 (14:02 -0700)]
Moving ConcurrentQueue to shared (dotnet/coreclr#18024)

Making IProducerConsumerCollectionDebugView apis public

Fixes: dotnet/coreclr#17751

Commit migrated from https://github.com/dotnet/coreclr/commit/f17770dd0318aa80fcd2a70288f097f2e05ba3bd

6 years agoUpdate CoreClr to preview1-26516-01 (dotnet/coreclr#18015)
dotnet-maestro-bot [Wed, 16 May 2018 03:22:24 +0000 (22:22 -0500)]
Update CoreClr to preview1-26516-01 (dotnet/coreclr#18015)

Commit migrated from https://github.com/dotnet/coreclr/commit/e353a220a673fa54e98f53c4dcc5793badd4d69e

6 years agoignore .tail opcode for arm64 (dotnet/coreclr#18002)
Sergey Andreenko [Wed, 16 May 2018 02:02:00 +0000 (19:02 -0700)]
ignore .tail opcode for arm64 (dotnet/coreclr#18002)

when we can't do fast tail call.

Commit migrated from https://github.com/dotnet/coreclr/commit/d5c558539c375d7403a11183f03b07133d724b4d

6 years agoRemove IsAscii fast paths from Equals and Compare OrdinalIgnoreCase (dotnet/coreclr...
Bruce Bowyer-Smyth [Wed, 16 May 2018 01:45:50 +0000 (11:45 +1000)]
Remove IsAscii fast paths from Equals and Compare OrdinalIgnoreCase (dotnet/coreclr#17985)

Commit migrated from https://github.com/dotnet/coreclr/commit/135960e9c37e67cd3359da484e9663c56b46c4b9

6 years agoMerge pull request dotnet/coreclr#18010 from CarolEidt/StructTests
Carol Eidt [Wed, 16 May 2018 01:20:00 +0000 (18:20 -0700)]
Merge pull request dotnet/coreclr#18010 from CarolEidt/StructTests

Add tests for struct-related issues

Commit migrated from https://github.com/dotnet/coreclr/commit/c2376b24024d2778e574b259cd675342fcb488f7

6 years agoTolerate spmi misses (dotnet/coreclr#17997)
Sergey Andreenko [Tue, 15 May 2018 23:29:26 +0000 (16:29 -0700)]
Tolerate spmi misses (dotnet/coreclr#17997)

* catch missed values

* add a new return value for misses

Commit migrated from https://github.com/dotnet/coreclr/commit/9c110c3b1200fdade1c85df5da58f0a952b0754e

6 years agoDo not allocate memory in compUpdateTreeLife. (dotnet/coreclr#17055)
Sergey Andreenko [Tue, 15 May 2018 22:57:08 +0000 (15:57 -0700)]
Do not allocate memory in compUpdateTreeLife. (dotnet/coreclr#17055)

* move compUpdateLifeVar and compUpdateTreeLife to separate files for legacy and non-legacy case

* create TreeLifeUpdater class

Commit migrated from https://github.com/dotnet/coreclr/commit/8a375fe25d8b5f1a2fadb8afbf3360a4da67f71b

6 years agoRemove faulty Debug.Assert (dotnet/coreclr#18009)
stakx [Tue, 15 May 2018 22:39:02 +0000 (00:39 +0200)]
Remove faulty Debug.Assert (dotnet/coreclr#18009)

The assertion being removed here fails when Reflection.Emit user code
defines a method signature where a custom modifiers are used in con-
junction with a generic type parameter. Yet there is no obvious reason
why that should be forbidden.

Commit migrated from https://github.com/dotnet/coreclr/commit/186966c0448ba7541fe65643553898bd2295f4fb

6 years agoChange Span to Memory
Vance Morrison [Tue, 15 May 2018 21:32:59 +0000 (14:32 -0700)]
Change Span to Memory

Commit migrated from https://github.com/dotnet/coreclr/commit/8ae354469039d44d6e7a3381dea8a559cdd3dba3

6 years agoAdding EnumerateChunks which allow efficient scanning of a StringBuilder
Vance Morrison [Wed, 11 Apr 2018 20:46:28 +0000 (13:46 -0700)]
Adding EnumerateChunks which allow efficient scanning of a StringBuilder

Commit migrated from https://github.com/dotnet/coreclr/commit/9b1f2b29a3357cf1f98348fa65c8a2af91c1a934

6 years agoAdd tests for struct-related issues
Carol Eidt [Tue, 15 May 2018 20:57:09 +0000 (13:57 -0700)]
Add tests for struct-related issues

Commit migrated from https://github.com/dotnet/coreclr/commit/a7f129cce3ee1ccbc119d771ae517f7e4f18b782

6 years agoUpdate first-class-structs.md
Carol Eidt [Tue, 15 May 2018 20:55:15 +0000 (13:55 -0700)]
Update first-class-structs.md

Commit migrated from https://github.com/dotnet/coreclr/commit/2fe718c8ba73f1f6661c40b73ebb718c09a68ff6

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview1-02815-01, preview1-26515-05, preview1...
dotnet-maestro-bot [Tue, 15 May 2018 20:53:23 +0000 (15:53 -0500)]
Update BuildTools, CoreClr, CoreFx to preview1-02815-01, preview1-26515-05, preview1-26515-04, respectively (dotnet/coreclr#17995)

Commit migrated from https://github.com/dotnet/coreclr/commit/bbe1e304484c96957add7fd3ca1486bfac52cf81

6 years agofix jit format after better-wildcards PR (dotnet/coreclr#18008)
Sergey Andreenko [Tue, 15 May 2018 19:48:47 +0000 (12:48 -0700)]
fix jit format after better-wildcards PR (dotnet/coreclr#18008)

Commit migrated from https://github.com/dotnet/coreclr/commit/436b0ae73d1a40e2a4826502e5223af4fbfdb5f6

6 years agoformat spmi (dotnet/coreclr#18003)
Sergey Andreenko [Tue, 15 May 2018 18:17:48 +0000 (11:17 -0700)]
format spmi (dotnet/coreclr#18003)

Commit migrated from https://github.com/dotnet/coreclr/commit/dbb499c9897090373378085fc000491033294b02

6 years ago[Arm64] Fix stack struct arg packing
Steve MacLean [Mon, 14 May 2018 22:47:23 +0000 (18:47 -0400)]
[Arm64] Fix stack struct arg packing

Commit migrated from https://github.com/dotnet/coreclr/commit/e8098e514ce43a2c35edec4f5f231c8cc4854074

6 years agoUpdate first-class-structs.md
Carol Eidt [Tue, 15 May 2018 01:06:59 +0000 (18:06 -0700)]
Update first-class-structs.md

fix duplication

Commit migrated from https://github.com/dotnet/coreclr/commit/ba110d51de1994dd5f1a38e224b442dd1609d24f

6 years agoUpdate first-class-structs.md
Carol Eidt [Tue, 15 May 2018 01:04:46 +0000 (18:04 -0700)]
Update first-class-structs.md

Add some struct-related open issues to the document.

Commit migrated from https://github.com/dotnet/coreclr/commit/36a8c9af1378e5e38a8c1cdcf9c8ac47aa7b7acb

6 years agoMerge pull request dotnet/coreclr#17970 from briansull/better-wildcards
Brian Sullivan [Tue, 15 May 2018 00:45:54 +0000 (17:45 -0700)]
Merge pull request dotnet/coreclr#17970 from briansull/better-wildcards

Better wildcards for COMPLUS_JIT variables

Commit migrated from https://github.com/dotnet/coreclr/commit/99839e3251848d11d457cb540dbc5b9bd65de4bd

6 years agoFix multicast delegate step from delegate (dotnet/coreclr#17990)
David Wrighton [Mon, 14 May 2018 23:20:12 +0000 (16:20 -0700)]
Fix multicast delegate step from delegate (dotnet/coreclr#17990)

- Replace incorrect FEATURE_STUBS_AS_IL define check with FEATURE_MULTICASTSTUB_AS_IL
  - Allows step from one delegate to the next and step out from multicast delegate to function correctly.
- Add null check as the active frame's methoddesc isn't always non-null
  - In scenarios such as FuncEval, we also run through this code, and the md may be null.
- Fix unwind from StubHelpers::MulticastDebuggerTraceHelper function on amd64

Commit migrated from https://github.com/dotnet/coreclr/commit/ed9c82a956116f78fdaef781d99c3a22b01bfd27

6 years agoRemove usages of AnsiString and replace them with UnicodeString. (dotnet/coreclr...
Brian Robbins [Mon, 14 May 2018 20:44:28 +0000 (13:44 -0700)]
Remove usages of AnsiString and replace them with UnicodeString. (dotnet/coreclr#17989)

Commit migrated from https://github.com/dotnet/coreclr/commit/95a9055dbe5f6233f75ee2d7b6194e18cc4977fd

6 years agojit-format --fix --untidy
Brian Sullivan [Mon, 14 May 2018 20:44:10 +0000 (13:44 -0700)]
jit-format --fix --untidy

Commit migrated from https://github.com/dotnet/coreclr/commit/b152ce187578fffc5baed4f14705865714c785b6

6 years agoAdd tests for arm64 il issues. (dotnet/coreclr#17759)
Sergey Andreenko [Mon, 14 May 2018 20:29:42 +0000 (13:29 -0700)]
Add tests for arm64 il issues. (dotnet/coreclr#17759)

* Add test for "Shouldn_t_see_an_integer_typed_GT_MOD_node_in_ARM64"

* Add test for "We_should_never_encounter_a_reference_to_a_lclVar_that_has_a_zero_refCnt"

* Add test for 'NYI__Initialize_floating_point_register_to_zero'

* add tests to the arm lists

* exclude tests on:
1. windows arm64 with tests\arm64\tests.lst
2. windows x64 altjit arm with tests\issues.target
3. ubuntu arm64 with tests/testsFailing.arm64.txt

* change issues.targets

Commit migrated from https://github.com/dotnet/coreclr/commit/ee555267dbe649bf89f4610897716ab109fe37ce

6 years agoFix Typo
Brian Sullivan [Mon, 14 May 2018 19:39:37 +0000 (12:39 -0700)]
Fix Typo

Commit migrated from https://github.com/dotnet/coreclr/commit/23549a05eda644374eddde56facd7eab5f5ca677

6 years agoCode review feedback
Brian Sullivan [Mon, 14 May 2018 19:28:31 +0000 (12:28 -0700)]
Code review feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/ebe45cc70ccbd83a798e8b27d4cd5db3c02e7e25

6 years agoEnable System.Transactions.Local.Tests on Linux/arm (dotnet/coreclr#17973)
Egor Chesakov [Mon, 14 May 2018 19:21:30 +0000 (12:21 -0700)]
Enable System.Transactions.Local.Tests on Linux/arm (dotnet/coreclr#17973)

Commit migrated from https://github.com/dotnet/coreclr/commit/de091e450419739034fb23b47929b2dfcf92d4c9

6 years agoMerge branch 'master' into better-wildcards
Brian Sullivan [Mon, 14 May 2018 18:58:52 +0000 (11:58 -0700)]
Merge branch 'master' into better-wildcards

Commit migrated from https://github.com/dotnet/coreclr/commit/0cdd62e3619b4f0634839af4ee6ab0116294b871

6 years agoMerge pull request dotnet/coreclr#17988 from dotnet-maestro-bot/master-UpdateDependencies
Wes Haggard [Mon, 14 May 2018 18:00:35 +0000 (11:00 -0700)]
Merge pull request dotnet/coreclr#17988 from dotnet-maestro-bot/master-UpdateDependencies

Update CoreClr to preview1-26514-05 (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/cc0e7b49019d5d08aebd8cfa714d9864f2d65a8e

6 years agoMoving ConcurrentQueue to shared folder (dotnet/coreclr#17956)
Maryam Ariyan [Mon, 14 May 2018 17:50:45 +0000 (10:50 -0700)]
Moving ConcurrentQueue to shared folder (dotnet/coreclr#17956)

* Moving ConcurrentQueue to shared folder

Fixes: dotnet/coreclr#17751

Commit migrated from https://github.com/dotnet/coreclr/commit/612a944e186660e25791e898920aaadbf11d6dc1

6 years agoR2RDump - Print ReadyToRun image headers (dotnet/coreclr#17942)
acmyu [Mon, 14 May 2018 17:23:07 +0000 (10:23 -0700)]
R2RDump - Print ReadyToRun image headers (dotnet/coreclr#17942)

* R2RDump - Outputing ReadyToRun header from PE image

* R2RDump - Comments, follow coding guidelines, use enum for section types and flags

* R2RDump - Use utf8 encoding, rva from ManagedNativeHeader, return exit code

Commit migrated from https://github.com/dotnet/coreclr/commit/cf7489c07eafed047b776a8219d701215fbc6afe

6 years agoPEImageLayout: flush instruction cache only for pages with relocs. (dotnet/coreclr...
Konstantin Baladurin [Mon, 14 May 2018 16:55:18 +0000 (19:55 +0300)]
PEImageLayout: flush instruction cache only for pages with relocs. (dotnet/coreclr#17773)

We need to flush instruction cache only for pages that have relocations
instead of full sections because otherwise application's shared clean
memory is increased in some cases on Linux.

Commit migrated from https://github.com/dotnet/coreclr/commit/539b1745463d697b883ac2c8f556afd82c25b5dc

6 years agoUpdate CoreClr to preview1-26514-05
dotnet-maestro-bot [Mon, 14 May 2018 16:13:38 +0000 (09:13 -0700)]
Update CoreClr to preview1-26514-05

Commit migrated from https://github.com/dotnet/coreclr/commit/d128be096562c13ebfbfa8a97c1e6ca22ad7323c