profile/ivi/webkit-efl.git
12 years agoHTMLEmbedObject should match HTMLObjectElement by stopping any load when it is remove...
eric@webkit.org [Thu, 26 Jan 2012 00:00:03 +0000 (00:00 +0000)]
HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
https://bugs.webkit.org/show_bug.cgi?id=74360

Reviewed by Adam Barth.

Source/WebCore:

Neither of these !renderer() checks is strictly necessary since requestObject()
makes the same check.  However requestObject() asserts before it makes that
check, so it makes sense to add the check to HTMLEmebedObject instead of
removing the check from HTMLObjectElement.
I also moved the protect RefPtr to before the beforeload dispatch since
beforeload can remove the whole DOM element (as this test does) and
thus I beleive the renderer() check could be checking free'd memory.

Updated fast/dom/beforeload/remove-flash-in-beforeload-listener.html to test
<embed> as well as <object>.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):

LayoutTests:

Test <embed> as well as <object> in this test.

* fast/dom/beforeload/remove-flash-in-beforeload-listener.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove focus/blur handling code of HTMLInputElement to InputType
tkent@chromium.org [Wed, 25 Jan 2012 23:56:30 +0000 (23:56 +0000)]
Move focus/blur handling code of HTMLInputElement to InputType
https://bugs.webkit.org/show_bug.cgi?id=76984

Reviewed by Dimitri Glazkov.

No new tests. Just a refactoring.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::handleFocusEvent):
Move the code to PasswordInputType::handleFocusEvent().
(WebCore::HTMLInputElement::handleBlurEvent):
Move the code to TextFieldInputType::handleBlurEvent() and
PasswordInputType::handleBlurEvent().
* html/InputType.cpp:
(WebCore::InputType::handleFocusEvent):
* html/InputType.h:
(InputType): Add handleFocusEvent().
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::handleFocusEvent):
Move the code for type=password from HTMLInputElement::handleFocusEvent().
(WebCore::PasswordInputType::handleBlurEvent):
Move the code for tyep=password from HTMLInputElement::handleBlurEvent().
* html/PasswordInputType.h:
(PasswordInputType): Add handleFocusEvent() and handleBlurEvent().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBlurEvent):
Move the code for text field types from HTMLInputElement::handleBlurEvent().
* html/TextFieldInputType.h:
(TextFieldInputType): Add handleBlurEvent().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-webkit-tests --lint-test-files should lint all the ports by default
dpranke@chromium.org [Wed, 25 Jan 2012 23:52:52 +0000 (23:52 +0000)]
run-webkit-tests --lint-test-files should lint all the ports by default
https://bugs.webkit.org/show_bug.cgi?id=76749

Reviewed by Ojan Vafai.

Currently run-webkit-tests --lint-test-files will only lint the
test_expectations for the single port determined by the command
line options. This is not obvious and can produce unintended results
if you want to lint the chromium port (probably the normal case
for using --lint-test-files) but don't specify a port name or
--chromium.

I think we should probably lint *all* of the ports if no port
name is supplied. This change implements that, and also moves
the linting logic out of the Manager class, since this really
has nothing to do with Managers. It has little to do with
run-webkit-tests, but splitting it into a different script would
introduce compatibility issues. It might make sense to do that
anyway, in a separate patch and combining that with cleaning up
the style checker to share more code.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._strip_test_dir_prefix):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
(run):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations): added.
(LintTest.test_lint_test_files): added.
(LintTest.test_lint_test_files__errors): added.
(MainTest.test_lint_test_files): removed.
(MainTest.test_lint_test_files__errors): removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: clean up a bunch of test scaffolding
dpranke@chromium.org [Wed, 25 Jan 2012 23:46:02 +0000 (23:46 +0000)]
webkitpy: clean up a bunch of test scaffolding
https://bugs.webkit.org/show_bug.cgi?id=76973

Reviewed by Eric Seidel.

There were several helper modules in the webkitpy.test package
that appear to only be used by executive_unittest.py. I am
rolling them all into that file to make that clearer.

* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):
(command_line):
(main):
* Scripts/webkitpy/common/system/fileutils.py: Removed.
* Scripts/webkitpy/test/cat.py: Removed.
* Scripts/webkitpy/test/cat_unittest.py: Removed.
* Scripts/webkitpy/test/echo.py: Removed.
* Scripts/webkitpy/test/echo_unittest.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2][Qt] REGRESSION: Pages with transform animations sometimes omit some of the...
noam.rosenthal@nokia.com [Wed, 25 Jan 2012 23:40:41 +0000 (23:40 +0000)]
[WK2][Qt] REGRESSION: Pages with transform animations sometimes omit some of the layers since r105413
https://bugs.webkit.org/show_bug.cgi?id=76886

Reviewed by Kenneth Rohde Christiansen.

We now render the whole layer if it or one if its ancestors has an active transform
animations. It's possible to optimize further in the future, but not currently necessary.
Also, we make sure that when a WebGraphicsLayer's property that affects transformation is
changed, all its descandants layers are marked as modified so that we re-adjust their
visible rect in the next pass.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::notifyChangeRecursively):
(WebCore):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::selfOrAncestorHasActiveTransformAnimations):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNode.cpp shouldn't duplicate QualifiedName parsing logic
abarth@webkit.org [Wed, 25 Jan 2012 23:31:26 +0000 (23:31 +0000)]
Node.cpp shouldn't duplicate QualifiedName parsing logic
https://bugs.webkit.org/show_bug.cgi?id=76672

Reviewed by Eric Seidel.

I added this code out of ignorance that this logic already existed in
Document.cpp.  In a future patch, we should consider moving it to
QualifiedName.cpp.

* dom/Node.cpp:
(WebCore):
(WebCore::Node::checkSetPrefix):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShare more code between updateWidget implementations in HTMLEmbedElement and HTMLObje...
eric@webkit.org [Wed, 25 Jan 2012 23:29:53 +0000 (23:29 +0000)]
Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement
https://bugs.webkit.org/show_bug.cgi?id=74340

Reviewed by Adam Barth.

I'm preparing to unify these two methods, and starting by sharing more code between them.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent):
* html/HTMLPlugInElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove Python 2.5 support from WebKit
eric@webkit.org [Wed, 25 Jan 2012 23:11:46 +0000 (23:11 +0000)]
Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Adam Barth.

Just removing support from this one core file.
I'll commit the rest of the (large) change once we've
gone 24 hours and seen that no bots have exploded.
We can roll out this one change if we break bots
and then roll in the rest once those bots are fixed.

* Scripts/webkitpy/common/system/executive.py:
(Executive.cpu_count):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd full support for filesystem URLs.
ericu@chromium.org [Wed, 25 Jan 2012 22:43:19 +0000 (22:43 +0000)]
Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it.  This patch
merely enables that, without changing behavior.

Source/WebCore:

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL): Add missing escaping of URL path.

* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL): Use innerURL member, if it's populated.

* platform/KURL.h:
(WebCore::KURL::innerURL): Add innerURL member.

* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F ['/'] in paths; it's much more readable, and it's safe.

* platform/KURLGooglePrivate.h:
(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

Source/WebKit/chromium:

* tests/KURLTest.cpp:
TEST(KURLTest, Encode): Update expectation that '/' sails through unescaped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Layout Test fast/canvas/webgl/invalid-passed-params.html is failing
noel.gordon@gmail.com [Wed, 25 Jan 2012 22:40:03 +0000 (22:40 +0000)]
[Chromium] Layout Test fast/canvas/webgl/invalid-passed-params.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75784

Reviewed by Kenneth Russell.

Passing on ToT chromium.org, webkit.org (GPU and non-GPU), rebaseline this test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Refactor Clipboard invalidate for DataTransferItem/DataTransferItemList...
dcheng@chromium.org [Wed, 25 Jan 2012 22:33:33 +0000 (22:33 +0000)]
[chromium] Refactor Clipboard invalidate for DataTransferItem/DataTransferItemList into a wrapper
https://bugs.webkit.org/show_bug.cgi?id=76993

We want to unify the backing data store for ClipboardChromium and DataTransferItems. For
that, we want use a similar representation to DataTransferItem list inside
ChromiumDataObject.  However, since ChromiumDataObject should be valid in scopes where
Clipboard is not (e.g. default drag processing), we need to separate the clipboard
invalidation logic into a wrapper class.

Reviewed by Tony Chang.

Covered by existing tests.

* platform/chromium/ClipboardChromium.cpp:
():
(WebCore::ClipboardChromium::items):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohtml5-full-render.html fails due to a log
rniwa@webkit.org [Wed, 25 Jan 2012 22:25:10 +0000 (22:25 +0000)]
html5-full-render.html fails due to a log
https://bugs.webkit.org/show_bug.cgi?id=77046

Reviewed by Adam Barth.

Replace the call to log() in html5-full-render.html by a call to newly added logInfo(),
which doesn't print anything inside DRT.

* Parser/html5-full-render.html:
* resources/runner.js:
(logInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Texmap] Divide TextureMapperNode.cpp to 3 files.
noam.rosenthal@nokia.com [Wed, 25 Jan 2012 22:13:29 +0000 (22:13 +0000)]
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

 Reviewed by Kenneth Rohde Christiansen.

 Split the animation part of TextureMapperNode out to a separate file, called
 TextureMapperAnimation.
 Provide a clean interface for that class, that allows separating the internals of the scene
 painting from the internals of the animation interpolation.

 No new tests. Existing animation tests cover this.

 * GNUmakefile.list.am:

* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayout Test http/tests/workers/terminate-during-sync-operation.html times out frequen...
leviw@chromium.org [Wed, 25 Jan 2012 22:11:40 +0000 (22:11 +0000)]
Layout Test http/tests/workers/terminate-during-sync-operation.html times out frequently on Win DBG
https://bugs.webkit.org/show_bug.cgi?id=77047

Unreviewed. Marking http/tests/workers/terminate-during-sync-operation.html as flaky (timeout) on Chromium Win DBG

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Unreviewed expectation update after r105613.
knorton@google.com [Wed, 25 Jan 2012 22:00:53 +0000 (22:00 +0000)]
[chromium] Unreviewed expectation update after r105613.

* platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
commit-queue@webkit.org [Wed, 25 Jan 2012 21:46:47 +0000 (21:46 +0000)]
ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=76863

.:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* configure.ac:

Source/JavaScriptCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

No tests, it's a behid flag configuration change.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* Configurations/FeatureDefines.xcconfig:

Tools:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:

WebKitLibraries:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium]: rebaseline after r105878
leviw@chromium.org [Wed, 25 Jan 2012 21:09:10 +0000 (21:09 +0000)]
[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium image expectations update.

Not updating test_expectations because I am not sure that the rebaselining tool did
the right thing.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

* platform/chromium-linux-x86/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-linux/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-linux/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-linux/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-mac/svg/custom/zero-path-square-cap-rendering-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
* platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105906.
leviw@chromium.org [Wed, 25 Jan 2012 21:06:51 +0000 (21:06 +0000)]
Unreviewed, rolling out r105906.
http://trac.webkit.org/changeset/105906
https://bugs.webkit.org/show_bug.cgi?id=77038

Breaks compositing/visibility/layer-visible-content.html and
compositing/visibility/visibility-image-layers-dynamic.html
(Requested by leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

* compositing/visibility/layer-visible-content-expected.txt:
* compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPage Up and Page Down mappings are backwards on BlackBerry port.
commit-queue@webkit.org [Wed, 25 Jan 2012 20:57:17 +0000 (20:57 +0000)]
Page Up and Page Down mappings are backwards on BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=77021

Fix Page Up and Page Down mappings as they are reversed.

Patch by Mike Fenton <mifenton@rim.com> on 2012-01-25
Reviewed by Antonio Gomes.

* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Implement OSAllocator::commit/decommit.
commit-queue@webkit.org [Wed, 25 Jan 2012 20:52:41 +0000 (20:52 +0000)]
[BlackBerry] Implement OSAllocator::commit/decommit.
BlackBerry port should support virtual memory decommiting.
https://bugs.webkit.org/show_bug.cgi?id=77013

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Rob Buis.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<content> should create HTMLContentElement object
morrita@google.com [Wed, 25 Jan 2012 20:47:34 +0000 (20:47 +0000)]
<content> should create HTMLContentElement object
https://bugs.webkit.org/show_bug.cgi?id=76439

Reviewed by Dimitri Glazkov.

Source/WebCore:

- Added HTMLContentElement.idl which has @select attribute.
- Added "content" element.

Both are behind ENABLE_SHADOW_DOM.

Tests: fast/dom/shadow/content-element-api.html
       fast/dom/shadow/content-element-outside-shadow.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLTagNames.in:
* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
(WebCore):
(WebCore::HTMLContentElement::create):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/HTMLContentElement.idl: Added.

LayoutTests:

Ensure that contnet elements are renderered not only inside the shadow tree
but also the outside that.

* fast/dom/shadow/content-element-api-expected.txt: Added.
* fast/dom/shadow/content-element-api.html: Added.
* fast/dom/shadow/content-element-outside-shadow-expected.txt: Added.
* fast/dom/shadow/content-element-outside-shadow.html: Added.
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2] Navigation events not triggered by a mouse event claim to be triggered by the...
mrobinson@webkit.org [Wed, 25 Jan 2012 20:37:13 +0000 (20:37 +0000)]
[WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=76344

Reviewed by Sam Weinig.

Source/WebKit2:

When creating InjectedBundleNavigationActions, initialize the mouse button to NoButton.
This ensures that when there is no mouse event associated with the action, when the event
hits the client-API layer, the button is still NoButton.

* WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): Initialize m_mouseButton
to WebMouseEvent::NoButton.

Tools:

Add a test verifying that the mouse button during policy decisions for
events not triggered by mouse events is NoButton.

* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction): Added test.
(TestWebKitAPI::decidePolicyForNewWindowAction): Added test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-perf-tests should timeout sooner
rniwa@webkit.org [Wed, 25 Jan 2012 20:29:17 +0000 (20:29 +0000)]
run-perf-tests should timeout sooner
https://bugs.webkit.org/show_bug.cgi?id=77026

Reviewed by Adam Barth.

Bump off the timeout from 10 minutes to 4 minutes.

Also use float instead of str in test result values to compress the size of json files bots upload.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105828.
rniwa@webkit.org [Wed, 25 Jan 2012 20:21:52 +0000 (20:21 +0000)]
Unreviewed, rolling out r105828.
http://trac.webkit.org/changeset/105828
https://bugs.webkit.org/show_bug.cgi?id=77036

Caused many crashes in ClusterFuzz and PerformanceTests
(Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
* rendering/RenderBlock.h:
(RenderBlock):

LayoutTests:

* fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Removed.
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebView should implement typingAttributes methods to work correctly with the Inspecto...
enrica@apple.com [Wed, 25 Jan 2012 20:07:55 +0000 (20:07 +0000)]
WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

* WebView/WebHTMLView.mm: Removed typingAttributes implementation.
* WebView/WebView.mm:
(-[WebView typingAttributes]): Added.

Tools:

* TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
and WebHTMLView.
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThis test is actually flaky by timing out, not by failing.
abarth@webkit.org [Wed, 25 Jan 2012 20:03:45 +0000 (20:03 +0000)]
This test is actually flaky by timing out, not by failing.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the semantics of passing contentsVisible flag to GraphicsLayers
shawnsingh@chromium.org [Wed, 25 Jan 2012 19:53:05 +0000 (19:53 +0000)]
Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

* compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
* compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
* platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake DFG update topCallFrame
oliver@apple.com [Wed, 25 Jan 2012 19:43:06 +0000 (19:43 +0000)]
Make DFG update topCallFrame
https://bugs.webkit.org/show_bug.cgi?id=76969

Reviewed by Filip Pizlo.

Add NativeCallFrameTracer to manage topCallFrame assignment
in the DFG operations, and make use of it.

* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
():
* interpreter/Interpreter.h:
(JSC):
(NativeCallFrameTracer):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed test fix to followup r105900.
morrita@google.com [Wed, 25 Jan 2012 19:42:47 +0000 (19:42 +0000)]
Unreviewed test fix to followup r105900.

* compositing/overflow/overflow-scaled-descendant-overlapping.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agosupport overflow:auto and overflow:scroll in new flexbox
tony@chromium.org [Wed, 25 Jan 2012 19:27:54 +0000 (19:27 +0000)]
support overflow:auto and overflow:scroll in new flexbox
https://bugs.webkit.org/show_bug.cgi?id=76953

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flexbox-overflow-auto-expected.html
       css3/flexbox/flexbox-overflow-auto.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow): In the case of reverse flexboxen, we can overflow up or to the left (like horizontal-bt or rtl content).
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Call updateScrollInfoAfterLayout() to add overflow scrollbars.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): In row-reverse, offset the start of the content by the scrollbar.
(WebCore::RenderFlexibleBox::layoutColumnReverse): In column-reverse, offset the start of the content by the scrollbar.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Make isHorizontalFlow public.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::isReverseFlexDirection): Convenience method.

LayoutTests:

* css3/flexbox/flexbox-overflow-auto-expected.html: Added.
* css3/flexbox/flexbox-overflow-auto.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105885.
leviw@chromium.org [Wed, 25 Jan 2012 19:13:28 +0000 (19:13 +0000)]
Unreviewed, rolling out r105885.
http://trac.webkit.org/changeset/105885
https://bugs.webkit.org/show_bug.cgi?id=77027

Causes assertions in Position. (Requested by leviw|gardening
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

* dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
* dom/PositionIterator.cpp:
* dom/PositionIterator.h:
(PositionIterator):
* editing/htmlediting.cpp:
(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

* perf/selection-skip-hidden-node-expected.txt: Removed.
* perf/selection-skip-hidden-node.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoborder-image should be implemented like a shorthand.
alexis.menard@openbossa.org [Wed, 25 Jan 2012 19:11:10 +0000 (19:11 +0000)]
border-image should be implemented like a shorthand.
https://bugs.webkit.org/show_bug.cgi?id=76697

Reviewed by Tony Chang.

Source/WebCore:

Make sure that border-image is implemented like a shorthand : when we parse
it we set the correct value to its longhands. The code was not doing it
previously as we inherited the old implementation of -webkit-border-image which
is not a shorthand but a regular property. It will then increase
style.length for a given element as we now expand the longhands.
The behavior stays the same for -webkit-border-image.

Test: fast/css/border-image-style-length.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(BorderImageParseContext):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
* css/CSSParser.h:
():
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
* css/CSSStyleApplyProperty.cpp:
():
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::borderImageSlices):
(WebCore::RenderStyleBitfields::borderImageWidth):
(WebCore::RenderStyleBitfields::borderImageOutset):
(RenderStyleBitfields):
(WebCore::RenderStyleBitfields::setBorderImageSlices):
(WebCore::RenderStyleBitfields::setBorderImageWidth):
(WebCore::RenderStyleBitfields::setBorderImageOutset):

LayoutTests:

Make sure we cover that border-image correctly expands its longhands.

* fast/css/border-image-style-length-expected.txt: Added.
* fast/css/border-image-style-length.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Refactoring][Internals] Should have InternalSettings
morrita@google.com [Wed, 25 Jan 2012 19:04:10 +0000 (19:04 +0000)]
[Refactoring][Internals] Should have InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=76424

Source/WebCore:

Reviewed by Kent Tamura.

This change extracted setting related method from window.internals
to window.internals.settings object.
- Invoked Internals::reset() in the constructor to employ Document object.
- Moved setting and configuration related Internals methods to
  newly introduced InternalSettings object.

No new tests, covered by existing tests.

* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCoreTestSupport.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* testing/InternalSettings.cpp: Added.
(WebCore::InternalSettings::create):
(WebCore::InternalSettings::~InternalSettings):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::settings):
(WebCore::InternalSettings::document):
(WebCore::InternalSettings::page):
(WebCore::InternalSettings::setInspectorResourcesDataSizeLimits):
(WebCore::InternalSettings::setForceCompositingMode):
(WebCore::InternalSettings::setAcceleratedFiltersEnabled):
(WebCore::InternalSettings::setEnableCompositingForFixedPosition):
(WebCore::InternalSettings::setEnableCompositingForScrollableFrames):
(WebCore::InternalSettings::setAcceleratedDrawingEnabled):
(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore::InternalSettings::setZoomAnimatorTransform):
(WebCore::InternalSettings::setZoomParameters):
(WebCore::InternalSettings::setMockScrollbarsEnabled):
(WebCore::InternalSettings::setPasswordEchoEnabled):
(WebCore::InternalSettings::setPasswordEchoDurationInSeconds):
(WebCore::InternalSettings::setShouldLayoutFixedElementsRelativeToFrame):
(WebCore::InternalSettings::setUnifiedTextCheckingEnabled):
(WebCore::InternalSettings::unifiedTextCheckingEnabled):
(WebCore::InternalSettings::pageScaleFactor):
(WebCore::InternalSettings::setPageScaleFactor):
(WebCore::InternalSettings::setPerTileDrawingEnabled):
* testing/InternalSettings.h: Added.
* testing/InternalSettings.idl: Added.
* testing/Internals.cpp:
(WebCore::Internals::create):
(WebCore::Internals::Internals):
(WebCore::Internals::reset):
* testing/Internals.h:
(WebCore::Internals::settings):
* testing/Internals.idl:
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):

Tools:

Reviewed by Kent Tamura.

* GNUmakefile.am: Added so new files.

LayoutTests:

Updated to follow API receiver change.

Reviewed by Kent Tamura.

* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-composited-switch.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* compositing/iframes/resources/scrollgrandchild-inner.html:
* compositing/resources/mock_scrollbars.js:
* compositing/scaling/tiled-layer-recursion.html:
* editing/input/resources/password-echo.js:
(init):
* editing/spelling/spellcheck-async-mutation.html:
* editing/spelling/spellcheck-async.html:
* editing/spelling/spelling-unified-emulation.html:
* fast/dom/Element/scale-page-bounding-client-rect.html:
* fast/dom/Element/scale-page-client-rects.html:
* fast/dom/Range/scale-page-bounding-client-rect.html:
* fast/dom/Range/scale-page-client-rects.html:
* fast/dom/iframe-inner-size-scaling.html:
* fast/dom/window-inner-size-scaling.html:
* fast/events/scale-and-scroll-body.html:
* fast/events/scale-and-scroll-iframe-body.html:
* fast/events/scale-and-scroll-iframe-window.html:
* fast/events/scale-and-scroll-window.html:
* fast/events/script-tests/page-scaled-mouse-click-iframe.js:
(iframeLoaded):
* fast/events/script-tests/page-scaled-mouse-click.js:
* fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/frames/frame-set-rotation-hit.html:
* fast/frames/frame-set-scaling-hit.html:
* fast/frames/iframe-double-scale-contents.html:
* fast/repaint/background-scaling.html:
* fast/repaint/fixed-in-page-scale.html:
* fast/repaint/fixed-right-bottom-in-page-scale.html:
* fast/repaint/fixed-right-in-page-scale.html:
* fast/repaint/scale-page-shrink.html:
* fast/transforms/selection-bounds-in-transformed-view.html:
* http/tests/inspector/network-test.js:
(resetInspectorResourcesData):
* http/tests/inspector/network/network-content-replacement-embed.html:
* http/tests/inspector/network/network-content-replacement-xhr.html:
* platform/chromium/compositing/accelerated-drawing/alpha.html:
* platform/chromium/compositing/accelerated-drawing/svg-filters.html:
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: new-run-webkit-websocket is broken
toyoshim@chromium.org [Wed, 25 Jan 2012 18:55:37 +0000 (18:55 +0000)]
webkitpy: new-run-webkit-websocket is broken
https://bugs.webkit.org/show_bug.cgi?id=76999

Reviewed by Dirk Pranke.

r105674 broke new-run-webkit-websocket, since options.chromium
doesn't exist any more. new-run-webkit-httpd was also broken
and already fixed at r105835.
* Scripts/new-run-webkit-websocketserver:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoborder-image should not crash when the source is not specified.
alexis.menard@openbossa.org [Wed, 25 Jan 2012 18:54:40 +0000 (18:54 +0000)]
border-image should not crash when the source is not specified.
https://bugs.webkit.org/show_bug.cgi?id=77001

Reviewed by Andreas Kling.

Source/WebCore:

This bug was introduced by r105502 but was exposed by r105738.
The image-source of a border-image is not mandatory therefore it
may happen that you have no value set for it. WebCore::createBorderImageValue
was wrongly assuming that the image is always set. This problem also required a bit
of refactoring in CSSStyleSelector::mapNinePieceImage to take into account that
the image could be optional (just like other properties).

Test: fast/css/border-image-null-image-crash.html

* css/CSSBorderImage.cpp:
(WebCore::createBorderImageValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Add a new test to cover this crash specifically.

* fast/css/border-image-null-image-crash-expected.txt: Added.
* fast/css/border-image-null-image-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] public.pri is missing dependency to quick module.
commit-queue@webkit.org [Wed, 25 Jan 2012 18:38:34 +0000 (18:38 +0000)]
[Qt] public.pri is missing dependency to quick module.
https://bugs.webkit.org/show_bug.cgi?id=77016

Patch by Zeno Albisser <zeno@webkit.org> on 2012-01-25
Reviewed by Tor Arne Vestbø.

* declarative/public.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, only skip scrollbars/scroll-rtl-or-bt-layer.html on qt-wk2.
tony@chromium.org [Wed, 25 Jan 2012 18:34:15 +0000 (18:34 +0000)]
Unreviewed, only skip scrollbars/scroll-rtl-or-bt-layer.html on qt-wk2.
eventSender.mouseScrollBy is implemented on GTK+ and Mac.

* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium]: rebaseline after r105878
antonm@chromium.org [Wed, 25 Jan 2012 18:31:18 +0000 (18:31 +0000)]
[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium test expectations update to allow more failure modes.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInlining breaks call frame walking when the walking is done from outside the inlinee,
fpizlo@apple.com [Wed, 25 Jan 2012 18:27:43 +0000 (18:27 +0000)]
Inlining breaks call frame walking when the walking is done from outside the inlinee,
but inside a code block that had inlining
https://bugs.webkit.org/show_bug.cgi?id=76978
<rdar://problem/10720904>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOriginForReturn):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):

LayoutTests:

* fast/js/dfg-inline-arguments-use-from-uninlined-code-expected.txt: Added.
* fast/js/dfg-inline-arguments-use-from-uninlined-code.html: Added.
* fast/js/script-tests/dfg-inline-arguments-use-from-uninlined-code.js: Added.
(foo):
(fuzz):
(bar):
(baz):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Implement tap feedback respecting -webkit-tap-highlight-color
kenneth@webkit.org [Wed, 25 Jan 2012 18:18:47 +0000 (18:18 +0000)]
[Qt] Implement tap feedback respecting -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=76914

Reviewed by Simon Hausmann.

.:

Add a manual test.

* ManualTests/qt/tap-highlighting.html: Added.

Source/WebCore:

Implement highlighting of dom nodes with a rounded rect, respecting
the color of -webkit-tap-highlight-color and any transform applied
to the element.

Tested with manual test.

* Target.pri:
* page/GestureTapHighlighter.cpp: Added.
(WebCore::GestureTapHighlighter::pathForNodeHighlight):
* page/GestureTapHighlighter.h: Added.

Source/WebKit2:

Implement tap highlighting for Qt. When a touch press is issued,
which is not handled by the web page, then we highlight any
activatable node below. In all otehr cases, we hide any highlights.

The highlighting itself is painted on an accelerated PageOverlay,
on the web process side.

* Target.pri:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handlePotentialActivation):
* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::recognize):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handlePotentialSingleTapEvent):
* UIProcess/qt/QtWebPageEventHandler.h:
* WebProcess/WebPage/TapHighlightController.cpp: Added.
(WebKit::TapHighlightController::TapHighlightController):
(WebKit::TapHighlightController::~TapHighlightController):
(WebKit::TapHighlightController::highlight):
(WebKit::TapHighlightController::hideHighlight):
(WebKit::TapHighlightController::pageOverlayDestroyed):
(WebKit::TapHighlightController::willMoveToWebPage):
(WebKit::TapHighlightController::didMoveToWebPage):
(WebKit::highlightColor):
(WebKit::TapHighlightController::drawRect):
(WebKit::TapHighlightController::mouseEvent):
* WebProcess/WebPage/TapHighlightController.h: Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::highlightPotentialActivation):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::tapHighlightController):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105887.
leviw@chromium.org [Wed, 25 Jan 2012 18:12:04 +0000 (18:12 +0000)]
Unreviewed, rolling out r105887.
http://trac.webkit.org/changeset/105887
https://bugs.webkit.org/show_bug.cgi?id=77023

Rolling out incorrect chromium expectations for zero length
svg stroke. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

* platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
* platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
* platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
* platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
* platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
* platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Need to distinguish key paths that don't yield value vs. yield invalid key
jsbell@chromium.org [Wed, 25 Jan 2012 18:01:13 +0000 (18:01 +0000)]
IndexedDB: Need to distinguish key paths that don't yield value vs. yield invalid key
https://bugs.webkit.org/show_bug.cgi?id=76487

Source/WebCore:

Implement the precondition checks for IDBObjectStore.add/put operations: raise an error
if there is a key generator (autoIncrement) and the path yields a value and the value
is not a valid key; raise an error if any of the index key paths yield a value which
is not a valid key.

Reviewed by Tony Chang.

Tests: storage/indexeddb/keypath-edges.html
       storage/indexeddb/objectstore-basics.html

* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):

Source/WebKit/chromium:

Added a NullType to represent a null IDBKey pointer. This is needed to distinguish the
cases in the spec where the key resolution algorithm returns no value (null) versus
returns a value but that value is not a valid key (invalid).

Reviewed by Tony Chang.

* public/WebIDBKey.h:
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::createNull): Added.
(WebKit::WebIDBKey::createFromValueAndKeyPath): Now returns null if value is null.
(WebKit::convertFromWebIDBKeyArray): Null keys should never exist within arrays.
(WebKit::WebIDBKey::assignInvalid):
(WebKit::WebIDBKey::assignNull):
(WebKit::WebIDBKey::type):

LayoutTests:

Reviewed by Tony Chang.

* storage/indexeddb/keypath-edges-expected.txt: Added.
* storage/indexeddb/keypath-edges.html: Added.
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, skip scrollbars/scroll-rtl-or-bt-layer.html on WebKit2
tony@chromium.org [Wed, 25 Jan 2012 17:59:16 +0000 (17:59 +0000)]
Unreviewed, skip scrollbars/scroll-rtl-or-bt-layer.html on WebKit2
because eventSender.mouseScrollBy isn't implemented.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed Qt gardening.
rgabor@webkit.org [Wed, 25 Jan 2012 17:56:54 +0000 (17:56 +0000)]
Unreviewed Qt gardening.

Temporally skip failing tests after r105878.

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-01-25

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Adding platform expectations after 105879
leviw@chromium.org [Wed, 25 Jan 2012 17:51:20 +0000 (17:51 +0000)]
Unreviewed. Adding platform expectations after 105879

* platform/chromium-linux-x86/compositing: Added.
* platform/chromium-linux-x86/compositing/overflow: Added.
* platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win-vista/compositing: Added.
* platform/chromium-win-vista/compositing/overflow: Added.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win-xp/compositing: Added.
* platform/chromium-win-xp/compositing/overflow: Added.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Adding platform test expectations after r105878.
leviw@chromium.org [Wed, 25 Jan 2012 17:48:24 +0000 (17:48 +0000)]
Unreviewed. Adding platform test expectations after r105878.

* platform/chromium-mac-leopard/svg/stroke: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win-vista/svg/stroke: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win-xp/svg/stroke: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline and skip new timing-out media test.
philn@webkit.org [Wed, 25 Jan 2012 17:45:58 +0000 (17:45 +0000)]
Unreviewed, GTK rebaseline and skip new timing-out media test.

* platform/gtk/Skipped:
* platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
* platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=65377
commit-queue@webkit.org [Wed, 25 Jan 2012 17:23:48 +0000 (17:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65377
Skip the entire node when it is right to do so, instead of stepping
through every character, so we save CPU time on checking every position
unnecessarily.

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Darin Adler.

Source/WebCore:

Test: perf/selection-skip-hidden-node.html

* dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::moveToLeafNodeStart):
(WebCore::PositionIterator::moveToLeafNodeEnd):
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

* perf/selection-skip-hidden-node-expected.txt: Added.
* perf/selection-skip-hidden-node.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
commit-queue@webkit.org [Wed, 25 Jan 2012 17:21:33 +0000 (17:21 +0000)]
[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-25
Reviewed by Adam Roben.

Source/WebKit2:

Implement the setPopupBlockingEnabled method.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetPrivateBrowsingEnabled):
(WKBundleSetPopupBlockingEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPopupBlockingEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Implement the setPopupBlockingEnabled method.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPopupBlockingEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip tests which do not fail now.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unnecessary member variable from PluginView.
commit-queue@webkit.org [Wed, 25 Jan 2012 17:18:29 +0000 (17:18 +0000)]
Remove unnecessary member variable from PluginView.
https://bugs.webkit.org/show_bug.cgi?id=76909

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-01-25
Reviewed by Adam Roben.

No new tests needed.

* plugins/PluginView.cpp:
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
* plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline and skipping 2 new test failures.
philn@webkit.org [Wed, 25 Jan 2012 17:17:30 +0000 (17:17 +0000)]
Unreviewed, GTK rebaseline and skipping 2 new test failures.

* platform/gtk/Skipped:
* platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt:
* platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt:
* platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix when using force_static_libs_as_shared
yael.aharon@nokia.com [Wed, 25 Jan 2012 17:09:51 +0000 (17:09 +0000)]
[Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832

Reviewed by Simon Hausmann.

Source/WebCore:

Add a dependency on QtWidgets, when compiling against Qt5.

No new tests. This is a build fix.

* Target.pri:

Source/WebKit2:

Add a dependency on QtWidgets.

* Target.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Gtk] Update expected layout test results after r105686
philn@webkit.org [Wed, 25 Jan 2012 16:19:35 +0000 (16:19 +0000)]
[Gtk] Update expected layout test results after r105686
https://bugs.webkit.org/show_bug.cgi?id=77008

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-25
Reviewed by Philippe Normand.

After r105686, missing image icons are properly loaded and
shown, causing failures because of incorrect expected results.
These changes properly fix the expectations and subsequently
remove failures.

* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/gtk/fast/block/float/015-expected.txt:
* platform/gtk/fast/borders/rtl-border-05-expected.txt:
* platform/gtk/fast/dom/34176-expected.txt:
* platform/gtk/fast/dom/inner-text-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
* platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClipping of render layer boundaries does not take page scale into account
commit-queue@webkit.org [Wed, 25 Jan 2012 15:50:53 +0000 (15:50 +0000)]
Clipping of render layer boundaries does not take page scale into account
https://bugs.webkit.org/show_bug.cgi?id=76850

Source/WebCore:

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

When inserting render layers into the compositor's overlap map, the
layer boundaries are clipped against any potential parent clip rects.
The clip rects are given in CSS coordinates, while the render layer
boundaries are in scaled CSS coordinates, so the result is incorrect.
This patch scales the clip rects before calculating the intersection.

Test: compositing/overflow/overflow-scaled-descendant-overlapping.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):

LayoutTests:

Added new test to make sure render layers inside clipped containers
are correctly tested for overlap with other layers.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

* compositing/overflow/overflow-scaled-descendant-overlapping.html: Added.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLinecaps wrong for zero length lines
commit-queue@webkit.org [Wed, 25 Jan 2012 15:31:39 +0000 (15:31 +0000)]
Linecaps wrong for zero length lines
https://bugs.webkit.org/show_bug.cgi?id=71820

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25
Reviewed by Nikolas Zimmermann.

Total reworking of the method used to draw zero-length linecaps for
SVG. This patch works for all zero length sub-paths.

Source/WebCore:

Tests: svg/stroke/zero-length-path-linecap-rendering.svg
       svg/stroke/zero-length-subpaths-linecap-rendering.svg

* rendering/svg/RenderSVGShape.cpp: Significant refactoring to enable
  new implementation and clarify code.
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::zeroLengthLinecapPath):
(WebCore::RenderSVGShape::nonScalingStrokePath):
(WebCore::RenderSVGShape::setupNonScalingStrokeTransform):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::processZeroLengthSubpaths):
* rendering/svg/RenderSVGShape.h: Declarations for new methods.
* rendering/svg/SVGSubpathData.h: Class for finding zero length subpaths.
* svg/SVGPathBuilder.h: Fix typos
* svg/SVGPathConsumer.h: Fix typos
* svg/SVGPathSegListBuilder.h: Fix typos
* svg/SVGPathTraversalStateBuilder.h: Fix typos

LayoutTests:

* platform/chromium/test_expectations.txt: Chromium test expectations
pending new expected images and text.
* platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/mac/test_expectations.txt: Chromium test expectations
pending new expected images and text.
* svg/stroke/zero-length-path-linecap-rendering.svg: Added.
* svg/stroke/zero-length-subpaths-linecap-rendering.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: show memory counter graphs in timeline panel
yurys@chromium.org [Wed, 25 Jan 2012 15:10:31 +0000 (15:10 +0000)]
Web Inspector: show memory counter graphs in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=76843

Timeline panel is extended with several graphs depicting total node count,
number of DOM groups and event listeners. This feature is hidden behind
experimental setting.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setDomCountersEnabled):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::collectDomCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
* inspector/TimelineRecordFactory.cpp:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype._sidebarResized):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._updateSidebarSize):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getGroupCount):
(WebInspector.MemoryStatistics.prototype._draw.getNodeCount):
(WebInspector.MemoryStatistics.prototype._draw.getListenerCount):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype.hide):
(WebInspector.MemoryStatistics.prototype._setVerticalClip):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._drawBottomBound):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleMemoryStatistics):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refresh):
* inspector/front-end/timelinePanel.css:
(#timeline-memory-splitter):
(#memory-counters-graph):
(#memory-graphs-container):
(#memory-graphs-container .split-view-contents):
(.timeline-marker):
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info.bottom-border-visible):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Cleanup testfonts handling
kbalazs@webkit.org [Wed, 25 Jan 2012 15:03:01 +0000 (15:03 +0000)]
[Qt] Cleanup testfonts handling
https://bugs.webkit.org/show_bug.cgi?id=76068

Reviewed by Simon Hausmann.

Factor test font initialization into it's own file  so test
font users can share the implementation by adding the file
to their build.
Use fonts.conf from the test font directory to not require the
current directory to be the WebKit root.
Fix the -use-test-fonts option of QtTestBrowser by initializing
the fonts earlier, before it is too late (namely before calling
show on the main window).

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
* DumpRenderTree/qt/fonts.conf: Removed. No need for this since
we will use the one from the test fonts directory.
* DumpRenderTree/qt/main.cpp:
(main): Fix the ifdefs to make it clear that the code to
set up the Dpi has not been ported to Qt5 yet.
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(launcherMain):
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts): Remove the code to set up the Dpi
because it does not work with Qt5.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] build-webkit --qt requires a git-svn or SVN checkout.
hausmann@webkit.org [Wed, 25 Jan 2012 14:32:47 +0000 (14:32 +0000)]
[Qt] build-webkit --qt requires a git-svn or SVN checkout.

Reviewed by Tor Arne Vestø.

Don't require it by making svnRevisionForDirectory return "unknown"
instead of bailing out with an error.

* Scripts/VCSUtils.pm:
(svnRevisionForDirectory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed single line test fix after r105865.
loislo@chromium.org [Wed, 25 Jan 2012 14:30:27 +0000 (14:30 +0000)]
Unreviewed single line test fix after r105865.

* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<http://webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search...
commit-queue@webkit.org [Wed, 25 Jan 2012 14:13:44 +0000 (14:13 +0000)]
<webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search Stub

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-25
Reviewed by Pavel Feldman.

* inspector/front-end/InspectorFrontendHostStub.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][ARM] Unreviewed gardening.
ossy@webkit.org [Wed, 25 Jan 2012 13:27:26 +0000 (13:27 +0000)]
[Qt][ARM] Unreviewed gardening.

Skip failing tests, update/add platform specific expected files for passing tests.

* platform/qt-arm/Skipped:
* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
* platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed inspector style fix.
vsevik@chromium.org [Wed, 25 Jan 2012 13:20:41 +0000 (13:20 +0000)]
Unreviewed inspector style fix.

* inspector/front-end/tabbedPane.css:
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix incorrect behavior in HTMLCollection.prototype.item().
commit-queue@webkit.org [Wed, 25 Jan 2012 13:04:24 +0000 (13:04 +0000)]
Fix incorrect behavior in HTMLCollection.prototype.item().
https://bugs.webkit.org/show_bug.cgi?id=74468

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-25
Reviewed by Adam Barth.

HTMLCollection.prototype.item("someString") was falling back to
.namedItem("someString"), which is wrong per spec. Also align the
handling of various other types of objects passed as the argument with
the spec and the rest of the browsers.

Source/WebCore:

Test: fast/dom/collection-item.html

* bindings/js/JSHTMLCollectionCustom.cpp: Remove custom implementation of item().
* bindings/v8/custom/V8HTMLCollectionCustom.cpp: Ditto.
* html/HTMLCollection.idl: Remove [Custom] in item(), it's not needed.

LayoutTests:

* fast/dom/collection-item-expected.txt: Added.
* fast/dom/collection-item.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agotable border spacing test for CSS3 calc
mikelawther@chromium.org [Wed, 25 Jan 2012 12:39:03 +0000 (12:39 +0000)]
table border spacing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76226

Reviewed by Julien Chaffraix.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/table-border-spacing-expected.txt: Added.
* css3/calc/table-border-spacing.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105858.
commit-queue@webkit.org [Wed, 25 Jan 2012 12:36:44 +0000 (12:36 +0000)]
Unreviewed, rolling out r105858.
http://trac.webkit.org/changeset/105858
https://bugs.webkit.org/show_bug.cgi?id=77004

It made many tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperAnimation.cpp: Removed.
* platform/graphics/texmap/TextureMapperAnimation.h: Removed.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::normalizedAnimationValue):
(WebCore):
(WebCore::TextureMapperNode::applyOpacityAnimation):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::applyTimingFunction):
(WebCore::TextureMapperNode::applyTransformAnimation):
(WebCore::TextureMapperNode::applyAnimationFrame):
(WebCore::TextureMapperNode::applyAnimation):
(WebCore::TextureMapperNode::hasOpacityAnimation):
(WebCore::TextureMapperNode::hasTransformAnimation):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
(WebCore::TextureMapperAnimation::TextureMapperAnimation):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperAnimation):
(WebCore::TextureMapperAnimation::create):
(WebCore):
(TextureMapperNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening, Skipped list cleanup.
ossy@webkit.org [Wed, 25 Jan 2012 12:35:47 +0000 (12:35 +0000)]
Unreviewed gardening, Skipped list cleanup.

* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
* platform/mac/Skipped: Remove non-existent files.
* platform/qt/Skipped: Group new skipped tests.
* platform/qt/editing/deleting/delete-line-011-expected.png:
* platform/qt/editing/deleting/delete-line-011-expected.txt:
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.png: Added.
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Added.
* platform/qt/fast/block/float/floats-and-text-indent-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofast/text/unicode-variation-selector.html doesn't pass on Lion
bashi@chromium.org [Wed, 25 Jan 2012 12:32:48 +0000 (12:32 +0000)]
fast/text/unicode-variation-selector.html doesn't pass on Lion
https://bugs.webkit.org/show_bug.cgi?id=76041

Source/WebCore:

Reviewed by Dan Bernstein.

Consumes non-BMP marks in advanceByCombiningCharacterSequence() to take into
account Ideographic variation selectors (these are non-BMP marks).

No new tests. fast/text/unicode-variation-selector.html should pass on Lion.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Use Unicode code point
to iterate the loop which consumes marks.

LayoutTests:

Update the UVS test font to be CoreText-friendly. This updated font is provided by Apple.

Reviewed by Dan Bernstein.

* fast/text/resources/gw432047.ttf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers...
loislo@chromium.org [Wed, 25 Jan 2012 12:25:42 +0000 (12:25 +0000)]
Web Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers tree.
https://bugs.webkit.org/show_bug.cgi?id=76989

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._postfixObjectCell):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta...
vsevik@chromium.org [Wed, 25 Jan 2012 12:01:49 +0000 (12:01 +0000)]
Web Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta information to frontend.
https://bugs.webkit.org/show_bug.cgi?id=76711

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemovedFromFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.ObjectStore):
(WebInspector.IndexedDBModel.ObjectStoreIndex):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase):
(WebInspector.IndexedDBRequestManager.prototype._databaseLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabaseRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: CodeGeneratorInspector.py: add optional runtime validator
yurys@chromium.org [Wed, 25 Jan 2012 11:54:51 +0000 (11:54 +0000)]
Web Inspector: CodeGeneratorInspector.py: add optional runtime validator
https://bugs.webkit.org/show_bug.cgi?id=76676

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-25
Reviewed by Yury Semikhatsky.

Generator algorithm is redone significantly.

* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType):
(RawTypes.BaseType.request_raw_internal_runtime_cast):
(RawTypes.BaseType.generate_validate_method_impl):
(RawTypes):
(RawTypes.generate_validate_methods):
(RawTypes.String):
(RawTypes.String.generate_validate_method):
(RawTypes.String.get_raw_validator_call_text):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number):
(RawTypes.Number.generate_validate_method):
(RawTypes.Number.get_raw_validator_call_text):
(RawTypes.Bool):
(RawTypes.Bool.generate_validate_method):
(RawTypes.Bool.get_raw_validator_call_text):
(RawTypes.Object):
(RawTypes.Object.generate_validate_method):
(RawTypes.Object.get_raw_validator_call_text):
(RawTypes.Any):
(RawTypes.Any.generate_validate_method):
(RawTypes.Any.get_raw_validator_call_text):
(RawTypes.Array):
(RawTypes.Array.generate_validate_method):
(RawTypes.Array.get_raw_validator_call_text):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.resolve_inner):
(TypeBindings.create_type_declaration_.EnumBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_validator_call_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.resolve_inner):
(TypeBindings.create_type_declaration_.PlainString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.ClassBinding):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.PropertyData):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(TypeBindings.create_type_declaration_.ClassBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(get_validator_call_text):
(get_in_c_type_text):
(AdHocTypeContextImpl):
(AdHocTypeContextImpl.__init__):
(AdHocTypeContextImpl.get_type_name_fix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix.output_comment):
(AdHocTypeContextImpl.add_type):
(PlainObjectBinding):
(PlainObjectBinding.resolve_inner):
(PlainObjectBinding.request_user_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.AdHocTypeContext):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.resolve_inner.AdHocTypeContext.add_type):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(RawTypeBinding.resolve_inner):
(RawTypeBinding):
(RawTypeBinding.request_user_runtime_cast):
(RawTypeBinding.request_internal_runtime_cast):
(RawTypeBinding.get_validator_call_text):
(TypeData.get_name):
(TypeData):
(TypeData.get_domain_name):
(resolve_param_type):
(NeedRuntimeCastRequest):
(NeedRuntimeCastRequest.__init__):
(NeedRuntimeCastRequest.acknowledge):
(NeedRuntimeCastRequest.is_acknowledged):
(resolve_all_types):
(resolve_all_types.ForwardListener):
(resolve_all_types.ForwardListener.add_type_data):
(resolve_all_types.ResolveContext):
(Generator):
(Generator.go):
(Generator.process_event):
(Generator.process_event.AdHocTypeContext):
(Generator.process_event.AdHocTypeContext.add_type):
(Generator.process_event.EventForwardListener):
(Generator.process_event.EventForwardListener.add_type_data):
(Generator.process_event.EventResolveContext):
(Generator.process_event.EventGenerateContext):
(Generator.process_types.GenerateContext):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types.generate_forward_callback):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::size):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreview manual revert of r105843.
antonm@chromium.org [Wed, 25 Jan 2012 11:44:55 +0000 (11:44 +0000)]
Unreview manual revert of r105843.

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore):
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
(WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily):
(WebCore::KURLGooglePrivate::copyTo):
(WebCore::encodeWithURLEscapeSequences):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] fast/css/text-overflow-input.html rebaseline
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:44:06 +0000 (11:44 +0000)]
[chromium] fast/css/text-overflow-input.html rebaseline
https://bugs.webkit.org/show_bug.cgi?id=76981

Reviewed by Kent Tamura.

Fixed in r105451

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse maximum image dimension definition from libwebp
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:37:22 +0000 (11:37 +0000)]
Use maximum image dimension definition from libwebp
https://bugs.webkit.org/show_bug.cgi?id=76980

Reviewed by Kent Tamura.

No new tests, no change in behavior.

* platform/image-encoders/skia/WEBPImageEncoder.cpp:
(WebCore::encodePixels): s/WEBP_MAX_DIMENSION/WEBPImageEncoder::MaximumImageDimension/
* platform/image-encoders/skia/WEBPImageEncoder.h:
(): Remove local definition of the maximum webp image dimension

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJPEGDecoder should use imageDecoder colorProfile helpers
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:24:24 +0000 (11:24 +0000)]
JPEGDecoder should use imageDecoder colorProfile helpers
https://bugs.webkit.org/show_bug.cgi?id=76968

Reviewed by Adam Barth.

No new tests. Cover by existing tests, in particular:
  fast/images/ycbcr-with-cmyk-color-profile.html
  fast/images/gray-scale-jpeg-with-color-profile.html
  fast/images/cmyk-jpeg-with-color-profile.html
  fast/images/color-jpeg-with-color-profile.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: white-space removals via Xcode.
(WebCore::readColorProfile):  Use ImageDecoder.h color profile helper routines.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Texmap] Divide TextureMapperNode.cpp to 3 files.
noam.rosenthal@nokia.com [Wed, 25 Jan 2012 11:09:45 +0000 (11:09 +0000)]
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

* GNUmakefile.list.am: Added new TextureMapper-related files.
* Target.pri: Added new TextureMapper-related files.
* WebCore.gypi: Added new TextureMapper-related files.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperAnimation.cpp: Added.
* platform/graphics/texmap/TextureMapperAnimation.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTemporarily disable running the unit tests on the Chromium EWS. These
abarth@webkit.org [Wed, 25 Jan 2012 10:18:40 +0000 (10:18 +0000)]
Temporarily disable running the unit tests on the Chromium EWS.  These
tests don't work properly (see
https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
blocking the EWS.

* Scripts/webkitpy/common/config/ports.py:
(ChromiumPort):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate results.html version of PixelZoomer
abarth@webkit.org [Wed, 25 Jan 2012 09:57:51 +0000 (09:57 +0000)]
Update results.html version of PixelZoomer
https://bugs.webkit.org/show_bug.cgi?id=76965

Reviewed by Ojan Vafai.

Tools:

Improve readability as suggested by Ojan.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

LayoutTests:

Update result.html with changes from PixelZoomer.js.

* fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2] FindController should not assume that ports do not want to highlight text matches
sergio@webkit.org [Wed, 25 Jan 2012 08:54:19 +0000 (08:54 +0000)]
[WK2] FindController should not assume that ports do not want to highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Reviewed by Darin Adler.

FindController must obey the FindOptionsShowHighlight flag instead
of assuming that ports do not want to highlight search matches.

* Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFindOptions): Ditto.
* Shared/WebFindOptions.h: added FindOptionsShowHighlight.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 25 Jan 2012 08:37:01 +0000 (08:37 +0000)]
[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76899

Reviewed by Martin Robinson.

Source/WebKit2:

* UIProcess/API/gtk/WebKitLoaderClient.cpp: Renamed from
Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp.
(didStartProvisionalLoadForFrame): Use clientInfo instead fo
getting the view from the page.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(didSameDocumentNavigationForFrame): Ditto.
(didReceiveTitleForFrame): Ditto.
(didChangeProgress): Ditto.
(didChangeBackForwardList): Ditto.
(attachLoaderClientToView): Pass WebKitWebView as clientInfo to
callbacks.
* UIProcess/API/gtk/WebKitLoaderClient.h: Added.
* UIProcess/API/gtk/WebKitUIClient.cpp:
(createNewPage): Use clientInfo instead fo getting the view from
the page.
(showPage): Ditto.
(closePage): Ditto.
(runJavaScriptAlert): Ditto.
(runJavaScriptConfirm): Ditto.
(runJavaScriptPrompt): Ditto.
(toolbarsAreVisible): Ditto.
(setToolbarsAreVisible): Ditto.
(menuBarIsVisible): Ditto.
(setMenuBarIsVisible): Ditto.
(statusBarIsVisible): Ditto.
(setStatusBarIsVisible): Ditto.
(isResizable): Ditto.
(setIsResizable): Ditto.
(getWindowFrame): Ditto.
(setWindowFrame): Ditto.
(attachUIClientToView): Pass WebKitWebView as clientInfo to
callbacks.
* UIProcess/API/gtk/WebKitUIClient.h: Remove GObject boilerplate.
* UIProcess/API/gtk/WebKitWebLoaderClient.h: Removed.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Remove UIClient and LoaderClient
objects and call attachUIClientToView() and attachLoaderClientToView().
* UIProcess/API/gtk/tests/GNUmakefile.am: Rename
WebKitWebLoaderClient to WebKitLoaderClient.
* UIProcess/API/gtk/tests/TestLoaderClient.cpp: Renamed from
Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp.

Tools:

* gtk/generate-gtkdoc:
(get_webkit2_options): WebKitWebLoaderClient has been renamed to
WebKitLoaderClient.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnskip now passing tests after r105813.
ossy@webkit.org [Wed, 25 Jan 2012 08:04:14 +0000 (08:04 +0000)]
Unskip now passing tests after r105813.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening. Skip failing tests.
ossy@webkit.org [Wed, 25 Jan 2012 07:58:18 +0000 (07:58 +0000)]
Unreviewed gardening. Skip failing tests.

* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.
ossy@webkit.org [Wed, 25 Jan 2012 07:49:39 +0000 (07:49 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.

* platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Trigger Chromium Mac Release (Perf) on new commits.
rniwa@webkit.org [Wed, 25 Jan 2012 07:01:47 +0000 (07:01 +0000)]
Build fix. Trigger Chromium Mac Release (Perf) on new commits.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<style scoped>: Implement registering of <style scoped> with the scoping element
rolandsteiner@chromium.org [Wed, 25 Jan 2012 06:48:26 +0000 (06:48 +0000)]
<style scoped>: Implement registering of <style scoped> with the scoping element
https://bugs.webkit.org/show_bug.cgi?id=67790

.:

windows.internals updates

Reviewed by Dimitri Glazkov.

* Source/autotools/symbols.filter:

Source/WebCore:

Implement registering of a <style> element with its parent element if the 'scoped' attribute is set.
Update the registration whenever the 'scoped' attribute is changed,
or the <style> element eneters or leaves the tree.

Also, extend windows.internals to allow for testing of the registration ref-counting.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/registering.html

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::hasScopedHTMLStyleChild):
(WebCore::Element::numberOfScopedHTMLStyleChildren):
(WebCore::Element::registerScopedHTMLStyleChild):
(WebCore::Element::unregisterScopedHTMLStyleChild):
* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::registerScopedHTMLStyleChild):
(WebCore::ElementRareData::unregisterScopedHTMLStyleChild):
(WebCore::ElementRareData::hasScopedHTMLStyleChild):
(WebCore::ElementRareData::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::parseMappedAttribute):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedIntoDocument):
(WebCore::HTMLStyleElement::removedFromDocument):
(WebCore::HTMLStyleElement::willRemove):
* html/HTMLStyleElement.h:
* testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Add symbols for windows.internals.numberOfScopedHTMLStyleChildren

Reviewed by Dimitri Glazkov.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Tests that registration of <style scoped> with its parent is performed correctly
in various circumstances.

Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/registering-expected.txt: Added.
* fast/css/style-scoped/registering.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit needs public performance tests running on public bots
rniwa@webkit.org [Wed, 25 Jan 2012 06:08:41 +0000 (06:08 +0000)]
WebKit needs public performance tests running on public bots
https://bugs.webkit.org/show_bug.cgi?id=10266

Reviewed by Adam Barth.

Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(UploadPerfTestResults):
(BuildAndPerfTestFactory):
(BuildAndPerfTestFactory.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105843>
dbates@webkit.org [Wed, 25 Jan 2012 05:27:02 +0000 (05:27 +0000)]
Attempt to fix Mac build after changeset <trac.webkit.org/changeset/105843>
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

* platform/KURL.h:
(WebCore::KURL::innerURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium test fix.
vsevik@chromium.org [Wed, 25 Jan 2012 05:17:25 +0000 (05:17 +0000)]
Unreviewed chromium test fix.

* src/js/Tests.js:
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
vangelis@chromium.org [Wed, 25 Jan 2012 03:28:08 +0000 (03:28 +0000)]
Source/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76735

This is to add skipped layers to their RenderSurface's layer list so that they
are considered in the next update. Without this change, m_skipsDraw = false sticks
with the layer for the remainder of its lifetime.

Reviewed by James Robinson.

Tests: Unit test (TiledLayerChromiumTest.cpp)

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::skipsDraw):

Source/WebKit/chromium: Adding a test to verify that m_skipsDraw gets reset between frames for
tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=76735

Reviewed by James Robinson.

* WebKit.gypi:
* tests/FakeCCLayerTreeHostClient.h: Added.
(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
(WebCore::FakeCCLayerTreeHostClient::layout):
(WebCore::FakeCCLayerTreeHostClient::applyScrollAndScale):
(WebCore::FakeCCLayerTreeHostClient::createLayerTreeHostContext3D):
(WebCore::FakeCCLayerTreeHostClient::didRecreateGraphicsContext):
(WebCore::FakeCCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::FakeCCLayerTreeHostClient::didCompleteSwapBuffers):
(WebCore::FakeCCLayerTreeHostClient::scheduleComposite):
* tests/LayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::skipsDraw):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInvalidate r105697, r105766, r105809 and r105805
haraken@chromium.org [Wed, 25 Jan 2012 02:47:06 +0000 (02:47 +0000)]
Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970

Reviewed by Adam Barth.

I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.

In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:

(0) Assume that there are A.idl, B.idl and C.idl.

(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.

(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.

(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...

We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(UpdateFile):
* bindings/scripts/CodeGeneratorCPP.pm:
(WriteData):
* bindings/scripts/CodeGeneratorJS.pm:
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(WriteData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd full support for filesystem URLs.
ericu@chromium.org [Wed, 25 Jan 2012 02:20:00 +0000 (02:20 +0000)]
Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it.  This patch
merely enables that, without changing behavior.

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL): Add missing escaping of URL path.

* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL): Use innerURL member, if it's populated.

* platform/KURL.h:
(WebCore::KURL::innerURL): Add innerURL member.

* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F ['/'] in paths; it's much more readable, and it's safe.

* platform/KURLGooglePrivate.h:
(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInitializing the browser property of the Bugzilla class takes too long
ojan@chromium.org [Wed, 25 Jan 2012 02:13:51 +0000 (02:13 +0000)]
Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960

Reviewed by Adam Barth.

Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.__init__):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=76855
barraclough@apple.com [Wed, 25 Jan 2012 02:02:50 +0000 (02:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Oliver Hunt.

Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):
    - Track live handle objects in a map.
(WTF::MetaAllocator::release):
    - Removed support for handles with null m_allocator (no longer used).
    - Notify the tracker of handles being released.
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
    - Moved functionality out into MetaAllocator::release.
(WTF::MetaAllocatorHandle::shrink):
    - Removed support for handles with null m_allocator (no longer used).
(WTF::MetaAllocator::MetaAllocator):
    - Initialize m_tracker.
(WTF::MetaAllocator::allocate):
    - Notify the tracker of new allocations.
* wtf/MetaAllocator.h:
(WTF::MetaAllocatorTracker::find):
    - Lookup a MetaAllocatorHandle based on an address inside the allocation.
(WTF::MetaAllocator::trackAllocations):
    - Register a callback object to track allocation state.
* wtf/MetaAllocatorHandle.h:
    - Remove unused createSelfManagedHandle/constructor.
(WTF::MetaAllocatorHandle::key):
    - Added, for use in RedBlackTree.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDeath to JavaScriptGlue.
mrowe@apple.com [Wed, 25 Jan 2012 01:44:57 +0000 (01:44 +0000)]
Death to JavaScriptGlue.

Rubber-stamped by Geoffrey Garen.

.:

* Source/JavaScriptGlue: Removed.
* Source/Makefile: Stop building JavaScriptGlue.

Tools:

* BuildSlaveSupport/build-launcher-app:
(copyNightlyLauncher):
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
* Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
path in conjunction with a cross-platform path.
(ShouldBuildTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMark test as flaky.
abarth@webkit.org [Wed, 25 Jan 2012 01:38:00 +0000 (01:38 +0000)]
Mark test as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and...
haraken@chromium.org [Wed, 25 Jan 2012 01:19:03 +0000 (01:19 +0000)]
webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Reviewed by David Kilzer.

Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().

This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.

* Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: new-run-webkit-httpd is broken
dpranke@chromium.org [Wed, 25 Jan 2012 01:03:34 +0000 (01:03 +0000)]
webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963

Reviewed by Adam Barth.

r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.

* Scripts/new-run-webkit-httpd:
(run):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogarden-o-matic pixel zoomer should let you look at every pixel of the image
abarth@webkit.org [Wed, 25 Jan 2012 00:56:23 +0000 (00:56 +0000)]
garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962

Reviewed by Ojan Vafai.

Previously, you couldn't get up to the right and bottom pixels.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClear some bogus executable bits that r105828 set.
mrowe@apple.com [Wed, 25 Jan 2012 00:27:07 +0000 (00:27 +0000)]
Clear some bogus executable bits that r105828 set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Linux-specific overrides.
abarth@webkit.org [Wed, 25 Jan 2012 00:22:31 +0000 (00:22 +0000)]
Add Linux-specific overrides.

* platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebHTMLView should implement typingAttributes methods to work correctly with the...
enrica@apple.com [Tue, 24 Jan 2012 23:58:42 +0000 (23:58 +0000)]
WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Source/WebKit/mac:

The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.

Reviewed by Alexey Proskuryakov.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.

Tools:

Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105829 268f45cc-cd09-0410-ab3c-d52691b4dbfc